Timeline
Jun 3, 2003:
- 7:45 PM Changeset in webkit [4478] by
-
- 3 edits in trunk/WebKit
WebKit:
Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
Reviewed by rjw.
- Misc.subproj/WebDownload.m: (-[WebDownload initWithRequest:delegate:]): (-[WebDownload _initWithRequest:delegate:directory:]):
- WebView.subproj/WebImageView.m: (-[WebImageView setNeedsDisplay:]):
- WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]):
WebBrowser:
Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
Reviewed by rjw.
- DownloadMonitor.m: (-[DownloadMonitor downloadDidBegin:]): (-[DownloadMonitor startDownloadForRequest:mayOpenWhenDone:]):
- DownloadProgressEntry.h:
- DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):
WebKitExamples:
Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
Reviewed by rjw.
- CarbonDownloader/CarbonURLDownload.mm: (CarbonURLDownload::CarbonURLDownload):
- Downloader/MyDocument.m: (-[MyDocument downloadOrCancel:]): (-[MyDocument savePanelDidEnd:returnCode:contextInfo:]): (-[MyDocument download:didFailWithError:]):
- 3:58 PM Changeset in webkit [4477] by
-
- 3 edits in trunk/WebKit
Fixed 3263188, 3274636.
Written by Ed Voas. Reviewed by Richard.
- Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): Ensure the process info is correctly initialized so the correct "flavour" (carbon) is detected.
- Carbon.subproj/HIWebView.m: (Draw): Always draw the growbox after drawing the web view, assuming overlap.
- 3:03 PM Changeset in webkit [4476] by
-
- 3 edits in trunk/WebCore
Fix for 3259647, crash when printing a table page. This is fixed
on the KDE KHTML trunk. The loop shouldn't be broken out of
when you have column elements so that all sections can recalc
their cell grids as needed.
Reviewed by kocienda
- khtml/rendering/render_table.cpp: (RenderTable::recalcSections):
- 2:46 PM Changeset in webkit [4475]
-
- 3 copies in tags/Safari-82
This commit was manufactured by cvs2svn to create tag 'Safari-82'.
- 2:46 PM Changeset in webkit [4474] by
-
- 8 edits in trunk
v82 stamp
- 2:36 PM Changeset in webkit [4473] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3167792>: hang in _web_dragPromisedImage dragging 4 MB image
Reviewed by john.
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:fileType:title:event:]): if the original image is greater than 1500x1500, use a file icon for the drag image to avoid hanging
- 12:47 PM Changeset in webkit [4472] by
-
- 8 edits in trunk/WebCore
Fixed 3275565. Ref count the decoder.
Reviewed by Ken.
- khtml/khtml_part.cpp: (KHTMLPart::clear):
- khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::~Decoder):
- khtml/misc/decoder.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl):
- khtml/xml/dom_docimpl.h:
Jun 2, 2003:
- 3:59 PM Changeset in webkit [4471] by
-
- 4 edits in trunk/WebKit
Fix for 3250352.
Reviewed by Chris.
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): Check respondsToSelector: before calling.
- WebView.subproj/WebResourceLoadDelegate.h:
- WebView.subproj/WebUIDelegate.h: Headerdoc tweaks.
- 3:41 PM Changeset in webkit [4470] by
-
- 3 edits in trunk/WebCore
Fix for 3276099. value() was wrong for radio buttons. Needed
to get it from the attribute since I was no longer caching
anything in m_value.
Reviewed by kocienda
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value):
- 2:29 PM Changeset in webkit [4469] by
-
- 3 edits in trunk/WebCore
Code written by darin
Reviewed by me
Fix for this bug:
<rdar://problem/3272162>: repro crash in khtml::CachedImage::checkNotify() on particular page
- khtml/ecma/kjs_html.cpp: (Image::putValue): ref onLoadListener when setting a value to onLoad (Image::~Image): deref onLoadListener when destructing the image.
- 2:12 PM Changeset in webkit [4468] by
-
- 4 edits in trunk/WebCore
Fix for 3263679, color: # doesn't parse. Fix is to add an
error-handling case for # by itself to parser.y.
Reviewed by gramps/ken
- khtml/css/parser.cpp:
- khtml/css/parser.y:
- 1:18 PM Changeset in webkit [4467] by
-
- 3 edits in trunk
v82u
- 12:47 PM Changeset in webkit [4466]
-
- 3 copies in tags/Safari-81
This commit was manufactured by cvs2svn to create tag 'Safari-81'.
- 12:47 PM Changeset in webkit [4465] by
-
- 8 edits in trunk
v81 stamp
- 11:42 AM Changeset in webkit [4464] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3256787 -- HOMEPAGE:\000 characters being added by Safarin in Form submission, causing an exception in property list parsing
- kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Encode \ as 5C instead of 815F when encoding Shift-JIS. This should make the Apple Store work again. The only thing we lose is the ability to send an actual Shift-JIS backslash (815F), but I think that is almost never needed. In other browsers you can't even type a backslash in Shift-JIS.
- 10:56 AM Changeset in webkit [4463] by
-
- 4 edits in trunk/WebKit
Fixed: <rdar://problem/3154910>: No video when viewing QT plug-in content at some pages but audio works
This fix works around QT plug-in bug 3275755, but I think the fix is logical and worth keeping even after 3275755 is fixed.
Eric Carlson:
The problem happens when you call NPP_SetWindow with a 0 width or height more than once. The first call to NPP_SetWindow always seems to have width and height set to 0, but the next call sometimes has it set to the correct values (those in the EMBED tag). This is when it draws successfully. It seems to me that the fix is to always pass the correct width and height to NPP_SetWindow. You always position the plug-in far offscreen (1000000, -52) and set the clip region to an empty rect (48576, 52, 48576, 52) so there isn't really any danger of the plug-in drawing anyway. Additionally, you pass the correct width and height in the call to NPP_New before the first call to NPP_SetWindow.
Reviewed by john, darin.
- Plugins.subproj/WebBaseNetscapePluginView.h:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): use the NSView width and height if greater than 0, else use the tag specified width and height (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): new (-[WebBaseNetscapePluginView setWindow]): NPP_SetWindow may be expensive, only call it if it has changed
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): tweak, no need to store error code since it is ignored
- 9:25 AM Changeset in webkit [4462] by
-
- 3 edits in trunk/WebCore
top level:
Reviewed by John
- configure.in: Removed unneeded configure-time checks for Foundation. Added check to see if there is a Foundation tree checked out. Added HAVE_FOUNDATION_SOURCES macro to config.h.
Tests:
Reviewed by John
Tweaked path in Makefile.am so that tests can find private
Foundation headers using new configure-time checks.
Modified tests to be "skippable" based on whether there is
a Foundation tree checked out and HAVE_FOUNDATION_SOURCES
is set in config.h.
Modified test harness so that it knows how to skip tests.
- CookieManager/Makefile.am:
- CookieManager/wkcookiemanager-test.m: (main):
- WebFoundation-Misc/Makefile.am:
- WebFoundation-Misc/ifnsarrayextensions-test.m: (main):
- WebFoundation-Misc/ifnscalendardateextensions-test.m: (main):
- WebFoundation-Misc/ifnsobjectextensions-test.m: (main):
- WebFoundation-Misc/ifnsstringextensions-test.m: (main):
- WebFoundation-Misc/ifnsurlextensions-test.m: (main):
- WebFoundation-Misc/ifreadwritelock-test.m: (main):
- WebFoundation-Misc/ifrecursivereadwritelock-test.m: (main):
- WebFoundation-Misc/ifurlparsing-test.m: (main):
- harness.c: (runtest):
WebCore:
Reviewed by NOBODY (OOPS!).
- config.h:
- 3:07 AM Changeset in webkit [4461] by
-
- 3 edits in trunk/WebCore
Fix for 3275136. Make sure that when the checked attribute
is set dynamically (something we were ignoring before my previous
patch) that we also properly update the radio button array in
the document.
Reviewed by gramps
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset):
May 30, 2003:
- 7:04 PM Changeset in webkit [4460] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris.
- fixed 3169067 - PEOPLESOFT: left frame missing; frame RenderRoot height and width are both zero
- khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
- 6:54 PM Changeset in webkit [4459] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3273544 - REGRESSION: Page disappears at http://www.urban-advantage.com/
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::getElementById): Return null when the ID is the empty string. Otherwise we'll return the first element in the document, usually the top-level HTML element, which is wrong and does not match other browsers.
- 5:37 PM Changeset in webkit [4458] by
-
- 11 edits in trunk
WebKit:
Fixed 3272516. Items are now expired from the
b/f cache if they are older than 30 minutes. This
number was pulled out of our #!$es. Also did
some cleanup of the b/f cache code.
Reviewed by Ken.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge saveDocumentToPageCache:]):
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _createPageCacheForItem:]): (-[WebFrame _setState:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
- WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences _resourceTimedLayoutEnabled]): (-[WebPreferences _backForwardCacheExpirationInterval]):
- WebView.subproj/WebPreferencesPrivate.h:
- WebView.subproj/WebView.h:
- WebView.subproj/WebPreferences.h: Cleaned up some headerdoc comments.
WebCore:
As part of some cleanup when fixing 3272516 changed use of
@"" for cache keys to NSString declarations.
Reviewed by Ken.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
- 4:21 PM Changeset in webkit [4457] by
-
- 6 edits in trunk/WebCore
Fix for 3269129 and 3269220. setAttribute('value') didn't work
for inputs. Basically defaultValue and defaultChecked have never
worked. This patch fixes the problem by making sure that for both
value and checked you have a two-tier system where you look first
for the value as altered by the control (or by setting the DOM
property) and if that isn't set then you look at the default value.
This allows setAttribute (which changes the *default*) to work in
the cases where the control has not overridden the default
with a different value.
Reviewed by NOBODY (OOPS!).
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::HTMLInputElementImpl): (HTMLInputElementImpl::state): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset): (HTMLInputElementImpl::setChecked): (HTMLInputElementImpl::value): (HTMLInputElementImpl::setValue): (HTMLInputElementImpl::isCheckedRadioButtonForDocument):
- khtml/html/html_formimpl.h:
- khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): (RenderLineEdit::calcMinMaxWidth): (RenderLineEdit::updateFromElement): (RenderLineEdit::slotTextChanged):
- khtml/rendering/render_form.h:
- 4:08 PM Changeset in webkit [4456] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
- added "sjis" as a synonym for "Shift_JIS"; this might fix 3235161, HOMEPAGE: Publishing page with Japanese characters w/ Safari generates an error, but I am currently unable to test the fix.
- kwq/mac-encodings.txt: Added sjis to the Shift_JIS line.
- kwq/KWQCharsetData.c: Regenerated.
- 10:41 AM Changeset in webkit [4455] by
-
- 4 edits in trunk/WebCore
Fix for 3263156, stack overflow at www.liceo.edu.mx. This
site nests about 500 bold tags, only closes some of them,
and then opens 500 more, etc.
The fix for this problem is to stop honoring tags in the parser
after you see 20 identical tags. We do this only for fontstyle HTML
tags.
Reviewed by john/darin
- khtml/html/htmlparser.cpp: (KHTMLParser::getElement): (KHTMLParser::allowNestedRedundantTag):
- khtml/html/htmlparser.h:
- 10:23 AM Changeset in webkit [4454] by
-
- 3 edits in trunk/WebCore
WebCore:
Reviewed by Chris
- khtml/rendering/break_lines.cpp: Removed #ifdef/#else for which the two sides were identical that I noticed in passing.
WebBrowser:
- fixed 3273444 -- Window title leaks when window is closed
Reviewed by Chris
- BrowserWindow.m: (-[BrowserWindow dealloc]): release _title here, because there's a leftover retain from the last setTitle to enable our delay-title-change-for-performance hack.
