Timeline
Jun 5, 2003:
- 12:24 PM Changeset in webkit [4490] by
-
- 1 edit in trunk/WebCore/khtml/html/html_headimpl.h
* empty log message *
- 12:05 PM Changeset in webkit [4489]
-
- 1 copy79 deletes in branches/unlabeled-1.35.18
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.18'.
- 12:05 PM Changeset in webkit [4488] by
-
- 4 edits in trunk/WebCore
Fix for 3281030, stylesheets can't be enabled properly via
script. Test case from Dirk. The fix is to make the setting
of the state happen independently of the attribute setting.
Reviewed by john
- khtml/dom/html_head.cpp: (HTMLLinkElement::setDisabled):
- khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setDisabledState): (HTMLLinkElementImpl::parseAttribute):
- khtml/html/html_headimpl.h:
- 11:36 AM Changeset in webkit [4487] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3268751>: REGRESSION: crash in KWQValueListImpl selecting connection speed at news.com
Reviewed by darin.
- kwq/KWQButton.mm: (QButton::clicked): Don't call clicked if the button was destroyed inside of sendConsumedMouseUpIfNeeded.
- 11:23 AM Changeset in webkit [4486] by
-
- 8 edits in trunk/WebKit
- fixed 3266216 -- repro crash in -[WebBaseResourceHandleDelegate connection:didReceiveData:] in GIA Application
The problem was that an NSURLConnection delegate object (in this
case a WebMainResourceClient) was being dealloc'ed during one of
its connection delegate methods. To prevent this kind of problem,
I added [self retain]/[self release] guards around the meat of
all of the connection delegate methods in which arbitrary code
could be run. Another approach would be to do this retain/release
pair in NSURLConnection, but Darin deemed it wiser not to muck with
Foundation at this point for this issue.
Reviewed by Darin
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): guard with [self retain]/[self release] (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto
- WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:didReceiveResponse:]): ditto (-[WebSubresourceClient connection:didReceiveData:]): ditto
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): ditto. Also, commented out two assertions that fire illegitimately in the steps in this bug report. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): ditto
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): ditto (-[WebMainResourceClient connection:didReceiveResponse:]): ditto (-[WebMainResourceClient connection:didReceiveData:]): ditto
- 9:47 AM Changeset in webkit [4485] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3279206 -- REGRESSION: new page does not load after selecting item from list and hitting 'Go' button
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding): Use value() in a couple of places that were still directly using m_value.
- 8:41 AM Changeset in webkit [4484] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3278079 -- REGRESSION: UTF-8 page claiming to be UTF-16 in XML header gives garbage characters
- khtml/misc/decoder.cpp: (Decoder::setEncoding): Add EncodingFromXMLHeader as one of the types where we know the encoding is an 8-bit one. The reason this is a regression is that we used to ignore the encoding in the XML header altogether.
Jun 4, 2003:
- 5:26 PM Changeset in webkit [4483] by
-
- 3 edits in trunk/WebCore
- fixed 3279957 -- REGRESSION: assertion failure at launch in Decoder::~Decoder() importing bookmarks
Richard actually wrote this fix.
Reviewed by me, Darin
- kwq/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]): don't use stack-based decoder; use new instead.
- 5:11 PM Changeset in webkit [4482] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Dave.
- fixed 3224031 -- can't search at rakuten.co.jp b/c of extra characters inserted by regexp replace (8-bit char)
Use PCRE UTF-8 regular expressions instead of just chopping off high bytes.
- kjs/regexp.h: Redo field names, remove some unused stuff.
- kjs/regexp.cpp: (convertToUTF8): Added. (compareStringOffsets): Added. (createSortedOffsetsArray): Added. (convertCharacterOffsetsToUTF8ByteOffsets): Added. (convertUTF8ByteOffsetsToCharacterOffsets): Added. (RegExp::RegExp): Set the PCRE_UTF8 flag, and convert the UString to UTF-8 instead of using ascii() on it. (RegExp::~RegExp): Remove unneeded if statement (pcre_free is 0-tolerant as free is). (RegExp::match): Convert the UString to UTF-8 and convert the character offsets to and from UTF-8 byte offsets. Also do fixes for the "no offset vector" case so we get the correct position and matched string.
- JavaScriptCore.pbproj/project.pbxproj: Add a PCRE header that was missing before.
- 3:59 PM Changeset in webkit [4481] by
-
- 3 edits in trunk/WebKit
Fixed 3277775. Send less notifications. Notifcations suck!
Reviewed by David.
- WebView.subproj/WebViewPrivate.h:
- WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate init]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]):
- 3:12 PM Changeset in webkit [4480] by
-
- 4 edits in trunk/WebKit
Reviewed by John.
- fixed 3277675 -- REGRESSION: mouse wheel events not coalesced
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSWindow nextEventMatchingMask:untilDate:inMode:dequeue:]): When the mask is scroll wheel mask, instead of getting no events, do some tricks to get the next event if it is a scroll wheel event, and nothing otherwise. Also ifdef the fix so we don't compile it on Panther, since the underlying bug was fixed on Panther.
- other changes
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): Remove unneeded line of code. The super function copies all simple fields for us.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setMIMEType:]): Use copy instead of retain, do it in the right order to avoid "same object release/retain" disease. (-[WebBaseNetscapePluginView setBaseURL:]): Do retain before release (same reason as above).
- 1:35 PM Changeset in webkit [4479] by
-
- 3 edits in trunk/WebCore
Fix for 3273300, leaks in cssyyparse. Function forgot to delete
its args value list when destroyed.
Reviewed by gramps
- khtml/css/cssparser.h:
Jun 3, 2003:
- 7:45 PM Changeset in webkit [4478] by
-
- 3 edits in trunk/WebKit
WebKit:
Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
Reviewed by rjw.
- Misc.subproj/WebDownload.m: (-[WebDownload initWithRequest:delegate:]): (-[WebDownload _initWithRequest:delegate:directory:]):
- WebView.subproj/WebImageView.m: (-[WebImageView setNeedsDisplay:]):
- WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]):
WebBrowser:
Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
Reviewed by rjw.
- DownloadMonitor.m: (-[DownloadMonitor downloadDidBegin:]): (-[DownloadMonitor startDownloadForRequest:mayOpenWhenDone:]):
- DownloadProgressEntry.h:
- DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):
WebKitExamples:
Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
Reviewed by rjw.
- CarbonDownloader/CarbonURLDownload.mm: (CarbonURLDownload::CarbonURLDownload):
- Downloader/MyDocument.m: (-[MyDocument downloadOrCancel:]): (-[MyDocument savePanelDidEnd:returnCode:contextInfo:]): (-[MyDocument download:didFailWithError:]):
- 3:58 PM Changeset in webkit [4477] by
-
- 3 edits in trunk/WebKit
Fixed 3263188, 3274636.
Written by Ed Voas. Reviewed by Richard.
- Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): Ensure the process info is correctly initialized so the correct "flavour" (carbon) is detected.
- Carbon.subproj/HIWebView.m: (Draw): Always draw the growbox after drawing the web view, assuming overlap.
- 3:03 PM Changeset in webkit [4476] by
-
- 3 edits in trunk/WebCore
Fix for 3259647, crash when printing a table page. This is fixed
on the KDE KHTML trunk. The loop shouldn't be broken out of
when you have column elements so that all sections can recalc
their cell grids as needed.
Reviewed by kocienda
- khtml/rendering/render_table.cpp: (RenderTable::recalcSections):
- 2:46 PM Changeset in webkit [4475]
-
- 3 copies in tags/Safari-82
This commit was manufactured by cvs2svn to create tag 'Safari-82'.
- 2:46 PM Changeset in webkit [4474] by
-
- 8 edits in trunk
v82 stamp
- 2:36 PM Changeset in webkit [4473] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3167792>: hang in _web_dragPromisedImage dragging 4 MB image
Reviewed by john.
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:fileType:title:event:]): if the original image is greater than 1500x1500, use a file icon for the drag image to avoid hanging
- 12:47 PM Changeset in webkit [4472] by
-
- 8 edits in trunk/WebCore
Fixed 3275565. Ref count the decoder.
Reviewed by Ken.
- khtml/khtml_part.cpp: (KHTMLPart::clear):
- khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::~Decoder):
- khtml/misc/decoder.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl):
- khtml/xml/dom_docimpl.h:
Jun 2, 2003:
- 3:59 PM Changeset in webkit [4471] by
-
- 4 edits in trunk/WebKit
Fix for 3250352.
Reviewed by Chris.
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): Check respondsToSelector: before calling.
- WebView.subproj/WebResourceLoadDelegate.h:
- WebView.subproj/WebUIDelegate.h: Headerdoc tweaks.
- 3:41 PM Changeset in webkit [4470] by
-
- 3 edits in trunk/WebCore
Fix for 3276099. value() was wrong for radio buttons. Needed
to get it from the attribute since I was no longer caching
anything in m_value.
Reviewed by kocienda
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value):
- 2:29 PM Changeset in webkit [4469] by
-
- 3 edits in trunk/WebCore
Code written by darin
Reviewed by me
Fix for this bug:
<rdar://problem/3272162>: repro crash in khtml::CachedImage::checkNotify() on particular page
- khtml/ecma/kjs_html.cpp: (Image::putValue): ref onLoadListener when setting a value to onLoad (Image::~Image): deref onLoadListener when destructing the image.
- 2:12 PM Changeset in webkit [4468] by
-
- 4 edits in trunk/WebCore
Fix for 3263679, color: # doesn't parse. Fix is to add an
error-handling case for # by itself to parser.y.
Reviewed by gramps/ken
- khtml/css/parser.cpp:
- khtml/css/parser.y:
- 1:18 PM Changeset in webkit [4467] by
-
- 3 edits in trunk
v82u
- 12:47 PM Changeset in webkit [4466]
-
- 3 copies in tags/Safari-81
This commit was manufactured by cvs2svn to create tag 'Safari-81'.
- 12:47 PM Changeset in webkit [4465] by
-
- 8 edits in trunk
v81 stamp
- 11:42 AM Changeset in webkit [4464] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3256787 -- HOMEPAGE:\000 characters being added by Safarin in Form submission, causing an exception in property list parsing
- kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Encode \ as 5C instead of 815F when encoding Shift-JIS. This should make the Apple Store work again. The only thing we lose is the ability to send an actual Shift-JIS backslash (815F), but I think that is almost never needed. In other browsers you can't even type a backslash in Shift-JIS.
- 10:56 AM Changeset in webkit [4463] by
-
- 4 edits in trunk/WebKit
Fixed: <rdar://problem/3154910>: No video when viewing QT plug-in content at some pages but audio works
This fix works around QT plug-in bug 3275755, but I think the fix is logical and worth keeping even after 3275755 is fixed.
Eric Carlson:
The problem happens when you call NPP_SetWindow with a 0 width or height more than once. The first call to NPP_SetWindow always seems to have width and height set to 0, but the next call sometimes has it set to the correct values (those in the EMBED tag). This is when it draws successfully. It seems to me that the fix is to always pass the correct width and height to NPP_SetWindow. You always position the plug-in far offscreen (1000000, -52) and set the clip region to an empty rect (48576, 52, 48576, 52) so there isn't really any danger of the plug-in drawing anyway. Additionally, you pass the correct width and height in the call to NPP_New before the first call to NPP_SetWindow.
Reviewed by john, darin.
- Plugins.subproj/WebBaseNetscapePluginView.h:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): use the NSView width and height if greater than 0, else use the tag specified width and height (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): new (-[WebBaseNetscapePluginView setWindow]): NPP_SetWindow may be expensive, only call it if it has changed
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): tweak, no need to store error code since it is ignored
- 9:25 AM Changeset in webkit [4462] by
-
- 3 edits in trunk/WebCore
top level:
Reviewed by John
- configure.in: Removed unneeded configure-time checks for Foundation. Added check to see if there is a Foundation tree checked out. Added HAVE_FOUNDATION_SOURCES macro to config.h.
Tests:
Reviewed by John
Tweaked path in Makefile.am so that tests can find private
Foundation headers using new configure-time checks.
Modified tests to be "skippable" based on whether there is
a Foundation tree checked out and HAVE_FOUNDATION_SOURCES
is set in config.h.
Modified test harness so that it knows how to skip tests.
- CookieManager/Makefile.am:
- CookieManager/wkcookiemanager-test.m: (main):
- WebFoundation-Misc/Makefile.am:
- WebFoundation-Misc/ifnsarrayextensions-test.m: (main):
- WebFoundation-Misc/ifnscalendardateextensions-test.m: (main):
- WebFoundation-Misc/ifnsobjectextensions-test.m: (main):
- WebFoundation-Misc/ifnsstringextensions-test.m: (main):
- WebFoundation-Misc/ifnsurlextensions-test.m: (main):
- WebFoundation-Misc/ifreadwritelock-test.m: (main):
- WebFoundation-Misc/ifrecursivereadwritelock-test.m: (main):
- WebFoundation-Misc/ifurlparsing-test.m: (main):
- harness.c: (runtest):
WebCore:
Reviewed by NOBODY (OOPS!).
- config.h:
- 3:07 AM Changeset in webkit [4461] by
-
- 3 edits in trunk/WebCore
Fix for 3275136. Make sure that when the checked attribute
is set dynamically (something we were ignoring before my previous
patch) that we also properly update the radio button array in
the document.
Reviewed by gramps
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset):
