Timeline
Jun 15, 2003:
- 6:11 PM Changeset in webkit [4560]
-
- 3 copies in tags/Safari-85~1
This commit was manufactured by cvs2svn to create tag 'Safari-85~1'.
- 6:11 PM Changeset in webkit [4559] by
-
- 5 edits in trunk
changelog markers for 85.1
- 5:09 PM Changeset in webkit [4558] by
-
- 5 edits in trunk
WebCore:
Reviewed by darin.
- WebCore.pbproj/project.pbxproj: remove SECTORDER_FLAGS variable, so that we don't use order file for our Panther submission
WebKit:
Reviewed by darin.
- WebKit.pbproj/project.pbxproj: remove SECTORDER_FLAGS variable, so that we don't use order file for our Panther submission
WebBrowser:
Reviewed by darin.
- WebBrowser.pbproj/project.pbxproj: remove SECTORDER_FLAGS variable, so that we don't use order file for our Panther submission
Jun 14, 2003:
- 6:27 PM Changeset in webkit [4557]
-
- 3 copies2 deletes in branches/WebCore-85-tarball-branch
This commit was manufactured by cvs2svn to create branch
'WebCore-85-tarball-branch'.
- 6:27 PM Changeset in webkit [4556]
-
- 3 copies2 deletes in tags/WebCore-85-tarball-anchor
This commit was manufactured by cvs2svn to create tag
'WebCore-85-tarball-anchor'.
- 6:27 PM Changeset in webkit [4555]
-
- 3 copies in tags/Safari-85
This commit was manufactured by cvs2svn to create tag 'Safari-85'.
- 6:27 PM Changeset in webkit [4554]
-
- 1 copy2 deletes in branches/JavaScriptCore-85-tarball-branch
This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-85-tarball-branch'.
- 6:27 PM Changeset in webkit [4553]
-
- 1 copy2 deletes in tags/JavaScriptCore-85-tarball-anchor
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-85-tarball-anchor'.
- 6:27 PM Changeset in webkit [4552] by
-
- 8 edits in trunk
Safari-85 version stamp
- 3:39 PM Changeset in webkit [4551] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3293367>: REGRESSION (83-84): nil-deref in addMetaData loading page in pop-up at live365.com
Reviewed by darin.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): only call addMetaData if didOpenURL
Jun 13, 2003:
- 9:44 PM Changeset in webkit [4550] by
-
- 3 edits in trunk/WebCore
Reviewed by Don.
- fixed 3293031 -- REGRESSION (83-84): extra entry in history when going to page that redirects (live365.com)
- khtml/khtmlpart_p.h: Initialize m_executingJavaScriptFormAction to false. We had left it uninitialized when we fixed 3289047.
- 9:32 PM Changeset in webkit [4549] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin (Richard wrote the first cut), then Don and Dave.
- fixed 3291467 -- CARBON: context menus are broken when using WebKit from Carbon
- Carbon.subproj/HIWebView.m: (ContextMenuClick): Rewrite method to create a fake right mouse up event, and pass that to menuForEvent: and _popUpMenuWithEvent.
- 8:10 PM Changeset in webkit [4548] by
-
- 4 edits in trunk/WebCore
Fix for 3292630, misrendered page because of bad doctype. Add
this bad doctype to our list of quirky doctypes to fix the
problem, since the screwed up strict mode rendering is actually
correct.
Reviewed by john
- khtml/html/doctypes.cpp: (findDoctypeEntry):
- khtml/html/doctypes.gperf:
- 7:12 PM Changeset in webkit [4547] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Dave.
- fixed 3178438 -- return elements in order of addition in for..in loop (other browsers seem to)
- fixed 3292067 -- REGRESSION (64-65): albertsons.com "Shop A to Z" menus are not sorted alphabetically
- kjs/property_map.h: Add index field to hash table entry and index parameter to insert function.
- kjs/property_map.cpp: (PropertyMap::put): Set an index for new map entries to an ever-increasing number based on a global. (PropertyMap::insert): Take an index parameter. (PropertyMap::expand): Preserve the indices as we rehash the table. (comparePropertyMapEntryIndices): Added. Compares two property map entries by index. (PropertyMap::addEnumerablesToReferenceList): Sort the proprty map entries by index before adding them to the reference list.
- 5:46 PM Changeset in webkit [4546] by
-
- 3 edits in trunk/WebKit
Reviewed by Chris.
- fixed 3291778 -- REGRESSION (51-52): QT controller never shows up for mp3 in frame
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Handle the "invisible" plug-in cases in a more complete way. Detect the various ways of being invisible (big negative X value, 0 size, not really in a window) and in all those cases, use a clip rect to guarantee we won't be seen, and make sure the size passed to the plug-in is *not* 0.
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
- 2:13 PM Changeset in webkit [4545] by
-
- 4 edits in trunk/WebCore
Fixed 3282087. Don't use our <pre> optimizations
if text contains non-ascii, and consequently may
result in font substitution.
- 2:11 PM Changeset in webkit [4544] by
-
- 3 edits in trunk/WebKit
Fix for 3291319, scrolling is much worse since 79. The problem
was a fix for resize events that needed to use the scrollview size
and not the document view size inside the scrollview.
Reviewed by darin
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]):
- WebView.subproj/WebHTMLViewPrivate.h:
- 12:03 PM Changeset in webkit [4543] by
-
- 1 edit in trunk/WebKit/ChangeLog
Fixed previous " Reviewed by" string.
- ChangeLog:
- 12:01 PM Changeset in webkit [4542] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3291502>: REGRESSION (80-81): freebsd.org is giving us gzipped content (because we stopped spoofing)
Reviewed by darin.
- WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry):
- WebView.subproj/WebUserAgentSpoofTable.gperf:
- 11:51 AM Changeset in webkit [4541] by
-
- 3 edits in trunk/WebCore
Fixed 3291537.
Reviewed by John.
- kwq/KWQObject.mm: (QObject::killTimer): Only remove the timer is it hasn't fired (and is therefore valid). It is NOT permissible to reference a timer's userInfo if it is invalid.
Jun 12, 2003:
- 10:58 PM Changeset in webkit [4540] by
-
- 3 edits in trunk/WebKit
Restoring fix for 3221078 that I earlier backed out in a
panic about performance. In careful performance testing
I now see no performance regression, and maybe a tiny improvement.
The earlier performance regression Vicki saw was entirely
due to the incorrect checkin for the fix to 3288532.
Reviewed by Chris & Gramps.
- WebCoreSupport.subproj/WebTextRenderer.h:
- WebCoreSupport.subproj/WebTextRenderer.m:
- 10:22 PM Changeset in webkit [4539] by
-
- 2 edits in trunk/WebKit
Correct fix for 3288532 again. This time will feeling!
Reviewed by Gramps.
- History.subproj/WebBackForwardList.m: (-[WebBackForwardList setCapacity:]):
- 9:29 PM Changeset in webkit [4538] by
-
- 2 edits in trunk/WebKit
Since Richard didn't actually correct the fix for 3288532 in
WebBackForwardList.m, I've backed out out his original fix entirely.
- History.subproj/WebBackForwardList.m: (-[WebBackForwardList setCapacity:]):
- 7:24 PM Changeset in webkit [4537] by
-
- 1 edit in trunk/WebKit/ChangeLog
Correct fix for 3288532.
- History.subproj/WebBackForwardList.m:
- 7:09 PM Changeset in webkit [4536] by
-
- 2 edits in trunk/WebKit/WebCoreSupport.subproj
Back out change for 3221078 pending further testing.
- 6:25 PM Changeset in webkit [4535] by
-
- 2 edits in trunk/WebKit
Fixed 3288532. When setCapacity: shrinks capacity, trim
the back/forward list. Setting to zero will effectively
flush the list.
Reviewed by John.
- History.subproj/WebBackForwardList.m:
- 6:22 PM Changeset in webkit [4534] by
-
- 3 edits in trunk/WebKit
Fixed 3221078. Maintain a separate width map
for substitute fonts to avoid collision of glyph
codes.
Reviewed by Chris & Gramps.
- WebCoreSupport.subproj/WebTextRenderer.h:
- WebCoreSupport.subproj/WebTextRenderer.m:
- 2:01 PM Changeset in webkit [4533] by
-
- 3 edits in trunk
Safari-85u version, but the tree's not really open.
- 1:11 PM Changeset in webkit [4532]
-
- 3 copies in tags/Safari-84
This commit was manufactured by cvs2svn to create tag 'Safari-84'.
- 1:11 PM Changeset in webkit [4531] by
-
- 8 edits in trunk
Safari-84 stamp
- 11:00 AM Changeset in webkit [4530] by
-
- 5 edits in trunk/WebCore
Fix for 3289113, body.scrollTop doesn't return the right
value. Fix scrollLeft and scrollTop for body tags to just
use the view's offset. This matches WinIE behavior.
Reviewed by john
- khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::putValue):
- khtml/ecma/kjs_html.h:
- khtml/ecma/kjs_html.lut.h:
- 10:19 AM Changeset in webkit [4529] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3289405 -- repro crash in KWQPopUpButtonCell at umax.de
- kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Use the bridge that we got earlier in the function to find the right part. This is simpler, and more reliable. The old way would run into trouble if the widget or any of the other objects in the chain got destroyed during the event handling.
- 9:43 AM Changeset in webkit [4528] by
-
- 10 edits in trunk
WebCore:
Fixed by Richard, reviewed by me.
- fixed 3289047 -- REGRESSION: can't go back after using form at attwireless.com
- khtml/khtmlpart_p.h: Add an "executing JavaScript form action" flag.
- kwq/WebCoreBridge.h: Add an "executing JavaScript form action" flag parameter to the reportClientRedirectToURL method.
- khtml/khtml_part.cpp: (KHTMLPart::submitForm): In the JavaScript case, set a flag to say we are executing a JavaScript form action.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Pass the isJavaScriptFormAction state over the bridge.
WebKit:
Fixed by Richard, reviewed by me.
- fixed 3289047 -- REGRESSION: can't go back after using form at attwireless.com
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Added isJavaScriptFormAction parameter, passed on to frame.
- WebView.subproj/WebFramePrivate.h: Added isJavaScriptFormAction parameter.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): If isJavaScriptFormAction is YES, then don't treat this is a "quick redirect" which is merged with the previous page for purposes of back/forward.
Jun 11, 2003:
- 6:13 PM Changeset in webkit [4527] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3289577>: Reenable Carbon Java plug-ins when in Carbon app
Reviewed by gramps.
- Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): only call canUsePlugin: for web plug-ins
- 5:22 PM Changeset in webkit [4526] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3289380>: REGRESSION: policyDataSource == nil assertion failure after closing particular window
Reviewed by john.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): don't clear policyDataSource here because this method may not be called during navigation (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): clear policyDataSource here
- 3:57 PM Changeset in webkit [4525] by
-
- 6 edits in trunk/WebCore
Fix for 3288875, :after/:before content not getting destroyed
after printing on alistapart.com. Make the update method for
pseudos smart enough to destroy generated content when it is
no longer needed.
Reviewed by darin
- khtml/rendering/render_block.cpp: (RenderBlock::setStyle);
- khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
- khtml/rendering/render_container.h:
- khtml/rendering/render_inline.cpp: (RenderInline::setStyle):
- 3:48 PM Changeset in webkit [4524] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3288097>: REGRESSION: assertion failure after hitting back while loading page after fragment scroll
Fixed by darin, reviewed by me.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _URLsMatchItem:]): ignore the URL fragment so we scroll back at the current page instead of attempt to load the current page
- 1:51 PM Changeset in webkit [4523] by
-
- 4 edits in trunk/WebCore
Fix for 3288035, the wrong value was being filled in for
textfields. Fixed a bug in QString's assignment operator
that made empty strings become null strings upon assignment.
Also ensured that the form control never sets the value to
null but always uses empty instead.
Reviewed by john
- khtml/rendering/render_form.cpp: (RenderLineEdit::slotTextChanged):
- kwq/KWQString.mm: (QString::setLatin1):
- 10:37 AM Changeset in webkit [4522] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed 3285808 -- repro world leak when replacing div that contains iframe (at www.kbs.co.kr)
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]): Add a call to _detachFromParent.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _removeChild:]): Nil out the parent pointer in the removed child.
- 9:18 AM Changeset in webkit [4521] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3288076>: REGRESSION: Fragment scroll stops page load
We do policy navigation checks for the regular load case, fragment scroll and redirects.
We only want to stop the load, change the provisional data source etc in the regular load case.
Reviewed by darin.
- WebView.subproj/WebFramePrivate.m: got rid of _prepareForProvisionalLoadWithDataSource:: since the work done in this method only needs to be done in _continueLoadRequestAfterNavigationPolicy:: (which covers the regular load case).
- (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): …
- (-[WebFrame _setPolicyDataSource:]): new (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): don't call _prepareForProvisionalLoadWithDataSource::, don't muck with policyDataSource because it is only needed in the regular load case (-[WebFrame _continueAfterNavigationPolicy:]): don't call _prepareForProvisionalLoadWithDataSource::, call _setPolicyDataSource:nil after _continueLoadRequestAfterNavigationPolicy:: has used policyDataSource
- (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): …
- (-[WebFrame _loadDataSource:withLoadType:formState:]): set the policyLoadType and policyDataSource (the beginning of the regular load case)
