Context Navigation

kwq/KWQTextCodec.mm: (KWQTextDecoder::createTECConverter): Added. Broken out from convertUsingTEC. (KWQTextDecoder::appendOmittingBOMs): Added. Broken out from convertUsingTEC. (KWQTextDecoder::convertOneChunkUsingTEC): Added. Broken out from convertUsingTEC. This also has much of the partially-decoded character handling. (KWQTextDecoder::convertUsingTEC): Simplified by breaking into functions, and added handling to use the same buffer we use for the other decoders to hold partially-decoded characters. (KWQTextDecoder::convert): Add a partial-character handling test mode where the decoder is passed only a single byte at a time; controlled by an #if.

2:40 PM Changeset in webkit [4639] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

do some improvements Maciej suggested while reviewing the array index change

kjs/array_object.cpp: (getArrayIndex): Return a flag to say whether the index was value separately, to avoid in-band signalling. (ArrayInstanceImp::get): Update for new getArrayIndex parameters. (ArrayInstanceImp::put): Ditto. (ArrayInstanceImp::hasProperty): Ditto. (ArrayInstanceImp::setLength): Ditto.

kjs/ustring.cpp: (UString::toStrictUInt32): Check for overflow in a way that avoids doing a divide every time through the loop. But note that it adds an extra branch to the loop. I wonder which is worse.

2:40 PM Changeset in webkit [4638] by darin

2 edits in trunk/WebKit

WebKit.pbproj/project.pbxproj: Add command to prevent build from failing if symlink creation fails.

2:31 PM Changeset in webkit [4637] by darin

2 edits in trunk/WebKit

Fixed symbolic link path as Matt Reda suggested.

WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases to use Versions/Current instead of Versions/A.

9:29 AM Changeset in webkit [4636] by darin

2 edits in trunk/WebKit

Fixed DSTROOT path as Eric Weiss suggested.

WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases.

Jul 12, 2003:

11:30 PM Changeset in webkit [4635]

3 copies
2 deletes in tags/WebKit-89~1

This commit was manufactured by cvs2svn to create tag 'WebKit-89~1'.

11:30 PM Changeset in webkit [4634] by mjs

2 edits in branches/Safari-89-branch/WebKit

Try to fix OS build by making the Frameworks link in both SYMROOT
and DSTROOT, and at both build time and install time.

WebKit.pbproj/project.pbxproj:

11:23 PM Changeset in webkit [4633] by mjs

2 edits in trunk/WebKit

Try to fix OS build by making the Frameworks link in both SYMROOT
and DSTROOT, and at both build time and install time.

WebKit.pbproj/project.pbxproj:

5:10 PM Changeset in webkit [4632] by hyatt

6 edits in trunk/WebCore

Fix for 3187101, before/after content not dynamic. This patch
compares the ContentData of the old style and the new style and
if they are different, it blows away and recreates the render
objects for the generated content. Otherwise it will dynamically
update the styles of the generated content render objects (which
should fix the printer/screen bug for rjw).

Note that createObject had an extra call to setStyle, which was
causing most objects to set the same style context on themselves
twice. This was exposed as I was fixing the above problem.

Reviewed by darin

ChangeLog:
khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
khtml/rendering/render_object.cpp: (RenderObject::createObject):
khtml/rendering/render_style.cpp: (RenderStyle::contentDataEquivalent):
khtml/rendering/render_style.h:

11:53 AM Changeset in webkit [4631] by darin

3 edits in trunk/JavaScriptCore

Fixed broken build.

kjs/identifier.h: Add toULong back. It's still used in WebCore (and maybe in JavaScriptGlue, for all I know).

9:01 AM Changeset in webkit [4630] by darin

6 edits in trunk/JavaScriptCore

Reviewed by Dave.

fixed 3272777 -- array object indices treated as integers by Safari, but as strings in other web browsers

JavaScriptCore did not implement the proper rule for what an array index is.

kjs/array_object.cpp: (getArrayIndex): Added. Implements the rule from the specification, which also provides a handy "not an array index" value of 2^{32-1.
(ArrayInstanceImp::get): Use getArrayIndex.
(ArrayInstanceImp::put): Ditto.
(ArrayInstanceImp::hasProperty): Ditto.
(ArrayInstanceImp::setLength): Ditto.}

kjs/identifier.h: Removed now-unused toULong, and added toStrictUInt32, in both cases forwarding functions that forward to UString.

kjs/ustring.h: Added toStringUInt32.
kjs/ustring.cpp: (UString::toStrictUInt32): Added. Converts a string to a 32-bit unsigned integer, and rejects any string that does not exactly match the way the integer would be formatted on output. This is the rule documented in the ECMA language standard.

Jul 11, 2003:

5:36 PM Changeset in webkit [4629] by hyatt

9 edits in trunk/WebCore

Fix pseudostyles to inherit from the element's style that they are
specified for. This is incorrect both for ::first-line and
::first-letter, but it is at least right for ::before and ::after.

Fix iframes and objects and embeds so that they will render borders
when borders are specified (as well as background images).

Patch iframes so that they correctly let the parent document's
background show through when the Web page inside the iframe has
no specified background. Also patched iframes to understand not
to blit in this case and to not blit when opacity has been specified
on the iframe.

Reviewed by darin

khtml/css/cssstyleselector.cpp:
khtml/khtmlview.h:
khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations):
khtml/rendering/render_canvas.cpp:
khtml/rendering/render_form.cpp: (RenderFormElement::setStyle):
khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth): (RenderWidget::setStyle): (RenderWidget::paintObject):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):

3:38 PM Changeset in webkit [4628] by darin

8 edits in trunk/WebCore

Reviewed by Ken.

roll in change from KHTML to remove user and password from referrer

khtml/khtml_part.cpp: (KHTMLPart::begin): Call setUser(""), setPass(""), and setRef(""), then also set the referrer to "" if the protocol does not start with http.

kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Remove check to exclude file URL referrers because KHTMLPart now excludes all non-http referrers.

kwq/KWQKURL.h: Add setUser and setPass functions. Also sort by order within the URL so it's clear no methods are omitted.
kwq/KWQKURL.mm: (KURL::setUser): Added. Adds or removes the username, adding or removing delimiters as needed. For now only the remove part is compiled in. (KURL::setPass): Added. Adds or removes a password, adding or removing delimiters as needed. For now only the remove part is compiled in.

kwq/KWQString.h: Add QSTRING_NULL macro to allow us to work around the fact that there is no global QString::null object in KWQ without having to do a relatively ineffecient conversion from a non-constant char * of 0 each time. We can use this anywhere QString::null appears and perhaps get some small code savings or performance boost.

small cleanup

kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Remove unneeded checks that repeat optimizations I already put in QString.

11:41 AM Changeset in webkit [4627] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

added a function Dave needs for various work he's doing that goes from a document to the corresponding element in the parent document

khtml/xml/dom_docimpl.h: Add ownerElement member function.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement): Added. Gets to the parent part and finds the right element.

10:55 AM Changeset in webkit [4626] by hyatt

19 edits in trunk/WebCore

An initial implementation of the CSS opacity property. Seems
to work perfectly except for native widgetry (NSViews). Images,
text, borders, and underlines are all properly blended.

Reviewed by rjw

config.h:
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::adjustZIndex):
khtml/rendering/render_box.h:
khtml/rendering/render_inline.h:
khtml/rendering/render_layer.cpp: (RenderLayer::transparentAncestor): (RenderLayer::isTransparent): (commonTransparentAncestor): (RenderLayer::updateTransparentState): (RenderLayer::beginTransparencyLayers): (RenderLayer::endTransparencyLayers): (RenderLayer::paint):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.h:
khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (RenderStyle::diff):
khtml/rendering/render_style.h:
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::beginTransparencyLayer): (QPainter::endTransparencyLayer):

10:54 AM Changeset in webkit [4625] by hyatt

2 edits in trunk/WebKit

Make sure image compositing obeys the current global alpha that
is in effect, e.g., if someone has set an opacity within the
current layer.

It's worth noting that I'm not even sure *why* this patch works,
but it does, even with nested opacity layers.

Reviewed by darin

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):

9:24 AM Changeset in webkit [4624] by darin

5 edits in trunk/WebCore

Reviewed by Chris.

fixed 3305391 -- repro crash in QPixmap::QPixmap after click in SVG using Adobe SVG plugin

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Remove code that tried to determine if something is an image by looking at the node type. Instead look at the object in the render tree and ask it if it's an image. Also use logic that exactly matches what RenderImage uses.

kwq/KWQDOMNode.h: Remove unused isImage function.
kwq/KWQDOMNode.cpp: Ditto.

8:24 AM Changeset in webkit [4623] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed 3300220 -- repro crash in closeURL when choosing from popup menus on www.drivewire.com

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Removed unused local variable. Since we update all documents, there was no longer any need to keep that pointer around, but we still had this obsolete code. This had nothing to do with the bug, just a related cleanup. (NodeImpl::dispatchWindowEvent): Add check for nil. We ref the document pointer, but we don't ref the document itself. So we do need to check for the case where the document went away.

1:01 AM Changeset in webkit [4622] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3217731 -- after going back to a page, forms are submitted with the wrong encoding (back/forward cache)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Put decoder from document into the part.

Jul 10, 2003:

11:23 PM Changeset in webkit [4621] by darin

2 edits in trunk/WebCore

Removed stray conflict marker.

6:03 PM Changeset in webkit [4620]

1 copy
2 deletes in branches/Safari-89-branch

This commit was manufactured by cvs2svn to create branch
'Safari-89-branch'.

6:03 PM Changeset in webkit [4619]

1 copy
2 deletes in tags/Safari-89-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-89-anchor'.

6:03 PM Changeset in webkit [4618]

3 copies in tags/Safari-89

This commit was manufactured by cvs2svn to create tag 'Safari-89'.

6:03 PM Changeset in webkit [4617] by vicki

8 edits in trunk

Safari-89 stamp

4:38 PM Changeset in webkit [4616] by rjw

2 edits in trunk/WebKit

Fixed 3298153. Force use of printer font when printing.

Reviewed by Chris.

WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs):

2:31 PM Changeset in webkit [4615] by cblu

5 edits in trunk/WebKit

Fixed: <rdar://problem/3161102>: Avoid retain cycles by destroying plug-ins in the page cache before dealloc
Fixed: <rdar://problem/3320624>: WebElementImageAltStringKey is not exported :-(
Unspoof freebsd since we now handle gzip'd content.

Reviewed by rjw.

History.subproj/WebHistoryItem.m: (+[WebHistoryItem _destroyAllPluginsInPendingPageCaches]): new, destroys all plug-ins (+[WebHistoryItem _releaseAllPendingPageCaches]): call _destroyAllPluginsInPendingPageCaches
WebKit.exp: export WebElementImageAltStringKey
WebView.subproj/WebUserAgentSpoofTable.c: unspoof freebsd (hash): (_web_findSpoofTableEntry):
WebView.subproj/WebUserAgentSpoofTable.gperf: unspoof freebsd

2:18 PM Changeset in webkit [4614]

1 copy
319 deletes in branches/unlabeled-1.4.14

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.4.14'.

2:18 PM Changeset in webkit [4613]

1 copy
319 deletes in branches/unlabeled-1.11.14

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.11.14'.

2:18 PM Changeset in webkit [4612] by mjs

14 edits in trunk

JavaScriptCore:

Reviewed by Darin.

fixed 3302021 - v74 and v85 hang with http://e-www.motorola.com/

The crux of this was saving and restoring the prototype objects
for all the standard types when saving and restoring for the page
cache.

kjs/internal.cpp: (InterpreterImp::saveBuiltins): (InterpreterImp::restoreBuiltins):
kjs/internal.h:
kjs/interpreter.cpp: (Interpreter::saveBuiltins): (Interpreter::restoreBuiltins): (SavedBuiltins::SavedBuiltins): (SavedBuiltins::~SavedBuiltins):
kjs/interpreter.h:
kjs/property_map.cpp:

WebCore:

Reviewed by Darin.

fixed 3302021 - v74 and v85 hang with http://e-www.motorola.com/
fixed a bug with saving and restoring location object properties

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveLocationProperties): Save the location object's properties, not the window's (!) (KWQKHTMLPart::saveInterpreterBuiltins): New function to save builtin properties of the interpeter. (KWQKHTMLPart::restoreInterpreterBuiltins): Similarly to restore them. (KWQKHTMLPart::openURLFromPageCache): Restore interpreter builtins too.
kwq/KWQPageState.h:
kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): Handle interpreter builtins. (-[KWQPageState invalidate]): Likewise. (-[KWQPageState dealloc]): Likewise. (-[KWQPageState interpreterBuiltins]): New method.
kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Handle interpeter builtins.

2:01 PM Changeset in webkit [4611] by sullivan

2 edits in trunk/WebKit

WebKit:

Reviewed by Chris

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): fixed copy/paste error in comment that I stumbled across

WebBrowser:

fixed 3320957 -- Selecting Edit Contents should reveal as much of the folder's contents as fit in the window

Reviewed by Chris

BookmarksViewController.m: (-[BookmarksViewController revealBookmark:expand:]): When revealing and expanding a folder, reveal the last visible descendant before the folder, to force the folder higher up if necessary.

11:55 AM Changeset in webkit [4610] by darin

3 edits in trunk/WebCore

top level:

Reviewed by Chris.

acconfig.h: Removed. The new autoconf in Panther doesn't need it.
configure.in: Removed HAVE_S_ISSOCK code; none of our code needs this define and it upsets the new autoconf if we leave out acconfig.h.

WebCore:

Reviewed by Chris.

config.h: Check in newly generated version which has changed due to changes in configure.in.

11:49 AM Changeset in webkit [4609] by darin

3 edits in trunk/WebCore

Reviewed by Chris.

fixed 3317693 -- REGRESSION: many web pages are rendering with wrong layout (columns in HelpViewer, etc.)

This is a workaround for the code generation bug in gcc that causes this problem with
gcc 3.3 in optimized builds. We can remove it once both we and B&I are using a newer
gcc with the fix. The bug number for the gcc problem is 3321716.

khtml/rendering/render_box.cpp: (workAroundBug3321716): Added. A function that does nothing and takes an integer parameter. (RenderBox::setStyle): Add a couple of calls to workAroundBug3321716 in the right places.

Jul 9, 2003:

4:21 PM Changeset in webkit [4608] by rjw

10 edits in trunk

WebKit:

Fixed 3141257. Animate multiple copies of the same
image on the same page.

Reviewed by hyatt.

WebCoreSupport.subproj/WebImageRenderer.h:
WebCoreSupport.subproj/WebImageRenderer.m: (+[WebImageRenderer stopAnimationsInView:]): (-[WebImageRenderer retainOrCopyIfNeeded]): (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer repetitionCount]): (-[WebImageRenderer scheduleFrame]): (-[WebImageRenderer beginAnimationInRect:fromRect:]):
WebCoreSupport.subproj/WebImageRendererFactory.h:
WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]): (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]):

WebCore:

Fixed 3141257. Animate multiple copies of the same
image on the same page.

Reviewed by hyatt.

khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
kwq/KWQPixmap.mm: (QPixmap::operator=):
kwq/WebCoreImageRenderer.h:

2:57 PM Changeset in webkit [4607] by cblu

5 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3229364>: user stylesheet path should be stored relative to home directory

Reviewed by john.

Misc.subproj/WebKitNSStringExtras.h:
Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_stringByAbbreviatingWithTildeInPath]): new, handles home directories that have symlinks in path
WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]): converts path string or URL string to URL (-[WebPreferences setUserStyleSheetLocation:]): converts URL to path string or URL string

WebBrowser:

Fixed: <rdar://problem/3183049>: Saved download entries use absolute paths thus not mobility-friendly

Reviewed by john.

DownloadProgressEntry.m: (-[DownloadProgressEntry initWithDictionary:]): expand home-dir relative paths (-[DownloadProgressEntry dictionaryRepresentation]): use home-dir relative paths when saving downloads paths to disk

10:40 AM Changeset in webkit [4606] by darin

19 edits in trunk

top level:

Reviewed by John.

.cvsignore: Add autom4te.cache to the list.
configure.in: Removed JAGUAR_OR_EARLIER define, not needed since we no longer support building TOT on Jaguar.

WebCore:

Reviewed by John.

removed Jaguar-specific code

kwq/KWQComboBox.mm: Remove fudge factor used to move text down and work around problem where pop-up menu text draws too high, bug 3030474.

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUsingTEC): Remove hack used to work around the lack of TECSetBasicOptions in Jaguar, bug 3201405.

config.h: The people with Foundation source trees slug it out with the people without Foundation trees, as one line of this file changes back and forth.

WebKit:

Reviewed by John.

fixed 3125264 -- nuke NSImage workaround when we drop Jaguar support

Misc.subproj/WebNSImageExtras.m: Removed the workaround.

removed other Jaguar-specific code

WebCoreSupport.subproj/WebImageRenderer.m: Remove workaround for improper handling of GIF animation loops with no loop counting, bug 3090341.

WebView.subproj/WebHTMLViewPrivate.m: Remove workaround for problem extracting scroll wheel events without also getting all others, which caused jumping around if you used the scroll wheel while moving the mouse, bug 3245425.

Misc.subproj/WebKitErrorsPrivate.h: Remove Jaguar-only import of <NSError.h>.
Plugins.subproj/WebNetscapePluginPackage.m: Remove Jaguar-only side of #if.
Plugins.subproj/WebNetscapePluginRepresentation.m: Remove Jaguar-only import of <NSError.h>.
WebKit/Plugins.subproj/WebPluginPackage.m: Remove unnecessary import of <NSError.h>.
Plugins.subproj/WebPluginPackage.m: Remove Jaguar-only side of #if.
WebCoreSupport.subproj/WebSubresourceClient.m: Remove Jaguar-only import of <NSError.h>.
WebView.subproj/WebDefaultFrameLoadDelegate.m: Remove Jaguar-only import of <NSError.h>.
WebView.subproj/WebImageRepresentation.m: Remove Jaguar-only import of <NSError.h>.

WebKit/English.lproj/StringsNotToBeLocalized.txt: Updated for this and other recent changes.

WebBrowser:

Reviewed by John.

removed Jaguar-specific code

AppController.m: (-[AppController applicationDidFinishLaunching:]): Remove workaround for problem with menu items that have backslash as the key equivalent for Japanese users, bug 3144133.

BrowserDocument.m: (-[BrowserDocument validModesForFontPanel:]): Take this method out of a Panther #if. (-[BrowserDocument validateUserInterfaceItem:]): Remove workaround for the hang in Preview when you preview printed bookmarks, bug 3267767.

BrowserNSErrorExtras.h: Remove import of NSError.h for Jaguar-only.
BrowserNSNetServiceExtras.m: Remove Jaguar-specific includes.
BrowserWindow.m: (-[BrowserWindow displayTitle]): Remove Panther #if around some code.
BugReportController.m: Remove import of NSError.h for Jaguar-only.
DownloadProgressEntry.m: Remove Panther #if around some code.
ListView.m: (+[ListView stripeColorForRow:]): Remove Jaguar compatibility code that always returns white.

LocationFieldEditor.m: (-[LocationFieldEditor validModesForFontPanel:]):
Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences validModesForFontPanel:]):
Preferences.subproj/WBPreferences.h:
Preferences.subproj/WBPreferences.m: (-[WBPreferences validModesForFontPanel:]): Take validModesForFontPanel: methods out of Panther #if.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed