Timeline



Jul 15, 2003:

3:54 PM Changeset in webkit [4658] by rjw
  • 6 edits in trunk

WebKit:

Fixed 3315952: Add support for <IMG> in attributed string conversion.

Added RTFD pasteboard type.

Reviewed by John.

  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView _pasteboardTypes]): (-[WebHTMLView _writeSelectionToPasteboard:]):

WebCore:

Fixed 3315951: Add support for <OL>, <UL> in attributed string conversion.
Fixed 3315952: Add support for <IMG> in attributed string conversion.
Fixed 3315953: Added support for <A> in attributed string conversion.

Reviewed by John (and earlier by Darin).

  • khtml/rendering/render_list.h:
  • kwq/KWQKHTMLPart.mm: (fileWrapperForElement): (listParent): (inList): (KWQKHTMLPart::attributedString):
3:32 PM Changeset in webkit [4657]
  • 1 copy
    319 deletes in branches/unlabeled-1.32.14

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.32.14'.

3:32 PM Changeset in webkit [4656] by hyatt
  • 18 edits in trunk/WebCore

Fix a problem where ems used for non-font values like width
and line-height would not zoom. (r=darin)

The rest is r=rjw.

An implementation of the CSS2 text-shadow property.

It uses a CoreGraphics API for drawing shadows
(via a custom API on QPainter) to paint the shadows.

At the moment there are two limitations in CG's API. The first
is that the shadow color cannot be set. This will be fixed for
Panther, and the code passes the color through in preparation
for this fix.

The second limitation is that CG only supports one shadow effect
and not multiple shadow effects. The parsing code on the CSS
side is set up to go ahead and parse all of the shadow effects,
but the code that makes use of shadows will simply look at the
first one for now. CG will not support multiple shadow effects
in the Panther time frame, so it will be a while before this
is revisited.

This patch also fixes a slew of bugs with colors in KHTML. When
we took the CSS parser and all of its associated code from Lars,
that code was using QRgb values that assumed RGBA (like the current
Qt toolkit uses). The code even made use of an "invalid color"
that wasn't really invalid (kind of like the z-index hack we refused
to take, i.e., unlikely but not invalid).

Our KWQColor implementation has been rewritten in this patch to
work the way the current Qt toolkit expects. That is, the top
eight bits actually do contain an alpha channel, and you can obtain
the alpha component using the qAlpha method and build a quadruple
using the qRgba method.

This patch adds support for rgba quadruples to CSS, so you can now
say, e.g.,color: rgba(255,0,0,0.5); in CSS.

  • khtml/css/css_valueimpl.cpp: (ShadowValueImpl::~ShadowValueImpl):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): (parseColor): (CSSParser::parseColor): (CSSParser::parseColorFromValue): (CSSParser::parseShadow):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp:
  • khtml/misc/helper.h:
  • khtml/rendering/render_line.cpp: (InlineFlowBox::paintDecorations):
  • khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (opacity): (flexibleBox): (StyleCSS3NonInheritedData::operator==): (textShadow): (StyleCSS3InheritedData): (StyleCSS3InheritedData::operator==): (StyleCSS3InheritedData::shadowDataEquivalent): (RenderStyle::RenderStyle): (RenderStyle::inheritFrom): (RenderStyle::operator==): (RenderStyle::inheritedNotEqual): (RenderStyle::diff): (ContentData::clearContent): (RenderStyle::setTextShadow): (ShadowData::operator==):
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_text.cpp: (RenderText::paintObject):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::diff):
  • kwq/KWQColor.h:
  • kwq/KWQColor.mm: (qRgb): (qRgba): (qAlpha): (QColor::QColor): (QColor::setNamedColor): (QColor::getNSColor):
  • kwq/KWQNamespace.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawRect): (QPainter::drawLine): (QPainter::_fillRect): (QPainter::fillRect): (QPainter::setShadow): (QPainter::clearShadow):

Jul 14, 2003:

9:18 PM Changeset in webkit [4655] by darin
  • 7 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3244447 -- add KOI8-U charset support
  • fixed 3327152 -- unicodeFFFE and unicodeFEFF are handled backwards by WebCore
  • fixed 3327157 -- x-mac-ukrainian should be mapped to MacCyrillic
  • fixed 3327160 -- shift-jis, shift_jis, x-sjis should be mapped to the DOS variant of Shift JIS
  • fixed 3327162 -- most Simplified Chinese encoding choices should be mapped to the DOS variant of EUC-CN
  • fixed 3327166 -- use DOS variant of EUC_KR
  • kwq/KWQCharsets.mm: Added some defines so we could use encodings that don't have any kCFStringEncoding constant in a header file.
  • kwq/mac-encodings.txt: Change table entries in accordance with the above bug reports.
  • kwq/KWQCharsetData.c: Regenerated.
  • other changes, inspired by investigation of various bugs
  • kwq/KWQButton.mm: (-[KWQButton sendConsumedMouseUpIfNeeded]): Make robust against cases where sending the consumed mouse up event destroys the QButton.
  • khtml/html/htmlparser.cpp: (KHTMLParser::reopenResidualStyleTags): Rearrange code slightly for clarity, added comment. (KHTMLParser::freeBlock): Removed unnecessary line of code.
9:17 PM Changeset in webkit [4654] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • make some improvements to handling of the timer, inspired by some bug reports
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Instead of releasing the timer, assert it is nil. (-[WebFrame _detachFromParent]): Invalidate and release the timer after finishing dealing with self, in case the reference from the timer is the last one. (-[WebFrame _timedLayout:]): Release the timer after doing all the other work, in case the reference from the timer is the last one. (-[WebFrame _setState:]): Release the timer after doing all the other work, in case the reference from the timer is the last one.
1:37 PM Changeset in webkit [4653] by darin
  • 2 edits in trunk/WebKit

Rolled out workaround to bug 3298153 -- get "screen font while printing"
error, bad stuff happens after that (Sherlock, Safari). It turns out the
real fix was on the WebCore side. Now that we have that fix we don't need
these extra calls to printerFont, which is a relatively slow call that
may need to look up a font by name each time it's called.

  • WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs): Remove code to look up the printer font.
1:36 PM Changeset in webkit [4652]
  • 16 copies in tags/Safari-85~5

This commit was manufactured by cvs2svn to create tag 'Safari-85~5'.

1:36 PM Changeset in webkit [4651] by sheridan
  • 8 edits in branches/Safari-1-0-branch

Safari-85.5 version stamp

1:12 PM Changeset in webkit [4650] by darin
  • 3 edits in branches/Safari-1-0-branch/WebCore

Rolled in change from main trunk.

2003-07-14 Dave Hyatt <​hyatt@apple.com>

Fix for 3294626, no scrollbar on ESPN. Fix lowestPosition to
always crawl into all children.

Reviewed by darin

  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
1:10 PM Changeset in webkit [4649] by mjs
  • 2 edits in trunk/WebKit

Rolled in fix from Safari-89-branch

2003-07-12 Maciej Stachowiak <​mjs@apple.com>

Try to fix OS build by making the Frameworks link in both SYMROOT
and DSTROOT, and at both build time and install time.

  • WebKit.pbproj/project.pbxproj:
12:17 PM Changeset in webkit [4648] by hyatt
  • 2 edits in trunk/WebKit

Roll this change out. It was a bad change that I only made
because I was using the opacity APIs wrong.

Reviewed by (nobody, just a straight backout of a previous checkin)

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
12:02 PM Changeset in webkit [4647] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3294626, no scrollbar on ESPN. Fix lowestPosition to
always crawl into all children.

Reviewed by darin

  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
11:27 AM Changeset in webkit [4646] by darin
  • 3 edits in branches/Safari-1-0-branch/WebCore

Rolled in change from main trunk.

2003-07-08 Dave Hyatt <​hyatt@apple.com>

Make sure that the contents width and height of the view are
used as the root height and width when a view exists. This
ensures that the root element background properly tiles over
the entire height of the document. (This used to be ensured
by growing the height of the <html> element, but that violates
the CSS2 spec.)

This fixes bugs 3317809, 3299789, and 3318066.

Reviewed by john

  • khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations):
11:24 AM Changeset in webkit [4645] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Changed minimum font size back to 9 instead of 1.

Jul 13, 2003:

6:22 PM Changeset in webkit [4644]
  • 3 copies
    2 deletes in tags/WebKit-89~3

This commit was manufactured by cvs2svn to create tag 'WebKit-89~3'.

6:22 PM Changeset in webkit [4643] by mjs
  • 2 edits in branches/Safari-89-branch/WebKit

Yet another build fix: WebKit.framework goes in
/System/Library/Frameworks,

  • WebKit.pbproj/project.pbxproj:
3:55 PM Changeset in webkit [4642]
  • 3 copies
    2 deletes in tags/WebKit-89~2

This commit was manufactured by cvs2svn to create tag 'WebKit-89~2'.

3:55 PM Changeset in webkit [4641] by mjs
  • 2 edits in branches/Safari-89-branch/WebKit

Rolled in build fixes from HEAD.

2003-07-13 Darin Adler <Darin Adler>

  • WebKit.pbproj/project.pbxproj: Add command to prevent build from failing if symlink creation fails.

2003-07-13 Darin Adler <Darin Adler>

Fixed symbolic link path as Matt Reda suggested.

  • WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases to use Versions/Current instead of Versions/A.

2003-07-13 Darin Adler <Darin Adler>

Fixed DSTROOT path as Eric Weiss suggested.

  • WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases.
2:41 PM Changeset in webkit [4640] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3132021 -- certain Japanese characters are misrendered because of incorrect partial-character handling

We didn't have code to handle kTECPartialCharErr.

  • kwq/KWQTextCodec.mm: (KWQTextDecoder::createTECConverter): Added. Broken out from convertUsingTEC. (KWQTextDecoder::appendOmittingBOMs): Added. Broken out from convertUsingTEC. (KWQTextDecoder::convertOneChunkUsingTEC): Added. Broken out from convertUsingTEC. This also has much of the partially-decoded character handling. (KWQTextDecoder::convertUsingTEC): Simplified by breaking into functions, and added handling to use the same buffer we use for the other decoders to hold partially-decoded characters. (KWQTextDecoder::convert): Add a partial-character handling test mode where the decoder is passed only a single byte at a time; controlled by an #if.
2:40 PM Changeset in webkit [4639] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • do some improvements Maciej suggested while reviewing the array index change
  • kjs/array_object.cpp: (getArrayIndex): Return a flag to say whether the index was value separately, to avoid in-band signalling. (ArrayInstanceImp::get): Update for new getArrayIndex parameters. (ArrayInstanceImp::put): Ditto. (ArrayInstanceImp::hasProperty): Ditto. (ArrayInstanceImp::setLength): Ditto.
  • kjs/ustring.cpp: (UString::toStrictUInt32): Check for overflow in a way that avoids doing a divide every time through the loop. But note that it adds an extra branch to the loop. I wonder which is worse.
2:40 PM Changeset in webkit [4638] by darin
  • 2 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Add command to prevent build from failing if symlink creation fails.
2:31 PM Changeset in webkit [4637] by darin
  • 2 edits in trunk/WebKit

Fixed symbolic link path as Matt Reda suggested.

  • WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases to use Versions/Current instead of Versions/A.
9:29 AM Changeset in webkit [4636] by darin
  • 2 edits in trunk/WebKit

Fixed DSTROOT path as Eric Weiss suggested.

  • WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases.

Jul 12, 2003:

11:30 PM Changeset in webkit [4635]
  • 3 copies
    2 deletes in tags/WebKit-89~1

This commit was manufactured by cvs2svn to create tag 'WebKit-89~1'.

11:30 PM Changeset in webkit [4634] by mjs
  • 2 edits in branches/Safari-89-branch/WebKit

Try to fix OS build by making the Frameworks link in both SYMROOT
and DSTROOT, and at both build time and install time.

  • WebKit.pbproj/project.pbxproj:
11:23 PM Changeset in webkit [4633] by mjs
  • 2 edits in trunk/WebKit

Try to fix OS build by making the Frameworks link in both SYMROOT
and DSTROOT, and at both build time and install time.

  • WebKit.pbproj/project.pbxproj:
5:10 PM Changeset in webkit [4632] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3187101, before/after content not dynamic. This patch
compares the ContentData of the old style and the new style and
if they are different, it blows away and recreates the render
objects for the generated content. Otherwise it will dynamically
update the styles of the generated content render objects (which
should fix the printer/screen bug for rjw).

Note that createObject had an extra call to setStyle, which was
causing most objects to set the same style context on themselves
twice. This was exposed as I was fixing the above problem.

Reviewed by darin

  • ChangeLog:
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_object.cpp: (RenderObject::createObject):
  • khtml/rendering/render_style.cpp: (RenderStyle::contentDataEquivalent):
  • khtml/rendering/render_style.h:
11:53 AM Changeset in webkit [4631] by darin
  • 3 edits in trunk/JavaScriptCore

Fixed broken build.

  • kjs/identifier.h: Add toULong back. It's still used in WebCore (and maybe in JavaScriptGlue, for all I know).
9:01 AM Changeset in webkit [4630] by darin
  • 6 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed 3272777 -- array object indices treated as integers by Safari, but as strings in other web browsers

JavaScriptCore did not implement the proper rule for what an array index is.

  • kjs/array_object.cpp: (getArrayIndex): Added. Implements the rule from the specification, which also provides a handy "not an array index" value of 232-1. (ArrayInstanceImp::get): Use getArrayIndex. (ArrayInstanceImp::put): Ditto. (ArrayInstanceImp::hasProperty): Ditto. (ArrayInstanceImp::setLength): Ditto.
  • kjs/identifier.h: Removed now-unused toULong, and added toStrictUInt32, in both cases forwarding functions that forward to UString.
  • kjs/ustring.h: Added toStringUInt32.
  • kjs/ustring.cpp: (UString::toStrictUInt32): Added. Converts a string to a 32-bit unsigned integer, and rejects any string that does not exactly match the way the integer would be formatted on output. This is the rule documented in the ECMA language standard.

Jul 11, 2003:

5:36 PM Changeset in webkit [4629] by hyatt
  • 9 edits in trunk/WebCore

Fix pseudostyles to inherit from the element's style that they are
specified for. This is incorrect both for ::first-line and
::first-letter, but it is at least right for ::before and ::after.

Fix iframes and objects and embeds so that they will render borders
when borders are specified (as well as background images).

Patch iframes so that they correctly let the parent document's
background show through when the Web page inside the iframe has
no specified background. Also patched iframes to understand not
to blit in this case and to not blit when opacity has been specified
on the iframe.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
  • khtml/khtmlview.h:
  • khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations):
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_form.cpp: (RenderFormElement::setStyle):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth): (RenderWidget::setStyle): (RenderWidget::paintObject):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):
3:38 PM Changeset in webkit [4628] by darin
  • 8 edits in trunk/WebCore

Reviewed by Ken.

  • roll in change from KHTML to remove user and password from referrer
  • khtml/khtml_part.cpp: (KHTMLPart::begin): Call setUser(""), setPass(""), and setRef(""), then also set the referrer to "" if the protocol does not start with http.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Remove check to exclude file URL referrers because KHTMLPart now excludes all non-http referrers.
  • kwq/KWQKURL.h: Add setUser and setPass functions. Also sort by order within the URL so it's clear no methods are omitted.
  • kwq/KWQKURL.mm: (KURL::setUser): Added. Adds or removes the username, adding or removing delimiters as needed. For now only the remove part is compiled in. (KURL::setPass): Added. Adds or removes a password, adding or removing delimiters as needed. For now only the remove part is compiled in.
  • kwq/KWQString.h: Add QSTRING_NULL macro to allow us to work around the fact that there is no global QString::null object in KWQ without having to do a relatively ineffecient conversion from a non-constant char * of 0 each time. We can use this anywhere QString::null appears and perhaps get some small code savings or performance boost.
  • small cleanup
  • kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Remove unneeded checks that repeat optimizations I already put in QString.
11:41 AM Changeset in webkit [4627] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • added a function Dave needs for various work he's doing that goes from a document to the corresponding element in the parent document
  • khtml/xml/dom_docimpl.h: Add ownerElement member function.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement): Added. Gets to the parent part and finds the right element.
10:55 AM Changeset in webkit [4626] by hyatt
  • 19 edits in trunk/WebCore

An initial implementation of the CSS opacity property. Seems
to work perfectly except for native widgetry (NSViews). Images,
text, borders, and underlines are all properly blended.

Reviewed by rjw

  • config.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::adjustZIndex):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::transparentAncestor): (RenderLayer::isTransparent): (commonTransparentAncestor): (RenderLayer::updateTransparentState): (RenderLayer::beginTransparencyLayers): (RenderLayer::endTransparencyLayers): (RenderLayer::paint):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (RenderStyle::diff):
  • khtml/rendering/render_style.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::beginTransparencyLayer): (QPainter::endTransparencyLayer):
10:54 AM Changeset in webkit [4625] by hyatt
  • 2 edits in trunk/WebKit

Make sure image compositing obeys the current global alpha that
is in effect, e.g., if someone has set an opacity within the
current layer.

It's worth noting that I'm not even sure *why* this patch works,
but it does, even with nested opacity layers.

Reviewed by darin

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
9:24 AM Changeset in webkit [4624] by darin
  • 5 edits in trunk/WebCore

Reviewed by Chris.

  • fixed 3305391 -- repro crash in QPixmap::QPixmap after click in SVG using Adobe SVG plugin
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Remove code that tried to determine if something is an image by looking at the node type. Instead look at the object in the render tree and ask it if it's an image. Also use logic that exactly matches what RenderImage uses.
  • kwq/KWQDOMNode.h: Remove unused isImage function.
  • kwq/KWQDOMNode.cpp: Ditto.
8:24 AM Changeset in webkit [4623] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3300220 -- repro crash in closeURL when choosing from popup menus on www.drivewire.com
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Removed unused local variable. Since we update all documents, there was no longer any need to keep that pointer around, but we still had this obsolete code. This had nothing to do with the bug, just a related cleanup. (NodeImpl::dispatchWindowEvent): Add check for nil. We ref the document pointer, but we don't ref the document itself. So we do need to check for the case where the document went away.
1:01 AM Changeset in webkit [4622] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3217731 -- after going back to a page, forms are submitted with the wrong encoding (back/forward cache)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Put decoder from document into the part.
Note: See TracTimeline for information about the timeline view.