Timeline



Jul 20, 2003:

6:36 PM Changeset in webkit [4677] by hyatt
  • 10 edits in trunk/WebCore

Enable domain() and setDomain() to work for all documents (XML
as well as HTML).

Implement onload for frames.

Reviewed by mjs

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript): (WindowFunc::tryCall):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::parseAttribute): (HTMLIFrameElementImpl::parseAttribute):
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::checkEmitLoadEvent):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::domain): (DocumentImpl::setDomain):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent):
5:19 PM Changeset in webkit [4676]
  • 7 copies
    2 deletes in tags/WebKit-85~7

This commit was manufactured by cvs2svn to create tag 'WebKit-85~7'.

5:19 PM Changeset in webkit [4675] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • another attempt to fix compiler error
  • WebKit.pbproj/project.pbxproj: Turn off -Werror.

Jul 18, 2003:

7:06 PM Changeset in webkit [4674] by rjw
  • 3 edits in trunk/WebKit

Fixed 3283594. "Times RO" appears to have a corrupt regular variant. Added
additional bullet proofing to catch corrupt fonts. Also added a special case
hack to map "Times RO" to "Time New Roman" if the variant doesn't have valid
glyphs.

Fixed 3319846. The page mentioned in this bug required > 10 substitute fonts for
the same base font. This triggered some buggy code that hasn't been exercise before.
Specifically the code that resizes the substitute fonts array was incorrect.

Reviewed by mjs.

  • Misc.subproj/WebAssertions.h: Added FATAL_ALWAYS macro that logs and CRASHES even in deployment builds.
  • WebCoreSupport.subproj/WebTextRenderer.m: (mapForSubstituteFont): (widthFromMap): (FillStyleWithAttributes): (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer _setupFont:]): (pathFromFont): (glyphCountFromFont): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):
5:17 PM Changeset in webkit [4673] by sheridan
  • 1 edit in branches/Safari-1-0-branch/WebKit/WebKit.pbproj/project.pbxproj

85.7 version for webkit

4:29 PM Changeset in webkit [4672] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • attempt to fix compiler error
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Did the type casting another way.
12:22 PM Changeset in webkit [4671] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3334082, XML documents can access HTML/XML docs in other
domains. The basic bug is that we made a change right before
1.0 to allow a parent document to access a child frame's document
if the child frame had no document. What we didn't notice was
that the ptr was obtained from the part by asking for an HTML
document. For XML documents that failed the cast, we got back
null as well, which means that for non-HTML XML documents we
always return true from isSafeScript.

This patch makes sure our addition uses the raw xmlDoc pointer,
so that there are no mistakes, and it restores the code that
denies access when you aren't an HTML document.

(It is a separate bug that we just disallow cross-frame
communication in XML documents right now that I'll file as
a follow-up to this one.)

Reviewed by darin, rjw, mjs

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript):

Jul 17, 2003:

5:48 PM Changeset in webkit [4670]
  • 7 copies
    2 deletes in tags/WebKit-85~6

This commit was manufactured by cvs2svn to create tag 'WebKit-85~6'.

5:48 PM Changeset in webkit [4669] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • rolled over change from main trunk

2003-07-17 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed 3250608 -- REGRESSION (74-85): reproducible Safari crash in blinkCaretTimerAction
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use NSView's setNeedsDisplayInRect: instead of the one in NSTextView. This avoids the layout that the NSTextView version of the call might do. By definition, we don't need layout to draw the insertion point, because we did the layout to find where the insertion point should display. If we do the layout we can end up recursing into the insertion point drawing code, which wreaks major havoc. Still no idea why this happened less in version 74.
4:41 PM Changeset in webkit [4668] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3250608 -- REGRESSION (74-85): reproducible Safari crash in blinkCaretTimerAction
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use NSView's setNeedsDisplayInRect: instead of the one in NSTextView. This avoids the layout that the NSTextView version of the call might do. By definition, we don't need layout to draw the insertion point, because we did the layout to find where the insertion point should display. If we do the layout we can end up recursing into the insertion point drawing code, which wreaks major havoc. Still no idea why this happened less in version 74.
12:49 PM Changeset in webkit [4667] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3300362, crash on myuhc.com. The residual style code
was messing up and inserting nodes in the wrong place (and also
updating the current member variable when it wasn't supposed to).

Fix for 3331793, nil deref because (astoundingly) someone was
using text-shadow and exposed a bug with the color handling
of the shadow.

Reviewed by darin

  • khtml/html/htmlparser.cpp:
  • khtml/html/htmlparser.h (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock):
11:55 AM Changeset in webkit [4666] by mjs
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3283076 - crash when doing 2nd query on the eBay channel (Sherlock) -- JavaScript locking issue?

I added a bit of minimal extra locking to WebCore to make sure
multithreaded apps that use WebKit on the main thread but do
JavaScript on other threads as well continue to work nicely.

  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::initScript): Lock interpreter around possible allocations or collections.
  • khtml/ecma/kjs_window.cpp: (Window::clear): Lock interpreter around possible allocations or collections.
11:54 AM Changeset in webkit [4665] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

  • fixed 3330344 - Please change allowable client to "JavaScriptGlue" from "JSGlue"
  • JavaScriptCore.pbproj/project.pbxproj: Changed allowable client to "JavaScriptGlue"
10:49 AM Changeset in webkit [4664] by kocienda
  • 12 edits in trunk

WebCore:

Reviewed by John

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): Now uses NSURL instead of NSString (KWQKHTMLPart::redirectionTimerStartedOrStopped): Ditto (KWQKHTMLPart::userAgent): Ditto
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::setIconURL): Ditto (KHTMLPartBrowserExtension::setTypedIconURL): Ditto
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet): Ditto
  • kwq/KWQLoader.mm: (KWQServeRequest): Ditto (KWQCheckCacheObjectStatus): Ditto
  • kwq/WebCoreBridge.h: Changed quite a number of methods to use NSURL instead of NSString
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge didNotOpenURL:]): Now uses NSURL instead of NSString (-[WebCoreBridge scrollToAnchorWithURL:]): Ditto (-[WebCoreBridge URL]): Ditto

WebKit:

Reviewed by John

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]): Now uses NSURL instead of NSString (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto (-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Ditto (-[WebBridge setIconURL:]): Ditto (-[WebBridge setIconURL:withType:]): Ditto (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto (-[WebBridge userAgentForURL:]): Ditto (-[WebBridge requestedURL]): Now returns string using _web_absoluteString
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedError:complete:]): Now uses NSURL instead of NSString
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]): Ditto (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): Ditto (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Ditto
8:51 AM Changeset in webkit [4663] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLStringLength]): Fix premature use of new CFURL API. New code is ifdef'ed out for now until everyone has revved.
7:56 AM Changeset in webkit [4662] by kocienda
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Darin

  • kwq/KWQKHTMLPart.h: _submittedFormURL is now a KURL, not a QString
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Now uses NSURL in API instead of NSString (KWQKHTMLPart::openURLRequest): Ditto (KWQKHTMLPart::didNotOpenURL): Ditto (KWQKHTMLPart::submitForm): Ditto. Plus update _submittedFormURL usages. (KWQKHTMLPart::urlSelected): Ditto (KWQKHTMLPart::setView): Ditto
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Now uses NSURL in API instead of NSString
  • kwq/KWQKURL.h: Added constructor that takes an NSURL
  • kwq/KWQKURL.mm: (KURL::KURL): Ditto.
  • kwq/WebCoreBridge.h: Updated bridge APIs to use NSURL instead of NSString in several places.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Ditto

WebKit:

Reviewed by Darin

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Now uses NSURL in API instead of NSString (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): Ditto (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto
  • WebKit.pbproj/project.pbxproj: Added WebNSURLExtras file
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Now uses NSURL in API instead of NSString

Jul 16, 2003:

1:30 PM Changeset in webkit [4661] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • cure problem where we keep competing to check in config.h with/without HAVE_FOUNDATION_SOURCSE
  • Makefile.am: Remove the HAVE_FOUNDATION_SOURCES line.
  • config.h: Check in without that line.
11:46 AM Changeset in webkit [4660] by vicki
  • 3 edits in trunk/WebCore

Reviewed by kocienda.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): set linkStartLocation to zero to fix deployment build
9:54 AM Changeset in webkit [4659] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Richard

  • kwq/KWQKURL.h:
  • kwq/KWQKURL.mm: (StringHasCaseInsensitivePrefix): Helper method for the new functions below (StringByAddingPercentEscapes): Ditto (URLStringByAddingPercentEscapes): Ditto (KURL::getNSURL): Added convenience function to get an NSURL from a KURL (KURL::getNSData): Added convenience function to get an NSData from a KURL
Note: See TracTimeline for information about the timeline view.