⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 22, 2003:

11:35 PM Changeset in webkit [4690] by hyatt
  • 11 edits
    3 deletes in trunk/WebCore

Allow HTML and BODY to be any display type. This patch primarily eliminates the
RenderBody class and makes the code that deals with background propagation smart
enough to locate the correct renderers for the HTML and BODY elements (by crossing
back into the DOM tree).

Reviewed by darin

  • ForwardingHeaders/rendering/render_body.h: Removed.
  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument):
  • khtml/html/html_baseimpl.h:
  • khtml/rendering/render_body.cpp: Removed.
  • khtml/rendering/render_body.h: Removed.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations): (RenderBox::repaint):
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::isBody):
  • khtml/rendering/render_object.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::createRenderer):
11:02 PM Changeset in webkit [4689] by darin
  • 6 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

  • fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu
  • kwq/mac-encodings.txt: Added "Shift_JIS_X0213-2000". Changed all non-HKSCS Big5 encodings to use the DOS variant of Big5 as requested by Peter Edberg, but left Big5-HKSCS alone.
  • kwq/KWQCharsets.mm: Added kCFStringEncodingBig5_DOSVariant constant.
  • kwq/KWQCharsetData.c: Regenerated.
  • fixed 3100151 -- subframes without explicit charset settings should inherit from parent, not use default
  • khtml/khtml_part.cpp: (KHTMLPart::write): Get the default encoding from the parent part, if there is one.

WebBrowser:

Reviewed by Maciej.

  • fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu

Since Shift JIS X0213 does not yet have an IANA name, had to change the code
to get the name another way. This led me to change the menu items to work by having
the character set name in the representedObject instead of the CFString character set
code in the tag.

  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Set the state of a changeTextEncoding: menu item based on the represented object, not the tag. (-[BrowserWindowController changeTextEncoding:]): Pass the represented object into setCustomTextEncodingName: rather than calling CFStringConvertEncodingToIANACharSetName.
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences updateDefaultCharacterSetPopup]): (-[AppearancePreferences takeDefaultCharacterSetFrom:]):
  • TextEncodingMenu.m: Added both kCFStringEncodingShiftJIS_X0213_00 and kCFStringEncodingBig5_HKSCS_1999 to the menu. (-[NSMenu addItemToMenuForEncoding:withTarget:action:]): Get the name using CFStringConvertEncodingToIANACharSetName, with hardcoded fallbacks for kCFStringEncodingGB_2312_80 and kCFStringEncodingShiftJIS_X0213_00, which do not have their IANA names in the table. Put the name in the represented object instead of putting the encoding constant in the tag. No need for the separatorItemWithNonConflictingTag method any more, since a character set name of nil does not ever get used (unlike a tag of 0, which was used for US-ASCII). (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Use the represented object check to detect the end of a group rather than checking the tag. No need for the separatorItemWithNonConflictingTag method (as above).
  • English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.
9:41 PM Changeset in webkit [4688] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
1:48 PM Changeset in webkit [4687]
  • 2 copies
    2 deletes in tags/Safari-89~1

This commit was manufactured by cvs2svn to create tag 'Safari-89~1'.

1:48 PM Changeset in webkit [4686] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

Remove -seg_addr_table_filename to fix build.

11:24 AM Changeset in webkit [4685] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3293898, list bullets in ordered lists with an inside list
position were rendering as though they had a width of 0. This was
a bug in KWQFontMetrics, which needed to handle the case where a
length of -1 was passed in to the width method (in which case
you should use the length of the whole string).

Reviewed by john

  • kwq/KWQFontMetrics.mm: (QFontMetrics::width):
9:40 AM Changeset in webkit [4684] by hyatt
  • 13 edits in trunk/WebCore

Fix for mozilla.org front page. This patch re-architects
align="left" and align="right" (for rtl and ltr directionality
respectively). The attributes are mapped to custom text-align
values, konq-left and konq-right, just as was done with the
center/middle attributes for alignment.

A number of "hack" style rules have been dropped from html4.css
and replaced with this C++ code that now works in the general
case for any children of align="left/right" divs and tds.

In addition, absmiddle support has been added for <td>s.

For RTL blocks, there is also a regression fix (this was probably
the #1 culprit for mangled placement of blocks in Hebrew Web
pages). The old code was doing byzantine math that happened to
work out. When I tried to simplify it before 1.0, I missed a spot
and basically broke margin handling on RTL blocks completely.

Reviewed by mjs

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLParagraphElementImpl::parseAttribute):
  • khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::calcHorizontalMargins):
  • khtml/rendering/render_style.h:

Jul 21, 2003:

3:53 PM Changeset in webkit [4683] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3333557, crash on www.dremedia.com. markDescendants in RenderBlock
was not passing in its argument in the recursive step, so the float wasn't
getting properly cleared out of everyone's lists.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
2:19 PM Changeset in webkit [4682] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3182596, percentage height tables with cells that specify
tiny percentage heights used that height even if it was smaller
than the cell's minimum required height.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
1:41 PM Changeset in webkit [4681] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3316867 -- tabbing to textarea below visible part of page doesn't scroll down
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added call to _KWQ_scrollFrameToVisible to match the one in KWQTextField.
1:29 PM Changeset in webkit [4680] by hyatt
  • 3 edits in trunk/WebCore

Fix removeAttributeNode. This is David Faure's patch.

Reviewed by me

  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::removeAttribute):
1:21 PM Changeset in webkit [4679] by hyatt
  • 4 edits in trunk/WebCore

Checking in David Faure's patch that fixes getElementsByTagName(*).

Reviewed by me

  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::getElementsByTagNameNS): (TagNodeListImpl::nodeMatches):
7:31 AM Changeset in webkit [4678] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me.

Fixed build breaker.

Removed glyphCountFromFont function. It was used only in an
ERROR function, which does not compile in on deployment
builds, causing a "defined, but not used warning".

As this function is only a one-liner call into ATS, I
replaced the usage in the ERROR call with a call to the
ATS function directly.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:])

Jul 20, 2003:

6:36 PM Changeset in webkit [4677] by hyatt
  • 10 edits in trunk/WebCore

Enable domain() and setDomain() to work for all documents (XML
as well as HTML).

Implement onload for frames.

Reviewed by mjs

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript): (WindowFunc::tryCall):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::parseAttribute): (HTMLIFrameElementImpl::parseAttribute):
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::checkEmitLoadEvent):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::domain): (DocumentImpl::setDomain):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent):
5:19 PM Changeset in webkit [4676]
  • 7 copies
    2 deletes in tags/WebKit-85~7

This commit was manufactured by cvs2svn to create tag 'WebKit-85~7'.

5:19 PM Changeset in webkit [4675] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • another attempt to fix compiler error
  • WebKit.pbproj/project.pbxproj: Turn off -Werror.

Jul 18, 2003:

7:06 PM Changeset in webkit [4674] by rjw
  • 3 edits in trunk/WebKit

Fixed 3283594. "Times RO" appears to have a corrupt regular variant. Added
additional bullet proofing to catch corrupt fonts. Also added a special case
hack to map "Times RO" to "Time New Roman" if the variant doesn't have valid
glyphs.

Fixed 3319846. The page mentioned in this bug required > 10 substitute fonts for
the same base font. This triggered some buggy code that hasn't been exercise before.
Specifically the code that resizes the substitute fonts array was incorrect.

Reviewed by mjs.

  • Misc.subproj/WebAssertions.h: Added FATAL_ALWAYS macro that logs and CRASHES even in deployment builds.
  • WebCoreSupport.subproj/WebTextRenderer.m: (mapForSubstituteFont): (widthFromMap): (FillStyleWithAttributes): (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer _setupFont:]): (pathFromFont): (glyphCountFromFont): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):
5:17 PM Changeset in webkit [4673] by sheridan
  • 1 edit in branches/Safari-1-0-branch/WebKit/WebKit.pbproj/project.pbxproj

85.7 version for webkit

4:29 PM Changeset in webkit [4672] by darin
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • attempt to fix compiler error
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Did the type casting another way.
12:22 PM Changeset in webkit [4671] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3334082, XML documents can access HTML/XML docs in other
domains. The basic bug is that we made a change right before
1.0 to allow a parent document to access a child frame's document
if the child frame had no document. What we didn't notice was
that the ptr was obtained from the part by asking for an HTML
document. For XML documents that failed the cast, we got back
null as well, which means that for non-HTML XML documents we
always return true from isSafeScript.

This patch makes sure our addition uses the raw xmlDoc pointer,
so that there are no mistakes, and it restores the code that
denies access when you aren't an HTML document.

(It is a separate bug that we just disallow cross-frame
communication in XML documents right now that I'll file as
a follow-up to this one.)

Reviewed by darin, rjw, mjs

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript):
Note: See TracTimeline for information about the timeline view.