Timeline



Jul 25, 2003:

3:04 PM Changeset in webkit [4715] by rjw
  • 2 edits in trunk/WebKit

Fixed 3344519. Prevent infinite recursion attempting font substitution.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
2:22 PM Changeset in webkit [4714] by mjs
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3280582 - REGRESSION (74-85): authentication sheet doesn't state that previous login was incorrect
  • Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Use chall, the parameter, not challenge, the not-yet-set ivar so we get the right failure count &c.
1:47 PM Changeset in webkit [4713] by hyatt
  • 6 edits in trunk/WebCore

Rename box and inline-box to -khtml-box and -khtml-inline-box.

Reviewed by john

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
1:22 PM Changeset in webkit [4712] by hyatt
  • 21 edits in trunk/WebCore

Fix for 3343529, inline blocks crashing Safari. There were lots of problems with
inlne-blocks. This code gets basic inline-blocks working properly (with no crashes).

Several functions have been patched to take an isRootLineBox parameter. This is used
to tell whether you're supposed to examine the root line box for a block or the block
itself. In the case of baselinePosition and lineHeight, it indicates whether the caller
wants to measure the outside or inside of the box.

The outside of an inline-block is like a replaced element (e.g., an image), but the
inside is like a block, e.g., you want measurements for
the line height and baseline position of a root line box for that block.

Similarly, createInlineBox has been patched in order to know whether you're making a
root inline box *inside* the inline-block or an inline box that *encompasses* the
inline-block element (like you'd do for an image).

A number of places had isInline() calls and needed to be patched to also check
isInlineBlockOrInlineTable(). How to treat the inline-block again basically depends
on whether the caller is looking at the outside of the block (in which case you're like
an inline replaced element) or the inside of the block (in which case you're just like
a block).

Reviewed by darin

  • ChangeLog:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::calcWidth): (RenderBox::calcHeight):
  • khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderFormElement::baselinePosition): (RenderButton::baselinePosition): (RenderSubmitButton::baselinePosition): (RenderSelect::baselinePosition):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_line.cpp: (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::computeLogicalBoxHeights):
  • khtml/rendering/render_list.cpp: (RenderListMarker::lineHeight): (RenderListMarker::baselinePosition):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::sizesToMaxWidth): (RenderObject::getVerticalPosition): (RenderObject::lineHeight): (RenderObject::baselinePosition): (RenderObject::createInlineBox):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::lineHeight): (RenderReplaced::baselinePosition):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (RenderText::lineHeight): (RenderText::baselinePosition): (RenderText::createInlineBox):
  • khtml/rendering/render_text.h:
12:54 PM Changeset in webkit [4711] by rjw
  • 2 edits in trunk/WebKit

Use 11 point bold, instead of 12 point bold, to draw dragged link
labels. This matches the text drawn in the bookmarks bar.

Reviewed by John.

  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]):
3:27 AM Changeset in webkit [4710] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3343527, crash when attempting to access rules in the CSS OM.
Our KWQListImpl doesn't null check accesses, so anything out
of bounds would cause a crash.

Reviewed by mjs

  • kwq/KWQListImpl.mm: (KWQListImpl::at):
3:10 AM Changeset in webkit [4709] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler
  • khtml/rendering/render_form.cpp: (RenderTextArea::handleFocusOut): Check if we still have an element. It could have gone away while handling an event that replaced some or all of the document, and if we're gonna be destroyed soon then there's no point doing this work anyway.
2:11 AM Changeset in webkit [4708] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler
  • khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter): We want to ref element() across this call, but it could get unset, so store it in a local variable.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::~QLineEdit): invalidate our KWQTextField.
  • kwq/KWQTextField.h:
  • kwq/KWQTextField.mm: (-[KWQTextField invalidate]): Set widget to NULL. (-[KWQTextField action:]): Do nothing if widget is NULL. (-[KWQTextField controlTextDidBeginEditing:]): Likewise. (-[KWQTextField controlTextDidEndEditing:]): Likewise. (-[KWQTextField controlTextDidChange:]): Likewise. (-[KWQTextField control:textShouldBeginEditing:]): Likewise. (-[KWQTextField control:textShouldEndEditing:]): Likewise. (-[KWQTextField control:didFailToFormatString:errorDescription:]): Likewise. (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): Likewise. (-[KWQTextField control:isValidObject:]): Likewise. (-[KWQTextField control:textView:doCommandBySelector:]): Likewise. (-[KWQTextField stringValue]): Likewise. (-[KWQTextField setStringValue:]): Likewise. (-[KWQTextField setFont:]): Likewise. (-[KWQTextField nextKeyView]): Likewise. (-[KWQTextField previousKeyView]): Likewise. (-[KWQTextField nextValidKeyView]): Likewise. (-[KWQTextField previousValidKeyView]): Likewise. (-[KWQTextField fieldEditorDidMouseDown:]): Likewise. (-[KWQTextField textView:shouldHandleEvent:]): Likewise. (-[KWQTextField textView:didHandleEvent:]): Likewise. (-[KWQTextField setHasFocus:]): Likewise.

Jul 24, 2003:

6:21 PM Changeset in webkit [4707] by rjw
  • 5 edits in trunk/WebKit

Fixed 3279910. Change the way we draw dragged link to use
WebKit's measurement and drawing. Also made the look match
the bookmarks bar text.

Reviewed by Maciej.

  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]): (-[WebHTMLView _handleMouseDragged:]):
3:43 PM Changeset in webkit [4706] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3332622 -- Safari Abbreviates Attribute Names in EMBED tags

Reviewed by Richard

  • khtml/html/htmltokenizer.h: bumped fixed max length of attributes from 14 to 1024. Theoretically they could be any arbitrary length, but it's more risk than it's worth to rewrite the code that uses the fixed-size buffer that is based on this value.
3:27 PM Changeset in webkit [4705] by rjw
  • 3 edits in trunk/WebKit

Removed unnecessary log.

Reviewed by John.

  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithData:MIMEType:]):

Add another check to use ATSU for Limbu (Unicode 4.0) script.
Also made shouldUseATSU inline.

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU):
3:07 PM Changeset in webkit [4704] by hyatt
  • 27 edits in trunk/WebCore

Change all uses of "konq-" in CSS to "khtml-".

Also rename the CSS3 properties that have either buggy or
incomplete implementations to "-khtml-property" for forward
compatibility (so that people don't have to worry about a buggy
Safari if/when they use the official property names).

Reviewed by john

  • khtml/css/cssparser.cpp: (CSSParser::parseRule): (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::parseFontFamily): (CSSParser::parseShadow):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/css/parser.cpp:
  • khtml/css/parser.h:
  • khtml/css/parser.y:
  • khtml/css/quirks.css:
  • khtml/css/tokenizer.cpp:
  • khtml/css/tokenizer.flex:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLParagraphElementImpl::parseAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLAlignment):
  • khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute):
  • khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute): (HTMLTableCellElementImpl::parseAttribute):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::calcHorizontalMargins):
  • khtml/rendering/render_flexbox.cpp:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp: (RenderTableCell::setStyle):
12:49 PM Changeset in webkit [4703] by sheridan
  • 3 edits in trunk

Safari-91u

12:39 PM Changeset in webkit [4702]
  • 3 copies in tags/Safari-90

This commit was manufactured by cvs2svn to create tag 'Safari-90'.

12:39 PM Changeset in webkit [4701] by sheridan
  • 8 edits in trunk

Safari-90 stamp

Jul 23, 2003:

8:38 PM Changeset in webkit [4700] by mjs
  • 3 edits in trunk/WebKit

Build breakage fix:

Fix WebKit to build with the latest Foundation.

  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_isJavaScriptURL]): (-[NSURL _webkit_scriptIfJavaScriptURL]): (-[NSURL _webkit_isFTPDirectoryURL]): (-[NSString _webkit_isFTPDirectoryURL]):
6:51 PM Changeset in webkit [4699] by hyatt
  • 3 edits in trunk/WebCore

Fix opacity to respect clipping.

Reviewed by rjw

  • khtml/rendering/render_layer.cpp: (RenderLayer::paint):
6:38 PM Changeset in webkit [4698] by rjw
  • 7 edits in trunk/WebKit

Fixed 3311725: Added support for key/value binding.
(As a side effect also made icon loading work! In 1.0
it doesn't work unless a secret preference value is set.)

Reviewed by Ken.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]):
  • WebView.subproj/WebView.m: (-[WebView setMainFrameURL:]): (-[WebView mainFrameURL]): (-[WebView isLoading]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]): (-[WebView _completeProgressForConnection:]): (-[WebView _declaredKeys]): (-[WebView setObservationInfo:]): (-[WebView observationInfo]): (-[WebView _willChangeBackForwardKeys]): (-[WebView _didChangeBackForwardKeys]): (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):
5:32 PM Changeset in webkit [4697] by rjw
  • 2 edits in trunk/WebKit

i Fixed 3341119: Crash when content contains nil (0x0) characters.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:atPoint:]):
5:23 PM Changeset in webkit [4696] by darin
  • 11 edits in trunk

WebCore:

Reviewed by John.

  • fixed 2/3 of 3279864 -- remove class_poseAs calls from WebKit (will also remove init routine)
  • kwq/KWQTextArea.h: Add drawing state variable so we can tell the difference between calls to draw the insertion point inside and calls to draw outside the redraw machinery.
  • kwq/KWQTextArea.mm: (-[KWQTextArea displayRectIgnoringOpacity:]): Added. Set drawing flag while in here. This is the method used by KWQWidget to draw. (-[KWQTextArea textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Added. Calls setNeedsDisplay (the NSView version, not the NSTextView override) instead of immediately drawing when asked to draw outside the normal redraw machinery. (-[KWQTextAreaTextView keyDown:]): Call interceptKeyEvent before handling each key down event.
  • kwq/KWQTextField.h: Add drawing state variable so we can tell the difference between calls to draw the insertion point inside and calls to draw outside the redraw machinery.
  • kwq/KWQTextField.mm: (-[KWQTextField displayRectIgnoringOpacity:]): Added. Set drawing flag while in here. This is the method used by KWQWidget to draw. (-[KWQTextField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Added. Calls setNeedsDisplay (the NSView version, not the NSTextView override) instead of immediately drawing when asked to draw outside the normal redraw machinery. (-[KWQTextField textView:shouldHandleEvent:]): Call interceptKeyEvent before handling each key down event. (-[KWQTextField textView:didHandleEvent:]): Call fieldEditorDidMouseDown: after handling each mouse down event.
  • kwq/KWQWidget.mm: (QWidget::paint): Add comment about dependency on displayRectIgnoringOpacity: use in KWQTextArea and KWQTextField.
  • kwq/WebCoreFirstResponderChanges.h: Added a comment about obsolescence.
  • Xcode wanted to change this, because it now knows JavaScriptCore is a framework
  • WebCore.pbproj/project.pbxproj: Munged by Xcode.

WebKit:

Reviewed by John.

  • fixed 2/3 of 3279864 -- remove class_poseAs calls from WebKit (will also remove init routine)
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Only pose as NSTextView and NSWindow if we have an older AppKit. If we have a new enough AppKit, the code in WebCore now takes care of things.
3:56 PM Changeset in webkit [4695] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3340885, invalid colors were being mapped to transparentColor,
thus causing invisible text!

Reviewed by kocienda

  • khtml/css/cssparser.cpp: (CSSParser::parseColorFromValue):
3:48 PM Changeset in webkit [4694] by rjw
  • 14 edits in trunk

WebCore:

Fixed for 3259840. Use ATSU for scripts we don't handle internally,
i.e.: Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian

Also fixed issues with our rendering of Arabic.

Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
parameters instead of scads on individual parameters. Much cleaner.

Reviewed by Maciej.

  • WebCore-combined.exp:
  • WebCore.exp:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.m: (WebCoreMakeTextRun): (WebCoreMakeEmptyTextStyle):

WebKit:

Fixed for 3259840. Use ATSU for scripts we don't handle internally,
i.e.: Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian

Also fixed issues with our rendering of Arabic.

Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
parameters instead of scads on individual parameters. Much cleaner.

Reviewed by Maciej.

  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
  • Misc.subproj/WebStringTruncator.m: (stringWidth):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): (-[WebTextRenderer _setupFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:]): (-[WebTextRenderer _floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _CG_floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _initializeATSUStyle]): (-[WebTextRenderer _createATSUTextLayoutForRun:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
3:36 PM Changeset in webkit [4693] by hyatt
  • 5 edits in trunk/WebCore

Clean up the mess left by a couple of previous checkins. I had
patched computeLength and computeLengthFloat to take a CSSStyleSelector,
but then I came up with a simpler solution that didn't require that
the selector be passed in as an argument. I forgot, however, to revert
the functions back to their original forms. This patch does that.

Reviewed by john

  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLength): (CSSPrimitiveValueImpl::computeLengthFloat):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssstyleselector.cpp:
1:04 PM Changeset in webkit [4692] by kocienda
  • 24 edits in trunk/WebKit

WebKit:

Reviewed by Darin

Removed dependency on Foundation NSURL_NSURLExtras file.
Copied the required methods from that file to WebNSURLExtras,
temporarily renaming the methods that are now in both
places to have a _webkit_ prefix. The names will be changed
back once every one is living on a Foundation version that
no longer contains these methods.

The files below were changed in one of three ways:

  1. Rename _web_URLWithString: to _web_URLWithDataAsString:
  2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
  3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).
  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem URL]):
  • History.subproj/WebHistoryPrivate.m:
  • History.subproj/WebURLsWithTitles.m: (+[WebURLsWithTitles URLsFromPasteboard:]):
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]):
  • Misc.subproj/WebIconLoader.m:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (ReleaseIfNotNULL): (+[NSURL _web_URLWithDataAsString:]): (+[NSURL _web_URLWithDataAsString:relativeToURL:]): (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_displayableString]): (-[NSURL _web_URLStringLength]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_isJavaScriptURL]): (-[NSURL _webkit_scriptIfJavaScriptURL]): (-[NSURL _webkit_isFTPDirectoryURL]): (-[NSURL _webkit_shouldLoadAsEmptyDocument]): (isHexDigit): (hexDigitValue): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_stringByReplacingValidPercentEscapes]): (-[NSString _webkit_scriptIfJavaScriptURL]):
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
  • Plugins.subproj/WebNullPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]):
  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _shouldReloadForCurrent:andDestination:]): (-[WebFrame _URLsMatchItem:]):
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient loadWithRequest:]): (-[WebMainResourceClient setDefersCallbacks:]):

WebBrowser:

Reviewed by Darin

Removed dependency on Foundation NSURL_NSURLExtras file.
Copied the required methods from that file to WebNSURLExtras
in WebKit. WebBrowser code now depends on that file instead.
In order to avoid method name collisions, the WebNSURLExtras
some methods have been temporarily renamed to have a _webkit_
prefix. The names will be changed back once every one is
living on a Foundation version that no longer contains these methods.

The files below were changed in one of three ways:

  1. Rename _web_URLWithString: to _web_URLWithDataAsString:
  2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
  3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).
  • AppController.m: (-[AppController handleURLEvent:withReplyEvent:]):
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserDocument.m: (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument goToScriptSpecifiedURL]): (-[BrowserDocument goHome:]):
  • BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): (-[BrowserDocumentController URLFromShortcutFile:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToURL:windowPolicy:]):
  • BrowserNSNetServiceExtras.m: (-[NSNetService URL]):
  • BrowserNSStringExtras.m: (-[NSString possibleURLsForUserTypedString]): (-[NSString bestURLForUserTypedString]):
  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): (-[WebBookmark URLsForGoToAllWithTitles:]):
  • BrowserWebController.m: (-[BrowserWebView mouseoverTextForElement:modifierFlags:]): (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebView webView:decidePolicyForMIMEType:request:frame:decisionListener:]): (-[BrowserWebView locationFieldURL]): (-[BrowserWebView goToRequest:withTabLabel:allowJavaScript:waitInQueue:]): (-[BrowserWebView goToURL:withFallbackURLs:]):
  • BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocationWithWindowPolicy:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController goToBookmarks]):
  • ContextMenuHandler.m: (-[BrowserWebView goToAddress:]):
  • Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
  • DownloadProgressEntry.m:
  • FrameProgressEntry.m: (-[FrameProgressEntry URL]):
  • GlobalHistory.m: (-[GlobalHistory updateDisplayTitleForHistoryItem:]):
  • GoogleSearchChannel.m: (-[GoogleSearchChannel URLWithSearchCriteria:]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor launchApplicationSheetEnded:returnCode:contextInfo:]): (-[LoadProgressMonitor pluginErrorSheetEnded:returnCode:contextInfo:]):
  • LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:dataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
  • LocationFieldEditor.m: (-[LocationFieldEditor paste:]):
  • Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences setStyleSheetPathPreference:]):
  • RendezvousController.m: (-[RendezvousController init]):
  • ResourceProgressEntry.m: (-[ResourceProgressEntry open]): (-[ResourceProgressEntry download]):
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner setSingleTestURL:]): (-[PageLoadTestRunner loadTestSuiteFile:]): (-[PageLoadTestRunner pageLoadStarted:]):
  • TitleBarButton.m: (-[TitleBarButton showPathRepresentingPopUpMenuForEvent:URL:]):
  • URLCompletionController.m:
  • WebBookmarkLeaf.m: (-[WebBookmarkLeaf setURLString:]):
11:07 AM Changeset in webkit [4691] by hyatt
  • 3 edits in trunk/WebCore

Temporary hack to ensure that the layout tests will not all
be failures if/when the layout tests regression gets fixed.
Will remove once we can run the tests.

Reviewed by ken

  • khtml/rendering/render_block.cpp:

Jul 22, 2003:

11:35 PM Changeset in webkit [4690] by hyatt
  • 11 edits
    3 deletes in trunk/WebCore

Allow HTML and BODY to be any display type. This patch primarily eliminates the
RenderBody class and makes the code that deals with background propagation smart
enough to locate the correct renderers for the HTML and BODY elements (by crossing
back into the DOM tree).

Reviewed by darin

  • ForwardingHeaders/rendering/render_body.h: Removed.
  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument):
  • khtml/html/html_baseimpl.h:
  • khtml/rendering/render_body.cpp: Removed.
  • khtml/rendering/render_body.h: Removed.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations): (RenderBox::repaint):
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::isBody):
  • khtml/rendering/render_object.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::createRenderer):
11:02 PM Changeset in webkit [4689] by darin
  • 6 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

  • fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu
  • kwq/mac-encodings.txt: Added "Shift_JIS_X0213-2000". Changed all non-HKSCS Big5 encodings to use the DOS variant of Big5 as requested by Peter Edberg, but left Big5-HKSCS alone.
  • kwq/KWQCharsets.mm: Added kCFStringEncodingBig5_DOSVariant constant.
  • kwq/KWQCharsetData.c: Regenerated.
  • fixed 3100151 -- subframes without explicit charset settings should inherit from parent, not use default
  • khtml/khtml_part.cpp: (KHTMLPart::write): Get the default encoding from the parent part, if there is one.

WebBrowser:

Reviewed by Maciej.

  • fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu

Since Shift JIS X0213 does not yet have an IANA name, had to change the code
to get the name another way. This led me to change the menu items to work by having
the character set name in the representedObject instead of the CFString character set
code in the tag.

  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Set the state of a changeTextEncoding: menu item based on the represented object, not the tag. (-[BrowserWindowController changeTextEncoding:]): Pass the represented object into setCustomTextEncodingName: rather than calling CFStringConvertEncodingToIANACharSetName.
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences updateDefaultCharacterSetPopup]): (-[AppearancePreferences takeDefaultCharacterSetFrom:]):
  • TextEncodingMenu.m: Added both kCFStringEncodingShiftJIS_X0213_00 and kCFStringEncodingBig5_HKSCS_1999 to the menu. (-[NSMenu addItemToMenuForEncoding:withTarget:action:]): Get the name using CFStringConvertEncodingToIANACharSetName, with hardcoded fallbacks for kCFStringEncodingGB_2312_80 and kCFStringEncodingShiftJIS_X0213_00, which do not have their IANA names in the table. Put the name in the represented object instead of putting the encoding constant in the tag. No need for the separatorItemWithNonConflictingTag method any more, since a character set name of nil does not ever get used (unlike a tag of 0, which was used for US-ASCII). (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Use the represented object check to detect the end of a group rather than checking the tag. No need for the separatorItemWithNonConflictingTag method (as above).
  • English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.
9:41 PM Changeset in webkit [4688] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
1:48 PM Changeset in webkit [4687]
  • 2 copies
    2 deletes in tags/Safari-89~1

This commit was manufactured by cvs2svn to create tag 'Safari-89~1'.

1:48 PM Changeset in webkit [4686] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

Remove -seg_addr_table_filename to fix build.

11:24 AM Changeset in webkit [4685] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3293898, list bullets in ordered lists with an inside list
position were rendering as though they had a width of 0. This was
a bug in KWQFontMetrics, which needed to handle the case where a
length of -1 was passed in to the width method (in which case
you should use the length of the whole string).

Reviewed by john

  • kwq/KWQFontMetrics.mm: (QFontMetrics::width):
9:40 AM Changeset in webkit [4684] by hyatt
  • 13 edits in trunk/WebCore

Fix for mozilla.org front page. This patch re-architects
align="left" and align="right" (for rtl and ltr directionality
respectively). The attributes are mapped to custom text-align
values, konq-left and konq-right, just as was done with the
center/middle attributes for alignment.

A number of "hack" style rules have been dropped from html4.css
and replaced with this C++ code that now works in the general
case for any children of align="left/right" divs and tds.

In addition, absmiddle support has been added for <td>s.

For RTL blocks, there is also a regression fix (this was probably
the #1 culprit for mangled placement of blocks in Hebrew Web
pages). The old code was doing byzantine math that happened to
work out. When I tried to simplify it before 1.0, I missed a spot
and basically broke margin handling on RTL blocks completely.

Reviewed by mjs

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLParagraphElementImpl::parseAttribute):
  • khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::calcHorizontalMargins):
  • khtml/rendering/render_style.h:

Jul 21, 2003:

3:53 PM Changeset in webkit [4683] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3333557, crash on www.dremedia.com. markDescendants in RenderBlock
was not passing in its argument in the recursive step, so the float wasn't
getting properly cleared out of everyone's lists.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
2:19 PM Changeset in webkit [4682] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3182596, percentage height tables with cells that specify
tiny percentage heights used that height even if it was smaller
than the cell's minimum required height.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
1:41 PM Changeset in webkit [4681] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3316867 -- tabbing to textarea below visible part of page doesn't scroll down
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added call to _KWQ_scrollFrameToVisible to match the one in KWQTextField.
1:29 PM Changeset in webkit [4680] by hyatt
  • 3 edits in trunk/WebCore

Fix removeAttributeNode. This is David Faure's patch.

Reviewed by me

  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::removeAttribute):
1:21 PM Changeset in webkit [4679] by hyatt
  • 4 edits in trunk/WebCore

Checking in David Faure's patch that fixes getElementsByTagName(*).

Reviewed by me

  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::getElementsByTagNameNS): (TagNodeListImpl::nodeMatches):
7:31 AM Changeset in webkit [4678] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me.

Fixed build breaker.

Removed glyphCountFromFont function. It was used only in an
ERROR function, which does not compile in on deployment
builds, causing a "defined, but not used warning".

As this function is only a one-liner call into ATS, I
replaced the usage in the ERROR call with a call to the
ATS function directly.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:])
Note: See TracTimeline for information about the timeline view.