Timeline
Jul 29, 2003:
- 6:36 PM Changeset in webkit [4729] by
-
- 3 edits in trunk/WebCore
Use the new KURL getNSURL() method to create an NSURL.
Reviewed by darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
- 5:39 PM Changeset in webkit [4728] by
-
- 7 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3311756 -- REGRESSION (76-77): radio buttons in different forms act as the same set by rolling out old fix for 3158411 -- radio button groups are supposed to be per-form The real bug at flyglobespan.com is what's fixed below.
- khtml/html/html_formimpl.h:
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::radioClicked): (HTMLInputElementImpl::~HTMLInputElementImpl): (HTMLInputElementImpl::setType): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset): (HTMLInputElementImpl::setChecked): (HTMLInputElementImpl::isEditable):
- khtml/xml/dom_docimpl.cpp:
- khtml/xml/dom_docimpl.h:
- fixed 3158411 -- re-opened form is one form in other browsers, multiple forms in Safari (flyglobespan.com)
- khtml/html/htmlparser.cpp: (KHTMLParser::getElement): Don't open a form if we encounter a form element inside another form.
- 11:00 AM Changeset in webkit [4727] by
-
- 4 edits in trunk/WebCore
WebCore:
- fixed 3346707 -- AutoFill does not fill in email address on Apple Store new account page
Reviewed by Darin
- kwq/KWQRegExp.h:
- kwq/KWQRegExp.mm: (QRegExp::searchRev): This method (that Trey had added) used a placeholder 2nd parameter that was always -1 and should have been ignored. But it was being passed into QRegExp::match as the starting index, which happened to work in many cases, but not if the byte of memory before the string happened to be a null character. Fixed by eliminating the placeholder parameter entirely.
WebBrowser:
- fixed 3345689 -- Safari-89: timeout alert sheet sometimes shows for the wrong tab
Reviewed by Darin
- BrowserWindowController.m: (-[BrowserWindowController closeTab:]): We were removing the old tab, then switching to the next tab. But removing the old tab causes NSTabView to switch to the previous tab, so there was an instant where the previous tab was switched in and thus felt compelled to put up its pending sheet. Fixed by switching to new tab before removing old one, which should also be a slight speed improvement, since we bypass going to the wrong tab momentarily.
Jul 28, 2003:
- 6:23 PM Changeset in webkit [4726] by
-
- 3 edits in trunk/WebKit
Fixed 3323866. Provide SPI to IB to enable scoping of preferences
values on a document-by-document basis.
Reviewed by Maciej.
- WebView.subproj/WebPreferences.m: (-[WebPreferencesPrivate dealloc]): (-[WebPreferences initWithIdentifier:]): (-[WebPreferences initWithCoder:]): (+[WebPreferences _userDefaultsKeysForIB]): (+[WebPreferences _setIBCreatorID:]): (+[WebPreferences _IBCreatorID]): (-[WebPreferences _concatenateKeyWithIBCreatorID:]):
- WebView.subproj/WebPreferencesPrivate.h:
- 5:55 PM Changeset in webkit [4725] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej.
- fixed 3344647 -- reachedTerminalState assertion in WebBaseResourceHandleDelegate.m
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]): Use [super cancelWithError:] rather than [self receivedError:]. I checked carefully to see that this code now does everything the old code did (and a bit more).
- 5:10 PM Changeset in webkit [4724] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Richard.
- fixed 3240814 - LEAK: 120 byte leak in JavaScript parser in Sherlock Movies channel
- kjs/internal.cpp: (Parser::parse): ref() and deref() the program node, to make sure to clean up properly, before deleting it. (InterpreterImp::checkSyntax): Likewise.
- 2:58 PM Changeset in webkit [4723] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- fixed 3343050 - nil-deref in saveInterpreterBuiltins running Sherlock via MallocDebug in Panther7B20
- fixed 3343942 - Safari crashes when clicking on link w/ JavaScript turned off
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveInterpreterBuiltins): Don't attempt to save when JavaScript is off. (KWQKHTMLPart::restoreInterpreterBuiltins): Don't attempt to restore when JavaScript is off. (KWQKHTMLPart::saveWindowProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::saveLocationProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::restoreWindowProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::restoreLocationProperties): Remove ERROR, since that case is normal when JS is off.
- 2:24 PM Changeset in webkit [4722] by
-
- 3 edits in trunk/WebKit
Fixed 3341859.
Check that the WebHTMLView is initialized in viewWillMoveToWindow: and
viewDidMoveToWindow. Don't do anything if we aren't initialized. This
happens when decoding a WebView. When WebViews are decoded their subviews
are created by initWithCoder: and so won't be normally initialized. The
stub views are discarded by WebView.
Reviewed by John.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]):
- 1:58 PM Changeset in webkit [4721] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed 3279864 -- remove class_poseAs calls from WebKit
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Call _setDrawsOwnDescendants, if we have a new enough AppKit.
- WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Don't pose as NSView, if we have a new enough AppKit.
- 1:39 PM Changeset in webkit [4720] by
-
- 3 edits in trunk/WebCore
Fix build bustage on my buggy panther compiler.
Reviewed by darin
- kwq/KWQLineEdit.mm: (QLineEdit::~QLineEdit):
- 1:37 PM Changeset in webkit [4719] by
-
- 10 edits in trunk/WebKit
Reviewed by John
Fix for this bug:
<rdar://problem/3336933>: REGRESSION (Panther): Mozilla build downloaded
with wrong extension, bad file size (gzip)
Use new delegate methods that allow for the correct reporting
of progress in cases where Foundation-level content decoding
has been performed on data received
- WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:didReceiveData:lengthReceived:]):
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):
- 1:32 PM Changeset in webkit [4718] by
-
- 3 edits in trunk/WebCore
Fix for 3343250, XML didn't know how to make implicit tbodies when starting new elements,
nor did it know to skip implicit elements when popping its element stack.
Reviewed by darin
- khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): (XMLHandler::endElement):
- 1:16 PM Changeset in webkit [4717] by
-
- 2 edits in trunk/WebKit
Reviewed by Richard.
- fixed leak of WebDataRequestParameters objects
- WebView.subproj/WebDataProtocol.m: (-[NSMutableURLRequest _webDataRequestParametersForWriting]): Release the WebDataRequestParameters object after putting it in the dictionary.
- 10:14 AM Changeset in webkit [4716] by
-
- 2 edits in trunk/WebKit
- fixed 3236815 -- bitmap TIFFs at > 72 dpi are scaled incorrectly in Safari when viewed standalone (uspto.gov)
Reviewed by Darin
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _adjustSizeToPixelDimensions]): call setScalesWhenResized:YES
Jul 25, 2003:
- 3:04 PM Changeset in webkit [4715] by
-
- 2 edits in trunk/WebKit
Fixed 3344519. Prevent infinite recursion attempting font substitution.
Reviewed by Darin.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
- 2:22 PM Changeset in webkit [4714] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed 3280582 - REGRESSION (74-85): authentication sheet doesn't state that previous login was incorrect
- Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Use chall, the parameter, not challenge, the not-yet-set ivar so we get the right failure count &c.
- 1:47 PM Changeset in webkit [4713] by
-
- 6 edits in trunk/WebCore
Rename box and inline-box to -khtml-box and -khtml-inline-box.
Reviewed by john
- khtml/css/cssparser.cpp: (CSSParser::parseValue):
- khtml/css/cssvalues.c: (hash_val): (findValue):
- khtml/css/cssvalues.h:
- khtml/css/cssvalues.in:
- 1:22 PM Changeset in webkit [4712] by
-
- 21 edits in trunk/WebCore
Fix for 3343529, inline blocks crashing Safari. There were lots of problems with
inlne-blocks. This code gets basic inline-blocks working properly (with no crashes).
Several functions have been patched to take an isRootLineBox parameter. This is used
to tell whether you're supposed to examine the root line box for a block or the block
itself. In the case of baselinePosition and lineHeight, it indicates whether the caller
wants to measure the outside or inside of the box.
The outside of an inline-block is like a replaced element (e.g., an image), but the
inside is like a block, e.g., you want measurements for
the line height and baseline position of a root line box for that block.
Similarly, createInlineBox has been patched in order to know whether you're making a
root inline box *inside* the inline-block or an inline box that *encompasses* the
inline-block element (like you'd do for an image).
A number of places had isInline() calls and needed to be patched to also check
isInlineBlockOrInlineTable(). How to treat the inline-block again basically depends
on whether the caller is looking at the outside of the block (in which case you're like
an inline replaced element) or the inside of the block (in which case you're just like
a block).
Reviewed by darin
- ChangeLog:
- khtml/rendering/bidi.cpp:
- khtml/rendering/render_block.cpp:
- khtml/rendering/render_block.h:
- khtml/rendering/render_box.cpp: (RenderBox::calcWidth): (RenderBox::calcHeight):
- khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_form.cpp: (RenderFormElement::baselinePosition): (RenderButton::baselinePosition): (RenderSubmitButton::baselinePosition): (RenderSelect::baselinePosition):
- khtml/rendering/render_form.h:
- khtml/rendering/render_line.cpp: (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::computeLogicalBoxHeights):
- khtml/rendering/render_list.cpp: (RenderListMarker::lineHeight): (RenderListMarker::baselinePosition):
- khtml/rendering/render_list.h:
- khtml/rendering/render_object.cpp: (RenderObject::sizesToMaxWidth): (RenderObject::getVerticalPosition): (RenderObject::lineHeight): (RenderObject::baselinePosition): (RenderObject::createInlineBox):
- khtml/rendering/render_object.h:
- khtml/rendering/render_replaced.cpp: (RenderReplaced::lineHeight): (RenderReplaced::baselinePosition):
- khtml/rendering/render_replaced.h:
- khtml/rendering/render_table.cpp:
- khtml/rendering/render_table.h:
- khtml/rendering/render_text.cpp: (RenderText::lineHeight): (RenderText::baselinePosition): (RenderText::createInlineBox):
- khtml/rendering/render_text.h:
- 12:54 PM Changeset in webkit [4711] by
-
- 2 edits in trunk/WebKit
Use 11 point bold, instead of 12 point bold, to draw dragged link
labels. This matches the text drawn in the bookmarks bar.
Reviewed by John.
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]):
- 3:27 AM Changeset in webkit [4710] by
-
- 3 edits in trunk/WebCore
Fix for 3343527, crash when attempting to access rules in the CSS OM.
Our KWQListImpl doesn't null check accesses, so anything out
of bounds would cause a crash.
Reviewed by mjs
- kwq/KWQListImpl.mm: (KWQListImpl::at):
- 3:10 AM Changeset in webkit [4709] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler
- khtml/rendering/render_form.cpp: (RenderTextArea::handleFocusOut): Check if we still have an element. It could have gone away while handling an event that replaced some or all of the document, and if we're gonna be destroyed soon then there's no point doing this work anyway.
- 2:11 AM Changeset in webkit [4708] by
-
- 7 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler
- khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter): We want to ref element() across this call, but it could get unset, so store it in a local variable.
- kwq/KWQLineEdit.h:
- kwq/KWQLineEdit.mm: (QLineEdit::~QLineEdit): invalidate our KWQTextField.
- kwq/KWQTextField.h:
- kwq/KWQTextField.mm: (-[KWQTextField invalidate]): Set widget to NULL. (-[KWQTextField action:]): Do nothing if widget is NULL. (-[KWQTextField controlTextDidBeginEditing:]): Likewise. (-[KWQTextField controlTextDidEndEditing:]): Likewise. (-[KWQTextField controlTextDidChange:]): Likewise. (-[KWQTextField control:textShouldBeginEditing:]): Likewise. (-[KWQTextField control:textShouldEndEditing:]): Likewise. (-[KWQTextField control:didFailToFormatString:errorDescription:]): Likewise. (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): Likewise. (-[KWQTextField control:isValidObject:]): Likewise. (-[KWQTextField control:textView:doCommandBySelector:]): Likewise. (-[KWQTextField stringValue]): Likewise. (-[KWQTextField setStringValue:]): Likewise. (-[KWQTextField setFont:]): Likewise. (-[KWQTextField nextKeyView]): Likewise. (-[KWQTextField previousKeyView]): Likewise. (-[KWQTextField nextValidKeyView]): Likewise. (-[KWQTextField previousValidKeyView]): Likewise. (-[KWQTextField fieldEditorDidMouseDown:]): Likewise. (-[KWQTextField textView:shouldHandleEvent:]): Likewise. (-[KWQTextField textView:didHandleEvent:]): Likewise. (-[KWQTextField setHasFocus:]): Likewise.
