Timeline
Jul 30, 2003:
- 7:29 PM Changeset in webkit [4747]
-
- 1 copy319 deletes in branches/unlabeled-1.15.14
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.15.14'.
- 7:29 PM Changeset in webkit [4746] by
-
- 17 edits in trunk
WebKit:
Preparation for 3095376.
Reviewed by Maciej.
- Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
- Misc.subproj/WebStringTruncator.m: (stringWidth):
- WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForRun:style:widths:]): (-[WebTextRenderer _floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _createATSUTextLayoutForRun:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer checkSelectionPoint:style:position:reversed:]):
WebCore:
Preparation for 3095376.
Reviewed by Maciej.
- WebCore-combined.exp:
- WebCore.exp:
- khtml/rendering/font.cpp: (Font::checkSelectionPoint):
- khtml/rendering/font.h:
- khtml/rendering/render_text.cpp: (TextRun::checkSelectionPoint):
- kwq/KWQFontMetrics.h:
- kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): (QFontMetrics::checkSelectionPoint):
- kwq/KWQPainter.mm: (QPainter::drawText):
- kwq/WebCoreTextRenderer.h:
- kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeTextRun): (WebCoreInitializeEmptyTextStyle):
- 5:46 PM Changeset in webkit [4745] by
-
- 4 edits in trunk/WebCore
Fix for 3274144, floats in Help Viewer overlapped when they shouldn't have.
lineWidth was overflowing (and positionNewFloats was also sometimes not called
when it should have been).
Reviewed by darin
- khtml/rendering/bidi.cpp:
- khtml/rendering/render_block.cpp:
- 5:38 PM Changeset in webkit [4744] by
-
- 1 edit1 add in trunk/LayoutTests
Ignore layout test results.
- 5:37 PM Changeset in webkit [4743] by
-
- 18 deletes in trunk/LayoutTests
Remove actual and diffs checked in by accident.
- 5:21 PM Changeset in webkit [4742] by
-
- 245 adds in trunk/LayoutTests/css1
More layout tests here.
- 5:18 PM Changeset in webkit [4741]
-
- 1 copy104 deletes in branches/unlabeled-1.1.14
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.1.14'.
- 5:18 PM Changeset in webkit [4740] by
-
- 842 adds in trunk/LayoutTests
Moving layout tests in here.
- 4:54 PM Changeset in webkit [4739] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Dave.
- fixed problem where some JavaScriptCore symbols had no namespace or prefix
- kjs/grammar.y: Added a define for yylloc to make it use the kjs prefix. This is the same thing done for the rest of the symbols automatically by yacc, but for some reason it's not done for yyloc. Also make automatic() function static.
- kjs/grammar.cpp: Regenerated.
- kjs/lexer.cpp: Use kjsyylloc instead of yyloc.
- pcre/pcre.h: Add defines to prepend kjs prefixes for all the PCRE functions.
- 3:34 PM Changeset in webkit [4738] by
-
- 3 edits in trunk/JavaScriptCore
- Makefile.am: Include the subdirectory with the PCRE code in it.
- 3:19 PM Changeset in webkit [4737] by
-
- 4 edits in trunk/WebCore
Add support for setting the text-shadow's color. This uses a new CG API,
so updating to a fairly recent Panther is required.
Reviewed by rjw
- khtml/css/cssparser.cpp: (CSSParser::parseShadow):
- kwq/KWQPainter.mm: (QPainter::setShadow):
- 3:09 PM Changeset in webkit [4736] by
-
- 1 edit in trunk/WebCore/WebCore-tests.exp
Tweaked for signature change to KWQRegExp::match, to fix build
- 2:03 PM Changeset in webkit [4735] by
-
- 3 edits in trunk/WebCore
Tests:
- qt/qregexp-test.cpp: (main): fixed broken build by removing final parameter to match()
WebCore:
- fixed 3346460 -- images > area (2048x2048) are compressed vertically when displayed as src of img tag
Reviewed by Darin
- khtml/rendering/render_image.cpp: (RenderImage::layout): Just comment out the code that imposes a maximum image size (incorrectly); maybe KDE folks want to make this work, but we don't need to try to prevent large images.
- 2:02 PM Changeset in webkit [4734] by
-
- 1 edit in trunk/WebKit/WebView.subproj/WebViewPrivate.m
Backout hack for IB. IB will deal with the issue internally.
- 1:49 PM Changeset in webkit [4733] by
-
- 1 edit in trunk/WebCore/WebCore-combined.exp
Fixed signature for QRegExp::match in .exp file to fix build
- 1:48 PM Changeset in webkit [4732] by
-
- 2 edits in trunk/WebKit
Fixed 3356518. Added private method called by IB to ensure
that autoresizeSubviews flag is turned on correctly.
Reviewed by mjs.
- WebView.subproj/WebViewPrivate.m: (-[WebView _finishedMakingConnections]):
- 12:04 PM Changeset in webkit [4731] by
-
- 9 edits in trunk
- JavaScriptCore part of fix for 3284525 -- AutoFill fills in only e-mail address field of New Account form on Apple Store Japan
Reviewed by Darin
- JavaScriptCore.pbproj/project.pbxproj: Mark pcre.h as a Private header
WebCore:
- WebCore part of fix for 3284525 -- AutoFill fills in only e-mail address field of New Account form on Apple Store Japan
There were two problems: the regex library being used by
KWQRegExp.mm didn't handle unicode at all, and the way we
were using word boundaries in our regular expressions didn't
work with Japanese.
Reviewed by Darin
- kwq/KWQKHTMLPart.mm: (regExpForLabels): Redid the way word boundaries are used; the old way didn't work with PCRE, and also didn't work with Japanese.
- kwq/KWQRegExp.h: removed treatStartAsStartOfInput parameter to match() that Trey had added; it was being used incorrectly and was not necessary.
- kwq/KWQRegExp.mm: (compareStringOffsets), (createSortedOffsetsArray), (convertCharacterOffsetsToUTF8ByteOffsets), (convertUTF8ByteOffsetsToCharacterOffsets): Code copied from JavaScriptCore/regexp.cpp to convert between byte and character offsets. Darin preferred that I copy these methods rather than make them public in JavaScriptCore/regexp.h. (QRegExp::KWQRegExpPrivate::compile): converted from regex.h style to pcre.h style (QRegExp::KWQRegExpPrivate::~KWQRegExpPrivate): ditto (QRegExp::match): ditto (QRegExp::search): removed parameter to match() (QRegExp::searchRev): ditto
- kwq/KWQString.mm: (QString::replace): removed parameter to match()
WebBrowser:
- WebBrowser part of fix for 3284525 -- AutoFill fills in only e-mail address field of New Account form on Apple Store Japan
Reviewed by Darin
- FormCompletionController.m: (-[FormToABBinder _indexMapping:]): Replace ASSERT with ERROR when label tables have duplicates. The Japanese localized file that I was using to test with had such duplicates, and was crashing on me.
- 11:48 AM Changeset in webkit [4730] by
-
- 3 edits in trunk/WebCore
Fixed 3349598. Deal gracefully with <li> items that
are not in a <ol> or <ul>, instead of crashing!
Reviewed by Ken.
- kwq/KWQKHTMLPart.mm: (listParent): (KWQKHTMLPart::attributedString):
Jul 29, 2003:
- 6:36 PM Changeset in webkit [4729] by
-
- 3 edits in trunk/WebCore
Use the new KURL getNSURL() method to create an NSURL.
Reviewed by darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
- 5:39 PM Changeset in webkit [4728] by
-
- 7 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3311756 -- REGRESSION (76-77): radio buttons in different forms act as the same set by rolling out old fix for 3158411 -- radio button groups are supposed to be per-form The real bug at flyglobespan.com is what's fixed below.
- khtml/html/html_formimpl.h:
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::radioClicked): (HTMLInputElementImpl::~HTMLInputElementImpl): (HTMLInputElementImpl::setType): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset): (HTMLInputElementImpl::setChecked): (HTMLInputElementImpl::isEditable):
- khtml/xml/dom_docimpl.cpp:
- khtml/xml/dom_docimpl.h:
- fixed 3158411 -- re-opened form is one form in other browsers, multiple forms in Safari (flyglobespan.com)
- khtml/html/htmlparser.cpp: (KHTMLParser::getElement): Don't open a form if we encounter a form element inside another form.
- 11:00 AM Changeset in webkit [4727] by
-
- 4 edits in trunk/WebCore
WebCore:
- fixed 3346707 -- AutoFill does not fill in email address on Apple Store new account page
Reviewed by Darin
- kwq/KWQRegExp.h:
- kwq/KWQRegExp.mm: (QRegExp::searchRev): This method (that Trey had added) used a placeholder 2nd parameter that was always -1 and should have been ignored. But it was being passed into QRegExp::match as the starting index, which happened to work in many cases, but not if the byte of memory before the string happened to be a null character. Fixed by eliminating the placeholder parameter entirely.
WebBrowser:
- fixed 3345689 -- Safari-89: timeout alert sheet sometimes shows for the wrong tab
Reviewed by Darin
- BrowserWindowController.m: (-[BrowserWindowController closeTab:]): We were removing the old tab, then switching to the next tab. But removing the old tab causes NSTabView to switch to the previous tab, so there was an instant where the previous tab was switched in and thus felt compelled to put up its pending sheet. Fixed by switching to new tab before removing old one, which should also be a slight speed improvement, since we bypass going to the wrong tab momentarily.
Jul 28, 2003:
- 6:23 PM Changeset in webkit [4726] by
-
- 3 edits in trunk/WebKit
Fixed 3323866. Provide SPI to IB to enable scoping of preferences
values on a document-by-document basis.
Reviewed by Maciej.
- WebView.subproj/WebPreferences.m: (-[WebPreferencesPrivate dealloc]): (-[WebPreferences initWithIdentifier:]): (-[WebPreferences initWithCoder:]): (+[WebPreferences _userDefaultsKeysForIB]): (+[WebPreferences _setIBCreatorID:]): (+[WebPreferences _IBCreatorID]): (-[WebPreferences _concatenateKeyWithIBCreatorID:]):
- WebView.subproj/WebPreferencesPrivate.h:
- 5:55 PM Changeset in webkit [4725] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej.
- fixed 3344647 -- reachedTerminalState assertion in WebBaseResourceHandleDelegate.m
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]): Use [super cancelWithError:] rather than [self receivedError:]. I checked carefully to see that this code now does everything the old code did (and a bit more).
- 5:10 PM Changeset in webkit [4724] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Richard.
- fixed 3240814 - LEAK: 120 byte leak in JavaScript parser in Sherlock Movies channel
- kjs/internal.cpp: (Parser::parse): ref() and deref() the program node, to make sure to clean up properly, before deleting it. (InterpreterImp::checkSyntax): Likewise.
- 2:58 PM Changeset in webkit [4723] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- fixed 3343050 - nil-deref in saveInterpreterBuiltins running Sherlock via MallocDebug in Panther7B20
- fixed 3343942 - Safari crashes when clicking on link w/ JavaScript turned off
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveInterpreterBuiltins): Don't attempt to save when JavaScript is off. (KWQKHTMLPart::restoreInterpreterBuiltins): Don't attempt to restore when JavaScript is off. (KWQKHTMLPart::saveWindowProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::saveLocationProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::restoreWindowProperties): Remove ERROR, since that case is normal when JS is off. (KWQKHTMLPart::restoreLocationProperties): Remove ERROR, since that case is normal when JS is off.
- 2:24 PM Changeset in webkit [4722] by
-
- 3 edits in trunk/WebKit
Fixed 3341859.
Check that the WebHTMLView is initialized in viewWillMoveToWindow: and
viewDidMoveToWindow. Don't do anything if we aren't initialized. This
happens when decoding a WebView. When WebViews are decoded their subviews
are created by initWithCoder: and so won't be normally initialized. The
stub views are discarded by WebView.
Reviewed by John.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]):
- 1:58 PM Changeset in webkit [4721] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed 3279864 -- remove class_poseAs calls from WebKit
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Call _setDrawsOwnDescendants, if we have a new enough AppKit.
- WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Don't pose as NSView, if we have a new enough AppKit.
- 1:39 PM Changeset in webkit [4720] by
-
- 3 edits in trunk/WebCore
Fix build bustage on my buggy panther compiler.
Reviewed by darin
- kwq/KWQLineEdit.mm: (QLineEdit::~QLineEdit):
- 1:37 PM Changeset in webkit [4719] by
-
- 10 edits in trunk/WebKit
Reviewed by John
Fix for this bug:
<rdar://problem/3336933>: REGRESSION (Panther): Mozilla build downloaded
with wrong extension, bad file size (gzip)
Use new delegate methods that allow for the correct reporting
of progress in cases where Foundation-level content decoding
has been performed on data received
- WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:didReceiveData:lengthReceived:]):
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):
- 1:32 PM Changeset in webkit [4718] by
-
- 3 edits in trunk/WebCore
Fix for 3343250, XML didn't know how to make implicit tbodies when starting new elements,
nor did it know to skip implicit elements when popping its element stack.
Reviewed by darin
- khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): (XMLHandler::endElement):
- 1:16 PM Changeset in webkit [4717] by
-
- 2 edits in trunk/WebKit
Reviewed by Richard.
- fixed leak of WebDataRequestParameters objects
- WebView.subproj/WebDataProtocol.m: (-[NSMutableURLRequest _webDataRequestParametersForWriting]): Release the WebDataRequestParameters object after putting it in the dictionary.
- 10:14 AM Changeset in webkit [4716] by
-
- 2 edits in trunk/WebKit
- fixed 3236815 -- bitmap TIFFs at > 72 dpi are scaled incorrectly in Safari when viewed standalone (uspto.gov)
Reviewed by Darin
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _adjustSizeToPixelDimensions]): call setScalesWhenResized:YES
Note:
See TracTimeline
for information about the timeline view.
