Timeline
Aug 5, 2003:
- 4:06 PM Changeset in webkit [4773] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- kwq/KWQPainter.mm: (QPainter::drawLine): Print a warning in debug builds when drawing a dashed line. Also, revert accidental commenting of lines that set the dash style.
- 3:18 PM Changeset in webkit [4772] by
-
- 2 edits in trunk/WebKit
Reviewed by John
Fix for this bug:
<rdar://problem/3365035>: Modify WebNSURLExtras to call improved NSURL creation API
- Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithDataAsString:]): Call through to _web_URLWithDataAsString:relativeToURL:. (+[NSURL _web_URLWithDataAsString:relativeToURL:]): Call through to _web_URLWithData:relativeToURL:. (+[NSURL _web_URLWithData:]): Ditto. (+[NSURL _web_URLWithData:relativeToURL:]): Call CFURLCreateAbsoluteURLWithBytes API in CoreFoundation. (-[NSURL _web_originalData]): Use CFURLGetBytes API in CoreFoundation. Also make sure that a relative URL is resolved against its base. (-[NSURL _web_displayableString]): Call _web_originalData to get bytes to use to create the string. (-[NSURL _web_URLStringLength]): Use CFURLGetBytes API in CoreFoundation.
- 2:21 PM Changeset in webkit [4771] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- kjs/list.cpp: (List::copyTail): Test for loop termination with < instead of !=, since i starts at 1 but size could be 0. Do the same for the other loop for consistency's sake.
- 2:16 PM Changeset in webkit [4770] by
-
- 4 edits in trunk/WebCore
Fix for 3127909, copied text matched the document source instead of the
rendered HTML. This patch makes sure that the TextRuns are walked instead
of just blindly pulling the text out of the DOM node.
Reviewed by rjw
- khtml/khtml_part.cpp: (KHTMLPart::selectedText):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
- 1:16 PM Changeset in webkit [4769] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin and Dave.
- fixed 3363557 - REGRESSION (90-91): float:left element inside position:absolute element positioned wrong
- khtml/rendering/render_block.cpp: (RenderBlock::calcInlineMinMaxWidth): Remove attempt to break line after flaot that follows a non-float. Removing this code fixes the regression and leaves pepboys and the meyerweb matrix theme working properly. Also, I could not find any evidence in the CSS2 spec that what this code is trying to do is right.
- 10:38 AM Changeset in webkit [4768] by
-
- 3 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3364251>: Modify KURL to call improved NSURL creation API
- kwq/KWQKURL.mm: (KURL::getNSURL): Modify to use CFURLCreateAbsoluteURLWithBytes to create the NSURL.
- 10:33 AM Changeset in webkit [4767] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej
In KWQKURL.mm, we copy the contents of a URL path from a source buffer
to a destination buffer. In the loop, we often access dst[-1]. It was
not entirely clear that this did not underrun the buffer. Upon further
inspection, it seems clear that it does not, but this small change
makes this more clear, and adds an assertion that all is well with
regard to indexing into the dst buffer.
- kwq/KWQKURL.mm: (copyPathRemovingDots)
Aug 4, 2003:
- 6:38 PM Changeset in webkit [4766] by
-
- 3 edits in trunk/WebKit
Fixed 3363011. Pass b/f related key down events to super if b/f is disabled.
Reviewed by Chris.
- WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]):
Fixed 3363345. Retain static array used by IB to present WebView's bindable keys.
Review by Maciej
- WebView.subproj/WebViewPrivate.m: (-[WebView _declaredKeys]):
- 4:44 PM Changeset in webkit [4765] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
Fix for this bug:
<rdar://problem/3363318>: REGRESSION: Plug-in content doesn't show up, animate etc
WebNetscapePluginConnectionDelegate must implement this method:
- (void)connection:(NSURLConnection *)con didReceiveData:(NSData *)data lengthReceived:(long long)lengthReceived
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:])
- 2:41 PM Changeset in webkit [4764] by
-
- 2 edits in trunk/WebKit
Reviewed by Richard.
- fixed 3298153 -- get "screen font while printing" error, bad stuff happens after that (Sherlock, Safari)
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): If we find ourselves in drawRect with the wrong printing mode, that usually means we're being printed as part of some larger print process, so do the layout in printing mode.
- 1:50 PM Changeset in webkit [4763] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3360977>: REGRESSION (7B28-7B29): main webview rejects drop of doc icon from BBEdit
Reviewed by darin.
- Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_dragTypesForURL]): we handle NSFilenamesPboardType
- WebKit.pbproj/project.pbxproj:
- 1:20 PM Changeset in webkit [4762] by
-
- 2 edits in trunk/WebKit
Fixed 3223989. Pass key down events to super if scrolling is disabled.
Reviewed by Chris (Welcome back!).
- WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]):
Aug 1, 2003:
- 5:54 PM Changeset in webkit [4761]
-
- 1 copy95 deletes in branches/unlabeled-1.35.14
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.14'.
- 5:54 PM Changeset in webkit [4760] by
-
- 12 edits in trunk
WebKit:
Fixed 3095376. Implemented correct selection behavior for rtl scripts.
We still use our Arabic and Hebrew layout scheme.
Fixed 3360487. Implemented selection of ATSU rendered code.
Fixed 3360242. Return nil from _bodyBackgroundColor when no
background color specified. This was requested by Doug D.
Reviewed by Maciej.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer pointToOffset:style:position:reversed:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]):
WebCore:
Fixed 3095376. Implemented correct selection behavior for rtl scripts.
We still use our Arabic and Hebrew layout scheme.
Fixed 3360487. Implemented selection of ATSU rendered code.
Fixed 3360242. Return nil from _bodyBackgroundColor when no
background color specified. This was requested by Doug D.
Reviewed by Maciej.
- khtml/rendering/font.cpp: (Font::drawHighlightForText):
- khtml/rendering/font.h:
- khtml/rendering/render_text.cpp: (TextRun::paintSelection):
- kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bodyBackgroundColor):
- kwq/KWQPainter.h:
- kwq/KWQPainter.mm: (QPainter::drawHighlightForText):
- kwq/WebCoreTextRenderer.h:
- 5:47 PM Changeset in webkit [4759] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3265419 - homepage preview doesn't show Images with names longer than 17 chars
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTML):
- 4:33 PM Changeset in webkit [4758] by
-
- 8 edits in trunk
WebCore:
Reviewed by Darin.
- fixed 3339255 - REGRESSION (73-85): javascript failure at gia.apple.com
I fixed this by making sure to cancel any pending redirects before
telling the bridge to load a URL. We don't want a race between
getting back a response and the redirect timer.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge provisionalLoadStarted]): New method - call equivalent part method. We count on the other side of the bridge to call this once it knows a load will really happen (not cancelled by policy, etc).
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::provisionalLoadStarted): cancel pending redirects.
WebKit:
Reviewed by Darin.
- fixed 3339255 - REGRESSION (73-85): javascript failure at gia.apple.com
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): When going to provisional state, tell the bridge that a provisional load started, so it can cancel any pending redirects.
- 4:04 PM Changeset in webkit [4757] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- fixed 3222621 - Cryptic "anonymous function hack" messages in console (10.2.4)
- kjs/lexer.cpp: (Lexer::lex): Remove useless debug spew.
- 3:58 PM Changeset in webkit [4756] by
-
- 3 edits in trunk
Safari-91u versions ... tree is open
- 11:10 AM Changeset in webkit [4755]
-
- 3 copies in tags/Safari-91
This commit was manufactured by cvs2svn to create tag 'Safari-91'.
- 11:10 AM Changeset in webkit [4754] by
-
- 8 edits in trunk
Safari-91 version stamp
- 10:40 AM Changeset in webkit [4753] by
-
- 4 edits in trunk/WebCore
Fix for 3347286, hang on pepboys.com. Text-indent had numerous bugs that
resulted in an infinite loop because some incorrect values were being compared.
This patch changes floats to ignore text-indent when positioning themselves
(as they should).
The maxwidth computation also didn't deal properly with text-indent, applying it
multiple times instead of once, and also only applying it for text and not for
inline replaced elements (images, form controls, etc.).
With these changes pepboys.com renders correctly. This patch also conveniently fixes
the last rendering error on meyerweb's Matrix stylesheet.
Reviewed by darin
- khtml/rendering/render_block.cpp:
- khtml/rendering/render_block.h:
