Timeline
Aug 6, 2003:
- 7:19 PM Changeset in webkit [4782] by
-
- 6 edits in trunk
WebKit:
Fixed 3365378. Edge case text run > 1024 hit by JS generated string. We weren't correctly checking size of string length. Used /2 instead of *2.
Reviewed by Vicki (and Dan!).
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]):
WebCore:
Fixed development build problem. WebCore.exp needed a newline at EOF.
- WebCore-combined.exp:
- 6:35 PM Changeset in webkit [4781] by
-
- 1 edit in trunk/WebCore/WebCore.exp
Added newline to WebCore.exp. W/O newline development builds break.
- 5:11 PM Changeset in webkit [4780] by
-
- 12 edits in trunk
WebKit:
Fixed 3348630. Pick up about 1% by moving implementation of _unicodeDirection to WebCore and inlining.
Reviewed by Ken.
- Misc.subproj/WebUnicode.h:
- Misc.subproj/WebUnicode.m: (_unicodeDirection): (_unicodeJoining): (_unicodeMirrored): (WebKitInitializeUnicode):
- Misc.subproj/WebUnicodeTables.m:
WebCore:
Fixed 3348630. Pick up about 1% by moving implementation of _unicodeDirection to WebCore and inlining.
Reviewed by Ken.
- WebCore-combined.exp:
- WebCore.exp:
- WebCore.pbproj/project.pbxproj:
- kwq/KWQString.h:
- kwq/WebCoreUnicode.cpp:
- kwq/WebCoreUnicode.h:
- 4:52 PM Changeset in webkit [4779] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3161102>: Avoid retain cycles by destroying plug-ins in the page cache before dealloc
Reviewed by rjw.
- History.subproj/WebHistoryItemPrivate.h: added declaration for [WebBackForwardList _clearPageCache]
- WebView.subproj/WebViewPrivate.m: (-[WebView _close]): clear the page cache when we are closing the web view so we call destroy on all the plug-ins on the page cache to break any retain cycles.
- 3:25 PM Changeset in webkit [4778] by
-
- 3 edits in trunk/WebCore
- fixed 3366587 -- Mail quits instantly (no crashlog) trying to reply to a particular message
Reviewed by Richard
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Return nil immediately if startNode is nil.
- 3:15 PM Changeset in webkit [4777] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris Blumenberg.
- fixed 3366173 - crash in DOM::DomShared::ref loading www.berkheiser.net
- khtml/ecma/kjs_html.cpp: (Image::putValue): Check for NULL before refing, because we set onLoadListener with a function that returns NULL if passed a value that's not a function.
- 1:36 PM Changeset in webkit [4776] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin and Dave.
- fixed 3364433 - repro crash in khtml::RenderBlock::nodeAtPoint
- khtml/rendering/render_object.cpp: (RenderObject::removeFromObjectLists): When finding the right parent block to remove a float from, don't stop at floating or positioned elements. They could well have floats in their m_floatingObjects list due to overhang, and failing to remove them leads to crashes.
- 10:38 AM Changeset in webkit [4775] by
-
- 6 edits in trunk/WebKit
Fixed: <rdar://problem/3106525>: Results of JavaScript requests are not returned to plug-ins
Reviewed by darin.
- Plugins.subproj/WebBaseNetscapePluginStream.h:
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setNotifyData:]): new (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): renamed from setResponse (-[WebBaseNetscapePluginStream startStreamWithResponse:]): new (-[WebBaseNetscapePluginStream receivedData:]): tweak (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): tweak (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): tweak
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:targetFrame:]): new
- (-[WebBaseNetscapePluginView loadPluginRequest:]): call …
-
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call loadPluginRequest for JS requests
- Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): call renamed startStreamWithResponse
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): call setNotifyData (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): call renamed startStreamWithResponse
- 7:45 AM Changeset in webkit [4774] by
-
- 5 edits in trunk/WebKit
Reviewed by Richard
Plugins in WebKit need to store URLs in the form of "C-style" strings.
Create and use a new, improved method to make these strings, and do
not traverse through the NSURL absoluteString method, since that can i
introduce errors.
- Misc.subproj/WebNSURLExtras.h: Added _web_URLCString method.
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLCString]): Added.
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): Call new _web_URLCString method. (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Ditto.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView frameStateChanged:]): Ditto. (-[WebBaseNetscapePluginView loadPluginRequest:]): Ditto.
Aug 5, 2003:
- 4:06 PM Changeset in webkit [4773] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- kwq/KWQPainter.mm: (QPainter::drawLine): Print a warning in debug builds when drawing a dashed line. Also, revert accidental commenting of lines that set the dash style.
- 3:18 PM Changeset in webkit [4772] by
-
- 2 edits in trunk/WebKit
Reviewed by John
Fix for this bug:
<rdar://problem/3365035>: Modify WebNSURLExtras to call improved NSURL creation API
- Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithDataAsString:]): Call through to _web_URLWithDataAsString:relativeToURL:. (+[NSURL _web_URLWithDataAsString:relativeToURL:]): Call through to _web_URLWithData:relativeToURL:. (+[NSURL _web_URLWithData:]): Ditto. (+[NSURL _web_URLWithData:relativeToURL:]): Call CFURLCreateAbsoluteURLWithBytes API in CoreFoundation. (-[NSURL _web_originalData]): Use CFURLGetBytes API in CoreFoundation. Also make sure that a relative URL is resolved against its base. (-[NSURL _web_displayableString]): Call _web_originalData to get bytes to use to create the string. (-[NSURL _web_URLStringLength]): Use CFURLGetBytes API in CoreFoundation.
- 2:21 PM Changeset in webkit [4771] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- kjs/list.cpp: (List::copyTail): Test for loop termination with < instead of !=, since i starts at 1 but size could be 0. Do the same for the other loop for consistency's sake.
- 2:16 PM Changeset in webkit [4770] by
-
- 4 edits in trunk/WebCore
Fix for 3127909, copied text matched the document source instead of the
rendered HTML. This patch makes sure that the TextRuns are walked instead
of just blindly pulling the text out of the DOM node.
Reviewed by rjw
- khtml/khtml_part.cpp: (KHTMLPart::selectedText):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
- 1:16 PM Changeset in webkit [4769] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin and Dave.
- fixed 3363557 - REGRESSION (90-91): float:left element inside position:absolute element positioned wrong
- khtml/rendering/render_block.cpp: (RenderBlock::calcInlineMinMaxWidth): Remove attempt to break line after flaot that follows a non-float. Removing this code fixes the regression and leaves pepboys and the meyerweb matrix theme working properly. Also, I could not find any evidence in the CSS2 spec that what this code is trying to do is right.
- 10:38 AM Changeset in webkit [4768] by
-
- 3 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3364251>: Modify KURL to call improved NSURL creation API
- kwq/KWQKURL.mm: (KURL::getNSURL): Modify to use CFURLCreateAbsoluteURLWithBytes to create the NSURL.
- 10:33 AM Changeset in webkit [4767] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej
In KWQKURL.mm, we copy the contents of a URL path from a source buffer
to a destination buffer. In the loop, we often access dst[-1]. It was
not entirely clear that this did not underrun the buffer. Upon further
inspection, it seems clear that it does not, but this small change
makes this more clear, and adds an assertion that all is well with
regard to indexing into the dst buffer.
- kwq/KWQKURL.mm: (copyPathRemovingDots)
Aug 4, 2003:
- 6:38 PM Changeset in webkit [4766] by
-
- 3 edits in trunk/WebKit
Fixed 3363011. Pass b/f related key down events to super if b/f is disabled.
Reviewed by Chris.
- WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]):
Fixed 3363345. Retain static array used by IB to present WebView's bindable keys.
Review by Maciej
- WebView.subproj/WebViewPrivate.m: (-[WebView _declaredKeys]):
- 4:44 PM Changeset in webkit [4765] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
Fix for this bug:
<rdar://problem/3363318>: REGRESSION: Plug-in content doesn't show up, animate etc
WebNetscapePluginConnectionDelegate must implement this method:
- (void)connection:(NSURLConnection *)con didReceiveData:(NSData *)data lengthReceived:(long long)lengthReceived
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:])
- 2:41 PM Changeset in webkit [4764] by
-
- 2 edits in trunk/WebKit
Reviewed by Richard.
- fixed 3298153 -- get "screen font while printing" error, bad stuff happens after that (Sherlock, Safari)
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): If we find ourselves in drawRect with the wrong printing mode, that usually means we're being printed as part of some larger print process, so do the layout in printing mode.
- 1:50 PM Changeset in webkit [4763] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3360977>: REGRESSION (7B28-7B29): main webview rejects drop of doc icon from BBEdit
Reviewed by darin.
- Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_dragTypesForURL]): we handle NSFilenamesPboardType
- WebKit.pbproj/project.pbxproj:
- 1:20 PM Changeset in webkit [4762] by
-
- 2 edits in trunk/WebKit
Fixed 3223989. Pass key down events to super if scrolling is disabled.
Reviewed by Chris (Welcome back!).
- WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]):
