⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 11, 2003:

4:41 PM Changeset in webkit [4804] by hyatt
  • 10 edits in trunk/WebCore

Fix for 3349142, blocks inside inlines with generated content cause the generated
content to get all screwed up, especially if you try to print. This patch fixes
generated content to be continuation-aware (and vice versa), so that the content
behaves correctly when inlines get split.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChild):
  • khtml/rendering/render_inline.cpp: (RenderInline::isInlineContinuation): (RenderInline::addChildToFlow): (RenderInline::cloneInline): (RenderInline::splitInlines):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::continuation): (RenderObject::isInlineContinuation):
  • khtml/rendering/render_object.h:
2:13 PM Changeset in webkit [4803] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3163589>: Macromedia Flash 6 cannot take Asian text entry in Safari

Revidewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView installKeyEventHandler]): new (-[WebBaseNetscapePluginView removeKeyEventHandler]): new (-[WebBaseNetscapePluginView becomeFirstResponder]): call installKeyEventHandler (-[WebBaseNetscapePluginView resignFirstResponder]): call removeKeyEventHandler (-[WebBaseNetscapePluginView keyUp:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (-[WebBaseNetscapePluginView keyDown:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (TSMEventHandler): turn the TSM event into a series of EventRecords and pass them to the plug-in (-[WebBaseNetscapePluginView stop]): call removeKeyEventHandler because resignFirstResponder may not get called
10:22 AM Changeset in webkit [4802] by darin
  • 3 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.h: Fixed some small typo-ish strangenesses.

Aug 8, 2003:

6:00 PM Changeset in webkit [4801] by rjw
  • 6 edits in trunk/WebKit

Lots of healthy cleanup. Introduced width and shaping iterators
to simplify code and remove allocations for large text runs. Should
go further and make more use of these in the future (post panther).

Fixed 3369608. Crash in -[WebTextRenderer _CG_drawRun:style:atPoint:] at lovepucca.net
Fixed 3118050. Crash selecting text at ​http://www.faqs.org/rfcs/rfc2849.html (SELECTION)
Fixed 3371115. Can't correctly select text that contains surrogate pairs

Reviewed by darin.

  • Misc.subproj/WebUnicode.h:
  • Misc.subproj/WebUnicode.m: (prevChar): (nextChar): (prevLogicalCharJoins): (nextLogicalCharJoins): (glyphVariantLogical): (hasShapeForNextCharacter): (shapeForNextCharacter): (initializeCharacterShapeIterator): (shapedString):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (widthForNextCharacter): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]):

Just formatting changed here

  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]):
4:34 PM Changeset in webkit [4800] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): Put "about:blank" in the back/forward item if there is no URL (which happens because there is no data source because the frame has never successfully loaded anything). Perhaps we can do better some day, but this avoids all the major bad effects in a safe way.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:26 PM Changeset in webkit [4799] by hyatt
  • 10 edits in trunk/WebCore

Fix for 3368672, don't allow frames and framesets to be positioned or relpositioned.

Reviewed by darin

  • ChangeLog:
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_object.cpp: (RenderObject::requiresLayer):
  • khtml/rendering/render_object.h:
11:34 AM Changeset in webkit [4798] by sullivan
  • 6 edits in trunk/WebCore

WebCore:

  • fixed 3362481 -- REGRESSION (89-90): clicking in a field causes page to move; esp. bad if the field moves out from under the mouse

Reviewed by Darin

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::currentEventIsMouseDownInWidget): new method
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): only scroll to reveal if currentEventIsMouseDownInWidget is false
  • kwq/KWQTextField.mm: (-[KWQTextField setHasFocus:]): ditto

WebBrowser:

  • fixed 3369587 -- REGRESSION (85-88): window position isn't being saved if moved from default position

Reviewed by Chris

The bug was that when the default window size is set
programmatically to be full screen height, we're setting the
_lastResizeWasProgrammatic bit in WindowController, which
prevents the window frame from being saved on subsequent window
moves (to avoid saving a window frame whose size was set by
JavaScript). The fix is to rejigger the code so that this bit
is not left set in this default-window-frame case.

  • WindowController.h:
  • WindowController.m: (-[WindowController defaultFrame]): New method for subclasses to override. Default implementation is to return the current frame. (-[WindowController setFrameToDefault]): new method, uses defaultFrame but leaves the _lastResizeWasProgrammatic bit clear
  • BrowserWindowController.m: (-[BrowserWindowController defaultFrame]): replace setDefaultWindowFrame with this override of new method; we don't know about the _lastResizeWasProgrammatic bit at this level. (-[BrowserWindowController windowDidLoad]): call new setFrameToDefault instead of old setDefaultWindowFrame
11:27 AM Changeset in webkit [4797] by sheridan
  • 3 edits in trunk

* empty log message *

10:42 AM Changeset in webkit [4796]
  • 3 copies
    2 deletes in tags/WebCore-92~1

This commit was manufactured by cvs2svn to create tag 'WebCore-92~1'.

10:42 AM Changeset in webkit [4795]
  • 1 copy
    3 deletes in tags/JavaScriptCore-92~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-92~1'.

10:42 AM Changeset in webkit [4794] by sheridan
  • 6 edits in trunk

JSC and WC 92.1, picking up missed fixes for Safari-92

8:21 AM Changeset in webkit [4793] by darin
  • 4 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fixed 3366234 -- repro crash in CSS parser: function that can't be parsed (www.bi-flugplatz-magdeburg.de)
  • khtml/css/parser.y: Allocate a Function object for the "can't parse function" case, since the other code involved cannot handle 0 for the function.
  • khtml/css/parser.cpp: Regenerated.
8:21 AM Changeset in webkit [4792] by darin
  • 8 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • fixed 3365527 -- subscripting JavaScript strings does not work (leads to hang at www.newmagna.com.au)

The JavaScript specification says nothing about this, but other browsers seem to give
read-only access to the characters in a string as if the string was an array of characters.

  • kjs/array_object.cpp: (ArrayInstanceImp::get): Update to use a public toArrayIndex function instead of our own getArrayIndex function, so we can share with string. (ArrayInstanceImp::put): Ditto. (ArrayInstanceImp::hasProperty): Ditto. (ArrayInstanceImp::setLength): Ditto.
  • kjs/ustring.h: Add toArrayIndex.
  • kjs/ustring.cpp: (UString::toArrayIndex): Added. Implements the rule from array.
  • kjs/identifier.h: Add a forwarding function so we can use toArrayIndex.
  • kjs/string_object.cpp: (StringInstanceImp::get): Return a single character string if the property name is an array index. (StringInstanceImp::hasProperty): Return true for property names that are suitable array indices.

Aug 7, 2003:

4:11 PM Changeset in webkit [4791]
  • 3 copies in tags/Safari-92

This commit was manufactured by cvs2svn to create tag 'Safari-92'.

4:11 PM Changeset in webkit [4790] by sheridan
  • 8 edits in trunk

Safari-92 version stamp

4:02 PM Changeset in webkit [4789] by rjw
  • 2 edits in trunk/WebKit

Fixed 3362939. Checked flippyness of view and adjust y coord accordingly.

Reviewed by John.

  • Misc.subproj/WebKitNSStringExtras.m:
2:32 PM Changeset in webkit [4788] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3330742>: 1.0 Safari fails to send NPP_URLNotify with the error of NPRES_NETWORK_ERR to Flash

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): call NPP_URLNotify so we cover both the failure and successful cases (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): have destroyStreamWithReason call NPP_URLNotify
2:07 PM Changeset in webkit [4787] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3367434>: newly-added KURL assertion failing reproducibly for JavaScript URL (www.thai.com)

The assertion is correct. The issue was in calling the function
with bad input. Non-hierarchical URLs should not have their "path"
elements submitted to a function that will replace dots.

The fix is to avoid calling this function with such non-hierarchical
URLs.

  • kwq/KWQKURL.mm: (KURL::parse)
1:53 PM Changeset in webkit [4786] by kocienda
  • 4 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3368552>: Fix inappropriate use of NSURL creation methods in WebKit

Change calls to URLWithString: or URLWithString:relativeToURL to
_web_URLWithDataAsString: and _web_URLWithDataAsString:relativeToURL,
respectively.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:intoChild:]):
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]):
  • WebView.subproj/WebView.m: (-[WebView takeStringURLFrom:]): (-[WebView setMainFrameURL:]):
1:36 PM Changeset in webkit [4785] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Maciej

There was a bug in this code that caused a relative URL that was
being resolved against an empty base URL to process incorrectly.
The bug is that the resolution was being done twice. The first
time was correct handling of this case, but then the code did
not return at this point, and instead proceeded on through the
code path that is used to handle resolution of a relative URL
against a non-empty base. This double processing is clearly
wrong, and we found this bug as the result of the recent addition
of an assertion in some related code.

  • kwq/KWQKURL.mm: (KURL::KURL)
1:27 PM Changeset in webkit [4784] by darin
  • 7 edits
    1 delete in trunk

WebCore:

Reviewed by Richard.

  • fixed 3347114 -- remove vestiges of posing, including init routine, from WebKit
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): Remove check for old versions of AppKit that let the WebKit posing handle key down events.
  • kwq/KWQTextField.mm: Removed fieldEditorDidMouseDown: methods.
  • WebCore.pbproj/project.pbxproj: Removed WebCoreFirstResponderChanges.h.
  • kwq/WebCoreFirstResponderChanges.h: Removed.

WebKit:

Reviewed by Richard.

  • fixed 3347114 -- remove vestiges of posing, including init routine, from WebKit
  • WebView.subproj/WebHTMLViewPrivate.m: Removed WebNSTextView, WebNSView, and WebNSWindow, removed the code to have them pose as NSTextView, NSView, and NSWindow, and removed excess imports that are no longer needed.
12:10 PM Changeset in webkit [4783] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • fixed 3366975 - repro hang in KJS::Value::Value entering text at eil.com
  • kjs/string_object.cpp: (StringProtoFuncImp::call): When doing a match against a regexp with the global flag set, make sure to return null rather than an empty array when there is no match. This is what other browsers do.
Note: See TracTimeline for information about the timeline view.