Timeline
Aug 12, 2003:
- 6:25 PM Changeset in webkit [4812] by
-
- 2 edits in trunk/WebKit
- fixed 3369505 -- leaks of NSCFTimer after running through the cvs-base test suite
Reviewed by Richard
- WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): release timer before nil'ing it out
- 4:03 PM Changeset in webkit [4811] by
-
- 3 edits in trunk/WebCore
Fix for 3262190, <li> bullets in mail were overly massive. The bezier path the
painter stroked was not setting the line width from QPen's width, so it ended up
just using the current line width instead (which happened to be much larger in
Mail).
Reviewed by darin
- kwq/KWQPainter.mm: (QPainter::drawEllipse): (QPainter::drawArc): (QPainter::_drawPoints):
- 3:13 PM Changeset in webkit [4810] by
-
- 2 edits in trunk/WebKit
2003-08-12 Ed Voas <voas@apple.com>
Reviewed by Richard.
Make sure to override the standard behavior for ordering windows to do nothing for Carbon stuff.
- Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
- 2:50 PM Changeset in webkit [4809] by
-
- 3 edits in trunk/WebCore
- fixed 3370614 -- REGRESSION (81-85): partial inline input from Japanese input method can disappear
Reviewed by Hyatt
- khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): call w->text() before element()->value(), because w->text() has a side effect of updating element()->value() in the inline input case (RenderTextArea::updateFromElement): same for text areas
- 11:30 AM Changeset in webkit [4808] by
-
- 3 edits in trunk/WebCore
Fix for 3374566, list bullets don't display if list-style-type is none but a list-style-image
is specified. The spec says list-style-type: none does not apply to list-style-image,
and this fixes Microsoft's list bullet on their security pages.
Reviewed by john
- khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
- 11:26 AM Changeset in webkit [4807] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3226083 -- REGRESSION (Panther): white box overlaying select lists at nvidia.com drivers page
- kwq/KWQListBox.mm: (QListBox::QListBox): Call releaseGState on the clip view that we make for the list box. This prevents the incorrect graphics state caching that causes the problem, although it's not entirely clear why this is necessary. This may ultimately turn out to be an AppKit bug, and if so we can roll out this change when the AppKit itself is fixed.
- 9:42 AM Changeset in webkit [4806] by
-
- 2 edits in trunk/LayoutTests/fast
Updating layout tests.
- 9:34 AM Changeset in webkit [4805] by
-
- 3 edits in trunk/WebCore
Fix for 3373462, XML shows up as blank because the root is inline. The fix is
to just disallow inline roots.
Reviewed by kocienda
- khtml/css/cssstyleselector.cpp:
Aug 11, 2003:
- 4:41 PM Changeset in webkit [4804] by
-
- 10 edits in trunk/WebCore
Fix for 3349142, blocks inside inlines with generated content cause the generated
content to get all screwed up, especially if you try to print. This patch fixes
generated content to be continuation-aware (and vice versa), so that the content
behaves correctly when inlines get split.
Reviewed by darin
- khtml/rendering/render_block.cpp:
- khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
- khtml/rendering/render_container.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::addChild):
- khtml/rendering/render_inline.cpp: (RenderInline::isInlineContinuation): (RenderInline::addChildToFlow): (RenderInline::cloneInline): (RenderInline::splitInlines):
- khtml/rendering/render_inline.h:
- khtml/rendering/render_object.cpp: (RenderObject::continuation): (RenderObject::isInlineContinuation):
- khtml/rendering/render_object.h:
- 2:13 PM Changeset in webkit [4803] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3163589>: Macromedia Flash 6 cannot take Asian text entry in Safari
Revidewed by darin.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView installKeyEventHandler]): new (-[WebBaseNetscapePluginView removeKeyEventHandler]): new (-[WebBaseNetscapePluginView becomeFirstResponder]): call installKeyEventHandler (-[WebBaseNetscapePluginView resignFirstResponder]): call removeKeyEventHandler (-[WebBaseNetscapePluginView keyUp:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (-[WebBaseNetscapePluginView keyDown:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (TSMEventHandler): turn the TSM event into a series of EventRecords and pass them to the plug-in (-[WebBaseNetscapePluginView stop]): call removeKeyEventHandler because resignFirstResponder may not get called
- 10:22 AM Changeset in webkit [4802] by
-
- 3 edits in trunk/WebCore
- kwq/KWQKHTMLPart.h: Fixed some small typo-ish strangenesses.
Aug 8, 2003:
- 6:00 PM Changeset in webkit [4801] by
-
- 6 edits in trunk/WebKit
Lots of healthy cleanup. Introduced width and shaping iterators
to simplify code and remove allocations for large text runs. Should
go further and make more use of these in the future (post panther).
Fixed 3369608. Crash in -[WebTextRenderer _CG_drawRun:style:atPoint:] at lovepucca.net
Fixed 3118050. Crash selecting text at http://www.faqs.org/rfcs/rfc2849.html (SELECTION)
Fixed 3371115. Can't correctly select text that contains surrogate pairs
Reviewed by darin.
- Misc.subproj/WebUnicode.h:
- Misc.subproj/WebUnicode.m: (prevChar): (nextChar): (prevLogicalCharJoins): (nextLogicalCharJoins): (glyphVariantLogical): (hasShapeForNextCharacter): (shapeForNextCharacter): (initializeCharacterShapeIterator): (shapedString):
- WebCoreSupport.subproj/WebTextRenderer.h:
- WebCoreSupport.subproj/WebTextRenderer.m: (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (widthForNextCharacter): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]):
Just formatting changed here
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]):
- 4:34 PM Changeset in webkit [4800] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej.
- fixed 3368236 -- NSURL exception going back at http://derstandard.at/
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): Put "about:blank" in the back/forward item if there is no URL (which happens because there is no data source because the frame has never successfully loaded anything). Perhaps we can do better some day, but this avoids all the major bad effects in a safe way.
- English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
- 3:26 PM Changeset in webkit [4799] by
-
- 10 edits in trunk/WebCore
Fix for 3368672, don't allow frames and framesets to be positioned or relpositioned.
Reviewed by darin
- ChangeLog:
- khtml/rendering/render_box.cpp: (RenderBox::setStyle):
- khtml/rendering/render_object.cpp: (RenderObject::requiresLayer):
- khtml/rendering/render_object.h:
- 11:34 AM Changeset in webkit [4798] by
-
- 6 edits in trunk/WebCore
WebCore:
- fixed 3362481 -- REGRESSION (89-90): clicking in a field causes page to move; esp. bad if the field moves out from under the mouse
Reviewed by Darin
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::currentEventIsMouseDownInWidget): new method
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): only scroll to reveal if currentEventIsMouseDownInWidget is false
- kwq/KWQTextField.mm: (-[KWQTextField setHasFocus:]): ditto
WebBrowser:
- fixed 3369587 -- REGRESSION (85-88): window position isn't being saved if moved from default position
Reviewed by Chris
The bug was that when the default window size is set
programmatically to be full screen height, we're setting the
_lastResizeWasProgrammatic bit in WindowController, which
prevents the window frame from being saved on subsequent window
moves (to avoid saving a window frame whose size was set by
JavaScript). The fix is to rejigger the code so that this bit
is not left set in this default-window-frame case.
- WindowController.h:
- WindowController.m: (-[WindowController defaultFrame]): New method for subclasses to override. Default implementation is to return the current frame. (-[WindowController setFrameToDefault]): new method, uses defaultFrame but leaves the _lastResizeWasProgrammatic bit clear
- BrowserWindowController.m: (-[BrowserWindowController defaultFrame]): replace setDefaultWindowFrame with this override of new method; we don't know about the _lastResizeWasProgrammatic bit at this level. (-[BrowserWindowController windowDidLoad]): call new setFrameToDefault instead of old setDefaultWindowFrame
- 11:27 AM Changeset in webkit [4797] by
-
- 3 edits in trunk
* empty log message *
- 10:42 AM Changeset in webkit [4796]
-
- 3 copies2 deletes in tags/WebCore-92~1
This commit was manufactured by cvs2svn to create tag 'WebCore-92~1'.
- 10:42 AM Changeset in webkit [4795]
-
- 1 copy3 deletes in tags/JavaScriptCore-92~1
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-92~1'.
- 10:42 AM Changeset in webkit [4794] by
-
- 6 edits in trunk
JSC and WC 92.1, picking up missed fixes for Safari-92
- 8:21 AM Changeset in webkit [4793] by
-
- 4 edits in trunk/WebCore
Reviewed by John Sullivan.
- fixed 3366234 -- repro crash in CSS parser: function that can't be parsed (www.bi-flugplatz-magdeburg.de)
- khtml/css/parser.y: Allocate a Function object for the "can't parse function" case, since the other code involved cannot handle 0 for the function.
- khtml/css/parser.cpp: Regenerated.
- 8:21 AM Changeset in webkit [4792] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by John Sullivan.
- fixed 3365527 -- subscripting JavaScript strings does not work (leads to hang at www.newmagna.com.au)
The JavaScript specification says nothing about this, but other browsers seem to give
read-only access to the characters in a string as if the string was an array of characters.
- kjs/array_object.cpp: (ArrayInstanceImp::get): Update to use a public toArrayIndex function instead of our own getArrayIndex function, so we can share with string. (ArrayInstanceImp::put): Ditto. (ArrayInstanceImp::hasProperty): Ditto. (ArrayInstanceImp::setLength): Ditto.
- kjs/ustring.h: Add toArrayIndex.
- kjs/ustring.cpp: (UString::toArrayIndex): Added. Implements the rule from array.
- kjs/identifier.h: Add a forwarding function so we can use toArrayIndex.
- kjs/string_object.cpp: (StringInstanceImp::get): Return a single character string if the property name is an array index. (StringInstanceImp::hasProperty): Return true for property names that are suitable array indices.
- JavaScriptCore.pbproj/project.pbxproj: Let Xcode be Xcode.
