⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 13, 2003:

11:44 PM Changeset in webkit [4820] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3372896, spaces left at ends of lines. Patch the selection code
to be smarter about detecting ends of lines and adding in spaces.

Reviewed by gramps

  • khtml/khtml_part.cpp: (KHTMLPart::selectedText):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
5:26 PM Changeset in webkit [4819] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): ref the data source around processing the data and afterwards, to avoid crashing if a script in this chunk of data made the frame go away.
4:25 PM Changeset in webkit [4818] by rjw
  • 6 edits in trunk/WebKit

Fixed 3376077. Override automaticallyNotifiesObserversForKey: to
prevent unnecessary additional notifications from being sent. Also
added development-only logging (bulk of the change).

Reviewed by Chris.

  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _didChangeValueForKey:]): (-[WebView _willChangeValueForKey:]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]): (+[WebView automaticallyNotifiesObserversForKey:]): (-[WebView _willChangeBackForwardKeys]): (-[WebView _didChangeBackForwardKeys]): (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):
2:57 PM Changeset in webkit [4817] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3347134>: After first successful POST in Flash, Safari does not repeat POST and gives cached reply

Reviewed by kocienda.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): call [request setCachePolicy:NSURLRequestReloadIgnoringCacheData]
1:55 PM Changeset in webkit [4816] by kocienda
  • 5 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3366441>: URL strings with UTF-8 characters
processed improperly for display by WebKit

  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (isHexDigit): Added (hexDigitValue): Added (-[NSURL _web_userVisibleString]): Added. Produces a string that is suitable for display to a user in the UI. (-[NSURL _web_isEmpty]): Convenience to check for an empty URL
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]): Now calls _web_userVisibleString
1:48 PM Changeset in webkit [4815] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3374458>: Choose UTF-8 for encoding when calling
CFURLCreateAbsoluteURLWithBytes in WebKit

Calling CFURLCreateAbsoluteURLWithBytes with ISO Latin 1 string
encoding results in some issues when trying to decode a URL path in
preparation for doing file I/O. Instead of doing a redecoding step
whenever a path is needed to perform I/O, use UTF-8 as the encoding
right from the start. This will mean that illegal UTF-8 sequences will
be rejected by CFURLCreateAbsoluteURLWithBytes. However, we can work
around this by falling back on ISO Latin1 in this case. The end result
is that existing code throughout the URL loading system can remain
unchanged and simply call the path method on NSURL as it does now and
get the right result for its I/O requirements.

  • Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:])
1:23 PM Changeset in webkit [4814] by kocienda
  • 4 edits in trunk/WebKit

WebKit:

Reviewed by Darin

Fix for this bug:

<rdar://problem/3374487>: URLs with UTF-8 escape sequences can't be accessed
when typed in the Safari location bar

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): Call _web_URLWithUserTypedString: to make a URL from this type of string.
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (hexDigit): Added. (+[NSURL _web_URLWithUserTypedString:]): Added. Creates a URL from a string that is typed in a user, for example, in the Safari location bar.

WebBrowser:

Reviewed by Darin

Fix for this bug:

<rdar://problem/3374487>: URLs with UTF-8 escape sequences can't be accessed
when typed in the Safari location bar

  • BrowserNSStringExtras.m: (-[NSString possibleURLsForUserTypedString]): Use _web_URLWithUserTypedString: to make URL from this type of string.
9:51 AM Changeset in webkit [4813] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Ken Kocienda.

  • fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
  • khtml/khtml_part.cpp: (KHTMLPart::write): ref the part around actually processing the data, since a script could cause the part to go away.

Aug 12, 2003:

6:25 PM Changeset in webkit [4812] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3369505 -- leaks of NSCFTimer after running through the cvs-base test suite

Reviewed by Richard

  • WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): release timer before nil'ing it out
4:03 PM Changeset in webkit [4811] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3262190, <li> bullets in mail were overly massive. The bezier path the
painter stroked was not setting the line width from QPen's width, so it ended up
just using the current line width instead (which happened to be much larger in
Mail).

Reviewed by darin

  • kwq/KWQPainter.mm: (QPainter::drawEllipse): (QPainter::drawArc): (QPainter::_drawPoints):
3:13 PM Changeset in webkit [4810] by voas
  • 2 edits in trunk/WebKit

2003-08-12 Ed Voas <voas@apple.com>

Reviewed by Richard.

Make sure to override the standard behavior for ordering windows to do nothing for Carbon stuff.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2:50 PM Changeset in webkit [4809] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3370614 -- REGRESSION (81-85): partial inline input from Japanese input method can disappear

Reviewed by Hyatt

  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): call w->text() before element()->value(), because w->text() has a side effect of updating element()->value() in the inline input case (RenderTextArea::updateFromElement): same for text areas
11:30 AM Changeset in webkit [4808] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3374566, list bullets don't display if list-style-type is none but a list-style-image
is specified. The spec says list-style-type: none does not apply to list-style-image,
and this fixes Microsoft's list bullet on their security pages.

Reviewed by john

  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
11:26 AM Changeset in webkit [4807] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3226083 -- REGRESSION (Panther): white box overlaying select lists at nvidia.com drivers page
  • kwq/KWQListBox.mm: (QListBox::QListBox): Call releaseGState on the clip view that we make for the list box. This prevents the incorrect graphics state caching that causes the problem, although it's not entirely clear why this is necessary. This may ultimately turn out to be an AppKit bug, and if so we can roll out this change when the AppKit itself is fixed.
9:42 AM Changeset in webkit [4806] by hyatt
  • 2 edits in trunk/LayoutTests/fast

Updating layout tests.

9:34 AM Changeset in webkit [4805] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3373462, XML shows up as blank because the root is inline. The fix is
to just disallow inline roots.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp:

Aug 11, 2003:

4:41 PM Changeset in webkit [4804] by hyatt
  • 10 edits in trunk/WebCore

Fix for 3349142, blocks inside inlines with generated content cause the generated
content to get all screwed up, especially if you try to print. This patch fixes
generated content to be continuation-aware (and vice versa), so that the content
behaves correctly when inlines get split.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChild):
  • khtml/rendering/render_inline.cpp: (RenderInline::isInlineContinuation): (RenderInline::addChildToFlow): (RenderInline::cloneInline): (RenderInline::splitInlines):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::continuation): (RenderObject::isInlineContinuation):
  • khtml/rendering/render_object.h:
2:13 PM Changeset in webkit [4803] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3163589>: Macromedia Flash 6 cannot take Asian text entry in Safari

Revidewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView installKeyEventHandler]): new (-[WebBaseNetscapePluginView removeKeyEventHandler]): new (-[WebBaseNetscapePluginView becomeFirstResponder]): call installKeyEventHandler (-[WebBaseNetscapePluginView resignFirstResponder]): call removeKeyEventHandler (-[WebBaseNetscapePluginView keyUp:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (-[WebBaseNetscapePluginView keyDown:]): call TSMProcessRawKeyEvent so key events go through the machinery and UI that plug-ins expect (TSMEventHandler): turn the TSM event into a series of EventRecords and pass them to the plug-in (-[WebBaseNetscapePluginView stop]): call removeKeyEventHandler because resignFirstResponder may not get called
10:22 AM Changeset in webkit [4802] by darin
  • 3 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.h: Fixed some small typo-ish strangenesses.
Note: See TracTimeline for information about the timeline view.