Timeline
Aug 17, 2003:
- 11:02 PM Changeset in webkit [4834] by
-
- 4 edits in trunk/WebKit
Reviewed by Maciej.
- fixed 3376522 -- REGRESSION: uncaught exception from bad .ico causes crash (login window at 34sp.com)
I added exception handling in all the places we load images with NSImage.
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconsForIconURLString:]): Add exception handler.
- Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): Add exception handler.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): Add exception handler. (-[WebImageRenderer initWithContentsOfFile:]): Add exception handler. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Add exception handler.
Aug 15, 2003:
- 5:10 PM Changeset in webkit [4833] by
-
- 3 edits in trunk/WebCore
Fixed by Darin, reviewed by me (and originally figured out by John).
- fixed 3375592 - New Yahoo Maps doesn't work right
- kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Don't pass through null characters. (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto. (KWQTextDecoder::convertUsingTEC): Ditto.
- 5:04 PM Changeset in webkit [4832] by
-
- 2 edits in trunk/WebKit
Fixed 3378530. Ensure that line is always drawn within bounds
of element.
Reviewed by Chris.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
- 10:33 AM Changeset in webkit [4831] by
-
- 2 edits in trunk/WebKit
Fixed 3379439. Remove checks for CG symbols. No longer needed.
Reviewed by Darin.
- WebCoreSupport.subproj/WebTextRendererFactory.m: (+[WebTextRendererFactory createSharedFactory]):
- 9:58 AM Changeset in webkit [4830]
-
- 3 copies in tags/Safari-93
This commit was manufactured by cvs2svn to create tag 'Safari-93'.
- 9:58 AM Changeset in webkit [4829] by
-
- 8 edits in trunk
Safari-93 stamp
Aug 14, 2003:
- 5:49 PM Changeset in webkit [4828] by
-
- 3 edits in trunk/WebCore
Back out the last change, because the tree is closed. I am an idiot.
- 5:40 PM Changeset in webkit [4827] by
-
- 3 edits in trunk/WebCore
Fixed by Darin, reviewed by me (and originally figured out by John).
- fixed 3375592 - New Yahoo Maps doesn't work right
- kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Don't pass through null characters. (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto. (KWQTextDecoder::convertUsingTEC): Ditto.
- 2:46 PM Changeset in webkit [4826] by
-
- 8 edits in trunk
Reviewed by John.
- JavaScriptCore.pbproj/project.pbxproj: deleted JavaScriptCore.order from the project.
WebCore:
Reviewed by John.
- WebCore.pbproj/project.pbxproj: deleted WebCore.order from the project.
WebKit:
Reviewed by John.
- WebKit.pbproj/project.pbxproj: deleted WebKit.order from the project.
- 2:16 PM Changeset in webkit [4825] by
-
- 8 edits3 deletes in trunk
Reviewed by John.
- JavaScriptCore.order: Removed. We now link to the order file at /AppleInternal/OrderFiles.
- JavaScriptCore.pbproj/project.pbxproj: change sectorder flag to point to /AppleInternal/OrderFiles/JavaScriptCore.order
WebCore:
Reviewed by John.
- WebCore.order: Removed. We now point to the WebCore order file in /AppleInternal/OrderFiles.
- WebCore.pbproj/project.pbxproj: change sectorder flag to point to /AppleInternal/OrderFiles/WebCore.order
WebKit:
Reviewed by John.
- WebKit.order: Removed. We now point to the WebKit order file in /AppleInternal/OrderFiles.
- WebKit.pbproj/project.pbxproj: set sectorder flag to point to /AppleInternal/OrderFiles/WebKit.order
WebBrowser:
Reviewed by John.
- Safari.order: updated this order file
- WebBrowser.pbproj/project.pbxproj: set sectorder flag to point to Safari.order
- 11:13 AM Changeset in webkit [4824] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
- fixed 3344259 -- flipped image when copying from Safari in 1000s of colors mode
The workaround is to turn off the NSImage cache. Andrew says this won't have any
practical repercussions other than making the bug go away.
Seems to have a side effect of speeding up the cvs-base page load test!
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): Set mode to NSImageCacheNever. (-[WebImageRenderer initWithData:MIMEType:]): Ditto. (-[WebImageRenderer initWithContentsOfFile:]): Ditto. (-[WebImageRenderer _adjustSizeToPixelDimensions]): Don't set mode to NSImageCacheDefault.
- 10:56 AM Changeset in webkit [4823] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin
Fix for this bug:
<rdar://problem/3095893>: Image Capture: "Build web page" doesn't work with Japanese folder name.
- kwq/KWQKURL.mm: (KURL::getNSURL): Try UTF-8 first and fallback to ISO Latin-1 when creating an NSURL. This will handle the two-byte character in file name case mentioned in the bug.
- 9:48 AM Changeset in webkit [4822] by
-
- 27 edits in trunk/WebKit
Reviewed by Darin
Fix for this bug:
<rdar://problem/3375042>: Change usages of NSURL absoluteString in WebKit
to use improved variants
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): Use data-as-string. (-[WebHistoryItem initWithURL:target:parent:title:]): Use data-as-string. (-[WebHistoryItem setURL:]): Use data-as-string.
- History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addItem:]): Remove FIX_VISITED ifdef (-[WebHistoryPrivate removeItem:]): Ditto (-[WebHistoryPrivate containsURL:]): Ditto. Use data-as-string. (-[WebHistoryPrivate itemForURL:]): Ditto. Ditto. (-[WebHistoryPrivate loadFromURL:error:]): Fix log message to URL. (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): Ditto. (-[WebHistoryPrivate saveToURL:error:]): Ditto.
- History.subproj/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use visible-string.
- Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): Use data-as-string.
- Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithDomain:code:URL:]): Added new convenience that takes a URL instead of a URL string. (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): Added new convenience that takes URLs instead of a URL stringis.
- Misc.subproj/WebKitErrorsPrivate.h: Declared new conveniences.
- Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:types:]): Use visible-string.
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_originalDataAsString]): Added. (-[NSURL _webkit_isJavaScriptURL]): Use data-as-string. (-[NSURL _webkit_scriptIfJavaScriptURL]): Ditto (-[NSURL _webkit_isFTPDirectoryURL]): Ditto (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Ditto. Also use _web_isEmpty.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Use data-as-string.
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): Use new error convenience.
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): Ditto.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]): Use data-as-string.
- WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Use new error convenience.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelledError]): Ditto.
- WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]): Ditto.
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]): Ditto. (-[WebDataSource _updateIconDatabaseWithURL:]): Use data-as-string. (-[WebDataSource _loadIcon]): Ditto.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): Use data-as-string. (-[WebFrame _transitionToCommitted:]): Fix log message to use URL. (-[WebFrame _purgePageCache]): Use _web_isEmpty (-[WebFrame _setState:]): Fix log message to use URL. (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): Use new error convenience. (-[WebFrame _loadItem:withLoadType:]): Fix log message to use URL. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Fix log messages to use URL. (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): Use data-as-string.
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]): Use visible-string.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): Use new error convenience.
- WebView.subproj/WebPreferences.m: (-[WebPreferences setUserStyleSheetLocation:]): Use data-as-string.
- WebView.subproj/WebView.m: (-[WebView mainFrameURL]): Use data-as-string. (-[WebView mainFrameIcon]): Use data-as-string.
- WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Use data-as-string.
- 8:56 AM Changeset in webkit [4821] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3375270 -- writing to frame parent from a button press crashes in viewportMousePressEvent
The fix turned out to be to ref the view around handling events in the view, since processing
the event could cause the view and part to go away. Since the view refs the part, ref'ing just
the view seems to work perfectly.
- kwq/KWQKHTMLPart.mm: Fixed namespace access to use "using" instead of explicit namespaces. (KWQKHTMLPart::setView): Not-entirely-related cleanup. Use the "ref before deref" idiom here. (KWQKHTMLPart::sendResizeEvent): Ref the KHTMLView while sending the resize event. (KWQKHTMLPart::mouseDown): Ref the KHTMLView while sending the viewport mouse down event. (KWQKHTMLPart::mouseDragged): Ref the KHTMLView while sending the viewport mouse dragged event. (KWQKHTMLPart::mouseUp): Ref the KHTMLView while sending the viewport mouse up or double click event. (KWQKHTMLPart::mouseMoved): Ref the KHTMLView while sending the viewport mouse moved event.
Aug 13, 2003:
- 11:44 PM Changeset in webkit [4820] by
-
- 4 edits in trunk/WebCore
Fix for 3372896, spaces left at ends of lines. Patch the selection code
to be smarter about detecting ends of lines and adding in spaces.
Reviewed by gramps
- khtml/khtml_part.cpp: (KHTMLPart::selectedText):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
- 5:26 PM Changeset in webkit [4819] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): ref the data source around processing the data and afterwards, to avoid crashing if a script in this chunk of data made the frame go away.
- 4:25 PM Changeset in webkit [4818] by
-
- 6 edits in trunk/WebKit
Fixed 3376077. Override automaticallyNotifiesObserversForKey: to
prevent unnecessary additional notifications from being sent. Also
added development-only logging (bulk of the change).
Reviewed by Chris.
- Misc.subproj/WebKitLogging.h:
- Misc.subproj/WebKitLogging.m:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
- WebView.subproj/WebViewPrivate.h:
- WebView.subproj/WebViewPrivate.m: (-[WebView _didChangeValueForKey:]): (-[WebView _willChangeValueForKey:]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]): (+[WebView automaticallyNotifiesObserversForKey:]): (-[WebView _willChangeBackForwardKeys]): (-[WebView _didChangeBackForwardKeys]): (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):
- 2:57 PM Changeset in webkit [4817] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3347134>: After first successful POST in Flash, Safari does not repeat POST and gives cached reply
Reviewed by kocienda.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): call [request setCachePolicy:NSURLRequestReloadIgnoringCacheData]
- 1:55 PM Changeset in webkit [4816] by
-
- 5 edits in trunk/WebKit
Reviewed by Darin
Fix for this bug:
<rdar://problem/3366441>: URL strings with UTF-8 characters
processed improperly for display by WebKit
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (isHexDigit): Added (hexDigitValue): Added (-[NSURL _web_userVisibleString]): Added. Produces a string that is suitable for display to a user in the UI. (-[NSURL _web_isEmpty]): Convenience to check for an empty URL
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]): Now calls _web_userVisibleString
- 1:48 PM Changeset in webkit [4815] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
Fix for this bug:
<rdar://problem/3374458>: Choose UTF-8 for encoding when calling
CFURLCreateAbsoluteURLWithBytes in WebKit
Calling CFURLCreateAbsoluteURLWithBytes with ISO Latin 1 string
encoding results in some issues when trying to decode a URL path in
preparation for doing file I/O. Instead of doing a redecoding step
whenever a path is needed to perform I/O, use UTF-8 as the encoding
right from the start. This will mean that illegal UTF-8 sequences will
be rejected by CFURLCreateAbsoluteURLWithBytes. However, we can work
around this by falling back on ISO Latin1 in this case. The end result
is that existing code throughout the URL loading system can remain
unchanged and simply call the path method on NSURL as it does now and
get the right result for its I/O requirements.
- Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:])
- 1:23 PM Changeset in webkit [4814] by
-
- 4 edits in trunk/WebKit
WebKit:
Reviewed by Darin
Fix for this bug:
<rdar://problem/3374487>: URLs with UTF-8 escape sequences can't be accessed
when typed in the Safari location bar
- Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): Call _web_URLWithUserTypedString: to make a URL from this type of string.
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (hexDigit): Added. (+[NSURL _web_URLWithUserTypedString:]): Added. Creates a URL from a string that is typed in a user, for example, in the Safari location bar.
WebBrowser:
Reviewed by Darin
Fix for this bug:
<rdar://problem/3374487>: URLs with UTF-8 escape sequences can't be accessed
when typed in the Safari location bar
- BrowserNSStringExtras.m: (-[NSString possibleURLsForUserTypedString]): Use _web_URLWithUserTypedString: to make URL from this type of string.
- 9:51 AM Changeset in webkit [4813] by
-
- 4 edits in trunk/WebCore
Reviewed by Ken Kocienda.
- fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
- khtml/khtml_part.cpp: (KHTMLPart::write): ref the part around actually processing the data, since a script could cause the part to go away.
