⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 18, 2003:

5:09 PM Changeset in webkit [4841] by rjw
  • 4 edits in trunk/WebKit

Fixed 3140065. Bidi neutrals in RTL runs are now handled correctly. Still have
problem with bidi neutrals at directional boundaries 3382926.

Reviewed by Maciej.

  • Misc.subproj/WebUnicode.h:
  • Misc.subproj/WebUnicode.m: (shapedString):
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
2:12 PM Changeset in webkit [4840] by darin
  • 17 edits in trunk

WebCore:

Reviewed by Maciej.

  • fixed 3299893 -- oncontextmenu support
  • kwq/WebCoreBridge.h: Added sendContextMenuEvent: method.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge sendContextMenuEvent:]): Added. Calls sendContextMenuEvent on the part.
  • kwq/KWQKHTMLPart.h: Added sendContextMenuEvent member function.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): Added. Sets up a suitable mouse event and calls dispatchMouseEvent for CONTEXTMENU_EVENT.
  • khtml/ecma/kjs_dom.cpp: Added oncontextmenu to DOMNode's list of properties. (DOMNode::getValueProperty): Added case for OnContextMenu. (DOMNode::putValue): Added case for OnContextMenu.
  • khtml/ecma/kjs_dom.h: Added constant for OnContextMenu.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): Added case for ATTR_ONCONTEXTMENU.
  • khtml/misc/htmlattrs.in: Added oncontextmenu.
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Added case for CONTEXTMENU_EVENT. (EventImpl::idToType): Added case for CONTEXTMENU_EVENT.
  • khtml/xml/dom2_eventsimpl.h: Added CONTEXTMENU_EVENT.
  • khtml/ecma/kjs_dom.lut.h: Regenerated.
  • khtml/misc/htmlattrs.c: Regenerated.
  • khtml/misc/htmlattrs.h: Regenerated.

WebKit:

Reviewed by Maciej.

  • fixed 3299893 -- oncontextmenu support
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Call sendContextMenuEvent: on the bridge, and don't show a menu if the event is handled over in WebCore. (-[WebHTMLView mouseDown:]): Don't send a mouse down event in the case where we already sent a context menu event and decided not to put up a real context menu.
2:03 PM Changeset in webkit [4839] by rjw
  • 2 edits in trunk/WebKit

Fix build problem from last checkin.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):
12:23 PM Changeset in webkit [4838] by darin
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

  • fixed 3381295 -- regular expression matches for text with UTF-16 surrogates will give incorrect results
  • kwq/KWQRegExp.mm: (QRegExp::match): Removed local copy of convertCharacterOffsetsToUTF8ByteOffsets and its reverse. Instead use convertUTF16OffsetsToUTF8Offsets and its reverse, now available from <JavaScriptCore/ustring.h>.
  • added test for the URI encoding and decoding functions in JavaScriptCore
  • layout-tests/fast/js/global/encode-URI-test-expected.txt: Added.
  • layout-tests/fast/js/global/encode-URI-test.html: Added.
11:51 AM Changeset in webkit [4837] by darin
  • 8 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed 3247528 -- encodeURI missing from JavaScriptCore (needed by Crystal Reports)
  • fixed 3381297 -- escape method does not escape the null character
  • fixed 3381299 -- escape method produces incorrect escape sequences ala WinIE, rather than correct ala Gecko
  • fixed 3381303 -- unescape method treats escape sequences as Latin-1 ala WinIE rather than as UTF-8 ala Gecko
  • fixed 3381304 -- unescape method garbles strings with bad escape sequences in them
  • kjs/function.h: Added constants for decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent.
  • kjs/function.cpp: (encode): Added. New helper function for escape, encodeURI, and encodeURIComponent. (decode): Added. New helper function for unescape, decodeURI, and decodeURIComponent. (GlobalFuncImp::call): Added decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent implementations. Changed escape and unescape to use new helper functions, which fixes the four problems above.
  • kjs/internal.cpp: (InterpreterImp::initGlobalObject): Add decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent to the global object.
  • kjs/ustring.h: Added a length to the CString class so it can hold strings with null characters in them, not just null-terminated strings. This allows a null character from a UString to survive the process of UTF-16 to UTF-8 decoding. Added overloads to UString::append, UString::UTF8String, UTF8SequenceLength, decodeUTF8Sequence, convertUTF16OffsetsToUTF8Offsets, and convertUTF8OffsetsToUTF16Offsets.
  • kjs/ustring.cpp: (CString::CString): Set up the length properly in all the constructors. Also add a new constructor that takes a length. (CString::append): Use and set the length properly. (CString::operator=): Use and set the length properly. (operator==): Use and the length and memcmp instead of strcmp. (UString::append): Added new overloads for const char * and for a single string to make it more efficient to build up a UString from pieces. The old way, a UString was created and destroyed each time you appended. (UTF8SequenceLength): New. Helper for decoding UTF-8. (decodeUTF8Sequence): New. Helper for decoding UTF-8. (UString::UTF8String): New. Decodes from UTF-16 to UTF-8. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (compareStringOffsets): Moved from regexp.cpp. (createSortedOffsetsArray): Moved from regexp.cpp. (convertUTF16OffsetsToUTF8Offsets): New. Converts UTF-16 offsets to UTF-8 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (convertUTF8OffsetsToUTF16Offsets): New. Converts UTF-8 offsets to UTF-16 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates.
  • fixed 3381296 -- regular expression matches with UTF-16 surrogates will treat sequences as two characters
  • kjs/regexp.cpp: (RegExp::RegExp): Use the new UString::UTF8String function instead a function in this file. (RegExp::match): Use the new convertUTF16OffsetsToUTF8Offsets (and the corresponding reverse) instead of convertCharacterOffsetsToUTF8ByteOffsets in this file.
9:10 AM Changeset in webkit [4836] by cblu
  • 3 edits in trunk/WebCore

Fixed: <rdar://problem/3380418>: Ignore specified string encoding when constructing file, mailto and help URLs

Reviewed by mjs, darin.

  • kwq/KWQKURL.mm: (KURL::KURL): store the URL string as UTF-8 when the URL is file, mailto and help.
7:50 AM Changeset in webkit [4835] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3366542 -- filename with non-ASCII name left out of Content-Disposition for <input type=file>
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Do the &-encoding thing on the filename. This is what Gecko does.

Aug 17, 2003:

11:02 PM Changeset in webkit [4834] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed 3376522 -- REGRESSION: uncaught exception from bad .ico causes crash (login window at 34sp.com)

I added exception handling in all the places we load images with NSImage.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconsForIconURLString:]): Add exception handler.
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): Add exception handler.
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): Add exception handler. (-[WebImageRenderer initWithContentsOfFile:]): Add exception handler. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Add exception handler.

Aug 15, 2003:

5:10 PM Changeset in webkit [4833] by mjs
  • 3 edits in trunk/WebCore

Fixed by Darin, reviewed by me (and originally figured out by John).

  • fixed 3375592 - New Yahoo Maps doesn't work right
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Don't pass through null characters. (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto. (KWQTextDecoder::convertUsingTEC): Ditto.
5:04 PM Changeset in webkit [4832] by rjw
  • 2 edits in trunk/WebKit

Fixed 3378530. Ensure that line is always drawn within bounds
of element.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
10:33 AM Changeset in webkit [4831] by rjw
  • 2 edits in trunk/WebKit

Fixed 3379439. Remove checks for CG symbols. No longer needed.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebTextRendererFactory.m: (+[WebTextRendererFactory createSharedFactory]):
9:58 AM Changeset in webkit [4830]
  • 3 copies in tags/Safari-93

This commit was manufactured by cvs2svn to create tag 'Safari-93'.

9:58 AM Changeset in webkit [4829] by sheridan
  • 8 edits in trunk

Safari-93 stamp

Aug 14, 2003:

5:49 PM Changeset in webkit [4828] by mjs
  • 3 edits in trunk/WebCore

Back out the last change, because the tree is closed. I am an idiot.

5:40 PM Changeset in webkit [4827] by mjs
  • 3 edits in trunk/WebCore

Fixed by Darin, reviewed by me (and originally figured out by John).

  • fixed 3375592 - New Yahoo Maps doesn't work right
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Don't pass through null characters. (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto. (KWQTextDecoder::convertUsingTEC): Ditto.
2:46 PM Changeset in webkit [4826] by vicki
  • 8 edits in trunk

JavaScriptCore:

Reviewed by John.

WebCore:

Reviewed by John.

  • WebCore.pbproj/project.pbxproj: deleted WebCore.order from the project.

WebKit:

Reviewed by John.

  • WebKit.pbproj/project.pbxproj: deleted WebKit.order from the project.
2:16 PM Changeset in webkit [4825] by vicki
  • 8 edits
    3 deletes in trunk

JavaScriptCore:

Reviewed by John.

  • JavaScriptCore.order: Removed. We now link to the order file at /AppleInternal/OrderFiles.
  • JavaScriptCore.pbproj/project.pbxproj: change sectorder flag to point to /AppleInternal/OrderFiles/JavaScriptCore.order

WebCore:

Reviewed by John.

  • WebCore.order: Removed. We now point to the WebCore order file in /AppleInternal/OrderFiles.
  • WebCore.pbproj/project.pbxproj: change sectorder flag to point to /AppleInternal/OrderFiles/WebCore.order

WebKit:

Reviewed by John.

  • WebKit.order: Removed. We now point to the WebKit order file in /AppleInternal/OrderFiles.
  • WebKit.pbproj/project.pbxproj: set sectorder flag to point to /AppleInternal/OrderFiles/WebKit.order

WebBrowser:

Reviewed by John.

  • Safari.order: updated this order file
  • WebBrowser.pbproj/project.pbxproj: set sectorder flag to point to Safari.order
11:13 AM Changeset in webkit [4824] by darin
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed 3344259 -- flipped image when copying from Safari in 1000s of colors mode

The workaround is to turn off the NSImage cache. Andrew says this won't have any
practical repercussions other than making the bug go away.

Seems to have a side effect of speeding up the cvs-base page load test!

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): Set mode to NSImageCacheNever. (-[WebImageRenderer initWithData:MIMEType:]): Ditto. (-[WebImageRenderer initWithContentsOfFile:]): Ditto. (-[WebImageRenderer _adjustSizeToPixelDimensions]): Don't set mode to NSImageCacheDefault.
10:56 AM Changeset in webkit [4823] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3095893>: Image Capture: "Build web page" doesn't work with Japanese folder name.

  • kwq/KWQKURL.mm: (KURL::getNSURL): Try UTF-8 first and fallback to ISO Latin-1 when creating an NSURL. This will handle the two-byte character in file name case mentioned in the bug.
9:48 AM Changeset in webkit [4822] by kocienda
  • 27 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3375042>: Change usages of NSURL absoluteString in WebKit
to use improved variants

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): Use data-as-string. (-[WebHistoryItem initWithURL:target:parent:title:]): Use data-as-string. (-[WebHistoryItem setURL:]): Use data-as-string.
  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addItem:]): Remove FIX_VISITED ifdef (-[WebHistoryPrivate removeItem:]): Ditto (-[WebHistoryPrivate containsURL:]): Ditto. Use data-as-string. (-[WebHistoryPrivate itemForURL:]): Ditto. Ditto. (-[WebHistoryPrivate loadFromURL:error:]): Fix log message to URL. (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): Ditto. (-[WebHistoryPrivate saveToURL:error:]): Ditto.
  • History.subproj/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use visible-string.
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): Use data-as-string.
  • Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithDomain:code:URL:]): Added new convenience that takes a URL instead of a URL string. (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): Added new convenience that takes URLs instead of a URL stringis.
  • Misc.subproj/WebKitErrorsPrivate.h: Declared new conveniences.
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:types:]): Use visible-string.
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_originalDataAsString]): Added. (-[NSURL _webkit_isJavaScriptURL]): Use data-as-string. (-[NSURL _webkit_scriptIfJavaScriptURL]): Ditto (-[NSURL _webkit_isFTPDirectoryURL]): Ditto (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Ditto. Also use _web_isEmpty.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Use data-as-string.
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): Use new error convenience.
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): Ditto.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURLString]): Use data-as-string.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Use new error convenience.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelledError]): Ditto.
  • WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]): Ditto.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]): Ditto. (-[WebDataSource _updateIconDatabaseWithURL:]): Use data-as-string. (-[WebDataSource _loadIcon]): Ditto.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): Use data-as-string. (-[WebFrame _transitionToCommitted:]): Fix log message to use URL. (-[WebFrame _purgePageCache]): Use _web_isEmpty (-[WebFrame _setState:]): Fix log message to use URL. (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): Use new error convenience. (-[WebFrame _loadItem:withLoadType:]): Fix log message to use URL. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Fix log messages to use URL. (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): Use data-as-string.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _dragImageForLinkElement:]): Use visible-string.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): Use new error convenience.
  • WebView.subproj/WebPreferences.m: (-[WebPreferences setUserStyleSheetLocation:]): Use data-as-string.
  • WebView.subproj/WebView.m: (-[WebView mainFrameURL]): Use data-as-string. (-[WebView mainFrameIcon]): Use data-as-string.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Use data-as-string.
8:56 AM Changeset in webkit [4821] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3375270 -- writing to frame parent from a button press crashes in viewportMousePressEvent

The fix turned out to be to ref the view around handling events in the view, since processing
the event could cause the view and part to go away. Since the view refs the part, ref'ing just
the view seems to work perfectly.

  • kwq/KWQKHTMLPart.mm: Fixed namespace access to use "using" instead of explicit namespaces. (KWQKHTMLPart::setView): Not-entirely-related cleanup. Use the "ref before deref" idiom here. (KWQKHTMLPart::sendResizeEvent): Ref the KHTMLView while sending the resize event. (KWQKHTMLPart::mouseDown): Ref the KHTMLView while sending the viewport mouse down event. (KWQKHTMLPart::mouseDragged): Ref the KHTMLView while sending the viewport mouse dragged event. (KWQKHTMLPart::mouseUp): Ref the KHTMLView while sending the viewport mouse up or double click event. (KWQKHTMLPart::mouseMoved): Ref the KHTMLView while sending the viewport mouse moved event.
Note: See TracTimeline for information about the timeline view.