Context Navigation

← Previous Period
Next Period →

Timeline

Aug 19, 2003:

6:18 PM Changeset in webkit [4847] by rjw

3 edits in trunk/WebKit

Fixed 3383623 (and 3384896). Remove our unbeknownst work-around for an NSImage bug that incorrectly flipped y coordinate when drawing a partial rect within the image. This has been fixed in Panther, making our work-around no longer necessary.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:]):
WebKit.pbproj/project.pbxproj:

5:26 PM Changeset in webkit [4846] by hyatt

4 edits in trunk/WebCore

Fixes for 3380766 and 3381867. One is a table bug with amazon.com where colspans
were losing percentage width values. The other is a bug where floats aren't dirtying
objects into which they intrude when doing layout.

Reviewed by darin

khtml/rendering/render_block.cpp:
khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth):

2:49 PM Changeset in webkit [4845] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3379336>: flash on front page of http://www.westportmotorsports.com is broken

Reviewed by darin.

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Ignore the PARAM tags and only use attributes inside the OBJECT tag when the EMBED tag is omitted.

1:58 PM Changeset in webkit [4844] by darin

6 edits in trunk/WebCore

Reviewed by Dave.

fixed 3343681 -- clicking on a disabled submit button submits the form!

This turned out to be a problem with code in dispatchGenericEvent that sent
DOMActivate events even when the form element was disabled.

khtml/xml/dom_nodeimpl.h: Add virtual disabled() member function.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Don't send DOM activate events for disabled elements. (NodeImpl::handleLocalEvents): Don't send mouse events for disabled elements. But we do want those events to pass through the bubble and capture phases, just avoid triggering any listeners on this node itself. (NodeImpl::disabled): Added default implementation that returns false.

khtml/html/html_formimpl.h: Removed the disabled() function's inline implementation since it's now virtual and it's not helpful to inline virtual functions.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::disabled): Moved this method into the .cpp file since it's now virtual and it's not helpful to inline virtual functions.

1:07 PM Changeset in webkit [4843] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3380411 -- Unicode supplementary characters cut in half in text control with maxlength set

kwq/KWQTextField.mm: (-[KWQTextField setMaximumLength:]): Enforce maximum length based on number of composed character sequences rather than on number of UTF-16 values. This helps with both surrogate pairs (the supplementary characters mentioned in the bug report) and composed character sequences. (-[KWQTextField setStringValue:]): Ditto. (-[KWQTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]): Ditto. (-[NSString _KWQ_numComposedCharacterSequences]): Added. Computes the length of a string in terms of number of composed character sequences. (-[NSString _KWQ_truncateToNumComposedCharacterSequences:]): Added. Truncates a string in terms of number of composed character sequences.

11:08 AM Changeset in webkit [4842] by sheridan

3 edits in trunk

94u version numbers

Aug 18, 2003:

5:09 PM Changeset in webkit [4841] by rjw

4 edits in trunk/WebKit

Fixed 3140065. Bidi neutrals in RTL runs are now handled correctly. Still have
problem with bidi neutrals at directional boundaries 3382926.

Reviewed by Maciej.

Misc.subproj/WebUnicode.h:
Misc.subproj/WebUnicode.m: (shapedString):
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):

2:12 PM Changeset in webkit [4840] by darin

17 edits in trunk

WebCore:

Reviewed by Maciej.

fixed 3299893 -- oncontextmenu support

kwq/WebCoreBridge.h: Added sendContextMenuEvent: method.
kwq/WebCoreBridge.mm: (-[WebCoreBridge sendContextMenuEvent:]): Added. Calls sendContextMenuEvent on the part.

kwq/KWQKHTMLPart.h: Added sendContextMenuEvent member function.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): Added. Sets up a suitable mouse event and calls dispatchMouseEvent for CONTEXTMENU_EVENT.

khtml/ecma/kjs_dom.cpp: Added oncontextmenu to DOMNode's list of properties. (DOMNode::getValueProperty): Added case for OnContextMenu. (DOMNode::putValue): Added case for OnContextMenu.
khtml/ecma/kjs_dom.h: Added constant for OnContextMenu.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): Added case for ATTR_ONCONTEXTMENU.
khtml/misc/htmlattrs.in: Added oncontextmenu.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Added case for CONTEXTMENU_EVENT. (EventImpl::idToType): Added case for CONTEXTMENU_EVENT.
khtml/xml/dom2_eventsimpl.h: Added CONTEXTMENU_EVENT.

khtml/ecma/kjs_dom.lut.h: Regenerated.
khtml/misc/htmlattrs.c: Regenerated.
khtml/misc/htmlattrs.h: Regenerated.

WebKit:

Reviewed by Maciej.

fixed 3299893 -- oncontextmenu support

WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Call sendContextMenuEvent: on the bridge, and don't show a menu if the event is handled over in WebCore. (-[WebHTMLView mouseDown:]): Don't send a mouse down event in the case where we already sent a context menu event and decided not to put up a real context menu.

2:03 PM Changeset in webkit [4839] by rjw

2 edits in trunk/WebKit

Fix build problem from last checkin.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):

12:23 PM Changeset in webkit [4838] by darin

3 edits
4 adds in trunk

Reviewed by Maciej.

fixed 3381295 -- regular expression matches for text with UTF-16 surrogates will give incorrect results

kwq/KWQRegExp.mm: (QRegExp::match): Removed local copy of convertCharacterOffsetsToUTF8ByteOffsets and its reverse. Instead use convertUTF16OffsetsToUTF8Offsets and its reverse, now available from <JavaScriptCore/ustring.h>.

added test for the URI encoding and decoding functions in JavaScriptCore

layout-tests/fast/js/global/encode-URI-test-expected.txt: Added.
layout-tests/fast/js/global/encode-URI-test.html: Added.

11:51 AM Changeset in webkit [4837] by darin

8 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed 3247528 -- encodeURI missing from JavaScriptCore (needed by Crystal Reports)
fixed 3381297 -- escape method does not escape the null character
fixed 3381299 -- escape method produces incorrect escape sequences ala WinIE, rather than correct ala Gecko
fixed 3381303 -- unescape method treats escape sequences as Latin-1 ala WinIE rather than as UTF-8 ala Gecko
fixed 3381304 -- unescape method garbles strings with bad escape sequences in them

kjs/function.h: Added constants for decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent.
kjs/function.cpp: (encode): Added. New helper function for escape, encodeURI, and encodeURIComponent. (decode): Added. New helper function for unescape, decodeURI, and decodeURIComponent. (GlobalFuncImp::call): Added decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent implementations. Changed escape and unescape to use new helper functions, which fixes the four problems above.

kjs/internal.cpp: (InterpreterImp::initGlobalObject): Add decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent to the global object.

kjs/ustring.h: Added a length to the CString class so it can hold strings with null characters in them, not just null-terminated strings. This allows a null character from a UString to survive the process of UTF-16 to UTF-8 decoding. Added overloads to UString::append, UString::UTF8String, UTF8SequenceLength, decodeUTF8Sequence, convertUTF16OffsetsToUTF8Offsets, and convertUTF8OffsetsToUTF16Offsets.

kjs/ustring.cpp: (CString::CString): Set up the length properly in all the constructors. Also add a new constructor that takes a length. (CString::append): Use and set the length properly. (CString::operator=): Use and set the length properly. (operator==): Use and the length and memcmp instead of strcmp. (UString::append): Added new overloads for const char * and for a single string to make it more efficient to build up a UString from pieces. The old way, a UString was created and destroyed each time you appended. (UTF8SequenceLength): New. Helper for decoding UTF-8. (decodeUTF8Sequence): New. Helper for decoding UTF-8. (UString::UTF8String): New. Decodes from UTF-16 to UTF-8. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (compareStringOffsets): Moved from regexp.cpp. (createSortedOffsetsArray): Moved from regexp.cpp. (convertUTF16OffsetsToUTF8Offsets): New. Converts UTF-16 offsets to UTF-8 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (convertUTF8OffsetsToUTF16Offsets): New. Converts UTF-8 offsets to UTF-16 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates.

fixed 3381296 -- regular expression matches with UTF-16 surrogates will treat sequences as two characters

kjs/regexp.cpp: (RegExp::RegExp): Use the new UString::UTF8String function instead a function in this file. (RegExp::match): Use the new convertUTF16OffsetsToUTF8Offsets (and the corresponding reverse) instead of convertCharacterOffsetsToUTF8ByteOffsets in this file.

9:10 AM Changeset in webkit [4836] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3380418>: Ignore specified string encoding when constructing file, mailto and help URLs

Reviewed by mjs, darin.

kwq/KWQKURL.mm: (KURL::KURL): store the URL string as UTF-8 when the URL is file, mailto and help.

7:50 AM Changeset in webkit [4835] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3366542 -- filename with non-ASCII name left out of Content-Disposition for <input type=file>

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Do the &-encoding thing on the filename. This is what Gecko does.

Aug 17, 2003:

11:02 PM Changeset in webkit [4834] by darin

4 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3376522 -- REGRESSION: uncaught exception from bad .ico causes crash (login window at 34sp.com)

I added exception handling in all the places we load images with NSImage.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconsForIconURLString:]): Add exception handler.
Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): Add exception handler.
WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): Add exception handler. (-[WebImageRenderer initWithContentsOfFile:]): Add exception handler. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Add exception handler.

Aug 15, 2003:

5:10 PM Changeset in webkit [4833] by mjs

3 edits in trunk/WebCore

Fixed by Darin, reviewed by me (and originally figured out by John).

fixed 3375592 - New Yahoo Maps doesn't work right

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Don't pass through null characters. (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto. (KWQTextDecoder::convertUsingTEC): Ditto.

5:04 PM Changeset in webkit [4832] by rjw