Timeline
Aug 22, 2003:
- 9:09 PM Changeset in webkit [4882] by
-
- 4 edits in trunk/WebKit
- fixed 3385837 -- REGRESSION: can't paste link from Safari into Keynote (paste at top level, not into text)
Reviewed by Darin
The problem was that we were using a single list of pasteboard
types for both "types we can read" and "types we can write", but
NSFilenamesPBoardType wasn't being written to, creating a bad
pasteboard. The fix is to split this list in two. We could do
this a little more elegantly if we weren't paranoid about
last-minute SPI changes breaking compatibility with Sherlock or
some other internal client.
- Misc.subproj/WebNSPasteboardExtras.h: add new _web_writableDragTypesForURL, commented various methods better.
- Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_writableDragTypesForURL]): implement _web_writableDragTypesForURL; it's just like _web_dragTypesForURL but without the NSFilenamesPBoardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use _web_writableDragTypesForURL
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:title:event:]): use _web_writableDragTypesForURL
- 3:02 PM Changeset in webkit [4881] by
-
- 3 edits in trunk/WebCore
Fix for 3388363, copying a word in a list item copied too much. The code that checked
for the bullet would add in too much text sometimes.
Reviewed by john
- kwq/KWQKHTMLPart.mm: (isTextFirstInListItem): (KWQKHTMLPart::attributedString):
- 12:28 PM Changeset in webkit [4880] by
-
- 2 edits in trunk/WebKit
Reviewed by Dave.
- fixed 3386051 -- REGRESSION: text "too dark" after the page is deactivated and reactivated (bugweb)
Cached clips were causing us to draw nothing for the top frames of framesets, resulting in darkened
text because we draw anti-aliased text twice without drawing a background.
- WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Invalidate cached graphics state when changing the visible rect. (-[WebClipView setAdditionalClip:]): Ditto.
- 10:33 AM Changeset in webkit [4879] by
-
- 3 edits in trunk
95u version number
Aug 21, 2003:
- 9:22 PM Changeset in webkit [4878] by
-
- 4 edits in trunk/WebCore
- Makefile.am: Work around DLCFN issue to prevent constant churn of config.h.
- config.h: Regenerated without DLCFN.
- 9:21 PM Changeset in webkit [4877] by
-
- 2 edits in trunk/WebKit
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): Tweak to printing fix: Be sure to call adjustViewSize after applying styles and doing layout.
- 9:18 PM Changeset in webkit [4876] by
-
- 3 edits in trunk/WebCore
- khtml/khtmlview.h: Formatting tweak.
- 6:31 PM Changeset in webkit [4875] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3386673>: a particular fidelity.com "Log in" link does nothing because of cross-domain JavaScript rules
Reviewed by mjs.
- config.h:
- khtml/ecma/kjs_window.cpp: (Window::get): allow other frames to get the location object (Window::isSafeScript): added JS logging (Location::get): don't allow other frames to access location attributes (LocationFunc::tryCall): don't allow other frames to call functions on the location object
- 5:45 PM Changeset in webkit [4874] by
-
- 10 edits in trunk
WebKit:
Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.
Reviewed by Hyatt.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): (-[WebHTMLView drawRect:]): (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): (-[WebHTMLView beginDocument]): (-[WebHTMLView endDocument]):
WebCore:
Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.
Reviewed by Hyatt.
- khtml/khtmlview.cpp: (KHTMLView::adjustViewSize):
- khtml/khtmlview.h:
- khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
- kwq/KWQScrollView.mm: (QScrollView::resizeContents):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge adjustViewSize]):
- 4:57 PM Changeset in webkit [4873]
-
- 3 copies in tags/Safari-94
This commit was manufactured by cvs2svn to create tag 'Safari-94'.
- 4:57 PM Changeset in webkit [4872] by
-
- 8 edits in trunk
Safari-94
- 2:05 PM Changeset in webkit [4871] by
-
- 2 edits in trunk/WebKit
- fixed 3387950 -- REGRESSION (85-89): Standalone image in Safari prints much smaller than in Jaguar
Reviewed by Chris.
- WebView.subproj/WebImageView.m: (-[WebImageView adjustFrameSize]): renamed from setFrameSizeUsingImage; now sets the frame size to exactly the image size (as it did in Jaguar always) when we're not drawing to the screen. (-[WebImageView setFrameSize:]): updated for name change (-[WebImageView layout]): ditto (-[WebImageView beginDocument]): adjust frame size (before printing) (-[WebImageView endDocument]): adjust frame size (after printing)
- 12:14 PM Changeset in webkit [4870] by
-
- 2 adds in trunk/LayoutTests/fast/block/float
Add a test for relpositioned floats.
- 11:52 AM Changeset in webkit [4869] by
-
- 3 edits in trunk/WebCore
Fix for 3387302, floats weren't being allowed to be relatively positioned. The
fix is trivial. Stop making floating/relpositiion setting an if/else and just make
it two ifs.
Reviewed by darin
- khtml/rendering/render_box.cpp: (RenderBox::setStyle):
- 2:27 AM Changeset in webkit [4868] by
-
- 2 adds in trunk/LayoutTests/fast/inline-block
The most evil test I've ever come up with.
- 2:21 AM Changeset in webkit [4867] by
-
- 2 adds in trunk/LayoutTests/fast/text/basic
Add test case for the unicode bullet bug.
- 2:17 AM Changeset in webkit [4866] by
-
- 3 edits in trunk/WebCore
Fix for 3384635, breakable unicode characters that were preceded by multiple spaces
accidentally added in those spaces to their widths.
Reviewed by rjw and gramps
- khtml/rendering/bidi.cpp:
Aug 20, 2003:
- 7:19 PM Changeset in webkit [4865] by
-
- 2 edits in trunk/LayoutTests/fast/block/float
Fix this float test.
- 6:02 PM Changeset in webkit [4864] by
-
- 2 adds in trunk/LayoutTests/fast/overflow
Adding overflow test with percentage widths.
- 6:00 PM Changeset in webkit [4863] by
-
- 1 edit in trunk/LayoutTests/fast/block/float/003-expected.txt
Repair float test case.
- 5:52 PM Changeset in webkit [4862] by
-
- 4 edits in trunk/WebCore
Fix for 3384609. Objects that want to dodge floats should fill the line width instead
of the containing block width only if their widths are auto. If widths are specified
explicitly, then ccontaining block width should be honored.
Reviewed by john
- khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
- khtml/rendering/render_table.cpp: (RenderTable::calcWidth):
- 5:17 PM Changeset in webkit [4861] by
-
- 3 edits in trunk/WebCore
UCFindTextBreak will report false if we have a sequence of 0xa0 0x20 (nbsp, sp), so we explicity check for that case. Filed 3386852 to track this problem, meanwhile added a work-around. This problem was revealed after adding the fix for 3242508.
Reviewed by Dave.
- khtml/rendering/break_lines.cpp:
- 4:02 PM Changeset in webkit [4860] by
-
- 1 edit in trunk/LayoutTests/fast/frames/empty-frame-src-expected.txt
Updating layout tests.
- 3:48 PM Changeset in webkit [4859] by
-
- 1 edit2 adds in trunk/LayoutTests/fast/table
Correcting the glitch caused by textareas changing size and add a layout test for the amazon.com colspan table issue.
- 3:46 PM Changeset in webkit [4858] by
-
- 2 adds in trunk/LayoutTests/fast/block/positioning
Adding a positioning test that makes sure spaces are properly stripped when computing maxwidths.
- 3:44 PM Changeset in webkit [4857] by
-
- 2 adds in trunk/LayoutTests/fast/block/float
Adding a float test that mixes positioning, inline blocks, and text-indent. The horror, the horror.
- 3:37 PM Changeset in webkit [4856] by
-
- 2 adds in trunk/LayoutTests/fast/block/float
Adding a float test for overflowing and line breaking.
- 3:34 PM Changeset in webkit [4855] by
-
- 2 adds in trunk/LayoutTests/fast/block/positioning
Adding a test of line breaking inside positioned elements.
- 3:31 PM Changeset in webkit [4854] by
-
- 5 edits in trunk/WebCore
Reviewed by John.
- fixed 3248069 -- Safari does not support ISO Latin 10 (ISO-8859-16, romanian) coding.
- kwq/mac-encodings.txt: Added ISO-8859-16, which maps to ISO Latin-10.
- kwq/KWQCharsetData.c: Regenerated.
- kwq/KWQCharsets.mm: Add definition of kCFStringEncodingISOLatin10, since this encoding is currently only in TextCommon.h, not in CFStringEncodingExt.h.
- 3:20 PM Changeset in webkit [4853] by
-
- 1 edit2 adds in trunk/LayoutTests/fast/frames
Adding an object/iframe test for padding/borders.
- 3:15 PM Changeset in webkit [4852] by
-
- 2 adds in trunk/LayoutTests/fast/css-generated-content
Add a <q>/<p> test for split anonymous content.
- 3:05 PM Changeset in webkit [4851] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- fixed 3384963 - REGRESSION: assertion in copyPathRemovingDots, crash parsing URL in snippet editor
- kwq/KWQKURL.mm: (copyPathRemovingDots): It's OK if the path is entirely empty.
- 3:03 PM Changeset in webkit [4850] by
-
- 6 edits in trunk/WebCore
Fix for 3385211, <td>s should ignore the float property in quirks mode. This
patch cleans up the adjustments of <td>s and <table>s and moves the code into
the style selector (instead of cluttering up the rendering code).
Fix for 3385476, generated content not built correctly. All generated content
should be placed inside a containing object that actually gets the pseudo-style.
Reviewed by rjw
- ChangeLog:
- khtml/css/cssstyleselector.cpp:
- khtml/css/cssstyleselector.h:
- khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
- khtml/rendering/render_object.cpp: (RenderObject::createObject):
- 1:48 PM Changeset in webkit [4849] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- fixed 3292036 - albertsons.com world leak of 2 WebDataSource and 2 WebHTMLRepresentation objects
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Test for parentPart() even if there is no document.
- 11:24 AM Changeset in webkit [4848] by
-
- 5 edits in trunk/WebCore
Fixed 3242508. Japanese (and other non latin1 scripts) line breaking incorrect when mixed with latin1.
Reviewed by Dave.
- khtml/rendering/break_lines.cpp:
Checkin fix for earlier bug that was already approved!
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
Aug 19, 2003:
- 6:18 PM Changeset in webkit [4847] by
-
- 3 edits in trunk/WebKit
Fixed 3383623 (and 3384896). Remove our unbeknownst work-around for an NSImage bug that incorrectly flipped y coordinate when drawing a partial rect within the image. This has been fixed in Panther, making our work-around no longer necessary.
Reviewed by Darin.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:]):
- WebKit.pbproj/project.pbxproj:
- 5:26 PM Changeset in webkit [4846] by
-
- 4 edits in trunk/WebCore
Fixes for 3380766 and 3381867. One is a table bug with amazon.com where colspans
were losing percentage width values. The other is a bug where floats aren't dirtying
objects into which they intrude when doing layout.
Reviewed by darin
- khtml/rendering/render_block.cpp:
- khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth):
- 2:49 PM Changeset in webkit [4845] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3379336>: flash on front page of http://www.westportmotorsports.com is broken
Reviewed by darin.
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Ignore the PARAM tags and only use attributes inside the OBJECT tag when the EMBED tag is omitted.
- 1:58 PM Changeset in webkit [4844] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3343681 -- clicking on a disabled submit button submits the form!
This turned out to be a problem with code in dispatchGenericEvent that sent
DOMActivate events even when the form element was disabled.
- khtml/xml/dom_nodeimpl.h: Add virtual disabled() member function.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Don't send DOM activate events for disabled elements. (NodeImpl::handleLocalEvents): Don't send mouse events for disabled elements. But we do want those events to pass through the bubble and capture phases, just avoid triggering any listeners on this node itself. (NodeImpl::disabled): Added default implementation that returns false.
- khtml/html/html_formimpl.h: Removed the disabled() function's inline implementation since it's now virtual and it's not helpful to inline virtual functions.
- khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::disabled): Moved this method into the .cpp file since it's now virtual and it's not helpful to inline virtual functions.
- 1:07 PM Changeset in webkit [4843] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3380411 -- Unicode supplementary characters cut in half in text control with maxlength set
- kwq/KWQTextField.mm: (-[KWQTextField setMaximumLength:]): Enforce maximum length based on number of composed character sequences rather than on number of UTF-16 values. This helps with both surrogate pairs (the supplementary characters mentioned in the bug report) and composed character sequences. (-[KWQTextField setStringValue:]): Ditto. (-[KWQTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]): Ditto. (-[NSString _KWQ_numComposedCharacterSequences]): Added. Computes the length of a string in terms of number of composed character sequences. (-[NSString _KWQ_truncateToNumComposedCharacterSequences:]): Added. Truncates a string in terms of number of composed character sequences.
- 11:08 AM Changeset in webkit [4842] by
-
- 3 edits in trunk
94u version numbers
Aug 18, 2003:
- 5:09 PM Changeset in webkit [4841] by
-
- 4 edits in trunk/WebKit
Fixed 3140065. Bidi neutrals in RTL runs are now handled correctly. Still have
problem with bidi neutrals at directional boundaries 3382926.
Reviewed by Maciej.
- Misc.subproj/WebUnicode.h:
- Misc.subproj/WebUnicode.m: (shapedString):
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
- 2:12 PM Changeset in webkit [4840] by
-
- 17 edits in trunk
WebCore:
Reviewed by Maciej.
- fixed 3299893 -- oncontextmenu support
- kwq/WebCoreBridge.h: Added sendContextMenuEvent: method.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge sendContextMenuEvent:]): Added. Calls sendContextMenuEvent on the part.
- kwq/KWQKHTMLPart.h: Added sendContextMenuEvent member function.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): Added. Sets up a suitable mouse event and calls dispatchMouseEvent for CONTEXTMENU_EVENT.
- khtml/ecma/kjs_dom.cpp: Added oncontextmenu to DOMNode's list of properties. (DOMNode::getValueProperty): Added case for OnContextMenu. (DOMNode::putValue): Added case for OnContextMenu.
- khtml/ecma/kjs_dom.h: Added constant for OnContextMenu.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): Added case for ATTR_ONCONTEXTMENU.
- khtml/misc/htmlattrs.in: Added oncontextmenu.
- khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Added case for CONTEXTMENU_EVENT. (EventImpl::idToType): Added case for CONTEXTMENU_EVENT.
- khtml/xml/dom2_eventsimpl.h: Added CONTEXTMENU_EVENT.
- khtml/ecma/kjs_dom.lut.h: Regenerated.
- khtml/misc/htmlattrs.c: Regenerated.
- khtml/misc/htmlattrs.h: Regenerated.
WebKit:
Reviewed by Maciej.
- fixed 3299893 -- oncontextmenu support
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Call sendContextMenuEvent: on the bridge, and don't show a menu if the event is handled over in WebCore. (-[WebHTMLView mouseDown:]): Don't send a mouse down event in the case where we already sent a context menu event and decided not to put up a real context menu.
- 2:03 PM Changeset in webkit [4839] by
-
- 2 edits in trunk/WebKit
Fix build problem from last checkin.
Reviewed by Darin.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):
- 12:23 PM Changeset in webkit [4838] by
-
- 3 edits4 adds in trunk
Reviewed by Maciej.
- fixed 3381295 -- regular expression matches for text with UTF-16 surrogates will give incorrect results
- kwq/KWQRegExp.mm: (QRegExp::match): Removed local copy of convertCharacterOffsetsToUTF8ByteOffsets and its reverse. Instead use convertUTF16OffsetsToUTF8Offsets and its reverse, now available from <JavaScriptCore/ustring.h>.
- added test for the URI encoding and decoding functions in JavaScriptCore
- layout-tests/fast/js/global/encode-URI-test-expected.txt: Added.
- layout-tests/fast/js/global/encode-URI-test.html: Added.
- 11:51 AM Changeset in webkit [4837] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fixed 3247528 -- encodeURI missing from JavaScriptCore (needed by Crystal Reports)
- fixed 3381297 -- escape method does not escape the null character
- fixed 3381299 -- escape method produces incorrect escape sequences ala WinIE, rather than correct ala Gecko
- fixed 3381303 -- unescape method treats escape sequences as Latin-1 ala WinIE rather than as UTF-8 ala Gecko
- fixed 3381304 -- unescape method garbles strings with bad escape sequences in them
- kjs/function.h: Added constants for decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent.
- kjs/function.cpp: (encode): Added. New helper function for escape, encodeURI, and encodeURIComponent. (decode): Added. New helper function for unescape, decodeURI, and decodeURIComponent. (GlobalFuncImp::call): Added decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent implementations. Changed escape and unescape to use new helper functions, which fixes the four problems above.
- kjs/internal.cpp: (InterpreterImp::initGlobalObject): Add decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent to the global object.
- kjs/ustring.h: Added a length to the CString class so it can hold strings with null characters in them, not just null-terminated strings. This allows a null character from a UString to survive the process of UTF-16 to UTF-8 decoding. Added overloads to UString::append, UString::UTF8String, UTF8SequenceLength, decodeUTF8Sequence, convertUTF16OffsetsToUTF8Offsets, and convertUTF8OffsetsToUTF16Offsets.
- kjs/ustring.cpp: (CString::CString): Set up the length properly in all the constructors. Also add a new constructor that takes a length. (CString::append): Use and set the length properly. (CString::operator=): Use and set the length properly. (operator==): Use and the length and memcmp instead of strcmp. (UString::append): Added new overloads for const char * and for a single string to make it more efficient to build up a UString from pieces. The old way, a UString was created and destroyed each time you appended. (UTF8SequenceLength): New. Helper for decoding UTF-8. (decodeUTF8Sequence): New. Helper for decoding UTF-8. (UString::UTF8String): New. Decodes from UTF-16 to UTF-8. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (compareStringOffsets): Moved from regexp.cpp. (createSortedOffsetsArray): Moved from regexp.cpp. (convertUTF16OffsetsToUTF8Offsets): New. Converts UTF-16 offsets to UTF-8 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates. (convertUTF8OffsetsToUTF16Offsets): New. Converts UTF-8 offsets to UTF-16 offsets, given a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling for UTF-16 surrogates.
- fixed 3381296 -- regular expression matches with UTF-16 surrogates will treat sequences as two characters
- kjs/regexp.cpp: (RegExp::RegExp): Use the new UString::UTF8String function instead a function in this file. (RegExp::match): Use the new convertUTF16OffsetsToUTF8Offsets (and the corresponding reverse) instead of convertCharacterOffsetsToUTF8ByteOffsets in this file.
- 9:10 AM Changeset in webkit [4836] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3380418>: Ignore specified string encoding when constructing file, mailto and help URLs
Reviewed by mjs, darin.
- kwq/KWQKURL.mm: (KURL::KURL): store the URL string as UTF-8 when the URL is file, mailto and help.
- 7:50 AM Changeset in webkit [4835] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3366542 -- filename with non-ASCII name left out of Content-Disposition for <input type=file>
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Do the &-encoding thing on the filename. This is what Gecko does.
