Timeline
Aug 25, 2003:
- 4:26 PM Changeset in webkit [4886] by
-
- 2 edits in trunk/WebKit
Fix for 3391609. Our rounding hack wasn't correctly reflected in the selection point
code. Piggy-backed on this fix are fixes for selection of letter-spacing, word-spacing
and justified text.
Reviewed by Hyatt.
- WebCoreSupport.subproj/WebTextRenderer.m: (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (widthForNextCharacter): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
- 4:08 PM Changeset in webkit [4885] by
-
- 2 edits in trunk/WebKit
- fixed 3391264 -- REGRESSION (Panther): Back/Forward buttons not updating immediately after page load
The buttons are updated in response to window update notifications.
Jaguar was sending so many extra bogus notifications that it
masked the fact that we weren't ensuring that these notifications
were sent at all in the case of non-event-based interesting
changes that might affect menu items/toolbar items/etc.
Reviewed by Richard
- WebView.subproj/WebViewPrivate.m: (-[WebView _didStartProvisionalLoadForFrame:]): call -[NSApp setWindowsNeedUpdate:YES] so window update notices will be sent (-[WebView _didCommitLoadForFrame:]): ditto (-[WebView _didFinishLoadForFrame:]): ditto (-[WebView _didFailLoadWithError:forFrame:]): ditto (-[WebView _didFailProvisionalLoadWithError:forFrame:]): ditto
Aug 24, 2003:
- 6:57 PM Changeset in webkit [4884] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- fixed 3098350 -- opt. params to date methods are ignored (can't set end date in Exchange/Outlook web cal.)
- kjs/date_object.cpp: (DateProtoFuncImp::call): Added code to handle the optional parameters. Strangely, the table of functions already had the right number of parameters listed, but the code to look at the parameter values was missing.
- 6:44 PM Changeset in webkit [4883] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed 3382179 -- REGRESSION: many images scroll down while loading (e.g., homepage.mac.com slide show)
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): While loading, always draw one less line than the number NSImage says we have, since that last line is a partial line and draws unwanted white. This is not what the bug report complains about, but is a longstanding and very minor issue. Remove the code that adjust the Y origin. This is what the bug report is about. That adjustment is incorrect and was unknowingly compensating for some kind of NSImage bug that is now fixed. (-[WebImageRenderer tileInRect:fromPoint:]): Added an assertion that the WebImageRenderer is flipped. The code does assume that it's flipped.
Aug 22, 2003:
- 9:09 PM Changeset in webkit [4882] by
-
- 4 edits in trunk/WebKit
- fixed 3385837 -- REGRESSION: can't paste link from Safari into Keynote (paste at top level, not into text)
Reviewed by Darin
The problem was that we were using a single list of pasteboard
types for both "types we can read" and "types we can write", but
NSFilenamesPBoardType wasn't being written to, creating a bad
pasteboard. The fix is to split this list in two. We could do
this a little more elegantly if we weren't paranoid about
last-minute SPI changes breaking compatibility with Sherlock or
some other internal client.
- Misc.subproj/WebNSPasteboardExtras.h: add new _web_writableDragTypesForURL, commented various methods better.
- Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard _web_writableDragTypesForURL]): implement _web_writableDragTypesForURL; it's just like _web_dragTypesForURL but without the NSFilenamesPBoardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use _web_writableDragTypesForURL
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:title:event:]): use _web_writableDragTypesForURL
- 3:02 PM Changeset in webkit [4881] by
-
- 3 edits in trunk/WebCore
Fix for 3388363, copying a word in a list item copied too much. The code that checked
for the bullet would add in too much text sometimes.
Reviewed by john
- kwq/KWQKHTMLPart.mm: (isTextFirstInListItem): (KWQKHTMLPart::attributedString):
- 12:28 PM Changeset in webkit [4880] by
-
- 2 edits in trunk/WebKit
Reviewed by Dave.
- fixed 3386051 -- REGRESSION: text "too dark" after the page is deactivated and reactivated (bugweb)
Cached clips were causing us to draw nothing for the top frames of framesets, resulting in darkened
text because we draw anti-aliased text twice without drawing a background.
- WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Invalidate cached graphics state when changing the visible rect. (-[WebClipView setAdditionalClip:]): Ditto.
- 10:33 AM Changeset in webkit [4879] by
-
- 3 edits in trunk
95u version number
Aug 21, 2003:
- 9:22 PM Changeset in webkit [4878] by
-
- 4 edits in trunk/WebCore
- Makefile.am: Work around DLCFN issue to prevent constant churn of config.h.
- config.h: Regenerated without DLCFN.
- 9:21 PM Changeset in webkit [4877] by
-
- 2 edits in trunk/WebKit
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): Tweak to printing fix: Be sure to call adjustViewSize after applying styles and doing layout.
- 9:18 PM Changeset in webkit [4876] by
-
- 3 edits in trunk/WebCore
- khtml/khtmlview.h: Formatting tweak.
- 6:31 PM Changeset in webkit [4875] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3386673>: a particular fidelity.com "Log in" link does nothing because of cross-domain JavaScript rules
Reviewed by mjs.
- config.h:
- khtml/ecma/kjs_window.cpp: (Window::get): allow other frames to get the location object (Window::isSafeScript): added JS logging (Location::get): don't allow other frames to access location attributes (LocationFunc::tryCall): don't allow other frames to call functions on the location object
- 5:45 PM Changeset in webkit [4874] by
-
- 10 edits in trunk
WebKit:
Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.
Reviewed by Hyatt.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): (-[WebHTMLView drawRect:]): (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): (-[WebHTMLView beginDocument]): (-[WebHTMLView endDocument]):
WebCore:
Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.
Reviewed by Hyatt.
- khtml/khtmlview.cpp: (KHTMLView::adjustViewSize):
- khtml/khtmlview.h:
- khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
- kwq/KWQScrollView.mm: (QScrollView::resizeContents):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge adjustViewSize]):
- 4:57 PM Changeset in webkit [4873]
-
- 3 copies in tags/Safari-94
This commit was manufactured by cvs2svn to create tag 'Safari-94'.
- 4:57 PM Changeset in webkit [4872] by
-
- 8 edits in trunk
Safari-94
- 2:05 PM Changeset in webkit [4871] by
-
- 2 edits in trunk/WebKit
- fixed 3387950 -- REGRESSION (85-89): Standalone image in Safari prints much smaller than in Jaguar
Reviewed by Chris.
- WebView.subproj/WebImageView.m: (-[WebImageView adjustFrameSize]): renamed from setFrameSizeUsingImage; now sets the frame size to exactly the image size (as it did in Jaguar always) when we're not drawing to the screen. (-[WebImageView setFrameSize:]): updated for name change (-[WebImageView layout]): ditto (-[WebImageView beginDocument]): adjust frame size (before printing) (-[WebImageView endDocument]): adjust frame size (after printing)
- 12:14 PM Changeset in webkit [4870] by
-
- 2 adds in trunk/LayoutTests/fast/block/float
Add a test for relpositioned floats.
- 11:52 AM Changeset in webkit [4869] by
-
- 3 edits in trunk/WebCore
Fix for 3387302, floats weren't being allowed to be relatively positioned. The
fix is trivial. Stop making floating/relpositiion setting an if/else and just make
it two ifs.
Reviewed by darin
- khtml/rendering/render_box.cpp: (RenderBox::setStyle):
- 2:27 AM Changeset in webkit [4868] by
-
- 2 adds in trunk/LayoutTests/fast/inline-block
The most evil test I've ever come up with.
- 2:21 AM Changeset in webkit [4867] by
-
- 2 adds in trunk/LayoutTests/fast/text/basic
Add test case for the unicode bullet bug.
- 2:17 AM Changeset in webkit [4866] by
-
- 3 edits in trunk/WebCore
Fix for 3384635, breakable unicode characters that were preceded by multiple spaces
accidentally added in those spaces to their widths.
Reviewed by rjw and gramps
- khtml/rendering/bidi.cpp:
