⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 18, 2003:

2:56 PM Changeset in webkit [5005] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/date_object.cpp: Removed our CF-based implementations of gmtime, localtime, mktime, timegm, and time, since they no longer have the slow "hit the filesystem every time" behavior.
8:26 AM Changeset in webkit [5004] by sullivan
  • 14 edits in trunk

WebCore:

  • WebCore part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

  • kwq/KWQKHTMLSettings.h: add _shouldPrintBackgrounds field and accessors
  • kwq/WebCoreSettings.h: add shouldPrintBackgrounds field and accessors
  • kwq/WebCoreSettings.mm: (-[WebCoreSettings setShouldPrintBackgrounds:]): new method, passes value to KHTMLSettings (-[WebCoreSettings shouldPrintBackgrounds]): new method
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge styleSheetForPrinting]): new method, returns a style sheet that has backgrounds turned off if preference is set that way. (-[WebCoreBridge reapplyStylesForDeviceType:]): if printing, set the printStyleSheet to the one we created based on the preferences. (KHTML has always had support for a special printStyleSheet, but it was only being used in !APPLE_CHANGES code.)
  • khtml/rendering/render_style.h: add shouldCorrectTextColor boolean field and accessors
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): tell style to correct text colors if backgrounds aren't being printed
  • khtml/rendering/render_text.cpp: (TextRun::paintSelection): added comment (simpleDifferenceBetweenColors): new function, computes a quick measure of difference between colors (correctedTextColor): if text and background colors are too similar, returns lightened or darkened text color (RenderText::paintObject): if style says to correct text colors, call correctedTextColor

WebKit:

  • WebKit part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

  • WebView.subproj/WebPreferences.h: new accessor methods for new shouldPrintBackgrounds preference
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): set initial value for WebKitShouldPrintBackgroundsPreferenceKey to NO (-[WebPreferences shouldPrintBackgrounds]): new method, read NSUserDefaults value (-[WebPreferences setShouldPrintBackgrounds:]): new method, write NSUserDefault value
  • WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): tell WebCore about value of shouldPrintBackgrounds
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes

WebBrowser:

  • WebBrowser part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

  • English.lproj/PrintingAccessoryView.nib: new nib file, contains view holding single "Print Backgrounds" checkbox
  • PrintingAccessoryViewController.h: Added.
  • PrintingAccessoryViewController.m: Added. (-[PrintingAccessoryViewController init]): load the nib file with self as owner (+[PrintingAccessoryViewController sharedController]): returns shared instance used by BrowserDocument (-[PrintingAccessoryViewController togglePrintBackgrounds:]): toggle the WebKit preference (which in turn updates the WebCore setting) (-[PrintingAccessoryViewController accessoryView]): returns the view from the nib that will be displayed in the print panel, after updating the checkbox state
  • BrowserDocument.m: (-[BrowserDocument printWebFrameView:showingPrintPanel:]): Set up print panel's accessory view
  • Preferences.subproj/AppearancePreferences.m: removed unused method I stumbled across
  • WebBrowser.pbproj/project.pbxproj: updated for new files
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

Sep 17, 2003:

5:08 PM Changeset in webkit [5003] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Pass the "no UI" flag, so we don't prompt the user when we're trying to load plug-ins. Also use OSStatus rather than OSErr so we don't miss error codes that just happen to have zeroes in the low 16 bits.
5:05 PM Changeset in webkit [5002] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton setFilename:]): Don't call -[NSWorkspace iconForFile:] on a path that does not start with a '/'. This can happen if JavaScript or the web page sets the path explicitly, and adding this check avoids an unpleasant warning on the console.
2:51 PM Changeset in webkit [5001] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3423404 -- REGRESSION: Japanese page appears blank due to unexpected kTECPartialCharErr
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): In the case where we're already going from the small buffer back to the large one, treat kTECPartialCharErr the same as noErr. Otherwise we'll get confused and drop the contents of the big buffer. (KWQTextDecoder::convert): Improve the debugging code a bit (still turned off).

Sep 16, 2003:

5:25 PM Changeset in webkit [5000]
  • 1 copy
    3 deletes in tags/WebKit-106

This commit was manufactured by cvs2svn to create tag 'WebKit-106'.

5:25 PM Changeset in webkit [4999] by vicki
  • 1 edit in trunk/WebKit/ChangeLog

markers for WebKit-106, and updated release notes for Safari-100

3:59 PM Changeset in webkit [4998] by rjw
  • 2 edits in trunk/WebKit

Backed out fix to 3412062 to resolve 3424197.

Many sites use a technique of posting forms the same URL to generate content server side. The fix to 3412062 broke those sites.

Reviewed by Darin.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):

Sep 15, 2003:

5:20 PM Changeset in webkit [4997]
  • 1 copy
    3 deletes in tags/WebKit-105

This commit was manufactured by cvs2svn to create tag 'WebKit-105'.

5:20 PM Changeset in webkit [4996]
  • 3 copies
    2 deletes in branches/WebCore-105-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-105-branch'.

5:20 PM Changeset in webkit [4995]
  • 3 copies
    2 deletes in tags/WebCore-105-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-105-anchor'.

5:20 PM Changeset in webkit [4994]
  • 3 copies
    2 deletes in tags/WebCore-105

This commit was manufactured by cvs2svn to create tag 'WebCore-105'.

5:20 PM Changeset in webkit [4993] by vicki
  • 3 edits in trunk

updated Release Notes for the never-ending Safari-100; markers for WebKit/WebCore-105

3:32 PM Changeset in webkit [4992] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin and Don.

  • fixed 3419957 -- REGRESSION: lines drawn across multiple columns at washingtonpost.com
  • khtml/rendering/render_box.cpp: (RenderBox::calcWidth): Always use the width of the line rather than the width of the containing block for "flow around floats" blocks (<hr>). This undoes half of the change made to fix bug 3384609.
10:23 AM Changeset in webkit [4991] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken and Don.

  • fixed 3417604 -- REGRESSION: dragging scroll thumb causes textarea contents to vanish
  • kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Deallocated cached graphics state for the text view as well as for the clip view.
8:44 AM Changeset in webkit [4990]
  • 5 copies
    2 deletes in tags/WebCore-104

This commit was manufactured by cvs2svn to create tag 'WebCore-104'.

8:44 AM Changeset in webkit [4989] by vicki
  • 2 edits in trunk/WebCore

marker for WebCore-104

Sep 14, 2003:

9:58 PM Changeset in webkit [4988]
  • 1 copy
    3 deletes in tags/WebKit-104

This commit was manufactured by cvs2svn to create tag 'WebKit-104'.

9:58 PM Changeset in webkit [4987] by vicki
  • 1 edit in trunk/WebKit/ChangeLog

marker for WebKit-104

Note: See TracTimeline for information about the timeline view.