Context Navigation

khtml/ecma/kjs_binding.cpp: (DOMObject::get): Put "code" in the error object. (DOMObject::put): Put "code" in the error object. (DOMFunction::get): Put "code" in the error object.

khtml/ecma/kjs_dom.cpp: (DOMCharacterDataProtoFunc::tryCall): Add checks for negative count values. Not clear whether this change is really great, but it helps us pass W3C DOM tests and clearly won't affect normal pages in any bad way.

khtml/xml/dom_elementimpl.cpp: (AttrImpl::AttrImpl): Set m_specified to true. Since we never set up the attributes from the DTD anyway, this is fine for now. If we ever go crazy and implement that, then the bit field is sitting here waiting for us. (NamedAttrMapImpl::removeNamedItem): The comment from KHTML says they don't raise the not found exception because "the DOM 2 spec doesn't say you should". But the DOM Level 1 specification clearly does, and the W3C DOM Level 1 Core test requires it, so I'm putting it in.

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Typo; this was returning the wrong error code in the "wrong document" case.

khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::remove): Fix overflow case. (DOMStringImpl::substring): Fix overflow case.

4:28 PM Changeset in webkit [5010] by hyatt

1 edit in trunk/WebCore/kwq/KWQRenderTreeDebug.cpp

Fix build error.

3:54 PM Changeset in webkit [5009] by hyatt

24 edits in trunk/WebCore

Fix for 3401409, fix negative z-index. This code actually substantially
reworks layers to be more efficient in both painting and event handling.
It also fixes bugs with clipping as well as with negative z-indices.

Reviewed by kocienda

khtml/css/cssstyleselector.cpp:
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::repaintRectangle):
khtml/rendering/render_box.h:
khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint):
khtml/rendering/render_frames.h:
khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
khtml/rendering/render_image.h:
khtml/rendering/render_inline.cpp: (RenderInline::nodeAtPoint):
khtml/rendering/render_inline.h:
khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPosition): (RenderLayer::stackingContext): (RenderLayer::enclosingPositionedAncestor): (RenderLayer::transparentAncestor): (RenderLayer::addChild): (RenderLayer::removeChild): (RenderLayer::convertToLayerCoords): (RenderLayer::checkScrollbarsAfterLayout): (RenderLayer::paintScrollbars): (RenderLayer::paint): (setClip): (restoreClip): (RenderLayer::paintLayer): (RenderLayer::nodeAtPoint): (RenderLayer::nodeAtPointForLayer): (RenderLayer::calculateClipRects): (RenderLayer::calculateRects): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint): (hoverAncestor): (commonAncestor): (RenderLayer::updateHoverActiveState): (sortByZOrder): (RenderLayer::dirtyZOrderLists): (RenderLayer::updateZOrderLists): (RenderLayer::collectLayers):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::document): (RenderObject::renderArena): (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h:
khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
khtml/rendering/render_text.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::recalcStyleSelector): (DocumentImpl::setHoverNode):
khtml/xml/dom_docimpl.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::paintSelectionOnly): (KWQKHTMLPart::adjustPageHeight):
kwq/KWQRect.h:
kwq/KWQRenderTreeDebug.cpp: (write): (writeLayers): (externalRepresentation):

3:16 PM Changeset in webkit [5008] by darin

6 edits in trunk

Reviewed by Dave.

layout-tests: Updated for my mini-controls change.

2:46 PM Changeset in webkit [5007] by darin

16 edits in trunk

WebCore:

Reviewed by Dave.

do the prep work for the mini controls feature; Dave will finish this

khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement): Tell the widget about the font size. Our widgets use the font size to decide whether to use Aqua normal, small, or mini.

kwq/KWQButton.h: Add setFont.
kwq/KWQButton.mm: (QButton::setFont): Set control size based on font. (KWQNSControlSizeForFont): Determine control size given a font. Dave is going to tweak this later.

kwq/KWQCheckBox.h: Add dimensions function for metrics for each control size.
kwq/KWQCheckBox.mm: (QCheckBox::sizeHint): Use dimensions. (QCheckBox::frameGeometry): Use dimensions. (QCheckBox::setFrameGeometry): Use dimensions. (QCheckBox::baselinePosition): Use dimensions. (QCheckBox::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

kwq/KWQComboBox.h: Add setFont and dimensions.
kwq/KWQComboBox.mm: (QComboBox::sizeHint): Use dimensions. (QComboBox::frameGeometry): Use dimensions. (QComboBox::setFrameGeometry): Use dimensions. (QComboBox::baselinePosition): Use dimensions. (QComboBox::setFont): Use dimensions. (QComboBox::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

kwq/KWQFileButton.mm: (KWQFileButton::baselinePosition): Change to adapt to flipped version of file button NSControl.

kwq/KWQPushButton.h: Add dimensions function for metrics for each control size.
kwq/KWQPushButton.mm: (QPushButton::sizeHint): Use dimensions. (QPushButton::frameGeometry): Use dimensions. (QPushButton::setFrameGeometry): Use dimensions. (QPushButton::baselinePosition): Use dimensions. (QPushButton::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

kwq/KWQRadioButton.h: Add dimensions function for metrics for each control size.
kwq/KWQRadioButton.mm: (QRadioButton::sizeHint): Use dimensions. (QRadioButton::frameGeometry): Use dimensions. (QRadioButton::setFrameGeometry): Use dimensions. (QRadioButton::baselinePosition): Use dimensions. (QRadioButton::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

WebKit:

Reviewed by Dave.

do the prep work for the mini controls feature; Dave will finish this

WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton isFlipped]): Make this flipped, easier to understand coordinates that way. (-[WebFileButton drawRect:]): Update for flipped-ness. (-[WebFileButton visualFrame]): Update for flipped-ness. (-[WebFileButton setVisualFrame:]): Update for flipped-ness. (-[WebFileButton baseline]): Update for flipped-ness.

1:46 PM Changeset in webkit [5006] by mjs

9 edits in trunk

WebCore:

Reviewed by Darin.

fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Remove redundant check removed.
khtml/khtml_part.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleHistoryNavigation): Only call the base class method to actually schedule when it's possible to go back or forward that number of steps.
kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge backOrForwardItemWithDistance:]): Factored out from goBackOrForward. (-[WebBridge canGoBackOrForward:]): Use the new method. (-[WebBridge goBackOrForward:]): Likewise.

Sep 18, 2003:

2:56 PM Changeset in webkit [5005] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

kjs/date_object.cpp: Removed our CF-based implementations of gmtime, localtime, mktime, timegm, and time, since they no longer have the slow "hit the filesystem every time" behavior.

8:26 AM Changeset in webkit [5004] by sullivan

14 edits in trunk

WebCore:

WebCore part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

kwq/KWQKHTMLSettings.h: add _shouldPrintBackgrounds field and accessors

kwq/WebCoreSettings.h: add shouldPrintBackgrounds field and accessors
kwq/WebCoreSettings.mm: (-[WebCoreSettings setShouldPrintBackgrounds:]): new method, passes value to KHTMLSettings (-[WebCoreSettings shouldPrintBackgrounds]): new method

kwq/WebCoreBridge.mm: (-[WebCoreBridge styleSheetForPrinting]): new method, returns a style sheet that has backgrounds turned off if preference is set that way. (-[WebCoreBridge reapplyStylesForDeviceType:]): if printing, set the printStyleSheet to the one we created based on the preferences. (KHTML has always had support for a special printStyleSheet, but it was only being used in !APPLE_CHANGES code.)

khtml/rendering/render_style.h: add shouldCorrectTextColor boolean field and accessors

khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): tell style to correct text colors if backgrounds aren't being printed

khtml/rendering/render_text.cpp: (TextRun::paintSelection): added comment (simpleDifferenceBetweenColors): new function, computes a quick measure of difference between colors (correctedTextColor): if text and background colors are too similar, returns lightened or darkened text color (RenderText::paintObject): if style says to correct text colors, call correctedTextColor

WebKit:

WebKit part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

WebView.subproj/WebPreferences.h: new accessor methods for new shouldPrintBackgrounds preference
WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): set initial value for WebKitShouldPrintBackgroundsPreferenceKey to NO (-[WebPreferences shouldPrintBackgrounds]): new method, read NSUserDefaults value (-[WebPreferences setShouldPrintBackgrounds:]): new method, write NSUserDefault value

WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): tell WebCore about value of shouldPrintBackgrounds

English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes

WebBrowser:

WebBrowser part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

English.lproj/PrintingAccessoryView.nib: new nib file, contains view holding single "Print Backgrounds" checkbox

PrintingAccessoryViewController.h: Added.
PrintingAccessoryViewController.m: Added. (-[PrintingAccessoryViewController init]): load the nib file with self as owner (+[PrintingAccessoryViewController sharedController]): returns shared instance used by BrowserDocument (-[PrintingAccessoryViewController togglePrintBackgrounds:]): toggle the WebKit preference (which in turn updates the WebCore setting) (-[PrintingAccessoryViewController accessoryView]): returns the view from the nib that will be displayed in the print panel, after updating the checkbox state

BrowserDocument.m: (-[BrowserDocument printWebFrameView:showingPrintPanel:]): Set up print panel's accessory view

Preferences.subproj/AppearancePreferences.m: removed unused method I stumbled across

WebBrowser.pbproj/project.pbxproj: updated for new files

English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

Sep 17, 2003:

5:08 PM Changeset in webkit [5003] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Pass the "no UI" flag, so we don't prompt the user when we're trying to load plug-ins. Also use OSStatus rather than OSErr so we don't miss error codes that just happen to have zeroes in the low 16 bits.

5:05 PM Changeset in webkit [5002] by darin

2 edits in trunk/WebKit

Reviewed by John.

WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton setFilename:]): Don't call -[NSWorkspace iconForFile:] on a path that does not start with a '/'. This can happen if JavaScript or the web page sets the path explicitly, and adding this check avoids an unpleasant warning on the console.

2:51 PM Changeset in webkit [5001] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed 3423404 -- REGRESSION: Japanese page appears blank due to unexpected kTECPartialCharErr

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): In the case where we're already going from the small buffer back to the large one, treat kTECPartialCharErr the same as noErr. Otherwise we'll get confused and drop the contents of the big buffer. (KWQTextDecoder::convert): Improve the debugging code a bit (still turned off).

Sep 16, 2003:

5:25 PM Changeset in webkit [5000]

1 copy
3 deletes in tags/WebKit-106

This commit was manufactured by cvs2svn to create tag 'WebKit-106'.

5:25 PM Changeset in webkit [4999] by vicki

1 edit in trunk/WebKit/ChangeLog

markers for WebKit-106, and updated release notes for Safari-100

3:59 PM Changeset in webkit [4998] by rjw

2 edits in trunk/WebKit

Backed out fix to 3412062 to resolve 3424197.

Many sites use a technique of posting forms the same URL to generate content server side. The fix to 3412062 broke those sites.

Reviewed by Darin.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):

Sep 15, 2003:

5:20 PM Changeset in webkit [4997]

1 copy
3 deletes in tags/WebKit-105

This commit was manufactured by cvs2svn to create tag 'WebKit-105'.

5:20 PM Changeset in webkit [4996]

3 copies
2 deletes in branches/WebCore-105-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-105-branch'.

5:20 PM Changeset in webkit [4995]

3 copies
2 deletes in tags/WebCore-105-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-105-anchor'.

5:20 PM Changeset in webkit [4994]

3 copies
2 deletes in tags/WebCore-105

This commit was manufactured by cvs2svn to create tag 'WebCore-105'.

5:20 PM Changeset in webkit [4993] by vicki

3 edits in trunk

updated Release Notes for the never-ending Safari-100; markers for WebKit/WebCore-105

3:32 PM Changeset in webkit [4992] by darin

3 edits in trunk/WebCore

Reviewed by Darin and Don.

fixed 3419957 -- REGRESSION: lines drawn across multiple columns at washingtonpost.com

khtml/rendering/render_box.cpp: (RenderBox::calcWidth): Always use the width of the line rather than the width of the containing block for "flow around floats" blocks (<hr>). This undoes half of the change made to fix bug 3384609.

10:23 AM Changeset in webkit [4991] by darin

3 edits in trunk/WebCore

Reviewed by Ken and Don.

fixed 3417604 -- REGRESSION: dragging scroll thumb causes textarea contents to vanish

kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Deallocated cached graphics state for the text view as well as for the clip view.

8:44 AM Changeset in webkit [4990]

5 copies
2 deletes in tags/WebCore-104

This commit was manufactured by cvs2svn to create tag 'WebCore-104'.

8:44 AM Changeset in webkit [4989] by vicki

2 edits in trunk/WebCore

marker for WebCore-104

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed