Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 21, 2003:

7:27 PM Changeset in webkit [5027] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView removeTrackingRect:]): Remove bogus assert.

5:33 PM Changeset in webkit [5026] by darin

• 12 edits in trunk

WebCore:

Reviewed by Dave.

• fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Set the value of a new element dictionary key, WebCoreElementTitleKey. This gives the title for an element, walking up the DOM tree as necessary to find it. It's used for tool tips at the WebKit level.
• kwq/WebCoreBridge.h: Added WebCoreElementTitleKey and WebCorePageCacheStateKey.

• WebCore.exp: Added all the constants from WebCoreBridge.h; these should be exported even though they are not being used at the moment because the "WebCore and WebKit use the same constant keys" hack we are doing at the WebKit level means we can just use the WebKit keys on the WebKit side.
• WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Dave.

• fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

• WebView.subproj/WebHTMLViewPrivate.h: Added fields needed for tool tip implementation.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the tool tip string. (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): Override the default NSView tracking rectangle implementation so we can trick the tool tip manager into trusting us about when you leave and enter the rectangle for each element. (-[WebHTMLView removeTrackingRect:]): The other half of the above stuff. (-[WebHTMLView _sendToolTipMouseExited]): Added. Makes an event just good enough to fool the tool tip manager, and send it on. (-[WebHTMLView _sendToolTipMouseEntered]): Ditto. (-[WebHTMLView _setToolTip:]): Added. Manages the new and old tool tips in a way that fools the tool tip manager into working even though we don't know the rectangles of the tool tips beforehand. The advantage of using AppKit tool tips is that they have all sorts of nice little features, like wrapping to a nice rectangular shape and fading out when you move away. (-[WebHTMLView view:stringForToolTip:point:userData:]): This is how the tool tip manager gets the actual tool tip text. (-[WebHTMLView _updateMouseoverWithEvent:]): Call _setToolTip method, using the value passed along with the WebCoreElementTitleKey in the dictionary.

• unrelated code cleanup

• WebView.subproj/WebFramePrivate.h: Don't define WebCorePageCacheStateKey here; instead use a definition exported from WebCore.
• WebView.subproj/WebFramePrivate.m: Ditto.
• English.lproj/StringsNotToBeLocalized.txt: Update for above changes.

Sep 20, 2003:

9:00 PM Changeset in webkit [5025] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

• fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)

• kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction in here was incorrect. Perhaps I should have corrected it for the non-BSD case too, but I'm not sure the issue is the same.

8:59 PM Changeset in webkit [5024] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3328481 -- selection in select element list box does not scroll into view when set programatically

• kwq/KWQListBox.mm: (QListBox::setSelected): Scroll newly-selected item into view.

8:55 PM Changeset in webkit [5023] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3429384 -- REGRESSION (89-90): nil-deref in KHTMLPart::write() (cheshiremotorcyclesalvage.com)

• khtml/khtml_part.cpp: (KHTMLPart::write): Add a nil check.

8:53 PM Changeset in webkit [5022] by darin

• 7 edits in trunk/WebCore

Reviewed by Dave.

• more fixes for the W3C DOM tests

• khtml/dom/dom_doc.cpp: (Document::createAttributeNS): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not.

• khtml/dom/dom_element.cpp: (Element::removeAttributeNode): Get the attribute name properly. The old code would always get a 0, so this function would always fail. (Element::setAttributeNS): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not. (Element::setAttributeNodeNS): Remove redundant exception checks that are also done by setNamedItem in the implementation. I had to change the implementation of one, so I decided it was better not to have any duplication.

• khtml/xml/dom_docimpl.h: Added isValidName function.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not. (DocumentImpl::isValidName): Added. Used to check for valid names.

• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem): Don't do the document check until after checking for the "replace self" case. Otherwise we raise a spurious "in use" exception. (NamedAttrMapImpl::addAttribute): Point the new attribute at the element.

Sep 19, 2003:

6:41 PM Changeset in webkit [5021]

• 6 copies
  2 deletes in branches/WebCore-106-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-106-tarball-branch'.

6:41 PM Changeset in webkit [5020]

• 6 copies
  2 deletes in tags/WebCore-106

This commit was manufactured by cvs2svn to create tag 'WebCore-106'.

6:41 PM Changeset in webkit [5019]

• 7 copies in branches/Safari-1-1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-1-1-branch'.

6:41 PM Changeset in webkit [5018]

• 7 copies in tags/Safari-1-1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-1-anchor'.

6:41 PM Changeset in webkit [5017]

• 6 copies
  1 delete in branches/SUPanBisque-branch

This commit was manufactured by cvs2svn to create branch
'SUPanBisque-branch'.

6:41 PM Changeset in webkit [5016]

• 6 copies
  1 delete in tags/SUPanBisque-anchor

This commit was manufactured by cvs2svn to create tag
'SUPanBisque-anchor'.

6:41 PM Changeset in webkit [5015]

• 7 copies in tags/MacOSX_10_3

This commit was manufactured by cvs2svn to create tag 'MacOSX_10_3'.

6:41 PM Changeset in webkit [5014] by vicki

• 2 edits in branches/WebCore-105-branch/WebCore

release markers for WebCore-106

6:30 PM Changeset in webkit [5013] by mjs

• 3 edits in branches/WebCore-105-branch/WebCore

Reviewed by Darin.

• fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Don't do paint suppression for history redirects.

6:22 PM Changeset in webkit [5012] by mjs

• 8 edits in trunk

WebCore:

Reviewed by Darin.

Roll out old fix for 3410980 and do a new better fix.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
• khtml/khtml_part.h:
• kwq/KWQKHTMLPart.mm:
• kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

Roll out old fix for 3410980.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge goBackOrForward:]):

4:55 PM Changeset in webkit [5011] by darin

• 10 edits in trunk

Reviewed by Dave.

• update layout tests for Dave's change

• layout-tests/apple-only/base/www.excite.com/index-expected.txt:
• layout-tests/fast/block/positioning/051-expected.txt:
• layout-tests/fast/overflow/003-expected.txt:

• fixed 3426272 -- sites that use text-shadow cause leaks (QPainter::setShadow)

• kwq/KWQPainter.mm: (QPainter::setShadow): Release the color space and color.

• fixed some errors that caused failures in the W3C DOM suite

• khtml/ecma/kjs_binding.cpp: (DOMObject::get): Put "code" in the error object. (DOMObject::put): Put "code" in the error object. (DOMFunction::get): Put "code" in the error object.

• khtml/ecma/kjs_dom.cpp: (DOMCharacterDataProtoFunc::tryCall): Add checks for negative count values. Not clear whether this change is really great, but it helps us pass W3C DOM tests and clearly won't affect normal pages in any bad way.

• khtml/xml/dom_elementimpl.cpp: (AttrImpl::AttrImpl): Set m_specified to true. Since we never set up the attributes from the DTD anyway, this is fine for now. If we ever go crazy and implement that, then the bit field is sitting here waiting for us. (NamedAttrMapImpl::removeNamedItem): The comment from KHTML says they don't raise the not found exception because "the DOM 2 spec doesn't say you should". But the DOM Level 1 specification clearly does, and the W3C DOM Level 1 Core test requires it, so I'm putting it in.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Typo; this was returning the wrong error code in the "wrong document" case.

• khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::remove): Fix overflow case. (DOMStringImpl::substring): Fix overflow case.

4:28 PM Changeset in webkit [5010] by hyatt

• 1 edit in trunk/WebCore/kwq/KWQRenderTreeDebug.cpp

Fix build error.

3:54 PM Changeset in webkit [5009] by hyatt

• 24 edits in trunk/WebCore

Fix for 3401409, fix negative z-index. This code actually substantially
reworks layers to be more efficient in both painting and event handling.
It also fixes bugs with clipping as well as with negative z-indices.

Reviewed by kocienda

• khtml/css/cssstyleselector.cpp:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::repaintRectangle):
• khtml/rendering/render_box.h:
• khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint):
• khtml/rendering/render_frames.h:
• khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
• khtml/rendering/render_image.h:
• khtml/rendering/render_inline.cpp: (RenderInline::nodeAtPoint):
• khtml/rendering/render_inline.h:
• khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPosition): (RenderLayer::stackingContext): (RenderLayer::enclosingPositionedAncestor): (RenderLayer::transparentAncestor): (RenderLayer::addChild): (RenderLayer::removeChild): (RenderLayer::convertToLayerCoords): (RenderLayer::checkScrollbarsAfterLayout): (RenderLayer::paintScrollbars): (RenderLayer::paint): (setClip): (restoreClip): (RenderLayer::paintLayer): (RenderLayer::nodeAtPoint): (RenderLayer::nodeAtPointForLayer): (RenderLayer::calculateClipRects): (RenderLayer::calculateRects): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint): (hoverAncestor): (commonAncestor): (RenderLayer::updateHoverActiveState): (sortByZOrder): (RenderLayer::dirtyZOrderLists): (RenderLayer::updateZOrderLists): (RenderLayer::collectLayers):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::document): (RenderObject::renderArena): (RenderObject::nodeAtPoint):
• khtml/rendering/render_object.h:
• khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
• khtml/rendering/render_text.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::recalcStyleSelector): (DocumentImpl::setHoverNode):
• khtml/xml/dom_docimpl.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::paintSelectionOnly): (KWQKHTMLPart::adjustPageHeight):
• kwq/KWQRect.h:
• kwq/KWQRenderTreeDebug.cpp: (write): (writeLayers): (externalRepresentation):

3:16 PM Changeset in webkit [5008] by darin

• 6 edits in trunk

Reviewed by Dave.

• layout-tests: Updated for my mini-controls change.

2:46 PM Changeset in webkit [5007] by darin

• 16 edits in trunk

WebCore:

Reviewed by Dave.

• do the prep work for the mini controls feature; Dave will finish this

• khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement): Tell the widget about the font size. Our widgets use the font size to decide whether to use Aqua normal, small, or mini.

• kwq/KWQButton.h: Add setFont.
• kwq/KWQButton.mm: (QButton::setFont): Set control size based on font. (KWQNSControlSizeForFont): Determine control size given a font. Dave is going to tweak this later.

• kwq/KWQCheckBox.h: Add dimensions function for metrics for each control size.
• kwq/KWQCheckBox.mm: (QCheckBox::sizeHint): Use dimensions. (QCheckBox::frameGeometry): Use dimensions. (QCheckBox::setFrameGeometry): Use dimensions. (QCheckBox::baselinePosition): Use dimensions. (QCheckBox::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

• kwq/KWQComboBox.h: Add setFont and dimensions.
• kwq/KWQComboBox.mm: (QComboBox::sizeHint): Use dimensions. (QComboBox::frameGeometry): Use dimensions. (QComboBox::setFrameGeometry): Use dimensions. (QComboBox::baselinePosition): Use dimensions. (QComboBox::setFont): Use dimensions. (QComboBox::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

• kwq/KWQFileButton.mm: (KWQFileButton::baselinePosition): Change to adapt to flipped version of file button NSControl.

• kwq/KWQPushButton.h: Add dimensions function for metrics for each control size.
• kwq/KWQPushButton.mm: (QPushButton::sizeHint): Use dimensions. (QPushButton::frameGeometry): Use dimensions. (QPushButton::setFrameGeometry): Use dimensions. (QPushButton::baselinePosition): Use dimensions. (QPushButton::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

• kwq/KWQRadioButton.h: Add dimensions function for metrics for each control size.
• kwq/KWQRadioButton.mm: (QRadioButton::sizeHint): Use dimensions. (QRadioButton::frameGeometry): Use dimensions. (QRadioButton::setFrameGeometry): Use dimensions. (QRadioButton::baselinePosition): Use dimensions. (QRadioButton::dimensions): Added. Has newly tweaked values for all dimensions for all three control sizes.

WebKit:

Reviewed by Dave.

• do the prep work for the mini controls feature; Dave will finish this

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton isFlipped]): Make this flipped, easier to understand coordinates that way. (-[WebFileButton drawRect:]): Update for flipped-ness. (-[WebFileButton visualFrame]): Update for flipped-ness. (-[WebFileButton setVisualFrame:]): Update for flipped-ness. (-[WebFileButton baseline]): Update for flipped-ness.

1:46 PM Changeset in webkit [5006] by mjs

• 9 edits in trunk

WebCore:

Reviewed by Darin.

• fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Remove redundant check removed.
• khtml/khtml_part.h:
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleHistoryNavigation): Only call the base class method to actually schedule when it's possible to go back or forward that number of steps.
• kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

• fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge backOrForwardItemWithDistance:]): Factored out from goBackOrForward. (-[WebBridge canGoBackOrForward:]): Use the new method. (-[WebBridge goBackOrForward:]): Likewise.

Sep 18, 2003:

2:56 PM Changeset in webkit [5005] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• kjs/date_object.cpp: Removed our CF-based implementations of gmtime, localtime, mktime, timegm, and time, since they no longer have the slow "hit the filesystem every time" behavior.

8:26 AM Changeset in webkit [5004] by sullivan

• 14 edits in trunk

WebCore:

• WebCore part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

• kwq/KWQKHTMLSettings.h: add _shouldPrintBackgrounds field and accessors

• kwq/WebCoreSettings.h: add shouldPrintBackgrounds field and accessors
• kwq/WebCoreSettings.mm: (-[WebCoreSettings setShouldPrintBackgrounds:]): new method, passes value to KHTMLSettings (-[WebCoreSettings shouldPrintBackgrounds]): new method

• kwq/WebCoreBridge.mm: (-[WebCoreBridge styleSheetForPrinting]): new method, returns a style sheet that has backgrounds turned off if preference is set that way. (-[WebCoreBridge reapplyStylesForDeviceType:]): if printing, set the printStyleSheet to the one we created based on the preferences. (KHTML has always had support for a special printStyleSheet, but it was only being used in !APPLE_CHANGES code.)

• khtml/rendering/render_style.h: add shouldCorrectTextColor boolean field and accessors

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): tell style to correct text colors if backgrounds aren't being printed

• khtml/rendering/render_text.cpp: (TextRun::paintSelection): added comment (simpleDifferenceBetweenColors): new function, computes a quick measure of difference between colors (correctedTextColor): if text and background colors are too similar, returns lightened or darkened text color (RenderText::paintObject): if style says to correct text colors, call correctedTextColor

WebKit:

• WebKit part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

• WebView.subproj/WebPreferences.h: new accessor methods for new shouldPrintBackgrounds preference
• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): set initial value for WebKitShouldPrintBackgroundsPreferenceKey to NO (-[WebPreferences shouldPrintBackgrounds]): new method, read NSUserDefaults value (-[WebPreferences setShouldPrintBackgrounds:]): new method, write NSUserDefault value

• WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): tell WebCore about value of shouldPrintBackgrounds

• English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes

WebBrowser:

• WebBrowser part of fix for 3157018 -- Would like option to not print backgrounds

Reviewed by Darin

• English.lproj/PrintingAccessoryView.nib: new nib file, contains view holding single "Print Backgrounds" checkbox

• PrintingAccessoryViewController.h: Added.
• PrintingAccessoryViewController.m: Added. (-[PrintingAccessoryViewController init]): load the nib file with self as owner (+[PrintingAccessoryViewController sharedController]): returns shared instance used by BrowserDocument (-[PrintingAccessoryViewController togglePrintBackgrounds:]): toggle the WebKit preference (which in turn updates the WebCore setting) (-[PrintingAccessoryViewController accessoryView]): returns the view from the nib that will be displayed in the print panel, after updating the checkbox state

• BrowserDocument.m: (-[BrowserDocument printWebFrameView:showingPrintPanel:]): Set up print panel's accessory view

• Preferences.subproj/AppearancePreferences.m: removed unused method I stumbled across

• WebBrowser.pbproj/project.pbxproj: updated for new files

• English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

Sep 17, 2003:

5:08 PM Changeset in webkit [5003] by darin

• 2 edits in trunk/WebKit

Reviewed by Maciej.

• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Pass the "no UI" flag, so we don't prompt the user when we're trying to load plug-ins. Also use OSStatus rather than OSErr so we don't miss error codes that just happen to have zeroes in the low 16 bits.

5:05 PM Changeset in webkit [5002] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton setFilename:]): Don't call -[NSWorkspace iconForFile:] on a path that does not start with a '/'. This can happen if JavaScript or the web page sets the path explicitly, and adding this check avoids an unpleasant warning on the console.

2:51 PM Changeset in webkit [5001] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3423404 -- REGRESSION: Japanese page appears blank due to unexpected kTECPartialCharErr

• kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): In the case where we're already going from the small buffer back to the large one, treat kTECPartialCharErr the same as noErr. Otherwise we'll get confused and drop the contents of the big buffer. (KWQTextDecoder::convert): Improve the debugging code a bit (still turned off).