Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 24, 2003:

11:36 PM Changeset in webkit [5054] by darin

• 3 edits in trunk

• layout-tests/fast/table/003-expected.txt: Updated for textarea width change.

9:34 PM Changeset in webkit [5053] by darin

• 1 edit in trunk/WebKit/ChangeLog

Added marker now that the change was reviewed by Maciej.

9:28 PM Changeset in webkit [5052] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Added one more call to _stopAutoscrollTimer for when drags begin.

5:47 PM Changeset in webkit [5051] by hyatt

• 2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

5:44 PM Changeset in webkit [5050] by hyatt

• 31 adds in trunk/LayoutTests/fast/clip

Adding clipping tests.

5:37 PM Changeset in webkit [5049] by hyatt

• 4 edits in trunk/WebCore

Fix for 3429646, <img src="blah"<img src="foo"> should show up as two images.

Reviewed by darin

• khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

5:09 PM Changeset in webkit [5048] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed a recent regression, and ...
• fixed 3386544 -- ARCH: <object>s don't support transclusion like <iframe>s do

• khtml/khtml_part.cpp: (KHTMLPart::childFrame): Added back a cast I should not have removed to fix the function.

5:00 PM Changeset in webkit [5047] by hyatt

• 3 edits in trunk/WebCore

Fix for 3430612, crash on about:blank in updateHoverActiveState. Just missing
a null-check. Also remove a hover optimization that was bogus.

Reviewed by darin

• khtml/rendering/render_layer.cpp: (RenderLayer::updateHoverActiveState):

4:05 PM Changeset in webkit [5046] by rjw

• 12 edits in trunk

WebKit:

Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906. Also 3428451 needs to should be resolved.

Also added code to get and log entry point for the function used to get a Java class from plugins. That class is used for LiveConnect support.

Reviewed by John.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
• Plugins.subproj/npapi.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (FillStyleWithAttributes):
• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): (fontsChanged): (+[WebTextRendererFactory createSharedFactory]): (-[WebTextRendererFactory fontWithFamily:traits:size:]): (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):

WebCore:

Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (+[WebCoreBridge updateAllViews]):

9:37 AM Changeset in webkit [5045] by darin

• 2 edits
  2 adds in trunk

• a new test for JavaScript date parsing

• layout-tests/fast/js/date-parse-test-expected.txt: Added.
• layout-tests/fast/js/date-parse-test.html: Added.

9:37 AM Changeset in webkit [5044] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed 3421107 -- some dates that other browsers can parse can't be parsed by KJS's Date.parse()

• kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Added code to be more strict about month names, to allow a time zone after date even if the date omits the time, and to understand AM and PM.

8:55 AM Changeset in webkit [5043] by darin

• 7 edits in trunk/WebCore

Reviewed by Ken.

• fixed ownerElement for documents in HTML objects (helpful for some work Dave is doing)

• khtml/khtml_part.h: Change name of frame function to childFrame for clarity.
• khtml/khtml_part.cpp: (KHTMLPart::slotChildStarted): Call the frame function by its new name, childFrame. (KHTMLPart::slotChildCompleted): Ditto. (KHTMLPart::slotChildURLRequest): Ditto. (KHTMLPart::childFrame): Change name from frame to childFrame for clarity, and make it work for parts inside HTML objects, not just normal frames and iframes. The change in behavior is the actual fix. Note that for the three callers above, it's an error to call this when the result would be 0, so there's no harm in doing the extra search of HTML objects in those cases.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement): Call the frame function by its new name, childFrame. This is the caller that will benefit most from the change in behavior.

• kwq/KWQKHTMLPart.h: Remove childFrameForPart function, which is superseded by the childFrame function now.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Use childFrame instead of childFrameForPart.

Sep 23, 2003:

9:52 PM Changeset in webkit [5042] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3390850 -- Shift_JIS in meta tag ignored because <img> tag in JavaScript comes first (vintagecomp.com)

• khtml/misc/decoder.cpp: (Decoder::decode): Don't let tags inside a script make us think we're in the body. Later we can enhance this even more.

4:45 PM Changeset in webkit [5041] by darin

• 1 edit in trunk/WebKit/ChangeLog

Update bug number to 3127833 -- autoscroll only works when mouse is moving.

4:19 PM Changeset in webkit [5040] by darin

• 4 edits in trunk/WebKit

Reviewed by John and Richard.

• fixed 3367377 -- autoscroll only works when mouse is moving

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewDidMoveToWindow]): Stop the auto-scroll timer. This covers the case where a view is removed from the view hierarchy while the mouse is down. (-[WebHTMLView mouseDown:]): Start the auto-scroll timer. (-[WebHTMLView mouseUp:]): Stop the auto-scroll timer.
• WebView.subproj/WebHTMLViewPrivate.h: Add an auto-scroll timer, and methods to start and stop it.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _startAutoscrollTimer]): Create and schedule a timer. It uses the same 1/10 second interval that NSTextView uses for its scrolling timer. (-[WebHTMLView _stopAutoscrollTimer]): Invalidate and release the timer. (-[WebHTMLView _autoscroll]): Check for a mouse up event in the queue; if one is there, then no autoscrlling. But if not, then create a fake mouse dragged event and dispatch it; that will lead to autoscrolling.

7:47 AM Changeset in webkit [5039] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3292723 -- onBlur() getting called twice on <input type=text>

• khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter): Call setFocusNode(0) instead of explicitly sending a blur event, otherwise setFocusNode will send a second blur event later.

Sep 22, 2003:

11:34 PM Changeset in webkit [5038] by darin

• 1 edit in trunk/LayoutTests/fast/js/global/encode-URI-test.html

Fix minor coding style issue in this test; something was being
computed twice.

11:28 PM Changeset in webkit [5037] by darin

• 1 edit in trunk/WebKit/WebView.subproj/WebHTMLViewPrivate.m

Fix check-in snafu.

11:11 PM Changeset in webkit [5036] by darin

• 2 edits in trunk/WebKit

Reviewed by Dave.

• worked around 3429631 -- window stops getting mouse moved events after first tooltip appears

• WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]): Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

11:09 PM Changeset in webkit [5035] by darin

• 2 edits in trunk/WebKit

Reviewed by Dave.

• worked around 3429631 -- window stops getting mouse moved events after first tooltip appears

• WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]): Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

9:03 PM Changeset in webkit [5034] by darin

• 4 edits in trunk/WebCore

• fixed 3391837 -- we list ISO-8859-8-E as visual ordering for Hebrew; it's "explicit ordering", not supported

• kwq/mac-encodings.txt: Removed ISO-8859-8-E.
• kwq/KWQCharsetData.c: Regenerated.

4:29 PM Changeset in webkit [5033] by darin

• 3 edits in trunk/WebCore

• kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Made it compile.

3:09 PM Changeset in webkit [5032] by darin

• 7 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3306041 -- Airborne tracking number field too narrow, tracking doesn't work (textare col property)

• khtml/rendering/render_form.cpp: (RenderTextArea::calcMinMaxWidth): Call the QTextEdit to ask it what size, rather than trying to compute it. This is the same thing we do with other widgets, I just hadn't done textarea yet.

• kwq/KWQTextEdit.h: Added sizeWithColumnsAndRows function.
• kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Added. Calls through to the KWQTextArea object.

• kwq/KWQTextArea.h: Added sizeWithColumns:rows: method.
• kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Make consistent with other callers of the size mapping methods by using [self class] instead of NSScrollView, and getting hasHorizontalScroller and hasVerticalScroller from the view. (-[KWQTextArea setFrame:]): Make consistent with other callers of the size mapping methods by using [self class] instead of NSScrollView. (-[KWQTextArea sizeWithColumns:rows:]): Added. Starts by computing the width and height of the columns specified, using a canonical width of a "0" character. Then converts that to a container size by adding line fragment padding. Then converts that into the text view size by adding the text container inset. Then converts that into the scroll view size by calling frameSizeForContentSize:.

11:16 AM Changeset in webkit [5031] by darin

• 8 edits in trunk

top level:

• configure.in: Add "OptimizedWithSymbols" build style.

JavaScriptCore:

• JavaScriptCore.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebCore:

• WebCore.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebKit:

• WebKit.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

8:22 AM Changeset in webkit [5030] by darin

• 1 edit in trunk/WebKit/ChangeLog

Tweaked some old ChangeLog entries to get rid of "Reviewed by NOBODY".

8:21 AM Changeset in webkit [5029] by darin

• 6 edits
  1 delete in trunk/WebCore

Reviewed by Ken.

• research determined we were using nothing defined in config.h, so I got rid of it

• Makefile.am: Removed rules to generate config.h.
• config.h: Removed.

• WebCore.pbproj/project.pbxproj: Removed define of HAVE_CONFIG_H.

• WebCorePrefix.h: Removed include of <config.h>.

• ForwardingHeaders/config.h: Emptied this file out. Can't remove this because there are some includes of <config.h> without HAVE_CONFIG_H wrappers.

8:21 AM Changeset in webkit [5028] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

• kjs/config.h: Added HAVE_SYS_PARAM_H, since KJS does look for this header, and we do indeed have it. Just something I noticed in passing while cleaning up configure.in.

Sep 21, 2003:

7:27 PM Changeset in webkit [5027] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView removeTrackingRect:]): Remove bogus assert.

5:33 PM Changeset in webkit [5026] by darin

• 12 edits in trunk

WebCore:

Reviewed by Dave.

• fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Set the value of a new element dictionary key, WebCoreElementTitleKey. This gives the title for an element, walking up the DOM tree as necessary to find it. It's used for tool tips at the WebKit level.
• kwq/WebCoreBridge.h: Added WebCoreElementTitleKey and WebCorePageCacheStateKey.

• WebCore.exp: Added all the constants from WebCoreBridge.h; these should be exported even though they are not being used at the moment because the "WebCore and WebKit use the same constant keys" hack we are doing at the WebKit level means we can just use the WebKit keys on the WebKit side.
• WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Dave.

• fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

• WebView.subproj/WebHTMLViewPrivate.h: Added fields needed for tool tip implementation.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the tool tip string. (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): Override the default NSView tracking rectangle implementation so we can trick the tool tip manager into trusting us about when you leave and enter the rectangle for each element. (-[WebHTMLView removeTrackingRect:]): The other half of the above stuff. (-[WebHTMLView _sendToolTipMouseExited]): Added. Makes an event just good enough to fool the tool tip manager, and send it on. (-[WebHTMLView _sendToolTipMouseEntered]): Ditto. (-[WebHTMLView _setToolTip:]): Added. Manages the new and old tool tips in a way that fools the tool tip manager into working even though we don't know the rectangles of the tool tips beforehand. The advantage of using AppKit tool tips is that they have all sorts of nice little features, like wrapping to a nice rectangular shape and fading out when you move away. (-[WebHTMLView view:stringForToolTip:point:userData:]): This is how the tool tip manager gets the actual tool tip text. (-[WebHTMLView _updateMouseoverWithEvent:]): Call _setToolTip method, using the value passed along with the WebCoreElementTitleKey in the dictionary.

• unrelated code cleanup

• WebView.subproj/WebFramePrivate.h: Don't define WebCorePageCacheStateKey here; instead use a definition exported from WebCore.
• WebView.subproj/WebFramePrivate.m: Ditto.
• English.lproj/StringsNotToBeLocalized.txt: Update for above changes.

Sep 20, 2003:

9:00 PM Changeset in webkit [5025] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

• fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)

• kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction in here was incorrect. Perhaps I should have corrected it for the non-BSD case too, but I'm not sure the issue is the same.

8:59 PM Changeset in webkit [5024] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3328481 -- selection in select element list box does not scroll into view when set programatically

• kwq/KWQListBox.mm: (QListBox::setSelected): Scroll newly-selected item into view.

8:55 PM Changeset in webkit [5023] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3429384 -- REGRESSION (89-90): nil-deref in KHTMLPart::write() (cheshiremotorcyclesalvage.com)

• khtml/khtml_part.cpp: (KHTMLPart::write): Add a nil check.

8:53 PM Changeset in webkit [5022] by darin

• 7 edits in trunk/WebCore

Reviewed by Dave.

• more fixes for the W3C DOM tests

• khtml/dom/dom_doc.cpp: (Document::createAttributeNS): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not.

• khtml/dom/dom_element.cpp: (Element::removeAttributeNode): Get the attribute name properly. The old code would always get a 0, so this function would always fail. (Element::setAttributeNS): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not. (Element::setAttributeNodeNS): Remove redundant exception checks that are also done by setNamedItem in the implementation. I had to change the implementation of one, so I decided it was better not to have any duplication.

• khtml/xml/dom_docimpl.h: Added isValidName function.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Check that the attribute name is valid and throw INVALID_CHARACTER_ERR if not. (DocumentImpl::isValidName): Added. Used to check for valid names.

• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem): Don't do the document check until after checking for the "replace self" case. Otherwise we raise a spurious "in use" exception. (NamedAttrMapImpl::addAttribute): Point the new attribute at the element.