Timeline

Sep 26, 2003:

9:44 AM Changeset in webkit [5073] by kocienda

• 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3435532>: REGRESSION: tabbing to textareas causes infinite recursion

Add recursion guards to the becomeFirstResponder method, otherwise calling
eventFilter with a FocusIn event will cause the infinite recursion
described in the bug.

• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]):

Sep 25, 2003:

9:12 PM Changeset in webkit [5072] by mjs

• 4 edits in trunk/WebCore

Reviewed by John.

• khtml/ecma/kjs_window.cpp: (Window::installTimeout): Variant that takes a function and args. (WindowFunc::tryCall): If the argument is a function, call the function variant of installTimeout instead of pointlessly passing the string. Also, correctly implement the code to pass extra args along.
• khtml/ecma/kjs_window.h:

9:08 PM Changeset in webkit [5071] by mjs

• 9 edits in trunk

Tools:

Roll out build system change since it did not actually work. :-(

• Scripts/SourceTools.pm:
• Scripts/embed-into-alex: Added.
• Scripts/embed-into-webkit: Removed.

JavaScriptCore:

Roll out build system change since it did not actually work. :-(

• JavaScriptCore.pbproj/project.pbxproj:
• Makefile.am:

WebCore:

Roll out build system change since it did not actually work. :-(

• WebCore.pbproj/project.pbxproj:

WebKit:

Roll out build system change since it did not actually work. :-(

• WebKit.pbproj/project.pbxproj:

WebBrowser:

Roll out build system change since it did not actually work. :-(

• WebBrowser.pbproj/project.pbxproj:
• add-environment.sh: Removed.
• embed-frameworks.sh: Added.

6:04 PM Changeset in webkit [5070] by hyatt

• 3 edits in trunk/LayoutTests/fast

Updating the layout tests.

5:58 PM Changeset in webkit [5069] by hyatt

• 3 edits in trunk/WebKit

Change layout so that it is called from the private _recursive functions instead of
inside drawRect.

Reviewed by kocienda

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:adjustingViewSize:]): (-[WebHTMLView drawRect:]):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:testDirtyRect:]): (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSView _web_setPrintingModeRecursive]): (-[NSView _web_clearPrintingModeRecursive]): (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]):

5:57 PM Changeset in webkit [5068] by hyatt

• 28 edits in trunk/WebCore

Landing the new repainting code. This code eliminates many redundant layouts, makes
layout scheduling work properly when called from WebKit, cleans up relpositioned inlines
that act as containing blocks for absolute positioned children, and eliminates the
repaint timer.

Reviewed by kocienda

• ChangeLog:
• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
• khtml/khtmlview.cpp: (KHTMLView::KHTMLView):
• khtml/khtmlview.h:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::setPixmap): (RenderBox::getAbsoluteRepaintRect): (RenderBox::computeAbsoluteRepaintRect): (RenderBox::repaintIfMoved): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteVertical):
• khtml/rendering/render_box.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::layout): (RenderCanvas::repaintViewRectangle): (RenderCanvas::getAbsoluteRepaintRect): (RenderCanvas::computeAbsoluteRepaintRect):
• khtml/rendering/render_canvas.h:
• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode): (RenderContainer::removeChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
• khtml/rendering/render_flexbox.cpp:
• khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
• khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow):
• khtml/rendering/render_layer.cpp: (RenderLayer::convertToLayerCoords):
• khtml/rendering/render_list.cpp: (RenderListMarker::setPixmap):
• khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::setNeedsLayout): (RenderObject::setChildNeedsLayout): (RenderObject::markContainingBlocksForLayout): (RenderObject::containingBlock): (RenderObject::repaint): (RenderObject::repaintRectangle): (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::repaintIfMoved): (RenderObject::repaintPositionedAndFloatingDescendants): (RenderObject::getAbsoluteRepaintRect): (RenderObject::getAbsoluteRepaintRectIncludingDescendants): (RenderObject::computeAbsoluteRepaintRect): (RenderObject::setStyle): (RenderObject::container): (RenderObject::detach): (RenderObject::scheduleRelayout):
• khtml/rendering/render_object.h:
• khtml/rendering/render_style.cpp: (RenderStyle::diff):
• khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableRow::getAbsoluteRepaintRect): (RenderTableCell::computeAbsoluteRepaintRect):
• khtml/rendering/render_table.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::appendChild):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clearTimers):
• kwq/KWQRenderTreeDebug.cpp: (write): (externalRepresentation):
• kwq/KWQRenderTreeDebug.h:

3:42 PM Changeset in webkit [5067] by hyatt

• 1 edit in trunk/LayoutTests/css1/box_properties/float_elements_in_series-expected.txt

Fix the css1 failure, since we now pass the test.

3:31 PM Changeset in webkit [5066] by rjw

• 2 edits in trunk/WebKit

Fixed 3433802. Written by Ed. Carbon WebView doesn't detach native view when removed.

Reviewed by Richard.

• Carbon.subproj/HIWebView.m: (OwningWindowChanged):

3:26 PM Changeset in webkit [5065] by rjw

• 2 edits in trunk/WebKit

Fixed 3433488. Written by Ed. WebKit doesn't sync window visibility when new webview added to visible window.

Reviewed by Richard.

• Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):

3:15 PM Changeset in webkit [5064] by rjw

• 2 edits in trunk/WebKit

Fixed 3434854. Written by Ed. Correctly handle window modality in carbon.

Reviewed by Richard.

• Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):

2003-09-25 Maciej Stachowiak <​mjs@apple.com>

2:09 PM Changeset in webkit [5063] by mjs

• 9 edits
  1 add in trunk

Tools:

Reviewed by Darin.

• Scripts/SourceTools.pm: Don't try to install Foundation on the system any more. The new build setup takes care of it.
• Scripts/embed-into-alex: Removed.
• Scripts/embed-into-webkit: Added.

JavaScriptCore:

Reviewed by Darin.

• JavaScriptCore.pbproj/project.pbxproj: Don't hack install name. Instead of embedding into Safari, embed into WebKit as sub-umbrella.
• Makefile.am: Don't forget to rebuild if the user removes JavaScript.framework from symroots manually.

WebCore:

Reviewed by Darin.

• WebCore.pbproj/project.pbxproj: Don't hack install name. Instead of embedding into Safari, embed into WebKit as sub-umbrella.

WebKit:

Reviewed by Darin.

Updated setup for engineering builds. Don't embed the framework
into Safari or hack the install name. However, do copy WebCore and
JavaScriptCore into the proper sub-umbrella locations.

• WebKit.pbproj/project.pbxproj:
• embed-frameworks.sh: Added.

WebBrowser:

Reviewed by Darin.

Changed things around for the engineering Safari build. Instead of
building frameworks embedded, set DYLD_FRAMEWORK_PATH via the
Info.plist (for engineering builds only). This also removes the
need to install engineering builds of Foundation on the system.

• WebBrowser.pbproj/project.pbxproj:
• add-environment.sh: Added.
• embed-frameworks.sh: Removed.

1:43 PM Changeset in webkit [5062] by vicki

• 3 edits in trunk

The tree is open for Safari-108!

1:40 PM Changeset in webkit [5061]

• 3 copies in tags/Safari-107

This commit was manufactured by cvs2svn to create tag 'Safari-107'.

1:40 PM Changeset in webkit [5060] by vicki

• 8 edits in trunk

Safari-107 stamp.

12:59 PM Changeset in webkit [5059] by darin

• 3 edits in trunk/WebCore

• rolled out change to fix 3390850 because it caused a performance regression

• khtml/misc/decoder.cpp: (Decoder::decode): Rolled out change.

10:06 AM Changeset in webkit [5058] by kocienda

• 4 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3341222>: WebView doesn't follow AppKit default nextKeyView pattern

• WebCoreSupport.subproj/WebBridge.h: Added a variable to guard against recursion in -[WebBridge inNextKeyViewOutsideWebFrameViews].
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge inNextKeyViewOutsideWebFrameViews]): Accessor for recursion guard. (-[WebBridge nextKeyViewOutsideWebFrameViews]): Do not ask webView for its next key view, but rather, ask it for the next key view of the last view in its key view loop. This is what will get us to the next view outside of the webView.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView nextKeyView]): Ask AppKit, rather than khtml, for the next key key view if -[WebBridge inNextKeyViewOutsideWebFrameViews] returns YES. Doing so gives us the correct answer as calculated by AppKit, and makes HTML views behave like other views. This check also heads off an infinite recursion through -[WebBridge nextKeyViewOutsideWebFrameViews].

Also did some cleanup of some code that was marked for removal "some day".
That "some day" is today.

10:00 AM Changeset in webkit [5057] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed 3176853 -- can't attach files that have no extensions with Yahoo mail (bad Content-Type headers)

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]): Return @"application/octet-stream" rather than nil or empty string when the type is not known.

9:51 AM Changeset in webkit [5056] by kocienda

• 11 edits in trunk/WebCore

Reviewed by Dave

Name change: TextRun is now InlineTextBox. Some related names
have been changed as well. There should be no change in
behavior as a result of this patch.

• khtml/khtml_part.cpp: (KHTMLPart::selectedText): (firstRunAt): (lastRunAt): (startAndEndLineNodesIncludingNode):
• khtml/rendering/bidi.cpp:
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxDecorations):
• khtml/rendering/render_line.cpp: (InlineFlowBox::placeBoxesHorizontally): (InlineFlowBox::placeBoxesVertically):
• khtml/rendering/render_line.h:
• khtml/rendering/render_text.cpp: (InlineTextBox::detach): (throw): (InlineTextBox::operator delete): (InlineTextBox::paintSelection): (InlineTextBox::paintDecoration): (InlineTextBox::checkSelectionPoint): (InlineTextBoxArray::InlineTextBoxArray): (InlineTextBoxArray::compareItems): (InlineTextBoxArray::findFirstMatching): (RenderText::deleteRuns): (RenderText::findNextInlineTextBox): (RenderText::nodeAtPoint): (RenderText::checkSelectionPointIgnoringContinuations): (RenderText::cursorPos): (RenderText::posOfChar): (RenderText::paintObject): (RenderText::createInlineBox): (RenderText::position): (RenderText::width):
• khtml/rendering/render_text.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
• kwq/KWQRenderTreeDebug.cpp: (writeTextRun): (write):

7:50 AM Changeset in webkit [5055] by darin

• 2 edits
  2 adds in trunk

Added a new layout test.

• layout-tests/fast/forms/form-element-geometry-expected.txt: Added.
• layout-tests/fast/forms/form-element-geometry.html: Added.

Sep 24, 2003:

11:36 PM Changeset in webkit [5054] by darin

• 3 edits in trunk

• layout-tests/fast/table/003-expected.txt: Updated for textarea width change.

9:34 PM Changeset in webkit [5053] by darin

• 1 edit in trunk/WebKit/ChangeLog

Added marker now that the change was reviewed by Maciej.

9:28 PM Changeset in webkit [5052] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Added one more call to _stopAutoscrollTimer for when drags begin.

5:47 PM Changeset in webkit [5051] by hyatt

• 2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

5:44 PM Changeset in webkit [5050] by hyatt

• 31 adds in trunk/LayoutTests/fast/clip

Adding clipping tests.

5:37 PM Changeset in webkit [5049] by hyatt

• 4 edits in trunk/WebCore

Fix for 3429646, <img src="blah"<img src="foo"> should show up as two images.

Reviewed by darin

• khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

5:09 PM Changeset in webkit [5048] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed a recent regression, and ...
• fixed 3386544 -- ARCH: <object>s don't support transclusion like <iframe>s do

• khtml/khtml_part.cpp: (KHTMLPart::childFrame): Added back a cast I should not have removed to fix the function.

5:00 PM Changeset in webkit [5047] by hyatt

• 3 edits in trunk/WebCore

Fix for 3430612, crash on about:blank in updateHoverActiveState. Just missing
a null-check. Also remove a hover optimization that was bogus.

Reviewed by darin

• khtml/rendering/render_layer.cpp: (RenderLayer::updateHoverActiveState):

4:05 PM Changeset in webkit [5046] by rjw

• 12 edits in trunk

WebKit:

Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906. Also 3428451 needs to should be resolved.

Also added code to get and log entry point for the function used to get a Java class from plugins. That class is used for LiveConnect support.

Reviewed by John.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
• Plugins.subproj/npapi.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (FillStyleWithAttributes):
• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): (fontsChanged): (+[WebTextRendererFactory createSharedFactory]): (-[WebTextRendererFactory fontWithFamily:traits:size:]): (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):

WebCore:

Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (+[WebCoreBridge updateAllViews]):

9:37 AM Changeset in webkit [5045] by darin

• 2 edits
  2 adds in trunk

• a new test for JavaScript date parsing

• layout-tests/fast/js/date-parse-test-expected.txt: Added.
• layout-tests/fast/js/date-parse-test.html: Added.

9:37 AM Changeset in webkit [5044] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed 3421107 -- some dates that other browsers can parse can't be parsed by KJS's Date.parse()

• kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Added code to be more strict about month names, to allow a time zone after date even if the date omits the time, and to understand AM and PM.

8:55 AM Changeset in webkit [5043] by darin

• 7 edits in trunk/WebCore

Reviewed by Ken.

• fixed ownerElement for documents in HTML objects (helpful for some work Dave is doing)

• khtml/khtml_part.h: Change name of frame function to childFrame for clarity.
• khtml/khtml_part.cpp: (KHTMLPart::slotChildStarted): Call the frame function by its new name, childFrame. (KHTMLPart::slotChildCompleted): Ditto. (KHTMLPart::slotChildURLRequest): Ditto. (KHTMLPart::childFrame): Change name from frame to childFrame for clarity, and make it work for parts inside HTML objects, not just normal frames and iframes. The change in behavior is the actual fix. Note that for the three callers above, it's an error to call this when the result would be 0, so there's no harm in doing the extra search of HTML objects in those cases.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement): Call the frame function by its new name, childFrame. This is the caller that will benefit most from the change in behavior.

• kwq/KWQKHTMLPart.h: Remove childFrameForPart function, which is superseded by the childFrame function now.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Use childFrame instead of childFrameForPart.