Timeline
Sep 30, 2003:
- 5:47 PM Changeset in webkit [5098] by
-
- 2 edits in trunk/WebKit
Attempt to find a reasonable font using a simple string matching heuristic if
none of the fonts actually specified are found. In particular we will use
Geeza Pro if "arabic", "urdu", or "pashto" is contained (case-insensitive) in
any of the requested font family names. Geeza Pro is a much better fallback
font for Arabic (and variant languages) than Helvetica.
Reviewed by Chris.
- WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]):
- 5:38 PM Changeset in webkit [5097] by
-
- 8 edits1 add in trunk/WebKit
WebKit:
- fixed 3045617 -- Make Text Bigger/Smaller doesn't affect non-html documents.
I added an internal protocol inside WebKit to make this work, and implemented
it for plain text and RTF. I also slightly shuffled the existing code to
handle this for HTML so that it goes through the new protocol in that case
also.
Reviewed by NOBODY (OOPS!).
- WebView.subproj/WebDocumentInternal.h: Added.
New header file, holds definition of
_web_WebDocumentTextSizing protocol.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _textSizeMultiplierChanged]): if the document view conforms to the new protocol, tell it that the multiplier has changed. Also, don't tell the bridge here anymore; let WebHTMLView do that.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateTextSizeMultiplier]): tell the bridge here instead of having WebFrame do so (-[WebHTMLView viewDidMoveToSuperview]): call _updateTextSizeMultiplier (in case it changed while we were switched out) (-[WebHTMLView _web_textSizeMultiplierChanged]): call _updateTextSizeMultiplier
- WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation receivedData:withDataSource:]):
- WebView.subproj/WebTextView.h: now implements _web_WebDocumentTextSizing protocol; new ivar for holding local copy of text size multiplier; new public method appendReceivedData:fromDataSource:
- WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): set local copy of text size multiplier to 1.0 (-[WebTextView _textSizeMultiplierFromWebView]): new method, asks the webview's opinion of the text size multiplier (-[WebTextView setFixedWidthFont]): use the text size multiplier when setting font size (-[WebTextView _adjustRichTextFontSizeByRatio:]): new method, borrowed from Mail and tweaked, that walks through the rich text and adjusts the font sizes (-[WebTextView _updateTextSizeMultiplier]): new method, updates local copy of text size multiplier to match webview's opinion (-[WebTextView setDataSource:]): set the text size multiplier appropriately before setting the fixed-width font; this is too early for the RTF case though since the fonts are embedded in the data (-[WebTextView appendReceivedData:fromDataSource:]): new method. Most of this logic was in WebTextRepresentation, but it's a little better encapsulated here, plus now it handles the text multiplier for RTF. (-[WebTextView defaultsChanged:]): added comment (-[WebTextView _web_textSizeMultiplierChanged]): call updateTextSizeMultiplier
- WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): return NO if the main frame doesn't support the text sizing protocol. This means that if the main frame doesn't support it but a subframe does, you can't adjust the text size. This seems fine for now since the only case with subframes is HTML, where the main frame does support changing text size.
- WebKit.pbproj/project.pbxproj: updated for new file
WebBrowser:
Reviewed by Darin
- HTMLSourceDocument.h: removed unused _textSizeMultiplier ivar
- 5:08 PM Changeset in webkit [5096] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3428262>: Plugin loads for static files, but not PHP scripts
Reviewed by rjw.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]): load the plug-in DB so this method returns reliable results.
- 4:17 PM Changeset in webkit [5095] by
-
- 3 edits in trunk/WebCore
Reviewed by me
- WebCore.pbproj/project.pbxproj: Made WebCoreKeyboardAccess.h a private header.
- 4:07 PM Changeset in webkit [5094] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3006869>: show image dimensions in title bar when single image is loaded
Reviewed by rjw.
- English.lproj/Localizable.strings:
- WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]): return "foo.jpg 50x50 pixels"
- 4:04 PM Changeset in webkit [5093] by
-
- 2 edits in trunk/WebKit
Fixed 3420396. If a frame targets _top and a URL that contains a fragment (very unusual, it's meaningless for a frameset to contain a named anchor point) the frameset won't be reloaded. Our normal path is to just scroll to the anchor point. This is only important because our Help folks oddly depend on the behavior.
Reviewed by Chris.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
- 3:47 PM Changeset in webkit [5092] by
-
- 1 add in trunk/WebCore/kwq/WebCoreKeyboardAccess.h
I added this file earlier, but a cvs-abandon command removed it. Re-adding and committing.
- 3:47 PM Changeset in webkit [5091] by
-
- 9 edits in trunk
WebCore:
Reviewed by Maciej
Fix for this bug:
<rdar://problem/3439688>: WebKit needs to retrieve full keyboard access preference
- WebCore.pbproj/project.pbxproj:
- kwq/KWQKHTMLPart.h: Declare keyboardUIMode accessor.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyboardUIMode): Implement keyboardUIMode accessor (calls through the bridge).
- kwq/WebCoreBridge.h: Declare the bridge accessor.
- kwq/WebCoreKeyboardAccess.h: Added. Header defines keyboard UI mode constants.
WebKit:
Reviewed by Maciej
Fix for this bug:
<rdar://problem/3439688>: WebKit needs to retrieve full keyboard access preference
- WebCoreSupport.subproj/WebBridge.h: Add two ivars: one to track the keyboard UI mode, the other a flag we use to register for notifications.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Remove the notification observer to keyboard UI mode changes. (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): New method. Accesses the preferences to get the current keyboard UI mode. (-[WebBridge keyboardUIMode]): Returns the current keyboard UI mode. Registers for notifications of keyboard UI mode changes when called the first time.
- 2:58 PM Changeset in webkit [5090] by
-
- 11 edits in trunk
WebCore:
Reviewed by Ken.
- fixed 3375281 - Keyboard event handlers not fired if focus not in form field
- fixed 3242927 - KeyPressed Event in Javascript don't work
- fixed 3375353 - keyboard event.target not updated when blurring from form items
- fixed 3183754 - returning false from key press handlers does not prevent typing or form submission
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Force false when defaultHandled instead of based on a weird rule appropriate for KDE but not for us.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): If there's no focus node, give the event to the body element instead of giving up. Also, reverse expectedsense of return value dispatchKeyEvent, since it returns true if it *didn't* swallow the event. And finally, let the key press event as well as the key down event for the initial NSKeyDown block default handling.
- kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): Respect return value from interceptKeyEvent: (-[KWQTableView keyUp:]): ditto
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): ditto (-[KWQTextAreaTextView keyUp:]): ditto
- kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): ditto
WebKit:
Reviewed by Ken.
- fixed 3375281 - Keyboard event handlers not fired if focus not in form field
- fixed 3242927 - KeyPressed Event in Javascript don't work
- fixed 3375353 - keyboard event.target not updated when blurring from form items
- fixed 3183754 - returning false from key press handlers does not prevent typing or form submission
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Ask the bridge before passing the event along. (-[WebHTMLView keyUp:]): Likewise.
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebHTMLViewPrivate.m: Remove dead code.
- 2:06 PM Changeset in webkit [5089] by
-
- 4 edits in trunk/WebKit
Fixed 3422138. We weren't sending a didChange call for isLoading until the load was complete! Also [WebView isLoading] wasn't accounting for provisional datasources.
Reviewed by Chris.
- WebView.subproj/WebView.m: (-[WebView isLoading]):
- WebView.subproj/WebViewPrivate.h:
- WebView.subproj/WebViewPrivate.m: (-[WebView _didStartProvisionalLoadForFrame:]): (-[WebView _didCommitLoadForFrame:]): (-[WebView _didFinishLoadForFrame:]): (-[WebView _didFailLoadWithError:forFrame:]): (-[WebView _didFailProvisionalLoadWithError:forFrame:]):
- 12:53 PM Changeset in webkit [5088] by
-
- 21 edits in trunk/LayoutTests
Update layout tests.
- 11:47 AM Changeset in webkit [5087] by
-
- 1 edit in trunk/WebCore/khtml/rendering/render_list.cpp
Backing out an accidental commit.
- 11:46 AM Changeset in webkit [5086] by
-
- 3 edits in trunk/WebKit
Improvements to scrolling and layout. Also fixing 3264346, body overflow should
apply to document's scrollbars.
Reviewed by darin
- WebView.subproj/WebDynamicScrollBarsView.h:
- WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView initWithFrame:]): (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]): (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): (-[WebDynamicScrollBarsView horizontalScrollingMode]): (-[WebDynamicScrollBarsView verticalScrollingMode]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]):
- 11:45 AM Changeset in webkit [5085] by
-
- 19 edits in trunk/WebCore
Improvements to layout transitions and scrollbar appearance/disappearance.
Also implementing a fix for 3264346, overflow applied to body should apply to
the document's scrollers.
Reviewed by darin
- khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::parseAttribute):
- khtml/khtmlview.cpp: (KHTMLView::KHTMLView): (KHTMLView::~KHTMLView): (KHTMLView::resetScrollBars): (KHTMLView::clear): (KHTMLView::initScrollBars): (KHTMLView::applyBodyScrollQuirk): (KHTMLView::inLayout):
- khtml/khtmlview.h:
- khtml/rendering/render_block.cpp:
- khtml/rendering/render_block.h:
- khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
- khtml/rendering/render_form.cpp: (TextAreaWidget::TextAreaWidget):
- khtml/rendering/render_frames.cpp: (RenderFrame::slotViewCleared): (RenderPartObject::slotViewCleared):
- khtml/rendering/render_list.cpp: (RenderListMarker::calcMinMaxWidth):
- khtml/rendering/render_object.cpp: (RenderObject::repaint): (RenderObject::repaintRectangle):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::setInPageCache):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
- kwq/KWQRenderTreeDebug.cpp: (write): (externalRepresentation):
- kwq/KWQScrollView.h:
- kwq/KWQScrollView.mm: (QScrollView::setVScrollBarMode): (QScrollView::setHScrollBarMode): (QScrollView::setScrollBarsMode): (QScrollView::vScrollBarMode): (QScrollView::hScrollBarMode): (QScrollView::hasVerticalScrollBar): (QScrollView::hasHorizontalScrollBar): (QScrollView::suppressScrollBars):
- kwq/WebCoreBridge.mm: (-[WebCoreBridge installInFrame:]):
- kwq/WebCoreFrameView.h:
- 11:39 AM Changeset in webkit [5084] by
-
- 3 edits in trunk/WebCore
Fix for 3437260, nil deref of the render style because it hasn't been set yet.
Fallout from my incremental repainting landing.
Reviewed by darin
- khtml/rendering/render_replaced.cpp: (RenderWidget::setQWidget):
- 11:35 AM Changeset in webkit [5083] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Dave.
Rolled in Harri Porten's change to accept non-breaking space in JavaScript.
- kjs/lexer.cpp: (Lexer::isWhiteSpace): Accept 00A0 as "whitespace".
- 11:30 AM Changeset in webkit [5082] by
-
- 3 edits in trunk/WebCore
Fix for 3438479, tables expand on every layout when a cell has percentage height
children.
Reviewed by darin
- khtml/rendering/render_table.cpp: (RenderTableSection::calcRowHeight): (RenderTableRow::layout):
Sep 29, 2003:
- 4:04 PM Changeset in webkit [5081] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3332460>: nil-deref in khtml::RenderWidget::eventFilter with onchange handler
Reviewed by darin.
- kwq/KWQTextField.mm: (-[KWQTextField controlTextDidEndEditing:]): call setHasFocus:NO last so we have the widget that lets us get to the bridge and lets us call controlTextDidEndEditing
- 3:33 PM Changeset in webkit [5080] by
-
- 3 edits in trunk/WebCore
Fix for 3425053, text past the bottom of a positioned table doesn't repaint.
3426847 is the same bug. Both are fixed by ensuring that calcHeight doesn't actually
do anything other than margin computation and position determination for positioned
elements. In reality, for weird edge cases like implying the height via explicit top and
bottom properties, we'll still be wrong.
Reviewed by darin
- ChangeLog:
- khtml/rendering/render_table.cpp: (RenderTable::layout):
- 3:05 PM Changeset in webkit [5079] by
-
- 5 edits in trunk/WebKit
Fixed: <rdar://problem/3422739>: Plug-in streams not cancelled when plug-in returns error from NPP_NewStream
Reviewed by mjs.
- Plugins.subproj/WebBaseNetscapePluginStream.h: renamed receivedError to cancelWithReason
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): call cancelWithReason if NPP_NewStream returns an error (-[WebBaseNetscapePluginStream cancelWithReason:]): renamed (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): tweak
- Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call renamed cancelWithReason (-[WebNetscapePluginRepresentation cancelWithReason:]): new override, stop load then call super
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): new override, stop load then call super (-[WebNetscapePluginStream stop]): call cancelWithReason (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): call renamed cancelWithReason (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): call renamed cancelWithReason
- 2:10 PM Changeset in webkit [5078] by
-
- 1 add in trunk/LayoutTests/fast/text/whitespace/024-expected.txt
Forgot to commit expected.txt for new whitespace test.
- 2:10 PM Changeset in webkit [5077] by
-
- 2 adds in trunk/LayoutTests/fast/block/positioning
Add layout test for abs positioned object inside relpositioned inline containing block
- 1:29 PM Changeset in webkit [5076] by
-
- 1 add in trunk/LayoutTests/fast/text/whitespace/024.html
Adding layout test for <pre> maxwidth bug.
- 1:27 PM Changeset in webkit [5075] by
-
- 4 edits in trunk/WebCore
Make sure that timeouts updateRendering after they execute the scheduled timer
action.
Also fixing 3429455, maxwidth of pres miscomputed when two blank lines occur at
the end of a pre text run.
Reviewed by darin, mjs (setTimeout fix), darin (pre fix)
- khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
- khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth):
- 9:49 AM Changeset in webkit [5074] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
- fixed 3437292 -- Safari uses wrong characters for ∧ and ∨ entities
- khtml/html/kentities.gperf: Corrected values for ∧ and ∨ entities. Checked all the rest against a list on the W3C site, and those are the only two that were wrong.
- khtml/html/kentities.c: Regnenerated.
Sep 26, 2003:
- 9:44 AM Changeset in webkit [5073] by
-
- 3 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3435532>: REGRESSION: tabbing to textareas causes infinite recursion
Add recursion guards to the becomeFirstResponder method, otherwise calling
eventFilter with a FocusIn event will cause the infinite recursion
described in the bug.
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]):
