⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 3, 2003:

4:24 PM Changeset in webkit [5136] by rjw
  • 3 edits in trunk/WebKit

Fix part of 3438071. Creating an instance of WebPreferences using init
will do the expected thing: that is, create a new instance! We used to
always return standardPreferences.

Reviewed by Chris.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences init]): (+[WebPreferences standardPreferences]):
3:38 PM Changeset in webkit [5135] by darin
  • 3 edits in trunk
  • updated layout tests for recent WebTextRenderer changes
  • layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.sun.com/index-expected.txt:
  • layout-tests/css1/font_properties/font_weight-expected.txt:
3:32 PM Changeset in webkit [5134] by hyatt
  • 2 edits in trunk/WebKit

Fix for numerous regressions caused by an inadvertent renaming of the recursiveDisplay
override method.

Reviewed by darin

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2:57 PM Changeset in webkit [5133] by rjw
  • 2 edits in trunk/WebKit

Fixed some edge case issue (control characters after end of word) with our rounding hack.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
2:51 PM Changeset in webkit [5132] by cblu
  • 3 edits
    1 delete in trunk/WebCore

Removed eastCursor.tiff because it was added by mistake.

  • Resources/eastCursor.tiff: Removed.
  • WebCore.pbproj/project.pbxproj:
2:49 PM Changeset in webkit [5131] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3398420 - crash when creating a new document.body object in <body>

Also included David Faure's improvement to throw an exception.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setBody): Don't remove the body when null is passed in, as this means type error at the higher level, so throw an exception.
  • khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Initialize current to 0. (KHTMLParser::setCurrent): Ref new current and deref old; we need to keep it ref'd because script execution could drop the current node on the floor. (KHTMLParser::reset): Use setCurrent. (KHTMLParser::insertNode): Likewise. (KHTMLParser::reopenResidualStyleTags): Likewise. (KHTMLParser::popOneBlock): Likewise. (KHTMLParser::finished): Likewise.
  • khtml/html/htmlparser.h: Prototype setCurrent.
2:46 PM Changeset in webkit [5130] by cblu
  • 14 edits in trunk/WebCore

Ran compress-tiffs on new cursor images.

  • Resources/eastCursor.tiff:
  • Resources/eastResizeCursor.tiff:
  • Resources/helpCursor.tiff:
  • Resources/moveCursor.tiff:
  • Resources/northEastResizeCursor.tiff:
  • Resources/northResizeCursor.tiff:
  • Resources/northWestResizeCursor.tiff:
  • Resources/southEastResizeCursor.tiff:
  • Resources/southResizeCursor.tiff:
  • Resources/southWestResizeCursor.tiff:
  • Resources/waitCursor.tiff:
  • Resources/westResizeCursor.tiff:
11:46 AM Changeset in webkit [5129] by kocienda
  • 11 edits in trunk

WebCore:

Reviewed by Darin, with much help from Maciej and Hyatt

Fix for these bugs:

<rdar://problem/3441321>: Form buttons do not respond to key events when focused
<rdar://problem/3441060>: Form buttons do not scroll to view when focused

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::simulateMouseClickForEvent): Added helper to simulate mouse clicks in elements. Used to trigger button actions in response to keyboard events. (HTMLInputElementImpl::defaultEventHandler): Improved handler to process key press events for radio, checkbox, image, reset, and submit buttons.
  • khtml/html/html_formimpl.h: Added simulateMouseClickForEvent function.
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::isKeyboardEvent): Added type check virtual function. (DOM::KeyEventImpl::isKeyboardEvent): Ditto.
  • kwq/KWQButton.h:
  • kwq/KWQButton.mm: (-[KWQButton simulateClick]): New method. This makes AppKit do a button click programatically for button types. For <input type=image>, we just simulate a the click in the DOM since there is no real "clickable" AppKit widget. (-[KWQButton becomeFirstResponder]): Fixes the button scroll to visible when focused issue. (-[KWQButton resignFirstResponder]): Correctly give up focus when user clicks into the page body when a button has the focus. (QButton::simulateClick): QWidget bridge to the KWQButton simulateClick method.

WebKit:

Reviewed by Darin, with much help from Maciej and Hyatt

Fix for this bug:

<rdar://problem/3441321>: Form buttons do not respond to key events when focused

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _firstResponderIsControl]): Added to tell if the focus is on a form control. (-[WebFrameView keyDown:]): Call new _firstResponderIsControl method to see whether space bar key events should propagate. Adding this check keeps us from blocking the event here and allows AppKit to handle it.
  • WebView.subproj/WebFrameViewPrivate.h: Add new _firstResponderIsControl method.
11:40 AM Changeset in webkit [5128] by hyatt
  • 6 edits in trunk/WebCore

Removing redundant layouts and adding a few !needsLayout and !normalChildNeedsLayout
checks to prevent extra layouts.

Also, fixing the recalcStyle changed() bottleneck to go through view's layout and to
not do a full repaint. The layout method will then do the right thing (full repaint
without INCREMENTAL_REPAINTING turned on, the precise repainting needed otherwise).

Reviewed by darin

  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle):

Oct 2, 2003:

5:48 PM Changeset in webkit [5127] by mjs
  • 9 edits
    6 deletes in trunk/WebKit

Folded Private implementation files into the regular ones as the
first step towards pulling in our SPI exposure and other code
cleanup.

  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryPrivate.m: Removed.
  • Misc.subproj/WebIconDatabasePrivate.h:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m: Removed.
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m: Removed.
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m: Removed.
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebHTMLViewPrivate.m: Removed.
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m: Removed.
4:28 PM Changeset in webkit [5126] by hyatt
  • 3 edits in trunk/WebCore

Remove the speed hit from using the UC break locators by not using them when
checking if the current character is &nbsp; and by also using a global text
break locator object.

Reviewed by rjw

  • khtml/rendering/break_lines.cpp:
4:16 PM Changeset in webkit [5125] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3440063>: Safari 1.1 won't load new pages after visiting adultswim.com, assertion failure on debug build

Reviewed by rjw.

  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): if not data was received for a stream, create the temp file anyway. Plug-ins expect this.
3:11 PM Changeset in webkit [5124] by vicki
  • 3 edits in trunk

tree is open for Safari-109

3:06 PM Changeset in webkit [5123]
  • 3 copies in tags/Safari-108

This commit was manufactured by cvs2svn to create tag 'Safari-108'.

3:06 PM Changeset in webkit [5122] by vicki
  • 8 edits in trunk

Safari-108 stamp.

12:58 PM Changeset in webkit [5121] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
11:50 AM Changeset in webkit [5120] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Don't turn on scroll-blitting here when the page is done... (-[WebFrame _transitionToCommitted:]): Instead do it here, when the page is committed.
11:46 AM Changeset in webkit [5119] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3398622 - Crash when JavaScript changes display style

This was a problem with one of the many global variables in
bidi.cpp, last, having a stale value from the last layout that
pointed to a dead node. I fixed this by refactoring the code to
put most of the global variables in a struct allocated on the
stack, and pass around a reference to the struct. Seems much
cleaner (if somewhat wordier) this way. There are still more
global variables to kill here.

  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::BidiIterator): (khtml::BidiStatus::BidiStatus): (khtml::BidiInfo::BidiInfo): (khtml::Bidinext): (khtml::first): (khtml::BidiIterator::increment): (khtml::checkMidpoints): (khtml::appendRunsForObject): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak):
  • khtml/rendering/bidi.h:
  • khtml/rendering/render_block.h:
11:35 AM Changeset in webkit [5118] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • in preparation for a WebCore whitespace-handling change, made WebTextRenderer draw and measure newline characters as if they are spaces (just as we already do with non-breaking spaces)
  • removed some unused stuff from WebTextRenderer
  • other unimportant tweaks (e.g. unsigned int -> unsigned)
  • WebCoreSupport.subproj/WebTextRenderer.m: (kFixedOne), (fixed1), (FixToFloat), (FloatToFixed): Removed these. We can use the standard ones from <FixMath.h> instead of defining our own. (isControlCharacter): Added. Inline function that we can use instead of the macro we had before. (isAlternateSpace): Added. Returns YES for newlines and non-breaking spaces. (isSpace): Added. Returns YES for real spaces and the two alternate spaces as well. (initializeCharacterWidthIterator): Use isSpace. (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): Use isAlternateSpace and isControlCharacter. (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]): Use isControlCharacter, isAlternateSpace, and isSpace. Also fix a small bug where numGlyphs would not get set up properly when the run length is 0, and used local variables when possible instead of going back at the run structure. (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): Use the standard FixedToFloat instead of our own FixToFloat. (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): Ditto.
11:23 AM Changeset in webkit [5117] by hyatt
  • 7 edits in trunk/WebCore

Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.

Reviewed by darin

  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject initWithRenderer:]): (-[KWQAccObject parentObject]): (-[KWQAccObject parentObjectUnignored]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityIsAttributeSettable:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityHitTest:]):
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge accessibilityTree]):
11:22 AM Changeset in webkit [5116] by hyatt
  • 2 edits in trunk/WebKit

Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.

Reviewed by darin

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView accessibilityAttributeValue:]): (-[WebHTMLView accessibilityHitTest:]):
11:19 AM Changeset in webkit [5115] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed 3441656 -- constructor bad for objs created w/ function as prototype (www.moock.org/asdg/codedepot)
  • kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Set up the constructor as as specified in the JavaScript spec. We were already doing this right in the other place we make functions.
8:31 AM Changeset in webkit [5114] by darin
  • 122 edits in trunk

Reviewed by Ken.

  • kwq/KWQRenderTreeDebug.cpp: (quoteAndEscapeNonPrintables): Since our text rendering renders non-breaking spaces the same as spaces, dump them as spaces. Do the same with newlines since I am about to change our text rendering to do the same with newlines.
  • layout-tests: Updated test results.

Oct 1, 2003:

6:43 PM Changeset in webkit [5113] by hyatt
  • 4 edits in trunk/WebCore

Avoid doing extra work when tearing down the document by checking to see if
we're in the destruction of the document.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
5:24 PM Changeset in webkit [5112] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewDidMoveToSuperview]): skip some work when when we've been removed. This wasn't causing any trouble before, but was at least conceptually inefficient.
5:07 PM Changeset in webkit [5111] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3441372: REGRESSION (107+): Plain text document is initially drawn with proportional font

Reviewed by Hyatt

  • WebView.subproj/WebTextView.m: (-[WebTextView setDataSource:]): Changed a != to an ==
4:57 PM Changeset in webkit [5110] by rjw
  • 13 edits in trunk

WebKit:

Fixed 3438441. If a load is triggered by a onload handling, don't add an entry for it into the b/f or history. The new Google ads use this technique.

Reviewed by Ken.

  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _itemForRestoringDocState]):

WebCore:

Fixed 3438441. Pass extra info up to WebKit about load type, specifically is a load is triggered by JS running in an onLoad handler.

Reviewed by Ken.

  • khtml/ecma/kjs_binding.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (KWQKHTMLPart::submitForm): (KWQKHTMLPart::urlSelected):
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Nothing changed. Tweaked spacing.
4:56 PM Changeset in webkit [5109] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _webView]): Fixed problem where we'd get a nil WebView and pass crazy values for subframe text multipliers.
4:27 PM Changeset in webkit [5108] by cblu
  • 10 edits
    12 adds in trunk/WebCore

<rdar://problem/2942589>: CSS cursors are not implemented

Reviewed by Dave.

  • Resources/eastCursor.tiff: Added.
  • Resources/eastResizeCursor.tiff: Added.
  • Resources/helpCursor.tiff: Added.
  • Resources/moveCursor.tiff: Added.
  • Resources/northEastResizeCursor.tiff: Added.
  • Resources/northResizeCursor.tiff: Added.
  • Resources/northWestResizeCursor.tiff: Added.
  • Resources/southEastResizeCursor.tiff: Added.
  • Resources/southResizeCursor.tiff: Added.
  • Resources/southWestResizeCursor.tiff: Added.
  • Resources/waitCursor.tiff: Added.
  • Resources/westResizeCursor.tiff: Added.
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssparser.cpp: special-case the hand cursor to mean pointer (CSSParser::parseValue):
  • khtml/css/cssvalues.c: generated changes (hash_val): (findValue):
  • khtml/css/cssvalues.h: generated changes
  • khtml/css/cssvalues.in: removed the progress cursor from the list because it was messing up the mapping
  • khtml/khtmlview.cpp: call new cursor methods
  • kwq/KWQKCursor.h:
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]): new, loads and caches cursors (KCursor::crossCursor): get the AppKit cross hair cursor (KCursor::handCursor): call _WebCore_cursorWithName:hotSpot: (KCursor::sizeAllCursor): ditto (KCursor::waitCursor): ditto (KCursor::whatsThisCursor): ditto (KCursor::eastResizeCursor): new, call _WebCore_cursorWithName:hotSpot: (KCursor::northResizeCursor): ditto (KCursor::northEastResizeCursor): ditto (KCursor::northWestResizeCursor): ditto (KCursor::southResizeCursor): ditto (KCursor::southEastResizeCursor): ditto (KCursor::southWestResizeCursor): ditto (KCursor::westResizeCursor): ditto
1:58 PM Changeset in webkit [5107] by hyatt
  • 45 edits
    4 adds in trunk

Clean up our detach model so that you can always get to a document, even for
anonymous content. Also stubbing out and adding the accessibility objects.

Reviewed by darin, mjs, john

  • ChangeLog:
  • WebCore.pbproj/project.pbxproj:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::detach):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
  • khtml/rendering/render_container.cpp: (RenderContainer::detach): (RenderContainer::addChild): (RenderContainer::updatePseudoChild): (RenderContainer::insertChildNode): (RenderContainer::removeLeftoverAnonymousBoxes):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::createAnonymousFlow): (RenderFlow::deleteLineBoxes): (RenderFlow::detach):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderTextArea::detach):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::detach):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::splitFlow): (RenderInline::renderName):
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::detach): (RenderListItem::updateMarkerLocation): (RenderListMarker::RenderListMarker):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information): (RenderObject::dump): (RenderObject::createAnonymousBlock): (RenderObject::remove): (RenderObject::detach):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::detach):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTableSection::detach): (RenderTableSection::addChild): (RenderTableRow::detach): (RenderTableRow::addChild): (RenderTableCell::detach):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (RenderText::detach): (RenderText::deleteRuns):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::detach): (DocumentImpl::getOrCreateAccObjectCache):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::detach):
  • kwq/KWQAccObject.h: Added.
  • kwq/KWQAccObject.mm: Added. (-[KWQAccObject x]): (-[KWQAccObject y]): (-[KWQAccObject width]): (-[KWQAccObject height]): (-[KWQAccObject detached]): (-[KWQAccObject detach]): (-[KWQAccObject data]): (-[KWQAccObject setData:]): (-[KWQAccObject firstChild]): (-[KWQAccObject lastChild]): (-[KWQAccObject previousSibling]): (-[KWQAccObject nextSibling]): (-[KWQAccObject parentObject]):
  • kwq/KWQAccObjectCache.h: Added.
  • kwq/KWQAccObjectCache.mm: Added. (KWQAccObjectCache::KWQAccObjectCache): (KWQAccObjectCache::~KWQAccObjectCache): (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::detach):
  • layout-tests/css1/pseudo/firstletter-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • layout-tests/fast/css-generated-content/002-expected.txt:
  • layout-tests/fast/css-generated-content/004-expected.txt:
  • layout-tests/fast/css-generated-content/005-expected.txt:
  • layout-tests/fast/css-generated-content/006-expected.txt:
  • layout-tests/fast/selectors/039-expected.txt:
  • layout-tests/fast/selectors/039b-expected.txt:
  • layout-tests/fast/selectors/041-expected.txt:
  • layout-tests/fast/selectors/042-expected.txt:
  • layout-tests/fast/selectors/166a-expected.txt:
  • layout-tests/fast/selectors/168-expected.txt:
  • layout-tests/fast/selectors/168a-expected.txt:
  • layout-tests/fast/selectors/169-expected.txt:
  • layout-tests/fast/selectors/169a-expected.txt:
  • layout-tests/fast/text/firstline/002-expected.txt:
  • layout-tests/fast/text/firstline/003-expected.txt:
1:36 PM Changeset in webkit [5106] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Adding layout test for setting of cssFlaot via a with clause.

1:30 PM Changeset in webkit [5105] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3163840, the images are mispositioned on the DHTML menus at the top of
www.aa.com (and in many other places). We needed to support returning the right
value from hasProperty and tryGet for 'cssFloat'.

This patch also adds support for getting/setting our custom CSS properties (-khtml-*)
and just factors the code a bit better for all the special values.

Reviewed by darin

  • khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::hasProperty): (DOMCSSStyleDeclaration::tryGet): (DOMCSSStyleDeclaration::tryPut):
1:22 PM Changeset in webkit [5104] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3437309 -- REGRESSION (100-107): Javascript menu doesn't work at www.aa.com
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::removeAttribute): Restored the old behavior for removeAttribute and removeAttributeNS; these don't give NOT_FOUND_ERR. But keep the NOT_FOUND_ERR for removeAttributeNode and removedNamedItem.
12:57 PM Changeset in webkit [5103] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by me

  • kwq/KWQWidget.mm: (QWidget::focusPolicy): Improved comment.
11:48 AM Changeset in webkit [5102] by kocienda
  • 8 edits in trunk/WebCore

Reviewed by Maciej

Fix for these bugs:

<rdar://problem/3439736>: WebCore form button widgets do not accept focus
<rdar://problem/3440770>: WebCore form button widgets do not take part in tabbing order

  • kwq/KWQButton.h: Add focusPolicy function declaration.
  • kwq/KWQButton.mm: (-[KWQButton nextKeyView]): Add tabbing support for buttons. (-[KWQButton previousKeyView]): Ditto (-[KWQButton nextValidKeyView]): Ditto (-[KWQButton previousValidKeyView]): Ditto (QButton::focusPolicy): Add focusPolicy implementation. This calls through to the recently-added accessor for full keyboard access to help in the determination for focus policy. For now, full keyboard access must be turned on for buttons to receive focus.
  • kwq/KWQTextEdit.h: Remove focusPolicy specialization from this class. The implementation in QWidget now serves this class well.
  • kwq/KWQTextEdit.mm: Ditto
  • kwq/KWQWidget.h: Added isEnabled function. Small, unrelated cleanup to move the no-implementation setFocusPolicy() and setFocusProxy() functions fully into the header file.
  • kwq/KWQWidget.mm: (QWidget::isEnabled): Added. Calls through to the Cocoa view to retrieve this information. (QWidget::focusPolicy): Much improved focus policy function is now more general in stipulating the conditions for focus policy, and will work for more widgets.
11:36 AM Changeset in webkit [5101]
  • 1 copy
    318 deletes in branches/unlabeled-1.35.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.4'.

11:36 AM Changeset in webkit [5100] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.

Reviewed by cblu

  • kwq/KWQScrollView.h:
  • kwq/WebCoreFrameView.h:
11:34 AM Changeset in webkit [5099] by hyatt
  • 2 edits in trunk/WebKit

Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.

Reviewed by cblu

  • WebView.subproj/WebDynamicScrollBarsView.m:
Note: See TracTimeline for information about the timeline view.