⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 8, 2003:

6:35 PM Changeset in webkit [5152] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/positioning

Adding layout test for section 10.3.7 of the CSS2.1 spec.

6:34 PM Changeset in webkit [5151] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3436723, the shrink-to-fit algorithm for positioned elements did not match
the algorithm specified in section 10.3.7 of the CSS2.1 specification. The min-width
of the element was not being taken into account like it should have been.

Reviewed by mjs

  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):
5:45 PM Changeset in webkit [5150] by hyatt
  • 4 edits in trunk/WebCore

Implement min/max width and min/max height support for replaced elements.

Reviewed by ken

  • khtml/rendering/render_box.cpp: (RenderBox::calcReplacedWidth): (RenderBox::calcReplacedWidthUsing): (RenderBox::calcReplacedHeight): (RenderBox::calcReplacedHeightUsing): (RenderBox::availableHeight): (RenderBox::availableHeightUsing):
  • khtml/rendering/render_box.h:
4:27 PM Changeset in webkit [5149] by mjs
  • 3 edits in trunk/WebCore

Fix development build.

  • kwq/KWQExceptions.h: Correct assertion args.
2:23 PM Changeset in webkit [5148]
  • 1 copy
    322 deletes in branches/unlabeled-1.39.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.39.4'.

2:23 PM Changeset in webkit [5147] by mjs
  • 23 edits
    1 add in trunk/WebCore

Reviewed by Ken.

Start on blocking Cocoa exceptions when calling ObjC from C++ to
avoid unreproducible crashes when this happens.

  • kwq/KWQExceptions.h: Added. Helper macros for exception blocking.
  • WebCore.pbproj/project.pbxproj: Add new header

In all these files, block exceptions when calling ObjC from C++,
or explain why not.

  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQApplication.mm:
  • kwq/KWQButton.mm: (QButton::QButton): (QButton::~QButton): (QButton::setText): (QButton::text): (QButton::clicked): (QButton::simulateClick): (QButton::setFont): (QButton::focusPolicy):
  • kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox): (QCheckBox::setChecked): (QCheckBox::isChecked): (QCheckBox::dimensions):
  • kwq/KWQColor.mm:
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): (QComboBox::~QComboBox): (QComboBox::insertItem): (QComboBox::sizeHint): (QComboBox::setCurrentItem): (QComboBox::updateCurrentItem): (QComboBox::setFont): (QComboBox::dimensions):
  • kwq/KWQCursor.mm:
  • kwq/KWQFile.mm:
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::baselinePosition): (KWQFileButton::filenameChanged):
  • kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): (KWQKCookieJar::setCookie): (KWQKCookieJar::cookieEnabled):
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): (KHTMLPartBrowserExtension::setIconURL): (KHTMLPartBrowserExtension::setTypedIconURL):
  • kwq/KWQKHistoryProvider.mm: (KParts::HistoryProvider::contains):
  • kwq/KWQKPartsBrowserInterface.mm: (KParts::BrowserInterface::callMethod):
  • kwq/KWQKStandardDirs.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQKWinModule.mm: (KWinModule::workArea):
  • kwq/KWQObject.mm:
  • kwq/KWQString.mm: (QString::getNSString):
  • kwq/KWQTimer.mm:
  • kwq/KWQWindowWidget.mm:

Oct 7, 2003:

6:49 PM Changeset in webkit [5146] by hyatt
  • 5 edits in trunk/WebCore

Fix for link dragging regression in the titles of links. More accessibility
improvements.

Reviewed by darin

  • khtml/khtml_part.cpp: (KHTMLPart::text):
  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject helpText]): (-[KWQAccObject textUnderElement]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeValue:]):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
3:23 PM Changeset in webkit [5145] by kocienda
  • 19 edits in trunk/WebCore

Reviewed by Darin

Fix for these bugs:

<rdar://problem/3443296>: REGRESSION: pop-up menu gets focus, but once it has
focus doesn't work right
<rdar://problem/3444873>: Select widgets that use list views do not take part in tab order
<rdar://problem/3446306>: Text area form widgets do not accept DOM focus correctly
<rdar://problem/3446323>: Using keyboard to work popup button select form
widget causes a crash

The intention of this patch is to add keyboard navigation support for
HTML form select widgets. This includes the two visual representations
for these widgets: popup buttons and lists. Many keyboard, focus, and
tabbing fixes are included in this work, as indicated below.

  • khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::defaultEventHandler): Added. Submit form when return or enter key is pressed when focused on a select widget.
  • khtml/html/html_formimpl.h: Make HTMLSelectElementImpl a friend class of HTMLInputElementImpl. This is done so that an HTMLSelectElementImpl can call the private method which simulates a form submit. Also add declaration of defaultEventHandler function.
  • kwq/KWQButton.h: Clean up focusPolicy declaration.
  • kwq/KWQComboBox.h: Add focusPolicy declaration.
  • kwq/KWQComboBox.mm: (QComboBox::focusPolicy): Added. Widget will focus if full keyboard access is on. (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Now calls sendFakeEventsAfterWidgetTracking instead of doFakeMouseUpAfterWidgetTracking now that name has changed. (-[KWQPopUpButton becomeFirstResponder]): Added. Needed for setting focus correctly. (-[KWQPopUpButton resignFirstResponder]): Ditto. (-[KWQPopUpButton nextKeyView]): Added. Makes tabbing work correctly for this widget. (-[KWQPopUpButton previousKeyView]): Ditto. (-[KWQPopUpButton nextValidKeyView]): Ditto. (-[KWQPopUpButton previousValidKeyView]): Ditto.
  • kwq/KWQKHTMLPart.h: Change name of doFakeMouseUpAfterWidgetTracking to sendFakeEventsAfterWidgetTracking now that it handles key events as well.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): Name change as noted above. Also handles sending simulated key up events.
  • kwq/KWQLineEdit.h: (QLineEdit::checksDescendantsForFocus): Added. This is a big part of the fiz for <rdar://problem/3446306>.
  • kwq/KWQListBox.h: (QListBox::checksDescendantsForFocus): Ditto. Yes for this widget.
  • kwq/KWQListBox.mm: (QListBox::focusPolicy): Added. Widget will focus if full keyboard access is on. (-[KWQListBoxScrollView becomeFirstResponder]): Added. Needed for setting focus correctly. This sets the focus to its document view. (-[KWQTableView becomeFirstResponder]): Added. Needed for setting focus correctly. (-[KWQTableView resignFirstResponder]): Added. Needed for setting focus correctly. (-[KWQTableView nextKeyView]): Added. Makes tabbing work correctly for this widget. (-[KWQTableView previousKeyView]): Ditto. (-[KWQTableView nextValidKeyView]): Ditto. (-[KWQTableView previousValidKeyView]): Ditto. (-[KWQTableView _KWQ_setKeyboardFocusRingNeedsDisplay]): Added.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Other part of fix for <rdar://problem/3446306>. The recursion guards were bad and wrong. The checksDescendantsForFocus improvement prevents the erroneous recursion from happening.
  • kwq/KWQTextEdit.h: (QTextEdit::checksDescendantsForFocus): Added. Yes for this widget.
  • kwq/KWQWidget.h: (QWidget::checksDescendantsForFocus): Added. No by default.
  • kwq/KWQWidget.mm: (QWidget::hasFocus): Now uses checksDescendantsForFocus to perform proper checks for views that may have a subview which is first responder.
1:15 PM Changeset in webkit [5144] by hyatt
  • 9 edits in trunk/WebCore

Fix for 3363421, event handlers could be triggered for content outside an overflow:hidden
area. The layer checks that test for intersection/point containment need to only include
layers with overhanging floats if the element is overflow:visible.

Fix for 3366801, assignment to scrollLeft/Top of an overflow:hidden layer makes the layer
disappear. overflow:hidden blocks actually were never computing their scroll dimensions,
and so had bogus answers for those values.

Fix for 3366686, no reliable scrollHeight/Width reporting for overflow:hidden or
overflow:visible elements. The former was caused by the same bug as 3366801. The
latter was just me using the wrong method (clientWidth/Height instead of
overflowWidth/Height).

This patch also tightens the assignment to scrollLeft/Top to not do anything if you don't
have an overflow value other than visible.

Reviewed by darin

  • khtml/ecma/kjs_dom.cpp: (DOMNode::putValue):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::scrollToOffset): (RenderLayer::scrollWidth): (RenderLayer::scrollHeight): (RenderLayer::computeScrollDimensions): (RenderLayer::updateScrollInfoAfterLayout): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::scrollWidth): (RenderObject::scrollHeight):
  • khtml/rendering/render_object.h:
10:43 AM Changeset in webkit [5143] by darin
  • 3 edits in trunk/WebCore

Reviewed by Chris.

  • fixed some exceptions I was seeing with my recent text change
  • khtml/khtml_part.cpp: (KHTMLPart::text): Return an empty string for a null range rather than raising an exception. (KHTMLPart::selection): Return a null range rather than raising an exception if there is no selection.
8:49 AM Changeset in webkit [5142] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • removed code that mutates \n into a space so we can pass more W3C DOM Level 1 Core tests
  • khtml/rendering/bidi.cpp: (khtml::addRun): Treat \n as a space. (khtml::RenderBlock::computeHorizontalPositionsForLine): Treat \n as a space. (khtml::RenderBlock::findNextLineBreak): Treat \n outside <pre> as a space. Removed code that mutates the \n into a space.
  • khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): Treat \n outside <pre> as a space. (RenderText::calcMinMaxWidth): Treat \n outside <pre> as a space. Removed code that mutates the \n into a space. (RenderText::position): Detect a <br> with isBR instead of assuming a 1-character string with a \n in it is a <br>.

Oct 6, 2003:

9:43 PM Changeset in webkit [5141] by hyatt
  • 23 edits in trunk/WebCore

Several fixes preparing for the incremental repainting patch to be enabled.

(1) Make layers update their positions after layout instead of during layout or
during painting.

(2) Fix a regression from the overflow:hidden body quirk landing. Make sure repaint()
understands that quirk exists and avoids clipping when it shouldn't.

(3) Fix a regression from the scrollbar improvements. The vertical scrollbar repainted
on every layout.

(4) Make sure outside list bullets are repainted when a list item needs to repaint.

(5) A whole bunch of INCREMENTAL_REPAINTING code that isn't turned on yet.

Reviewed by kocienda

  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::reset): (KHTMLView::resetScrollBars): (KHTMLView::needsFullRepaint):
  • khtml/khtmlview.h:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): (khtml::RenderBlock::repaintFloatingDescendants): (khtml::RenderBlock::repaintObjectsBeforeLayout):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::computeAbsoluteRepaintRect): (RenderBox::repaintDuringLayoutIfMoved):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::layout):
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::hasOverhangingFloats):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): (khtml::RenderFlexibleBox::layoutHorizontalBox): (khtml::RenderFlexibleBox::layoutVerticalBox): (khtml::RenderFlexibleBox::placeChild):
  • khtml/rendering/render_flexbox.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::computeRepaintRects): (RenderLayer::updateLayerPositions): (RenderLayer::updateLayerPosition): (RenderLayer::checkScrollbarsAfterLayout): (RenderLayer::paintLayer): (RenderLayer::calculateClipRects): (RenderLayer::calculateRects):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::relativePositionOffset):
  • khtml/rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect):
  • khtml/rendering/render_list.h: (khtml::RenderListMarker::listImage):
  • khtml/rendering/render_object.cpp: (RenderObject::repaint): (RenderObject::repaintRectangle): (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::repaintDuringLayoutIfMoved): (RenderObject::repaintFloatingDescendants): (RenderObject::checkForRepaintDuringLayout): (RenderObject::repaintObjectsBeforeLayout): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::container):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget):
5:01 PM Changeset in webkit [5140] by darin
  • 7 edits in trunk/WebCore

Reviewed by Ken.

  • preparation for the upcoming whitespace patch; refactored some of the code that extracts text
  • khtml/khtml_part.h: Added text() member function.
  • khtml/khtml_part.cpp: (KHTMLPart::text): Added. Refactored from selectedText; takes a DOM::Range as a parameter. Also added code to change newlines to spaces when extracting text from the DOM. (KHTMLPart::selectedText): Now calls text(). (KHTMLPart::selection): Removed stray declaration.
  • kwq/KWQAccObject.mm: (-[KWQAccObject value]): Changed to call KHTMLPart::text.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Changed to call KHTMLPart::text instead of doing it ourselves.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Added code to change change '\n' newlines to spaces when extracting text from the DOM.
1:28 PM Changeset in webkit [5139] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3444255 - REGRESSION: www.aa.com crashes (innerHTML)
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Keep the fragment ref'd since the tokenizer will ref and deref it. Then turn TreeShared's evil against itself to get the fragment back in the floating 0-ref state.
  • khtml/html/html_elementimpl.h: Remove stray whitespace.
  • khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Initialize current to 0 in the other constructor too.
9:01 AM Changeset in webkit [5138] by darin
  • 1 edit in trunk/WebKit/ChangeLog

Fixed a newline.

8:50 AM Changeset in webkit [5137] by darin
  • 20 edits in trunk

JavaScriptCore:

  • kjs/create_hash_table: Remove stray semicolon.
  • kjs/array_object.lut.h:
  • kjs/date_object.lut.h:
  • kjs/lexer.lut.h:
  • kjs/math_object.lut.h:
  • kjs/number_object.lut.h:
  • kjs/string_object.lut.h: Regenerated.

WebCore:

  • khtml/ecma/kjs_css.lut.h:
  • khtml/ecma/kjs_dom.lut.h:
  • khtml/ecma/kjs_events.lut.h:
  • khtml/ecma/kjs_html.lut.h:
  • khtml/ecma/kjs_navigator.lut.h:
  • khtml/ecma/kjs_range.lut.h:
  • khtml/ecma/kjs_traversal.lut.h:
  • khtml/ecma/kjs_views.lut.h:
  • khtml/ecma/kjs_window.lut.h: Regenerated, without stray semicolon.
Note: See TracTimeline for information about the timeline view.