Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 10, 2003:

4:22 PM Changeset in webkit [5171] by hyatt

• 5 edits in trunk/WebCore

Beginning of work on border collapsing. This patch makes sure that cell spacing between cells is
ignored and that padding on tables is ignored. This ensures that there is no space between cells
or between the edges of cells and the border of the table itself.

Reviewed by john

• khtml/rendering/render_style.h: (khtml::RenderStyle::setBitDefaults):
• khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::layout):
• khtml/rendering/render_table.h: (khtml::RenderTable::collapseBorders): (khtml::RenderTable::bordersPaddingAndSpacing):

4:05 PM Changeset in webkit [5170] by hyatt

• 1 edit in trunk/LayoutTests/fast/block/basic/016.html

Update test to remove the padding from tables.

3:35 PM Changeset in webkit [5169] by mjs

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Fixed for Private change from a while back.

3:04 PM Changeset in webkit [5168] by hyatt

• 6 edits in trunk/WebKit

Patch to move widgets during layout instead of waiting until paint time.

Reviewed by darin

• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.h:

3:03 PM Changeset in webkit [5167] by hyatt

• 28 edits in trunk/WebCore

Fix for table regression 3449444, as well as a patch to support padding on tables and to stop
honoring borders on row groups (both of which are correct for the "separate" border model).

• khtml/rendering/render_table.cpp:

(RenderTable::layout):
(RenderTableSection::calcRowHeight):
(RenderTableSection::layoutRows):

• khtml/rendering/render_table.h: (khtml::RenderTable::bordersPaddingAndSpacing):
• khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): (FixedTableLayout::layout): (AutoTableLayout::calcMinMaxWidth): (AutoTableLayout::layout):

Reviewed by darin

11:40 AM Changeset in webkit [5166] by kocienda

• 7 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3440703>: Textarea form controls do not respect disabled attribute

• khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Check for disabled attribute.
• kwq/KWQTextArea.h:
• kwq/KWQTextArea.mm: (-[KWQTextArea setEnabled:]): Added. (-[KWQTextArea isEnabled]): Added. (-[KWQTextArea drawRect:]): Draws a disabled-looking bezel when disabled. (-[KWQTextAreaTextView becomeFirstResponder]): Return NO if disabled. (-[KWQTextAreaTextView mouseDown:]): Block events if disabled. (-[KWQTextAreaTextView keyDown:]): Ditto. (-[KWQTextAreaTextView keyUp:]): Ditto. (-[KWQTextAreaTextView setEnabled:]): Added. Pass value through to editable attribute on text view. (-[KWQTextAreaTextView isEnabled]): Added. (-[KWQTextAreaTextView drawRect:]): Set the text color to a disabled color when disabled.
• kwq/KWQTextEdit.h:
• kwq/KWQTextEdit.mm: (QTextEdit::isDisabled): Added. (QTextEdit::setDisabled): Added.

12:45 AM Changeset in webkit [5165] by mjs

• 3 edits in trunk/WebCore

• fixed 3449405 - REGRESSION: reproducible crash changing focus w/ button on page, e.g. on www.aa.com

More fallout from the exception blocking.

• kwq/KWQButton.mm: (QButton::focusPolicy): Don't return from exception block (caught by Darin).

Oct 9, 2003:

10:49 PM Changeset in webkit [5164] by darin

• 4 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3449280 -- REGRESSION: crash copying a selection that ends in a <br>

• khtml/rendering/render_br.h: Add checkSelectionPointIgnoringContinuations.
• khtml/rendering/render_br.cpp: (RenderBR::checkSelectionPointIgnoringContinuations): Override to never return an offset of 1. We can't use a character offset because the DOM doesn't know that we're implemented as a text object. So an offset of 1 turns into "after this element".

8:21 PM Changeset in webkit [5163] by mjs

• 3 edits in trunk/WebCore

• fixed crash I just added.

• kwq/KWQWidget.mm: (QWidget::setCursor): Move BLOCK_NS_EXCEPTIONS macros so you don't `break' out of the blocking code.

5:46 PM Changeset in webkit [5162] by rjw

• 3 edits in trunk/WebKit

Ensure that the autoscroll timer is always stopped if a mouse up event is lost.

Reviewed by John.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _startAutoscrollTimer:]): (-[WebHTMLView _stopAutoscrollTimer]): (-[WebHTMLView _autoscroll]): (-[WebHTMLView mouseDown:]):
• WebView.subproj/WebHTMLViewPrivate.h:

3:56 PM Changeset in webkit [5161] by mjs

• 11 edits in trunk/WebCore

Reviewed by Ken.

More Cocoa exception blocking work.

• kwq/KWQFrame.mm: (QFrame::setFrameStyle):
• kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::~QLineEdit): (QLineEdit::setEchoMode): (QLineEdit::setFont): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition): (QLineEdit::setAlignment):
• kwq/KWQListBox.mm: (QListBox::QListBox): (QListBox::~QListBox): (QListBox::count): (QListBox::clear): (QListBox::setSelectionMode): (QListBox::insertItem): (QListBox::insertGroupLabel): (QListBox::endBatchInsert): (QListBox::setSelected): (QListBox::isSelected): (QListBox::setEnabled): (QListBox::sizeForNumberOfLines): (QListBox::focusPolicy):
• kwq/KWQPushButton.mm: (QPushButton::QPushButton): (QPushButton::sizeHint): (QPushButton::baselinePosition): (QPushButton::dimensions):
• kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton): (QRadioButton::setChecked): (QRadioButton::isChecked): (QRadioButton::dimensions):
• kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): (:m_valueChanged): (QScrollBar::~QScrollBar): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QScrollBar::scrollbarHit):
• kwq/KWQScrollView.mm: (QScrollView::visibleWidth): (QScrollView::visibleHeight): (QScrollView::contentsWidth): (QScrollView::contentsHeight): (QScrollView::contentsX): (QScrollView::contentsY): (QScrollView::setContentsPos): (QScrollView::setVScrollBarMode): (QScrollView::setHScrollBarMode): (QScrollView::setScrollBarsMode): (QScrollView::vScrollBarMode): (QScrollView::hScrollBarMode): (QScrollView::hasVerticalScrollBar): (QScrollView::hasHorizontalScrollBar): (QScrollView::suppressScrollBars): (QScrollView::addChild): (QScrollView::removeChild): (QScrollView::resizeContents): (QScrollView::updateContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::setStaticBackground): (QScrollView::ensureVisible): (QScrollView::getDocumentView):
• kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setText): (QTextEdit::text): (QTextEdit::textWithHardLineBreaks): (QTextEdit::getCursorPosition): (QTextEdit::setCursorPosition): (QTextEdit::wordWrap): (QTextEdit::setWordWrap): (QTextEdit::isReadOnly): (QTextEdit::setReadOnly): (QTextEdit::selectAll): (QTextEdit::setFont): (QTextEdit::setAlignment): (QTextEdit::sizeWithColumnsAndRows):
• kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::~QWidget): (QWidget::setActiveWindow): (QWidget::setEnabled): (QWidget::isEnabled): (QWidget::frameGeometry): (QWidget::hasFocus): (QWidget::setFocus): (QWidget::focusPolicy): (QWidget::isVisible): (QWidget::setCursor): (QWidget::cursor): (QWidget::setFrameGeometry): (QWidget::mapFromGlobal): (QWidget::setView): (QWidget::getOuterView): (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::disableFlushDrawing): (QWidget::enableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::paint): (QWidget::sendConsumedMouseUp):

3:20 PM Changeset in webkit [5160] by hyatt

• 3 edits in trunk/WebCore

Stop printing extra spaces before list items. Fixes ordered lists with list-style-position: inside.

Reviewed by mjs

• khtml/rendering/render_list.cpp:

2:59 PM Changeset in webkit [5159] by hyatt

• 3 edits in trunk/WebCore

Make definition of kMin and kMax match the KHTML trunk. Someone still needs to eliminate uses of QMIN
and QMAX from the code.

• kwq/KWQDef.h: (kMin): (kMax):

1:41 PM Changeset in webkit [5158] by cblu

• 20 edits in trunk

WebCore:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

Reviewed by rjw.

• khtml/ecma/kjs_navigator.cpp: (PluginBase::refresh): new (PluginsFunc::tryCall): call refresh
• kwq/KWQKConfigBase.h:
• kwq/KWQKConfigBase.mm: (RefreshPlugins): new
• kwq/WebCoreViewFactory.h:

WebKit:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

Reviewed by rjw.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): release the plug-in object
• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): store the last mod date (-[WebBasePluginPackage dealloc]): release the last mod date (-[WebBasePluginPackage lastModifiedDate]): new (-[WebBasePluginPackage isEqual:]): new (-[WebBasePluginPackage hash]): new
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): convert the NPP_Shutdown proc pointer so that we can use it later (-[WebNetscapePluginPackage unload]): added log message
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): tweak (-[WebPluginDatabase plugins]): tweak (-[WebPluginDatabase init]): call refresh (-[WebPluginDatabase refresh]): new (-[WebPluginDatabase loadPluginIfNeededForMIMEType:]): tweak
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]): new
• WebView.subproj/WebControllerSets.h:
• WebView.subproj/WebControllerSets.m: (+[WebViewSets makeWebViewsPerformSelector:]): new
• WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): new
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebView.m: (-[WebView _reloadForPluginChanges]): new
• WebView.subproj/WebViewPrivate.h:

1:15 PM Changeset in webkit [5157] by vicki

• 3 edits in trunk

tree is open for Safari-110!

1:12 PM Changeset in webkit [5156]

• 3 copies in tags/Safari-109

This commit was manufactured by cvs2svn to create tag 'Safari-109'.

1:12 PM Changeset in webkit [5155] by vicki

• 8 edits in trunk

Safari-109 stamp

12:45 AM Changeset in webkit [5154]

• 7 copies
  2 deletes in tags/WebCore-106-tarball

This commit was manufactured by cvs2svn to create tag
'WebCore-106-tarball'.

12:45 AM Changeset in webkit [5153] by mjs

• 1 edit in branches/WebCore-106-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

WebCore-106 tarball.

Oct 8, 2003:

6:35 PM Changeset in webkit [5152] by hyatt

• 2 adds in trunk/LayoutTests/fast/block/positioning

Adding layout test for section 10.3.7 of the CSS2.1 spec.

6:34 PM Changeset in webkit [5151] by hyatt

• 3 edits in trunk/WebCore

Fix for 3436723, the shrink-to-fit algorithm for positioned elements did not match
the algorithm specified in section 10.3.7 of the CSS2.1 specification. The min-width
of the element was not being taken into account like it should have been.

Reviewed by mjs

• khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):

5:45 PM Changeset in webkit [5150] by hyatt

• 4 edits in trunk/WebCore

Implement min/max width and min/max height support for replaced elements.

Reviewed by ken

• khtml/rendering/render_box.cpp: (RenderBox::calcReplacedWidth): (RenderBox::calcReplacedWidthUsing): (RenderBox::calcReplacedHeight): (RenderBox::calcReplacedHeightUsing): (RenderBox::availableHeight): (RenderBox::availableHeightUsing):
• khtml/rendering/render_box.h:

4:27 PM Changeset in webkit [5149] by mjs

• 3 edits in trunk/WebCore

Fix development build.

• kwq/KWQExceptions.h: Correct assertion args.

2:23 PM Changeset in webkit [5148]

• 1 copy
  322 deletes in branches/unlabeled-1.39.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.39.4'.

2:23 PM Changeset in webkit [5147] by mjs

• 23 edits
  1 add in trunk/WebCore

Reviewed by Ken.

Start on blocking Cocoa exceptions when calling ObjC from C++ to
avoid unreproducible crashes when this happens.

• kwq/KWQExceptions.h: Added. Helper macros for exception blocking.
• WebCore.pbproj/project.pbxproj: Add new header

In all these files, block exceptions when calling ObjC from C++,
or explain why not.

• kwq/KWQAccObjectCache.mm:
• kwq/KWQApplication.mm:
• kwq/KWQButton.mm: (QButton::QButton): (QButton::~QButton): (QButton::setText): (QButton::text): (QButton::clicked): (QButton::simulateClick): (QButton::setFont): (QButton::focusPolicy):
• kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox): (QCheckBox::setChecked): (QCheckBox::isChecked): (QCheckBox::dimensions):
• kwq/KWQColor.mm:
• kwq/KWQComboBox.mm: (QComboBox::QComboBox): (QComboBox::~QComboBox): (QComboBox::insertItem): (QComboBox::sizeHint): (QComboBox::setCurrentItem): (QComboBox::updateCurrentItem): (QComboBox::setFont): (QComboBox::dimensions):
• kwq/KWQCursor.mm:
• kwq/KWQFile.mm:
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::baselinePosition): (KWQFileButton::filenameChanged):
• kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): (KWQKCookieJar::setCookie): (KWQKCookieJar::cookieEnabled):
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): (KHTMLPartBrowserExtension::setIconURL): (KHTMLPartBrowserExtension::setTypedIconURL):
• kwq/KWQKHistoryProvider.mm: (KParts::HistoryProvider::contains):
• kwq/KWQKPartsBrowserInterface.mm: (KParts::BrowserInterface::callMethod):
• kwq/KWQKStandardDirs.mm:
• kwq/KWQKURL.mm:
• kwq/KWQKWinModule.mm: (KWinModule::workArea):
• kwq/KWQObject.mm:
• kwq/KWQString.mm: (QString::getNSString):
• kwq/KWQTimer.mm:
• kwq/KWQWindowWidget.mm:

Oct 7, 2003:

6:49 PM Changeset in webkit [5146] by hyatt

• 5 edits in trunk/WebCore

Fix for link dragging regression in the titles of links. More accessibility
improvements.

Reviewed by darin

• khtml/khtml_part.cpp: (KHTMLPart::text):
• kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject helpText]): (-[KWQAccObject textUnderElement]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeValue:]):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

3:23 PM Changeset in webkit [5145] by kocienda

• 19 edits in trunk/WebCore

Reviewed by Darin

Fix for these bugs:

<rdar://problem/3443296>: REGRESSION: pop-up menu gets focus, but once it has
focus doesn't work right
<rdar://problem/3444873>: Select widgets that use list views do not take part in tab order
<rdar://problem/3446306>: Text area form widgets do not accept DOM focus correctly
<rdar://problem/3446323>: Using keyboard to work popup button select form
widget causes a crash

The intention of this patch is to add keyboard navigation support for
HTML form select widgets. This includes the two visual representations
for these widgets: popup buttons and lists. Many keyboard, focus, and
tabbing fixes are included in this work, as indicated below.

• khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::defaultEventHandler): Added. Submit form when return or enter key is pressed when focused on a select widget.
• khtml/html/html_formimpl.h: Make HTMLSelectElementImpl a friend class of HTMLInputElementImpl. This is done so that an HTMLSelectElementImpl can call the private method which simulates a form submit. Also add declaration of defaultEventHandler function.
• kwq/KWQButton.h: Clean up focusPolicy declaration.
• kwq/KWQComboBox.h: Add focusPolicy declaration.
• kwq/KWQComboBox.mm: (QComboBox::focusPolicy): Added. Widget will focus if full keyboard access is on. (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Now calls sendFakeEventsAfterWidgetTracking instead of doFakeMouseUpAfterWidgetTracking now that name has changed. (-[KWQPopUpButton becomeFirstResponder]): Added. Needed for setting focus correctly. (-[KWQPopUpButton resignFirstResponder]): Ditto. (-[KWQPopUpButton nextKeyView]): Added. Makes tabbing work correctly for this widget. (-[KWQPopUpButton previousKeyView]): Ditto. (-[KWQPopUpButton nextValidKeyView]): Ditto. (-[KWQPopUpButton previousValidKeyView]): Ditto.
• kwq/KWQKHTMLPart.h: Change name of doFakeMouseUpAfterWidgetTracking to sendFakeEventsAfterWidgetTracking now that it handles key events as well.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): Name change as noted above. Also handles sending simulated key up events.
• kwq/KWQLineEdit.h: (QLineEdit::checksDescendantsForFocus): Added. This is a big part of the fiz for <rdar://problem/3446306>.
• kwq/KWQListBox.h: (QListBox::checksDescendantsForFocus): Ditto. Yes for this widget.
• kwq/KWQListBox.mm: (QListBox::focusPolicy): Added. Widget will focus if full keyboard access is on. (-[KWQListBoxScrollView becomeFirstResponder]): Added. Needed for setting focus correctly. This sets the focus to its document view. (-[KWQTableView becomeFirstResponder]): Added. Needed for setting focus correctly. (-[KWQTableView resignFirstResponder]): Added. Needed for setting focus correctly. (-[KWQTableView nextKeyView]): Added. Makes tabbing work correctly for this widget. (-[KWQTableView previousKeyView]): Ditto. (-[KWQTableView nextValidKeyView]): Ditto. (-[KWQTableView previousValidKeyView]): Ditto. (-[KWQTableView _KWQ_setKeyboardFocusRingNeedsDisplay]): Added.
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Other part of fix for <rdar://problem/3446306>. The recursion guards were bad and wrong. The checksDescendantsForFocus improvement prevents the erroneous recursion from happening.
• kwq/KWQTextEdit.h: (QTextEdit::checksDescendantsForFocus): Added. Yes for this widget.
• kwq/KWQWidget.h: (QWidget::checksDescendantsForFocus): Added. No by default.
• kwq/KWQWidget.mm: (QWidget::hasFocus): Now uses checksDescendantsForFocus to perform proper checks for views that may have a subview which is first responder.

1:15 PM Changeset in webkit [5144] by hyatt

• 9 edits in trunk/WebCore

Fix for 3363421, event handlers could be triggered for content outside an overflow:hidden
area. The layer checks that test for intersection/point containment need to only include
layers with overhanging floats if the element is overflow:visible.

Fix for 3366801, assignment to scrollLeft/Top of an overflow:hidden layer makes the layer
disappear. overflow:hidden blocks actually were never computing their scroll dimensions,
and so had bogus answers for those values.

Fix for 3366686, no reliable scrollHeight/Width reporting for overflow:hidden or
overflow:visible elements. The former was caused by the same bug as 3366801. The
latter was just me using the wrong method (clientWidth/Height instead of
overflowWidth/Height).

This patch also tightens the assignment to scrollLeft/Top to not do anything if you don't
have an overflow value other than visible.

Reviewed by darin

• khtml/ecma/kjs_dom.cpp: (DOMNode::putValue):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
• khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::scrollToOffset): (RenderLayer::scrollWidth): (RenderLayer::scrollHeight): (RenderLayer::computeScrollDimensions): (RenderLayer::updateScrollInfoAfterLayout): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::scrollWidth): (RenderObject::scrollHeight):
• khtml/rendering/render_object.h:

10:43 AM Changeset in webkit [5143] by darin

• 3 edits in trunk/WebCore

Reviewed by Chris.

• fixed some exceptions I was seeing with my recent text change

• khtml/khtml_part.cpp: (KHTMLPart::text): Return an empty string for a null range rather than raising an exception. (KHTMLPart::selection): Return a null range rather than raising an exception if there is no selection.

8:49 AM Changeset in webkit [5142] by darin

• 4 edits in trunk/WebCore

Reviewed by Dave.

• removed code that mutates \n into a space so we can pass more W3C DOM Level 1 Core tests

• khtml/rendering/bidi.cpp: (khtml::addRun): Treat \n as a space. (khtml::RenderBlock::computeHorizontalPositionsForLine): Treat \n as a space. (khtml::RenderBlock::findNextLineBreak): Treat \n outside <pre> as a space. Removed code that mutates the \n into a space.

• khtml/rendering/render_text.cpp: (RenderText::trimmedMinMaxWidth): Treat \n outside <pre> as a space. (RenderText::calcMinMaxWidth): Treat \n outside <pre> as a space. Removed code that mutates the \n into a space. (RenderText::position): Detect a <br> with isBR instead of assuming a 1-character string with a \n in it is a <br>.