Context Navigation

← Previous Period
Next Period →

Timeline

Oct 13, 2003:

6:56 PM Changeset in webkit [5178] by hyatt

3 edits in trunk/WebCore

Fix for a small-caps rendering error when used in conjunction with ::first-line. Always update
the Font variable even when QFonts are the same, since small-caps is not stored in QFonts.

Reviewed by rjw

khtml/rendering/render_text.cpp: (RenderText::paintObject):

5:52 PM Changeset in webkit [5177] by rjw

6 edits in trunk

Updated layout tests actuals to reflect implementation of small-caps style.

layout-tests/css1/font_properties/font-expected.txt:
layout-tests/css1/font_properties/font_variant-expected.txt:
layout-tests/css1/pseudo/firstline-expected.txt:
layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:

5:44 PM Changeset in webkit [5176] by rjw

4 edits in trunk/WebCore

Added support for small-caps.

Reviewed by John.

khtml/rendering/font.h: (khtml::Font::isSmallCaps):
khtml/rendering/render_text.cpp: (RenderText::shouldUseMonospaceCache):

5:39 PM Changeset in webkit [5175] by rjw

4 edits in trunk/WebKit

Added support for small-caps.

Reworked drawing and measuring to use new iterators. Position checking was already using
the new iterator code, but I was reluctant to switch the mainline drawing and measuring
code over to the new approach until now.

Lots of other code cleanup.

Reviewed by John.

Misc.subproj/WebUnicode.m: (initializeCharacterShapeIterator):
WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer shouldBufferTextDrawing]): (+[WebTextRenderer initialize]): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer widthForString:]): (-[WebTextRenderer ascent]): (-[WebTextRenderer descent]): (-[WebTextRenderer lineSpacing]): (-[WebTextRenderer xHeight]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer floatWidthForRun:style:widths:]): (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]): (-[WebTextRenderer drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer pointToOffset:style:position:reversed:]): (-[WebTextRenderer _setIsSmallCapsRenderer:]): (-[WebTextRenderer _isSmallCapsRenderer]): (-[WebTextRenderer _smallCapsRenderer]): (-[WebTextRenderer _smallCapsFont]): (-[WebTextRenderer _substituteFontForString:families:]): (-[WebTextRenderer _substituteFontForCharacters:length:families:]): (-[WebTextRenderer _convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer _setupFont]): (_drawGlyphs): (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer _floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _updateGlyphEntryForCharacter:glyphID:font:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]): (freeWidthMap): (freeGlyphMap): (glyphForCharacter): (glyphForUnicodeCharacter): (mapForSubstituteFont): (widthFromMap): (widthForGlyph): (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (ceilCurrentWidth): (widthForNextCharacter): (fillStyleWithAttributes): (findLengthOfCharacterCluster): (shouldUseATSU): (isControlCharacter): (isAlternateSpace): (isSpace): (fontContainsString): (GetScratchUniCharString): (toUpper): (isUpper):

Oct 12, 2003:

8:32 PM Changeset in webkit [5174] by darin

4 edits in trunk

layout-tests/fast/js/date-parse-test.html: Fixed a couple of silly mistakes.

kwq/character-sets.txt: New version of file from www.iana.org. No substantive change. Also, now that we don't use MIB numbers any more, I could leave out our one local change, the MIB number we added for ISO-10646-J-1.

7:13 PM Changeset in webkit [5173] by darin

5 adds in trunk/JavaScriptCore/tests/mozilla

A few more files from the Mozilla tests. Soon I will make it so we can
run the tests.

7:05 PM Changeset in webkit [5172] by darin

1218 adds in trunk/JavaScriptCore/tests

First commit of Mozilla JavaScript tests.

Oct 10, 2003:

4:22 PM Changeset in webkit [5171] by hyatt

5 edits in trunk/WebCore

Beginning of work on border collapsing. This patch makes sure that cell spacing between cells is
ignored and that padding on tables is ignored. This ensures that there is no space between cells
or between the edges of cells and the border of the table itself.

Reviewed by john

khtml/rendering/render_style.h: (khtml::RenderStyle::setBitDefaults):
khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::layout):
khtml/rendering/render_table.h: (khtml::RenderTable::collapseBorders): (khtml::RenderTable::bordersPaddingAndSpacing):

4:05 PM Changeset in webkit [5170] by hyatt

1 edit in trunk/LayoutTests/fast/block/basic/016.html

Update test to remove the padding from tables.

3:35 PM Changeset in webkit [5169] by mjs

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Fixed for Private change from a while back.

3:04 PM Changeset in webkit [5168] by hyatt

6 edits in trunk/WebKit

Patch to move widgets during layout instead of waiting until paint time.

Reviewed by darin

WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
WebView.subproj/WebHTMLView.m:
WebView.subproj/WebHTMLViewPrivate.h:

3:03 PM Changeset in webkit [5167] by hyatt

28 edits in trunk/WebCore

Fix for table regression 3449444, as well as a patch to support padding on tables and to stop
honoring borders on row groups (both of which are correct for the "separate" border model).

khtml/rendering/render_table.cpp:

(RenderTable::layout):
(RenderTableSection::calcRowHeight):
(RenderTableSection::layoutRows):

khtml/rendering/render_table.h: (khtml::RenderTable::bordersPaddingAndSpacing):
khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): (FixedTableLayout::layout): (AutoTableLayout::calcMinMaxWidth): (AutoTableLayout::layout):

Reviewed by darin

11:40 AM Changeset in webkit [5166] by kocienda

7 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3440703>: Textarea form controls do not respect disabled attribute

khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Check for disabled attribute.
kwq/KWQTextArea.h:
kwq/KWQTextArea.mm: (-[KWQTextArea setEnabled:]): Added. (-[KWQTextArea isEnabled]): Added. (-[KWQTextArea drawRect:]): Draws a disabled-looking bezel when disabled. (-[KWQTextAreaTextView becomeFirstResponder]): Return NO if disabled. (-[KWQTextAreaTextView mouseDown:]): Block events if disabled. (-[KWQTextAreaTextView keyDown:]): Ditto. (-[KWQTextAreaTextView keyUp:]): Ditto. (-[KWQTextAreaTextView setEnabled:]): Added. Pass value through to editable attribute on text view. (-[KWQTextAreaTextView isEnabled]): Added. (-[KWQTextAreaTextView drawRect:]): Set the text color to a disabled color when disabled.
kwq/KWQTextEdit.h:
kwq/KWQTextEdit.mm: (QTextEdit::isDisabled): Added. (QTextEdit::setDisabled): Added.

12:45 AM Changeset in webkit [5165] by mjs

3 edits in trunk/WebCore

fixed 3449405 - REGRESSION: reproducible crash changing focus w/ button on page, e.g. on www.aa.com

More fallout from the exception blocking.

kwq/KWQButton.mm: (QButton::focusPolicy): Don't return from exception block (caught by Darin).

Oct 9, 2003:

10:49 PM Changeset in webkit [5164] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3449280 -- REGRESSION: crash copying a selection that ends in a <br>

khtml/rendering/render_br.h: Add checkSelectionPointIgnoringContinuations.
khtml/rendering/render_br.cpp: (RenderBR::checkSelectionPointIgnoringContinuations): Override to never return an offset of 1. We can't use a character offset because the DOM doesn't know that we're implemented as a text object. So an offset of 1 turns into "after this element".

8:21 PM Changeset in webkit [5163] by mjs

3 edits in trunk/WebCore

fixed crash I just added.

kwq/KWQWidget.mm: (QWidget::setCursor): Move BLOCK_NS_EXCEPTIONS macros so you don't `break' out of the blocking code.

5:46 PM Changeset in webkit [5162] by rjw

3 edits in trunk/WebKit

Ensure that the autoscroll timer is always stopped if a mouse up event is lost.

Reviewed by John.

WebView.subproj/WebHTMLView.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _startAutoscrollTimer:]): (-[WebHTMLView _stopAutoscrollTimer]): (-[WebHTMLView _autoscroll]): (-[WebHTMLView mouseDown:]):
WebView.subproj/WebHTMLViewPrivate.h:

3:56 PM Changeset in webkit [5161] by mjs

11 edits in trunk/WebCore

Reviewed by Ken.

More Cocoa exception blocking work.

kwq/KWQFrame.mm: (QFrame::setFrameStyle):
kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::~QLineEdit): (QLineEdit::setEchoMode): (QLineEdit::setFont): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition): (QLineEdit::setAlignment):
kwq/KWQListBox.mm: (QListBox::QListBox): (QListBox::~QListBox): (QListBox::count): (QListBox::clear): (QListBox::setSelectionMode): (QListBox::insertItem): (QListBox::insertGroupLabel): (QListBox::endBatchInsert): (QListBox::setSelected): (QListBox::isSelected): (QListBox::setEnabled): (QListBox::sizeForNumberOfLines): (QListBox::focusPolicy):
kwq/KWQPushButton.mm: (QPushButton::QPushButton): (QPushButton::sizeHint): (QPushButton::baselinePosition): (QPushButton::dimensions):
kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton): (QRadioButton::setChecked): (QRadioButton::isChecked): (QRadioButton::dimensions):
kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): (:m_valueChanged): (QScrollBar::~QScrollBar): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QScrollBar::scrollbarHit):
kwq/KWQScrollView.mm: (QScrollView::visibleWidth): (QScrollView::visibleHeight): (QScrollView::contentsWidth): (QScrollView::contentsHeight): (QScrollView::contentsX): (QScrollView::contentsY): (QScrollView::setContentsPos): (QScrollView::setVScrollBarMode): (QScrollView::setHScrollBarMode): (QScrollView::setScrollBarsMode): (QScrollView::vScrollBarMode): (QScrollView::hScrollBarMode): (QScrollView::hasVerticalScrollBar): (QScrollView::hasHorizontalScrollBar): (QScrollView::suppressScrollBars): (QScrollView::addChild): (QScrollView::removeChild): (QScrollView::resizeContents): (QScrollView::updateContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::setStaticBackground): (QScrollView::ensureVisible): (QScrollView::getDocumentView):
kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setText): (QTextEdit::text): (QTextEdit::textWithHardLineBreaks): (QTextEdit::getCursorPosition): (QTextEdit::setCursorPosition): (QTextEdit::wordWrap): (QTextEdit::setWordWrap): (QTextEdit::isReadOnly): (QTextEdit::setReadOnly): (QTextEdit::selectAll): (QTextEdit::setFont): (QTextEdit::setAlignment): (QTextEdit::sizeWithColumnsAndRows):
kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::~QWidget): (QWidget::setActiveWindow): (QWidget::setEnabled): (QWidget::isEnabled): (QWidget::frameGeometry): (QWidget::hasFocus): (QWidget::setFocus): (QWidget::focusPolicy): (QWidget::isVisible): (QWidget::setCursor): (QWidget::cursor): (QWidget::setFrameGeometry): (QWidget::mapFromGlobal): (QWidget::setView): (QWidget::getOuterView): (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::disableFlushDrawing): (QWidget::enableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::paint): (QWidget::sendConsumedMouseUp):

3:20 PM Changeset in webkit [5160] by hyatt

3 edits in trunk/WebCore

Stop printing extra spaces before list items. Fixes ordered lists with list-style-position: inside.

Reviewed by mjs

khtml/rendering/render_list.cpp:

2:59 PM Changeset in webkit [5159] by hyatt

3 edits in trunk/WebCore

Make definition of kMin and kMax match the KHTML trunk. Someone still needs to eliminate uses of QMIN
and QMAX from the code.

kwq/KWQDef.h: (kMin): (kMax):

1:41 PM Changeset in webkit [5158] by cblu

20 edits in trunk

WebCore:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

Reviewed by rjw.

khtml/ecma/kjs_navigator.cpp: (PluginBase::refresh): new (PluginsFunc::tryCall): call refresh
kwq/KWQKConfigBase.h:
kwq/KWQKConfigBase.mm: (RefreshPlugins): new
kwq/WebCoreViewFactory.h:

WebKit:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

Reviewed by rjw.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): release the plug-in object
Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): store the last mod date (-[WebBasePluginPackage dealloc]): release the last mod date (-[WebBasePluginPackage lastModifiedDate]): new (-[WebBasePluginPackage isEqual:]): new (-[WebBasePluginPackage hash]): new
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): convert the NPP_Shutdown proc pointer so that we can use it later (-[WebNetscapePluginPackage unload]): added log message
Plugins.subproj/WebPluginDatabase.h:
Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): tweak (-[WebPluginDatabase plugins]): tweak (-[WebPluginDatabase init]): call refresh (-[WebPluginDatabase refresh]): new (-[WebPluginDatabase loadPluginIfNeededForMIMEType:]): tweak
WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]): new
WebView.subproj/WebControllerSets.h:
WebView.subproj/WebControllerSets.m: (+[WebViewSets makeWebViewsPerformSelector:]): new
WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): new
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebView.m: (-[WebView _reloadForPluginChanges]): new
WebView.subproj/WebViewPrivate.h:

1:15 PM Changeset in webkit [5157] by vicki