Timeline



Oct 14, 2003:

6:32 PM Changeset in webkit [5184] by rjw
  • 5 edits in trunk/WebKit

WebBrowser:

Use WebKit estimated progress scheme. I've left the old
scheme in place. You can get the old behavior by turning off the
"Use Alternate Progress" item in the debug menu. The new code is
much simpler than the old code. Once we decide to move ahead with the
new scheme we can do a serious root canal.

Reviewed by Chris.

  • BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): (-[BrowserWebView dealloc]): (-[BrowserWebView isLoading]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController updateProgressBar]): (-[BrowserWindowController newUpdateProgressBar]): (-[BrowserWindowController clearProgressBar]):
  • Debug/DebugUtilities.h:
  • Debug/DebugUtilities.m: (-[DebugUtilities init]): (-[DebugUtilities useAlternateProgress]): (-[DebugUtilities setUseAlternateProgress:]): (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument toggleAlternateProgress:]):
  • TextFieldWithControls.m: (-[TextFieldWithControls setProgressBarValue:]):

WebKit:

Added logging for estimated progress.

Added a time delta to the throttler, so we now send notifications
if a delta amount has been exceeded OR a delta between notifications
has been exceeded.

Reviewed by Chris.

  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • WebView.subproj/WebView.m: (-[WebViewPrivate init]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]):
  • WebView.subproj/WebViewPrivate.h:
12:47 PM Changeset in webkit [5183] by hyatt
  • 3 edits in trunk/WebCore

Fix an obvious little typo with smallCaps inheritance. Richard reviewed.

Also merge in Dirk's patch to fix a crasher caused by an obvious deref mistake.

Reviewed by rjw and nobody

  • khtml/css/cssstyleselector.cpp: (khtml::convertToLength): (khtml::CSSStyleSelector::applyRule):
9:01 AM Changeset in webkit [5182] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3450449>: assertion failure in WebBridge
_retrieveKeyboardUIModeFromPreferences

Can't assert that the preference always exists and is valid as I
thought you could. This could just mean that the a preference for full
keyboard access has not been specified by the user yet. If this is so,
just return the default keyboard access mode.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:])
8:36 AM Changeset in webkit [5181]
  • 1 copy
    74 deletes in branches/unlabeled-1.8.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.8.4'.

8:36 AM Changeset in webkit [5180]
  • 1 copy
    41 deletes in branches/unlabeled-1.27.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.27.4'.

8:36 AM Changeset in webkit [5179] by kocienda
  • 20 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/dom/dom_misc.h: Declared TristateFlag enum used to implement inheritance behavior for inheritable attributes like designMode.
  • khtml/dom/html_document.cpp: (HTMLDocument::designMode): Added getter. (HTMLDocument::setDesignMode): Added setter.
  • khtml/dom/html_document.h: Added declarations for designMode getter and setter.
  • khtml/dom/html_element.cpp: (HTMLElement::isContentEditable): Added convenience. (HTMLElement::contentEditable): Added getter. (HTMLElement::setContentEditable): Added setter.
  • khtml/dom/html_element.h: Added declarations for contentEditable accessors.
  • khtml/ecma/kjs_html.cpp: Added js support for contentEditable and designMode. (KJS::HTMLDocument::tryGet) (KJS::HTMLDocument::putValue) (KJS::HTMLElement::getValueProperty) (KJS::HTMLElement::putValue)
  • khtml/ecma/kjs_html.h: (KJS::HTMLDocument::): Added DesignMode to attribuute enum. (KJS::HTMLElement::): Added ContentEditable to attribute enum.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::designMode): Added getter. (HTMLDocumentImpl::setDesignMode): Added setter.
  • khtml/html/html_documentimpl.h: Declared designMode accessors.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::parseAttribute): Added support for contentEditable. (HTMLElementImpl::isContentEditable): Added. Implements inheritance feature for this attribute. (HTMLElementImpl::contentEditable): Getter for contentEditable attribute. (HTMLElementImpl::setContentEditable): Setter for contentEditable attribute.
  • khtml/html/html_elementimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::setEditMode): Added. (KHTMLPart::editMode): Added. Implements inheritance behavior for attribute. (KHTMLPart::inEditMode): Helper that calls on editMode function. (KHTMLPart::parentPart): Made const.
  • khtml/khtml_part.h: Rolled in a couple of typo fixes. Added declarations for the changes made in the implementation file.
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): Declared editMode flag. Also added support for editMode flag in initializers and copy function.
  • khtml/misc/htmlattrs.in: Added contentEditable as an attribute name.

Oct 13, 2003:

6:56 PM Changeset in webkit [5178] by hyatt
  • 3 edits in trunk/WebCore

Fix for a small-caps rendering error when used in conjunction with ::first-line. Always update
the Font variable even when QFonts are the same, since small-caps is not stored in QFonts.

Reviewed by rjw

  • khtml/rendering/render_text.cpp: (RenderText::paintObject):
5:52 PM Changeset in webkit [5177] by rjw
  • 6 edits in trunk

Updated layout tests actuals to reflect implementation of small-caps style.

  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_variant-expected.txt:
  • layout-tests/css1/pseudo/firstline-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
5:44 PM Changeset in webkit [5176] by rjw
  • 4 edits in trunk/WebCore

Added support for small-caps.

Reviewed by John.

  • khtml/rendering/font.h: (khtml::Font::isSmallCaps):
  • khtml/rendering/render_text.cpp: (RenderText::shouldUseMonospaceCache):
5:39 PM Changeset in webkit [5175] by rjw
  • 4 edits in trunk/WebKit

Added support for small-caps.

Reworked drawing and measuring to use new iterators. Position checking was already using
the new iterator code, but I was reluctant to switch the mainline drawing and measuring
code over to the new approach until now.

Lots of other code cleanup.

Reviewed by John.

  • Misc.subproj/WebUnicode.m: (initializeCharacterShapeIterator):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer shouldBufferTextDrawing]): (+[WebTextRenderer initialize]): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer widthForString:]): (-[WebTextRenderer ascent]): (-[WebTextRenderer descent]): (-[WebTextRenderer lineSpacing]): (-[WebTextRenderer xHeight]): (-[WebTextRenderer drawRun:style:atPoint:]): (-[WebTextRenderer floatWidthForRun:style:widths:]): (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]): (-[WebTextRenderer drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer pointToOffset:style:position:reversed:]): (-[WebTextRenderer _setIsSmallCapsRenderer:]): (-[WebTextRenderer _isSmallCapsRenderer]): (-[WebTextRenderer _smallCapsRenderer]): (-[WebTextRenderer _smallCapsFont]): (-[WebTextRenderer _substituteFontForString:families:]): (-[WebTextRenderer _substituteFontForCharacters:length:families:]): (-[WebTextRenderer _convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer _setupFont]): (_drawGlyphs): (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _CG_drawRun:style:atPoint:]): (-[WebTextRenderer _floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _updateGlyphEntryForCharacter:glyphID:font:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_floatWidthForRun:style:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]): (freeWidthMap): (freeGlyphMap): (glyphForCharacter): (glyphForUnicodeCharacter): (mapForSubstituteFont): (widthFromMap): (widthForGlyph): (initializeCharacterWidthIterator): (widthAndGlyphForSurrogate): (ceilCurrentWidth): (widthForNextCharacter): (fillStyleWithAttributes): (findLengthOfCharacterCluster): (shouldUseATSU): (isControlCharacter): (isAlternateSpace): (isSpace): (fontContainsString): (GetScratchUniCharString): (toUpper): (isUpper):

Oct 12, 2003:

8:32 PM Changeset in webkit [5174] by darin
  • 4 edits in trunk
  • layout-tests/fast/js/date-parse-test.html: Fixed a couple of silly mistakes.
  • kwq/character-sets.txt: New version of file from www.iana.org. No substantive change. Also, now that we don't use MIB numbers any more, I could leave out our one local change, the MIB number we added for ISO-10646-J-1.
7:13 PM Changeset in webkit [5173] by darin
  • 5 adds in trunk/JavaScriptCore/tests/mozilla

A few more files from the Mozilla tests. Soon I will make it so we can
run the tests.

7:05 PM Changeset in webkit [5172] by darin
  • 1218 adds in trunk/JavaScriptCore/tests

First commit of Mozilla JavaScript tests.

Oct 10, 2003:

4:22 PM Changeset in webkit [5171] by hyatt
  • 5 edits in trunk/WebCore

Beginning of work on border collapsing. This patch makes sure that cell spacing between cells is
ignored and that padding on tables is ignored. This ensures that there is no space between cells
or between the edges of cells and the border of the table itself.

Reviewed by john

  • khtml/rendering/render_style.h: (khtml::RenderStyle::setBitDefaults):
  • khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::layout):
  • khtml/rendering/render_table.h: (khtml::RenderTable::collapseBorders): (khtml::RenderTable::bordersPaddingAndSpacing):
4:05 PM Changeset in webkit [5170] by hyatt
  • 1 edit in trunk/LayoutTests/fast/block/basic/016.html

Update test to remove the padding from tables.

3:35 PM Changeset in webkit [5169] by mjs
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Fixed for Private change from a while back.
3:04 PM Changeset in webkit [5168] by hyatt
  • 6 edits in trunk/WebKit

Patch to move widgets during layout instead of waiting until paint time.

Reviewed by darin

  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebHTMLViewPrivate.h:
3:03 PM Changeset in webkit [5167] by hyatt
  • 28 edits in trunk/WebCore

Fix for table regression 3449444, as well as a patch to support padding on tables and to stop
honoring borders on row groups (both of which are correct for the "separate" border model).

  • khtml/rendering/render_table.cpp:

(RenderTable::layout):
(RenderTableSection::calcRowHeight):
(RenderTableSection::layoutRows):

  • khtml/rendering/render_table.h: (khtml::RenderTable::bordersPaddingAndSpacing):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): (FixedTableLayout::layout): (AutoTableLayout::calcMinMaxWidth): (AutoTableLayout::layout):

Reviewed by darin

11:40 AM Changeset in webkit [5166] by kocienda
  • 7 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3440703>: Textarea form controls do not respect disabled attribute

  • khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Check for disabled attribute.
  • kwq/KWQTextArea.h:
  • kwq/KWQTextArea.mm: (-[KWQTextArea setEnabled:]): Added. (-[KWQTextArea isEnabled]): Added. (-[KWQTextArea drawRect:]): Draws a disabled-looking bezel when disabled. (-[KWQTextAreaTextView becomeFirstResponder]): Return NO if disabled. (-[KWQTextAreaTextView mouseDown:]): Block events if disabled. (-[KWQTextAreaTextView keyDown:]): Ditto. (-[KWQTextAreaTextView keyUp:]): Ditto. (-[KWQTextAreaTextView setEnabled:]): Added. Pass value through to editable attribute on text view. (-[KWQTextAreaTextView isEnabled]): Added. (-[KWQTextAreaTextView drawRect:]): Set the text color to a disabled color when disabled.
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::isDisabled): Added. (QTextEdit::setDisabled): Added.
12:45 AM Changeset in webkit [5165] by mjs
  • 3 edits in trunk/WebCore
  • fixed 3449405 - REGRESSION: reproducible crash changing focus w/ button on page, e.g. on www.aa.com

More fallout from the exception blocking.

  • kwq/KWQButton.mm: (QButton::focusPolicy): Don't return from exception block (caught by Darin).
Note: See TracTimeline for information about the timeline view.