Timeline



Oct 19, 2003:

11:57 PM Changeset in webkit [5219] by hyatt
  • 3 edits in trunk/WebCore

Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse code in the collapsedRightBorder
case. I forgot to deal with colspans.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::cellRight): (RenderTableCell::collapsedRightBorder):
9:16 PM Changeset in webkit [5218] by hyatt
  • 3 edits in trunk/WebCore

Patch from KHTML trunk that makes textareas work properly even when they have no render objects.

  • khtml/html/html_formimpl.cpp: (HTMLTextAreaElementImpl::encoding): (HTMLTextAreaElementImpl::value):
5:45 PM Changeset in webkit [5217] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3454444 -- contents of mailto form shows up in Mail title instead of body (IE sends mail directly)
  • kwq/KWQKURL.mm: (KURL::parse): Changed non-hierarchical code to consider everything after a question mark as a query, just the way the hierarchical code does. This makes the code that constructs the mailto URL work properly.
11:08 AM Changeset in webkit [5216] by cblu
  • 7 edits
    1 add in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3229530>: Dragging standalone image to desktop should save it, not re-download it

Reviewed by darin.

  • English.lproj/Localizable.strings:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDocumentPrivate.h: Added.
  • WebView.subproj/WebImageRepresentation.h:
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation dealloc]): release new filename and data ivars (-[WebImageRepresentation doneLoading]): return YES if data is non-nil (-[WebImageRepresentation setDataSource:]): store the filename (-[WebImageRepresentation receivedError:withDataSource:]): store the data (-[WebImageRepresentation finishedLoadingWithDataSource:]): store the data (-[WebImageRepresentation data]): new (-[WebImageRepresentation filename]): new
  • WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): just save the image, don't download it (-[WebImageView image]): new

WebBrowser:

Fixed:
<rdar://problem/3456752>: Filename when saving a standalone image includes "nxn pixels"
<rdar://problem/3177870>: Context menu for standalone images should be "Save Image As..." not "Download Image to Disk"

Reviewed by darin.

  • BrowserDocument.m: (-[BrowserDocument displayName]): If we are saving a standalone image, use the responses suggestedFilename
  • ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): If this is a context menu for a standalone image, provide "Save Image As..." and "Copy Image to Clipboard" (-[BrowserWebView saveDocumentAs:]): renamed from savePageAs to be more generic
  • English.lproj/StringsNotToBeLocalized.txt:

Oct 18, 2003:

8:09 PM Changeset in webkit [5215] by darin
  • 2 edits in trunk/WebCore

Tweak some old log entries.

4:25 PM Changeset in webkit [5214] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/positioning

Add minmax test for positioned elements.

4:23 PM Changeset in webkit [5213] by hyatt
  • 4 edits in trunk/WebCore

Fix the intrinsic minmax width computation for blocks and XUL boxes to actually check fixed min/max CSS widths.

Reviewed by darin

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):
2:30 PM Changeset in webkit [5212] by hyatt
  • 7 edits in trunk/WebCore

Change the names of the border-spacing properties to border-horizontal-spacing and border-vertical-spacing.

Reviewed by NOBODY (Straightforward).

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
2:27 PM Changeset in webkit [5211] by hyatt
  • 1 delete in trunk/LayoutTests/fast/table/border-collapsing/004.html~

Remove accidental commit of a ~ file.

2:27 PM Changeset in webkit [5210] by hyatt
  • 3 adds in trunk/LayoutTests/fast/table/border-collapsing

Adding another border-collapsing test.

2:13 PM Changeset in webkit [5209] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed 3367015 -- interdependent variable declarations in for loop don't work (they go backwards)
  • kjs/nodes.h: (KJS::ForNode::ForNode): Add a new overload of the constructor for when the first parameter is a variable declaration list. Call reverseList as we do in other constructors that take lists that are built backwards.
  • kjs/nodes.cpp: (ForNode::reverseList): Added. New helper function.
1:54 PM Changeset in webkit [5208] by hyatt
  • 2 edits in trunk/WebCore/khtml/rendering

Accidentally removed a FIXME comment. Putting it back.

1:50 PM Changeset in webkit [5207] by hyatt
  • 2 adds in trunk/LayoutTests/fast/text/whitespace

Adding minmax width test for the mozilla web site beta bug.

1:49 PM Changeset in webkit [5206] by hyatt
  • 2 adds in trunk/LayoutTests/fast/selectors

Adding test for classname parsing bug.

1:48 PM Changeset in webkit [5205] by hyatt
  • 5 edits in trunk/WebCore

Fix for diveintomark className parsing bug. class="bigblue blue" would fail to match a rule with .blue.
The bug was in the selector matching code for class attributes.

Also fixing a minmax width bug for blocks on the mozilla.org Web site. XUL boxes had the same bug as
well.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):
2:28 AM Changeset in webkit [5204] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3443502, generated content sometimes doesn't generate. The bug is caused by an
uninitialized variable. m_isContinuation needed to be set to false in the RenderInline
constructor.

Reviewed by NOBODY (it's a simple obvious fix)

  • khtml/rendering/render_inline.cpp: (m_isContinuation):

Oct 17, 2003:

4:57 PM Changeset in webkit [5203] by darin
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

  • make text areas set the base writing direction based on the direction in the CSS style
  • kwq/KWQTextArea.h: Added setBaseWritingDirection method.
  • kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Use _KWQ_setTypingParagraphStyle. (-[KWQTextArea setWordWrap:]): Use _KWQ_setTypingParagraphStyle. (-[KWQTextArea setBaseWritingDirection:]): Added. New method that sets the base writing direction in both the style of the text and the typing attributes. (-[NSTextView _KWQ_typingParagraphStyle]): Added. Helper method to make setBaseWritingDirection: a little less gigantic. (-[NSTextView _KWQ_setTypingParagraphStyle:]): Ditto. (-[NSTextStorage _KWQ_setBaseWritingDirection:]): Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Set both alignment and base writing direction.
4:35 PM Changeset in webkit [5202] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3456176>: Assertion failure when loading atomfilms.com

Reviewed by kocienda.

  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): call super before calling plug-in code as we do in other callbacks (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto

WebBrowser:

Fixed: <rdar://problem/3456246>: repro assertion failure in DowloadViewController pressing cmd-. when active download is not selected

Reviewed by kocienda.

  • DownloadViewController.m: (-[DownloadViewController _stopSelection]): Removed the assertion because it is OK to call this method when there are no downloads to stop
4:06 PM Changeset in webkit [5201] by hyatt
  • 7 adds in trunk/LayoutTests/fast/table/border-collapsing

Add border-collapsing tests.

3:32 PM Changeset in webkit [5200] by hyatt
  • 20 edits in trunk/WebCore

Implement horizontal and vertical border-spacing. Allow them to be specified individually.

Reviewed by mjs

------

Fix the calcWidth method of tables to account for horizontal margins properly.

Reviewed by john

------

Implement border collapsing in tables.

Reviewed by kocienda

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c:
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
  • khtml/rendering/render_form.cpp: (RenderFieldset::paintBorderMinusLegend):
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorder): (RenderObject::collectBorders):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::): (khtml::CollapsedBorderValue::precedence): (khtml::CollapsedBorderValue::width): (khtml::CollapsedBorderValue::style): (khtml::CollapsedBorderValue::exists): (khtml::CollapsedBorderValue::color): (khtml::CollapsedBorderValue::isTransparent): (khtml::CollapsedBorderValue::operator==): (khtml::RenderStyle::borderLeft): (khtml::RenderStyle::borderRight): (khtml::RenderStyle::borderTop): (khtml::RenderStyle::borderBottom): (khtml::RenderStyle::horizontalBorderSpacing): (khtml::RenderStyle::verticalBorderSpacing): (khtml::RenderStyle::setHorizontalBorderSpacing): (khtml::RenderStyle::setVerticalBorderSpacing):
  • khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::setStyle): (RenderTable::calcWidth): (RenderTable::paint): (RenderTable::borderLeft): (RenderTable::borderRight): (RenderTable::borderTop): (RenderTable::borderBottom): (RenderTable::cellAbove): (RenderTable::cellBelow): (RenderTable::cellLeft): (RenderTable::cellRight): (RenderTableSection::setCellWidths): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (compareBorders): (RenderTableCell::collapsedLeftBorder): (RenderTableCell::collapsedRightBorder): (RenderTableCell::collapsedTopBorder): (RenderTableCell::collapsedBottomBorder): (RenderTableCell::borderLeft): (RenderTableCell::borderRight): (RenderTableCell::borderTop): (RenderTableCell::borderBottom): (collapsedBorderStyle): (CollapsedBorder::CollapsedBorder): (CollapsedBorders:::count): (CollapsedBorders::addBorder): (CollapsedBorders::nextBorder): (addBorderStyle): (RenderTableCell::collectBorders): (RenderTableCell::paintCollapsedBorder): (RenderTableCell::paintObject): (RenderTableCell::paintBoxDecorations):
  • khtml/rendering/render_table.h: (khtml::RenderTable::hBorderSpacing): (khtml::RenderTable::vBorderSpacing): (khtml::RenderTable::bordersPaddingAndSpacing): (khtml::RenderTable::currentBorderStyle):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::layout): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::layout):

Oct 16, 2003:

5:36 PM Changeset in webkit [5199] by mjs
  • 5 edits in trunk/WebCore

Reviewed by John.

More exception blocking.

  • kwq/KWQFont.mm: (QFont::isFixedPitch): (QFont::getNSFont):
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::~TransferJob):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQCheckIfReloading): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse): (KWQResponseMIMEType):
5:17 PM Changeset in webkit [5198] by rjw
  • 2 edits in trunk/WebKit

Fixed 3455306. Ensure that progress is correctly ended when a load is interupted (i.e. becomes a download).

Reviewed by mjs.

  • WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
4:40 PM Changeset in webkit [5197] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug-in content

Reviewed by rjw.

  • Misc.subproj/WebDownload.m: fixed build failure when using new Foundation. We are overriding and calling a renamed method. Continue to override the old method, override the new method and declare their interfaces to avoid build failures.
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): cancel the load before telling the plug-in about the error so plug-in code doesn't attempt to cancel the load twice
3:37 PM Changeset in webkit [5196]
  • 5 copies in tags/Safari-110

This commit was manufactured by cvs2svn to create tag 'Safari-110'.

3:37 PM Changeset in webkit [5195] by vicki
  • 2 edits in trunk/WebCore

move the Safari-110 marker in the ChangeLog

3:27 PM Changeset in webkit [5194] by vicki
  • 3 edits in trunk/WebCore

Reviewed by vicki.

  • fix buildit build failure
  • kwq/KWQScrollView.mm: (QScrollView::resizeContents):
2:59 PM Changeset in webkit [5193] by rjw
  • 2 edits in trunk/WebKit

Fixed 3453991. We weren't setting the array cursor correctly after changing
capacity.

Reviewed by John.

  • ChangeLog:
  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList setCapacity:]):
2:50 PM Changeset in webkit [5192] by vicki
  • 3 edits in trunk

tree is open for Safari-111

2:44 PM Changeset in webkit [5191] by vicki
  • 5 edits in trunk

The rest of the Safari-110 stamp

2:42 PM Changeset in webkit [5190] by vicki
  • 3 edits in trunk/JavaScriptCore

top level:

  • configure.in: Add "OptimizedWithSymbols" build style.

Tools:

  • Scripts/autovicki: Renamed from run-tests.
  • Scripts/run-tests: Run autovicki passing all arguments (for compatibility with the humor-impaired).

JavaScriptCore:

  • kjs/create_hash_table: Remove stray semicolon.
  • kjs/array_object.lut.h:
  • kjs/date_object.lut.h:
  • kjs/lexer.lut.h:
  • kjs/math_object.lut.h:
  • kjs/number_object.lut.h:
  • kjs/string_object.lut.h: Regenerated.

Tests:

  • JSUnit/jsunit/app/jsUnitTestManager.js: Commented the lines I changed to work around bug 3269212 in WebCore.

WebCore:

Reviewed by Ken.

  • change "volatile X * volatile" to "X * volatile" in cases where the pointer needs to be volatile but the object pointed to do does not
  • kwq/KWQKConfigBase.mm: (KConfig::readEntry):
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
  • kwq/KWQKLocale.mm: (inputElementAltText): (resetButtonDefaultLabel): (searchableIndexIntroduction): (submitButtonDefaultLabel): (KLocale::language):
  • kwq/KWQLineEdit.mm: (QLineEdit::text):
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos): (QScrollView::addChild): (QScrollView::updateContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::getDocumentView):
  • kwq/KWQTextEdit.mm: (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
  • kwq/KWQWidget.mm: (QWidget::getOuterView): Removed the excess volatiles and excess casts that go with them.
  • kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): Do the same, but also remove an unnecessary nil check that is the same as QString::fromNSString's default behavior.

WebKit:

Tweaked the progress behavior and factored cleanup of progress
related ivars.

Reviewed by Hyatt.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
  • WebView.subproj/WebView.m: (-[WebView _resetProgress]): (-[WebView _progressStarted:]): (-[WebView _finalProgressComplete]): (-[WebView _progressCompleted:]): (-[WebView _incrementProgressForConnection:data:]):
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Coalesce drawing of progress bar (like old behavior). This fixes a performance regression.
Always draw the progress at 100% for a short interval after loading a page (like the old behavior).

Reviewed by Hyatt.

  • BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController _newUpdateProgressBar]): (-[BrowserWindowController newUpdateProgressBar]): (-[BrowserWindowController showCompleteProgressBar]): (-[BrowserWindowController clearProgressBar]):
  • TextFieldWithControls.m: (-[TextFieldWithControls setProgressBarValue:]):

WebKitExamples:

  • CarbonDownloader/English.lproj/main.nib: Changed command key equivalent for Close to Cmd-W. Since this is example code and not localized, the localization freeze should not be an issue.
  • CarbonDownloader/English.lproj/main~.nib: Removed.
2:11 PM Changeset in webkit [5189] by mjs
  • 5 edits in trunk/WebCore

Roll out earlier change, since the tree was closed.

1:55 PM Changeset in webkit [5188] by mjs
  • 5 edits in trunk/WebCore

Reviewed by John.

More exception blocking.

  • kwq/KWQFont.mm: (QFont::isFixedPitch): (QFont::getNSFont):
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::~TransferJob):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQCheckIfReloading): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse): (KWQResponseMIMEType):
12:56 PM Changeset in webkit [5187] by rjw
  • 5 edits in trunk/WebKit

WebBrowser:

Coalesce drawing of progress bar (like old behavior). This fixes a performance regression.
Always draw the progress at 100% for a short interval after loading a page (like the old behavior).

Reviewed by Hyatt.

  • BrowserWebController.m: (-[BrowserWebView initWithDocument:request:frameName:]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController _newUpdateProgressBar]): (-[BrowserWindowController newUpdateProgressBar]): (-[BrowserWindowController showCompleteProgressBar]): (-[BrowserWindowController clearProgressBar]):
  • TextFieldWithControls.m: (-[TextFieldWithControls setProgressBarValue:]):

WebKit:

Tweaked the progress behavior and factored cleanup of progress
related ivars.

Reviewed by Hyatt.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]):
  • WebView.subproj/WebView.m: (-[WebView _resetProgress]): (-[WebView _progressStarted:]): (-[WebView _finalProgressComplete]): (-[WebView _progressCompleted:]): (-[WebView _incrementProgressForConnection:data:]):
  • WebView.subproj/WebViewPrivate.h:

Oct 15, 2003:

9:18 AM Changeset in webkit [5186] by darin
  • 10 edits in trunk/WebCore

Reviewed by Ken.

  • change "volatile X * volatile" to "X * volatile" in cases where the pointer needs to be volatile but the object pointed to do does not
  • kwq/KWQKConfigBase.mm: (KConfig::readEntry):
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
  • kwq/KWQKLocale.mm: (inputElementAltText): (resetButtonDefaultLabel): (searchableIndexIntroduction): (submitButtonDefaultLabel): (KLocale::language):
  • kwq/KWQLineEdit.mm: (QLineEdit::text):
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos): (QScrollView::addChild): (QScrollView::updateContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::getDocumentView):
  • kwq/KWQTextEdit.mm: (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
  • kwq/KWQWidget.mm: (QWidget::getOuterView): Removed the excess volatiles and excess casts that go with them.
  • kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): Do the same, but also remove an unnecessary nil check that is the same as QString::fromNSString's default behavior.
12:05 AM Changeset in webkit [5185] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Dave.

More objc-exception-blocking excitement.

  • kwq/KWQKConfigBase.mm: (KConfig::readEntry): (KConfig::readNumEntry): (RefreshPlugins):
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
  • kwq/KWQKLocale.mm: (inputElementAltText): (resetButtonDefaultLabel): (searchableIndexIntroduction): (submitButtonDefaultLabel): (KLocale::language):
  • kwq/KWQRegion.mm: (QRegion::QRegion):
Note: See TracTimeline for information about the timeline view.