Timeline



Oct 21, 2003:

7:22 PM Changeset in webkit [5236] by hyatt
  • 3 edits in trunk/WebCore

​http://placenamehere.com/safari/fixedbgtest.html is now fixed with a patch from the KHTML trunk.
Fixed backgrounds repeated when they weren't supposed to.

  • khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended):
5:10 PM Changeset in webkit [5235] by rjw
  • 2 edits in trunk/WebKit

Don't use small caps font for characters that don't have an
uppercase counterpart (i.e. punctuation marks).

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):
3:14 PM Changeset in webkit [5234] by hyatt
  • 11 edits in trunk/WebCore

Change pseudo-element style resolution to be lazy and to not occur until the style is actually asked
for by the front end render objects. Also fix first-letter to inherit properly from first-line styles.

Reviewed by mjs

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/css/cssstyleselector.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::createInlineBox): (RenderObject::style): (RenderObject::getPseudoStyle):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (pseudoBit): (RenderStyle::hasPseudoStyle): (RenderStyle::setHasPseudoStyle): (RenderStyle::getPseudoStyle): (RenderStyle::addPseudoStyle):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults):
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject): (RenderText::htmlFont):
2:17 PM Changeset in webkit [5233] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

More exception blocking.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::generateFrameName): (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (regExpForLabels): (KWQKHTMLPart::clearRecordedFormValues): (KWQKHTMLPart::recordFormValue): (KWQKHTMLPart::submitForm): (KHTMLPart::frameDetached): (KWQKHTMLPart::urlSelected): (KWQKHTMLPart::createPart): (KWQKHTMLPart::setTitle): (KWQKHTMLPart::setStatusBarText): (KWQKHTMLPart::scheduleClose): (KWQKHTMLPart::unfocusWindow): (KWQKHTMLPart::jumpToSelection): (KWQKHTMLPart::redirectionTimerStartedOrStopped): (KWQKHTMLPart::userAgent): (KWQKHTMLPart::mimeTypeForFileName): (KWQKHTMLPart::nextKeyView): (KWQKHTMLPart::currentEventIsMouseDownInWidget): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::saveDocumentState): (KWQKHTMLPart::restoreDocumentState): (KWQKHTMLPart::requestedURLString): (KWQKHTMLPart::incomingReferrer): (KWQKHTMLPart::runJavaScriptAlert): (KWQKHTMLPart::runJavaScriptConfirm): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::createEmptyDocument): (KWQKHTMLPart::keyEvent): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::lastEventIsMouseUp): (findViewInSubviews): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::passSubframeEventToSubframe): (KWQKHTMLPart::buttonForCurrentEvent): (KWQKHTMLPart::stateForCurrentEvent): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::mouseDragged): (KWQKHTMLPart::mouseUp): (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): (KWQKHTMLPart::mouseMoved): (KWQKHTMLPart::sendContextMenuEvent): (fileWrapperForElement): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::keyboardUIMode):
11:47 AM Changeset in webkit [5232] by cblu
  • 7 edits in trunk

WebCore:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

Reviewed by rjw.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): call renamed frameRequiredForMIMEType:URL:
  • kwq/WebCoreBridge.h: renamed frameRequiredForMIMEType: to frameRequiredForMIMEType:URL:

WebKit:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

Reviewed by rjw.

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForExtension:]): If no plug-in is found from the extension, attempt to map from the extension to a MIME type using our mappings and find a plug-in from the MIME type. This improves our chances of finding a plug-in when no MIME type is specified.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): If the passed MIME is empty, nil it out so that clients only need to check for nil. This avoids error sheets complaining about "" MIME types. (-[WebBridge frameRequiredForMIMEType:URL:]): Renamed to include URL. If no MIME is specified, only create a plug-in view if we can map from the extension.

Oct 20, 2003:

1:35 PM Changeset in webkit [5231] by cblu
  • 9 edits in trunk/WebKit

Fixed: <rdar://problem/3457627>: empty Flash plugin at tvguide.com
Fixed issues with plug-in stream error handling.
Improved plug-in logging.

Reviewed by kocienda.

  • Misc.subproj/WebKitLogging.h: added WebKitLogPluginEvents
  • Misc.subproj/WebKitLogging.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.h:
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): improved logging (-[WebBaseNetscapePluginStream destroyStream]): improved logging (-[WebBaseNetscapePluginStream destroyStreamWithFailingReason:]): renamed from cancelWithReason to avoid confusion (-[WebBaseNetscapePluginStream receivedError:]): calls destroyStreamWithFailingReason after determining a reason from the NSError (-[WebBaseNetscapePluginStream cancelWithReason:]): calls destroyStreamWithFailingReason, this method is overriden by subclasses to cancel the actual load (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): call destroyStreamWithFailingReason, not cancelWithReason because the loaded has already ended here (-[WebBaseNetscapePluginStream deliverData]): improved logging
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): use even logging (-[WebBaseNetscapePluginView sendUpdateEvent]): ditto (-[WebBaseNetscapePluginView becomeFirstResponder]): ditto (-[WebBaseNetscapePluginView resignFirstResponder]): ditto (-[WebBaseNetscapePluginView mouseDown:]): ditto (-[WebBaseNetscapePluginView mouseUp:]): ditto (-[WebBaseNetscapePluginView mouseEntered:]): ditto (-[WebBaseNetscapePluginView mouseExited:]): ditto (TSMEventHandler): ditto (-[WebBaseNetscapePluginView destroyStream:reason:]): call cancelWithReason so the reason is passed back to the plug-in
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): tweak
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call receivedError (-[WebNetscapePluginRepresentation cancelWithReason:]): override, cancel the load, call super
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): override, cancel the load, call super (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): be sure to call the stream before calling super because the stream can be cleared out when calling super (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto
11:49 AM Changeset in webkit [5230] by rjw
  • 2 edits in trunk/WebKit

Conditionally excluded fix for 3446192. We'll enable the fix once 3446669
has been fixed. This patch switches to the new UTI typing API for pasteboard types.

Reviewed by Ken.

  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]):
11:22 AM Changeset in webkit [5229] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Add test for floating/positioning generated content.

11:18 AM Changeset in webkit [5228] by hyatt
  • 4 edits in trunk/WebCore

Fix generated content (before/after) so that it no longer has any restrictions on it. CSS2.1 lifted
restrictions preventing the floating/positioning of generated content.

Reviewed by rjw

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
11:09 AM Changeset in webkit [5227] by rjw
  • 5 edits in trunk/WebKit

WebBrowser

Add a debug menu item to always use ATSU text drawing. This will be helpful
to the ATSU folks in performance tuning there API. Right now I see approx.
2X slowdown using ATSU.
Reviewed by Chris.

  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleAlternateProgress:]): (-[BrowserDocument toggleUseATSUForAllTextDrawing:]):

WebKit

Fixed 3456103. Don't assert, just check for inappropriate state.
Reviewed by Hyatt

Add a debug menu item to always use ATSU text drawing. This will be helpful
to the ATSU folks in performance tuning there API. Right now I see approx.
2X slowdown using ATSU.

Also did some shuffling around of inline related stuff.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (isControlCharacter): (isAlternateSpace): (isSpace): (getUncachedWidth): (widthFromMap): (widthForGlyph): (+[WebTextRenderer _setAlwaysUseATSU:]): (glyphForCharacter): (glyphForUnicodeCharacter): (shouldUseATSU):
  • WebView.subproj/WebView.m: (+[WebView _setAlwaysUseATSU:]): (-[WebView _progressCompleted:]):
  • WebView.subproj/WebViewPrivate.h:
10:28 AM Changeset in webkit [5226] by kocienda
  • 15 edits in trunk/WebCore

Reviewed by David

  • khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Change over to use ascii value for key code. (UIEvent::which): Ditto. (KeyboardEvent::KeyboardEvent): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEvent::operator = ): New function. (KeyboardEvent::~KeyboardEvent): New function. (KeyboardEvent::ctrlKey): New function. (KeyboardEvent::shiftKey): New function. (KeyboardEvent::altKey): New function. (KeyboardEvent::metaKey): New function. (KeyboardEvent::altGraphKey): New function. (KeyboardEvent::initKeyboardEvent): New function.
  • khtml/dom/dom2_events.h: Ditto.
  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Use key identifiers to test which key was pressed, instead of removed keyVal(). (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new class name. Use key identifiers to test which key was pressed, instead of removed keyVal(). Use new modifier accessors.
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (EventImpl::idToType): Ditto. (KeyboardEventImpl::KeyboardEventImpl): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEventImpl::~KeyboardEventImpl): Ditto. (KeyboardEventImpl::initKeyboardEvent): Ditto.
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (DOM::KeyboardEventImpl::keyIdentifier): New function. (DOM::KeyboardEventImpl::keyLocation): New function. (DOM::KeyboardEventImpl::ctrlKey): New function. (DOM::KeyboardEventImpl::shiftKey): New function. (DOM::KeyboardEventImpl::altKey): New function. (DOM::KeyboardEventImpl::metaKey): New function. (DOM::KeyboardEventImpl::altGraphKey): New function. (DOM::KeyboardEventImpl::qKeyEvent): New function.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Now can create keyboard events.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Class name changes.
  • kwq/KWQEvent.h: Added QString identifier member.
  • kwq/KWQEvent.mm: (hexDigit): Added helper. (identifierForKeyText): Added new function to map keys to DOM key identifiers as listed in the DOM spec. (QKeyEvent::identifier): Added accessor.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::stateForCurrentEvent): Added check to see if a key press is on one of the numeric keypad keys.
  • kwq/KWQLogging.h: Added log constant for DOM events.
  • kwq/KWQLogging.m: Ditto
8:42 AM Changeset in webkit [5225] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3442218>: crash due to infinite recursion trying to load standalone plug-in content

Reviewed by darin.

  • WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): manage the isStoppingLoad ivar, return if isStoppingLoad is YES
  • WebView.subproj/WebFramePrivate.h: added the isStoppingLoad ivar
7:59 AM Changeset in webkit [5224] by darin
  • 2 edits in trunk/WebKit

Reviewed by Dave and Ken.

  • fixed 3457066 -- REGRESSION (91-92): command-left-arrow causes a scroll to the left before going back
  • WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): Add an else so that we don't fall into the scrolling code when the command key is down for right and left arrow.
12:09 AM Changeset in webkit [5223] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Adding first-letter/before text-transform tests.

12:07 AM Changeset in webkit [5222] by hyatt
  • 7 edits in trunk/WebCore

Make first-letter and before/after work with text transforms.

Reviewed by mjs

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::isTextFragment): (RenderText::originalString): (RenderText::setText): (m_generatedContentStr): (m_start): (RenderTextFragment::~RenderTextFragment): (RenderTextFragment::isTextFragment): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h: (khtml::RenderTextFragment::start): (khtml::RenderTextFragment::end): (khtml::RenderTextFragment::contentString):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::setRenderer):
12:05 AM Changeset in webkit [5221] by hyatt
  • 2 edits in trunk/LayoutTests/fast

Layout tests affected by the removal of the list float quirk.

12:02 AM Changeset in webkit [5220] by hyatt
  • 3 edits in trunk/WebCore

Remove the "flow-around-floats" hack for lists. Other browsers don't do this.

Reviewed by darin

  • khtml/css/quirks.css:

Oct 19, 2003:

11:57 PM Changeset in webkit [5219] by hyatt
  • 3 edits in trunk/WebCore

Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse code in the collapsedRightBorder
case. I forgot to deal with colspans.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::cellRight): (RenderTableCell::collapsedRightBorder):
9:16 PM Changeset in webkit [5218] by hyatt
  • 3 edits in trunk/WebCore

Patch from KHTML trunk that makes textareas work properly even when they have no render objects.

  • khtml/html/html_formimpl.cpp: (HTMLTextAreaElementImpl::encoding): (HTMLTextAreaElementImpl::value):
5:45 PM Changeset in webkit [5217] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3454444 -- contents of mailto form shows up in Mail title instead of body (IE sends mail directly)
  • kwq/KWQKURL.mm: (KURL::parse): Changed non-hierarchical code to consider everything after a question mark as a query, just the way the hierarchical code does. This makes the code that constructs the mailto URL work properly.
11:08 AM Changeset in webkit [5216] by cblu
  • 7 edits
    1 add in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3229530>: Dragging standalone image to desktop should save it, not re-download it

Reviewed by darin.

  • English.lproj/Localizable.strings:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDocumentPrivate.h: Added.
  • WebView.subproj/WebImageRepresentation.h:
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation dealloc]): release new filename and data ivars (-[WebImageRepresentation doneLoading]): return YES if data is non-nil (-[WebImageRepresentation setDataSource:]): store the filename (-[WebImageRepresentation receivedError:withDataSource:]): store the data (-[WebImageRepresentation finishedLoadingWithDataSource:]): store the data (-[WebImageRepresentation data]): new (-[WebImageRepresentation filename]): new
  • WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): just save the image, don't download it (-[WebImageView image]): new

WebBrowser:

Fixed:
<rdar://problem/3456752>: Filename when saving a standalone image includes "nxn pixels"
<rdar://problem/3177870>: Context menu for standalone images should be "Save Image As..." not "Download Image to Disk"

Reviewed by darin.

  • BrowserDocument.m: (-[BrowserDocument displayName]): If we are saving a standalone image, use the responses suggestedFilename
  • ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): If this is a context menu for a standalone image, provide "Save Image As..." and "Copy Image to Clipboard" (-[BrowserWebView saveDocumentAs:]): renamed from savePageAs to be more generic
  • English.lproj/StringsNotToBeLocalized.txt:

Oct 18, 2003:

8:09 PM Changeset in webkit [5215] by darin
  • 2 edits in trunk/WebCore

Tweak some old log entries.

4:25 PM Changeset in webkit [5214] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/positioning

Add minmax test for positioned elements.

4:23 PM Changeset in webkit [5213] by hyatt
  • 4 edits in trunk/WebCore

Fix the intrinsic minmax width computation for blocks and XUL boxes to actually check fixed min/max CSS widths.

Reviewed by darin

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):
2:30 PM Changeset in webkit [5212] by hyatt
  • 7 edits in trunk/WebCore

Change the names of the border-spacing properties to border-horizontal-spacing and border-vertical-spacing.

Reviewed by NOBODY (Straightforward).

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
2:27 PM Changeset in webkit [5211] by hyatt
  • 1 delete in trunk/LayoutTests/fast/table/border-collapsing/004.html~

Remove accidental commit of a ~ file.

2:27 PM Changeset in webkit [5210] by hyatt
  • 3 adds in trunk/LayoutTests/fast/table/border-collapsing

Adding another border-collapsing test.

2:13 PM Changeset in webkit [5209] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed 3367015 -- interdependent variable declarations in for loop don't work (they go backwards)
  • kjs/nodes.h: (KJS::ForNode::ForNode): Add a new overload of the constructor for when the first parameter is a variable declaration list. Call reverseList as we do in other constructors that take lists that are built backwards.
  • kjs/nodes.cpp: (ForNode::reverseList): Added. New helper function.
1:54 PM Changeset in webkit [5208] by hyatt
  • 2 edits in trunk/WebCore/khtml/rendering

Accidentally removed a FIXME comment. Putting it back.

1:50 PM Changeset in webkit [5207] by hyatt
  • 2 adds in trunk/LayoutTests/fast/text/whitespace

Adding minmax width test for the mozilla web site beta bug.

1:49 PM Changeset in webkit [5206] by hyatt
  • 2 adds in trunk/LayoutTests/fast/selectors

Adding test for classname parsing bug.

1:48 PM Changeset in webkit [5205] by hyatt
  • 5 edits in trunk/WebCore

Fix for diveintomark className parsing bug. class="bigblue blue" would fail to match a rule with .blue.
The bug was in the selector matching code for class attributes.

Also fixing a minmax width bug for blocks on the mozilla.org Web site. XUL boxes had the same bug as
well.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcMinMaxWidth):
2:28 AM Changeset in webkit [5204] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3443502, generated content sometimes doesn't generate. The bug is caused by an
uninitialized variable. m_isContinuation needed to be set to false in the RenderInline
constructor.

Reviewed by NOBODY (it's a simple obvious fix)

  • khtml/rendering/render_inline.cpp: (m_isContinuation):

Oct 17, 2003:

4:57 PM Changeset in webkit [5203] by darin
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

  • make text areas set the base writing direction based on the direction in the CSS style
  • kwq/KWQTextArea.h: Added setBaseWritingDirection method.
  • kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Use _KWQ_setTypingParagraphStyle. (-[KWQTextArea setWordWrap:]): Use _KWQ_setTypingParagraphStyle. (-[KWQTextArea setBaseWritingDirection:]): Added. New method that sets the base writing direction in both the style of the text and the typing attributes. (-[NSTextView _KWQ_typingParagraphStyle]): Added. Helper method to make setBaseWritingDirection: a little less gigantic. (-[NSTextView _KWQ_setTypingParagraphStyle:]): Ditto. (-[NSTextStorage _KWQ_setBaseWritingDirection:]): Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Set both alignment and base writing direction.
4:35 PM Changeset in webkit [5202] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3456176>: Assertion failure when loading atomfilms.com

Reviewed by kocienda.

  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): call super before calling plug-in code as we do in other callbacks (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto

WebBrowser:

Fixed: <rdar://problem/3456246>: repro assertion failure in DowloadViewController pressing cmd-. when active download is not selected

Reviewed by kocienda.

  • DownloadViewController.m: (-[DownloadViewController _stopSelection]): Removed the assertion because it is OK to call this method when there are no downloads to stop
4:06 PM Changeset in webkit [5201] by hyatt
  • 7 adds in trunk/LayoutTests/fast/table/border-collapsing

Add border-collapsing tests.

3:32 PM Changeset in webkit [5200] by hyatt
  • 20 edits in trunk/WebCore

Implement horizontal and vertical border-spacing. Allow them to be specified individually.

Reviewed by mjs

------

Fix the calcWidth method of tables to account for horizontal margins properly.

Reviewed by john

------

Implement border collapsing in tables.

Reviewed by kocienda

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c:
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
  • khtml/rendering/render_form.cpp: (RenderFieldset::paintBorderMinusLegend):
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorder): (RenderObject::collectBorders):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::): (khtml::CollapsedBorderValue::precedence): (khtml::CollapsedBorderValue::width): (khtml::CollapsedBorderValue::style): (khtml::CollapsedBorderValue::exists): (khtml::CollapsedBorderValue::color): (khtml::CollapsedBorderValue::isTransparent): (khtml::CollapsedBorderValue::operator==): (khtml::RenderStyle::borderLeft): (khtml::RenderStyle::borderRight): (khtml::RenderStyle::borderTop): (khtml::RenderStyle::borderBottom): (khtml::RenderStyle::horizontalBorderSpacing): (khtml::RenderStyle::verticalBorderSpacing): (khtml::RenderStyle::setHorizontalBorderSpacing): (khtml::RenderStyle::setVerticalBorderSpacing):
  • khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::setStyle): (RenderTable::calcWidth): (RenderTable::paint): (RenderTable::borderLeft): (RenderTable::borderRight): (RenderTable::borderTop): (RenderTable::borderBottom): (RenderTable::cellAbove): (RenderTable::cellBelow): (RenderTable::cellLeft): (RenderTable::cellRight): (RenderTableSection::setCellWidths): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (compareBorders): (RenderTableCell::collapsedLeftBorder): (RenderTableCell::collapsedRightBorder): (RenderTableCell::collapsedTopBorder): (RenderTableCell::collapsedBottomBorder): (RenderTableCell::borderLeft): (RenderTableCell::borderRight): (RenderTableCell::borderTop): (RenderTableCell::borderBottom): (collapsedBorderStyle): (CollapsedBorder::CollapsedBorder): (CollapsedBorders:::count): (CollapsedBorders::addBorder): (CollapsedBorders::nextBorder): (addBorderStyle): (RenderTableCell::collectBorders): (RenderTableCell::paintCollapsedBorder): (RenderTableCell::paintObject): (RenderTableCell::paintBoxDecorations):
  • khtml/rendering/render_table.h: (khtml::RenderTable::hBorderSpacing): (khtml::RenderTable::vBorderSpacing): (khtml::RenderTable::bordersPaddingAndSpacing): (khtml::RenderTable::currentBorderStyle):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::layout): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::layout):
Note: See TracTimeline for information about the timeline view.