Timeline



Oct 23, 2003:

4:47 PM Changeset in webkit [5251] by cblu
  • 8 edits in trunk/WebKit

Fixed: <rdar://problem/3364036>: ER: Allow plug-ins to override built-in types such as image/jpeg

Reviewed by john.

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Allow plug-ins to override built-in types except for our core HTML types and don't allow the QT plug-in to override any types because it handles many types that we already handle
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:): instead of asserting, handle the case where we ask a plug-in to map from an extension to a MIME type, but nil is returned (-[WebBridge frameRequiredForMIMEType:URL:]): no need to start up the plug-in DB because this is now handled by [WebView _viewClass:andRepresentationClass:forMIMEType:]
  • WebView.subproj/WebDataSource.m: (+[WebDataSource _representationClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:] (-[WebDataSource _makeRepresentation]): call _representationClassForMIMEType
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): tweak (+[WebFrameView _viewClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:]
  • WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): new, central place for mapping from a MIME to the document classes. We now load the plug-in DB when a non-HTML MIME type is encountered instead of loading the plug-in DB when the class for the MIME type is not found. This is required to fully fix 3364036. (+[WebView canShowMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:] (+[WebView registerViewClass:representationClass:forMIMEType:]): tweak
  • WebView.subproj/WebViewPrivate.h:
3:24 PM Changeset in webkit [5250] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Adding generated content tests for fancy first-letter/line combos.

3:23 PM Changeset in webkit [5249] by hyatt
  • 16 edits in trunk/WebCore

This patch fixes the pseudo-elements ::first-line and ::first-letter to inherit styles properly. More
specifically it does the following:

(1) Implements caching of pseudo-styles once computed off the style() which originated the pseudo-style.
The old code did this, and this was a regression from my previous patch.

(2) Fixes first-letter checking so that it happens at layout time rather than during render object
construction time, since that makes first-letter more dynamic and causes it to be discovered in cases
where it was being missed before. This fixes the front page of meyerweb.com.

(3) Make first-letter inherit from first-line like it's supposed to, and also make first-line styles
cross blocks and inherit properly from enclosing containers.

(4) Make first-letter changes cause a detach/attach to fire just as when the display changes. I generalized
the notion of needing to detach on a style change by making it a new kind of hint in dom_nodeimpl's style
diff function.

(5) Fixed isBlockFlow to return true for inline-blocks.

Reviewed by john

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getFirstLineBox): (khtml::RenderBlock::firstLineBlock): (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::isBlockFlow):
  • khtml/rendering/render_line.cpp: (InlineFlowBox::paintBackgroundAndBorder):
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::firstLineBlock): (RenderObject::updateFirstLetter): (RenderObject::dump): (RenderObject::setStyle): (RenderObject::recalcMinMaxWidths): (RenderObject::style): (RenderObject::getPseudoStyle):
  • khtml/rendering/render_object.h: (khtml::RenderObject::overhangingContents):
  • khtml/rendering/render_style.cpp: (pseudoBit):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::):
  • khtml/rendering/render_table.cpp: (RenderTable::firstLineBlock): (RenderTable::updateFirstLetter):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (RenderText::paintObject): (RenderText::htmlFont):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::diff):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::):
12:25 PM Changeset in webkit [5248] by sullivan
  • 4 edits in trunk/WebKit
  • fixed 3459272 -- Can't set up keyboard loop inside a WebDocumentView without subclassing views
  • fixed 3179062 -- can't tab back to address bar from image-only page
  • fixed 3252009 -- tabbing from address bar to content area does not work with WebTextView
  • fixed 3461398 -- Can't click on a standalone image to focus it (for later keyboard scrolling)

I redid the way WebView and WebFrameView splice themselves into
the keyview loop in a way very similar to what NSScrollView and
NSClipView do. This means that contained and sibling views won't
need to do anything special to put themselves into the key loop.

Reviewed by Chris.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollView]): check for nil pointer before dereferencing; this can happen during [super dealloc]'s keyview-loop-fixup code (-[WebFrameView initWithFrame:]): wire our nextKeyView link to the contained scrollview (so previousKeyView will work correctly from scrollview) (-[WebFrameView acceptsFirstResponder]): return what the contained scrollview says (-[WebFrameView becomeFirstResponder]): in previous direction, use previousValidKeyView (follows normal NSView keyview links); in forward direction, hand first responder-ness to contained scrollview (which will in turn hand it down to clipview, which will in turn hand it down to document) (-[WebFrameView setNextKeyView:]): wire up scrollview instead of self, if it exists
  • WebView.subproj/WebImageView.m: (-[WebImageView acceptsFirstResponder]): overridden to return YES; this fixes 3461398 and puts the finishing touches on 3179062
  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]): wire our nextKeyView link to the contained webframeview (so previousKeyView will work correctly from webframeview). Also, if there's a nextKeyView already set (in a nib, e.g.), wire it to our contained webframeview. (-[WebView acceptsFirstResponder]): return what the contained webframeview says (-[WebView becomeFirstResponder]): in previous direction, use previousValidKeyView (follows normal NSView keyview links); in forward direction, hand first responder-ness to contained webframeview (which will in turn hand it down to scrollview, etc.) (-[WebView setNextKeyView:]): wire up webframeview instead of self, if it exists
8:41 AM Changeset in webkit [5247] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by David

Fix for these bugs:

<rdar://problem/3171929>: Safari picks a different button in a
form when you hit return if the first button has no name
<rdar://problem/3200386>: investigate which button is activated
when hitting return in form text input fields

HTML spec says that buttons must have names to be considered
successful. However, other browsers do not impose this constraint.
Therefore, we behave differently, and can use different buttons than
the author intended.

  • khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::isSuccessfulSubmitButton) (HTMLInputElementImpl::isSuccessfulSubmitButton)

Oct 22, 2003:

7:03 PM Changeset in webkit [5246] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3460726, the user agent string was returning nil.

Fix for 3386544, empty documents did not get a layout, and so they looked white. Also fixed the positioning
of widgets to account for border/padding in updateWidgetPositions.

Fix for espn.com crasher, 3458143, caused by layout object not being properly cleared when layouts were
unscheduled.

Reviewed by darin

  • khtml/khtmlview.cpp:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::updateWidgetPositions):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::userAgent):
6:01 PM Changeset in webkit [5245] by mjs
  • 3 edits in trunk/WebCore

Reviewed by

  • fixed 3460664 - Exception handlers not properly removed
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::mouseMoved): Don't return from exception block (KWQKHTMLPart::khtmlMouseReleaseEvent): Add exception blocking (whoops)
5:43 PM Changeset in webkit [5244] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3460652 -- REGRESSION (100-110+): Can't tab out of a frameset page

Reviewed by Darin (actually he made the change on my machine)

  • khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::defaultEventHandler): only set defaultHandled for the one event that we actually handle (mouse event to resize frame borders); this was always being set, hence preventing key events from being used elsewhere.
5:27 PM Changeset in webkit [5243] by rjw
  • 10 edits in trunk/LayoutTests

Updated to account for change in metrics

5:10 PM Changeset in webkit [5242] by rjw
  • 8 edits in trunk

WebKit:

Match WebCore's notion of distributing linegap between top and bottom of
line. WebKit used to put it all at the bottom of the line.

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):

WebCore:

Fixed 3454067. RenderText's repaint wasn't called because of recent changes to de-virtualize repaint. Modified getAbsoluteRepaintRect() to return containing block's getAbsoluteRepaintRect().

Also removed the long standing +1 from QFontMetrics::height().

Reviewed by Hyatt.

  • khtml/rendering/render_text.cpp: (RenderText::getAbsoluteRepaintRect):
  • khtml/rendering/render_text.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::height):
4:18 PM Changeset in webkit [5241] by mjs
  • 3 edits in trunk/JavaScriptCore

Fix broken build.

  • kjs/simple_number.h:
3:36 PM Changeset in webkit [5240] by hyatt
  • 5 edits in trunk/WebCore

Fix visibility to be done when widgets are added or when styles are set rather than at paint time. Fixes
the ads painting on top of content at tvguide.com.

Reviewed by cblu

  • khtml/rendering/render_replaced.cpp: (RenderWidget::setQWidget): (RenderWidget::setStyle): (RenderWidget::paintObject):
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::show): (QWidget::hide):
2:31 PM Changeset in webkit [5239] by mjs
  • 4 edits in trunk/JavaScriptCore

Merged 64-bit compilation fixes, and fixes for handling negative 0
from upstream kjs.

  • kjs/internal.cpp:
  • kjs/simple_number.h: (KJS::SimpleNumber): fixed constants; added negZero constant. (KJS::SimpleNumber::is): adjusted to use long and not int. (KJS::SimpleNumber::value): ditto. (KJS::SimpleNumber::fits): ditto; also don't allow -0 to fit, so we don't lose the distinction between -0 and +0. (KJS::SimpleNumber::make): adjusted to use long.
1:33 PM Changeset in webkit [5238] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Dave.

Finished exception blocking changes, so now I can finally say:

  • fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
  • fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
  • fixed 3311511 - nil deref inside KJS::Screen
  • fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
  • fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
  • fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
  • fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
  • fixed 3413224 - unrepro crash in KJS::Window::mark
  • fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access ​http://www.lindyinthepalms.com
  • fixed 3420123 - Panther7B66: Safari crashed while going to ​http://www.tangents.co.uk/index2.html
  • fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
  • fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()
  • WebCore.pbproj/project.pbxproj:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQPainter.mm: (QPainter::drawPixmap): (QPainter::drawTiledPixmap): (QPainter::_updateRenderer):
  • kwq/WebCoreTextRenderer.h:

WebKit:

Reviewed by Dave.

Finished exception blocking changes, so now I can finally say:

  • fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
  • fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
  • fixed 3311511 - nil deref inside KJS::Screen
  • fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
  • fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
  • fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
  • fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
  • fixed 3413224 - unrepro crash in KJS::Window::mark
  • fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access ​http://www.lindyinthepalms.com
  • fixed 3420123 - Panther7B66: Safari crashed while going to ​http://www.tangents.co.uk/index2.html
  • fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
  • fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer ascent]): (-[WebTextRenderer descent]): (-[WebTextRenderer lineSpacing]): (-[WebTextRenderer xHeight]): (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]): (-[WebTextRenderer _smallCapsRenderer]): (-[WebTextRenderer _initializeATSUStyle]): (-[WebTextRenderer _createATSUTextLayoutForRun:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):
1:25 PM Changeset in webkit [5237] by rjw
  • 2 edits in trunk/WebKit

WebBrowser:

Fixed 3458715. Only update progress for current tab, and
update progress when tab is switched.

Reviewed by Chris.

  • BrowserWebController.m: (-[BrowserWebView _updateProgressBar]): (-[BrowserWebView progressStarted:]): (-[BrowserWebView progressChanged:]): (-[BrowserWebView progressFinished:]):
  • BrowserWindowController.m: (-[BrowserWindowController didSelectTabViewItem]):

WebKit:

Fixed 3458715. Reset to 0, not .1 when done.

Reviewed by Chris.

  • WebView.subproj/WebView.m: (-[WebView _resetProgress]): (-[WebView _progressStarted:]):

Oct 21, 2003:

7:22 PM Changeset in webkit [5236] by hyatt
  • 3 edits in trunk/WebCore

​http://placenamehere.com/safari/fixedbgtest.html is now fixed with a patch from the KHTML trunk.
Fixed backgrounds repeated when they weren't supposed to.

  • khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended):
5:10 PM Changeset in webkit [5235] by rjw
  • 2 edits in trunk/WebKit

Don't use small caps font for characters that don't have an
uppercase counterpart (i.e. punctuation marks).

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):
3:14 PM Changeset in webkit [5234] by hyatt
  • 11 edits in trunk/WebCore

Change pseudo-element style resolution to be lazy and to not occur until the style is actually asked
for by the front end render objects. Also fix first-letter to inherit properly from first-line styles.

Reviewed by mjs

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/css/cssstyleselector.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::createInlineBox): (RenderObject::style): (RenderObject::getPseudoStyle):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (pseudoBit): (RenderStyle::hasPseudoStyle): (RenderStyle::setHasPseudoStyle): (RenderStyle::getPseudoStyle): (RenderStyle::addPseudoStyle):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults):
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject): (RenderText::htmlFont):
2:17 PM Changeset in webkit [5233] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

More exception blocking.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::generateFrameName): (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (regExpForLabels): (KWQKHTMLPart::clearRecordedFormValues): (KWQKHTMLPart::recordFormValue): (KWQKHTMLPart::submitForm): (KHTMLPart::frameDetached): (KWQKHTMLPart::urlSelected): (KWQKHTMLPart::createPart): (KWQKHTMLPart::setTitle): (KWQKHTMLPart::setStatusBarText): (KWQKHTMLPart::scheduleClose): (KWQKHTMLPart::unfocusWindow): (KWQKHTMLPart::jumpToSelection): (KWQKHTMLPart::redirectionTimerStartedOrStopped): (KWQKHTMLPart::userAgent): (KWQKHTMLPart::mimeTypeForFileName): (KWQKHTMLPart::nextKeyView): (KWQKHTMLPart::currentEventIsMouseDownInWidget): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::saveDocumentState): (KWQKHTMLPart::restoreDocumentState): (KWQKHTMLPart::requestedURLString): (KWQKHTMLPart::incomingReferrer): (KWQKHTMLPart::runJavaScriptAlert): (KWQKHTMLPart::runJavaScriptConfirm): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::createEmptyDocument): (KWQKHTMLPart::keyEvent): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::lastEventIsMouseUp): (findViewInSubviews): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::passSubframeEventToSubframe): (KWQKHTMLPart::buttonForCurrentEvent): (KWQKHTMLPart::stateForCurrentEvent): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::mouseDragged): (KWQKHTMLPart::mouseUp): (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): (KWQKHTMLPart::mouseMoved): (KWQKHTMLPart::sendContextMenuEvent): (fileWrapperForElement): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::keyboardUIMode):
11:47 AM Changeset in webkit [5232] by cblu
  • 7 edits in trunk

WebCore:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

Reviewed by rjw.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): call renamed frameRequiredForMIMEType:URL:
  • kwq/WebCoreBridge.h: renamed frameRequiredForMIMEType: to frameRequiredForMIMEType:URL:

WebKit:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

Reviewed by rjw.

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForExtension:]): If no plug-in is found from the extension, attempt to map from the extension to a MIME type using our mappings and find a plug-in from the MIME type. This improves our chances of finding a plug-in when no MIME type is specified.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): If the passed MIME is empty, nil it out so that clients only need to check for nil. This avoids error sheets complaining about "" MIME types. (-[WebBridge frameRequiredForMIMEType:URL:]): Renamed to include URL. If no MIME is specified, only create a plug-in view if we can map from the extension.

Oct 20, 2003:

1:35 PM Changeset in webkit [5231] by cblu
  • 9 edits in trunk/WebKit

Fixed: <rdar://problem/3457627>: empty Flash plugin at tvguide.com
Fixed issues with plug-in stream error handling.
Improved plug-in logging.

Reviewed by kocienda.

  • Misc.subproj/WebKitLogging.h: added WebKitLogPluginEvents
  • Misc.subproj/WebKitLogging.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.h:
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): improved logging (-[WebBaseNetscapePluginStream destroyStream]): improved logging (-[WebBaseNetscapePluginStream destroyStreamWithFailingReason:]): renamed from cancelWithReason to avoid confusion (-[WebBaseNetscapePluginStream receivedError:]): calls destroyStreamWithFailingReason after determining a reason from the NSError (-[WebBaseNetscapePluginStream cancelWithReason:]): calls destroyStreamWithFailingReason, this method is overriden by subclasses to cancel the actual load (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): call destroyStreamWithFailingReason, not cancelWithReason because the loaded has already ended here (-[WebBaseNetscapePluginStream deliverData]): improved logging
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): use even logging (-[WebBaseNetscapePluginView sendUpdateEvent]): ditto (-[WebBaseNetscapePluginView becomeFirstResponder]): ditto (-[WebBaseNetscapePluginView resignFirstResponder]): ditto (-[WebBaseNetscapePluginView mouseDown:]): ditto (-[WebBaseNetscapePluginView mouseUp:]): ditto (-[WebBaseNetscapePluginView mouseEntered:]): ditto (-[WebBaseNetscapePluginView mouseExited:]): ditto (TSMEventHandler): ditto (-[WebBaseNetscapePluginView destroyStream:reason:]): call cancelWithReason so the reason is passed back to the plug-in
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): tweak
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call receivedError (-[WebNetscapePluginRepresentation cancelWithReason:]): override, cancel the load, call super
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream cancelWithReason:]): override, cancel the load, call super (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): be sure to call the stream before calling super because the stream can be cleared out when calling super (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): ditto (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto
11:49 AM Changeset in webkit [5230] by rjw
  • 2 edits in trunk/WebKit

Conditionally excluded fix for 3446192. We'll enable the fix once 3446669
has been fixed. This patch switches to the new UTI typing API for pasteboard types.

Reviewed by Ken.

  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]):
11:22 AM Changeset in webkit [5229] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Add test for floating/positioning generated content.

11:18 AM Changeset in webkit [5228] by hyatt
  • 4 edits in trunk/WebCore

Fix generated content (before/after) so that it no longer has any restrictions on it. CSS2.1 lifted
restrictions preventing the floating/positioning of generated content.

Reviewed by rjw

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
11:09 AM Changeset in webkit [5227] by rjw
  • 5 edits in trunk/WebKit

WebBrowser

Add a debug menu item to always use ATSU text drawing. This will be helpful
to the ATSU folks in performance tuning there API. Right now I see approx.
2X slowdown using ATSU.
Reviewed by Chris.

  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleAlternateProgress:]): (-[BrowserDocument toggleUseATSUForAllTextDrawing:]):

WebKit

Fixed 3456103. Don't assert, just check for inappropriate state.
Reviewed by Hyatt

Add a debug menu item to always use ATSU text drawing. This will be helpful
to the ATSU folks in performance tuning there API. Right now I see approx.
2X slowdown using ATSU.

Also did some shuffling around of inline related stuff.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (isControlCharacter): (isAlternateSpace): (isSpace): (getUncachedWidth): (widthFromMap): (widthForGlyph): (+[WebTextRenderer _setAlwaysUseATSU:]): (glyphForCharacter): (glyphForUnicodeCharacter): (shouldUseATSU):
  • WebView.subproj/WebView.m: (+[WebView _setAlwaysUseATSU:]): (-[WebView _progressCompleted:]):
  • WebView.subproj/WebViewPrivate.h:
10:28 AM Changeset in webkit [5226] by kocienda
  • 15 edits in trunk/WebCore

Reviewed by David

  • khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Change over to use ascii value for key code. (UIEvent::which): Ditto. (KeyboardEvent::KeyboardEvent): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEvent::operator = ): New function. (KeyboardEvent::~KeyboardEvent): New function. (KeyboardEvent::ctrlKey): New function. (KeyboardEvent::shiftKey): New function. (KeyboardEvent::altKey): New function. (KeyboardEvent::metaKey): New function. (KeyboardEvent::altGraphKey): New function. (KeyboardEvent::initKeyboardEvent): New function.
  • khtml/dom/dom2_events.h: Ditto.
  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Use key identifiers to test which key was pressed, instead of removed keyVal(). (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new class name. Use key identifiers to test which key was pressed, instead of removed keyVal(). Use new modifier accessors.
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (EventImpl::idToType): Ditto. (KeyboardEventImpl::KeyboardEventImpl): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEventImpl::~KeyboardEventImpl): Ditto. (KeyboardEventImpl::initKeyboardEvent): Ditto.
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (DOM::KeyboardEventImpl::keyIdentifier): New function. (DOM::KeyboardEventImpl::keyLocation): New function. (DOM::KeyboardEventImpl::ctrlKey): New function. (DOM::KeyboardEventImpl::shiftKey): New function. (DOM::KeyboardEventImpl::altKey): New function. (DOM::KeyboardEventImpl::metaKey): New function. (DOM::KeyboardEventImpl::altGraphKey): New function. (DOM::KeyboardEventImpl::qKeyEvent): New function.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Now can create keyboard events.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Class name changes.
  • kwq/KWQEvent.h: Added QString identifier member.
  • kwq/KWQEvent.mm: (hexDigit): Added helper. (identifierForKeyText): Added new function to map keys to DOM key identifiers as listed in the DOM spec. (QKeyEvent::identifier): Added accessor.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::stateForCurrentEvent): Added check to see if a key press is on one of the numeric keypad keys.
  • kwq/KWQLogging.h: Added log constant for DOM events.
  • kwq/KWQLogging.m: Ditto
8:42 AM Changeset in webkit [5225] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3442218>: crash due to infinite recursion trying to load standalone plug-in content

Reviewed by darin.

  • WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]): manage the isStoppingLoad ivar, return if isStoppingLoad is YES
  • WebView.subproj/WebFramePrivate.h: added the isStoppingLoad ivar
7:59 AM Changeset in webkit [5224] by darin
  • 2 edits in trunk/WebKit

Reviewed by Dave and Ken.

  • fixed 3457066 -- REGRESSION (91-92): command-left-arrow causes a scroll to the left before going back
  • WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): Add an else so that we don't fall into the scrolling code when the command key is down for right and left arrow.
12:09 AM Changeset in webkit [5223] by hyatt
  • 2 adds in trunk/LayoutTests/fast/css-generated-content

Adding first-letter/before text-transform tests.

12:07 AM Changeset in webkit [5222] by hyatt
  • 7 edits in trunk/WebCore

Make first-letter and before/after work with text transforms.

Reviewed by mjs

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::isTextFragment): (RenderText::originalString): (RenderText::setText): (m_generatedContentStr): (m_start): (RenderTextFragment::~RenderTextFragment): (RenderTextFragment::isTextFragment): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h: (khtml::RenderTextFragment::start): (khtml::RenderTextFragment::end): (khtml::RenderTextFragment::contentString):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::setRenderer):
12:05 AM Changeset in webkit [5221] by hyatt
  • 2 edits in trunk/LayoutTests/fast

Layout tests affected by the removal of the list float quirk.

12:02 AM Changeset in webkit [5220] by hyatt
  • 3 edits in trunk/WebCore

Remove the "flow-around-floats" hack for lists. Other browsers don't do this.

Reviewed by darin

  • khtml/css/quirks.css:

Oct 19, 2003:

11:57 PM Changeset in webkit [5219] by hyatt
  • 3 edits in trunk/WebCore

Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse code in the collapsedRightBorder
case. I forgot to deal with colspans.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::cellRight): (RenderTableCell::collapsedRightBorder):
9:16 PM Changeset in webkit [5218] by hyatt
  • 3 edits in trunk/WebCore

Patch from KHTML trunk that makes textareas work properly even when they have no render objects.

  • khtml/html/html_formimpl.cpp: (HTMLTextAreaElementImpl::encoding): (HTMLTextAreaElementImpl::value):
5:45 PM Changeset in webkit [5217] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3454444 -- contents of mailto form shows up in Mail title instead of body (IE sends mail directly)
  • kwq/KWQKURL.mm: (KURL::parse): Changed non-hierarchical code to consider everything after a question mark as a query, just the way the hierarchical code does. This makes the code that constructs the mailto URL work properly.
11:08 AM Changeset in webkit [5216] by cblu
  • 7 edits
    1 add in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3229530>: Dragging standalone image to desktop should save it, not re-download it

Reviewed by darin.

  • English.lproj/Localizable.strings:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDocumentPrivate.h: Added.
  • WebView.subproj/WebImageRepresentation.h:
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation dealloc]): release new filename and data ivars (-[WebImageRepresentation doneLoading]): return YES if data is non-nil (-[WebImageRepresentation setDataSource:]): store the filename (-[WebImageRepresentation receivedError:withDataSource:]): store the data (-[WebImageRepresentation finishedLoadingWithDataSource:]): store the data (-[WebImageRepresentation data]): new (-[WebImageRepresentation filename]): new
  • WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): just save the image, don't download it (-[WebImageView image]): new

WebBrowser:

Fixed:
<rdar://problem/3456752>: Filename when saving a standalone image includes "nxn pixels"
<rdar://problem/3177870>: Context menu for standalone images should be "Save Image As..." not "Download Image to Disk"

Reviewed by darin.

  • BrowserDocument.m: (-[BrowserDocument displayName]): If we are saving a standalone image, use the responses suggestedFilename
  • ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): If this is a context menu for a standalone image, provide "Save Image As..." and "Copy Image to Clipboard" (-[BrowserWebView saveDocumentAs:]): renamed from savePageAs to be more generic
  • English.lproj/StringsNotToBeLocalized.txt:
Note: See TracTimeline for information about the timeline view.