Timeline
Oct 27, 2003:
- 4:51 PM Changeset in webkit [5280] by
-
- 2 edits in trunk/WebKit
- fixed 3441258 -- hysteresis to start dragging a link is too small; too easy to start drag
Reviewed by Chris.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): Split DragHysteresis into two values, one for links and one for images. Make the link one much larger than the image one (since dragging an image doesn't occur accidentally in the ways that dragging a link does).
- 12:51 PM Changeset in webkit [5279]
-
- 1 copy324 deletes in branches/unlabeled-1.70.4
This commit was manufactured by cvs2svn to create branch
'unlabeled-1.70.4'.
- 12:51 PM Changeset in webkit [5278] by
-
- 29 edits1 add in trunk/WebCore
Reviewed by Darin.
Improved exception blocking in the following ways:
- use C++ constructors and destructors so returning or breaking out of an exception block works
- Remove use of volatile
- Collapse the caught exception case into a single function call to reduce code size.
- WebCore.pbproj/project.pbxproj:
- kwq/KWQButton.mm:
- kwq/KWQCheckBox.mm:
- kwq/KWQComboBox.mm:
- kwq/KWQExceptions.h:
- kwq/KWQExceptions.mm: Added.
- kwq/KWQFileButton.mm:
- kwq/KWQFont.mm:
- kwq/KWQFrame.mm:
- kwq/KWQKConfigBase.mm:
- kwq/KWQKCookieJar.mm:
- kwq/KWQKCursor.mm:
- kwq/KWQKHTMLPart.mm:
- kwq/KWQKHTMLPartBrowserExtension.mm:
- kwq/KWQKHistoryProvider.mm:
- kwq/KWQKJavaAppletWidget.mm:
- kwq/KWQKJobClasses.mm:
- kwq/KWQKLocale.mm:
- kwq/KWQKPartsBrowserInterface.mm:
- kwq/KWQLineEdit.mm:
- kwq/KWQListBox.mm:
- kwq/KWQLoader.mm:
- kwq/KWQPainter.mm:
- kwq/KWQPushButton.mm:
- kwq/KWQRadioButton.mm:
- kwq/KWQScrollBar.mm:
- kwq/KWQScrollView.mm:
- kwq/KWQTextEdit.mm:
- kwq/KWQWidget.mm:
- 12:48 PM Changeset in webkit [5277] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3462523>: Safari Sometimes Destroys Applets When Going "Back"
Reviewed by darin.
- History.subproj/WebHistoryItem.m: (+[WebHistoryItem _destroyAllPluginsInPendingPageCaches]): Don't destroy plug-ins that are currently being viewed.
- 8:41 AM Changeset in webkit [5276] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3463144>: assertion failure when viewing jpeg with SoundPix installed
Reviewed by john.
- WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]): don't allow image types to override types that are already registered as we do in [WebFrameView _viewTypesAllowImageTypeOmission:]
- 8:28 AM Changeset in webkit [5275] by
-
- 2 edits in trunk/WebKit
Fixed:
<rdar://problem/3462977>: ER: Nice if images dragged from web pages didn't redownload
<rdar://problem/3031582>: Dragging an image to the desktop doesn't leave the file where I dropped it
<rdar://problem/3061371>: "CFURLGetFSRef failed" log when dragging image to Finder
Reviewed by john.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): attempt to fetch the image data from the cache, if that works, write out the file
Oct 26, 2003:
- 10:54 PM Changeset in webkit [5274] by
-
- 2 edits in trunk/WebCore
- khtml/khtml_part.cpp: (findWordBoundary): Fix small mistake from NULL check-in earlier.
- 10:38 PM Changeset in webkit [5273] by
-
- 2 edits in trunk/WebCore
- kwq/KWQLoader.mm: (KWQResponseMIMEType): Removed an excess volatile.
- 10:32 PM Changeset in webkit [5272] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Remove the word "Merlot".
- 10:32 PM Changeset in webkit [5271] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Updated change log to mention bug number for Merlot build fix.
- 10:31 PM Changeset in webkit [5270] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3463624 -- page at cinemakorea.com shows up blank due to kTECBufferBelowMinimumSizeErr from TEC
- kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): To work around the bug I found in the decoder (Radar 3351093), change kTECBufferBelowMinimumSizeErr to kTECOutputBufferFullStatus in cases where bytes were actually converted.
- 10:31 PM Changeset in webkit [5269] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed uses of NULL in non-pointer contexts
- khtml/khtml_part.cpp: (findWordBoundary): Changed NULL to 0 and did a little code cleanup of the surrounding code.
- khtml/rendering/break_lines.cpp: (khtml::isBreakable): Changed NULL to 0 and did a tiny bit of cleanup.
- WebCorePrefix.h: Add a definition of NULL here that takes advantage of the GNU null feature even if the system C library doesn't.
- 10:26 PM Changeset in webkit [5268] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3457831 -- REGRESSION: copying particular text and pasting (plain) produces lots of extra text
- khtml/khtml_part.cpp: (KHTMLPart::text): Check for the end node when following a link to the parent node, not just when following a link to the next child node.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Ditto.
- 8:53 PM Changeset in webkit [5267] by
-
- 2 edits in trunk/WebKit
- WebKitPrefix.h: Add a definition of NULL here so we get the stricter type checking even on pre-Merlot systems.
- 8:29 PM Changeset in webkit [5266] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCorePrefix.h: Added a C case to the NULL definition since we use C as well as C++ in this project.
- 8:24 PM Changeset in webkit [5265] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Revised ChangeLog to strike a reference to Merlot.
- 8:21 PM Changeset in webkit [5264] by
-
- 3 edits in trunk/JavaScriptCore
- rolled in some CString changes Harri Porten did on the KDE side
- kjs/ustring.cpp: (KJS::CString::CString): Use memcpy instead of strcpy for speed. Fix an off by one error in the copy constructor. (KJS::CString::operator=): Use memcpy instead of strcpy for speed.
- JavaScriptCorePrefix.h: Add a definition of NULL here that matches the one in Merlot. This makes us see warnings that otherwise would be Merlot-only warnings.
Oct 25, 2003:
- 4:53 PM Changeset in webkit [5263] by
-
- 2 edits in trunk
Rolled over ChangeLog, since checkouts were getting slow again.
WebCore:
Ditto.
Oct 24, 2003:
- 6:02 PM Changeset in webkit [5262] by
-
- 1 edit in trunk/WebKit/English.lproj/StringsNotToBeLocalized.txt
Fixed: <rdar://problem/3308160>: Safari goes bonkers on ftp:// URLs
Reviewed by hyatt.
- BrowserWebController.m: (-[BrowserWebView openURLExternallyWithRequest:inFrame:]): if Safari is the handler for a URL that we are attempting to launch, unset that preference. If the URL is FTP, set the finder as the handler.
- 5:21 PM Changeset in webkit [5261] by
-
- 3 edits in trunk
tree is open for Safari-112
- 5:18 PM Changeset in webkit [5260]
-
- 3 copies in tags/Safari-111
This commit was manufactured by cvs2svn to create tag 'Safari-111'.
- 5:18 PM Changeset in webkit [5259] by
-
- 8 edits in trunk
Safari-111 stamp.
77 bugs fixed since Safari-110!
- 4:10 PM Changeset in webkit [5258] by
-
- 5 edits in trunk
WebKit:
Fixed 3425358. Don't try to create page cache for pages that
have a nil view().
Reviewed by Hyatt.
- WebView.subproj/WebFrame.m: (-[WebFrame _createPageCacheForItem:]): (-[WebFrame _setState:]):
WebCore:
Fixed 3425358. Don't try to create page cache for pages that
have a nil view().
Reviewed by Hyatt.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
- 3:32 PM Changeset in webkit [5257] by
-
- 3 edits in trunk/WebCore
Fix for 3133375, the minwidth computation for pres is wrong. There were a couple of bugs here.
One is that pres only should have a breakable character if they contain a newline. Otherwise they're
treated essentially like nowrap. The other was that m_beginMinWidth and m_endMinWidth needed to be
set to the maxwidth of the first line and the maxwidth of the last line respectively for pres instead of
being only the first and last words.
Reviewed by mjs
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
- 2:44 PM Changeset in webkit [5256] by
-
- 2 adds in trunk/LayoutTests/fast/text/whitespace
Adding test of unicode breakability and whitespace.
- 2:20 PM Changeset in webkit [5255] by
-
- 476 edits in trunk/LayoutTests
Checking in the layout test results using our current defaults and not ancient crufty defaults.
- 2:07 PM Changeset in webkit [5254] by
-
- 3 edits in trunk/WebCore
Two fixes to the computation of min/max width for text runs.
(1) Make sure that pre runs don't add in word-spacing to the last word on a line (e.g., when a newline explicitly
breaks a pre).
(2) Fix a bug where breakable characters weren't getting factored into minwidth properly. When a word got broken
because of a breakable character, we were treating the breakable character like a space, and not including its
width as part of the minimum width of the text run.
Reviewed by john
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
- 2:05 PM Changeset in webkit [5253] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3424039>: standalone plug-in content occasionaly redirects to blank page
Reviewed by john.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): don't honor JS requests from standalone plug-ins to workaround 3462628 which is a deeper issue.
- 9:06 AM Changeset in webkit [5252] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3462256>: REGRESSION: Plain text is downloaded
Reviewed by john.
- WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): use _web_objectForMIMEType when getting an object for a MIME. Removed unnecessary code that checked for the document classes after loading the plug-in DB since it is not an optimization because the plug-in DB calls _viewTypesAllowImageTypeOmission:NO.
Oct 23, 2003:
- 4:47 PM Changeset in webkit [5251] by
-
- 8 edits in trunk/WebKit
Fixed: <rdar://problem/3364036>: ER: Allow plug-ins to override built-in types such as image/jpeg
Reviewed by john.
- Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Allow plug-ins to override built-in types except for our core HTML types and don't allow the QT plug-in to override any types because it handles many types that we already handle
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:): instead of asserting, handle the case where we ask a plug-in to map from an extension to a MIME type, but nil is returned (-[WebBridge frameRequiredForMIMEType:URL:]): no need to start up the plug-in DB because this is now handled by [WebView _viewClass:andRepresentationClass:forMIMEType:]
- WebView.subproj/WebDataSource.m: (+[WebDataSource _representationClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:] (-[WebDataSource _makeRepresentation]): call _representationClassForMIMEType
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): tweak (+[WebFrameView _viewClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:]
- WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): new, central place for mapping from a MIME to the document classes. We now load the plug-in DB when a non-HTML MIME type is encountered instead of loading the plug-in DB when the class for the MIME type is not found. This is required to fully fix 3364036. (+[WebView canShowMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:] (+[WebView registerViewClass:representationClass:forMIMEType:]): tweak
- WebView.subproj/WebViewPrivate.h:
- 3:24 PM Changeset in webkit [5250] by
-
- 2 adds in trunk/LayoutTests/fast/css-generated-content
Adding generated content tests for fancy first-letter/line combos.
- 3:23 PM Changeset in webkit [5249] by
-
- 16 edits in trunk/WebCore
This patch fixes the pseudo-elements ::first-line and ::first-letter to inherit styles properly. More
specifically it does the following:
(1) Implements caching of pseudo-styles once computed off the style() which originated the pseudo-style.
The old code did this, and this was a regression from my previous patch.
(2) Fixes first-letter checking so that it happens at layout time rather than during render object
construction time, since that makes first-letter more dynamic and causes it to be discovered in cases
where it was being missed before. This fixes the front page of meyerweb.com.
(3) Make first-letter inherit from first-line like it's supposed to, and also make first-line styles
cross blocks and inherit properly from enclosing containers.
(4) Make first-letter changes cause a detach/attach to fire just as when the display changes. I generalized
the notion of needing to detach on a style change by making it a new kind of hint in dom_nodeimpl's style
diff function.
(5) Fixed isBlockFlow to return true for inline-blocks.
Reviewed by john
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getFirstLineBox): (khtml::RenderBlock::firstLineBlock): (khtml::RenderBlock::updateFirstLetter):
- khtml/rendering/render_block.h: (khtml::RenderBlock::isBlockFlow):
- khtml/rendering/render_line.cpp: (InlineFlowBox::paintBackgroundAndBorder):
- khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
- khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::firstLineBlock): (RenderObject::updateFirstLetter): (RenderObject::dump): (RenderObject::setStyle): (RenderObject::recalcMinMaxWidths): (RenderObject::style): (RenderObject::getPseudoStyle):
- khtml/rendering/render_object.h: (khtml::RenderObject::overhangingContents):
- khtml/rendering/render_style.cpp: (pseudoBit):
- khtml/rendering/render_style.h: (khtml::RenderStyle::):
- khtml/rendering/render_table.cpp: (RenderTable::firstLineBlock): (RenderTable::updateFirstLetter):
- khtml/rendering/render_table.h:
- khtml/rendering/render_text.cpp: (RenderText::paintObject): (RenderText::htmlFont):
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::diff):
- khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::):
- 12:25 PM Changeset in webkit [5248] by
-
- 4 edits in trunk/WebKit
- fixed 3459272 -- Can't set up keyboard loop inside a WebDocumentView without subclassing views
- fixed 3179062 -- can't tab back to address bar from image-only page
- fixed 3252009 -- tabbing from address bar to content area does not work with WebTextView
- fixed 3461398 -- Can't click on a standalone image to focus it (for later keyboard scrolling)
I redid the way WebView and WebFrameView splice themselves into
the keyview loop in a way very similar to what NSScrollView and
NSClipView do. This means that contained and sibling views won't
need to do anything special to put themselves into the key loop.
Reviewed by Chris.
- WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollView]): check for nil pointer before dereferencing; this can happen during [super dealloc]'s keyview-loop-fixup code (-[WebFrameView initWithFrame:]): wire our nextKeyView link to the contained scrollview (so previousKeyView will work correctly from scrollview) (-[WebFrameView acceptsFirstResponder]): return what the contained scrollview says (-[WebFrameView becomeFirstResponder]): in previous direction, use previousValidKeyView (follows normal NSView keyview links); in forward direction, hand first responder-ness to contained scrollview (which will in turn hand it down to clipview, which will in turn hand it down to document) (-[WebFrameView setNextKeyView:]): wire up scrollview instead of self, if it exists
- WebView.subproj/WebImageView.m: (-[WebImageView acceptsFirstResponder]): overridden to return YES; this fixes 3461398 and puts the finishing touches on 3179062
- WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]): wire our nextKeyView link to the contained webframeview (so previousKeyView will work correctly from webframeview). Also, if there's a nextKeyView already set (in a nib, e.g.), wire it to our contained webframeview. (-[WebView acceptsFirstResponder]): return what the contained webframeview says (-[WebView becomeFirstResponder]): in previous direction, use previousValidKeyView (follows normal NSView keyview links); in forward direction, hand first responder-ness to contained webframeview (which will in turn hand it down to scrollview, etc.) (-[WebView setNextKeyView:]): wire up webframeview instead of self, if it exists
- 8:41 AM Changeset in webkit [5247] by
-
- 3 edits in trunk/WebCore
Reviewed by David
Fix for these bugs:
<rdar://problem/3171929>: Safari picks a different button in a
form when you hit return if the first button has no name
<rdar://problem/3200386>: investigate which button is activated
when hitting return in form text input fields
HTML spec says that buttons must have names to be considered
successful. However, other browsers do not impose this constraint.
Therefore, we behave differently, and can use different buttons than
the author intended.
- khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::isSuccessfulSubmitButton) (HTMLInputElementImpl::isSuccessfulSubmitButton)
