⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 30, 2003:

5:51 PM Changeset in webkit [5337] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3469330, the Marquee data in RenderStyle needs a copy constructor hack like all the other
objects do.

  • khtml/rendering/render_style.cpp: (direction):
  • khtml/rendering/render_style.h:
5:41 PM Changeset in webkit [5336] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3469206, images didn't paint outlines any more. They were bailing early because I forgot to
add a check for my new PaintAction.

Reviewed by darin

  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
5:27 PM Changeset in webkit [5335] by hyatt
  • 6 edits in trunk/WebCore

Fixes for 3469057, outlines not drawn on aintitcool.com and also for 3469178, objects with width/height of 0
incorrectly excluded from tabbing.

Reviewed by darin

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isSelectable):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isSelectable):
  • khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
  • khtml/rendering/render_inline.cpp: (RenderInline::addFocusRingRects): (RenderInline::paintOutline):
  • khtml/rendering/render_object.cpp: (RenderObject::addFocusRingRects): (RenderObject::getAbsoluteRepaintRectWithOutline):
4:47 PM Changeset in webkit [5334] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3426081 - empty cells HTMLCollection for <tr>
  • fixed 3367598 - "length" attribute for table row "cells" always returns 0
  • khtml/dom/html_table.cpp: (HTMLTableRowElement::cells): TR_CELLS, not TABLE_ROWS.
4:11 PM Changeset in webkit [5333] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3468916, outline needs its own paint action so that focus rings don't draw under other content.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats):
  • khtml/rendering/render_image.cpp: (RenderImage::paintObject):
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_layer.cpp: (RenderLayer::paintLayer):
  • khtml/rendering/render_object.h:
4:09 PM Changeset in webkit [5332] by mjs
  • 2 edits in branches/Safari-1-1-branch

Correct bug number in ChangeLogs.

3:35 PM Changeset in webkit [5331] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3458368>: drawing to the screen while window hidden: ​http://www.bhphotovideo.com/

Reviewed by john.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): clip out the plug-in when the window is miniaturized or hidden (-[WebBaseNetscapePluginView restartNullEvents]): don't restart null events if the window is miniaturized, this allows restartNullEvents to be called in start and viewDidMoveToWindow without needing to make the check (-[WebBaseNetscapePluginView start]): just call restartNullEvents instead of checking if the window is miniaturized
3:31 PM Changeset in webkit [5330] by mjs
  • 2 edits in trunk/WebCore

Fixed Dave's fix to my fix to my fix:

  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): Put back m_render check, consider the case of image with no width/height attributes and display:none set. We don't want to crash on that. (HTMLImageElementImpl::height): Ditto.
3:28 PM Changeset in webkit [5329] by hyatt
  • 1 edit in trunk/WebCore/khtml/html/html_imageimpl.cpp

Fix build bustage.

3:13 PM Changeset in webkit [5328]
  • 1 copy
    93 deletes in branches/unlabeled-1.41.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.41.4'.

3:13 PM Changeset in webkit [5327] by kocienda
  • 38 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt

Support for tabbing to links.

Fixes these bugs

<rdar://problem/3468395>: fix full keyboard access loop for buttons
<rdar://problem/3468397>: paint aqua focus rings around text links
<rdar://problem/3468406>: focused links do not activate by hitting

return key

<rdar://problem/3468410>: paintTextOutline in RenderText objects

should be done at a higher level

<rdar://problem/3468424>: improve function to determine if a node is

tab selectable

<rdar://problem/3468427>: add bridge function to access active

document view for a node

<rdar://problem/3468429>: links do not scroll into view when focusing
<rdar://problem/3468435>: when tabbing out of a frame, last focused

node is not cleared if it is a text link

<rdar://problem/3468436>: focus on text link does not clear when

clicking mouse in document body

<rdar://problem/3468440>: add setRect convenience to QRect
<rdar://problem/3468444>: elements paint their outlines even if they

are not visible

<rdar://problem/3468448>: setting focus on a node sets focus on all

its siblings

<rdar://problem/3468456>: cannot tab to form image input elements
<rdar://problem/3468461>: tab focus can seem to disappear from view on

pages with dhtml menus

<rdar://problem/3469021>: webcore bridge nextKeyView always starts
from the beginning of the document

  • WebCore-combined.exp: Export WebCoreGraphicsBridge class
  • WebCore.exp: Ditto
  • WebCore.pbproj/project.pbxproj: Add WebCoreGraphicsBridge class
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): border style check now take apple aqua style into account
  • khtml/css/cssvalues.in: Add -apple-aqua border value
  • khtml/css/html4.css: Change focus, a:link:active, and a:visited:active to use new -apple-aqua focus rings.
  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isSelectable): Improve function so that invisible elements are no longer considered selectable
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isSelectable): Ditto. (HTMLAnchorElementImpl::defaultEventHandler): Make return key activate links as well as Enter.
  • khtml/html/html_inlineimpl.h: Move isSelectable function into implementation file.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Do not paint outlines if content is invisible.
  • khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect): Improve function to correctly calculate repaint rects including outlines.
  • khtml/rendering/render_image.cpp: (RenderImage::paintObject): Do not paint outlines if content is invisible.
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject): Ditto. (RenderInline::addFocusRingRects): New function to gather up rects to use for painting outlines. (RenderInline::paintOutline): Added code to paint aqua focus rings.
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder): Add case for apple aqua border style. (RenderObject::addFocusRingRects): New function to gather up rects to use for painting outlines. (RenderObject::paintOutline): Added code to paint aqua focus rings. (RenderObject::getAbsoluteRepaintRectWithOutline): Helper function to calculate rectangle to use for repainting when an object has an outline.
  • khtml/rendering/render_object.h: Add addFocusRingRects declaration.
  • khtml/rendering/render_style.h: Add APPLEAQUA to border enum
  • khtml/rendering/render_text.cpp: (RenderText::paintObject): Removed code to draw outlines.
  • khtml/rendering/render_text.h: Ditto.
  • khtml/xml/dom_elementimpl.cpp: Removed redundant isSelectable check.
  • khtml/xml/dom_elementimpl.h: Ditto.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isSelectable): Added. (NodeBaseImpl::setFocus): Do not set focus on siblings.
  • khtml/xml/dom_nodeimpl.h: Moved implementation to .cpp file.
  • kwq/KWQButton.mm: (-[KWQButton nextKeyView]): Send a blur before going to next key view. This prevents focus from being lost altogether. (-[KWQButton previousKeyView]): Ditto.
  • kwq/KWQKHTMLPart.h: Added documentViewForNode function.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Add check for other focusables, like text links. (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Remove focus when leaving a view. (KWQKHTMLPart::documentViewForNode): Added. (KWQKHTMLPart::khtmlMousePressEvent): Remove focus when you click in a non-focusable area, like the document body.
  • kwq/KWQPainter.h: Added declarations.
  • kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): Modified constructor for new fields. (QPainter::initFocusRing): Added. (QPainter::addFocusRingRect): Added. (QPainter::drawFocusRing): Added. (QPainter::clearFocusRing): Added.
  • kwq/KWQRect.h: (QRect::setRect): Added.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyView]): Start from the currently-focused node, if there is one, not unconditionally from the start of the document. (-[WebCoreBridge previousKeyView]): Ditto
  • kwq/WebCoreGraphicsBridge.h: Added.
  • kwq/WebCoreGraphicsBridge.m: Added. (+[WebCoreGraphicsBridge sharedBridge]): Added. (-[WebCoreGraphicsBridge init]): Added. (-[WebCoreGraphicsBridge setFocusRingStyle:radius:color:]): Added.

WebKit:

Reviewed by Hyatt

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge documentView]): Added.
  • WebCoreSupport.subproj/WebGraphicsBridge.h: Added.
  • WebCoreSupport.subproj/WebGraphicsBridge.m: Added. (+[WebGraphicsBridge createSharedBridge]): Added. (-[WebGraphicsBridge setFocusRingStyle:radius:color:]): Added.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebFrameView.m: Create a WebGraphicsBridge when creating a WebFrameView.
2:51 PM Changeset in webkit [5326] by mjs
  • 2 edits in trunk/WebCore

Fix mistake in my last change that I did not mean to commit.

  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): Remove extraneous second attempt to lay out.
2:50 PM Changeset in webkit [5325] by hyatt
  • 4 edits in trunk/WebCore

Put paged-media changes back without the wrongful removal of the style data copy constructors (which
were necessary after all).

  • ChangeLog:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/rendering/render_style.cpp: (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::widows): (khtml::RenderStyle::orphans): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::setWidows): (khtml::RenderStyle::setOrphans): (khtml::RenderStyle::setPageBreakInside): (khtml::RenderStyle::setPageBreakBefore): (khtml::RenderStyle::setPageBreakAfter):
2:42 PM Changeset in webkit [5324] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3468129 - REGRESSION: FOUC occurs on Surfin' Safari
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): Don't force layout for image width/height if you can determine it statically from the attribute.
2:40 PM Changeset in webkit [5323] by mjs
  • 5 edits in branches/Safari-1-1-branch

WebCore:

Merged fix for the following bug from HEAD:

  • fixed 3183754 - returning false from key press handlers does not prevent typing or form submission
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent):

WebKit:

Merged fix for the following bug from HEAD:

  • fixed 3183754 - returning false from key press handlers does not prevent typing or form submission
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]):
2:26 PM Changeset in webkit [5322] by vicki
  • 3 edits in trunk

fixed version number. tree is open.

2:23 PM Changeset in webkit [5321]
  • 3 copies in tags/Safari-112

This commit was manufactured by cvs2svn to create tag 'Safari-112'.

2:23 PM Changeset in webkit [5320] by vicki
  • 3 edits in trunk

forgot to tag before setting the version number back (doh!)

2:22 PM Changeset in webkit [5319] by vicki
  • 3 edits in trunk

tree is open for Safari-113

2:20 PM Changeset in webkit [5318] by vicki
  • 6 edits in trunk

Safari-112 stamp

2:00 PM Changeset in webkit [5317] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by me

Rolling out this code since it caused a big performance
regression.

2003-10-29 David Hyatt <​hyatt@apple.com>

Add the paged media properties to RenderStyle.
They aren't used yet, but they should now be
parsed and interpreted correctly.

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData): (StyleBoxData::StyleBoxData): (StyleBoxData::operator==): (StyleVisualData::~StyleVisualData): (StyleVisualData::StyleVisualData): (StyleBackgroundData::StyleBackgroundData): (StyleFlexibleBoxData::StyleFlexibleBoxData): (opacity): (textShadow): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::~StyleInheritedData): (StyleInheritedData::operator==):
  • khtml/rendering/render_style.h: (khtml::StyleBackgroundData::~StyleBackgroundData): (khtml::StyleFlexibleBoxData::~StyleFlexibleBoxData): (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults):
12:59 PM Changeset in webkit [5316] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Corrected ChangeLog.

12:59 PM Changeset in webkit [5315] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

  • fixed 3427069 - browsing mp3.com causes leaks (KJS)
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Don't do an early return, since that could leak a temporary regexp.
10:42 AM Changeset in webkit [5314] by mjs
  • 6 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • kjs/grammar.cpp: (yyerror): Updated the commented code.
  • kjs/grammar.y: Don't delete string and identifier tokens when done with them any more, they'll get cleaned up by the lexer now.
  • kjs/internal.cpp: (Parser::parse): Tell lexer when done parsing.
  • kjs/lexer.cpp: (Lexer::Lexer): Initialize new data members. (Lexer::lex): Use new methods to make strings and identifiers, and save them. (Lexer::makeIdentifier): Make a new Identifier and save it in an auto-growing array. (Lexer::makeUString): Likewise for UStrings. (Lexer::doneParsing): Clean up arrays of Ifentifiers and UStrings.
  • kjs/lexer.h:
12:26 AM Changeset in webkit [5313] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3466628, widgets in overflow blocks don't move when the overflow block is scrolled. This
was a regression caused by my change to move widgets only during layout and not at paint time. The
problem with this is that scrolling an overflow block doesn't do a layout, just a repaint. I patched
the layer code to update widget positions on an overflow block scroll.

This then exposed a bug in absolutePosition, namely that the scroll offset was never factored in when
computing absolutePosition. This bug also explains why text selection and cursor display were wrong
inside scrolled overflow blocks.

Reviewed by mjs

  • khtml/rendering/render_box.cpp: (RenderBox::absolutePosition):
  • khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset):
  • khtml/rendering/render_object.cpp: (RenderObject::absolutePosition):
  • khtml/rendering/render_text.cpp: (RenderText::cursorPos): (RenderText::posOfChar):
  • khtml/rendering/render_text.h:

Oct 29, 2003:

11:31 PM Changeset in webkit [5312] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Release lastModifiedDate.
10:55 PM Changeset in webkit [5311] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3467499 - REGRESSION: onClick handlers on links don't work (bubbling broken)
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::EventImpl): Initialize m_cancelBubble (duh).
9:45 PM Changeset in webkit [5310] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3466802. When breaking on a newline, "pre" is determined by checking the actual object that
the line broke on, and not by simply checking the "pre" status of the containing block.

Reviewed by mjs

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
9:12 PM Changeset in webkit [5309] by hyatt
  • 4 edits in trunk/WebCore

Add the paged media properties to RenderStyle. They aren't used yet, but they should now be
parsed and interpreted correctly.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/rendering/render_style.cpp: (StyleBoxData::operator==): (StyleFlexibleBoxData::StyleFlexibleBoxData): (:opacity): (:textShadow): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::widows): (khtml::RenderStyle::orphans): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::setWidows): (khtml::RenderStyle::setOrphans): (khtml::RenderStyle::setPageBreakInside): (khtml::RenderStyle::setPageBreakBefore): (khtml::RenderStyle::setPageBreakAfter):
5:30 PM Changeset in webkit [5308] by cblu
  • 3 edits in trunk/WebKit

WebKit:

WebKit part of fix for:
<rdar://problem/3467744>: Photoshop files (.psd) don't show up in Open dialog in Safari, but can be viewed
<rdar://problem/3109132>: Can't open movie file via open panel even though it can be dropped in browser window

Reviewed by john.

  • WebView.subproj/WebView.m: (+[WebView _supportedMIMETypes]): new (+[WebView _supportedFileExtensions]): new
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Fixed:
<rdar://problem/3467744>: Photoshop files (.psd) don't show up in Open dialog in Safari, but can be viewed
<rdar://problem/3109132>: Can't open movie file via open panel even though it can be dropped in browser window

Reviewed by john.

  • BrowserDocumentController.m: (-[BrowserDocumentController _openableFileExtensions]): override, returns list of types that Safari and WebKit can handle so the NSOpenPanel properly enables files
2:36 PM Changeset in webkit [5307] by cblu
  • 10 edits in trunk/WebKit

Fixed: <rdar://problem/3438716>: jpg and gif images copied from Safari and placed in mail are sent as tiff

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeFileContents:withFilename:]): new
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:originalData:rect:URL:title:event:]): now takes originalData and calls _web_fileContents:withFilename:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): call _web_writeFileContents:withFilename:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): call renamed _web_dragImage and [WebView _cachedResponseForURL:] (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebView _cachedResponseForURL:]
  • WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:]): call _web_writeFileContents:withFilename: (-[WebImageView mouseDragged:]): call renamed _web_dragImage
  • WebView.subproj/WebView.m: (-[WebView _cachedResponseForURL:]): new
  • WebView.subproj/WebViewPrivate.h:
1:47 PM Changeset in webkit [5306] by hyatt
  • 2 edits in trunk/WebCore

Refine the fix to updateLayout.
updateStyleSelector would get called over and over again when you queried for layout properties from
JS. If no stylesheets are pending, this isn't necessary (and is quite expensive, since updateStyleSelector
is a slow function).

Reviewed by darin

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateLayout):
1:15 PM Changeset in webkit [5305] by hyatt
  • 2 edits in trunk/WebCore

Fix crasher in border collapsing code.

Reviewed by kocienda

  • khtml/rendering/render_table.cpp: (RenderTable::cellRight):
12:08 PM Changeset in webkit [5304] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3163842 - Citibank cardmember central DHTML menus not working right in Safari
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): update layout before fetching image properties that need it.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_ignorePendingStylesheets to false. (DocumentImpl::updateLayout): Ignore pending stylesheets - when JS demands a layout, it wants a real one now. (DocumentImpl::updateStyleSelector): Go ahead with the update if we're ignoring pending stylesheets.
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::haveStylesheetsLoaded): Pretend stylesheets have loaded if we're temporarily ignoring pending stylesheets.
1:18 AM Changeset in webkit [5303] by hyatt
  • 2 adds in trunk/LayoutTests/fast/text/whitespace

Add layout test for pre minwidth bugs.

1:02 AM Changeset in webkit [5302] by hyatt
  • 2 adds in trunk/LayoutTests/fast/inline-block

Add inline block test inside a center tag.

12:57 AM Changeset in webkit [5301] by hyatt
  • 31 edits in trunk/WebCore

Implement support for <marquee>. This includes support for the CSS3 specification (although modified a fair
bit to actually be compatible with WinIE's version and to correct obvious errors in the draft). All of the
marquee behaviors (slide, scroll, and alternate) are supported.

This patch also fixes the following bugs that were discovered while testing marquee:
(1) An error in the computation of scrollWidth and scrollHeight.
(2) The ability to ask for the leftmostPosition as well as the rightmostPosition of content and to
be able to ask for the positions of children (via left/right/lowest) without including the parent in the
computation.
(3) An optimization to RenderFlow's rightmost/lowestPosition functions to avoid examining text elements since
they are always fully accounted for by either overflow or by inline flow boxes.
(4) A fix for RTL rendering. A block with direction:RTL was being placed on the right, when in reality only
its children should be placed on the right.
(5) A fix to prevent inline blocks and tables from computing auto margins (making them just like floats in this
regard).

Reviewed by darin

  • khtml/css/cssparser.cpp: (validUnit): (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::convertToLength): (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/html/html_blockimpl.cpp: (HTMLMarqueeElementImpl::HTMLMarqueeElementImpl): (HTMLMarqueeElementImpl::id): (HTMLMarqueeElementImpl::parseAttribute):
  • khtml/html/html_blockimpl.h: (DOM::HTMLMarqueeElementImpl::minimumDelay):
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcWidth): (RenderBox::calcHorizontalMargins): (RenderBox::lowestPosition): (RenderBox::rightmostPosition): (RenderBox::leftmostPosition):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition): (RenderFlow::leftmostPosition):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPositions): (RenderLayer::scrollToOffset): (RenderLayer::computeScrollDimensions): (RenderLayer::styleChanged): (RenderLayer::stopMarquees): (m_whiteSpace): (Marquee::marqueeSpeed): (Marquee::direction): (Marquee::isHorizontal): (Marquee::computePosition): (Marquee::start): (Marquee::stop): (Marquee::updateMarqueePosition): (Marquee::updateMarqueeStyle): (Marquee::timerEvent):
  • khtml/rendering/render_layer.h: (khtml::): (khtml::RenderLayer::marquee):
  • khtml/rendering/render_object.cpp: (RenderObject::isHTMLMarquee): (RenderObject::sizesToMaxWidth):
  • khtml/rendering/render_object.h: (khtml::RenderObject::lowestPosition): (khtml::RenderObject::rightmostPosition): (khtml::RenderObject::leftmostPosition):
  • khtml/rendering/render_style.cpp: (StyleMarqueeData::StyleMarqueeData): (StyleMarqueeData::operator==): (opacity): (marquee): (StyleCSS3NonInheritedData::operator==): (RenderStyle::RenderStyle):
  • khtml/rendering/render_style.h: (khtml::): (khtml::StyleMarqueeData::operator!=): (khtml::RenderStyle::marqueeIncrement): (khtml::RenderStyle::marqueeSpeed): (khtml::RenderStyle::marqueeLoopCount): (khtml::RenderStyle::marqueeBehavior): (khtml::RenderStyle::marqueeDirection): (khtml::RenderStyle::setMarqueeIncrement): (khtml::RenderStyle::setMarqueeSpeed): (khtml::RenderStyle::setMarqueeDirection): (khtml::RenderStyle::setMarqueeBehavior): (khtml::RenderStyle::setMarqueeLoopCount):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clearTimers):
12:29 AM Changeset in webkit [5300] by hyatt
  • 1 edit in trunk/LayoutTests/fast/selectors/064-expected.txt

Fixing the layout test that has a <button>

12:16 AM Changeset in webkit [5299] by hyatt
  • 2 edits in trunk/WebCore

Make <button> be an inline-block.

  • khtml/css/html4.css:

Oct 28, 2003:

11:22 PM Changeset in webkit [5298] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3465547 - REGRESSION (100-111)?: window.prompt does not work
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::runJavaScriptPrompt): Return the result properly instead of always returning false.
10:31 PM Changeset in webkit [5297] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3465504 -- REGRESSION (100-111): text areas with Chinese text in them are wider than ones without
  • kwq/KWQTextArea.h: Add _font field.
  • kwq/KWQTextArea.mm: (-[KWQTextArea dealloc]): Release _font. (-[KWQTextArea setFont:]): Store font in _font as well as setting it in the text view. (-[KWQTextArea sizeWithColumns:rows:]): Use _font rather than asking the text view for the font.
9:42 PM Changeset in webkit [5296] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3464702 -- node.item(x) is not implemented (dynamic menus not filled out at techcu.com)
  • khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Add implementation of item function.
  • khtml/ecma/kjs_dom.h: Added Item to the enum.
  • khtml/ecma/kjs_dom.lut.h: Regenerated.
5:23 PM Changeset in webkit [5295] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Dave,

  • fixed 3379725 - for <a> elements with both onclick and href, Web Kit's behavior does not match other browsers

The fix for this was to make cancelBubble only prevent bubbling,
but not stop propagation or prevent default. While I was at it, I
made returnValue work right too.

  • khtml/ecma/kjs_events.cpp: (DOMEvent::getValueProperty): Implement cancelBubble and returnValue properties properly. (DOMEvent::putValue): Ditto.
  • khtml/dom/dom2_events.cpp: (Event::setCancelBubble): Call impl. (Event::setDefaultPrevented): Ditto. (Event::getCancelBubble): Ditto. (Event::defaultPrevented): Ditto.
  • khtml/dom/dom2_events.h:
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::propagationStopped): Made this a const method. (DOM::EventImpl::defaultPrevented): Ditto. (DOM::EventImpl::setCancelBubble): Implemented by setting a new field. (DOM::EventImpl::getCancelBubble): Corresponding getter. (DOM::EventImpl::setDefaultPrevented): Set the already existing field for this.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Check getCancelBubble() when bubbling. Do not check bubbles() before default handling.
4:39 PM Changeset in webkit [5294] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3466082>: 7B85/111: Crash viewing web page ([WebView setNextKeyView:])

Reviewed by Chris.

  • WebView.subproj/WebView.m: (-[WebView dealloc]): set _private to nil after releasing, because [super dealloc] can dispatch to it (-[WebView mainFrame]): fixed spelling error in comment
4:00 PM Changeset in webkit [5293] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/3464472>: REGRESSION: New CSS cursor support breaks style="cursor:default

Reviewed by dave.

  • kwq/KWQWidget.mm: (QWidget::cursor): break after we hit a view that responds to documentCursor as we do in setCursor. Without breaking we were returning the cursor of the most super HTML view which is not what we want.
3:06 PM Changeset in webkit [5292] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3421393 - window.open does not handle non-integral height/width (small window at saabusa.com)
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Parse width, height, top and left as floating point and then cast to int instead of parsing as int to match other browsers and avoid rejecting floating point numbers.
2:52 PM Changeset in webkit [5291] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed 3413962 - malicious web pages can kill all future JavaScript execution by breaking recursion limit check
  • kjs/nodes.cpp: (FunctionCallNode::evaluate): If we're going to return early due to breaking the recursion limit, make sure to lower it again, or it will creep up by one each time it's exceeded.
2:21 PM Changeset in webkit [5290] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3464528 - addEventListener does not work for buttons, text areas, or inputs
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotClicked): Send CLICK_EVENT as well as one of KHTML_CLICK_EVENT or KHTML_DOUBLE_CLICK_EVENT.
2:21 PM Changeset in webkit [5289] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop

Reviewed by john.

  • WebView.subproj/WebFrame.m: (-[WebFrame _isLoadComplete]): call _progressCompleted after we deliver the didFailLoadWithError or didFinishLoadForFrame message as we do in other places. This allows to be aware of the error (if there is one), when they get the WebViewProgressFinishedNotification notification.

WebBrowser:

Fixed:
<rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop
<rdar://problem/3465910>: REGRESSION (100-110): Switching to bookmarks view shows progress bar but shouldn't

Reviewed by john.

  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebView setMainFrameLoadEndedInError:]): new (-[BrowserWebView progressFinished:]): if we have a main frame error, set the progress bar to 0
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): call setMainFrameLoadEndedInError:NO for the main frame (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): call setMainFrameLoadEndedInError:YES for the main frame
1:27 PM Changeset in webkit [5288] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didSetName:]): Tell the WebFrame about its new name.
11:52 AM Changeset in webkit [5287] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3465613 -- REGRESSION (111): Crash creating nib that contains WebView

Reviewed by Chris.

  • WebView.subproj/WebView.m: (-[WebView mainFrame]): check for nil _private before dereferencing.
11:45 AM Changeset in webkit [5286] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3465591>: Security: Netscape plug-ins can execute JavaScript in other frames

Reviewed by mjs.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): renamed, no need to pass the target frame since the target is either the plug-in itself or the frame that contains the plug-in (-[WebBaseNetscapePluginView loadPluginRequest:]): call renamed evaluateJavaScriptPluginRequest (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): if this is a JS request that is targeted at a frame, return NPERR_INVALID_PARAM if the frame is not the frame that contains the plugin
11:40 AM Changeset in webkit [5285] by mjs
  • 2 edits in trunk/WebCore

Fixed broken build.

  • kwq/KWQKPartsPart.mm: (KParts::ReadOnlyPart::setName): It's a ReadOnlyPart method, not a Part method.
11:15 AM Changeset in webkit [5284] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3437959>: javascript: URLs don't work from Java (and other Cocoa plugins, if any)

Reviewed by mjs.

  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): support JS requests targeted only to the plug-in's frame.
11:13 AM Changeset in webkit [5283] by mjs
  • 6 edits in trunk/WebCore

Reviewed by John.

  • fixed 3427046 - href and src attributes don't always give resolved URL

It turns out that all href and src attributes should be resolved
against the base, except for frame elements.

  • khtml/dom/html_base.cpp: (HTMLIFrameElement::src): Resolve against base URL.
  • khtml/dom/html_form.cpp: (HTMLInputElement::src): Resolve URL even when empty. Remove comment questioning resolution against base - it's definitely right.
  • khtml/dom/html_head.cpp: (HTMLBaseElement::href): Resolve against base URL. (HTMLLinkElement::href): Ditto. (HTMLScriptElement::src): Ditto.
  • khtml/dom/html_image.cpp: (HTMLAreaElement::href): Ditto. (HTMLImageElement::src): Resolve URL even when empty. Remove comment questioning resolution against base - it's definitely right.
  • khtml/dom/html_inline.cpp: (HTMLAnchorElement::href): Resolve against base URL.
11:12 AM Changeset in webkit [5282] by mjs
  • 7 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setName): Make sure the name is unique. Then tell the bridge and the superclass about it.
  • kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::setName): Made this method virtual.
  • kwq/KWQKPartsPart.m: Added. Moved implementations of virtual methods here.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setName:]): Call the superclass method to avid sending the name pointlessly back across the bridge.
8:46 AM Changeset in webkit [5281] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3465063 -- REGRESSION (107-108): hang when fetching a page with an ad in a subframe (theage.com.au)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Follow the parent chain properly rather than repeatedly getting the part's own parent!

Oct 27, 2003:

4:51 PM Changeset in webkit [5280] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3441258 -- hysteresis to start dragging a link is too small; too easy to start drag

Reviewed by Chris.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): Split DragHysteresis into two values, one for links and one for images. Make the link one much larger than the image one (since dragging an image doesn't occur accidentally in the ways that dragging a link does).
12:51 PM Changeset in webkit [5279]
  • 1 copy
    324 deletes in branches/unlabeled-1.70.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.70.4'.

12:51 PM Changeset in webkit [5278] by mjs
  • 29 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Improved exception blocking in the following ways:

  • use C++ constructors and destructors so returning or breaking out of an exception block works
  • Remove use of volatile
  • Collapse the caught exception case into a single function call to reduce code size.
  • WebCore.pbproj/project.pbxproj:
  • kwq/KWQButton.mm:
  • kwq/KWQCheckBox.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQExceptions.h:
  • kwq/KWQExceptions.mm: Added.
  • kwq/KWQFileButton.mm:
  • kwq/KWQFont.mm:
  • kwq/KWQFrame.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKCookieJar.mm:
  • kwq/KWQKCursor.mm:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQKHistoryProvider.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKLocale.mm:
  • kwq/KWQKPartsBrowserInterface.mm:
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQLoader.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQPushButton.mm:
  • kwq/KWQRadioButton.mm:
  • kwq/KWQScrollBar.mm:
  • kwq/KWQScrollView.mm:
  • kwq/KWQTextEdit.mm:
  • kwq/KWQWidget.mm:
12:48 PM Changeset in webkit [5277] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3462523>: Safari Sometimes Destroys Applets When Going "Back"

Reviewed by darin.

  • History.subproj/WebHistoryItem.m: (+[WebHistoryItem _destroyAllPluginsInPendingPageCaches]): Don't destroy plug-ins that are currently being viewed.
8:41 AM Changeset in webkit [5276] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3463144>: assertion failure when viewing jpeg with SoundPix installed

Reviewed by john.

  • WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]): don't allow image types to override types that are already registered as we do in [WebFrameView _viewTypesAllowImageTypeOmission:]
8:28 AM Changeset in webkit [5275] by cblu
  • 2 edits in trunk/WebKit

Fixed:
<rdar://problem/3462977>: ER: Nice if images dragged from web pages didn't redownload
<rdar://problem/3031582>: Dragging an image to the desktop doesn't leave the file where I dropped it
<rdar://problem/3061371>: "CFURLGetFSRef failed" log when dragging image to Finder

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): attempt to fetch the image data from the cache, if that works, write out the file

Oct 26, 2003:

10:54 PM Changeset in webkit [5274] by darin
  • 2 edits in trunk/WebCore
  • khtml/khtml_part.cpp: (findWordBoundary): Fix small mistake from NULL check-in earlier.
10:38 PM Changeset in webkit [5273] by darin
  • 2 edits in trunk/WebCore
  • kwq/KWQLoader.mm: (KWQResponseMIMEType): Removed an excess volatile.
10:32 PM Changeset in webkit [5272] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Remove the word "Merlot".

10:32 PM Changeset in webkit [5271] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Updated change log to mention bug number for Merlot build fix.

10:31 PM Changeset in webkit [5270] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3463624 -- page at cinemakorea.com shows up blank due to kTECBufferBelowMinimumSizeErr from TEC
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): To work around the bug I found in the decoder (Radar 3351093), change kTECBufferBelowMinimumSizeErr to kTECOutputBufferFullStatus in cases where bytes were actually converted.
10:31 PM Changeset in webkit [5269] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed uses of NULL in non-pointer contexts
  • khtml/khtml_part.cpp: (findWordBoundary): Changed NULL to 0 and did a little code cleanup of the surrounding code.
  • khtml/rendering/break_lines.cpp: (khtml::isBreakable): Changed NULL to 0 and did a tiny bit of cleanup.
  • WebCorePrefix.h: Add a definition of NULL here that takes advantage of the GNU null feature even if the system C library doesn't.
10:26 PM Changeset in webkit [5268] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3457831 -- REGRESSION: copying particular text and pasting (plain) produces lots of extra text
  • khtml/khtml_part.cpp: (KHTMLPart::text): Check for the end node when following a link to the parent node, not just when following a link to the next child node.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Ditto.
8:53 PM Changeset in webkit [5267] by darin
  • 2 edits in trunk/WebKit
  • WebKitPrefix.h: Add a definition of NULL here so we get the stricter type checking even on pre-Merlot systems.
8:29 PM Changeset in webkit [5266] by darin
  • 2 edits in trunk/JavaScriptCore
  • JavaScriptCorePrefix.h: Added a C case to the NULL definition since we use C as well as C++ in this project.
8:24 PM Changeset in webkit [5265] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Revised ChangeLog to strike a reference to Merlot.

8:21 PM Changeset in webkit [5264] by darin
  • 3 edits in trunk/JavaScriptCore
  • rolled in some CString changes Harri Porten did on the KDE side
  • kjs/ustring.cpp: (KJS::CString::CString): Use memcpy instead of strcpy for speed. Fix an off by one error in the copy constructor. (KJS::CString::operator=): Use memcpy instead of strcpy for speed.
  • JavaScriptCorePrefix.h: Add a definition of NULL here that matches the one in Merlot. This makes us see warnings that otherwise would be Merlot-only warnings.
Note: See TracTimeline for information about the timeline view.