Context Navigation

khtml/rendering/render_image.cpp: (RenderImage::selectionTintColor): new, takes style into account (RenderImage::paintObject): use selectionTintColor
khtml/rendering/render_image.h:
kwq/KWQPainter.h: removed selectedImageTintColor
kwq/KWQPainter.mm:

3:52 PM Changeset in webkit [5447] by hyatt

9 edits in trunk/WebCore

Fix for 3479287, macro-ize the handling of the CSS 'inherit' value. This patch is preparation for
adding support for the 'initial' value, which will be used to fix the CSS parser's shorthand parsing
bugs.

Reviewed by kocienda

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/khtmlview.cpp: (KHTMLView::layout):

3:21 PM Changeset in webkit [5446] by cblu

5 edits in trunk/WebCore

Fixed:
<rdar://problem/3478883>: REGRESSION (113-114u): drag image for selected text includes unselected images
<rdar://problem/3479204>: selected images don't look selected

Reviewed by dave.

khtml/rendering/render_image.cpp: (RenderImage::RenderImage): init m_selectionState (RenderImage::paintObject): draw a tint over the image if selected, don't draw anything if not selected and the action is PaintActionSelection
khtml/rendering/render_image.h: (khtml::RenderImage::selectionState): new (khtml::RenderImage::setSelectionState): new
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::selectedImageTintColor): new

2:41 PM Changeset in webkit [5445] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3477795>: REGRESSION: can't submit form without
submit button by hitting return (cocoadev.com)

When I changed submitting forms using the return key in a text field
to go through a search for the correct submit or image input
element to use when submitting, I neglected to cover the case of
forms which have neither a submit or image input element. When
I encounter a form such as this now, I submit it anyway after
performing the submit or image input element and failing to find one.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::performSubmitClick)

1:54 PM Changeset in webkit [5444] by rjw

2 edits in trunk

Forget to change NOBODY to Darin.

1:51 PM Changeset in webkit [5443] by rjw

12 edits in trunk

WebKit:

Fixed 3478765. Use ICU to access unicode properties.
Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.
Fixed 3478885. Remove dead arabic shaping code

Reviewed by NOBODY (OOPS!).

Misc.subproj/WebUnicode.h:
Misc.subproj/WebUnicode.m: (_unicodeDigitValue): (_unicodeDirection): (_unicodeMirrored): (_unicodeMirroredChar): (_unicodeLower): (_unicodeUpper): (WebKitInitializeUnicode): (shapeForNextCharacter): (initializeCharacterShapeIterator):
Misc.subproj/WebUnicodeTables.m:
WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter): (fontContainsString):

WebCore:

Fixed 3478765. Use ICU to access unicode properties.
Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.

Reviewed by NOBODY (OOPS!).

WebCore-combined.exp:
WebCore.exp:
kwq/KWQChar.mm: (QChar::lower): (QChar::upper): (QChar::mirroredChar):
kwq/KWQString.h: (QChar::direction):
kwq/WebCoreUnicode.cpp:
kwq/WebCoreUnicode.h:

12:45 PM Changeset in webkit [5442] by rjw

1 add in trunk/LayoutTests/css1/text_properties/text-transform-expected.txt

Added expected results for text-transform test.

12:42 PM Changeset in webkit [5441] by rjw

1 edit in trunk/LayoutTests/css1/text_properties/text-transform.html

Removed Turkish and Deseret from the test case. These don't work yet.

11:58 AM Changeset in webkit [5440] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3478351>: Safari: URL Alias on Dock failed to open the 2byte URL

Reviewed by dave.

Misc.subproj/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]): if the host name is percent-escaped, use CFURLCreateStringByReplacingPercentEscapes

10:49 AM Changeset in webkit [5439] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3478781>: drag image of selected text and images doesn't include images

Reviewed by rjw.

khtml/rendering/render_image.cpp: (RenderImage::paintObject): paint when the paint action is PaintActionSelection
khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): ditto

10:46 AM Changeset in webkit [5438] by kocienda

4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3477624>: REGRESSION (113): Using input method to
enter non-ascii text submits the form

This regression has been in the tree for a couple of versions now,
since we improved the way key events are processed. The solution
is to ask the text input manager if it has any marked text when
the return key (or enter key) is pressed, because if it does, the key
needs to work in the "accept" role for the input manager. Fixing
in this way has the pleasant effect of making return/enter key
behavior "do the right thing" based on context.

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Add check to see if text input manager has marked text before submitting text and password fields. Broke out key handling for checkboxes and radios, since the old code for these widgets worked fine.
kwq/KWQLineEdit.h: Added hasMarkedText function.
kwq/KWQLineEdit.mm: (QLineEdit::hasMarkedText): Returns whether the current input manager has marked text or not.

10:00 AM Changeset in webkit [5437] by rjw

2 edits in trunk/WebKit

Use ICU for upper/lower conversion. Fixed 3477157, 3478455, 3478456, 3478457, 3478486.
Remaining issues with surrogates (3477159) and Turkish I (3478482).

Reviewed by Ken.

Misc.subproj/WebUnicode.m: (_unicodeLower): (_unicodeUpper):

8:31 AM Changeset in webkit [5436] by darin

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3477528 -- array.sort(function) fails if the function returns a non-zero value that rounds to zero

kjs/array_object.cpp: (compareByStringForQSort): Added checks for undefined values to match what the specification calls for. (compareWithCompareFunctionForQSort): Added checks for undefined values as above, and also changed the code that looks at the compare function result to look at the number returned without rounding to an integer. (ArrayProtoFuncImp::call): Changed the code that looks at the compare function result to look at the number returned without rounding to an integer.

12:26 AM Changeset in webkit [5435] by darin

9 edits in trunk/WebCore

Reviewed by Dave.

fixed 3478173 -- REGRESSION (112-113): getElementById is failing for many types of elements

The problem was that ElementImpl::attach was being skipped for many objects with classes
derived from ElementImpl. By changing them all to call up to their base classes instead of
skipping levels, the bug went away. This was possible (and easy to do) because of the
rendererIsNeeded() change I made a while back.

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). This was a remnant of the old way of changing the logic about when to create the renderer, not needed now that we have rendererIsNeeded(). (HTMLFrameSetElementImpl::attach): Ditto. (HTMLIFrameElementImpl::attach): Ditto.

khtml/html/html_formimpl.h: Removed many unused attach() overrides.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Ditto. (HTMLButtonElementImpl::attach): Removed, because now the base class's attach does the right thing. (HTMLFieldSetElementImpl::attach): Ditto. (HTMLInputElementImpl::attach): Removed explicit createRendererIfNeeded call, not needed now that HTMLGenericFormElementImpl calls through to its base class. (HTMLLegendElementImpl::attach): Removed, because now the base class's attach does the right thing. (HTMLSelectElementImpl::attach): Ditto. (HTMLTextAreaElementImpl::attach): Ditto.

khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). (HTMLImageElementImpl::detach): Call base class's detach() instead of NodeBaseImpl::detach(). No need to skip the ElementImpl::detach() function, and important not to for the new "id" optimization.

khtml/html/html_inlineimpl.h: Removed HTMLBRElementImpl::attach override.
khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach().

khtml/html/html_objectimpl.h: Removed HTMLAppletElementImpl::attach override.
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::attach): Removed, because the base class's attach does the right thing. (HTMLEmbedElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). (HTMLObjectElementImpl::attach): Ditto.

Nov 9, 2003:

3:43 PM Changeset in webkit [5434] by hyatt

2 adds in trunk/LayoutTests/fast/text/basic

Add layout test for letter/word spacing bug.

3:41 PM Changeset in webkit [5433] by hyatt

3 edits in trunk/WebCore

Fix for 3478317, letter/word-spacing don't inherit properly through italic/bold elements.

Reviewed by darin

khtml/rendering/font.h: (khtml::Font::Font):
khtml/rendering/render_style.h: (khtml::RenderStyle::setFontDef):

2:30 PM Changeset in webkit [5432] by hyatt

2 edits in trunk/WebCore

Fix for 3478309, make sure backgrounds paint in the border box and not just in the padding box.

Reviewed by darin

Also making sure that <frame>s aren't transparent, since other browsers seem to only make <iframe>s/<object>s
be transparent.

khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):

Nov 8, 2003:

9:10 PM Changeset in webkit [5431] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3478025 -- links with non-Latin-1 characters in the hostname are not getting IDN-encoded

kwq/KWQKURL.mm: (KURL::parse): Changed existing code to take advantage of the fact that a NUL character is classified as a path segment end character. (KURL::findHostnameInHierarchicalURL): Don't treat NUL characters as terminating characters for hostnames, because QChar::latin1() turns all non-Latin-1 characters into NUL characters.

3:24 PM Changeset in webkit [5430] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3477509 -- REGRESSION (112-113): crash in KHTMLPart::processObjectRequest at espn.com, chosun.com

khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Use a dynamic_cast to check the type of the part rather than assuming it's always a KHTMLPart. The crash was caused by casting a KWQPluginPart to KHTMLPart.

9:40 AM Changeset in webkit [5429] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3240778>: add "save" menu item to contextual menu for text pages

Reviewed by darin.

WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]): Made WebTextView's context menu behavior like WebHTMLView's context menu behavior with regards to selection. If the control-click was on a selection, show menu options for the selection like copy. If it was not on a selection, show menu options such as save and print. Don't select anything when control-clicking.

9:40 AM Changeset in webkit [5428] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3478022>: assertion failure while loading WMP content

Reviewed by darin.

ChangeLog:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): Don't continue if the stream is cancelled in startStreamWithResponse.

9:39 AM Changeset in webkit [5427] by darin

6 edits in trunk/WebCore

Reviewed by Richard.

event cleanup motivated by questions on khtml-devel

khtml/dom/dom2_events.h: Removed eventModuleName.
khtml/dom/dom2_events.cpp: Removed eventModuleName.

khtml/xml/dom2_eventsimpl.h: Removed eventModuleName, made many trivially simple functions inline, made virtual functions no longer inline. Also made some functions const. (DOM::EventImpl::propagationStopped): Made this non-virtual; there was no reason for it to be virtual I could see. (DOM::EventImpl::defaultPrevented): Ditto. (DOM::EventImpl::setDefaultHandled): Ditto. (DOM::UIEventImpl::view): Made this inline. (DOM::UIEventImpl::detail): Ditto. (DOM::MouseEventImpl::screenX): Ditto. (DOM::MouseEventImpl::screenY): Ditto. (DOM::MouseEventImpl::clientX): Ditto. (DOM::MouseEventImpl::clientY): Ditto. (DOM::MouseEventImpl::layerX): Ditto. (DOM::MouseEventImpl::layerY): Ditto. (DOM::MouseEventImpl::ctrlKey): Ditto. (DOM::MouseEventImpl::shiftKey): Ditto. (DOM::MouseEventImpl::altKey): Ditto. (DOM::MouseEventImpl::metaKey): Ditto. (DOM::MouseEventImpl::button): Ditto. (DOM::MouseEventImpl::relatedTarget): Ditto. (DOM::MutationEventImpl::relatedNode): Ditto. (DOM::MutationEventImpl::prevValue): Ditto. (DOM::MutationEventImpl::newValue): Ditto. (DOM::MutationEventImpl::attrName): Ditto. (DOM::MutationEventImpl::attrChange): Ditto.

khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Changed implementation to no longer require eventModuleName(), and removed some unneeded casts.

khtml/xml/dom2_eventsimpl.cpp: Made lots of functions inline. (EventImpl::isUIEvent): Since this is virtual, make it no longer inline. (EventImpl::isMouseEvent): Ditto. (EventImpl::isMutationEvent): Ditto. (EventImpl::isKeyboardEvent): Ditto. (UIEventImpl::isUIEvent): Ditto. (MouseEventImpl::isMouseEvent): Ditto. (KeyboardEventImpl::isKeyboardEvent): Ditto. (MutationEventImpl::isMutationEvent): Ditto.

Nov 7, 2003:

5:08 PM Changeset in webkit [5426] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3020196>: links with href="" don't show hand cursor when you mouse over them

Reviewed by darin.

khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): check if the URL on the event is non-NULL, not if it is non-empty

4:48 PM Changeset in webkit [5425]

9 copies
2 deletes in tags/Safari-100~0~1

This commit was manufactured by cvs2svn to create tag
'Safari-100~0~1'.

4:48 PM Changeset in webkit [5424] by vicki

1 edit in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore/ChangeLog-2005-08-23

moved the release marker in the ChangeLog

4:40 PM Changeset in webkit [5423] by vicki

2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore

Reviewed by kocienda.

WebCorePrefix.h: fix Merlot build breakage

3:36 PM Changeset in webkit [5422] by vicki

1 edit in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore/ChangeLog-2005-08-23

Safari v100.0.1 stamp

3:24 PM Changeset in webkit [5421] by vicki

4 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebCore

rolled this fix onto the Safari-1-1-Merlot-BuildFixes-branch

2003-10-26 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed 3463586 -- WebCore does not compile with new definition of NULL

khtml/khtml_part.cpp: (findWordBoundary): Changed NULL to 0 and did a little code cleanup of the surrounding code.
khtml/rendering/break_lines.cpp: (khtml::isBreakable): Changed NULL to 0 and did a tiny bit of cleanup.

WebCorePrefix.h: Add a definition of NULL here that takes advantage of the GNU null feature even if the system C library doesn't.

3:24 PM Changeset in webkit [5420]

14 copies in branches/Safari-1-1-Merlot-BuildFixes-branch

This commit was manufactured by cvs2svn to create branch
'Safari-1-1-Merlot-BuildFixes-branch'.

10:57 AM Changeset in webkit [5419] by rjw

4 edits in trunk

WebKit:

Fixed 3477067. Use our case unicode conversion routines.

Reviewed by Ken.

WebCoreSupport.subproj/WebTextRenderer.m: (toUpper):

WebCore:

Fixed 3477067. Use our case unicode conversion routines.

Reviewed by Ken.

kwq/KWQChar.mm: (QChar::lower): (QChar::upper):

9:51 AM Changeset in webkit [5418] by rjw

1 add in trunk/LayoutTests/css1/text_properties/text-transform.html

New text-transform test case from Dave at CSS WG.

Nov 6, 2003:

11:59 PM Changeset in webkit [5417] by hyatt

3 adds in trunk/LayoutTests/fast/runin

Adding runin tests finally.

11:58 PM Changeset in webkit [5416] by hyatt

2 edits in trunk/WebCore

Fixes for 3476717, inline blocks should expand to encompass floats; 3476718, inline blocks should not
collapse margins with children; and 3476721, run-ins and compacts can flow into anonymous blocks, even
ones that they caused to be created by failing to run in/compact in the first place.

Reviewed by darin (inline block fixes only).

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren):

11:41 PM Changeset in webkit [5415] by hyatt

4 adds in trunk/LayoutTests/fast/inline-block

Adding inline-block growth/collapsing layout tests.

7:37 PM Changeset in webkit [5414] by rjw

2 edits in trunk/WebCore

Fixed 3476563. Remove unnecessary call to set view position after load completes.

Reviewed by Gramps.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):

4:40 PM Changeset in webkit [5413] by rjw

4 edits in trunk/WebKit

Fixed 3476393. Call scrollPoint: recursively up the view hierarchy to ensure point is visible.

Reviewed by Ken.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_scrollPointToVisible:fromView:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollPoint:]):

3:42 PM Changeset in webkit [5412] by cblu

2 edits in trunk/WebCore

khtml/rendering/render_image.h: (khtml::RenderImage::isDisplayingError): forgot to remove the "virtual" part of the declaration

3:37 PM Changeset in webkit [5411] by cblu

3 edits in trunk/WebCore

Fixed:
<rdar://problem/3275118>: Dragging from missing-image link stretches missing-image icon to size of missing image
<rdar://problem/3476225>: assert dragging non-existant images

Reviewed by rjw.

khtml/rendering/render_image.h: (khtml::RenderImage::isDisplayingError): new method, returns true for the broken image
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): only provide info if there is an image and the image is not broken

1:29 PM Changeset in webkit [5410] by kocienda

3 edits in trunk/WebCore

Reviewed by Richard

Fixes for these bugs:

<rdar://problem/3476006>: Form file input widgets do not scroll
to view when focused

<rdar://problem/3476007>: Form file input widgets should only
focus when full keyboard access is on

kwq/KWQFileButton.h: Added focusPolicy declaration.
kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy): Added. Now works like other buttons. Fixes 3476007. (KWQFileButton::focusChanged): Added. Code similar to text area widgets. Fixes 3476006.

1:03 PM Changeset in webkit [5409] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3308609>: 6L60 Safari URL links with line-endings converted to hex by contextual menu

Reviewed by rjw.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): use parseURL to go from an attribute string to a URL string

12:11 PM Changeset in webkit [5408] by vicki

3 edits in trunk

the tree is open for Safari-114!

12:05 PM Changeset in webkit [5407]

3 copies in tags/Safari-113

This commit was manufactured by cvs2svn to create tag 'Safari-113'.

12:05 PM Changeset in webkit [5406] by vicki

6 edits in trunk

Safari-113 stamp

9:33 AM Changeset in webkit [5405] by sullivan

2 edits in trunk/WebCore

fixed broken build

khtml/xml/dom_docimpl.cpp: (DocumentImpl::completeURL): removed stray character

9:12 AM Changeset in webkit [5404] by mjs

9 edits in trunk/WebCore

Reviewed by Darin.

fixed 3475366 - 4.5% of time spent making html event listeners on slow intel page.

6% speedup on intel page, 1% speedup on cvs-base PLT.

khtml/ecma/kjs_events.cpp: (JSEventListener::JSEventListener): Don't add self to hashtable if imp is null (which can now happen in the lazy listener case). (JSEventListener::~JSEventListener): Ditto on removing. (JSEventListener::listenerObj): Made this virtual. (JSLazyEventListener::JSLazyEventListener): New constructor. (JSLazyEventListener::handleEvent): call parseCode, then superclass if it appeared to succeed. (JSLazyEventListener::listenerObj): call parseCode, then superclass. (JSLazyEventListener::parseCode): (KJS::getNodeEventListener): Check for null listenerObjImp in case of lazy listener that failed to parse.
khtml/ecma/kjs_dom.cpp: (DOMNode::getListener): Ditto.
khtml/ecma/kjs_html.cpp: (Image::getValueProperty): Ditto.
khtml/ecma/kjs_events.h: (KJS::JSEventListener::listenerObjImp): call listenerObj() virtual method and get imp from the result.
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::createHTMLEventHandler): Don't parse the code here, make a lazy listener.
khtml/ecma/kjs_window.cpp: (Window::getJSLazyEventListener): make a new JSLazyEventListener - no need to check the listeners hashtable cause a brand new lazy listener won't have a function anyway.
khtml/ecma/kjs_window.h: Prototype new method.

9:06 AM Changeset in webkit [5403] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

fixed 3475397 - REGRESSION: relative URLs on page load test sometimes contain garbage, leading to missing images

kwq/KWQKURL.mm: (KURL::KURL): When constructing from NSURL, null-terminate the raw bytes since KURL::parse expects a null-terminated C string. It might be even better to pass a length to parse, but this fix is simple and does the job.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed