Context Navigation

← Previous Period
Next Period →

Timeline

Nov 13, 2003:

10:15 PM Changeset in webkit [5490] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3474330 -- tooltips do not work for <area> elements

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): When looking for a title, start with innerNode (which can be an <area> inside a <map>). This matches what Mozilla does.

9:05 PM Changeset in webkit [5489] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed - 3479285 - hang at www.saccourt.com
fixed - 3477088 - (85-112) Safari frozen loading a page at Postal Service site of Taiwan

khtml/ecma/kjs_html.cpp: (KJS::HTMLSelectCollection::tryPut): Use the range-checking version of the number-conversion function to avoid negative numbers and NaN.

6:29 PM Changeset in webkit [5488]

1 copy in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore/bindings

This commit was manufactured by cvs2svn to create branch
'Safari-1-1-Merlot-BuildFixes-branch'.

6:29 PM Changeset in webkit [5487]

15 copies in tags/Safari-1-1-Merlot-BuildFixes-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-1-Merlot-BuildFixes-anchor'.

6:29 PM Changeset in webkit [5486] by rjw

3 edits in trunk/JavaScriptCore

Factored common code between copy constructor and assignment operator.

Reviewed by Chris.

ChangeLog:
bindings/jni/jni_runtime.h: (Bindings::JavaConstructor::_commonCopy): (Bindings::JavaConstructor::JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaField::type):
bindings/runtime.h:

6:17 PM Changeset in webkit [5485] by rjw

5 edits
3 adds
3 deletes in trunk/JavaScriptCore

JavaScriptCore:

More LiveConnect stuff. This checkin adds abstract classes to model
language runtimes and a JNI based set of concrete implementations for
Java.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/Makefile.am: Removed.
bindings/jni/Makefile.am: Removed.
bindings/jni/jni_runtime.cpp: Added. (JavaField::JavaField): (JavaConstructor::JavaConstructor): (JavaMethod::JavaMethod): (JavaClass::JavaClass):
bindings/jni/jni_runtime.h: Added. (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=): (Bindings::JavaString::characters): (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::~JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::type): (Bindings::JavaConstructor::JavaConstructor): (Bindings::JavaConstructor::~JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaConstructor::parameterAt): (Bindings::JavaConstructor::numParameters): (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=): (Bindings::JavaField::name): (Bindings::JavaField::type): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::~JavaMethod): (Bindings::JavaMethod::_commonCopy): (Bindings::JavaMethod::operator=): (Bindings::JavaMethod::name): (Bindings::JavaMethod::returnType): (Bindings::JavaMethod::parameterAt): (Bindings::JavaMethod::numParameters): (Bindings::JavaClass::_commonDelete): (Bindings::JavaClass::~JavaClass): (Bindings::JavaClass::_commonCopy): (Bindings::JavaClass::JavaClass): (Bindings::JavaClass::operator=): (Bindings::JavaClass::name): (Bindings::JavaClass::methodAt): (Bindings::JavaClass::numMethods): (Bindings::JavaClass::constructorAt): (Bindings::JavaClass::numConstructors): (Bindings::JavaClass::fieldAt): (Bindings::JavaClass::numFields):
bindings/jni/jni_utility.cpp: (callJNIMethod): (callJNIMethodA): (callJNIObjectMethod): (callJNIByteMethod): (callJNICharMethod): (callJNIShortMethod): (callJNIIntMethod): (callJNILongMethod): (callJNIFloatMethod): (callJNIDoubleMethod): (callJNIVoidMethodA): (callJNIObjectMethodA): (callJNIByteMethodA): (callJNICharMethodA): (callJNIShortMethodA): (callJNIIntMethodA): (callJNILongMethodA): (callJNIFloatMethodA): (callJNIDoubleMethodA): (getCharactersFromJString): (releaseCharactersForJString):
bindings/jni/jni_utility.h:
bindings/objc/Makefile.am: Removed.
bindings/runtime.h: Added. (Bindings::Parameter::~Parameter): (Bindings::Constructor::~Constructor): (Bindings::Field::~Field): (Bindings::Method::~Method): (Bindings::Class::~Class):

Tests:

More tweaks to test new LiveConnect stuff.

DumpJava/main.cpp: (dumpClass):

4:34 PM Changeset in webkit [5484]

1 copy
327 deletes in branches/unlabeled-1.21.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.21.4'.

4:34 PM Changeset in webkit [5483] by kocienda

10 edits in trunk

WebCore:

Reviewed by John

Fix for this bug:

<rdar://problem/3483284>: Tabbing to links needs to honor new
WebKit tab-to-links preference

In addition to fixing the bug, I also did a bit of cleanup
in the code which helps to determine tab order.

Biggest change is to modify the keyboard UI mode function so
that it is a set of flags, rather than a straight-up value.

I also tweaked the names on the keyboard UI mode constants
to make them read better.

kwq/KWQButton.mm: (QButton::focusPolicy): Tweaks to make more readable and use new model for keyboard UI mode.
kwq/KWQComboBox.mm: (QComboBox::focusPolicy): Ditto. Plus, this function was not blocking exceptions.
kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy): Tweaks to make more readable and use new model for keyboard UI mode.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now checks new tabsToLinks function to determine if links can be tabbed to. (KWQKHTMLPart::currentEventIsKeyboardOptionTab): New function checks for option-tab keyboard event. (KWQKHTMLPart::tabsToLinks): New helper to take keyboard UI mode and option-tab into account. (KWQKHTMLPart::keyboardUIMode): Name tweak.
kwq/KWQListBox.mm: Tweaks to make more readable and use new model for keyboard UI mode. (QListBox::focusPolicy):
kwq/WebCoreKeyboardAccess.h: Tweaked names. Added WebCoreKeyboardAccessTabsToLinks.

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3483284>: Tabbing to links needs to honor new
WebKit tab-to-links preference

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Remove self from notification center. (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Now checks for WebCoreKeyboardAccessTabsToLinks preference. (-[WebBridge keyboardUIMode]): Adds self to notification center to pick up changes to WebPreferences.

4:15 PM Changeset in webkit [5482] by vicki

2 edits in branches/SUPanBisque-branch/WebCore

roll the KWQKHTMLPart.mm change from this fix onto the branch; this is the WebCore part of the fix for 3375281

2003-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ken.

fixed 3375281 - Keyboard event handlers not fired if focus not in form field
fixed 3242927 - KeyPressed Event in Javascript don't work
fixed 3375353 - keyboard event.target not updated when blurring from form items
fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Force false when defaultHandled instead of based on a weird rule appropriate for KDE but not for us.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): If there's no focus node, give the event to the body element instead of giving up. Also, reverse expectedsense of return value dispatchKeyEvent, since it returns true if it *didn't* swallow the event. And finally, let the key press event as well as the key down event for the initial NSKeyDown block default handling.
kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): Respect return value from interceptKeyEvent: (-[KWQTableView keyUp:]): ditto
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): ditto (-[KWQTextAreaTextView keyUp:]): ditto
kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): ditto

4:06 PM Changeset in webkit [5481] by vicki

2 edits in branches/SUPanBisque-branch/WebKit

roll the WebHTMLView.m change from this fix onto the branch; this is the WebKit part of the fix for 3375281

2003-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ken.

fixed 3375281 - Keyboard event handlers not fired if focus not in form field
fixed 3242927 - KeyPressed Event in Javascript don't work
fixed 3375353 - keyboard event.target not updated when blurring from form items
fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Ask the bridge before passing the event along. (-[WebHTMLView keyUp:]): Likewise.
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m: Remove dead code.

2:53 PM Changeset in webkit [5480] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3472562 - Null or Undefined variables passed to IN operator cause javascript exceptions

kjs/nodes.cpp: (ForInNode::execute): If the in value is null or undefined, bail out early, since attempting to iterate its properties will throw an exception.

1:37 PM Changeset in webkit [5479] by kocienda

3 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3481719>: WebKit needs preference for tabbing to links

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Add initialization of new WebKitTabToLinksPreferenceKey. (-[WebPreferences setTabsToLinks:]): Added preference setter. (-[WebPreferences tabsToLinks]): Added preference getter.
WebView.subproj/WebPreferencesPrivate.h: Declared new methods as SPI on WebPreferences.

12:13 PM Changeset in webkit [5478] by hyatt

10 edits in trunk/WebCore

Implement a custom unfurl marquee style.

Reviewed by john

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/rendering/render_box.cpp: (RenderBox::calcHeight):
khtml/rendering/render_layer.cpp: (m_direction): (Marquee::isUnfurlMarquee): (Marquee::start): (Marquee::updateMarqueePosition): (Marquee::updateMarqueeStyle): (Marquee::timerEvent):
khtml/rendering/render_layer.h: (khtml::):
khtml/rendering/render_style.h: (khtml::):

11:42 AM Changeset in webkit [5477] by kocienda

8 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3480761>: event object type attribute returns
khtml_keypress instead of keypress

Fixed string so that it returns keypress instead of khtml_keypress.
While I was at it, I changed the constant used for this event from
KHTML_KEYPRESS_EVENT to KEYPRESS_EVENT.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture): Constant name fixup.
khtml/ecma/kjs_dom.cpp: Ditto. (DOMNode::getValueProperty): Ditto. (DOMNode::putValue): Ditto.
khtml/ecma/kjs_window.cpp: (Window::get): Ditto. (Window::put): Ditto.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): Ditto.
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::idToType): This is the change that fixes the bug. (KeyboardEventImpl::KeyboardEventImpl): Constant name fixup.
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Ditto.

9:39 AM Changeset in webkit [5476] by darin

7 edits in trunk/WebCore

Reviewed by Ken.

fixed 3452554 -- keyCode attribute for DOM events reports incorrect value

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Return the Windows key code for keydown and keyup events. But for other events, return the character code. This matches IE. (UIEvent::which): Same behavior for now; may need further refinement.

kwq/KWQEvent.h: Change QEvent to allow copying. The Qt version probably doesn't allow it, but for us it's no big deal. Our event objects are just data holders. (QKeyEvent::QKeyEvent): Change parameters; take an NSEvent and figure the rest out here. Except for now get the type, button state, and auto repeat flag from the caller because that's a smaller change from how things are done now. I'll take this the next step later.
kwq/KWQEvent.mm: (characterCode): Added. Extracts the character code from the string if it's exactly 1 character long. (WindowsKeyCode): Added. Given an event, figures out the Windows key code. (QKeyEvent::QKeyEvent): Changed to get things from the NSEvent rather than having them passed individually. One change is that _ascii is now the Unicode value of the first character in the string. This causes us to return the Unicode value from keyCode for keypress events. Another change is that we now compute the Windows key code.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Change to use the new QKeyEvent constructor, passing in the NSEvent.

khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): In APPLE_CHANGES, copy the QKeyEvent using the copy constructor rather than listing the fields. This is easier to maintain when the list of fields changes.

khtml/rendering/render_form.cpp: (ComboBoxWidget::eventFilter): Put #if !APPLE_CHANGES around code that constructs a QKeyEvent. We don't ever run this code, but now we can't compile it either so we need the #if.

Nov 12, 2003:

8:33 PM Changeset in webkit [5475] by darin

2 edits in trunk/JavaScriptCore

fixed the build

Makefile.am: Fix the build by removing the bindings directory from SUBDIRS. Later, we can either add this back and add the Makefile.am files to the top level configure.in or leave it out and remove the Makefile.am files.

6:04 PM Changeset in webkit [5474] by rjw

2 edits in trunk/WebKit

Fixed 3475082. Remove unnecessary orderKey before showKey.

Written by Ed Voas.

Reviewed by Richard.

Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter makeKeyWindow]):

5:56 PM Changeset in webkit [5473] by rjw

3 edits
8 adds in trunk/JavaScriptCore

Added utility functions for calling JNI methods.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/Makefile.am: Added.
bindings/jni/Makefile.am: Added.
bindings/jni/jni_utility.cpp: Added. (attachToJavaVM): (callJNIMethod): (callJNIVoidMethod): (callJNIObjectMethod): (callJNIByteMethod): (callJNICharMethod): (callJNIShortMethod): (callJNIIntMethod): (callJNILongMethod): (callJNIFloatMethod): (callJNIDoubleMethod):
bindings/jni/jni_utility.h: Added.
bindings/objc/Makefile.am: Added.

4:19 PM Changeset in webkit [5472] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3482147>: replace _releaseFutureIconForURL assertion with a log statement

Reviewed by rjw.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _releaseFutureIconForURL:]):

3:37 PM Changeset in webkit [5471]

1 copy
41 deletes in branches/unlabeled-1.30.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.30.4'.

3:37 PM Changeset in webkit [5470] by hyatt

7 edits in trunk/WebCore

Fix for 3482132, incremental repainting for layout, i.e., only repaint areas that change when
doing a layout.

Reviewed by kocienda

khtml/khtmlview.h:
khtml/rendering/render_canvas.cpp: (RenderCanvas::repaintViewRectangle):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::setNeedsLayout): (RenderObject::setChildNeedsLayout):
khtml/rendering/render_object.h:
khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

12:08 PM Changeset in webkit [5469] by kocienda

3 edits in trunk/WebCore

Reviewed by me

I am an idiot for just assuming that these elements implement a focus()
function, without actually compiling and testing. I will have to add
this function to these elements so I can make this work.

khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::accessKeyAction): These elements do not implement focus().
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::accessKeyAction): Ditto.

12:05 PM Changeset in webkit [5468] by kocienda

8 edits in trunk/WebCore

Reviewed by Richard

khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::click): Implemented. Missed this in my earlier patch. (HTMLButtonElementImpl::accessKeyAction): Added. Focus and click. (HTMLInputElementImpl::accessKeyAction): Added. Focus the element. (HTMLSelectElementImpl::accessKeyAction): Added. Focus the element. (HTMLTextAreaElementImpl::accessKeyAction): Added. Focus the element.
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::accessKeyAction): Added. Focus and click.
khtml/html/html_inlineimpl.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::addElementById): Dirty the accesskey dictionary. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::getElementByAccessKey): Function to look up an element based on the key provided. (DocumentImpl::setDocumentChanged): Dirty the accesskey dictionary. (DocumentImpl::defaultEventHandler): Check the accesskey dictionary to see if some element wants to handle a key event.
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::accessKeyAction): Added. Send a click to the element.

10:04 AM Changeset in webkit [5467] by vicki

2 edits in branches/SUPanBisque-branch/WebCore

apply the WebCore part of the fix for 3478904 to the SUPanBisque branch

2003-11-06 Richard Williamson <rjw@apple.com>

Fixed 3476563. Remove unnecessary call to set view position after load

completes.

Reviewed by Gramps.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):

10:04 AM Changeset in webkit [5466] by vicki

4 edits in branches/SUPanBisque-branch/WebKit

apply this fix to the SUPanBisque branch

2003-11-06 Richard Williamson <rjw@apple.com>

Fixed 3476393. Call scrollPoint: recursively up the view hierarchy to ensure point is visible.

Reviewed by Ken.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_scrollPointToVisible:fromView:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollPoint:]):

9:32 AM Changeset in webkit [5465] by kocienda

5 edits in trunk/WebCore

Reviewed by Richard

Fix for this bug:

<rdar://problem/3481600>: key event objects do not preserve unmodified keys

khtml/xml/dom2_eventsimpl.cpp: Modified constructor call to include unmodifiedText. (KeyboardEventImpl::KeyboardEventImpl):
kwq/KWQEvent.h: Added unmodifiedText accessor and variable to QKeyEvent.
kwq/KWQEvent.mm: (QKeyEvent::QKeyEvent): Modified constructor to include unmodifiedText. (QKeyEvent::unmodifiedText): Added accessor.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Modified constructor call to include unmodifiedText.

8:49 AM Changeset in webkit [5464] by kocienda

7 edits in trunk/WebCore

Reviewed by Maciej

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::click): Implemented a programmatic click function for elements.
khtml/html/html_elementimpl.h:
khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submitClick): Implemented a programmatic click function for elements. (HTMLInputElementImpl::click): This implementation calls through to Cocoa button programmatic click function to get user interface feedback for button elements, and calls through to the superclass for other elements.
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: Removed click() function for anchors. No longer needed.
khtml/html/html_inlineimpl.h: Ditto.

1:20 AM Changeset in webkit [5463] by hyatt

2 edits in trunk/WebCore

Fix build bustage in deployment builds.

12:48 AM Changeset in webkit [5462]

1 copy
93 deletes in branches/unlabeled-1.37.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.37.4'.

12:48 AM Changeset in webkit [5461] by hyatt

20 edits in trunk

Fix for 3481134, shorthand parsing in CSS does not fill in omitted values. The fix is to implement
the CSS3 'initial' value for all properties (covered by 3481323), and then to fill in the omitted
values with the 'initial' value.

This patch also fixes two bugs in the style system: 3481324, collapsed borders with border-style: none
should always return a width of 0, and 3481322, 'clip' not inheriting properly in CSS when explicit
inheritance is used.

Reviewed by mjs

khtml/css/css_valueimpl.cpp: (CSSInitialValueImpl::cssText):
khtml/css/css_valueimpl.h: (DOM::CSSInitialValueImpl::cssValueType):
khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseShortHand):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/dom/css_value.h: (DOM::CSSValue::):
khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleVisualData::StyleVisualData): (StyleBackgroundData::StyleBackgroundData): (StyleMarqueeData::StyleMarqueeData): (StyleFlexibleBoxData::StyleFlexibleBoxData): (opacity): (StyleInheritedData::StyleInheritedData): (RenderStyle::diff):
khtml/rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::CollapsedBorderValue::width): (khtml::RenderStyle::InheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::resetBorderTop): (khtml::RenderStyle::resetBorderRight): (khtml::RenderStyle::resetBorderBottom): (khtml::RenderStyle::resetBorderLeft): (khtml::RenderStyle::resetOutline): (khtml::RenderStyle::setHasClip): (khtml::RenderStyle::resetMargin): (khtml::RenderStyle::resetPadding): (khtml::RenderStyle::setCursor):

Nov 11, 2003:

8:15 PM Changeset in webkit [5460] by vicki

2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebKit

rolled this fix onto the branch

2003-10-16 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug-in content

Reviewed by rjw.

Misc.subproj/WebDownload.m: fixed build failure when using new Foundation. We are overriding and calling a renamed method. Continue to override the old method, override the new method and declare their interfaces to avoid build failures.

5:30 PM Changeset in webkit [5459] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed 3479537 - reproducible crash in KJS::WindowFunc::tryCall

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check part and doc impl for null.

3:16 PM Changeset in webkit [5458] by mjs

2 edits in trunk/WebCore

Reviewed by Ken.

fixed 3472330 - REGRESSION: onKeyPress handler not called when hitting keys in <input type=password> field

kwq/KWQTextField.mm: (-[KWQSecureTextField initWithQLineEdit:]): New initializer, so the secure text field knows about the widget. (-[KWQTextField setPasswordMode:]): Use new initializer for KWQSecureTextField. (-[KWQSecureTextField textView:shouldHandleEvent:]): New method, do the same thing as the non-secure text field to pass the event on. (-[KWQSecureTextField textView:didHandleEvent:]): Ditto.

1:58 PM Changeset in webkit [5457] by kocienda

8 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3480173>: Too many names for programmatic click functions

Changed all instances of performClick() and simulateClick() to click().
Changed all instances of performSubmitClick() to submitClick().

Additionally, KWQButton had a simulateClick method, which was redundant
given that its superclass has a performClick: method.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submitClick): (HTMLInputElementImpl::defaultEventHandler): (HTMLSelectElementImpl::defaultEventHandler):
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): (HTMLAnchorElementImpl::click):
khtml/html/html_inlineimpl.h:
khtml/rendering/render_form.cpp: (RenderLineEdit::slotReturnPressed):
kwq/KWQButton.h:
kwq/KWQButton.mm: (QButton::click):

1:51 PM Changeset in webkit [5456] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed 3475272 - custom property on CSSStyleObject won't hold a value

khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::tryPut): If the property is not a css property, save it as a custom object property in the normal way.

1:06 PM Changeset in webkit [5455] by sullivan

2 edits in trunk/WebCore

fixed <rdar://problem/3480421>: Focus rings around links are too thick, should use 3 px instead of 5 px

Reviewed by Don and Ken.

khtml/css/html4.css: use 3px instead of 5 px for :active, :focus

12:59 PM Changeset in webkit [5454] by kocienda

9 edits in trunk/WebCore

Reviewed by John

In the DOM Level 3 Events specification, keydown and keyup are
standard events. We can remove the KHTML component in the names
of these constants. Note that the keypress event is still
nonstandard and will retain the KHTML name component.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture)
khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty) (DOMNode::putValue)
khtml/ecma/kjs_window.cpp: (Window::get) (Window::put)
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute)
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler)
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler)
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId) (EventImpl::idToType) (KeyboardEventImpl::KeyboardEventImpl)
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::)

11:30 AM Changeset in webkit [5453] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3480281>: drag image of selected text and images include broken images

Reviewed by dave.

khtml/rendering/render_image.cpp: (RenderImage::paintObject): when drawing the drag image, don't draw the broken image

10:34 AM Changeset in webkit [5452] by vicki

2 edits in trunk/WebCore

Reviewed by sullivan.

rolled Merlot build fix onto the trunk

WebCorePrefix.h: added #include <sys/types.h>

Nov 10, 2003:

5:12 PM Changeset in webkit [5451] by hyatt

2 edits in trunk/WebCore

Fix for 3473531, text nested in hr inside h3 did not get the h3's style.

Reviewed by darin

khtml/html/dtd.cpp: (DOM::checkChild):

5:03 PM Changeset in webkit [5450] by hyatt

110 edits in trunk

Fix for 3478435, <hr> tags should be centered by default. Ditched the 1px margin as well.

Fix for 3479441, <h1>-<h6> tags should *not* be centered by default. They should also use bold instead of
bolder.

Reviewed by darin

khtml/css/html4.css:
khtml/html/html_blockimpl.cpp: (HTMLHRElementImpl::parseAttribute):
layout-tests/apple-only/base/bugzilla.mozilla.org/index-expected.txt:
layout-tests/apple-only/base/home.netscape.com/index-expected.txt:
layout-tests/apple-only/base/www.altavista.com/index-expected.txt:
layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
layout-tests/apple-only/base/www.digitalcity.com/index-expected.txt:
layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
layout-tests/apple-only/base/www.excite.com/index-expected.txt:
layout-tests/apple-only/base/www.mapquest.com/index-expected.txt:
layout-tests/apple-only/base/www.microsoft.com/index-expected.txt:
layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
layout-tests/apple-only/base/www.nytimes.com/index-expected.txt:
layout-tests/apple-only/base/www.nytimes.com_Table/index-expected.txt:
layout-tests/apple-only/base/www.quicken.com/index-expected.txt:
layout-tests/apple-only/base/www.w3.org_DOML2Core/index-expected.txt:
layout-tests/css1/basic/class_as_selector-expected.txt:
layout-tests/css1/basic/comments-expected.txt:
layout-tests/css1/basic/containment-expected.txt:
layout-tests/css1/basic/contextual_selectors-expected.txt:
layout-tests/css1/basic/grouping-expected.txt:
layout-tests/css1/basic/id_as_selector-expected.txt:
layout-tests/css1/basic/inheritance-expected.txt:
layout-tests/css1/box_properties/border-expected.txt:
layout-tests/css1/box_properties/border_bottom-expected.txt:
layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
layout-tests/css1/box_properties/border_bottom_width-expected.txt:
layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
layout-tests/css1/box_properties/border_color-expected.txt:
layout-tests/css1/box_properties/border_color_inline-expected.txt:
layout-tests/css1/box_properties/border_inline-expected.txt:
layout-tests/css1/box_properties/border_left-expected.txt:
layout-tests/css1/box_properties/border_left_inline-expected.txt:
layout-tests/css1/box_properties/border_left_width-expected.txt:
layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
layout-tests/css1/box_properties/border_right-expected.txt:
layout-tests/css1/box_properties/border_right_inline-expected.txt:
layout-tests/css1/box_properties/border_right_width-expected.txt:
layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
layout-tests/css1/box_properties/border_style-expected.txt:
layout-tests/css1/box_properties/border_style_inline-expected.txt:
layout-tests/css1/box_properties/border_top-expected.txt:
layout-tests/css1/box_properties/border_top_inline-expected.txt:
layout-tests/css1/box_properties/border_top_width-expected.txt:
layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
layout-tests/css1/box_properties/border_width-expected.txt:
layout-tests/css1/box_properties/border_width_inline-expected.txt:
layout-tests/css1/box_properties/clear-expected.txt:
layout-tests/css1/box_properties/clear_float-expected.txt:
layout-tests/css1/box_properties/float-expected.txt:
layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
layout-tests/css1/box_properties/float_margin-expected.txt:
layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
layout-tests/css1/box_properties/height-expected.txt:
layout-tests/css1/box_properties/margin-expected.txt:
layout-tests/css1/box_properties/margin_bottom-expected.txt:
layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
layout-tests/css1/box_properties/margin_inline-expected.txt:
layout-tests/css1/box_properties/margin_left-expected.txt:
layout-tests/css1/box_properties/margin_left_inline-expected.txt:
layout-tests/css1/box_properties/margin_right-expected.txt:
layout-tests/css1/box_properties/margin_right_inline-expected.txt:
layout-tests/css1/box_properties/margin_top-expected.txt:
layout-tests/css1/box_properties/margin_top_inline-expected.txt:
layout-tests/css1/box_properties/padding-expected.txt:
layout-tests/css1/box_properties/padding_bottom-expected.txt:
layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
layout-tests/css1/box_properties/padding_inline-expected.txt:
layout-tests/css1/box_properties/padding_left-expected.txt:
layout-tests/css1/box_properties/padding_left_inline-expected.txt:
layout-tests/css1/box_properties/padding_right-expected.txt:
layout-tests/css1/box_properties/padding_right_inline-expected.txt:
layout-tests/css1/box_properties/padding_top-expected.txt:
layout-tests/css1/box_properties/padding_top_inline-expected.txt:
layout-tests/css1/box_properties/width-expected.txt:
layout-tests/css1/cascade/cascade_order-expected.txt:
layout-tests/css1/cascade/important-expected.txt:
layout-tests/css1/classification/display-expected.txt:
layout-tests/css1/classification/list_style-expected.txt:
layout-tests/css1/classification/list_style_image-expected.txt:
layout-tests/css1/classification/list_style_position-expected.txt:
layout-tests/css1/classification/list_style_type-expected.txt:
layout-tests/css1/classification/white_space-expected.txt:
layout-tests/css1/color_and_background/background-expected.txt:
layout-tests/css1/color_and_background/background_attachment-expected.txt:
layout-tests/css1/color_and_background/background_color-expected.txt:
layout-tests/css1/color_and_background/background_image-expected.txt:
layout-tests/css1/color_and_background/background_position-expected.txt:
layout-tests/css1/color_and_background/background_repeat-expected.txt:
layout-tests/css1/color_and_background/color-expected.txt:
layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
layout-tests/css1/font_properties/font-expected.txt:
layout-tests/css1/font_properties/font_family-expected.txt:
layout-tests/css1/font_properties/font_size-expected.txt:
layout-tests/css1/font_properties/font_style-expected.txt:
layout-tests/css1/font_properties/font_variant-expected.txt:
layout-tests/css1/font_properties/font_weight-expected.txt:
layout-tests/css1/formatting_model/canvas-expected.txt:
layout-tests/css1/formatting_model/floating_elements-expected.txt:
layout-tests/css1/formatting_model/height_of_lines-expected.txt:
layout-tests/css1/formatting_model/inline_elements-expected.txt:
layout-tests/css1/formatting_model/replaced_elements-expected.txt:
layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
layout-tests/css1/pseudo/anchor-expected.txt:
layout-tests/css1/pseudo/firstletter-expected.txt:
layout-tests/css1/pseudo/firstline-expected.txt:
layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
layout-tests/css1/text_properties/letter_spacing-expected.txt:
layout-tests/css1/text_properties/line_height-expected.txt:
layout-tests/css1/text_properties/text-transform-expected.txt:
layout-tests/css1/text_properties/text_align-expected.txt:
layout-tests/css1/text_properties/text_decoration-expected.txt:
layout-tests/css1/text_properties/text_indent-expected.txt:
layout-tests/css1/text_properties/text_transform-expected.txt:
layout-tests/css1/text_properties/vertical_align-expected.txt:
layout-tests/css1/text_properties/word_spacing-expected.txt:
layout-tests/css1/units/color_units-expected.txt:
layout-tests/css1/units/length_units-expected.txt:
layout-tests/css1/units/percentage_units-expected.txt:
layout-tests/css1/units/urls-expected.txt:
layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
layout-tests/fast/encoding/utf-16-little-endian-expected.txt:

4:00 PM Changeset in webkit [5449]

1 copy
326 deletes in branches/unlabeled-1.56.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.56.4'.

4:00 PM Changeset in webkit [5448] by cblu

5 edits in trunk/WebCore

Fixed: <rdar://problem/3479266>: selected images don't obey CSS3 selection background-color attribute

Reviewed by dave.

khtml/rendering/render_image.cpp: (RenderImage::selectionTintColor): new, takes style into account (RenderImage::paintObject): use selectionTintColor
khtml/rendering/render_image.h:
kwq/KWQPainter.h: removed selectedImageTintColor
kwq/KWQPainter.mm:

3:52 PM Changeset in webkit [5447] by hyatt

9 edits in trunk/WebCore

Fix for 3479287, macro-ize the handling of the CSS 'inherit' value. This patch is preparation for
adding support for the 'initial' value, which will be used to fix the CSS parser's shorthand parsing
bugs.

Reviewed by kocienda

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssproperties.c: (hash_prop): (findProp):
khtml/css/cssproperties.h:
khtml/css/cssproperties.in:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/khtmlview.cpp: (KHTMLView::layout):

3:21 PM Changeset in webkit [5446] by cblu

5 edits in trunk/WebCore

Fixed:
<rdar://problem/3478883>: REGRESSION (113-114u): drag image for selected text includes unselected images
<rdar://problem/3479204>: selected images don't look selected

Reviewed by dave.

khtml/rendering/render_image.cpp: (RenderImage::RenderImage): init m_selectionState (RenderImage::paintObject): draw a tint over the image if selected, don't draw anything if not selected and the action is PaintActionSelection
khtml/rendering/render_image.h: (khtml::RenderImage::selectionState): new (khtml::RenderImage::setSelectionState): new
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::selectedImageTintColor): new

2:41 PM Changeset in webkit [5445] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3477795>: REGRESSION: can't submit form without
submit button by hitting return (cocoadev.com)

When I changed submitting forms using the return key in a text field
to go through a search for the correct submit or image input
element to use when submitting, I neglected to cover the case of
forms which have neither a submit or image input element. When
I encounter a form such as this now, I submit it anyway after
performing the submit or image input element and failing to find one.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::performSubmitClick)

1:54 PM Changeset in webkit [5444] by rjw

2 edits in trunk

Forget to change NOBODY to Darin.

1:51 PM Changeset in webkit [5443] by rjw

12 edits in trunk

WebKit:

Fixed 3478765. Use ICU to access unicode properties.
Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.
Fixed 3478885. Remove dead arabic shaping code

Reviewed by NOBODY (OOPS!).

Misc.subproj/WebUnicode.h:
Misc.subproj/WebUnicode.m: (_unicodeDigitValue): (_unicodeDirection): (_unicodeMirrored): (_unicodeMirroredChar): (_unicodeLower): (_unicodeUpper): (WebKitInitializeUnicode): (shapeForNextCharacter): (initializeCharacterShapeIterator):
Misc.subproj/WebUnicodeTables.m:
WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter): (fontContainsString):

WebCore:

Fixed 3478765. Use ICU to access unicode properties.
Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.

Reviewed by NOBODY (OOPS!).

WebCore-combined.exp:
WebCore.exp:
kwq/KWQChar.mm: (QChar::lower): (QChar::upper): (QChar::mirroredChar):
kwq/KWQString.h: (QChar::direction):
kwq/WebCoreUnicode.cpp:
kwq/WebCoreUnicode.h:

12:45 PM Changeset in webkit [5442] by rjw

1 add in trunk/LayoutTests/css1/text_properties/text-transform-expected.txt

Added expected results for text-transform test.

12:42 PM Changeset in webkit [5441] by rjw

1 edit in trunk/LayoutTests/css1/text_properties/text-transform.html

Removed Turkish and Deseret from the test case. These don't work yet.

11:58 AM Changeset in webkit [5440] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3478351>: Safari: URL Alias on Dock failed to open the 2byte URL

Reviewed by dave.

Misc.subproj/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]): if the host name is percent-escaped, use CFURLCreateStringByReplacingPercentEscapes

10:49 AM Changeset in webkit [5439] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3478781>: drag image of selected text and images doesn't include images

Reviewed by rjw.

khtml/rendering/render_image.cpp: (RenderImage::paintObject): paint when the paint action is PaintActionSelection
khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): ditto

10:46 AM Changeset in webkit [5438] by kocienda

4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3477624>: REGRESSION (113): Using input method to
enter non-ascii text submits the form

This regression has been in the tree for a couple of versions now,
since we improved the way key events are processed. The solution
is to ask the text input manager if it has any marked text when
the return key (or enter key) is pressed, because if it does, the key
needs to work in the "accept" role for the input manager. Fixing
in this way has the pleasant effect of making return/enter key
behavior "do the right thing" based on context.

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Add check to see if text input manager has marked text before submitting text and password fields. Broke out key handling for checkboxes and radios, since the old code for these widgets worked fine.
kwq/KWQLineEdit.h: Added hasMarkedText function.
kwq/KWQLineEdit.mm: (QLineEdit::hasMarkedText): Returns whether the current input manager has marked text or not.

10:00 AM Changeset in webkit [5437] by rjw

2 edits in trunk/WebKit

Use ICU for upper/lower conversion. Fixed 3477157, 3478455, 3478456, 3478457, 3478486.
Remaining issues with surrogates (3477159) and Turkish I (3478482).

Reviewed by Ken.

Misc.subproj/WebUnicode.m: (_unicodeLower): (_unicodeUpper):

8:31 AM Changeset in webkit [5436] by darin

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3477528 -- array.sort(function) fails if the function returns a non-zero value that rounds to zero

kjs/array_object.cpp: (compareByStringForQSort): Added checks for undefined values to match what the specification calls for. (compareWithCompareFunctionForQSort): Added checks for undefined values as above, and also changed the code that looks at the compare function result to look at the number returned without rounding to an integer. (ArrayProtoFuncImp::call): Changed the code that looks at the compare function result to look at the number returned without rounding to an integer.

12:26 AM Changeset in webkit [5435] by darin

9 edits in trunk/WebCore

Reviewed by Dave.

fixed 3478173 -- REGRESSION (112-113): getElementById is failing for many types of elements

The problem was that ElementImpl::attach was being skipped for many objects with classes
derived from ElementImpl. By changing them all to call up to their base classes instead of
skipping levels, the bug went away. This was possible (and easy to do) because of the
rendererIsNeeded() change I made a while back.

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). This was a remnant of the old way of changing the logic about when to create the renderer, not needed now that we have rendererIsNeeded(). (HTMLFrameSetElementImpl::attach): Ditto. (HTMLIFrameElementImpl::attach): Ditto.

khtml/html/html_formimpl.h: Removed many unused attach() overrides.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Ditto. (HTMLButtonElementImpl::attach): Removed, because now the base class's attach does the right thing. (HTMLFieldSetElementImpl::attach): Ditto. (HTMLInputElementImpl::attach): Removed explicit createRendererIfNeeded call, not needed now that HTMLGenericFormElementImpl calls through to its base class. (HTMLLegendElementImpl::attach): Removed, because now the base class's attach does the right thing. (HTMLSelectElementImpl::attach): Ditto. (HTMLTextAreaElementImpl::attach): Ditto.

khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). (HTMLImageElementImpl::detach): Call base class's detach() instead of NodeBaseImpl::detach(). No need to skip the ElementImpl::detach() function, and important not to for the new "id" optimization.

khtml/html/html_inlineimpl.h: Removed HTMLBRElementImpl::attach override.
khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach().

khtml/html/html_objectimpl.h: Removed HTMLAppletElementImpl::attach override.
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::attach): Removed, because the base class's attach does the right thing. (HTMLEmbedElementImpl::attach): Call base class's attach() instead of creating renderer explicitly and then calling NodeBaseImpl::attach(). (HTMLObjectElementImpl::attach): Ditto.

Nov 9, 2003:

3:43 PM Changeset in webkit [5434] by hyatt

2 adds in trunk/LayoutTests/fast/text/basic

Add layout test for letter/word spacing bug.

3:41 PM Changeset in webkit [5433] by hyatt

3 edits in trunk/WebCore

Fix for 3478317, letter/word-spacing don't inherit properly through italic/bold elements.

Reviewed by darin

khtml/rendering/font.h: (khtml::Font::Font):
khtml/rendering/render_style.h: (khtml::RenderStyle::setFontDef):

2:30 PM Changeset in webkit [5432] by hyatt

2 edits in trunk/WebCore

Fix for 3478309, make sure backgrounds paint in the border box and not just in the padding box.

Reviewed by darin

Also making sure that <frame>s aren't transparent, since other browsers seem to only make <iframe>s/<object>s
be transparent.

khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed