Context Navigation

Fix for 3472998, stop a crash on an insanely malformed page. I had to change the concept of
"inStrayTableContent" to be a counter, since you could be nested and need to push/pop, and
then I also had to stop from mistakenly popping when I didn't need to.

Reviewed by rjw

khtml/html/htmlparser.cpp: (KHTMLParser::reset): (KHTMLParser::insertNode): (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock): (KHTMLParser::popOneBlock):
khtml/html/htmlparser.h:

5:52 PM Changeset in webkit [5559]

1 copy
41 deletes in branches/unlabeled-1.80.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.80.4'.

5:52 PM Changeset in webkit [5558]

1 copy
93 deletes in branches/unlabeled-1.73.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.73.4'.

5:52 PM Changeset in webkit [5557]

1 copy
376 deletes in branches/unlabeled-1.23.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.23.4'.

5:52 PM Changeset in webkit [5556] by darin

20 edits in trunk/WebCore

Reviewed by Ken.

did keyboard event cleanup to follow up on the keyCode work I did before
fixed 3485558: key identifers use lowercase hex, but the W3C document shows uppercase
fixed 3485564: key identifier for the Return key should be "Enter"
fixed 3485579: letter keys generate different key identifiers depending on whether the shift key is down
fixed 3485568: keyboard event modifier key bits are uninitialized; may have incorrect values
fixed 3481514: which attribute for DOM events reports incorrect value
fixed 3452569: charCode attribute for DOM events not supported

khtml/dom/dom2_events.h: Added charCode.
khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Call through to KeyboardEventImpl instead of doing the work here; better factoring. (UIEvent::charCode): Added. Calls through to KeyboardEventImpl. (UIEvent::which): Call keyCode in KeyboardEventImpl to share code.

khtml/ecma/kjs_events.h: Added charCode property for DOMUIEvent.
khtml/ecma/kjs_events.cpp: (DOMUIEvent::getValueProperty): Added charCode.
khtml/ecma/kjs_events.lut.h: Regenerated.

khtml/html/html_formimpl.h:
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Remove checks for "U+00000d" since we now use "Enter" for that key; also, we use capitalized hex, so it would have to change to "U+00000D" anyway. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Ditto.

khtml/khtmlview.cpp: (KHTMLView::keyPressEvent): Put !APPLE_CHANGES around code we are not using. It was doing a switch based on Qt key codes, but the key value it was using to check was a Macintosh virtual key code, which could yield strange results when the codes happen to match. Safer and smaller code size not to do any of it at all.

khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): Use a KLineEdit instead of LineEditWidget for APPLE_CHANGES. Allows us to put !APPLE_CHANGES around more Qt key code stuff. (RenderLineEdit::select): Cast to KLineEdit instead of LineEditWidget. (ComboBoxWidget::event): Put !APPLE_CHANGES around more unneeded Qt key code stuff. (TextAreaWidget::event): Put !APPLE_CHANGES around more unneeded Qt key code stuff.

khtml/xml/dom2_eventsimpl.h: Made id() const and added keyCode() and charCode().
khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): Initialize all fields in the empty constructor. Initialize all the modifier bits in the main constructor; the old code assumed they started off false, which is not a safe assumption. Also set m_altGraphKey false. Eliminated the unneeded check of text() before calling identifier(). Also adapted for the name change from identifier() to keyIdentifier(). (KeyboardEventImpl::keyCode): Added. Returns the Windows virtual key code for keydown and keyup events, and the Unicode character for all other events. (KeyboardEventImpl::charCode): Added. Returns the Unicode character.

kwq/KWQEvent.h: Changed QCustomEvent to be a typedef for QEvent. (QEvent::QEvent): Removed AccelAvailable, and added KParts, so I could remove some ugly constants from the KParts code. (QMouseEvent::button): Use a cast here since the field is now int. (QMouseEvent::state): Use a cast here since the field is now int. (QMouseEvent::stateAfter): Use a cast here since the field is now int, and use the new _stateAfter field. (QTimerEvent::QTimerEvent): Moved the constructor to be inline since it's so simple. (QKeyEvent::QKeyEvent): Removed type and button state parameters, now unneeded. Also removed now-unused _key, _ascii, and _count fields, and key(), ascii(), and count() functions. (QKeyEvent::state): Made inline. (QKeyEvent::isAccepted): Made inline. (QKeyEvent::text): Made inline. (QKeyEvent::isAutoRepeat): Made inline. (QKeyEvent::accept): Made inline. (QKeyEvent::ignore): Made inline. (QKeyEvent::unmodifiedText): Made inline. (QKeyEvent::keyIdentifier): Made inline and chnaged name from identifier().
kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Renamed from identifierForKeyText and changed parameter to be the event. Cleaned up the code a little bit, and wrote a comment or two. Changed from lowercase hex to uppercase, and called toupper on the key so that letter a-z would work properly. (A non-Unicode toupper is just the ticket here, because I am only sure we want to do this for a-z, not other lowercase characters.) (isKeypadEvent): Added. Uses virtual key codes to decide if a key event is a keypad event, so we can set the state flag correctly. (WindowsKeyCodeForKeyEvent): Added Clear key to the switch statement; it was missing. Changed to no longe use the characterCode helper function since this was the only place it was needed. (mouseButtonForEvent): Added. Similar logic to what was in KWQKHTMLPart before; better factoring to have it in here. (nonMouseButtonsForEvent): Ditto. (QMouseEvent::QMouseEvent): Rewrote constructors. One matches the one from Qt that's used in some places in KHTML code. The other takes an NSEvent and uses the new functions above to compute the button and state. (QKeyEvent::QKeyEvent): Computer type based on the passed-in NSEvent. Compute the auto-repeat flag based on the event and also the "forceAutoRepeat" parameter. Compute the button state based on the event too.

kwq/KWQKHTMLPart.h: Remove buttonForCurrentEvent and stateForCurrentEvent. Both are now in KWQEvent.mm.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Remove extra parameters in code that creates QKeyEvent, now that QKeyEvent can handle everything itself. (KWQKHTMLPart::mouseDown): Same thing as above, only for QMouseEvent. (KWQKHTMLPart::mouseDragged): Ditto. (KWQKHTMLPart::mouseUp): Ditto. (KWQKHTMLPart::mouseMoved): Ditto. (KWQKHTMLPart::sendContextMenuEvent): Ditto.

kwq/KWQKPartsEvent.h: Tweaked the class around a little so it can work without taking advantage of QCustomEvent's data pointer.
kwq/KWQKPartsEvent.mm: (KParts::Event::Event): Changed so it does a strdup on the event name and uses the new event type pre-allocated in KWQEvent.h for us. (KParts::Event::~Event): Free the event name. (KParts::Event::test): Reimplemented this.

kwq/KWQKPartsPart.h: (KParts::Part::event): Removed now-unnecessary cast to change a QCustomEvent into a QEvent.

kwq/KWQNamespace.h: Removed the Qt::Key enum. All the code that used it was already broken because of the mixup between Qt and Macintosh key codes.

4:59 PM Changeset in webkit [5555] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

<rdar://problem/3487079>: Some scheme checks in KURL do not verify
first char is a legal first char for a scheme

kwq/KWQKURL.mm: (KURL::KURL): Added some additional checks when looking through strings looking for schemes. Now the first character is checked for validity as a first character in a scheme.

4:54 PM Changeset in webkit [5554] by hyatt

2 edits in trunk/WebCore

Fix for 3486441, don't use the visibleWidth when computing the containingBlockWidth(). No need to
query the view, since the canvas's width has been set to the proper size (when printing).

Reviewed by john

khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth):

3:44 PM Changeset in webkit [5553]

1 copy
93 deletes in branches/unlabeled-1.45.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.45.4'.

3:44 PM Changeset in webkit [5552] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

fixed 3413713 - iframe forms posting fails without initial src attribute value

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): If the new part is for "about:blank", set the document base URL to parent's base URL.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument): If this part is an iframe, set the document base URL to the parent's base URL.

3:40 PM Changeset in webkit [5551]

1 copy
78 deletes in branches/unlabeled-1.44.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.44.4'.

3:40 PM Changeset in webkit [5550] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3485925: Safari does not correctly parse eight-digit hex character entities

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseEntity): Replaced puzzling variable limit on number of hexadecimal characters to parse with an 8-character limit.

3:35 PM Changeset in webkit [5549]

1 copy
78 deletes in branches/unlabeled-1.36.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.36.4'.

3:35 PM Changeset in webkit [5548] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3485572 -- secure form check in KHTML uses case-sensitive comparison with "https"

khtml/html/html_formimpl.h:
khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formWouldHaveSecureSubmission): Changed to take a DOMString reference for slightly better efficiency, and to use startsWith so the prefix check is not case sensitive and for slightly better efficiency and clarity than calling latin1() and using strncmp.

3:29 PM Changeset in webkit [5547] by mjs

2 edits in trunk/WebCore

commit updated .lut.h file that I forgot to commit before

khtml/ecma/kjs_window.lut.h:

3:27 PM Changeset in webkit [5546] by mjs

6 edits in trunk/WebCore

Reviewed by Darin.

fixed 3382829 - Safari won't load script src javascript if done by a document.write followed by document.close

khtml/xml/dom_docimpl.cpp: (DocumentImpl::closeInternal): Don't delete the tokenizer if it's waiting for scripts. It will get destroyed later when the part gets all subresources and closes the document.
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::isWaitingForScripts): Added.
khtml/html/htmltokenizer.h: Prototyped.
khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::isWaitingForScripts): Added.
khtml/xml/xml_tokenizer.h: Prototyped.

3:24 PM Changeset in webkit [5545] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

Add malformed table content test.

3:23 PM Changeset in webkit [5544] by hyatt

2 edits in trunk/WebCore

Fix for 3480108, crash because of the wrong malformedTableParent when stray content is placed inside
a <tr>.

Reviewed by john

khtml/html/htmlparser.cpp: (KHTMLParser::popBlock):

3:21 PM Changeset in webkit [5543] by mjs

2 edits in trunk/WebCore

Add file I forgot in the last commit.

3:17 PM Changeset in webkit [5542] by mjs

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3397494 - FileMaker: Setting option object text fails if created without text

khtml/html/html_formimpl.cpp: (HTMLOptionElementImpl::childrenChanged): Update the select element. This ends up getting called when you add a text node to an option that didn't used to have one.

3:12 PM Changeset in webkit [5541] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3480023>: Links don't work if there's a colon in the URL

The colon in the URL was confusing KURL. I modified some checks in
KURL so that its search for schemes stops when a non-scheme
character is found rather than when a path end segment character
is found.

kwq/KWQKURL.mm: Added a new Colon class to the table of characters. (isSchemeCharOrColon): New helper. (KURL::KURL): Call on new helper when looking for a scheme. (KURL::findHostnameInHierarchicalURL): Ditto.

2:20 PM Changeset in webkit [5540] by hyatt

16 edits in trunk/LayoutTests

Revise layout tests now that we break on hyphens and question marks.

2:08 PM Changeset in webkit [5539] by hyatt

2 edits in trunk/WebCore

Fix for 2931829, lines with hyphens should break on the hyphens. Match WinIE's behavior of
breaking on - and ?.

Reviewed by john

khtml/rendering/break_lines.cpp: (khtml::isBreakable):

1:15 PM Changeset in webkit [5538] by hyatt

12 edits in trunk/LayoutTests

Check in revised layout tests after changing all the logical font size definitions.

12:38 PM Changeset in webkit [5537] by hyatt

9 edits in trunk/WebCore

Fix for 3415771, Safari should use mini form controls when necessary. This patch adds heuristics for
swapping in mini form controls and also drops intrinsic margins when mini form controls are used.

Fix for 3486454, options/optgroups should strip leading/trailing space.

Together these two fixes solve 3486581, travelocity misrenders because form controls are too large.

Reviewed by Darin

Also fixing 3474994, alink needs to be restricted to actual links and not all <a> tags.

Reviewed by John

Finally, adding :active outlines around <input type=image> (covered by the old bug 3141767).

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::applyRule): (khtml::CSSStyleSelector::checkForGenericFamilyChange): (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (khtml::): (khtml::CSSStyleSelector::fontSizeForKeyword): (khtml::CSSStyleSelector::largerFontSize): (khtml::CSSStyleSelector::smallerFontSize):
khtml/css/cssstyleselector.h:
khtml/css/html4.css:
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor):
khtml/rendering/render_form.cpp: (RenderFormElement::addIntrinsicMarginsIfAllowed): (RenderSelect::updateFromElement):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): (DocumentImpl::attach):
kwq/KWQButton.mm: (KWQNSControlSizeForFont):

3:45 AM Changeset in webkit [5536] by hyatt

2 edits in trunk/WebCore

Back out my change to exclude text runs from getting a relayout on a style change. I totally forgot about
text zooming.

khtml/rendering/render_object.cpp: (RenderObject::setStyle):

1:29 AM Changeset in webkit [5535] by mjs

11 edits
1 add in trunk

WebCore:

Reviewed by Dave.

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

khtml/ecma/kjs_window.cpp: (Window::get): add support for window.print (Apple-only) (WindowFunc::tryCall): ditto
khtml/ecma/kjs_window.h: Add Print to enum
khtml/ecma/kjs_window.lut.h: Regenerated
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::print): Call bridge.
kwq/KWQKHTMLPart.h: Declare above.
kwq/WebCoreBridge.h: prototype print method for other side of bridge.

WebKit:

Reviewed by Dave.

WebKit part of fix for:

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge print]): Call delegate.
WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webViewPrint:]): Implemented (do nothing).
WebView.subproj/WebUIDelegatePrivate.h: Added. Add extra SPI method webViewPrint: for UI delegate.
WebKit.pbproj/project.pbxproj: Install WebUIDelegatePrivate.h as private header

WebBrowser:

Reviewed by Dave.

WebBrowser part of fix for:

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

BrowserWebController.m: (-[BrowserWebView webViewPrint:]): Call printDocument: on the document.

Nov 16, 2003:

9:34 PM Changeset in webkit [5534] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Check for the returned part being NULL, not the out value pointer.

6:31 PM Changeset in webkit [5533]

1 copy
71 deletes in branches/unlabeled-1.54.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.54.4'.

6:31 PM Changeset in webkit [5532] by hyatt

9 edits in trunk/WebCore

Fix for 3485779, <input type=image> and <button> should not be mouse focusable.

Fix for 3485795, <input type=image> and <button> are being treated like links when they should not be.

Fix for 3485817, <input type=image> and <button> should obey full keyboard access mode.

Fix for 3485802, fieldset/legend/option/optgroup/label should not be focusable at all.

Reviewed by kocienda

ChangeLog:
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::isMouseFocusable): (HTMLFieldSetElementImpl::isFocusable): (HTMLLabelElementImpl::isFocusable): (HTMLLegendElementImpl::isFocusable): (HTMLOptGroupElementImpl::isFocusable): (HTMLOptionElementImpl::HTMLOptionElementImpl): (HTMLOptionElementImpl::isFocusable):
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isMouseFocusable): (HTMLAnchorElementImpl::isKeyboardFocusable):
khtml/html/html_inlineimpl.h:
khtml/khtml_part.cpp: (KHTMLPart::tabsToLinks): (KHTMLPart::tabsToAllControls):
khtml/khtml_part.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): (KWQKHTMLPart::tabsToLinks): (KWQKHTMLPart::tabsToAllControls):

5:36 PM Changeset in webkit [5531] by darin

12 edits in trunk/WebKit

Reviewed by John.

fixes 3457162 -- selecting text during a page load that blows the text field away causes a crash
fixes 3160035 -- crash or hang if you hold down a button while "go to about:blank soon" test runs
without causing 3484608 -- REGRESSION: Flash broken at http://www.macromedia.com/

The WebKit part of this fix is making setDefersCallbacks: work. It had succumbed to bit rot.
This has a side effect of not considering a page load done until all the plug-in streams are loaded.
If that's not a good idea, we'll have to keep two separate lists in WebDataSource.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]): Set the defersCallbacks state from the WebView here so that clients don't have to do it.

WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresourceClient:]): Remove call to set the defersCallbacks state on the subresource client, because the above change obviates it. (the client/delegate terminology makes it confusing, but it's a subclass). Also loosen the type so we can call this on clients for plug-in streams too. (-[WebDataSource _removeSubresourceClient:]): Loosen type here too. (-[WebDataSource _defersCallbacksChanged]): And here.
WebView.subproj/WebDataSourcePrivate.h: Loosen type of subresource client so we can pass in the delegates for plug-in streams too.

WebView.subproj/WebMainResourceClient.h: Added an _initialRequest field so we can defer the very first callback, which does not rely on NSURLConnection.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): Release the initial request. (-[WebMainResourceClient loadWithRequestNow:]): Moved the guts of loadWithRequest in here; to be used when the request is no longer deferred. Also removed the code to call setDefersCallbacks: on the connection, and assert that we are only called when callbacks are not deferred. Because the very first callback was not deferred, we would end up calling setDefersCallbacks:NO on the WebView, so nothing would be deferred. (-[WebMainResourceClient loadWithRequest:]): If callbacks are not deferred, then call the loadWithRequestNow: method, otherwise simply store the request in _initialRequest. (-[WebMainResourceClient setDefersCallbacks:]): If there is an _initialRequest and we are ceasing deferral of callbacks, then call the loadWithRequestNow: method.

Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]): Call _addSubresourceClient, and then _removeSubresourceClient if the load fails to even start. (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Call _removeSubresourceClient. (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Call _removeSubresourceClient.

Plugins.subproj/WebBaseNetscapePluginStream.h: Removed unneeded import.
Plugins.subproj/WebPluginDatabase.m: Add import needed now that WebBaseNetscapePluginStream.h imports less than before.

5:13 PM Changeset in webkit [5530] by mjs

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3484723 - name property of window reference from window.open call is always empty

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set the part name on the khtml side when making a new window.

4:02 PM Changeset in webkit [5529] by hyatt

2 edits in trunk/WebCore

Fix for 3485766.

Make sure DOM elements that are programmatically focused at a time when they have no render objects restore the
focus to their widgets when render objects get built.

Reviewed by darin

khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach):

3:23 PM Changeset in webkit [5528] by mjs

1 edit in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore/ChangeLog

merged the following fix from HEAD

2003-11-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by John.

fixed 3483829 - JavaScriptCore needs workaround to compile on Merlot

JavaScriptCore.pbproj/project.pbxproj: Add -Wno-long-double to warning flags.

3:03 PM Changeset in webkit [5527] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3483829 - JavaScriptCore needs workaround to compile on Merlot

JavaScriptCore.pbproj/project.pbxproj: Add -Wno-long-double to warning flags.

3:02 PM Changeset in webkit [5526]

1 copy
115 deletes in branches/unlabeled-1.47.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.47.4'.

3:02 PM Changeset in webkit [5525]

1 copy
584 deletes in branches/unlabeled-1.3.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.3.4'.

3:02 PM Changeset in webkit [5524]

1 copy
986 deletes in branches/unlabeled-1.2.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2.4'.

3:02 PM Changeset in webkit [5523] by hyatt

272 edits in trunk

Add border info to the render tree dumper.

khtml/rendering/render_style.h: (khtml::BorderValue::operator!=):
kwq/KWQRenderTreeDebug.cpp: (printBorderStyle): (operator<<):
layout-tests/apple-only/base/bugzilla.mozilla.org/index-expected.txt:
layout-tests/apple-only/base/home.netscape.com/index-expected.txt:
layout-tests/apple-only/base/lxr.mozilla.org/index-expected.txt:
layout-tests/apple-only/base/my.netscape.com/index-expected.txt:
layout-tests/apple-only/base/news.cnet.com/index-expected.txt:
layout-tests/apple-only/base/web.icq.com/index-expected.txt:
layout-tests/apple-only/base/www.altavista.com/index-expected.txt:
layout-tests/apple-only/base/www.amazon.com/index-expected.txt:
layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
layout-tests/apple-only/base/www.digitalcity.com/index-expected.txt:
layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
layout-tests/apple-only/base/www.excite.com/index-expected.txt:
layout-tests/apple-only/base/www.expedia.com/index-expected.txt:
layout-tests/apple-only/base/www.iplanet.com/index-expected.txt:
layout-tests/apple-only/base/www.mapquest.com/index-expected.txt:
layout-tests/apple-only/base/www.microsoft.com/index-expected.txt:
layout-tests/apple-only/base/www.moviefone.com/index-expected.txt:
layout-tests/apple-only/base/www.msn.com/index-expected.txt:
layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
layout-tests/apple-only/base/www.nytimes.com/index-expected.txt:
layout-tests/apple-only/base/www.nytimes.com_Table/index-expected.txt:
layout-tests/apple-only/base/www.quicken.com/index-expected.txt:
layout-tests/apple-only/base/www.sun.com/index-expected.txt:
layout-tests/apple-only/base/www.time.com/index-expected.txt:
layout-tests/apple-only/base/www.travelocity.com/index-expected.txt:
layout-tests/apple-only/base/www.w3.org_DOML2Core/index-expected.txt:
layout-tests/apple-only/base/www.yahoo.com/index-expected.txt:
layout-tests/apple-only/base/www.zdnet.com/index-expected.txt:
layout-tests/apple-only/base/www.zdnet.com_Gamespot.com/index-expected.txt:
layout-tests/css1/basic/class_as_selector-expected.txt:
layout-tests/css1/basic/comments-expected.txt:
layout-tests/css1/basic/containment-expected.txt:
layout-tests/css1/basic/contextual_selectors-expected.txt:
layout-tests/css1/basic/grouping-expected.txt:
layout-tests/css1/basic/id_as_selector-expected.txt:
layout-tests/css1/basic/inheritance-expected.txt:
layout-tests/css1/box_properties/acid_test-expected.txt:
layout-tests/css1/box_properties/border-expected.txt:
layout-tests/css1/box_properties/border_bottom-expected.txt:
layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
layout-tests/css1/box_properties/border_bottom_width-expected.txt:
layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
layout-tests/css1/box_properties/border_color-expected.txt:
layout-tests/css1/box_properties/border_color_inline-expected.txt:
layout-tests/css1/box_properties/border_inline-expected.txt:
layout-tests/css1/box_properties/border_left-expected.txt:
layout-tests/css1/box_properties/border_left_inline-expected.txt:
layout-tests/css1/box_properties/border_left_width-expected.txt:
layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
layout-tests/css1/box_properties/border_right-expected.txt:
layout-tests/css1/box_properties/border_right_inline-expected.txt:
layout-tests/css1/box_properties/border_right_width-expected.txt:
layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
layout-tests/css1/box_properties/border_style-expected.txt:
layout-tests/css1/box_properties/border_style_inline-expected.txt:
layout-tests/css1/box_properties/border_top-expected.txt:
layout-tests/css1/box_properties/border_top_inline-expected.txt:
layout-tests/css1/box_properties/border_top_width-expected.txt:
layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
layout-tests/css1/box_properties/border_width-expected.txt:
layout-tests/css1/box_properties/border_width_inline-expected.txt:
layout-tests/css1/box_properties/clear-expected.txt:
layout-tests/css1/box_properties/clear_float-expected.txt:
layout-tests/css1/box_properties/float-expected.txt:
layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
layout-tests/css1/box_properties/float_margin-expected.txt:
layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
layout-tests/css1/box_properties/height-expected.txt:
layout-tests/css1/box_properties/margin-expected.txt:
layout-tests/css1/box_properties/margin_bottom-expected.txt:
layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
layout-tests/css1/box_properties/margin_inline-expected.txt:
layout-tests/css1/box_properties/margin_left-expected.txt:
layout-tests/css1/box_properties/margin_left_inline-expected.txt:
layout-tests/css1/box_properties/margin_right-expected.txt:
layout-tests/css1/box_properties/margin_right_inline-expected.txt:
layout-tests/css1/box_properties/margin_top-expected.txt:
layout-tests/css1/box_properties/margin_top_inline-expected.txt:
layout-tests/css1/box_properties/padding-expected.txt:
layout-tests/css1/box_properties/padding_bottom-expected.txt:
layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
layout-tests/css1/box_properties/padding_inline-expected.txt:
layout-tests/css1/box_properties/padding_left-expected.txt:
layout-tests/css1/box_properties/padding_left_inline-expected.txt:
layout-tests/css1/box_properties/padding_right-expected.txt:
layout-tests/css1/box_properties/padding_right_inline-expected.txt:
layout-tests/css1/box_properties/padding_top-expected.txt:
layout-tests/css1/box_properties/padding_top_inline-expected.txt:
layout-tests/css1/box_properties/width-expected.txt:
layout-tests/css1/cascade/cascade_order-expected.txt:
layout-tests/css1/cascade/important-expected.txt:
layout-tests/css1/classification/display-expected.txt:
layout-tests/css1/classification/list_style-expected.txt:
layout-tests/css1/classification/list_style_image-expected.txt:
layout-tests/css1/classification/list_style_position-expected.txt:
layout-tests/css1/classification/list_style_type-expected.txt:
layout-tests/css1/classification/white_space-expected.txt:
layout-tests/css1/color_and_background/background-expected.txt:
layout-tests/css1/color_and_background/background_attachment-expected.txt:
layout-tests/css1/color_and_background/background_color-expected.txt:
layout-tests/css1/color_and_background/background_image-expected.txt:
layout-tests/css1/color_and_background/background_position-expected.txt:
layout-tests/css1/color_and_background/background_repeat-expected.txt:
layout-tests/css1/color_and_background/color-expected.txt:
layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
layout-tests/css1/font_properties/font-expected.txt:
layout-tests/css1/font_properties/font_family-expected.txt:
layout-tests/css1/font_properties/font_size-expected.txt:
layout-tests/css1/font_properties/font_style-expected.txt:
layout-tests/css1/font_properties/font_variant-expected.txt:
layout-tests/css1/font_properties/font_weight-expected.txt:
layout-tests/css1/formatting_model/canvas-expected.txt:
layout-tests/css1/formatting_model/floating_elements-expected.txt:
layout-tests/css1/formatting_model/height_of_lines-expected.txt:
layout-tests/css1/formatting_model/inline_elements-expected.txt:
layout-tests/css1/formatting_model/replaced_elements-expected.txt:
layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
layout-tests/css1/pseudo/anchor-expected.txt:
layout-tests/css1/pseudo/firstletter-expected.txt:
layout-tests/css1/pseudo/firstline-expected.txt:
layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
layout-tests/css1/text_properties/letter_spacing-expected.txt:
layout-tests/css1/text_properties/line_height-expected.txt:
layout-tests/css1/text_properties/text-transform-expected.txt:
layout-tests/css1/text_properties/text_align-expected.txt:
layout-tests/css1/text_properties/text_decoration-expected.txt:
layout-tests/css1/text_properties/text_indent-expected.txt:
layout-tests/css1/text_properties/text_transform-expected.txt:
layout-tests/css1/text_properties/vertical_align-expected.txt:
layout-tests/css1/text_properties/word_spacing-expected.txt:
layout-tests/css1/units/color_units-expected.txt:
layout-tests/css1/units/length_units-expected.txt:
layout-tests/css1/units/percentage_units-expected.txt:
layout-tests/css1/units/urls-expected.txt:
layout-tests/fast/block/basic/001-expected.txt:
layout-tests/fast/block/basic/002-expected.txt:
layout-tests/fast/block/basic/003-expected.txt:
layout-tests/fast/block/basic/004-expected.txt:
layout-tests/fast/block/basic/007-expected.txt:
layout-tests/fast/block/basic/011-expected.txt:
layout-tests/fast/block/basic/015-expected.txt:
layout-tests/fast/block/basic/016-expected.txt:
layout-tests/fast/block/basic/017-expected.txt:
layout-tests/fast/block/basic/018-expected.txt:
layout-tests/fast/block/basic/019-expected.txt:
layout-tests/fast/block/float/004-expected.txt:
layout-tests/fast/block/float/005-expected.txt:
layout-tests/fast/block/float/006-expected.txt:
layout-tests/fast/block/float/007-expected.txt:
layout-tests/fast/block/float/012-expected.txt:
layout-tests/fast/block/float/013-expected.txt:
layout-tests/fast/block/float/015-expected.txt:
layout-tests/fast/block/float/016-expected.txt:
layout-tests/fast/block/float/017-expected.txt:
layout-tests/fast/block/float/019-expected.txt:
layout-tests/fast/block/float/021-expected.txt:
layout-tests/fast/block/float/022-expected.txt:
layout-tests/fast/block/float/024-expected.txt:
layout-tests/fast/block/float/025-expected.txt:
layout-tests/fast/block/float/026-expected.txt:
layout-tests/fast/block/float/027-expected.txt:
layout-tests/fast/block/float/028-expected.txt:
layout-tests/fast/block/margin-collapse/001-expected.txt:
layout-tests/fast/block/margin-collapse/005-expected.txt:
layout-tests/fast/block/margin-collapse/006-expected.txt:
layout-tests/fast/block/margin-collapse/010-expected.txt:
layout-tests/fast/block/margin-collapse/011-expected.txt:
layout-tests/fast/block/margin-collapse/012-expected.txt:
layout-tests/fast/block/margin-collapse/015-expected.txt:
layout-tests/fast/block/margin-collapse/016-expected.txt:
layout-tests/fast/block/margin-collapse/017-expected.txt:
layout-tests/fast/block/margin-collapse/018-expected.txt:
layout-tests/fast/block/margin-collapse/019-expected.txt:
layout-tests/fast/block/margin-collapse/020-expected.txt:
layout-tests/fast/block/margin-collapse/021-expected.txt:
layout-tests/fast/block/margin-collapse/022-expected.txt:
layout-tests/fast/block/margin-collapse/024-expected.txt:
layout-tests/fast/block/margin-collapse/025-expected.txt:
layout-tests/fast/block/margin-collapse/026-expected.txt:
layout-tests/fast/block/margin-collapse/027-expected.txt:
layout-tests/fast/block/margin-collapse/028-expected.txt:
layout-tests/fast/block/margin-collapse/029-expected.txt:
layout-tests/fast/block/margin-collapse/030-expected.txt:
layout-tests/fast/block/margin-collapse/032-expected.txt:
layout-tests/fast/block/margin-collapse/033-expected.txt:
layout-tests/fast/block/margin-collapse/034-expected.txt:
layout-tests/fast/block/margin-collapse/035-expected.txt:
layout-tests/fast/block/margin-collapse/041-expected.txt:
layout-tests/fast/block/margin-collapse/042-expected.txt:
layout-tests/fast/block/margin-collapse/043-expected.txt:
layout-tests/fast/block/positioning/048-expected.txt:
layout-tests/fast/block/positioning/049-expected.txt:
layout-tests/fast/block/positioning/050-expected.txt:
layout-tests/fast/block/positioning/051-expected.txt:
layout-tests/fast/block/positioning/056-expected.txt:
layout-tests/fast/block/positioning/057-expected.txt:
layout-tests/fast/block/positioning/058-expected.txt:
layout-tests/fast/block/positioning/auto/001-expected.txt:
layout-tests/fast/block/positioning/auto/002-expected.txt:
layout-tests/fast/block/positioning/auto/003-expected.txt:
layout-tests/fast/block/positioning/auto/004-expected.txt:
layout-tests/fast/block/positioning/auto/005-expected.txt:
layout-tests/fast/block/positioning/auto/006-expected.txt:
layout-tests/fast/clip/013-expected.txt:
layout-tests/fast/clip/014-expected.txt:
layout-tests/fast/css-generated-content/006-expected.txt:
layout-tests/fast/css/003-expected.txt:
layout-tests/fast/css/004-expected.txt:
layout-tests/fast/css/005-expected.txt:
layout-tests/fast/dynamic/002-expected.txt:
layout-tests/fast/dynamic/004-expected.txt:
layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
layout-tests/fast/flexbox/007-expected.txt:
layout-tests/fast/flexbox/008-expected.txt:
layout-tests/fast/flexbox/009-expected.txt:
layout-tests/fast/flexbox/011-expected.txt:
layout-tests/fast/flexbox/016-expected.txt:
layout-tests/fast/flexbox/017-expected.txt:
layout-tests/fast/flexbox/018-expected.txt:
layout-tests/fast/flexbox/019-expected.txt:
layout-tests/fast/flexbox/022-expected.txt:
layout-tests/fast/flexbox/025-expected.txt:
layout-tests/fast/forms/001-expected.txt:
layout-tests/fast/forms/002-expected.txt:
layout-tests/fast/forms/006-expected.txt:
layout-tests/fast/forms/007-expected.txt:
layout-tests/fast/forms/form-element-geometry-expected.txt:
layout-tests/fast/frames/001-expected.txt:
layout-tests/fast/inline-block/001-expected.txt:
layout-tests/fast/inline-block/002-expected.txt:
layout-tests/fast/inline-block/003-expected.txt:
layout-tests/fast/inline/001-expected.txt:
layout-tests/fast/invalid/008-expected.txt:
layout-tests/fast/invalid/014-expected.txt:
layout-tests/fast/invalid/016-expected.txt:
layout-tests/fast/lists/001-expected.txt:
layout-tests/fast/lists/004-expected.txt:
layout-tests/fast/lists/007-expected.txt:
layout-tests/fast/overflow/001-expected.txt:
layout-tests/fast/overflow/002-expected.txt:
layout-tests/fast/overflow/004-expected.txt:
layout-tests/fast/replaced/005-expected.txt:
layout-tests/fast/replaced/006-expected.txt:
layout-tests/fast/replaced/008-expected.txt:
layout-tests/fast/selectors/009-expected.txt:
layout-tests/fast/selectors/014-expected.txt:
layout-tests/fast/selectors/032-expected.txt:
layout-tests/fast/selectors/033-expected.txt:
layout-tests/fast/selectors/039-expected.txt:
layout-tests/fast/selectors/039b-expected.txt:
layout-tests/fast/selectors/064-expected.txt:
layout-tests/fast/selectors/077-expected.txt:
layout-tests/fast/selectors/077b-expected.txt:
layout-tests/fast/selectors/078-expected.txt:
layout-tests/fast/selectors/078b-expected.txt:
layout-tests/fast/selectors/166a-expected.txt:
layout-tests/fast/table/003-expected.txt:
layout-tests/fast/table/004-expected.txt:
layout-tests/fast/table/005-expected.txt:
layout-tests/fast/table/006-expected.txt:
layout-tests/fast/table/007-expected.txt:
layout-tests/fast/table/008-expected.txt:
layout-tests/fast/table/009-expected.txt:
layout-tests/fast/table/015-expected.txt:
layout-tests/fast/table/017-expected.txt:
layout-tests/fast/table/018-expected.txt:
layout-tests/fast/table/020-expected.txt:
layout-tests/fast/table/023-expected.txt:
layout-tests/fast/table/025-expected.txt:
layout-tests/fast/table/027-expected.txt:
layout-tests/fast/table/028-expected.txt:
layout-tests/fast/table/029-expected.txt:
layout-tests/fast/table/030-expected.txt:
layout-tests/fast/table/035-expected.txt:
layout-tests/fast/table/036-expected.txt:
layout-tests/fast/table/038-expected.txt:
layout-tests/fast/table/border-collapsing/001-expected.txt:
layout-tests/fast/table/border-collapsing/002-expected.txt:
layout-tests/fast/table/border-collapsing/003-expected.txt:
layout-tests/fast/table/border-collapsing/004-expected.txt:
layout-tests/fast/table/large-width-expected.txt:
layout-tests/fast/table/nobr-expected.txt:
layout-tests/fast/text/basic/001-expected.txt:
layout-tests/fast/text/basic/003-expected.txt:
layout-tests/fast/text/basic/004-expected.txt:
layout-tests/fast/text/basic/005-expected.txt:
layout-tests/fast/text/basic/006-expected.txt:
layout-tests/fast/text/basic/007-expected.txt:
layout-tests/fast/text/basic/012-expected.txt:
layout-tests/fast/text/firstline/002-expected.txt:
layout-tests/fast/text/whitespace/002-expected.txt:
layout-tests/fast/text/whitespace/003-expected.txt:
layout-tests/fast/text/whitespace/020-expected.txt:
layout-tests/fast/text/whitespace/023-expected.txt:
layout-tests/fast/text/whitespace/024-expected.txt:
layout-tests/fast/text/whitespace/025-expected.txt:
layout-tests/fast/text/whitespace/027-expected.txt:

1:25 PM Changeset in webkit [5522] by mjs

4 edits in trunk

WebCore:

Reviewed by John.

fixed 3362841 - javascript History Object length property is always 0

kwq/KWQKPartsBrowserInterface.mm: (KParts::BrowserInterface::property): For the historyLength property, retturn a UInt variant, not Int, because that's what the kjs_window code expects.

WebKit:

Reviewed by John.

fixed 3362841 - javascript History Object length property is always 0

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge historyLength]): Add one to the length to match other browsers.

1:20 PM Changeset in webkit [5521] by mjs

3 edits in trunk/WebCore

Reviewed by Ken and Dave.

fixed 3471925 - getting and setting cssText not implemented

khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::cssText): Implemented by gathering text of all properties (that are not non-CSS hints), separated with semicolons. (CSSStyleDeclarationImpl::setCssText): Implemented by clearing all existing properties (that are not non-CSS hints) and invoking css parser. (CSSValueListImpl::cssText): Implemented. (FontValueImpl::cssText): Implemented. (ShadowValueImpl::cssText): Implemented. (CSSProperty::cssText): Implemented.
khtml/css/css_valueimpl.h: Declared new methods; made CSSValueImpl::cssText() pure virtual; removed CSSValueImpl::setCssText().

1:02 PM Changeset in webkit [5520] by hyatt

1 edit in trunk/LayoutTests/fast/overflow/004.html

Fix overflow test to be in strict mode.

1:01 PM Changeset in webkit [5519] by hyatt

11 adds in trunk/LayoutTests/fast/css

Adding css tests.

1:00 PM Changeset in webkit [5518] by hyatt

2 deletes in trunk/LayoutTests/fast/selectors

Moving this test.

12:57 PM Changeset in webkit [5517] by hyatt

2 adds in trunk/LayoutTests/fast/dynamic

Add a dynamic id manipulation test.

12:53 PM Changeset in webkit [5516] by hyatt

4 adds in trunk/LayoutTests/fast/block/basic

Adding basic block tests for hr and h1

12:51 PM Changeset in webkit [5515] by hyatt

8 adds in trunk/LayoutTests/fast/block/float

Add new tests for float displacement.

12:50 PM Changeset in webkit [5514] by hyatt

1 edit in trunk/LayoutTests/fast/block/basic/016-expected.txt

Fix the alignment test.

12:48 PM Changeset in webkit [5513]

1 copy
93 deletes in branches/unlabeled-1.93.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.93.4'.

12:48 PM Changeset in webkit [5512]

1 copy
102 deletes in branches/unlabeled-1.17.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.17.4'.

12:48 PM Changeset in webkit [5511] by hyatt

14 edits in trunk/WebCore

3485717, Cleanup of the float code. Eliminated the -khtml-flow-mode style property in favor of two simple methods,
avoidsFloats() and usesLineWidth(). avoidsFloats can be called to tell whether an object does not want
floats to intrude into its space (and that it should also move to avoid floats). usesLineWidth is called
to find out if an object's containing block width is the line width or the content width, and has all the
right smarts to emulate WinIE's behaviors in both quirks and strict mode.

Also fixed a bug (3485718) where overflow:scroll blocks with auto height did not factor in the horizontal scrollbar's
height (thus causing it to paint on top of content).

Reviewed by darin

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/css/html4.css:
khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::clearFloats):
khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::calcWidth):
khtml/rendering/render_object.cpp: (RenderObject::isHR):
khtml/rendering/render_object.h: (khtml::RenderObject::avoidsFloats): (khtml::RenderObject::usesLineWidth):
khtml/rendering/render_style.h: (khtml::RenderStyle::NonInheritedFlags::operator==): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::initialTextDecoration):
khtml/rendering/render_table.cpp: (RenderTable::calcWidth):

12:33 PM Changeset in webkit [5510]

7 copies
3 deletes in tags/WebKit-106~1

This commit was manufactured by cvs2svn to create tag 'WebKit-106~1'.

12:33 PM Changeset in webkit [5509]

25 copies
2 deletes in tags/WebCore-106~1

This commit was manufactured by cvs2svn to create tag
'WebCore-106~1'.

12:33 PM Changeset in webkit [5508] by vicki

2 edits in branches/SUPanBisque-branch

bump WebKit and WebCore versions to 106.1, for SUPanBisque

Nov 15, 2003:

10:22 PM Changeset in webkit [5507] by hyatt

4 edits in trunk/WebCore

Fix for 3485260, regression on Uniview site from incremental repainting. When appending/inserting child
nodes into the render tree, we need to always mark them as needing layout themselves (and not just as
having children needing layout). This ensures that the incremental repainting code will know to repaint the
enclosing container (even though that container's size may not change).

Fix for 3411960, block-level replaced elements should avoid floats.

Fix for 3463234, floats should not intrude into overflow blocks (even when siblings happen to get in
between the float and the overflow block).

Fix for 3485576, the containing block for text runs is incorrect.

Fix for 3485577, text runs should not trigger layout when style is re-resolved.

Reviewed by darin

khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
khtml/rendering/render_box.cpp
khtml/rendering/render_object.cpp

9:53 PM Changeset in webkit [5506] by mjs

2 edits in branches/SUPanBisque-branch/WebCore

Reviewed by Darin.

initialize modifier key fields, needed to make the recent merged fixes work well

khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): Always initialize, don't only set to true.

9:42 PM Changeset in webkit [5505] by mjs

18 edits in branches/SUPanBisque-branch/WebCore

merged the following fixes from HEAD

2003-11-13 Darin Adler <Darin Adler>

Reviewed by Ken.

fixed 3452554 -- keyCode attribute for DOM events reports incorrect value

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Return the Windows key code for keydown and keyup events. But for other events, return the character code. This matches IE. (UIEvent::which): Same behavior for now; may need further refinement.

kwq/KWQEvent.h: Change QEvent to allow copying. The Qt version probably doesn't allow it, but for us it's no big deal. Our event objects are just data holders. (QKeyEvent::QKeyEvent): Change parameters; take an NSEvent and figure the rest out here. Except for now get the type, button state, and auto repeat flag from the caller because that's a smaller change from how things are done now. I'll take this the next step later.
kwq/KWQEvent.mm: (characterCode): Added. Extracts the character code from the string if it's exactly 1 character long. (WindowsKeyCode): Added. Given an event, figures out the Windows key code. (QKeyEvent::QKeyEvent): Changed to get things from the NSEvent rather than having them passed individually. One change is that _ascii is now the Unicode value of the first character in the string. This causes us to return the Unicode value from keyCode for keypress events. Another change is that we now compute the Windows key code.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Change to use the new QKeyEvent constructor, passing in the NSEvent.

khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): In APPLE_CHANGES, copy the QKeyEvent using the copy constructor rather than listing the fields. This is easier to maintain when the list of fields changes.

khtml/rendering/render_form.cpp: (ComboBoxWidget::eventFilter): Put #if !APPLE_CHANGES around code that constructs a QKeyEvent. We don't ever run this code, but now we can't compile it either so we need the #if.

2003-11-12 Ken Kocienda <kocienda@apple.com>

Reviewed by Richard

Fix for this bug:

<rdar://problem/3481600>: key event objects do not preserve unmodified keys

khtml/xml/dom2_eventsimpl.cpp: Modified constructor call to include unmodifiedText. (KeyboardEventImpl::KeyboardEventImpl):
kwq/KWQEvent.h: Added unmodifiedText accessor and variable to QKeyEvent.
kwq/KWQEvent.mm: (QKeyEvent::QKeyEvent): Modified constructor to include unmodifiedText. (QKeyEvent::unmodifiedText): Added accessor.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Modified constructor call to include unmodifiedText.

2003-11-05 Darin Adler <Darin Adler>

Reviewed by Maciej.

fixed 3475109 -- support keyboard event object properties of altkey, ctrlKey, shiftKey

We had the DOM Level 3 KeyboardEvent class already; I just had to add JavaScript bindings.

khtml/ecma/kjs_events.h: Added DOMKeyboardEvent class.
khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Added code to make a DOMKeyboardEvent if the event is a DOM::KeyboardEvent. (DOMKeyboardEvent::~DOMKeyboardEvent): Added. (DOMKeyboardEvent::classInfo): Added. (DOMKeyboardEvent::tryGet): Added. (DOMKeyboardEvent::getValueProperty): Added. (DOMKeyboardEventProtoFunc::tryCall): Added.

khtml/dom/dom2_events.cpp: (KeyboardEvent::keyIdentifier): Added. (KeyboardEvent::keyLocation): Added.

khtml/ecma/kjs_events.lut.h: Regenerated.

2003-10-20 Ken Kocienda <kocienda@apple.com>

Reviewed by David

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Change over to use ascii value for key code. (UIEvent::which): Ditto. (KeyboardEvent::KeyboardEvent): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEvent::operator = ): New function. (KeyboardEvent::~KeyboardEvent): New function. (KeyboardEvent::ctrlKey): New function. (KeyboardEvent::shiftKey): New function. (KeyboardEvent::altKey): New function. (KeyboardEvent::metaKey): New function. (KeyboardEvent::altGraphKey): New function. (KeyboardEvent::initKeyboardEvent): New function.
khtml/dom/dom2_events.h: Ditto.
khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Use key identifiers to test which key was pressed, instead of removed keyVal(). (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new class name. Use key identifiers to test which key was pressed, instead of removed keyVal(). Use new modifier accessors.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (EventImpl::idToType): Ditto. (KeyboardEventImpl::KeyboardEventImpl): New key event class which tracks the DOM Level 3 spec more closely. (KeyboardEventImpl::~KeyboardEventImpl): Ditto. (KeyboardEventImpl::initKeyboardEvent): Ditto.
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Some reorganization of the constants in the switch statements. Name change for these to remove the KHTML_ prefix from the key up and key down events will happen soon. (DOM::KeyboardEventImpl::keyIdentifier): New function. (DOM::KeyboardEventImpl::keyLocation): New function. (DOM::KeyboardEventImpl::ctrlKey): New function. (DOM::KeyboardEventImpl::shiftKey): New function. (DOM::KeyboardEventImpl::altKey): New function. (DOM::KeyboardEventImpl::metaKey): New function. (DOM::KeyboardEventImpl::altGraphKey): New function. (DOM::KeyboardEventImpl::qKeyEvent): New function.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Now can create keyboard events.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Class name changes.
kwq/KWQEvent.h: Added QString identifier member.
kwq/KWQEvent.mm: (hexDigit): Added helper. (identifierForKeyText): Added new function to map keys to DOM key identifiers as listed in the DOM spec. (QKeyEvent::identifier): Added accessor.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::stateForCurrentEvent): Added check to see if a key press is on one of the numeric keypad keys.
kwq/KWQLogging.h: Added log constant for DOM events.
kwq/KWQLogging.m: Ditto

Nov 14, 2003:

8:53 PM Changeset in webkit [5504] by hyatt

2 edits in trunk/WebCore

Fix for 3473707, 100% height positioned divs are too tall. The padding box wasn't being used like it was
supposed to be when calcing percentage heights.

Reviewed by kocienda

khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):

4:46 PM Changeset in webkit [5503] by sullivan

3 edits in trunk/WebKit

WebKit:

WebKit part of fix for <rdar://problem/3474757>: Safari on-screen text needs review

Reviewed by Ken.

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): change "Download Link to Disk" to "Download Linked File to Disk"

English.lproj/Localizable.strings: updated for these changes

WebBrowser:

WebBrowser part of fix for <rdar://problem/3474757>: Safari on-screen text needs review

Reviewed by Ken.

Many text changes. In a small number of places I got to delete stuff, but
mostly I just changed the words to match Ron's edit (after much discussion).

ABHomePagesController.m: (-[ABHomePagesController openAddressBook:]):
AppController.m: (-[AppController confirmSwitchDefaultBrowser]): (-[AppController _showResourceFileWithName:extension:]):
BookmarksController.m: (-[BookmarksController tellUserAboutExceptionInFileLockingCode]): (-[BookmarksController tellUserThatISyncWon]): (-[BookmarksController tellUserThatExternalChangePreemptedLocalChange]): (-[BookmarksController exportBookmarks:]):
BrowserDocument.m: (-[BrowserDocument panel:userEnteredFilename:confirmed:]):
BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
BrowserWebController.m: (-[BrowserWebView mouseoverTextForElement:modifierFlags:]): (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebView openFileExternallyWithRequest:inFrame:]): (-[BrowserWebView revealInFinderWithRequest:inFrame:]): (-[BrowserWebView decidePolicyForAction:request:frame:newFrameName:decisionListener:]): (-[BrowserWebView displayName]):
BrowserWindowController.m: (-[BrowserWindowController setUpSearchField]): (-[BrowserWindowController goToToolbarLocationWithWindowPolicy:]):
ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): (-[BrowserWebView saveFileWrapperForURLKey:menuItem:]):
DownloadRow.m: (-[DownloadRow _statusText]): (-[DownloadRow open:]):
DownloadViewController.m: (-[DownloadViewController _openEntries:]): (-[DownloadViewController _revealEntries:]):
DownloadWindowController.m: (-[DownloadWindowController windowDidLoad]): (-[DownloadWindowController askToTerminateWhileDownloading]): (-[DownloadWindowController reportInvalidDownloadFileErrorForPath:]):
FavoriteButton.m: (-[FavoriteButton setBookmark:]): (-[FavoriteButton confirmDeletingFolder]):
FavoritesBar.m: (-[FavoritesBar initWithView:]):
FormCompletionController.m: (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController autoFillInWebView:]):
LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]): (-[LoadProgressMonitor _statusSummary]): (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:dataSource:]): (-[LocationChangeHandler genericTitleForError:]): (-[LocationChangeHandler genericMessageForError:]):
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
Preferences.subproj/AutoFillPreferences.m: (-[AutoFillPreferences editMyCard:]):
Preferences.subproj/BookmarkPreferences.m: (-[BookmarkPreferences configureSynchronizing:]):
Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaScriptCanOpenWindows:]):
RendezvousController.m: (-[RendezvousController reportErrorForServiceName:]):
TabBarView.m: (-[TabBarView initWithFrame:]):
main.m: (storeVersionInPreferences): Changed or removed words.

English.lproj/Localizable.strings: updated for these changes

3:29 PM Changeset in webkit [5502] by kocienda

5 edits
2 adds in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3481701>: Crashes before loading page/no error msg
(forums.pelicanparts.com) Works in IE and Netscape

This fix is really a workaround for this bug:

<rdar://problem/3484937>: Horribly malformed URL crashes when call
is made to CFURLCopyHostName

The fix is to avoid all usages of [NSURL host] by replacing all
such calls with a private URL method added to WebNSURLExtras.

I copied a number of URL methods from the private NSURL
extras file in Foundation to the WebKit URL extras file.

Misc.subproj/WebNSDataExtras.h: Added. Helper for new URL extras.
Misc.subproj/WebNSDataExtras.m: Ditto. (-[NSData _web_isCaseInsensitiveEqualToCString:]): New helper.
Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_hasQuestionMarkOnlyQueryString]): Added. (-[NSURL _web_schemeSeparatorWithoutColon]): Added. (-[NSURL _web_dataForURLComponentType:]): Added. (-[NSURL _web_schemeData]): Added. (-[NSURL _web_hostData]): Added. (-[NSURL _web_hostString]): Added.
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebView.m: (-[WebView userAgentForURL:]): Replace call to [NSURL host] with new extras _web_hostString method.

12:21 PM Changeset in webkit [5501] by vicki

3 edits in trunk

tree is open for Safari-115

12:13 PM Changeset in webkit [5500]

3 copies in tags/Safari-114

This commit was manufactured by cvs2svn to create tag 'Safari-114'.

12:13 PM Changeset in webkit [5499] by vicki

6 edits in trunk

Safari-114 stamp

12:05 PM Changeset in webkit [5498] by vicki

8 edits in trunk/WebKit

rolled out Darin's fixes for 3457162 and 3160035, since these changes broke plugins on macromedia.com and disney.go.com

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]):
WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresourceClient:]):
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient loadWithRequest:]): (-[WebMainResourceClient setDefersCallbacks:]):

11:38 AM Changeset in webkit [5497] by mjs

4 edits in trunk/WebCore

backed out changes unintentionally commited while the tree was closed

khtml/css/css_valueimpl.cpp:
khtml/css/css_valueimpl.h:
kwq/KWQKPartsBrowserInterface.mm:

11:29 AM Changeset in webkit [5496] by mjs

4 edits in trunk/WebCore

Reviewed by Ken.

fixed 3471925 - getting and setting cssText not implemented

khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::cssText): Implemented by gathering text of all properties, separated with semicolons. (CSSStyleDeclarationImpl::setCssText): Implemented by clearing all existing properties and invoking css parser. (CSSValueListImpl::cssText): Implemented. (FontValueImpl::cssText): Implemented. (ShadowValueImpl::cssText): Implemented. (CSSProperty::cssText): Implemented.
khtml/css/css_valueimpl.h: Declared new methods; made CSSValueImpl::cssText() pure virtual; removed CSSValueImpl::setCssText().

9:47 AM Changeset in webkit [5495] by darin

8 edits in trunk/WebKit

Reviewed by John.

fixes 3457162 -- selecting text during a page load that blows the text field away causes a crash
fixes 3160035 -- crash or hang if you hold down a button while "go to about:blank soon" test runs

The WebKit part of this fix is making setDefersCallbacks: work. It had succumbed to bit rot.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]): Set the defersCallbacks state from the WebView here so that clients don't have to do it.
WebView.subproj/WebDataSource.m: (-[WebDataSource _addSubresourceClient:]): Remove call to set the defersCallbacks state on the subresource client, because the above change obviates it. (the client/delegate terminology makes it confusing, but it's a subclass).

WebView.subproj/WebMainResourceClient.h: Added an _initialRequest field so we can defer the very first callback, which does not rely on NSURLConnection.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): Release the initial request. (-[WebMainResourceClient loadWithRequestNow:]): Moved the guts of loadWithRequest in here; to be used when the request is no longer deferred. Also removed the code to call setDefersCallbacks: on the connection, and assert that we are only called when callbacks are not deferred. Because the very first callback was not deferred, we would end up calling setDefersCallbacks:NO on the WebView, so nothing would be deferred. (-[WebMainResourceClient loadWithRequest:]): If callbacks are not deferred, then call the loadWithRequestNow: method, otherwise simply store the request in _initialRequest. (-[WebMainResourceClient setDefersCallbacks:]): If there is an _initialRequest and we are ceasing deferral of callbacks, then call the loadWithRequestNow: method.

9:30 AM Changeset in webkit [5494] by darin

3 edits in trunk/WebCore

Reviewed by John.

first half of fix for 3457162 -- selecting text during a page load that blows the text field away causes a crash

The WebCore part of this fix is to generalize the "defers loading" feature to all mouse clicks,
rather than just doing it for mouse clicks on the combo box.

kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Remove code to defer loading.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Put the code here instead.

9:12 AM Changeset in webkit [5493]

1 copy
327 deletes in branches/unlabeled-1.55.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.55.4'.

9:12 AM Changeset in webkit [5492] by sullivan

5 edits in trunk/WebCore

fixed <rdar://problem/3483585>: Option-tab in a text field inputs a character rather than tabbing to the next widget

Reviewed by Ken.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::handleKeyboardOptionTabInView): New method. If current event is option-tab or option-shift-tab, do keyboard navigation and return YES.

kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): Bail out if KWQKHTMLPart::handleKeyboardOptionTabInView returns YES.

kwq/KWQTextField.mm: (-[KWQTextField controlTextDidChange:]): Bail out if KWQKHTMLPart::handleKeyboardOptionTabInView returns YES.

12:09 AM Changeset in webkit [5491] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3472875 -- REGRESSION (109-110): insertion point does not blink in a nonempty textarea
fixed 3484002 -- disabling, then enabling a read-only <textarea> will make it editable

kwq/KWQTextArea.mm: (-[KWQTextArea setText:]): Call updateTextColor after setting the text. (-[KWQTextArea setEditable:]): Don't set the NSTextView editable property directly, because we don't want to make a disabled text view editable right away, but we need to later if it's enabled. (-[KWQTextArea isEditable]): Don't get the NSTextView editable property directly, because it can be appropriate to return YES even if the text view happens to be disabled. (-[KWQTextAreaTextView initWithFrame:textContainer:]): Initialize editableIfEnabled to YES. (-[KWQTextAreaTextView setEnabled:]): Don't set the editable state to true if editableIfEnabled is NO. The old code would make a read-only field editable if you changed it to be enabled. Also update the color of the text here. (-[KWQTextAreaTextView setEditableIfEnabled:]): Store the editableIfEnabled state in a field, and then alter the state of the editable flag to match if we're currently enabled. (-[KWQTextAreaTextView isEditableIfEnabled]): Return the editableIfEnabled state. (-[KWQTextAreaTextView updateTextColor]): Update the color of the text. This was done in drawRect: before, which was the cause of the lack of insertion point.

Nov 13, 2003:

10:15 PM Changeset in webkit [5490] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3474330 -- tooltips do not work for <area> elements

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): When looking for a title, start with innerNode (which can be an <area> inside a <map>). This matches what Mozilla does.

9:05 PM Changeset in webkit [5489] by mjs

2 edits in trunk/WebCore

Reviewed by John.

fixed - 3479285 - hang at www.saccourt.com
fixed - 3477088 - (85-112) Safari frozen loading a page at Postal Service site of Taiwan

khtml/ecma/kjs_html.cpp: (KJS::HTMLSelectCollection::tryPut): Use the range-checking version of the number-conversion function to avoid negative numbers and NaN.

6:29 PM Changeset in webkit [5488]

1 copy in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore/bindings

This commit was manufactured by cvs2svn to create branch
'Safari-1-1-Merlot-BuildFixes-branch'.

6:29 PM Changeset in webkit [5487]

15 copies in tags/Safari-1-1-Merlot-BuildFixes-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-1-Merlot-BuildFixes-anchor'.

6:29 PM Changeset in webkit [5486] by rjw

3 edits in trunk/JavaScriptCore

Factored common code between copy constructor and assignment operator.

Reviewed by Chris.

ChangeLog:
bindings/jni/jni_runtime.h: (Bindings::JavaConstructor::_commonCopy): (Bindings::JavaConstructor::JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaField::type):
bindings/runtime.h:

6:17 PM Changeset in webkit [5485] by rjw

5 edits
3 adds
3 deletes in trunk/JavaScriptCore

JavaScriptCore:

More LiveConnect stuff. This checkin adds abstract classes to model
language runtimes and a JNI based set of concrete implementations for
Java.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/Makefile.am: Removed.
bindings/jni/Makefile.am: Removed.
bindings/jni/jni_runtime.cpp: Added. (JavaField::JavaField): (JavaConstructor::JavaConstructor): (JavaMethod::JavaMethod): (JavaClass::JavaClass):
bindings/jni/jni_runtime.h: Added. (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=): (Bindings::JavaString::characters): (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::~JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::type): (Bindings::JavaConstructor::JavaConstructor): (Bindings::JavaConstructor::~JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaConstructor::parameterAt): (Bindings::JavaConstructor::numParameters): (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=): (Bindings::JavaField::name): (Bindings::JavaField::type): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::~JavaMethod): (Bindings::JavaMethod::_commonCopy): (Bindings::JavaMethod::operator=): (Bindings::JavaMethod::name): (Bindings::JavaMethod::returnType): (Bindings::JavaMethod::parameterAt): (Bindings::JavaMethod::numParameters): (Bindings::JavaClass::_commonDelete): (Bindings::JavaClass::~JavaClass): (Bindings::JavaClass::_commonCopy): (Bindings::JavaClass::JavaClass): (Bindings::JavaClass::operator=): (Bindings::JavaClass::name): (Bindings::JavaClass::methodAt): (Bindings::JavaClass::numMethods): (Bindings::JavaClass::constructorAt): (Bindings::JavaClass::numConstructors): (Bindings::JavaClass::fieldAt): (Bindings::JavaClass::numFields):
bindings/jni/jni_utility.cpp: (callJNIMethod): (callJNIMethodA): (callJNIObjectMethod): (callJNIByteMethod): (callJNICharMethod): (callJNIShortMethod): (callJNIIntMethod): (callJNILongMethod): (callJNIFloatMethod): (callJNIDoubleMethod): (callJNIVoidMethodA): (callJNIObjectMethodA): (callJNIByteMethodA): (callJNICharMethodA): (callJNIShortMethodA): (callJNIIntMethodA): (callJNILongMethodA): (callJNIFloatMethodA): (callJNIDoubleMethodA): (getCharactersFromJString): (releaseCharactersForJString):
bindings/jni/jni_utility.h:
bindings/objc/Makefile.am: Removed.
bindings/runtime.h: Added. (Bindings::Parameter::~Parameter): (Bindings::Constructor::~Constructor): (Bindings::Field::~Field): (Bindings::Method::~Method): (Bindings::Class::~Class):

Tests:

More tweaks to test new LiveConnect stuff.

DumpJava/main.cpp: (dumpClass):

4:34 PM Changeset in webkit [5484]

1 copy
327 deletes in branches/unlabeled-1.21.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.21.4'.

4:34 PM Changeset in webkit [5483] by kocienda

10 edits in trunk

WebCore:

Reviewed by John

Fix for this bug:

<rdar://problem/3483284>: Tabbing to links needs to honor new
WebKit tab-to-links preference

In addition to fixing the bug, I also did a bit of cleanup
in the code which helps to determine tab order.

Biggest change is to modify the keyboard UI mode function so
that it is a set of flags, rather than a straight-up value.

I also tweaked the names on the keyboard UI mode constants
to make them read better.

kwq/KWQButton.mm: (QButton::focusPolicy): Tweaks to make more readable and use new model for keyboard UI mode.
kwq/KWQComboBox.mm: (QComboBox::focusPolicy): Ditto. Plus, this function was not blocking exceptions.
kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy): Tweaks to make more readable and use new model for keyboard UI mode.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now checks new tabsToLinks function to determine if links can be tabbed to. (KWQKHTMLPart::currentEventIsKeyboardOptionTab): New function checks for option-tab keyboard event. (KWQKHTMLPart::tabsToLinks): New helper to take keyboard UI mode and option-tab into account. (KWQKHTMLPart::keyboardUIMode): Name tweak.
kwq/KWQListBox.mm: Tweaks to make more readable and use new model for keyboard UI mode. (QListBox::focusPolicy):
kwq/WebCoreKeyboardAccess.h: Tweaked names. Added WebCoreKeyboardAccessTabsToLinks.

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3483284>: Tabbing to links needs to honor new
WebKit tab-to-links preference

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): Remove self from notification center. (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Now checks for WebCoreKeyboardAccessTabsToLinks preference. (-[WebBridge keyboardUIMode]): Adds self to notification center to pick up changes to WebPreferences.

4:15 PM Changeset in webkit [5482] by vicki

2 edits in branches/SUPanBisque-branch/WebCore

roll the KWQKHTMLPart.mm change from this fix onto the branch; this is the WebCore part of the fix for 3375281

2003-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ken.

fixed 3375281 - Keyboard event handlers not fired if focus not in form field
fixed 3242927 - KeyPressed Event in Javascript don't work
fixed 3375353 - keyboard event.target not updated when blurring from form items
fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchKeyEvent): Force false when defaultHandled instead of based on a weird rule appropriate for KDE but not for us.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): If there's no focus node, give the event to the body element instead of giving up. Also, reverse expectedsense of return value dispatchKeyEvent, since it returns true if it *didn't* swallow the event. And finally, let the key press event as well as the key down event for the initial NSKeyDown block default handling.
kwq/KWQListBox.mm: (-[KWQTableView keyDown:]): Respect return value from interceptKeyEvent: (-[KWQTableView keyUp:]): ditto
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyDown:]): ditto (-[KWQTextAreaTextView keyUp:]): ditto
kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): ditto

4:06 PM Changeset in webkit [5481] by vicki

2 edits in branches/SUPanBisque-branch/WebKit

roll the WebHTMLView.m change from this fix onto the branch; this is the WebKit part of the fix for 3375281

2003-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ken.

fixed 3375281 - Keyboard event handlers not fired if focus not in form field
fixed 3242927 - KeyPressed Event in Javascript don't work
fixed 3375353 - keyboard event.target not updated when blurring from form items
fixed 3183754 - returning false from key press handlers does not prevent typing or form submission

WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Ask the bridge before passing the event along. (-[WebHTMLView keyUp:]): Likewise.
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m: Remove dead code.

2:53 PM Changeset in webkit [5480] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by John.

fixed 3472562 - Null or Undefined variables passed to IN operator cause javascript exceptions

kjs/nodes.cpp: (ForInNode::execute): If the in value is null or undefined, bail out early, since attempting to iterate its properties will throw an exception.

1:37 PM Changeset in webkit [5479] by kocienda

3 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3481719>: WebKit needs preference for tabbing to links

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Add initialization of new WebKitTabToLinksPreferenceKey. (-[WebPreferences setTabsToLinks:]): Added preference setter. (-[WebPreferences tabsToLinks]): Added preference getter.
WebView.subproj/WebPreferencesPrivate.h: Declared new methods as SPI on WebPreferences.

12:13 PM Changeset in webkit [5478] by hyatt

10 edits in trunk/WebCore

Implement a custom unfurl marquee style.

Reviewed by john

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/rendering/render_box.cpp: (RenderBox::calcHeight):
khtml/rendering/render_layer.cpp: (m_direction): (Marquee::isUnfurlMarquee): (Marquee::start): (Marquee::updateMarqueePosition): (Marquee::updateMarqueeStyle): (Marquee::timerEvent):
khtml/rendering/render_layer.h: (khtml::):
khtml/rendering/render_style.h: (khtml::):

11:42 AM Changeset in webkit [5477] by kocienda

8 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3480761>: event object type attribute returns
khtml_keypress instead of keypress

Fixed string so that it returns keypress instead of khtml_keypress.
While I was at it, I changed the constant used for this event from
KHTML_KEYPRESS_EVENT to KEYPRESS_EVENT.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture): Constant name fixup.
khtml/ecma/kjs_dom.cpp: Ditto. (DOMNode::getValueProperty): Ditto. (DOMNode::putValue): Ditto.
khtml/ecma/kjs_window.cpp: (Window::get): Ditto. (Window::put): Ditto.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): Ditto.
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Ditto. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::idToType): This is the change that fixes the bug. (KeyboardEventImpl::KeyboardEventImpl): Constant name fixup.
khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::): Ditto.

9:39 AM Changeset in webkit [5476] by darin

7 edits in trunk/WebCore

Reviewed by Ken.

fixed 3452554 -- keyCode attribute for DOM events reports incorrect value

khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Return the Windows key code for keydown and keyup events. But for other events, return the character code. This matches IE. (UIEvent::which): Same behavior for now; may need further refinement.

kwq/KWQEvent.h: Change QEvent to allow copying. The Qt version probably doesn't allow it, but for us it's no big deal. Our event objects are just data holders. (QKeyEvent::QKeyEvent): Change parameters; take an NSEvent and figure the rest out here. Except for now get the type, button state, and auto repeat flag from the caller because that's a smaller change from how things are done now. I'll take this the next step later.
kwq/KWQEvent.mm: (characterCode): Added. Extracts the character code from the string if it's exactly 1 character long. (WindowsKeyCode): Added. Given an event, figures out the Windows key code. (QKeyEvent::QKeyEvent): Changed to get things from the NSEvent rather than having them passed individually. One change is that _ascii is now the Unicode value of the first character in the string. This causes us to return the Unicode value from keyCode for keypress events. Another change is that we now compute the Windows key code.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Change to use the new QKeyEvent constructor, passing in the NSEvent.

khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): In APPLE_CHANGES, copy the QKeyEvent using the copy constructor rather than listing the fields. This is easier to maintain when the list of fields changes.

khtml/rendering/render_form.cpp: (ComboBoxWidget::eventFilter): Put #if !APPLE_CHANGES around code that constructs a QKeyEvent. We don't ever run this code, but now we can't compile it either so we need the #if.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed