Context Navigation

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Call appropriate methods for status and statusText. (KJS::XMLHttpRequest::send): Set request headers as "customHeaders" metadata property. (KJS::XMLHttpRequest::setRequestHeader): Simply append to header string. (KJS::XMLHttpRequest::getAllResponseHeaders): Return the header string except for the first line. (KJS::XMLHttpRequest::getResponseHeader): Scan the response header string for the header field. Not sure if it's worth being more efficient. (KJS::XMLHttpRequest::getStatus): Try to pull a code out of the status line. (KJS::XMLHttpRequest::getStatusText): Pull the first line off the headers (if any), otherwise return undefined. (KJS::XMLHttpRequest::slotData): The first time through, save the response headers, retrieved from "HTTP-Headers" metadata property. (KJS::XMLHttpRequestProtoFunc::tryCall): Make setRequestHeader, getResponseHeader, getAllResponseHeaders call the right thing.
khtml/ecma/xmlhttprequest.h:
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Added header support. (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::assembleResponseHeaders): Get a header string out of the response if needed. (KIO::TransferJob::queryMetaData): Special-case "HTTP-Headers". (KIO::TransferJob::emitReceivedResponse): Save response.
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (-[NSDictionary _webcore_initWithHeaderString:]): Helper method to turn a string of header fields into a dictionary. (KWQServeRequest): Pass custom headers through. (KWQResponseMIMEType): Admit it's an NSURLResponse *. (KWQResponseHeaderString): Assembled status code and response header fields into response header. Cheat a little on the status line.
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): Admit it's an NSURLResponse *.
kwq/WebCoreResourceLoader.h: Ditto.
kwq/WebCoreBridge.h: Add customHeader: arguments.

WebKit:

Reviewed by Ken.

WebKit part of fix for:

<rdar://problem/3487134>: Implement http request/response status and headers for XMLHttpRequest

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:]): Added customHeaders parameter. (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto.
WebCoreSupport.subproj/WebSubresourceClient.h:
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Add the custom headers. (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:referrer:forDataSource:]): Pass along the custom headers. (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Pass along the custom headers.

11:14 AM Changeset in webkit [5624] by cblu

7 edits in trunk/WebCore

Fixed: <rdar://problem/3491907>: When viewing applet, view hierarchy was an empty KWQView

Reviewed by rjw.

WebCore.pbproj/project.pbxproj:
khtml/html/html_objectimpl.cpp: removed setupApplet because that work is done when the applet widget is created (HTMLAppletElementImpl::createRenderer): pass the PARAM args to the render object (HTMLAppletElementImpl::getAppletInstance): don't call setupApplet
khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): store args and context, don't call setQWidget here (RenderApplet::setStyle): call setQWidget here (RenderApplet::layout): don't parse args here, that is done in HTMLAppletElementImpl::createRenderer
khtml/rendering/render_applet.h:
kwq/KWQKJavaAppletWidget.h: (KJavaApplet::KJavaApplet): turned into a stub, this work is no longer needed (KJavaApplet::setAppletClass): ditto (KJavaApplet::setAppletName): ditto (KJavaApplet::setArchives): ditto (KJavaApplet::setBaseURL): ditto (KJavaApplet::setCodeBase): ditto (KJavaApplet::setParameter): ditto (KJavaAppletWidget::~KJavaAppletWidget): ditto (KJavaAppletWidget::applet): ditto (KJavaAppletWidget::setBaseURL): ditto (KJavaAppletWidget::setParameter): ditto (KJavaAppletWidget::showApplet): ditto
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): create the java here instead of doing it later

10:16 AM Changeset in webkit [5623]

1 copy
330 deletes in branches/unlabeled-1.440.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.440.4'.

10:16 AM Changeset in webkit [5622]

1 copy
330 deletes in branches/unlabeled-1.137.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.137.4'.

10:16 AM Changeset in webkit [5621] by sullivan

7 edits in trunk

WebCore:

WebCore part of fix for <rdar://problem/3333744>: Safari prints page with very, very long line very, very small

Reviewed by Ken.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutWithPageWidthRange): Changed method name from forceLayoutForPageWidth; now takes min and max page width values. Use max page width value to limit how wide page will get when there's a very long line.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): changed pageWidth parameter into min and max parameters; pass them along to KWQKHTMLPart.

WebKit:

WebKit part of fix for <rdar://problem/3333744>: Safari prints page with very, very long line very, very small

Reviewed by Ken.

WebView.subproj/WebHTMLView.m: renamed PrintingExtraWidthFactor to PrintingMinimumShrinkFactor, added PrintingMaximumShrinkFactor of 2.0, which matches IE (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): now takes a min and max page width; passes them along to bridge (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): now takes a min and max page width; passes them along to layoutTo... (-[WebHTMLView _scaleFactorForPrintOperation:]): now takes PrintingMaximumScaleFactor into account (-[WebHTMLView knowsPageRange:]): now takes PrintingMaximumScaleFactor into account

(-[WebHTMLView layout]):
pass 0 for maximumPageWidth when passing 0 for minimumPageWidth
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
ditto
(-[WebHTMLView _web_setPrintingModeRecursive]):
ditto
(-[WebHTMLView _web_clearPrintingModeRecursive]):
ditto
(-[WebHTMLView endDocument]):
ditto

9:29 AM Changeset in webkit [5620] by darin

3 edits in trunk/WebCore

Reviewed by Ken.

fixed 3490260: allow &sup1 to be misspelled &supl (lowercase l instead of numeral 1) because WinIE does

khtml/html/kentities.gperf: Added supl to the list. Maps to U+00B9, just as sup1 does.
khtml/html/kentities.c: Regenerated.

12:54 AM Changeset in webkit [5619] by mjs

2 edits in trunk/JavaScriptCore

Patch from Harri Porten, reviewed by me.

fixed 3491712 - String slice with negative arguments does not offset from end of string

kjs/string_object.cpp: (StringProtoFuncImp::call): Handle negative arguments as offsets from end by adding length and clamping to [0,length-1].

12:49 AM Changeset in webkit [5618] by mjs

2 edits in trunk/JavaScriptCore

Patch from Harri Porten, reviewed by me.

fixed 3491709 - using Function.apply with a primitive type as the arg list causes crash

kjs/function_object.cpp: (FunctionProtoFuncImp::call): Nest parentheses properly.

Nov 20, 2003:

10:53 PM Changeset in webkit [5617] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

fixed 3487201 - Implement abort for XMLHttpRequest async loads

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::abort): Kill and clear job. (KJS::XMLHttpRequest::slotData): Avoid moving to state 3 on early abort. (KJS::XMLHttpRequestProtoFunc::tryCall): Call abort when appropriate.
khtml/ecma/xmlhttprequest.h:

7:13 PM Changeset in webkit [5616] by rjw

12 edits in trunk/JavaScriptCore

JavaScriptCore:

More LiveConnect stuff. Primitive Java fields are now
accessible from JavaScript! Yay!

Reviewed by Maciej.

bindings/jni/jni_class.cpp: (JavaClass::methodNamed): (JavaClass::fieldNamed):
bindings/jni/jni_class.h: (Bindings::JavaClass::_commonDelete):
bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::~JavaInstance): (JavaInstance::getClass):
bindings/jni/jni_instance.h: (Bindings::JavaInstance::javaInstance):
bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaField::valueFromInstance):
bindings/jni/jni_runtime.h: (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=):
bindings/jni/jni_utility.cpp: (callJNIMethod): (callJNIMethodA): (callJNIVoidMethod): (callJNIObjectMethod): (callJNIBooleanMethod): (callJNIByteMethod): (callJNICharMethod): (callJNIShortMethod): (callJNIIntMethod): (callJNILongMethod): (callJNIFloatMethod): (callJNIDoubleMethod): (callJNIVoidMethodA): (callJNIObjectMethodA): (callJNIByteMethodA): (callJNICharMethodA): (callJNIShortMethodA): (callJNIIntMethodA): (callJNILongMethodA): (callJNIFloatMethodA): (callJNIDoubleMethodA): (releaseCharactersForJStringInEnv): (primitiveTypeFromClassName): (getJNIField):
bindings/jni/jni_utility.h:
bindings/runtime.cpp: (Instance::createBindingForLanguageInstance): (Instance::getValueOfField):
bindings/runtime.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::get):

6:02 PM Changeset in webkit [5615]

10 copies
3 deletes in tags/WebKit-106~2

This commit was manufactured by cvs2svn to create tag 'WebKit-106~2'.

6:02 PM Changeset in webkit [5614]

29 copies
2 deletes in tags/WebCore-106~2

This commit was manufactured by cvs2svn to create tag
'WebCore-106~2'.

6:02 PM Changeset in webkit [5613] by vicki

4 edits in branches/SUPanBisque-branch

106.2 stamp in WebCore and WebKit for SUPanBisque

6:01 PM Changeset in webkit [5612]

1 copy
115 deletes in branches/unlabeled-1.15.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.15.4'.

6:01 PM Changeset in webkit [5611] by sullivan

10 edits in trunk

WebCore:

WebCore part of <rdar://problem/3183124>: Support page-break-before/after with a value of "always"

Dave wrote this part and we reviewed it together.

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): if printing, check for CSS page break locations (khtml::RenderBlock::inRootBlockContext): new method, used to check whether we're in a context for which CSS page breaks are legal.

khtml/rendering/render_block.h: prototype for inRootBlockContext; this might be useful for other code later.

khtml/rendering/render_canvas.cpp: (RenderCanvas::setBestTruncatedAt): now takes a forcedBreak parameter which overrides others.

khtml/rendering/render_canvas.h: (khtml::RenderCanvas::setTruncatedAt): set default value for m_forcedPageBreak

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRects:withPageHeight:]): do the real work of pagination here

WebKit:

WebKit part of <rdar://problem/3183124>: Support page-break-before/after with a value of "always"

Dave and I wrote and reviewed this.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]): reset page rects when printing status changes (-[WebHTMLView _availablePaperWidthForPrintOperation:]): new helper method to compute paper width taking margins into account (-[WebHTMLView _scaleFactorForPrintOperation:]): new helper method to compute how much we need to shrink to fit one page across (-[WebHTMLView _provideTotalScaleFactorForPrintOperation:]): we overrode this secret internal AppKit method to make shrink-to-fit work; we wrote bug 3491344 about the need for this to be public. (-[WebHTMLView knowsPageRange:]): new method, computes rects and returns YES (-[WebHTMLView rectForPage:]): new method, returns rect computed above (-[WebHTMLView _calculatePrintHeight]): new method, used by knowsPageRange

WebView.subproj/WebHTMLViewPrivate.h: new pageRects ivar

4:54 PM Changeset in webkit [5610] by mjs

1 edit in trunk/WebKit/ChangeLog

Corrected ChangeLog comment.

4:53 PM Changeset in webkit [5609] by mjs

6 edits in trunk/WebKit

Reviewed by Darin.

fixed 3487201 - Implement abort for XMLHttpRequest async loads

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:postData:]):
WebCoreSupport.subproj/WebSubresourceClient.h:
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:referrer:forDataSource:]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (+[WebSubresourceClient startLoadingResource:withURL:postData:referrer:forDataSource:]):

4:41 PM Changeset in webkit [5608] by vicki

5 edits in branches/SUPanBisque-branch/WebKit

roll these fixes onto the branch to add tooltip support in SUPanBisque (rdar://problem/3490331)

2003-09-22 Darin Adler <Darin Adler>

Reviewed by Dave.

worked around 3429631 -- window stops getting mouse moved events after first tooltip appears

WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]): Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

2003-09-22 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3431033 -- crash in -[NSToolTipManager _shouldInstallToolTip:]

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Override this alternate version of addTrackingRect. If I don't do this, we might create a real tracking rect, which we would then never remove. (-[WebHTMLView removeTrackingRect:]): Added assertions.

2003-09-21 Darin Adler <Darin Adler>

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView removeTrackingRect:]): Remove bogus assert.

2003-09-21 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

WebView.subproj/WebHTMLViewPrivate.h: Added fields needed for tool tip implementation.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the tool tip string. (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): Override the default NSView tracking rectangle implementation so we can trick the tool tip manager into trusting us about when you leave and enter the rectangle for each element. (-[WebHTMLView removeTrackingRect:]): The other half of the above stuff. (-[WebHTMLView _sendToolTipMouseExited]): Added. Makes an event just good enough to fool the tool tip manager, and send it on. (-[WebHTMLView _sendToolTipMouseEntered]): Ditto. (-[WebHTMLView _setToolTip:]): Added. Manages the new and old tool tips in a way that fools the tool tip manager into working even though we don't know the rectangles of the tool tips beforehand. The advantage of using AppKit tool tips is that they have all sorts of nice little features, like wrapping to a nice rectangular shape and fading out when you move away. (-[WebHTMLView view:stringForToolTip:point:userData:]): This is how the tool tip manager gets the actual tool tip text. (-[WebHTMLView _updateMouseoverWithEvent:]): Call _setToolTip method, using the value passed along with the WebCoreElementTitleKey in the dictionary.

unrelated code cleanup

WebView.subproj/WebFramePrivate.h: Don't define WebCorePageCacheStateKey here; instead use a definition exported from WebCore.
WebView.subproj/WebFramePrivate.m: Ditto.
English.lproj/StringsNotToBeLocalized.txt: Update for above changes.

WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebHTMLViewPrivate.h:
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): (-[WebHTMLView removeTrackingRect:]): (-[WebHTMLView _sendToolTipMouseExited]): (-[WebHTMLView _sendToolTipMouseEntered]): (-[WebHTMLView _setToolTip:]): (-[WebHTMLView view:stringForToolTip:point:userData:]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): (-[NSToolTipPanel setAcceptsMouseMovedEvents:]):

4:36 PM Changeset in webkit [5607] by vicki

5 edits in branches/SUPanBisque-branch/WebCore

roll these fixes onto the branch to add tooltip support in SUPanBisque (rdar://problem/3490331)

2003-11-13 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3474330 -- tooltips do not work for <area> elements

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): When looking for a title, start with innerNode (which can be an <area> inside a <map>). This matches what Mozilla does.

2003-09-21 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Set the value of a new element dictionary key, WebCoreElementTitleKey. This gives the title for an element, walking up the DOM tree as necessary to find it. It's used for tool tips at the WebKit level.
kwq/WebCoreBridge.h: Added WebCoreElementTitleKey and WebCorePageCacheStateKey.

WebCore.exp: Added all the constants from WebCoreBridge.h; these should be exported even though they are not being used at the moment because the "WebCore and WebKit use the same constant keys" hack we are doing at the WebKit level means we can just use the WebKit keys on the WebKit side.
WebCore-combined.exp: Regenerated.

WebCore-combined.exp:
WebCore.exp:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

3:05 PM Changeset in webkit [5606]

1 copy
561 deletes in branches/unlabeled-1.6.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.6.4'.

3:05 PM Changeset in webkit [5605]

1 copy
76 deletes in branches/unlabeled-1.19.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.19.4'.

3:05 PM Changeset in webkit [5604]

1 copy
382 deletes in branches/unlabeled-1.1.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.1.4'.

3:05 PM Changeset in webkit [5603] by cblu

9 edits
5 adds in trunk

WebCore:

Fixed: <rdar://problem/3491225>: Need UI and localized strings for <KEYGEN> support

Reviewed by john.

WebCore-combined.exp:
WebCore.exp:
WebCore.pbproj/project.pbxproj:
kwq/KWQKSSLKeyGen.h:
kwq/KWQKSSLKeyGen.mm: Added. (KSSLKeyGen::supportedKeySizes): implemented, calls [WebCoreLocalizedStringFactory keyGenerationMenuItemTitles]
kwq/WebCoreLocalizedStringFactory.h: Added.
kwq/WebCoreLocalizedStringFactory.m: Added. (+[WebCoreLocalizedStringFactory sharedFactory]): new (-[WebCoreLocalizedStringFactory init]): new (-[WebCoreLocalizedStringFactory keyGenerationMenuItemTitles]): new

WebKit:

Fixed: <rdar://problem/3491229>: Need UI and localized strings for <KEYGEN> support

Reviewed by john.

ChangeLog:
English.lproj/Localizable.strings:
WebCoreSupport.subproj/WebLocalizedStringFactory.h: Added.
WebCoreSupport.subproj/WebLocalizedStringFactory.m: Added. (+[WebLocalizedStringFactory createSharedFactory]): new (-[WebLocalizedStringFactory dealloc]): new (-[WebLocalizedStringFactory keyGenerationMenuItemTitles]): new
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebFrameView.m: call [WebLocalizedStringFactory createSharedFactory]

2:45 PM Changeset in webkit [5602] by mjs

6 edits in trunk/WebCore

Reviewed by Ken.

fixed 3490086 - support http post for XMLHttpRequest

kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJob::TransferJob):

2:00 PM Changeset in webkit [5601] by rjw

19 edits in trunk

WebKit:

Added spin of event loop during applet lookup poll. This
is necessary to allow timers and performOnMainThread: methods
a chance to fire. The plugin depends on these mechanisms during
initialization.

Reviewed by Chris.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pollForAppletInView:]):

WebCore:

Cleaned up synchronous applet lookup and initialization.
We need to further cleanup applet instantiation. It doesn't
need to be lazy with my modified Java Plugin.

Reviewed by Chris.

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet):
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::setupApplet): (HTMLAppletElementImpl::getAppletInstance):
khtml/html/html_objectimpl.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView):
kwq/KWQKJavaAppletWidget.h:
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):

JavaScriptCore:

More LiveConnect stuff.

Reviewed by Chris.

bindings/jni/jni_class.cpp: (JavaClass::classForName): (JavaClass::classForInstance):
bindings/jni/jni_instance.cpp: (JavaInstance::getValueOfField):
bindings/jni/jni_instance.h: (Bindings::JObjectWrapper::JObjectWrapper):
bindings/jni/jni_runtime.h: (Bindings::JavaConstructor::~JavaConstructor): (Bindings::JavaConstructor::operator=): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::signature):
bindings/jni/jni_utility.cpp: (getJNIEnv): (attachToJavaVM):
bindings/jni/jni_utility.h:
bindings/runtime.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::get):
bindings/runtime_object.h:

1:56 PM Changeset in webkit [5600] by kocienda

4 edits in trunk/WebKit

Reviewed by me

John and I decided to apply the _web_ prefix to the tab key
event method in the extras file, but I neglected to do this
before checking in. Fixed now.

Misc.subproj/WebNSEventExtras.h:
Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isTabKeyEvent])
WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:])

1:01 PM Changeset in webkit [5599]

1 copy
327 deletes in branches/unlabeled-1.102.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.102.4'.

1:01 PM Changeset in webkit [5598] by kocienda

3 edits in trunk/WebCore

Reviewed by David

Fix for this bug:

<rdar://problem/3487421>: crash/exception when tabbing to a link without text

khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): A link is also not focusable if it has zero width or height, if it has no children, or if it is is not a continuation.
kwq/KWQPainter.mm: (QPainter::drawFocusRing): Put in a guard against trying to draw a focus ring with no control points. Log this as an error.

12:59 PM Changeset in webkit [5597] by kocienda

3 edits
2 adds in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3482159>: Tabbing to links gets "stuck" in "style switcher" on zeldman.com

Misc.subproj/WebNSEventExtras.h: Added.
Misc.subproj/WebNSEventExtras.m: Added. (-[NSEvent _isTabKeyEvent]): New helper.
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView keyDown:]): Pass the key event to super unconditionally if it is a tab key. This fixes the bug.

Nov 19, 2003:

8:28 PM Changeset in webkit [5596] by hyatt

2 edits in trunk/WebCore

Fix for 3486963, crash because generated content was referencing a deleted object. Fix is to update the
variable to a sane value after deleting old generated content.

Reviewed by darin

khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):

7:57 PM Changeset in webkit [5595] by sullivan

2 edits in trunk/WebKit

WebKit:

WebKit part of fix for: <rdar://problem/3305671>: Web pages print with 1.25" border without regard to Page Setup margin settings

Reviewed by Dave.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Lay out the page into a width 25% wider than there's room for on the printed page. This will make pages that can fit into a thin area be scaled down a little when printed, which lets them fit on fewer pages. This closely matches what IE and Camino (at least) do; I used Google as my test page, and the Google logo is now precisely the same size when printed from Safari as when printed from IE. Pages that don't fit into a thin area are already causing the printed page to be scaled horizontally to fit, and this won't affect them.

WebBrowser:

WebBrowser part of fix for: <rdar://problem/3305671>: Web pages print with 1.25" border without regard to Page Setup margin settings

Reviewed by Dave.

BrowserDocument.m: (-[BrowserDocument printInfo]): Use the entire imageable area of the page (except max out at the paper size). This matches what IE does; you can tell by formatting for different printers in Page Setup and checking the printed margins against the margins reported in the Settings:Summary part of Page Setup.

With this change and the accompanying WebKit change to initially lay out into
an area 25% wider than fits on the page, and Hyatt's earlier change to re-layout
to the width of the widest element on the page, our printed pages are much, much
closer to how other browsers print. We are now no more different from other
browsers than they are from each other, at least for non-edge case pages.

4:46 PM Changeset in webkit [5594] by mjs

8 edits in trunk/WebCore

Reviewed by John.

fixed 3486998 - Implement asynchronous http loading for XMLHttpRequest

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestQObject::XMLHttpRequestQObject): New QObject to use to connect to signals. (KJS::XMLHttpRequestQObject::slotData): Call XMLHttpRequest. (KJS::XMLHttpRequestQObject::slotFinished): Ditto. (KJS::XMLHttpRequestQObject::slotRedirection): Ditto. (KJS::XMLHttpRequest::getValueProperty): Implemented, onrequeststatechange, readyState and responseText. (KJS::XMLHttpRequest::putValue): Implemented onrequeststatechange. (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new fields. (KJS::XMLHttpRequest::~XMLHttpRequest): Delete decoder. (KJS::XMLHttpRequest::changeState): Update state, and send event if needed. (KJS::XMLHttpRequest::open): Save the parameters. (KJS::XMLHttpRequest::send): Fire up a post or get job. (KJS::XMLHttpRequest::slotFinished): go to final state. (KJS::XMLHttpRequest::slotRedirection): Just stub for now. (KJS::XMLHttpRequest::slotData): Update state; decode & save data. (KJS::XMLHttpRequestProtoFunc::tryCall): Implemented open and send.
khtml/ecma/xmlhttprequest.h: Prototyped new stuff.
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Added "readystatechange" event. (EventImpl::idToType): Ditto.
khtml/xml/dom2_eventsimpl.h: Ditto.
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQServeRequest): New variant that doesn't need a Request.
kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Handle XMLHttpRequestQObject's slots. (KWQSlot::call): Ditto.

3:45 PM Changeset in webkit [5593] by cblu

4 edits in trunk/WebKit

Fixed: <rdar://problem/3489935>: Mentioning "to Disk" in context menus such as "Download Linked File To Disk..." is redundant

Reviewed by john.

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): use "Download Linked File" and "Download Image"

2:41 PM Changeset in webkit [5592] by rjw

14 edits
4 adds in trunk

Forget to check these in earlier.

2:25 PM Changeset in webkit [5591] by cblu

4 edits in trunk/WebKit

Fixed: <rdar://problem/3488783>: Flash at http://www.sjwilson.net/reef/ does not load photos

Reviewed by rjw.

Misc.subproj/WebKitNSStringExtras.h:
Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_stringByStrippingReturnCharacters]): new
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): call _web_stringByStrippingReturnCharacters on the relative string

2:21 PM Changeset in webkit [5590] by rjw

3 edits in trunk/WebKit

WebKit:

More LiveConnect stuff. Horrible polling hack that
blocks main thread waiting for applet to fully initialize.

Reviewed by Ken.

Plugins.subproj/WebPluginController.m: (-[WebPluginController addPlugin:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pollForAppletInView:]):

WebCore:

More LiveConnect stuff. With that patch we make the applet
visible to JavaScript in an Bindings::Instance. Next step
it to flush out implementation of RuntimeObjectImp and
RuntimeFunctionImp.

Reviewed by Ken.

khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::HTMLAppletElementImpl): (HTMLAppletElementImpl::~HTMLAppletElementImpl): (HTMLAppletElementImpl::getAppletInstance):
khtml/html/html_objectimpl.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView):
kwq/WebCoreBridge.h:

JavaScript:

More LiveConnect stuff.

Reviewed by Ken.

JavaScriptCore.pbproj/project.pbxproj:
bindings/jni/jni_class.cpp: Added. (JavaClass::_commonInit): (JavaClass::JavaClass): (_createClassesByNameIfNecessary): (JavaClass::classForName): (JavaClass::classForInstance): (JavaClass::methodNamed): (JavaClass::fieldNamed):
bindings/jni/jni_class.h: Added. (Bindings::JavaClass::_commonDelete): (Bindings::JavaClass::~JavaClass): (Bindings::JavaClass::_commonCopy): (Bindings::JavaClass::JavaClass): (Bindings::JavaClass::operator=): (Bindings::JavaClass::name): (Bindings::JavaClass::constructorAt): (Bindings::JavaClass::numConstructors):
bindings/jni/jni_instance.cpp: Added. (JavaInstance::JavaInstance): (JavaInstance::~JavaInstance):
bindings/jni/jni_instance.h: Added. (Bindings::JObjectWrapper::JObjectWrapper): (Bindings::JObjectWrapper::~JObjectWrapper): (Bindings::JObjectWrapper::ref): (Bindings::JObjectWrapper::deref): (Bindings::JavaInstance::getClass): (Bindings::JavaInstance::operator=):
bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod):
bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=):
bindings/jni/jni_utility.cpp: (getJavaVM): (getJNIEnv): (getCharactersFromJString): (releaseCharactersForJString): (getCharactersFromJStringInEnv): (releaseCharactersForJStringInEnv):
bindings/jni/jni_utility.h:
bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
bindings/runtime.h: (Bindings::Instance::):

12:36 PM Changeset in webkit [5589]

1 copy
129 deletes in branches/unlabeled-1.49.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.49.4'.

12:36 PM Changeset in webkit [5588]

1 copy
430 deletes in branches/unlabeled-1.18.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.18.4'.

12:36 PM Changeset in webkit [5587] by hyatt

6 edits in trunk/WebCore

Fix for 3488888, about:blank in iframes doesn't repaint properly. Fix for 3485478, refreshing a remote
page often causes a white flash. Fix for 3488827, XML/XHTML documents don't fire load events on bodies/framesets.

Reviewed by darin

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLDocumentImpl):
khtml/html/html_documentimpl.h:
khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas): (RenderCanvas::layout):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::body): (DocumentImpl::close):
khtml/xml/dom_docimpl.h:

12:30 PM Changeset in webkit [5586] by hyatt

3 edits in trunk/WebKit

Make updateScrollers guard non-static, so that it applies only to the view whose scrollers are being
updated.

Reviewed by darin

WebView.subproj/WebDynamicScrollBarsView.h:
WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

10:55 AM Changeset in webkit [5585]

1 copy
41 deletes in branches/unlabeled-1.168.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.168.4'.

10:55 AM Changeset in webkit [5584] by mjs

14 edits in trunk/WebCore

Reviewed by Darin.

fixed 3488883 - KIO::TransferJob needs to really use signals instead of calling loader directly

khtml/khtml_part.cpp: (KHTMLPart::openURL):
khtml/misc/loader.cpp: (Loader::servePendingRequests): (Loader::slotReceivedResponse):
khtml/misc/loader.h:
kwq/KWQKJobClasses.h:
kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): (KIO::TransferJob::url): (KIO::TransferJob::emitData): (KIO::TransferJob::emitRedirection): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
kwq/KWQLoader.mm: (KWQServeRequest):
kwq/KWQObject.mm: (QObject::connect):
kwq/KWQResourceLoader.h:
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): (-[KWQResourceLoader addData:]): (-[KWQResourceLoader finishJobAndHandle]):
kwq/KWQSignal.h:
kwq/KWQSignal.mm: (KWQSignal::call):
kwq/KWQSlot.h:
kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):

Nov 18, 2003:

2:12 PM Changeset in webkit [5583]

1 copy
93 deletes in branches/unlabeled-1.61.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.61.4'.

2:12 PM Changeset in webkit [5582] by hyatt

2 edits in trunk/WebCore

Fix for 3488244, marquee-increments with percentage values not handled correctly. Also added a tweak to ensure
that 1% of a small value ends up being at least an increment of 1. Also added an optimization to not even
bother kicking off the marquee timer if the increment's initial value is 0 (matches WinIE).

khtml/rendering/render_layer.cpp: (Marquee::start): (Marquee::timerEvent):

1:23 PM Changeset in webkit [5581] by rjw

15 edits
3 adds in trunk

WebKit:

More live connect stubs. We're getting close.

Reviewed by Chris.

Plugins.subproj/WebPluginController.m: (-[WebPluginController addPlugin:]): (-[WebPluginController _delayedGetApplet:]):
WebView.subproj/WebView.m: (-[WebView _goToItem:withLoadType:]):

WebCore:

More live connect stubs. We're getting close.

Reviewed by Chris.

WebCore.pbproj/project.pbxproj:
khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet):
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): (HTMLAppletElementImpl::getAppletInstance):
khtml/html/html_objectimpl.h:

JavaScriptCore:

More live connect stubs. We're getting close.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
bindings/jni/jni_runtime.cpp: (JavaClass::JavaClass): (JavaInstance::JavaInstance): (JavaInstance::~JavaInstance):
bindings/jni/jni_runtime.h: (Bindings::JavaConstructor::value): (Bindings::JavaField::value): (Bindings::JavaMethod::value): (Bindings::JavaClass::_commonDelete): (Bindings::JavaClass::_commonCopy): (Bindings::JavaClass::methodNamed): (Bindings::JavaClass::fieldNamed): (Bindings::JavaInstance::getClass):
bindings/runtime.cpp: Added.
bindings/runtime.h: (Bindings::Instance::~Instance):
bindings/runtime_object.cpp: Added. (RuntimeObjectImp::classInfo): (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::deleteProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::_initializeClassInfoFromInstance):
bindings/runtime_object.h: Added. (KJS::RuntimeObjectImp::setInternalInstance): (KJS::RuntimeObjectImp::getInternalInstance):
kjs/object.cpp: (KJS::ObjectImp::get): (KJS::ObjectImp::hasProperty):
kjs/value.h: (KJS::):

10:19 AM Changeset in webkit [5580]

7 copies
3 deletes in tags/JavaScriptCore-96~0~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-96~0~1'.

10:19 AM Changeset in webkit [5579] by vicki

2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore

added a release marker for the latest Merlot build fix, JavaScriptCore-96~0~1

10:16 AM Changeset in webkit [5578]

4 copies
3 deletes in tags/WebKit-106~0~1

This commit was manufactured by cvs2svn to create tag
'WebKit-106~0~1'.

10:16 AM Changeset in webkit [5577] by vicki

2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/WebKit

added a release marker for the latest Merlot build fix, WebKit-106~0~1

10:04 AM Changeset in webkit [5576] by vicki

2 edits in branches/Safari-1-1-Merlot-BuildFixes-branch/JavaScriptCore

Merged this fix from HEAD. We thought this was already merged to the branch, but its not.

2003-11-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by John.

fixed 3483829 - JavaScriptCore needs workaround to compile on Merlot

JavaScriptCore.pbproj/project.pbxproj: Add -Wno-long-double to warning flags.

7:57 AM Changeset in webkit [5575] by darin

4 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3487335: REGRESSION (112-113): "a:b" error message does not cite the URL properly

Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithCode:failingURL:]): Call _webKitErrorWithDomain:code:URL:. (+[NSError _webKitErrorWithDomain:code:URL:]): Call _web_errorWithDomain:code:URL:, instead of using the deprecated failingURL: flavor. (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]): Change this method to call the other one. (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): Implement this one, and put in the NSErrorFailingURLKey, as well as the NSErrorFailingURLStringKey, to match what Foundation now does for other errors.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): Change to use the non-deprecated flavor of the NSError call above.

English.lproj/StringsNotToBeLocalized.txt: Updated for above changes and other recent changes.

2:05 AM Changeset in webkit [5574] by hyatt

1 edit in trunk/LayoutTests/fast/css-generated-content/004-expected.txt

Fix for generated content problems fixes test 4.

2:04 AM Changeset in webkit [5573] by hyatt

1 edit in trunk/LayoutTests/fast/parser/document-write-option-expected.txt

Update option document.write layout test. Somebody fixed a bug and didn't run the layout tests to see that they'd fixed a layout test. ;)

1:55 AM Changeset in webkit [5572] by hyatt

2 edits in trunk/WebCore

Fix for 3478122, crash using first-letter and zooming, and also the fix for 3478078, generated content
does not get removed properly on w3c site. The root cause of these two bugs was the same, namely my
change to meld the concept of generated anonymous content and anonymous blocks created by the layout
engine together. RenderBlock's setStyle method was incorrectly updating before/after/first-letter content
and wiping out its style in random (and bad) ways.

khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):

1:28 AM Changeset in webkit [5571] by hyatt

2 adds in trunk/LayoutTests/fast/css-generated-content

Adding layout test to cover image generated content.

1:21 AM Changeset in webkit [5570] by hyatt

2 edits in trunk/WebCore

Fix for 3487424, images not painting because of dropped layouts. When replaced elements dirtied
themselves during line layout, they only needed to do a local dirty and not walk up the parent chain.

Reviewed by mjs

khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):

12:52 AM Changeset in webkit [5569]

1 copy
379 deletes in branches/unlabeled-1.22.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.22.4'.

12:52 AM Changeset in webkit [5568] by mjs

6 edits
3 adds in trunk/WebCore

Reviewed by Dave.

fixed 3486991 - Add XMLHttpRequest object and stub methods

khtml/ecma/kjs_window.cpp: (Window::get): Handle XMLHttpRequest constructor like Option and Image.
khtml/ecma/kjs_window.h: Ditto.
khtml/ecma/kjs_window.lut.h: Regenerated.
khtml/ecma/xmlhttprequest.cpp: Added. Stub implementations of everything. (KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp): (KJS::XMLHttpRequestConstructorImp::implementsConstruct): (KJS::XMLHttpRequestConstructorImp::construct): (KJS::XMLHttpRequest::tryGet): (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::tryPut): (KJS::XMLHttpRequest::putValue): (KJS::XMLHttpRequest::notifyFinished): (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequestProtoFunc::tryCall):
khtml/ecma/xmlhttprequest.h: Added. Stub implementations of everything. (KJS::XMLHttpRequest::toBoolean): (KJS::XMLHttpRequest::classInfo):
khtml/ecma/xmlhttprequest.lut.h: Added.
khtml/ecma/Makefile.am: Add new .lut.h file.
WebCore.pbproj/project.pbxproj: Add new files.

12:41 AM Changeset in webkit [5567]

1 copy
92 deletes in branches/unlabeled-1.34.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.34.4'.

12:41 AM Changeset in webkit [5566] by hyatt

4 edits in trunk/WebCore

Fix for 3487136, marquees reset when you return to a page in the b/f cache. This patch makes
marquees suspend and resume properly, so they pick up animating where they left off.

Reviewed by mjs

khtml/rendering/render_layer.cpp: (RenderLayer::suspendMarquees): (m_direction): (Marquee::start): (Marquee::suspend):
khtml/rendering/render_layer.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clearTimers):

Nov 17, 2003:

9:40 PM Changeset in webkit [5565] by mjs

3 edits in trunk/JavaScriptCore

Patch from Harri, reviewed by me.

fixed 3487375 - backwards array slice causes infinite loop

kjs/array_object.cpp: (ArrayProtoFuncImp::call):

9:30 PM Changeset in webkit [5564] by mjs

2 edits in trunk/JavaScriptCore

Patch from Harri Porten reviewed by me.

fixed 3487371 - operator precedence for bitwise or, xor and and is wrong

kjs/grammar.y: Correct the precedence.

8:15 PM Changeset in webkit [5563] by mjs

2 edits in trunk/WebCore

Merged from khtml:

-fixed 3487324 - CSS url values should be wrapped in "url()" for cssText purposes

2003-11-07 Dirk Mueller <mueller@kde.org>

css/css_valueimpl.cpp (cssText): wrap uri's into url(). Stephan Kulow noted that other browsers do that.

6:39 PM Changeset in webkit [5562] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

6:38 PM Changeset in webkit [5561]

1 copy
78 deletes in branches/unlabeled-1.62.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.62.4'.

6:38 PM Changeset in webkit [5560] by hyatt

3 edits in trunk/WebCore

Fix for 3472998, stop a crash on an insanely malformed page. I had to change the concept of
"inStrayTableContent" to be a counter, since you could be nested and need to push/pop, and
then I also had to stop from mistakenly popping when I didn't need to.

Reviewed by rjw

khtml/html/htmlparser.cpp: (KHTMLParser::reset): (KHTMLParser::insertNode): (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock): (KHTMLParser::popOneBlock):
khtml/html/htmlparser.h:

5:52 PM Changeset in webkit [5559]

1 copy
41 deletes in branches/unlabeled-1.80.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.80.4'.

5:52 PM Changeset in webkit [5558]

1 copy
93 deletes in branches/unlabeled-1.73.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.73.4'.

5:52 PM Changeset in webkit [5557]

1 copy
376 deletes in branches/unlabeled-1.23.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.23.4'.

5:52 PM Changeset in webkit [5556] by darin

20 edits in trunk/WebCore

Reviewed by Ken.

did keyboard event cleanup to follow up on the keyCode work I did before
fixed 3485558: key identifers use lowercase hex, but the W3C document shows uppercase
fixed 3485564: key identifier for the Return key should be "Enter"
fixed 3485579: letter keys generate different key identifiers depending on whether the shift key is down
fixed 3485568: keyboard event modifier key bits are uninitialized; may have incorrect values
fixed 3481514: which attribute for DOM events reports incorrect value
fixed 3452569: charCode attribute for DOM events not supported

khtml/dom/dom2_events.h: Added charCode.
khtml/dom/dom2_events.cpp: (UIEvent::keyCode): Call through to KeyboardEventImpl instead of doing the work here; better factoring. (UIEvent::charCode): Added. Calls through to KeyboardEventImpl. (UIEvent::which): Call keyCode in KeyboardEventImpl to share code.

khtml/ecma/kjs_events.h: Added charCode property for DOMUIEvent.
khtml/ecma/kjs_events.cpp: (DOMUIEvent::getValueProperty): Added charCode.
khtml/ecma/kjs_events.lut.h: Regenerated.

khtml/html/html_formimpl.h:
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::defaultEventHandler): Remove checks for "U+00000d" since we now use "Enter" for that key; also, we use capitalized hex, so it would have to change to "U+00000D" anyway. (HTMLSelectElementImpl::defaultEventHandler): Ditto.
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Ditto.

khtml/khtmlview.cpp: (KHTMLView::keyPressEvent): Put !APPLE_CHANGES around code we are not using. It was doing a switch based on Qt key codes, but the key value it was using to check was a Macintosh virtual key code, which could yield strange results when the codes happen to match. Safer and smaller code size not to do any of it at all.

khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): Use a KLineEdit instead of LineEditWidget for APPLE_CHANGES. Allows us to put !APPLE_CHANGES around more Qt key code stuff. (RenderLineEdit::select): Cast to KLineEdit instead of LineEditWidget. (ComboBoxWidget::event): Put !APPLE_CHANGES around more unneeded Qt key code stuff. (TextAreaWidget::event): Put !APPLE_CHANGES around more unneeded Qt key code stuff.

khtml/xml/dom2_eventsimpl.h: Made id() const and added keyCode() and charCode().
khtml/xml/dom2_eventsimpl.cpp: (KeyboardEventImpl::KeyboardEventImpl): Initialize all fields in the empty constructor. Initialize all the modifier bits in the main constructor; the old code assumed they started off false, which is not a safe assumption. Also set m_altGraphKey false. Eliminated the unneeded check of text() before calling identifier(). Also adapted for the name change from identifier() to keyIdentifier(). (KeyboardEventImpl::keyCode): Added. Returns the Windows virtual key code for keydown and keyup events, and the Unicode character for all other events. (KeyboardEventImpl::charCode): Added. Returns the Unicode character.

kwq/KWQEvent.h: Changed QCustomEvent to be a typedef for QEvent. (QEvent::QEvent): Removed AccelAvailable, and added KParts, so I could remove some ugly constants from the KParts code. (QMouseEvent::button): Use a cast here since the field is now int. (QMouseEvent::state): Use a cast here since the field is now int. (QMouseEvent::stateAfter): Use a cast here since the field is now int, and use the new _stateAfter field. (QTimerEvent::QTimerEvent): Moved the constructor to be inline since it's so simple. (QKeyEvent::QKeyEvent): Removed type and button state parameters, now unneeded. Also removed now-unused _key, _ascii, and _count fields, and key(), ascii(), and count() functions. (QKeyEvent::state): Made inline. (QKeyEvent::isAccepted): Made inline. (QKeyEvent::text): Made inline. (QKeyEvent::isAutoRepeat): Made inline. (QKeyEvent::accept): Made inline. (QKeyEvent::ignore): Made inline. (QKeyEvent::unmodifiedText): Made inline. (QKeyEvent::keyIdentifier): Made inline and chnaged name from identifier().
kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Renamed from identifierForKeyText and changed parameter to be the event. Cleaned up the code a little bit, and wrote a comment or two. Changed from lowercase hex to uppercase, and called toupper on the key so that letter a-z would work properly. (A non-Unicode toupper is just the ticket here, because I am only sure we want to do this for a-z, not other lowercase characters.) (isKeypadEvent): Added. Uses virtual key codes to decide if a key event is a keypad event, so we can set the state flag correctly. (WindowsKeyCodeForKeyEvent): Added Clear key to the switch statement; it was missing. Changed to no longe use the characterCode helper function since this was the only place it was needed. (mouseButtonForEvent): Added. Similar logic to what was in KWQKHTMLPart before; better factoring to have it in here. (nonMouseButtonsForEvent): Ditto. (QMouseEvent::QMouseEvent): Rewrote constructors. One matches the one from Qt that's used in some places in KHTML code. The other takes an NSEvent and uses the new functions above to compute the button and state. (QKeyEvent::QKeyEvent): Computer type based on the passed-in NSEvent. Compute the auto-repeat flag based on the event and also the "forceAutoRepeat" parameter. Compute the button state based on the event too.

kwq/KWQKHTMLPart.h: Remove buttonForCurrentEvent and stateForCurrentEvent. Both are now in KWQEvent.mm.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Remove extra parameters in code that creates QKeyEvent, now that QKeyEvent can handle everything itself. (KWQKHTMLPart::mouseDown): Same thing as above, only for QMouseEvent. (KWQKHTMLPart::mouseDragged): Ditto. (KWQKHTMLPart::mouseUp): Ditto. (KWQKHTMLPart::mouseMoved): Ditto. (KWQKHTMLPart::sendContextMenuEvent): Ditto.

kwq/KWQKPartsEvent.h: Tweaked the class around a little so it can work without taking advantage of QCustomEvent's data pointer.
kwq/KWQKPartsEvent.mm: (KParts::Event::Event): Changed so it does a strdup on the event name and uses the new event type pre-allocated in KWQEvent.h for us. (KParts::Event::~Event): Free the event name. (KParts::Event::test): Reimplemented this.

kwq/KWQKPartsPart.h: (KParts::Part::event): Removed now-unnecessary cast to change a QCustomEvent into a QEvent.

kwq/KWQNamespace.h: Removed the Qt::Key enum. All the code that used it was already broken because of the mixup between Qt and Macintosh key codes.

4:59 PM Changeset in webkit [5555] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

<rdar://problem/3487079>: Some scheme checks in KURL do not verify
first char is a legal first char for a scheme

kwq/KWQKURL.mm: (KURL::KURL): Added some additional checks when looking through strings looking for schemes. Now the first character is checked for validity as a first character in a scheme.

4:54 PM Changeset in webkit [5554] by hyatt

2 edits in trunk/WebCore

Fix for 3486441, don't use the visibleWidth when computing the containingBlockWidth(). No need to
query the view, since the canvas's width has been set to the proper size (when printing).

Reviewed by john

khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth):

3:44 PM Changeset in webkit [5553]

1 copy
93 deletes in branches/unlabeled-1.45.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.45.4'.

3:44 PM Changeset in webkit [5552] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

fixed 3413713 - iframe forms posting fails without initial src attribute value

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): If the new part is for "about:blank", set the document base URL to parent's base URL.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument): If this part is an iframe, set the document base URL to the parent's base URL.

3:40 PM Changeset in webkit [5551]

1 copy
78 deletes in branches/unlabeled-1.44.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.44.4'.

3:40 PM Changeset in webkit [5550] by darin

2 edits in trunk/WebCore

Reviewed by John.

fixed 3485925: Safari does not correctly parse eight-digit hex character entities

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseEntity): Replaced puzzling variable limit on number of hexadecimal characters to parse with an 8-character limit.

3:35 PM Changeset in webkit [5549]

1 copy
78 deletes in branches/unlabeled-1.36.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.36.4'.

3:35 PM Changeset in webkit [5548] by darin

3 edits in trunk/WebCore

Reviewed by John.

fixed 3485572 -- secure form check in KHTML uses case-sensitive comparison with "https"

khtml/html/html_formimpl.h:
khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formWouldHaveSecureSubmission): Changed to take a DOMString reference for slightly better efficiency, and to use startsWith so the prefix check is not case sensitive and for slightly better efficiency and clarity than calling latin1() and using strncmp.

3:29 PM Changeset in webkit [5547] by mjs

2 edits in trunk/WebCore

commit updated .lut.h file that I forgot to commit before

khtml/ecma/kjs_window.lut.h:

3:27 PM Changeset in webkit [5546] by mjs

6 edits in trunk/WebCore

Reviewed by Darin.

fixed 3382829 - Safari won't load script src javascript if done by a document.write followed by document.close

khtml/xml/dom_docimpl.cpp: (DocumentImpl::closeInternal): Don't delete the tokenizer if it's waiting for scripts. It will get destroyed later when the part gets all subresources and closes the document.
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::isWaitingForScripts): Added.
khtml/html/htmltokenizer.h: Prototyped.
khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::isWaitingForScripts): Added.
khtml/xml/xml_tokenizer.h: Prototyped.

3:24 PM Changeset in webkit [5545] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

Add malformed table content test.

3:23 PM Changeset in webkit [5544] by hyatt

2 edits in trunk/WebCore

Fix for 3480108, crash because of the wrong malformedTableParent when stray content is placed inside
a <tr>.

Reviewed by john

khtml/html/htmlparser.cpp: (KHTMLParser::popBlock):

3:21 PM Changeset in webkit [5543] by mjs

2 edits in trunk/WebCore

Add file I forgot in the last commit.

3:17 PM Changeset in webkit [5542] by mjs

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3397494 - FileMaker: Setting option object text fails if created without text

khtml/html/html_formimpl.cpp: (HTMLOptionElementImpl::childrenChanged): Update the select element. This ends up getting called when you add a text node to an option that didn't used to have one.

3:12 PM Changeset in webkit [5541] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3480023>: Links don't work if there's a colon in the URL

The colon in the URL was confusing KURL. I modified some checks in
KURL so that its search for schemes stops when a non-scheme
character is found rather than when a path end segment character
is found.

kwq/KWQKURL.mm: Added a new Colon class to the table of characters. (isSchemeCharOrColon): New helper. (KURL::KURL): Call on new helper when looking for a scheme. (KURL::findHostnameInHierarchicalURL): Ditto.

2:20 PM Changeset in webkit [5540] by hyatt

16 edits in trunk/LayoutTests

Revise layout tests now that we break on hyphens and question marks.

2:08 PM Changeset in webkit [5539] by hyatt

2 edits in trunk/WebCore

Fix for 2931829, lines with hyphens should break on the hyphens. Match WinIE's behavior of
breaking on - and ?.

Reviewed by john

khtml/rendering/break_lines.cpp: (khtml::isBreakable):

1:15 PM Changeset in webkit [5538] by hyatt

12 edits in trunk/LayoutTests

Check in revised layout tests after changing all the logical font size definitions.

12:38 PM Changeset in webkit [5537] by hyatt

9 edits in trunk/WebCore

Fix for 3415771, Safari should use mini form controls when necessary. This patch adds heuristics for
swapping in mini form controls and also drops intrinsic margins when mini form controls are used.

Fix for 3486454, options/optgroups should strip leading/trailing space.

Together these two fixes solve 3486581, travelocity misrenders because form controls are too large.

Reviewed by Darin

Also fixing 3474994, alink needs to be restricted to actual links and not all <a> tags.

Reviewed by John

Finally, adding :active outlines around <input type=image> (covered by the old bug 3141767).

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::applyRule): (khtml::CSSStyleSelector::checkForGenericFamilyChange): (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (khtml::): (khtml::CSSStyleSelector::fontSizeForKeyword): (khtml::CSSStyleSelector::largerFontSize): (khtml::CSSStyleSelector::smallerFontSize):
khtml/css/cssstyleselector.h:
khtml/css/html4.css:
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor):
khtml/rendering/render_form.cpp: (RenderFormElement::addIntrinsicMarginsIfAllowed): (RenderSelect::updateFromElement):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): (DocumentImpl::attach):
kwq/KWQButton.mm: (KWQNSControlSizeForFont):

3:45 AM Changeset in webkit [5536] by hyatt

2 edits in trunk/WebCore

Back out my change to exclude text runs from getting a relayout on a style change. I totally forgot about
text zooming.

khtml/rendering/render_object.cpp: (RenderObject::setStyle):

1:29 AM Changeset in webkit [5535] by mjs

11 edits
1 add in trunk

WebCore:

Reviewed by Dave.

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

khtml/ecma/kjs_window.cpp: (Window::get): add support for window.print (Apple-only) (WindowFunc::tryCall): ditto
khtml/ecma/kjs_window.h: Add Print to enum
khtml/ecma/kjs_window.lut.h: Regenerated
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::print): Call bridge.
kwq/KWQKHTMLPart.h: Declare above.
kwq/WebCoreBridge.h: prototype print method for other side of bridge.

WebKit:

Reviewed by Dave.

WebKit part of fix for:

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge print]): Call delegate.
WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webViewPrint:]): Implemented (do nothing).
WebView.subproj/WebUIDelegatePrivate.h: Added. Add extra SPI method webViewPrint: for UI delegate.
WebKit.pbproj/project.pbxproj: Install WebUIDelegatePrivate.h as private header

WebBrowser:

Reviewed by Dave.

WebBrowser part of fix for:

<rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons

BrowserWebController.m: (-[BrowserWebView webViewPrint:]): Call printDocument: on the document.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed