Context Navigation

← Previous Period
Next Period →

Timeline

Dec 3, 2003:

5:41 PM Changeset in webkit [5689]

1 copy
77 deletes in branches/unlabeled-1.50.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.50.4'.

5:41 PM Changeset in webkit [5688]

1 copy
24 deletes in branches/unlabeled-1.2336.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2336.4'.

5:41 PM Changeset in webkit [5687] by rjw

12 edits in trunk

WebCore:

LiveConnect: Removed some debugging.

Reviewed by Chris.

khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):

JavaScriptCore:

LiveConnect: Added support for parameter passing to Java and conversion
of return values.

Reviewed by Chris.

bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaMethod::JavaMethod): (JavaMethod::signature):
bindings/jni/jni_runtime.h: (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::getJNIType):
bindings/jni/jni_utility.cpp: (callJNIBooleanMethodA): (convertValueToJValue):
bindings/jni/jni_utility.h:
bindings/runtime.h:
bindings/runtime_method.cpp: (RuntimeMethodImp::call):
bindings/runtime_object.cpp: (RuntimeObjectImp::get):

4:17 PM Changeset in webkit [5686]

1 copy
93 deletes in branches/unlabeled-1.79.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.79.4'.

4:17 PM Changeset in webkit [5685] by hyatt

2 edits in trunk/WebCore

Fix for 3475761, list bullets mislayout after text zooming.

Reviewed by kocienda

khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):

2:46 PM Changeset in webkit [5684]

1 copy
93 deletes in branches/unlabeled-1.86.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.86.4'.

2:46 PM Changeset in webkit [5683]

1 copy
92 deletes in branches/unlabeled-1.32.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.32.4'.

2:46 PM Changeset in webkit [5682]

1 copy
93 deletes in branches/unlabeled-1.118.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.118.4'.

2:46 PM Changeset in webkit [5681] by hyatt

4 edits in trunk/WebCore

Fix for 3493356, table cells didn't repaint properly.

Reviewed by kocienda

khtml/rendering/render_object.cpp: (RenderObject::repaintObjectsBeforeLayout):
khtml/rendering/render_table.cpp: (RenderTableCell::getAbsoluteRepaintRect):
khtml/rendering/render_table.h:

2:07 PM Changeset in webkit [5680] by hyatt

2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

2:04 PM Changeset in webkit [5679]

1 copy
129 deletes in branches/unlabeled-1.25.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.25.4'.

2:04 PM Changeset in webkit [5678] by hyatt

2 edits in trunk/WebCore

Fix for 3495748, hang in parser at ocelot.ca. <nobr> needs to have very high priority (equal to the
priority of blocks like h1-6, p, and div), so that unclosed <nobr>s will close divs and ps.

Reviewed by gramps

khtml/html/dtd.cpp:

12:58 PM Changeset in webkit [5677] by hyatt

2 edits in trunk/WebCore

Fix for 3475767, hang at saabnet.com. Fix h1-h6 to be more tolerant regarding allowed child elements, to avoid
deeply nested pages.

Reviewed by darin

khtml/html/dtd.cpp: (DOM::checkChild):

12:50 PM Changeset in webkit [5676]

1 copy
377 deletes in branches/unlabeled-1.58.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.58.4'.

12:50 PM Changeset in webkit [5675] by sullivan

2 edits in trunk/WebCore

fixed these two design issues after Dave and I talked to HI: <rdar://problem/3497072>: There shouldn't be a focus ring around clicked regions <rdar://problem/3499315>: Focus ring should use aqua color always

Reviewed by Dave.

khtml/css/html4.css:

11:46 AM Changeset in webkit [5674]

1 copy
77 deletes in branches/unlabeled-1.40.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.40.4'.

11:46 AM Changeset in webkit [5673]

1 copy
107 deletes in branches/unlabeled-1.20.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.20.4'.

11:46 AM Changeset in webkit [5672] by mjs

3 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3395759>: results of parent.document.getElementsByTagName can't be added to string

khtml/ecma/kjs_dom.cpp: (DOMNodeList::toPrimitive): Always convert to string instead of trying to convert to number and failing, as is done for DOMNode.
khtml/ecma/kjs_dom.h: Prototype new method.

Dec 2, 2003:

5:21 PM Changeset in webkit [5671] by rjw

15 edits
2 adds in trunk

WebCore:

Return a value that is backed by RuntimeObjectImpl, instead
of a DOM object for applet[0]. This is better than having
the DOM object redirect to the RuntimeObjectImpl.

Reviewed by Chris.

khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):

JavaScriptCore:

Added support for calling simple methods in Java from JavaScript.
(void return and no parameters). Yay, LiveConnect lives.

Still need write argument and return value conversion code.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
bindings/jni/jni_instance.cpp: (JavaInstance::getClass): (JavaInstance::invokeMethod):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod): (JavaMethod::signature): (JavaMethod::JNIReturnType):
bindings/jni/jni_runtime.h: (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::_commonCopy): (Bindings::JavaMethod::name):
bindings/jni/jni_utility.cpp: (signatureFromPrimitiveType):
bindings/jni/jni_utility.h:
bindings/runtime.h:
bindings/runtime_method.cpp: Added. (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::~RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::implementsCall): (RuntimeMethodImp::call): (RuntimeMethodImp::codeType): (RuntimeMethodImp::execute):
bindings/runtime_method.h: Added.
bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get):
bindings/runtime_object.h:
kjs/function.cpp: (FunctionImp::FunctionImp):
kjs/interpreter.h:

5:09 PM Changeset in webkit [5670]

1 copy
64 deletes in branches/unlabeled-1.97.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.97.4'.

5:09 PM Changeset in webkit [5669] by mjs

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3488220>: namespaces test from David Faure causes Safari to crash in DOM::DocumentImpl::createElementNS

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): Check if new element is NULL before messing with it, to avoid a crash.

3:19 PM Changeset in webkit [5668]

1 copy
93 deletes in branches/unlabeled-1.83.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.83.4'.

3:19 PM Changeset in webkit [5667] by hyatt

2 edits in trunk/WebCore

Fix for 3497999, null check the text() of RenderTexts to avoid a crash in current().

Reviewed by kocienda

khtml/rendering/bidi.cpp: (khtml::BidiIterator::current):

3:13 PM Changeset in webkit [5666]

1 copy
126 deletes in branches/unlabeled-1.9.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.9.4'.

3:13 PM Changeset in webkit [5665]

1 copy
556 deletes in branches/unlabeled-1.7.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.7.4'.

3:13 PM Changeset in webkit [5664]

1 copy
151 deletes in branches/unlabeled-1.46.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.46.4'.

3:13 PM Changeset in webkit [5663]

1 copy
629 deletes in branches/unlabeled-1.4.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.4.4'.

3:13 PM Changeset in webkit [5662]

1 copy
94 deletes in branches/unlabeled-1.28.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.28.4'.

3:13 PM Changeset in webkit [5661]

1 copy
115 deletes in branches/unlabeled-1.26.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.26.4'.

3:13 PM Changeset in webkit [5660]

1 copy
129 deletes in branches/unlabeled-1.24.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.24.4'.

3:13 PM Changeset in webkit [5659]

1 copy
498 deletes in branches/unlabeled-1.12.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.12.4'.

3:13 PM Changeset in webkit [5658]

1 copy
64 deletes in branches/unlabeled-1.11.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.11.4'.

3:13 PM Changeset in webkit [5657]

1 copy
115 deletes in branches/unlabeled-1.10.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.10.4'.

3:13 PM Changeset in webkit [5656] by mjs

15 edits in trunk/WebCore

Reviewed by Darin.

Implemented a simple form of document serialization, enough to take care of:

<rdar://problem/3487190>: implement send of DOMDocument for XMLHttpRequest

khtml/dom/dom_doc.cpp: (DOM::Document::toString):
khtml/dom/dom_doc.h:
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::urlMatchesDocumentDomain): (KJS::XMLHttpRequestProtoFunc::tryCall):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::toString):
khtml/html/html_elementimpl.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::toString): (DocumentFragmentImpl::toString): (DocumentTypeImpl::copyFrom): (DocumentTypeImpl::toString):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::openTagStartToString): (ElementImpl::toString):
khtml/xml/dom_elementimpl.h:
khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_textimpl.cpp: (CommentImpl::toString): (TextImpl::toString): (CDATASectionImpl::toString):
khtml/xml/dom_textimpl.h:
khtml/xml/dom_xmlimpl.cpp: (EntityImpl::toString): (EntityReferenceImpl::toString): (ProcessingInstructionImpl::setStyleSheet): (ProcessingInstructionImpl::toString):
khtml/xml/dom_xmlimpl.h:

2:54 PM Changeset in webkit [5655]

1 copy
123 deletes in branches/unlabeled-1.116.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.116.4'.

2:54 PM Changeset in webkit [5654] by hyatt

2 edits in trunk/WebCore

Fix for 3493677, containingBlock() null because we tried to support position:relative on table rows. Fix
is to disallow this.

Reviewed by kocienda

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):

2:25 PM Changeset in webkit [5653] by hyatt

2 edits in trunk/WebCore

Fix for 3493697, nil-deref in bidi code. Need to null-check strings with no length.

Reviewed by john

khtml/rendering/bidi.cpp: (khtml::addRun):

2:06 PM Changeset in webkit [5652]

1 copy
93 deletes in branches/unlabeled-1.101.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.101.4'.

2:06 PM Changeset in webkit [5651] by hyatt

2 edits in trunk/WebCore

Fix for 3495746, nil deref of containing block (frame inside frameset).

Reviewed by kocienda

khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth):

11:58 AM Changeset in webkit [5650] by cblu

2 edits in trunk/WebKit

Fixed:
<rdar://problem/3439222>: always hangs opening plain text file on a particular machine due to missing font, no UI to detect
<rdar://problem/3492983>: Certain fonts cause Safari to hang on text/plain pages

Reviewed by rjw.

WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Use [[WebTextRendererFactory sharedFactory] fontWithFamilies:traits:size:] to get the font since it takes the font family which is what we store in WebPreferences and it does fallback work. Only set the font if non-nil is returned.

11:48 AM Changeset in webkit [5649] by kocienda

3 edits in trunk/WebCore

Reviewed by John

kwq/KWQRect.h:
kwq/KWQRect.mm: (QRect::bottomRight): Added helper.

8:04 AM Changeset in webkit [5648] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed 3493799: JavaScript string.replace expands $ if it's the last character in replacement string

kjs/ustring.cpp: (KJS::UString::toDouble): Fix backwards handling of the "tolerant" boolean. This indirectly caused the string.replace bug.

3:00 AM Changeset in webkit [5647]

1 copy
113 deletes in branches/unlabeled-1.96.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.96.4'.

3:00 AM Changeset in webkit [5646] by mjs

2 edits in trunk/WebCore

Merged the following patch from David Faure to fix:

<rdar://problem/3497663>: Can't look up frames by number using windw[i] notation

2003-11-25 David Faure <faure@kde.org>

ecma/kjs_window.cpp: Implement hasProperty and get for frames by number in Window, to fix window[0] and parent[1] etc. (#56983)

2:11 AM Changeset in webkit [5645] by mjs

5 edits in trunk/JavaScriptCore

Merged patches from Harri Porten and David Faure to fix:

<rdar://problem/3497643>: reproducible crash printing self-referential array

kjs/array_object.cpp: (ArrayProtoFuncImp::call): Break out of the loop if an exception was thrown.
kjs/nodes.cpp: (FunctionCallNode::evaluate): Move function call depth check from here...
kjs/object.cpp: (KJS::Object::call): ...to here.
kjs/object.h: Un-inline Object::call now that it does more.

Dec 1, 2003:

3:11 PM Changeset in webkit [5644] by rjw

2 edits in trunk/JavaScriptCore

Fixed mistake in method signatures used to get boolean and integer fields.

Reviewed by Chris.

bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance):

2:53 PM Changeset in webkit [5643] by mjs

3 edits in trunk/WebKit

Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): Let WebCore know about redirects.

2:52 PM Changeset in webkit [5642]

1 copy
529 deletes in branches/unlabeled-1.5.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.5.4'.

2:52 PM Changeset in webkit [5641] by mjs

5 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::open): Refuse to start if the URL is not one this document is allowed to access. (KJS::XMLHttpRequest::slotRedirection): Stop the job if we redirect to a URL the home document is not allowed to access.
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader redirectedToURL:]): emit the right signal
kwq/WebCoreResourceLoader.h: Prototype new method

2:44 PM Changeset in webkit [5640]

1 copy
76 deletes in branches/unlabeled-1.31.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.31.4'.

2:44 PM Changeset in webkit [5639]

1 copy
411 deletes in branches/unlabeled-1.13.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.13.4'.

2:44 PM Changeset in webkit [5638] by rjw

16 edits in trunk

WebKit:

Moved grungy polling code from WebKit to the JavaPlugin.

Reviewed by Chris.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pollForAppletInView:]):

WebCore:
Fixed parameter passing to applet. Child elements are NOT valid in setStyle(). So we now either create the widget before needed with createWidgetIfNecessary. This either happens when doing the first layout, or when JavaScript first references the applet element.

Fixed early delete of the the main applet instance. When the JS collector cleaned up the last JS object referring to the applet instance we were deleting the java instance. This caused the applet instance cached on the applet element to be invalid. The applet instance is the only Java object not to be cleaned up by the JS collector.

Added support for getting at Java object fields.

Reviewed by Chris.

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet):
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance):
khtml/html/html_objectimpl.h:
khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout):
khtml/rendering/render_applet.h: (khtml::RenderApplet::renderName):

JavaScriptCore:
Fixed parameter passing to applet. Child elements are NOT valid in setStyle(). So we now create the widget before needed with createWidgetIfNecessary. This either happens when doing the first layout, or when JavaScript first references the applet element.

Added support for getting at Java object fields.

Reviewed by Chris.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/jni/jni_instance.cpp: (JObjectWrapper::JObjectWrapper):
bindings/jni/jni_instance.h: (Bindings::JObjectWrapper::~JObjectWrapper):
bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance):
bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::deleteProperty):
bindings/runtime_object.h:

1:33 PM Changeset in webkit [5637]

1 copy
330 deletes in branches/unlabeled-1.197.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.197.4'.

1:33 PM Changeset in webkit [5636] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3496960: nil-deref in idFromNode inside elementDoesAutoComplete:

kwq/WebCoreBridge.mm: (inputElementFromDOMElement): Added nil check. (formElementFromDOMElement): Added nil check.

11:22 AM Changeset in webkit [5635] by hyatt

3 edits in trunk/WebCore

Fix for 3490959, collapsed border tables don't paint backgrounds.

Reviewed by darin

khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::paint): (RenderTable::paintBoxDecorations):
khtml/rendering/render_table.h:

11:18 AM Changeset in webkit [5634] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3493939: ordered lists with type="A" roll over to A' after X rather than after Z

khtml/rendering/render_list.cpp: (toLetter): Change 24 to 26.

11:05 AM Changeset in webkit [5633] by kocienda

4 edits in trunk/WebKit

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

Misc.subproj/WebNSEventExtras.h: Add declarations for new key event helpers.
Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isKeyEvent:]): Added. (-[NSEvent _web_isDeleteKeyEvent]): Added. (-[NSEvent _web_isEscapeKeyEvent]): Added. (-[NSEvent _web_isOptionTabKeyEvent]): Added. (-[NSEvent _web_isReturnOrEnterKeyEvent]): Added. (-[NSEvent _web_isTabKeyEvent]): Added.
WebKit.pbproj/project.pbxproj: Made WebNSEventExtras.h a private header so WebBrowser can use the new helpers.

WebBrowser:

Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

BookmarksViewController.m: (-[BookmarksViewController handleKeyDown:inSourceColumn:]): Move to new key event helper.
BrowserNSEventExtras.h: Remove key event helpers from here. WebBrowser will now pick these up from WebKit.
BrowserNSEventExtras.m: Ditto.
BrowserWindowController.m: Move to new key event helpers. (-[BrowserWindowController cancel:]): Ditto. (-[BrowserWindowController windowWillHandleKeyEvent:]): Ditto. (-[BrowserWindowController performQuickSearch:]): Ditto.
DownloadViewController.m: (-[DownloadViewController keyDown:]): Ditto.
Preferences.subproj/SheetWithTableController.m: (-[SheetWithTableController tableView:keyDown:]): Ditto.
TitleBarButton.m: Ditto.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed