Timeline



Dec 5, 2003:

3:22 PM Changeset in webkit [5711] by hyatt
  • 2 edits in trunk/WebCore

Add support for link clicking as an accessibility action.

Reviewed by john

  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]):
3:05 PM Changeset in webkit [5710] by rjw
  • 6 edits
    2 adds in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Part 1 of supporting JS bindings to
native language arrays.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bindings/jni/jni_runtime.h:
  • bindings/runtime.cpp: (Instance::setValueOfField):
  • bindings/runtime.h: (Bindings::Array::~Array):

Tests:

Added tests to access Java arrays.

Reviewed by Chris.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:
2:03 PM Changeset in webkit [5709] by mjs
  • 21 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487222>: Add ability to create working fully standalone document object

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::addSheet): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::applyRule):
  • khtml/dom/dom_doc.cpp: (DOM::Document::part):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (KJS::checkNodeSecurity):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::tryGet): (KJS::HTMLDocument::putValue): (KJS::HTMLElement::tryGet): (Image::notifyFinished):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): (HTMLDocumentImpl::lastModified):
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): (HTMLFormElementImpl::prepareSubmit): (HTMLFormElementImpl::submit): (HTMLFormElementImpl::reset): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::defaultEventHandler):
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isKeyboardFocusable): (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptExecution): (HTMLTokenizer::parseTag):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): (DocumentImpl::part): (DocumentImpl::close): (DocumentImpl::processHttpEquiv):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::partForNode): (KWQKHTMLPart::attributedString):
2:00 PM Changeset in webkit [5708] by rjw
  • 2 edits in trunk/WebCore

Fixed 3501885. Added null test to returned node from collection.

Reviewed by John.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):
10:06 AM Changeset in webkit [5707] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3491427>: REGRESSION (100-114): multi-page HTML content in Mail is blank when printed

Darin and I figured this one out.

Reviewed by Ken.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): Don't call setNeedsDisplay:NO when we're turning printing on, as doing so prevents anything from drawing in the case where this is called from adjustPageHeightsNew:top:bottom:limit
8:52 AM Changeset in webkit [5706] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed regression in small caps with substituted fonts my patch from yesterday caused
  • fixed 3463599: if Lucida font is installed, you see bad glyphs on pages that use it (advogato.org)
  • fixed storage leak if a renderer is ever deallocated (I don't think we ever do that)
  • fixed some small leaks in various error cases by adding appropriate free and dispose calls
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer dealloc]): Free the Unicode glyph map too. (fontContainsString): Moved inline function up here so it will be inlined. (-[WebTextRenderer _setupFont]): Free the glyph map and set it back to zero if we fail after extending the glyph map to include space. This fixes the "wrong glyph codes" bug with Lucida above. (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): Add free calls needed to avoid storage leaks in failure cases. (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Ditto. (-[WebTextRenderer _initializeATSUStyle]): Add ATSUDisposeStyle to fix storage leak. (freeWidthMap): Use a loop instead of recursion. (freeGlyphMap): Use a loop instead of recursion. (freeUnicodeGlyphMap): Added. (widthForNextCharacter): Don't use the original characters or cluster length, because the character may have been capitalized for use in small caps rendering. So check the character for <= 0xFFFF instead of looking at clusterLength, and break the character into a local array instead of using the original character pointer.

Dec 4, 2003:

9:09 PM Changeset in webkit [5705] by kocienda
  • 4 edits in branches

Reviewed by me

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Fixed some formatting. By calling new isEditingAtSelection() helper, fixed crasher caused by checking if we're editing and the selection has been cleared. (KHTMLPart::isEditingAtSelection): New helper.
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::placeCaret): Don't focus if not editing.
5:53 PM Changeset in webkit [5704] by kocienda
  • 1 edit
    2 adds in branches

2003-12-04 Ken Kocienda <​kocienda@apple.com>

Reviewed by me

  • khtml/html/htmlediting.cpp: Added.
  • khtml/html/htmlediting.h: Added.
5:53 PM Changeset in webkit [5703]
  • 16 copies
    341 deletes in branches/HTML-editing-hacks-branch

This commit was manufactured by cvs2svn to create branch
'HTML-editing-hacks-branch'.

5:27 PM Changeset in webkit [5702] by darin
  • 4 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3497879: REGRESSION (100-115): all non-BMP characters (including Deseret) are broken
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]): Bump offset by getting it from the iterator; don't assume we can just bump it by one each time. It would be even nicer to have a bit more abstraction. (initializeCharacterWidthIterator): Remove call to initializeCharacterShapeIterator. (widthForNextCharacter): Move handling of surrogate pairs (non-BMP) in here and unify it with the handling of BMP characters; this removes the broken code that was returning the wrong font, and changes us to use the code that was already doing the right thing for the surrogate pair case. Also get rid of the use of 0 width to mean "no glyph", which fixes the doubled glyph problem. Also got rid of remnants of use of the shape iterator.
  • Misc.subproj/WebUnicode.h: Remove obsolete shape iterator.
  • Misc.subproj/WebUnicode.m: Ditto.
5:05 PM Changeset in webkit [5701] by rjw
  • 7 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Moved defaultValue into concrete implementation because
more intelligent conversion can be perform with knowledge
of the class of the original instance.

Reviewed by Chris.

  • bindings/jni/jni_class.cpp: (JavaClass::isNumberClass): (JavaClass::isBooleanClass): (JavaClass::isStringClass):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::defaultValue): (JavaInstance::valueOf):
  • bindings/jni/jni_instance.h: (Bindings::JavaInstance::javaInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::defaultValue):

Tests:

Fixed incorrect log of boolean type.

Reviewed by Chris.

  • LiveConnect/Blink/test.html:
4:55 PM Changeset in webkit [5700]
  • 30 copies
    2 deletes in tags/WebCore-106~3

This commit was manufactured by cvs2svn to create tag
'WebCore-106~3'.

4:55 PM Changeset in webkit [5699] by mjs
  • 2 edits in branches/SUPanBisque-branch/WebCore

WebCore 106.3

4:30 PM Changeset in webkit [5698] by kocienda
  • 34 edits in branches

Reviewed by me

A large set of change to get a blinking caret
and a little bit of text input limping along.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/dom_node.cpp: (Node::getCursor):
  • khtml/dom/dom_node.h:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLDivElementImpl::defaultEventHandler):
  • khtml/html/html_blockimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::hasSelection): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::caretNode): (KHTMLPart::caretOffset): (KHTMLPart::isPointInsideSelection): (KHTMLPart::khtmlMousePressEvent): (isBeforeNode): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::topLevelFrameCount): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (CaretViewContext::CaretViewContext): (EditorContext::EditorContext): (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::caretViewContext): (KHTMLViewPrivate::editorContext): (khtml::ensureLeafNode): (khtml::findRenderer): (khtml::sanitizeCaretState): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::drawContents): (KHTMLView::layout): (KHTMLView::keyPressEvent): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::ensureNodeHasFocus): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::caretOn): (KHTMLView::caretOff): (KHTMLView::showCaret): (KHTMLView::paintCaret): (KHTMLView::foldSelectionToCaret): (KHTMLView::hideCaret): (KHTMLView::placeCaret): (KHTMLView::moveCaretTo):
  • khtml/khtmlview.h:
  • khtml/rendering/render_box.cpp: (RenderBox::caretPos):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_br.h: (khtml::RenderBR::isBR): (khtml::RenderBR::caretMinOffset): (khtml::RenderBR::caretMaxOffset):
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretPos):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_line.h: (khtml::InlineBox::caretMinOffset): (khtml::InlineBox::caretMaxOffset):
  • khtml/rendering/render_object.cpp: (RenderObject::caretPos): (RenderObject::isEditable):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFlow): (khtml::RenderObject::caretMinOffset): (khtml::RenderObject::caretMaxOffset):
  • khtml/rendering/render_replaced.h: (khtml::RenderReplaced::caretMinOffset): (khtml::RenderReplaced::caretMaxOffset):
  • khtml/rendering/render_text.cpp: (InlineTextBox::caretMinOffset): (InlineTextBox::caretMaxOffset): (RenderText::caretPos): (RenderText::htmlFont): (RenderText::caretMinOffset): (RenderText::caretMaxOffset):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::hasWindowEventListener): (DocumentImpl::applyEditing):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isContentEditable): (NodeImpl::getCaret): (NodeImpl::prevLeafNode): (NodeImpl::nextLeafNode): (NodeImpl::createRenderer): (NodeImpl::caretMinOffset): (NodeImpl::caretMaxOffset):
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::caretMinOffset): (CharacterDataImpl::caretMaxOffset):
  • khtml/xml/dom_textimpl.h:
  • kwq/KWQKDebug.h: (kdbgstream::operator<<):
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged): (KWQKHTMLPart::paint):
  • kwq/KWQLogging.h:
  • kwq/KWQLogging.m:
  • kwq/KWQWidget.h: (QWidget::focusInEvent):
4:28 PM Changeset in webkit [5697] by rjw
  • 9 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Added support for setting the value of Java
fields.

Reviewed by Chris.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod):
  • bindings/jni/jni_runtime.h: (Bindings::JavaField::getJNIType):
  • bindings/jni/jni_utility.cpp: (JNITypeFromClassName): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.cpp: (Instance::setValueOfField):
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::defaultValue):

Tests:

Added test of setting Java fields from JavaScript.

Reviewed by Chris.

  • LiveConnect/Blink/Holder.java: (Holder):
  • LiveConnect/Blink/test.html:
2:33 PM Changeset in webkit [5696] by rjw
  • 16 edits in trunk

WebCore:

Added support for named applet access from document node.
Factored creation of KJS::Values from RuntimeObjectImps.

Reviewed by Chris.

  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMNamedNodeMap): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet):

JavaScriptCore:

Added support for string conversions.
Changed various JavaString member variables to be inline.
Implemented defaultValue for context relevant type coercion.

Reviewed by Chris.

  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::setClassName): (JavaClass::classForInstance):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (appendClassName): (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=): (Bindings::JavaString::characters): (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::~JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::type): (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=): (Bindings::JavaField::name): (Bindings::JavaField::type): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::name): (Bindings::JavaMethod::returnType):
  • bindings/jni/jni_utility.cpp: (convertValueToJValue):
  • bindings/runtime.h: (Bindings::Instance::valueOf):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::call):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::classInfo):

Tests:

Added tests passing various parameters type to Java methods.

Reviewed by Chris.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.setTextWithString): (Blink.setTextWithNumberValueUsingByte): (Blink.setTextWithNumberValueUsingShort): (Blink.setTextWithNumberValueUsingInt): (Blink.setTextWithNumberValueUsingLong): (Blink.setTextWithNumberValueUsingFloat): (Blink.setTextWithNumberValueUsingDouble): (Blink.setTextWithNumberValueUsingChar): (Blink.setTextWithNumberValueUsingBoolean):
  • LiveConnect/Blink/Blink.pbproj/project.pbxproj:
  • LiveConnect/Blink/test.html:
  • PDFBundle/PDFBundle.pbproj/project.pbxproj:
2:28 PM Changeset in webkit [5695] by mjs
  • 3 edits in branches/SUPanBisque-branch/WebCore

Reviewed by Ken.

<rdar://problem/3500456>: JavaScript sites crash when a PAC file is in place

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add required locking. (KJS::getDOMEvent): Ditto.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Ditto. (KJSProxyImpl::createHTMLEventHandler): Ditto. (KJSProxyImpl::initScript): Ditto.
11:45 AM Changeset in webkit [5694] by darin
  • 9 edits in trunk/WebCore

Reviewed by John.

This was an uncaught exception thrown by DocumentImpl. But the design of KHTML DOM is that
"impl" classes return exception codes; they don't throw exceptions.

  • khtml/dom/dom_doc.cpp: (DOM::Document::createElement): Throw exception if necessary. The impl function now returns an exception code. (DOM::Document::createElementNS): Ditto.
  • khtml/html/html_documentimpl.h: Add exception code parameter to createElement.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createElement): Pass along the exception code from the lower level.
  • khtml/xml/dom_docimpl.h: Add exception code parameters to createElement, createElementNS, and createHTMLElement.
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Handle exception code from createElementNS. (DocumentImpl::createElement): Add exception code parameter, not set since there is no exception. (DocumentImpl::importNode): Handle exception code from createElementNS. (DocumentImpl::createElementNS): Add exception code parameter. Propagate the exception codes that we get from createHTMLElement and setPrefix. (DocumentImpl::createHTMLElement): Add exception code parameter. Use an exception code rather than a C++ exception for INVALID_CHARACTER_ERR.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Pass exception code parameter to createElement.
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): Pass exception code parameter to createElementNS, and return false if it is not zero. This is where the bug happened. Before we would get an exception from createElementNS, but "impl" functions are not supposed to throw in KHTML's DOM. (XMLTokenizer::finish): Add various exception code parameters to compile, but we know we won't get any exceptions.
  • kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument createElement:]): Pass an (ignored) exception code parameter. (-[WebCoreDOMDocument createElementNS::]): Pass an (ignored) exception code parameter.
11:01 AM Changeset in webkit [5693] by vicki
  • 3 edits in trunk

the tree is open for Safari-117

10:57 AM Changeset in webkit [5692]
  • 3 copies in tags/Safari-116

This commit was manufactured by cvs2svn to create tag 'Safari-116'.

10:57 AM Changeset in webkit [5691] by vicki
  • 9 edits in trunk

Safari-116, Safari 1.2 stamp

8:28 AM Changeset in webkit [5690] by darin
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • fixed 3498426: assertion failure in tooltip code at macosx.apple.com
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setToolTip:]): Work around the apparent bug in AppKit (3500217) that causes it to return 0 for the tool tip tag by using removeAllToolTips and not storing the tag at all. Besides the assertion failure there may also be a symptom of a "stuck" tool tip and a small memory leak until the window is closed.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove unused toolTipTag.

Dec 3, 2003:

5:41 PM Changeset in webkit [5689]
  • 1 copy
    77 deletes in branches/unlabeled-1.50.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.50.4'.

5:41 PM Changeset in webkit [5688]
  • 1 copy
    24 deletes in branches/unlabeled-1.2336.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2336.4'.

5:41 PM Changeset in webkit [5687] by rjw
  • 12 edits in trunk

WebCore:

LiveConnect: Removed some debugging.

Reviewed by Chris.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):

JavaScriptCore:

LiveConnect: Added support for parameter passing to Java and conversion
of return values.

Reviewed by Chris.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaMethod::JavaMethod): (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::getJNIType):
  • bindings/jni/jni_utility.cpp: (callJNIBooleanMethodA): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: (RuntimeMethodImp::call):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get):
4:17 PM Changeset in webkit [5686]
  • 1 copy
    93 deletes in branches/unlabeled-1.79.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.79.4'.

4:17 PM Changeset in webkit [5685] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3475761, list bullets mislayout after text zooming.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):
2:46 PM Changeset in webkit [5684]
  • 1 copy
    93 deletes in branches/unlabeled-1.86.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.86.4'.

2:46 PM Changeset in webkit [5683]
  • 1 copy
    92 deletes in branches/unlabeled-1.32.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.32.4'.

2:46 PM Changeset in webkit [5682]
  • 1 copy
    93 deletes in branches/unlabeled-1.118.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.118.4'.

2:46 PM Changeset in webkit [5681] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3493356, table cells didn't repaint properly.

Reviewed by kocienda

  • khtml/rendering/render_object.cpp: (RenderObject::repaintObjectsBeforeLayout):
  • khtml/rendering/render_table.cpp: (RenderTableCell::getAbsoluteRepaintRect):
  • khtml/rendering/render_table.h:
2:07 PM Changeset in webkit [5680] by hyatt
  • 2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

2:04 PM Changeset in webkit [5679]
  • 1 copy
    129 deletes in branches/unlabeled-1.25.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.25.4'.

2:04 PM Changeset in webkit [5678] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3495748, hang in parser at ocelot.ca. <nobr> needs to have very high priority (equal to the
priority of blocks like h1-6, p, and div), so that unclosed <nobr>s will close divs and ps.

Reviewed by gramps

  • khtml/html/dtd.cpp:
12:58 PM Changeset in webkit [5677] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3475767, hang at saabnet.com. Fix h1-h6 to be more tolerant regarding allowed child elements, to avoid
deeply nested pages.

Reviewed by darin

  • khtml/html/dtd.cpp: (DOM::checkChild):
12:50 PM Changeset in webkit [5676]
  • 1 copy
    377 deletes in branches/unlabeled-1.58.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.58.4'.

12:50 PM Changeset in webkit [5675] by sullivan
  • 2 edits in trunk/WebCore
  • fixed these two design issues after Dave and I talked to HI: <rdar://problem/3497072>: There shouldn't be a focus ring around clicked regions <rdar://problem/3499315>: Focus ring should use aqua color always

Reviewed by Dave.

  • khtml/css/html4.css:
11:46 AM Changeset in webkit [5674]
  • 1 copy
    77 deletes in branches/unlabeled-1.40.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.40.4'.

11:46 AM Changeset in webkit [5673]
  • 1 copy
    107 deletes in branches/unlabeled-1.20.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.20.4'.

11:46 AM Changeset in webkit [5672] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3395759>: results of parent.document.getElementsByTagName can't be added to string

  • khtml/ecma/kjs_dom.cpp: (DOMNodeList::toPrimitive): Always convert to string instead of trying to convert to number and failing, as is done for DOMNode.
  • khtml/ecma/kjs_dom.h: Prototype new method.

Dec 2, 2003:

5:21 PM Changeset in webkit [5671] by rjw
  • 15 edits
    2 adds in trunk

WebCore:

Return a value that is backed by RuntimeObjectImpl, instead
of a DOM object for applet[0]. This is better than having
the DOM object redirect to the RuntimeObjectImpl.

Reviewed by Chris.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):

JavaScriptCore:

Added support for calling simple methods in Java from JavaScript.
(void return and no parameters). Yay, LiveConnect lives.

Still need write argument and return value conversion code.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_instance.cpp: (JavaInstance::getClass): (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod): (JavaMethod::signature): (JavaMethod::JNIReturnType):
  • bindings/jni/jni_runtime.h: (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::_commonCopy): (Bindings::JavaMethod::name):
  • bindings/jni/jni_utility.cpp: (signatureFromPrimitiveType):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: Added. (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::~RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::implementsCall): (RuntimeMethodImp::call): (RuntimeMethodImp::codeType): (RuntimeMethodImp::execute):
  • bindings/runtime_method.h: Added.
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get):
  • bindings/runtime_object.h:
  • kjs/function.cpp: (FunctionImp::FunctionImp):
  • kjs/interpreter.h:
5:09 PM Changeset in webkit [5670]
  • 1 copy
    64 deletes in branches/unlabeled-1.97.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.97.4'.

5:09 PM Changeset in webkit [5669] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3488220>: namespaces test from David Faure causes Safari to crash in DOM::DocumentImpl::createElementNS

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): Check if new element is NULL before messing with it, to avoid a crash.
3:19 PM Changeset in webkit [5668]
  • 1 copy
    93 deletes in branches/unlabeled-1.83.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.83.4'.

3:19 PM Changeset in webkit [5667] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3497999, null check the text() of RenderTexts to avoid a crash in current().

Reviewed by kocienda

  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::current):
3:13 PM Changeset in webkit [5666]
  • 1 copy
    126 deletes in branches/unlabeled-1.9.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.9.4'.

3:13 PM Changeset in webkit [5665]
  • 1 copy
    556 deletes in branches/unlabeled-1.7.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.7.4'.

3:13 PM Changeset in webkit [5664]
  • 1 copy
    151 deletes in branches/unlabeled-1.46.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.46.4'.

3:13 PM Changeset in webkit [5663]
  • 1 copy
    629 deletes in branches/unlabeled-1.4.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.4.4'.

3:13 PM Changeset in webkit [5662]
  • 1 copy
    94 deletes in branches/unlabeled-1.28.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.28.4'.

3:13 PM Changeset in webkit [5661]
  • 1 copy
    115 deletes in branches/unlabeled-1.26.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.26.4'.

3:13 PM Changeset in webkit [5660]
  • 1 copy
    129 deletes in branches/unlabeled-1.24.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.24.4'.

3:13 PM Changeset in webkit [5659]
  • 1 copy
    498 deletes in branches/unlabeled-1.12.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.12.4'.

3:13 PM Changeset in webkit [5658]
  • 1 copy
    64 deletes in branches/unlabeled-1.11.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.11.4'.

3:13 PM Changeset in webkit [5657]
  • 1 copy
    115 deletes in branches/unlabeled-1.10.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.10.4'.

3:13 PM Changeset in webkit [5656] by mjs
  • 15 edits in trunk/WebCore

Reviewed by Darin.

Implemented a simple form of document serialization, enough to take care of:

<rdar://problem/3487190>: implement send of DOMDocument for XMLHttpRequest

  • khtml/dom/dom_doc.cpp: (DOM::Document::toString):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::urlMatchesDocumentDomain): (KJS::XMLHttpRequestProtoFunc::tryCall):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::toString):
  • khtml/html/html_elementimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::toString): (DocumentFragmentImpl::toString): (DocumentTypeImpl::copyFrom): (DocumentTypeImpl::toString):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::openTagStartToString): (ElementImpl::toString):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CommentImpl::toString): (TextImpl::toString): (CDATASectionImpl::toString):
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_xmlimpl.cpp: (EntityImpl::toString): (EntityReferenceImpl::toString): (ProcessingInstructionImpl::setStyleSheet): (ProcessingInstructionImpl::toString):
  • khtml/xml/dom_xmlimpl.h:
2:54 PM Changeset in webkit [5655]
  • 1 copy
    123 deletes in branches/unlabeled-1.116.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.116.4'.

2:54 PM Changeset in webkit [5654] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3493677, containingBlock() null because we tried to support position:relative on table rows. Fix
is to disallow this.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
2:25 PM Changeset in webkit [5653] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3493697, nil-deref in bidi code. Need to null-check strings with no length.

Reviewed by john

  • khtml/rendering/bidi.cpp: (khtml::addRun):
2:06 PM Changeset in webkit [5652]
  • 1 copy
    93 deletes in branches/unlabeled-1.101.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.101.4'.

2:06 PM Changeset in webkit [5651] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3495746, nil deref of containing block (frame inside frameset).

Reviewed by kocienda

  • khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth):
11:58 AM Changeset in webkit [5650] by cblu
  • 2 edits in trunk/WebKit

Fixed:
<rdar://problem/3439222>: always hangs opening plain text file on a particular machine due to missing font, no UI to detect
<rdar://problem/3492983>: Certain fonts cause Safari to hang on text/plain pages

Reviewed by rjw.

  • WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Use [[WebTextRendererFactory sharedFactory] fontWithFamilies:traits:size:] to get the font since it takes the font family which is what we store in WebPreferences and it does fallback work. Only set the font if non-nil is returned.
11:48 AM Changeset in webkit [5649] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

  • kwq/KWQRect.h:
  • kwq/KWQRect.mm: (QRect::bottomRight): Added helper.
8:04 AM Changeset in webkit [5648] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed 3493799: JavaScript string.replace expands $ if it's the last character in replacement string
  • kjs/ustring.cpp: (KJS::UString::toDouble): Fix backwards handling of the "tolerant" boolean. This indirectly caused the string.replace bug.
3:00 AM Changeset in webkit [5647]
  • 1 copy
    113 deletes in branches/unlabeled-1.96.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.96.4'.

3:00 AM Changeset in webkit [5646] by mjs
  • 2 edits in trunk/WebCore

Merged the following patch from David Faure to fix:

<rdar://problem/3497663>: Can't look up frames by number using windw[i] notation

2003-11-25 David Faure <​faure@kde.org>

  • ecma/kjs_window.cpp: Implement hasProperty and get for frames by number in Window, to fix window[0] and parent[1] etc. (#56983)
2:11 AM Changeset in webkit [5645] by mjs
  • 5 edits in trunk/JavaScriptCore

Merged patches from Harri Porten and David Faure to fix:

<rdar://problem/3497643>: reproducible crash printing self-referential array

  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): Break out of the loop if an exception was thrown.
  • kjs/nodes.cpp: (FunctionCallNode::evaluate): Move function call depth check from here...
  • kjs/object.cpp: (KJS::Object::call): ...to here.
  • kjs/object.h: Un-inline Object::call now that it does more.

Dec 1, 2003:

3:11 PM Changeset in webkit [5644] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed mistake in method signatures used to get boolean and integer fields.

Reviewed by Chris.

  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance):
2:53 PM Changeset in webkit [5643] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): Let WebCore know about redirects.
2:52 PM Changeset in webkit [5642]
  • 1 copy
    529 deletes in branches/unlabeled-1.5.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.5.4'.

2:52 PM Changeset in webkit [5641] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::open): Refuse to start if the URL is not one this document is allowed to access. (KJS::XMLHttpRequest::slotRedirection): Stop the job if we redirect to a URL the home document is not allowed to access.
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader redirectedToURL:]): emit the right signal
  • kwq/WebCoreResourceLoader.h: Prototype new method
2:44 PM Changeset in webkit [5640]
  • 1 copy
    76 deletes in branches/unlabeled-1.31.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.31.4'.

2:44 PM Changeset in webkit [5639]
  • 1 copy
    411 deletes in branches/unlabeled-1.13.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.13.4'.

2:44 PM Changeset in webkit [5638] by rjw
  • 16 edits in trunk

WebKit:

Moved grungy polling code from WebKit to the JavaPlugin.

Reviewed by Chris.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pollForAppletInView:]):

WebCore:
Fixed parameter passing to applet. Child elements are NOT valid in setStyle(). So we now either create the widget before needed with createWidgetIfNecessary. This either happens when doing the first layout, or when JavaScript first references the applet element.

Fixed early delete of the the main applet instance. When the JS collector cleaned up the last JS object referring to the applet instance we were deleting the java instance. This caused the applet instance cached on the applet element to be invalid. The applet instance is the only Java object not to be cleaned up by the JS collector.

Added support for getting at Java object fields.

Reviewed by Chris.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary): (RenderApplet::layout):
  • khtml/rendering/render_applet.h: (khtml::RenderApplet::renderName):

JavaScriptCore:
Fixed parameter passing to applet. Child elements are NOT valid in setStyle(). So we now create the widget before needed with createWidgetIfNecessary. This either happens when doing the first layout, or when JavaScript first references the applet element.

Fixed early delete of the the main applet instance. When the JS collector cleaned up the last JS object referring to the applet instance we were deleting the java instance. This caused the applet instance cached on the applet element to be invalid. The applet instance is the only Java object not to be cleaned up by the JS collector.

Added support for getting at Java object fields.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/jni/jni_instance.cpp: (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h: (Bindings::JObjectWrapper::~JObjectWrapper):
  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::deleteProperty):
  • bindings/runtime_object.h:
1:33 PM Changeset in webkit [5637]
  • 1 copy
    330 deletes in branches/unlabeled-1.197.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.197.4'.

1:33 PM Changeset in webkit [5636] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3496960: nil-deref in idFromNode inside elementDoesAutoComplete:
  • kwq/WebCoreBridge.mm: (inputElementFromDOMElement): Added nil check. (formElementFromDOMElement): Added nil check.
11:22 AM Changeset in webkit [5635] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3490959, collapsed border tables don't paint backgrounds.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::paint): (RenderTable::paintBoxDecorations):
  • khtml/rendering/render_table.h:
11:18 AM Changeset in webkit [5634] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3493939: ordered lists with type="A" roll over to A' after X rather than after Z
  • khtml/rendering/render_list.cpp: (toLetter): Change 24 to 26.
11:05 AM Changeset in webkit [5633] by kocienda
  • 4 edits in trunk/WebKit

WebKit:

Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

  • Misc.subproj/WebNSEventExtras.h: Add declarations for new key event helpers.
  • Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isKeyEvent:]): Added. (-[NSEvent _web_isDeleteKeyEvent]): Added. (-[NSEvent _web_isEscapeKeyEvent]): Added. (-[NSEvent _web_isOptionTabKeyEvent]): Added. (-[NSEvent _web_isReturnOrEnterKeyEvent]): Added. (-[NSEvent _web_isTabKeyEvent]): Added.
  • WebKit.pbproj/project.pbxproj: Made WebNSEventExtras.h a private header so WebBrowser can use the new helpers.

WebBrowser:

Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

  • BookmarksViewController.m: (-[BookmarksViewController handleKeyDown:inSourceColumn:]): Move to new key event helper.
  • BrowserNSEventExtras.h: Remove key event helpers from here. WebBrowser will now pick these up from WebKit.
  • BrowserNSEventExtras.m: Ditto.
  • BrowserWindowController.m: Move to new key event helpers. (-[BrowserWindowController cancel:]): Ditto. (-[BrowserWindowController windowWillHandleKeyEvent:]): Ditto. (-[BrowserWindowController performQuickSearch:]): Ditto.
  • DownloadViewController.m: (-[DownloadViewController keyDown:]): Ditto.
  • Preferences.subproj/SheetWithTableController.m: (-[SheetWithTableController tableView:keyDown:]): Ditto.
  • TitleBarButton.m: Ditto.
Note: See TracTimeline for information about the timeline view.