Timeline



Dec 8, 2003:

10:58 PM Changeset in webkit [5724] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3503652, news.com misrenders badly (footer is out of position). My fix to 3495748 caused this
regression. I made the tag priority of <nobr> too high. It needed to be the same as <div>, and I
accidentally made it higher. I intended for it to be the same as <div>.

I also had to make a fix (now that <nobr> has a higher priority) to ensure <nobr> can't be nested inside
other <nobr>.

Both fixes were required to make news.com render correctly again.

Reviewed by darin

  • khtml/html/dtd.cpp:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
6:12 PM Changeset in webkit [5723] by cblu
  • 15 edits
    6 adds
    4 deletes in trunk

WebCore:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::parseAttribute): store the KEYTYPE attribute (HTMLKeygenElementImpl::encoding): call KSSLKeyGen::signedPublicKeyAndChallengeString
  • khtml/html/html_formimpl.h: remove 2 declared but unimplemented methods
  • khtml/misc/htmlattrs.c: generated changes (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h: generated change
  • khtml/misc/htmlattrs.in: added KEYTYPE
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::supportedKeySizes): call renamed strengthMenuItemTitles (KSSLKeyGen::signedPublicKeyAndChallengeString): new, calls [WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]
  • kwq/WebCoreKeyGenerationFactory.h: Added.
  • kwq/WebCoreKeyGenerationFactory.m: Added. (+[WebCoreKeyGenerationFactory sharedFactory]): (-[WebCoreKeyGenerationFactory init]): (-[WebCoreKeyGenerationFactory strengthMenuItemTitles]): (-[WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]):
  • kwq/WebCoreLocalizedStringFactory.h: Removed.
  • kwq/WebCoreLocalizedStringFactory.m: Removed.

WebKit:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: Added. (gnrAddContextAttribute): new (gnrGetSubjPubKey): new (gnrNullAlgParams): new (gnrSign): new (gnrFreeCssmData): new (signedPublicKeyAndChallengeString): new
  • WebCoreSupport.subproj/WebKeyGeneration.h: Added.
  • WebCoreSupport.subproj/WebKeyGenerationFactory.h: Added. Renamed from WebLocalizedStringFactory.
  • WebCoreSupport.subproj/WebKeyGenerationFactory.m: Added. (+[WebKeyGenerationFactory createSharedFactory]): no change (-[WebKeyGenerationFactory dealloc]): no change (-[WebKeyGenerationFactory strengthMenuItemTitles]): new (-[WebKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): new
  • WebCoreSupport.subproj/WebLocalizedStringFactory.h: Removed.
  • WebCoreSupport.subproj/WebLocalizedStringFactory.m: Removed.
  • WebCoreSupport.subproj/WebNetscapeTemplates.cpp: Added.
  • WebCoreSupport.subproj/WebNetscapeTemplates.h: Added.
  • WebKit.pbproj/project.pbxproj:
  • WebKitPrefix.h:
  • WebView.subproj/WebFrameView.m:
5:03 PM Changeset in webkit [5722] by kocienda
  • 9 edits in branches

Reviewed by me.

Some more work on getting the delete key to work.
Some work to make relayout happen correctly.
Moved edit evenit handler to HTMLElementImpl.

  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler): (HTMLElementImpl::toString):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_inlineimpl.h: (DOM::HTMLBRElementImpl::isHTMLBRElement):
  • khtml/html/htmlediting.cpp: (EditCommand::notifyChanged): (InputTextCommand::applyToDocument): (DeleteTextCommand::applyToDocument):
  • khtml/html/htmlediting.h: (khtml::EditCommand::selection): (khtml::InputTextCommand::text):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isHTMLBRElement):
5:02 PM Changeset in webkit [5721] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3504047>: XMLHttpRequest object needs onload event

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented onload property. (KJS::XMLHttpRequest::putValue): Ditto. (KJS::XMLHttpRequest::XMLHttpRequest): Ditto. (KJS::XMLHttpRequest::changeState): Ditto.
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/xmlhttprequest.lut.h: Regenerated.
4:53 PM Changeset in webkit [5720] by rjw
  • 10 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: The last piece of the JavaScript side of the
LiveConnect implementation. This change adds support for
setting/getting values from Java arrays in JavaScript.

Reviewed by John.

  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaArray::JavaArray): (JavaArray::~JavaArray): (JavaArray::setValueAt): (JavaArray::valueAt): (JavaArray::getLength):
  • bindings/jni/jni_runtime.h: (Bindings::JavaArray::operator=): (Bindings::JavaArray::javaArray):
  • bindings/jni/jni_utility.cpp: (JNITypeFromPrimitiveType): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp): (RuntimeArrayImp::~RuntimeArrayImp): (RuntimeArrayImp::get): (RuntimeArrayImp::put): (RuntimeArrayImp::hasProperty):
  • bindings/runtime_array.h: (KJS::RuntimeArrayImp::getLength): (KJS::RuntimeArrayImp::getConcreteArray):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty):

Tests:

LiveConnect: Added tests for JavaScript to Java
array access.

Reviewed by John.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:
3:51 PM Changeset in webkit [5719] by hyatt
  • 2 adds in trunk/LayoutTests/fast/text/international

Add asahi.com layout test.

3:50 PM Changeset in webkit [5718] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3503022, asahi.com is too wide. Bugs in line breaking of breakable Japanese characters caused
the breaks to be ignored.

Reviewed by john

  • khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
2:35 PM Changeset in webkit [5717] by kocienda
  • 7 edits in branches

Reviewed by me

Got some more basic text editing working, including:
Deleting selection when you start typing, and making
the delete key work to remove text.

I did some refactoring as well, moving the guts of
the application of editing commands into the command
implementation file.

  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::defaultEventHandler):
  • khtml/html/htmlediting.cpp: (InputTextCommand::commandID): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::applyToDocument): (InputTextCommand::canUndo): (DeleteTextCommand::commandID): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::applyToDocument): (DeleteTextCommand::canUndo):
  • khtml/html/htmlediting.h: (khtml::): (khtml::InputTextCommand::~InputTextCommand): (khtml::DeleteTextCommand::~DeleteTextCommand):
  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent):
  • khtml/khtmlview.cpp: (KHTMLView::caretOverrides):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyEditing):
11:44 AM Changeset in webkit [5716] by hyatt
  • 3 edits in trunk/WebCore

Fix the position method to return screen coords like it should and to use the lower left corner instead of
the upper left.

Reviewed by john

  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject position]): (-[KWQAccObject size]):
9:43 AM Changeset in webkit [5715] by kocienda
  • 3 edits in branches

Reviewed by me

A couple of tweaks to make caret drawing work a little
better. Now the caret does not paint when you click on
a link, and the "leftover" pixel is gone from the
caret blink.

  • khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::placeCaret):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):
8:45 AM Changeset in webkit [5714] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • fixed 3502347: REGRESSION (100-116): bottom of login window sometimes missing (TR background image)
  • khtml/rendering/render_object.h: Added setPixmap.
  • khtml/rendering/render_object.cpp: (RenderObject::setPixmap): Moved this function here from RenderBox. This code is needed for the table row class and similar classes that supply a background image that is drawn by the table cell, and those are not RenderBox subclasses.
  • khtml/rendering/render_box.cpp: Removed setPixmap.
  • khtml/rendering/render_box.h: Removed setPixmap.

Dec 7, 2003:

10:04 PM Changeset in webkit [5713] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3502655>: REGRESSION: Repro crash at espn.com

Reviewed by Darin.

  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Check for nil RenderApplet before dereferencing rather than after.

Dec 6, 2003:

9:27 AM Changeset in webkit [5712] by kocienda
  • 2 edits in branches

Reviewed by me

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Fixed a dumb crasher in a debug printf.

Dec 5, 2003:

3:22 PM Changeset in webkit [5711] by hyatt
  • 2 edits in trunk/WebCore

Add support for link clicking as an accessibility action.

Reviewed by john

  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]):
3:05 PM Changeset in webkit [5710] by rjw
  • 6 edits
    2 adds in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Part 1 of supporting JS bindings to
native language arrays.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bindings/jni/jni_runtime.h:
  • bindings/runtime.cpp: (Instance::setValueOfField):
  • bindings/runtime.h: (Bindings::Array::~Array):

Tests:

Added tests to access Java arrays.

Reviewed by Chris.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:
2:03 PM Changeset in webkit [5709] by mjs
  • 21 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487222>: Add ability to create working fully standalone document object

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::addSheet): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::applyRule):
  • khtml/dom/dom_doc.cpp: (DOM::Document::part):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (KJS::checkNodeSecurity):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::tryGet): (KJS::HTMLDocument::putValue): (KJS::HTMLElement::tryGet): (Image::notifyFinished):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): (HTMLDocumentImpl::lastModified):
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): (HTMLFormElementImpl::prepareSubmit): (HTMLFormElementImpl::submit): (HTMLFormElementImpl::reset): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::defaultEventHandler):
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isKeyboardFocusable): (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptExecution): (HTMLTokenizer::parseTag):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): (DocumentImpl::part): (DocumentImpl::close): (DocumentImpl::processHttpEquiv):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::partForNode): (KWQKHTMLPart::attributedString):
2:00 PM Changeset in webkit [5708] by rjw
  • 2 edits in trunk/WebCore

Fixed 3501885. Added null test to returned node from collection.

Reviewed by John.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):
10:06 AM Changeset in webkit [5707] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3491427>: REGRESSION (100-114): multi-page HTML content in Mail is blank when printed

Darin and I figured this one out.

Reviewed by Ken.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): Don't call setNeedsDisplay:NO when we're turning printing on, as doing so prevents anything from drawing in the case where this is called from adjustPageHeightsNew:top:bottom:limit
8:52 AM Changeset in webkit [5706] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed regression in small caps with substituted fonts my patch from yesterday caused
  • fixed 3463599: if Lucida font is installed, you see bad glyphs on pages that use it (advogato.org)
  • fixed storage leak if a renderer is ever deallocated (I don't think we ever do that)
  • fixed some small leaks in various error cases by adding appropriate free and dispose calls
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer dealloc]): Free the Unicode glyph map too. (fontContainsString): Moved inline function up here so it will be inlined. (-[WebTextRenderer _setupFont]): Free the glyph map and set it back to zero if we fail after extending the glyph map to include space. This fixes the "wrong glyph codes" bug with Lucida above. (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): Add free calls needed to avoid storage leaks in failure cases. (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Ditto. (-[WebTextRenderer _initializeATSUStyle]): Add ATSUDisposeStyle to fix storage leak. (freeWidthMap): Use a loop instead of recursion. (freeGlyphMap): Use a loop instead of recursion. (freeUnicodeGlyphMap): Added. (widthForNextCharacter): Don't use the original characters or cluster length, because the character may have been capitalized for use in small caps rendering. So check the character for <= 0xFFFF instead of looking at clusterLength, and break the character into a local array instead of using the original character pointer.

Dec 4, 2003:

9:09 PM Changeset in webkit [5705] by kocienda
  • 4 edits in branches

Reviewed by me

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Fixed some formatting. By calling new isEditingAtSelection() helper, fixed crasher caused by checking if we're editing and the selection has been cleared. (KHTMLPart::isEditingAtSelection): New helper.
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::placeCaret): Don't focus if not editing.
5:53 PM Changeset in webkit [5704] by kocienda
  • 1 edit
    2 adds in branches

2003-12-04 Ken Kocienda <​kocienda@apple.com>

Reviewed by me

  • khtml/html/htmlediting.cpp: Added.
  • khtml/html/htmlediting.h: Added.
5:53 PM Changeset in webkit [5703]
  • 16 copies
    341 deletes in branches/HTML-editing-hacks-branch

This commit was manufactured by cvs2svn to create branch
'HTML-editing-hacks-branch'.

5:27 PM Changeset in webkit [5702] by darin
  • 4 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3497879: REGRESSION (100-115): all non-BMP characters (including Deseret) are broken
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]): Bump offset by getting it from the iterator; don't assume we can just bump it by one each time. It would be even nicer to have a bit more abstraction. (initializeCharacterWidthIterator): Remove call to initializeCharacterShapeIterator. (widthForNextCharacter): Move handling of surrogate pairs (non-BMP) in here and unify it with the handling of BMP characters; this removes the broken code that was returning the wrong font, and changes us to use the code that was already doing the right thing for the surrogate pair case. Also get rid of the use of 0 width to mean "no glyph", which fixes the doubled glyph problem. Also got rid of remnants of use of the shape iterator.
  • Misc.subproj/WebUnicode.h: Remove obsolete shape iterator.
  • Misc.subproj/WebUnicode.m: Ditto.
5:05 PM Changeset in webkit [5701] by rjw
  • 7 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Moved defaultValue into concrete implementation because
more intelligent conversion can be perform with knowledge
of the class of the original instance.

Reviewed by Chris.

  • bindings/jni/jni_class.cpp: (JavaClass::isNumberClass): (JavaClass::isBooleanClass): (JavaClass::isStringClass):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::defaultValue): (JavaInstance::valueOf):
  • bindings/jni/jni_instance.h: (Bindings::JavaInstance::javaInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::defaultValue):

Tests:

Fixed incorrect log of boolean type.

Reviewed by Chris.

  • LiveConnect/Blink/test.html:
4:55 PM Changeset in webkit [5700]
  • 30 copies
    2 deletes in tags/WebCore-106~3

This commit was manufactured by cvs2svn to create tag
'WebCore-106~3'.

4:55 PM Changeset in webkit [5699] by mjs
  • 2 edits in branches/SUPanBisque-branch/WebCore

WebCore 106.3

4:30 PM Changeset in webkit [5698] by kocienda
  • 34 edits in branches

Reviewed by me

A large set of change to get a blinking caret
and a little bit of text input limping along.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/dom_node.cpp: (Node::getCursor):
  • khtml/dom/dom_node.h:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLDivElementImpl::defaultEventHandler):
  • khtml/html/html_blockimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::hasSelection): (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::caretNode): (KHTMLPart::caretOffset): (KHTMLPart::isPointInsideSelection): (KHTMLPart::khtmlMousePressEvent): (isBeforeNode): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::topLevelFrameCount): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (CaretViewContext::CaretViewContext): (EditorContext::EditorContext): (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::caretViewContext): (KHTMLViewPrivate::editorContext): (khtml::ensureLeafNode): (khtml::findRenderer): (khtml::sanitizeCaretState): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::drawContents): (KHTMLView::layout): (KHTMLView::keyPressEvent): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::ensureNodeHasFocus): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::caretOn): (KHTMLView::caretOff): (KHTMLView::showCaret): (KHTMLView::paintCaret): (KHTMLView::foldSelectionToCaret): (KHTMLView::hideCaret): (KHTMLView::placeCaret): (KHTMLView::moveCaretTo):
  • khtml/khtmlview.h:
  • khtml/rendering/render_box.cpp: (RenderBox::caretPos):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_br.h: (khtml::RenderBR::isBR): (khtml::RenderBR::caretMinOffset): (khtml::RenderBR::caretMaxOffset):
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretPos):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_line.h: (khtml::InlineBox::caretMinOffset): (khtml::InlineBox::caretMaxOffset):
  • khtml/rendering/render_object.cpp: (RenderObject::caretPos): (RenderObject::isEditable):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFlow): (khtml::RenderObject::caretMinOffset): (khtml::RenderObject::caretMaxOffset):
  • khtml/rendering/render_replaced.h: (khtml::RenderReplaced::caretMinOffset): (khtml::RenderReplaced::caretMaxOffset):
  • khtml/rendering/render_text.cpp: (InlineTextBox::caretMinOffset): (InlineTextBox::caretMaxOffset): (RenderText::caretPos): (RenderText::htmlFont): (RenderText::caretMinOffset): (RenderText::caretMaxOffset):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::hasWindowEventListener): (DocumentImpl::applyEditing):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isContentEditable): (NodeImpl::getCaret): (NodeImpl::prevLeafNode): (NodeImpl::nextLeafNode): (NodeImpl::createRenderer): (NodeImpl::caretMinOffset): (NodeImpl::caretMaxOffset):
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::caretMinOffset): (CharacterDataImpl::caretMaxOffset):
  • khtml/xml/dom_textimpl.h:
  • kwq/KWQKDebug.h: (kdbgstream::operator<<):
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged): (KWQKHTMLPart::paint):
  • kwq/KWQLogging.h:
  • kwq/KWQLogging.m:
  • kwq/KWQWidget.h: (QWidget::focusInEvent):
4:28 PM Changeset in webkit [5697] by rjw
  • 9 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Added support for setting the value of Java
fields.

Reviewed by Chris.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod):
  • bindings/jni/jni_runtime.h: (Bindings::JavaField::getJNIType):
  • bindings/jni/jni_utility.cpp: (JNITypeFromClassName): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.cpp: (Instance::setValueOfField):
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::defaultValue):

Tests:

Added test of setting Java fields from JavaScript.

Reviewed by Chris.

  • LiveConnect/Blink/Holder.java: (Holder):
  • LiveConnect/Blink/test.html:
2:33 PM Changeset in webkit [5696] by rjw
  • 16 edits in trunk

WebCore:

Added support for named applet access from document node.
Factored creation of KJS::Values from RuntimeObjectImps.

Reviewed by Chris.

  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMNamedNodeMap): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet):

JavaScriptCore:

Added support for string conversions.
Changed various JavaString member variables to be inline.
Implemented defaultValue for context relevant type coercion.

Reviewed by Chris.

  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::setClassName): (JavaClass::classForInstance):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (appendClassName): (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString): (Bindings::JavaString::~JavaString): (Bindings::JavaString::operator=): (Bindings::JavaString::characters): (Bindings::JavaParameter::JavaParameter): (Bindings::JavaParameter::~JavaParameter): (Bindings::JavaParameter::operator=): (Bindings::JavaParameter::type): (Bindings::JavaField::JavaField): (Bindings::JavaField::~JavaField): (Bindings::JavaField::operator=): (Bindings::JavaField::name): (Bindings::JavaField::type): (Bindings::JavaMethod::JavaMethod): (Bindings::JavaMethod::_commonDelete): (Bindings::JavaMethod::name): (Bindings::JavaMethod::returnType):
  • bindings/jni/jni_utility.cpp: (convertValueToJValue):
  • bindings/runtime.h: (Bindings::Instance::valueOf):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::call):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::classInfo):

Tests:

Added tests passing various parameters type to Java methods.

Reviewed by Chris.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.setTextWithString): (Blink.setTextWithNumberValueUsingByte): (Blink.setTextWithNumberValueUsingShort): (Blink.setTextWithNumberValueUsingInt): (Blink.setTextWithNumberValueUsingLong): (Blink.setTextWithNumberValueUsingFloat): (Blink.setTextWithNumberValueUsingDouble): (Blink.setTextWithNumberValueUsingChar): (Blink.setTextWithNumberValueUsingBoolean):
  • LiveConnect/Blink/Blink.pbproj/project.pbxproj:
  • LiveConnect/Blink/test.html:
  • PDFBundle/PDFBundle.pbproj/project.pbxproj:
2:28 PM Changeset in webkit [5695] by mjs
  • 3 edits in branches/SUPanBisque-branch/WebCore

Reviewed by Ken.

<rdar://problem/3500456>: JavaScript sites crash when a PAC file is in place

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add required locking. (KJS::getDOMEvent): Ditto.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Ditto. (KJSProxyImpl::createHTMLEventHandler): Ditto. (KJSProxyImpl::initScript): Ditto.
11:45 AM Changeset in webkit [5694] by darin
  • 9 edits in trunk/WebCore

Reviewed by John.

This was an uncaught exception thrown by DocumentImpl. But the design of KHTML DOM is that
"impl" classes return exception codes; they don't throw exceptions.

  • khtml/dom/dom_doc.cpp: (DOM::Document::createElement): Throw exception if necessary. The impl function now returns an exception code. (DOM::Document::createElementNS): Ditto.
  • khtml/html/html_documentimpl.h: Add exception code parameter to createElement.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createElement): Pass along the exception code from the lower level.
  • khtml/xml/dom_docimpl.h: Add exception code parameters to createElement, createElementNS, and createHTMLElement.
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Handle exception code from createElementNS. (DocumentImpl::createElement): Add exception code parameter, not set since there is no exception. (DocumentImpl::importNode): Handle exception code from createElementNS. (DocumentImpl::createElementNS): Add exception code parameter. Propagate the exception codes that we get from createHTMLElement and setPrefix. (DocumentImpl::createHTMLElement): Add exception code parameter. Use an exception code rather than a C++ exception for INVALID_CHARACTER_ERR.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Pass exception code parameter to createElement.
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): Pass exception code parameter to createElementNS, and return false if it is not zero. This is where the bug happened. Before we would get an exception from createElementNS, but "impl" functions are not supposed to throw in KHTML's DOM. (XMLTokenizer::finish): Add various exception code parameters to compile, but we know we won't get any exceptions.
  • kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument createElement:]): Pass an (ignored) exception code parameter. (-[WebCoreDOMDocument createElementNS::]): Pass an (ignored) exception code parameter.
11:01 AM Changeset in webkit [5693] by vicki
  • 3 edits in trunk

the tree is open for Safari-117

10:57 AM Changeset in webkit [5692]
  • 3 copies in tags/Safari-116

This commit was manufactured by cvs2svn to create tag 'Safari-116'.

10:57 AM Changeset in webkit [5691] by vicki
  • 9 edits in trunk

Safari-116, Safari 1.2 stamp

8:28 AM Changeset in webkit [5690] by darin
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • fixed 3498426: assertion failure in tooltip code at macosx.apple.com
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setToolTip:]): Work around the apparent bug in AppKit (3500217) that causes it to return 0 for the tool tip tag by using removeAllToolTips and not storing the tag at all. Besides the assertion failure there may also be a symptom of a "stuck" tool tip and a small memory leak until the window is closed.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove unused toolTipTag.
Note: See TracTimeline for information about the timeline view.