⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 9, 2003:

8:09 PM Changeset in webkit [5741] by mjs
  • 7 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487195>: Implement responseXML property for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented responseXML by parsing the document and returning it. (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new field
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/kjs_window.cpp: (Windw::get): Forgot this in last commit; add XMLSerializer constructor.
  • khtml/ecma/kjs_window.lut.h:
  • khtml/ecma/Makefile.am: Forgot to include this in the last commit.
8:05 PM Changeset in webkit [5740] by mjs
  • 5 edits
    3 adds in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3504049>: XMLSerializer object and serializeToString method needed for XMLHttpRequest testing

Also fixed some lasst-minute mistakes in the DOM serialization
code that was already there.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/dom_doc.h:
  • khtml/ecma/Makefile.am:
  • khtml/ecma/kjs_window.cpp: (Window::get):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/ecma/xmlserializer.cpp: Added. (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): (KJS::XMLSerializerConstructorImp::implementsConstruct): (KJS::XMLSerializerConstructorImp::construct): (KJS::): (KJS::XMLSerializer::XMLSerializer): (KJS::XMLSerializerProtoFunc::tryCall):
  • khtml/ecma/xmlserializer.h: Added. (KJS::XMLSerializer::toBoolean): (KJS::XMLSerializer::classInfo): (KJS::XMLSerializer::):
  • khtml/ecma/xmlserializer.lut.h: Added. (KJS::):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::toString): (DocumentFragmentImpl::toString):
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::toString):
5:23 PM Changeset in webkit [5739] by hyatt
  • 4 edits in trunk/WebCore

Implement start() and stop() for marquees.

Reviewed by darin

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::classInfo): (KJS::HTMLElementFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
5:05 PM Changeset in webkit [5738] by rjw
  • 3 edits
    2 adds in trunk/JavaScriptCore

LiveConnect stubs that correspond to the native methods
on JSObject. These will be called from the new Java plugin
when an instance of JSObject is instantiated and messaged.
When these are implemented the Java will be able to originate
calls into JavaScript.

Also a temporary work-around added to Makefile.am to solve
a link problem. The 1.4.2 JavaVM accidentally links against
libobjc. This call a failure linking testkjs. Mike Hay is
working with someone to fix the problem (3505587).

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/jni_jsobject.cpp: Added. (KJS_JSCreateNativeJSObject): (KJS_JSObject_JSFinalize): (KJS_JSObject_JSObjectCall): (KJS_JSObject_JSObjectEval): (KJS_JSObject_JSObjectGetMember): (KJS_JSObject_JSObjectSetMember): (KJS_JSObject_JSObjectRemoveMember): (KJS_JSObject_JSObjectGetSlot): (KJS_JSObject_JSObjectSetSlot): (KJS_JSObject_JSObjectToString):
  • bindings/jni_jsobject.h: Added.
4:53 PM Changeset in webkit [5737] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3505277: nil-deref in ownerElement after choosing item from menu at projectnissan.com
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Add check for nil.
4:46 PM Changeset in webkit [5736] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveLocationProperties): Add locking around the call to get the location since it can allocate. (KWQKHTMLPart::restoreLocationProperties): Ditto.
4:29 PM Changeset in webkit [5735] by hyatt
  • 2 edits in trunk/WebCore

Fix for mojibake bg painting problem on bofa.com. The bug # is 3487144. Transparent colors were not
being handled properly when specified on the body.

Reviewed by darin

  • khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):
3:39 PM Changeset in webkit [5734] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3505391: REGRESSION (100-116): pages that move cells around don't repaint correctly
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): Added code similar to the code in RenderBlock::layoutBlock, but for table cells.
3:38 PM Changeset in webkit [5733] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add locking around the call to push event handler scope. Without this, we hit the "allocated without locking" assertion.
3:15 PM Changeset in webkit [5732] by hyatt
  • 5 edits in trunk/WebCore

Fix the dirty rect checks on various render_objects to be more accurate so that page-break properties don't
have mojibake when printing.

Reviewed by john

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
  • khtml/rendering/render_table.cpp: (RenderTable::paint):
3:01 PM Changeset in webkit [5731] by darin
  • 5 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3500408: Web Kit should pass the MAYSCRIPT attribute from the APPLET tag to the Java plug-in
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): Allow the "mayscript" attribute. (HTMLAppletElementImpl::createRenderer): Pass the value of the "mayscript" attribute as an argument named "mayScript".
  • khtml/misc/htmlattrs.in: Added "mayscript".
  • khtml/misc/htmlattrs.c: Regenerated.
  • khtml/misc/htmlattrs.h: Regenerated.
2:26 PM Changeset in webkit [5730] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

<rdar://problem/3505183>: JavaScriptCore should assert that interpreter is locked in collector

  • kjs/collector.cpp: (KJS::Collector::allocate): Assert that interpreter lock count is not 0. (KJS::Collector::collect): likewise
2:26 PM Changeset in webkit [5729] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3501030>: JavaScript sites crash when a PAC file is in place (WebCore,Safari 1.2)

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Lock interpreter when needed. (JSLazyEventListener::parseCode): Likewise. (KJS::getDOMEvent): Likewise.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Likewise. (KJSProxyImpl::initScript): Likewise.
2:11 PM Changeset in webkit [5728] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3491235, really make <script src="..."/> work in HTML. My original attempt to fix this only made
the tag flat, but did not ensure that the script got processed.

Reviewed by john

  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
1:52 PM Changeset in webkit [5727] by cblu
  • 7 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): (addCertificateToKeyChainFromData): new (addCertificateToKeyChainFromFile): new
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator addCertificateToKeyChainFromFileAtPath:]): new
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj: made WebKeyGenerator.h private

WebBrowser:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): new, calls [WebKeyGenerator addCertificateToKeyChainFromFileAtPath:] (-[DownloadProgressEntry autoOpen]): call _addCertificateToKeyChain
1:23 PM Changeset in webkit [5726] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3504907>: REGRESSION (100-116): Clicking QuickTime-requiring link twice crashes (wholenote.com)

I found the bug; Darin wrote the fix; I reviewed and tested.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): Rewrote this method to not use GetIndString, because GetIndString looks at all open resource files and in this case was reading information from the wrong plugin file.
11:56 AM Changeset in webkit [5725] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Adding a dynamic cell array test.

Dec 8, 2003:

10:58 PM Changeset in webkit [5724] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3503652, news.com misrenders badly (footer is out of position). My fix to 3495748 caused this
regression. I made the tag priority of <nobr> too high. It needed to be the same as <div>, and I
accidentally made it higher. I intended for it to be the same as <div>.

I also had to make a fix (now that <nobr> has a higher priority) to ensure <nobr> can't be nested inside
other <nobr>.

Both fixes were required to make news.com render correctly again.

Reviewed by darin

  • khtml/html/dtd.cpp:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
6:12 PM Changeset in webkit [5723] by cblu
  • 15 edits
    6 adds
    4 deletes in trunk

WebCore:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::parseAttribute): store the KEYTYPE attribute (HTMLKeygenElementImpl::encoding): call KSSLKeyGen::signedPublicKeyAndChallengeString
  • khtml/html/html_formimpl.h: remove 2 declared but unimplemented methods
  • khtml/misc/htmlattrs.c: generated changes (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h: generated change
  • khtml/misc/htmlattrs.in: added KEYTYPE
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::supportedKeySizes): call renamed strengthMenuItemTitles (KSSLKeyGen::signedPublicKeyAndChallengeString): new, calls [WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]
  • kwq/WebCoreKeyGenerationFactory.h: Added.
  • kwq/WebCoreKeyGenerationFactory.m: Added. (+[WebCoreKeyGenerationFactory sharedFactory]): (-[WebCoreKeyGenerationFactory init]): (-[WebCoreKeyGenerationFactory strengthMenuItemTitles]): (-[WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]):
  • kwq/WebCoreLocalizedStringFactory.h: Removed.
  • kwq/WebCoreLocalizedStringFactory.m: Removed.

WebKit:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: Added. (gnrAddContextAttribute): new (gnrGetSubjPubKey): new (gnrNullAlgParams): new (gnrSign): new (gnrFreeCssmData): new (signedPublicKeyAndChallengeString): new
  • WebCoreSupport.subproj/WebKeyGeneration.h: Added.
  • WebCoreSupport.subproj/WebKeyGenerationFactory.h: Added. Renamed from WebLocalizedStringFactory.
  • WebCoreSupport.subproj/WebKeyGenerationFactory.m: Added. (+[WebKeyGenerationFactory createSharedFactory]): no change (-[WebKeyGenerationFactory dealloc]): no change (-[WebKeyGenerationFactory strengthMenuItemTitles]): new (-[WebKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): new
  • WebCoreSupport.subproj/WebLocalizedStringFactory.h: Removed.
  • WebCoreSupport.subproj/WebLocalizedStringFactory.m: Removed.
  • WebCoreSupport.subproj/WebNetscapeTemplates.cpp: Added.
  • WebCoreSupport.subproj/WebNetscapeTemplates.h: Added.
  • WebKit.pbproj/project.pbxproj:
  • WebKitPrefix.h:
  • WebView.subproj/WebFrameView.m:
5:03 PM Changeset in webkit [5722] by kocienda
  • 9 edits in branches

Reviewed by me.

Some more work on getting the delete key to work.
Some work to make relayout happen correctly.
Moved edit evenit handler to HTMLElementImpl.

  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler): (HTMLElementImpl::toString):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_inlineimpl.h: (DOM::HTMLBRElementImpl::isHTMLBRElement):
  • khtml/html/htmlediting.cpp: (EditCommand::notifyChanged): (InputTextCommand::applyToDocument): (DeleteTextCommand::applyToDocument):
  • khtml/html/htmlediting.h: (khtml::EditCommand::selection): (khtml::InputTextCommand::text):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isHTMLBRElement):
5:02 PM Changeset in webkit [5721] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3504047>: XMLHttpRequest object needs onload event

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented onload property. (KJS::XMLHttpRequest::putValue): Ditto. (KJS::XMLHttpRequest::XMLHttpRequest): Ditto. (KJS::XMLHttpRequest::changeState): Ditto.
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/xmlhttprequest.lut.h: Regenerated.
4:53 PM Changeset in webkit [5720] by rjw
  • 10 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: The last piece of the JavaScript side of the
LiveConnect implementation. This change adds support for
setting/getting values from Java arrays in JavaScript.

Reviewed by John.

  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaArray::JavaArray): (JavaArray::~JavaArray): (JavaArray::setValueAt): (JavaArray::valueAt): (JavaArray::getLength):
  • bindings/jni/jni_runtime.h: (Bindings::JavaArray::operator=): (Bindings::JavaArray::javaArray):
  • bindings/jni/jni_utility.cpp: (JNITypeFromPrimitiveType): (convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/runtime.h:
  • bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp): (RuntimeArrayImp::~RuntimeArrayImp): (RuntimeArrayImp::get): (RuntimeArrayImp::put): (RuntimeArrayImp::hasProperty):
  • bindings/runtime_array.h: (KJS::RuntimeArrayImp::getLength): (KJS::RuntimeArrayImp::getConcreteArray):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty):

Tests:

LiveConnect: Added tests for JavaScript to Java
array access.

Reviewed by John.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:
3:51 PM Changeset in webkit [5719] by hyatt
  • 2 adds in trunk/LayoutTests/fast/text/international

Add asahi.com layout test.

3:50 PM Changeset in webkit [5718] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3503022, asahi.com is too wide. Bugs in line breaking of breakable Japanese characters caused
the breaks to be ignored.

Reviewed by john

  • khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
2:35 PM Changeset in webkit [5717] by kocienda
  • 7 edits in branches

Reviewed by me

Got some more basic text editing working, including:
Deleting selection when you start typing, and making
the delete key work to remove text.

I did some refactoring as well, moving the guts of
the application of editing commands into the command
implementation file.

  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::defaultEventHandler):
  • khtml/html/htmlediting.cpp: (InputTextCommand::commandID): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::applyToDocument): (InputTextCommand::canUndo): (DeleteTextCommand::commandID): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::applyToDocument): (DeleteTextCommand::canUndo):
  • khtml/html/htmlediting.h: (khtml::): (khtml::InputTextCommand::~InputTextCommand): (khtml::DeleteTextCommand::~DeleteTextCommand):
  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent):
  • khtml/khtmlview.cpp: (KHTMLView::caretOverrides):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyEditing):
11:44 AM Changeset in webkit [5716] by hyatt
  • 3 edits in trunk/WebCore

Fix the position method to return screen coords like it should and to use the lower left corner instead of
the upper left.

Reviewed by john

  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject position]): (-[KWQAccObject size]):
9:43 AM Changeset in webkit [5715] by kocienda
  • 3 edits in branches

Reviewed by me

A couple of tweaks to make caret drawing work a little
better. Now the caret does not paint when you click on
a link, and the "leftover" pixel is gone from the
caret blink.

  • khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::placeCaret):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):
8:45 AM Changeset in webkit [5714] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • fixed 3502347: REGRESSION (100-116): bottom of login window sometimes missing (TR background image)
  • khtml/rendering/render_object.h: Added setPixmap.
  • khtml/rendering/render_object.cpp: (RenderObject::setPixmap): Moved this function here from RenderBox. This code is needed for the table row class and similar classes that supply a background image that is drawn by the table cell, and those are not RenderBox subclasses.
  • khtml/rendering/render_box.cpp: Removed setPixmap.
  • khtml/rendering/render_box.h: Removed setPixmap.

Dec 7, 2003:

10:04 PM Changeset in webkit [5713] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3502655>: REGRESSION: Repro crash at espn.com

Reviewed by Darin.

  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Check for nil RenderApplet before dereferencing rather than after.

Dec 6, 2003:

9:27 AM Changeset in webkit [5712] by kocienda
  • 2 edits in branches

Reviewed by me

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Fixed a dumb crasher in a debug printf.

Dec 5, 2003:

3:22 PM Changeset in webkit [5711] by hyatt
  • 2 edits in trunk/WebCore

Add support for link clicking as an accessibility action.

Reviewed by john

  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]):
3:05 PM Changeset in webkit [5710] by rjw
  • 6 edits
    2 adds in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: Part 1 of supporting JS bindings to
native language arrays.

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bindings/jni/jni_runtime.h:
  • bindings/runtime.cpp: (Instance::setValueOfField):
  • bindings/runtime.h: (Bindings::Array::~Array):

Tests:

Added tests to access Java arrays.

Reviewed by Chris.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:
2:03 PM Changeset in webkit [5709] by mjs
  • 21 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487222>: Add ability to create working fully standalone document object

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::addSheet): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::applyRule):
  • khtml/dom/dom_doc.cpp: (DOM::Document::part):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (KJS::checkNodeSecurity):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::tryGet): (KJS::HTMLDocument::putValue): (KJS::HTMLElement::tryGet): (Image::notifyFinished):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): (HTMLDocumentImpl::lastModified):
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): (HTMLFormElementImpl::prepareSubmit): (HTMLFormElementImpl::submit): (HTMLFormElementImpl::reset): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::defaultEventHandler):
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isKeyboardFocusable): (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptExecution): (HTMLTokenizer::parseTag):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): (DocumentImpl::part): (DocumentImpl::close): (DocumentImpl::processHttpEquiv):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::partForNode): (KWQKHTMLPart::attributedString):
2:00 PM Changeset in webkit [5708] by rjw
  • 2 edits in trunk/WebCore

Fixed 3501885. Added null test to returned node from collection.

Reviewed by John.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::tryGet):
10:06 AM Changeset in webkit [5707] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3491427>: REGRESSION (100-114): multi-page HTML content in Mail is blank when printed

Darin and I figured this one out.

Reviewed by Ken.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): Don't call setNeedsDisplay:NO when we're turning printing on, as doing so prevents anything from drawing in the case where this is called from adjustPageHeightsNew:top:bottom:limit
8:52 AM Changeset in webkit [5706] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed regression in small caps with substituted fonts my patch from yesterday caused
  • fixed 3463599: if Lucida font is installed, you see bad glyphs on pages that use it (advogato.org)
  • fixed storage leak if a renderer is ever deallocated (I don't think we ever do that)
  • fixed some small leaks in various error cases by adding appropriate free and dispose calls
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer dealloc]): Free the Unicode glyph map too. (fontContainsString): Moved inline function up here so it will be inlined. (-[WebTextRenderer _setupFont]): Free the glyph map and set it back to zero if we fail after extending the glyph map to include space. This fixes the "wrong glyph codes" bug with Lucida above. (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): Add free calls needed to avoid storage leaks in failure cases. (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Ditto. (-[WebTextRenderer _initializeATSUStyle]): Add ATSUDisposeStyle to fix storage leak. (freeWidthMap): Use a loop instead of recursion. (freeGlyphMap): Use a loop instead of recursion. (freeUnicodeGlyphMap): Added. (widthForNextCharacter): Don't use the original characters or cluster length, because the character may have been capitalized for use in small caps rendering. So check the character for <= 0xFFFF instead of looking at clusterLength, and break the character into a local array instead of using the original character pointer.
Note: See TracTimeline for information about the timeline view.