Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Dec 10, 2003:

10:56 PM Changeset in webkit [5760] by mjs

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3504156>: XMLHttpRequest reuse test fails
<rdar://problem/3505158>: XMLHttpRequest "abort with open" test fails

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::open): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequestProtoFunc::tryCall):

10:50 PM Changeset in webkit [5759] by mjs

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507175>: Setting timeout function can allocate JS objects without lock

• khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Lock interpreter around code that might allocate JS objects.

10:26 PM Changeset in webkit [5758]

• 1 copy
  126 deletes in branches/unlabeled-1.1.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.1.2'.

10:26 PM Changeset in webkit [5757] by hyatt

• 1 add in trunk/LayoutTests/fast/overflow/005.html

Adding overflow test with auto height.

10:25 PM Changeset in webkit [5756] by hyatt

• 3 edits in trunk/WebCore

Fix for 3507097, overflow:auto should include the height of the horizontal scrollbar when the height
of the block is auto.

Reviewed by darin

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren):

9:15 PM Changeset in webkit [5755] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3506739: nil-deref in DocumentImpl::setSelection triple clicking (generated content)

• khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent): Check for the case where m_selectionEnd is 0. This doesn't fix the behavior completely, but it does prevent a crash.

8:55 PM Changeset in webkit [5754] by mjs

• 8 edits in trunk

WebCore:

Reviewed by Richard.

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::processSyncLoadResults): (KJS::XMLHttpRequest::slotRedirection): (KJS::XMLHttpRequest::slotData):
• khtml/ecma/xmlhttprequest.h:
• kwq/KWQLoader.h:
• kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQServeSynchronousRequest): (KWQResponseHeaderString):
• kwq/WebCoreBridge.h:

WebKit:

Reviewed by Richard.

WebKit part of fix for:

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):

8:55 PM Changeset in webkit [5753] by darin

• 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• fixed regression in JavaScript tests reported by the KDE guys
• fixed 3506345: REGRESSION (115-116): VIP: chordfind.com no longer displays chords

• kjs/ustring.h: Add tolerateEmptyString parameter to toDouble and toULong.
• kjs/ustring.cpp: (KJS::UString::toDouble): Separate the "tolerant" parameter into two separate ones: tolerateTrailingJunk and tolerateEmptyString. Add new overloads; better for code size and binary compatibility than default parameter values. (KJS::UString::toULong): Pass tolerateEmptyString down to toDouble. Add new overload.

• kjs/string_object.cpp: (StringProtoFuncImp::call): Pass false for the new "tolerate empty string" parameter.

8:49 PM Changeset in webkit [5752] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3506706: REGRESSION (100-115): onkeyup handlers called twice for active input fields

• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]): Don't call super because we don't want to pass the event down the responder chain.
• kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Return NO for key up events because we don't want to pass the event down the responder chain.

8:47 PM Changeset in webkit [5751] by hyatt

• 1 edit in trunk/JavaScriptCore/bindings/jni_jsobject.cpp

Fix optimized build bustage.

6:20 PM Changeset in webkit [5750] by rjw

• 11 edits in trunk

WebKit:

Added method to get to the bridge from a view. This is
used to ultimately get the part and KJS::Window for a
particular applet.

Reviewed by Hyatt.

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]): (-[WebViewFactory bridgeForView:]):

WebCore:

Added method to get to the bridge from a view. This is
used to ultimately get the part and KJS::Window for a
particular applet.

Reviewed by Hyatt.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
• kwq/WebCoreViewFactory.h:
• kwq/WebCoreViewFactory.m:

JavaScriptCore:

Added code to manage reference counting of JavaScript
objects passed to Java. Also added implementation of
KJS_JSCreateNativeJSObject. This is the function that
provides the root object to Java (KJS::Window).

Reviewed by Hyatt.

• JavaScriptCore.pbproj/project.pbxproj:
• bindings/jni_jsobject.cpp: (KJS_setFindObjectForNativeHandleFunction): (KJS_findObjectForNativeHandleFunction): (getReferencesByOwnerDictionary): (getReferencesDictionary): (findReferenceDictionary): (addJavaReference): (removeJavaReference): (removeAllJavaReferencesForOwner):
• bindings/jni_jsobject.h:

5:47 PM Changeset in webkit [5749] by sullivan

• 10 edits in trunk

WebCore:

• WebCore part of fix for: <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

Reviewed by Darin.

• kwq/KWQNSViewExtras.h:
• kwq/KWQNSViewExtras.m: (-[NSView _KWQ_scrollPointRecursive:]): (-[NSView _KWQ_scrollPointRecursive:inView:]): new methods, similar to existing scrollRect methods except that the preferred position for the point is the top-left corner rather than centered in the visible area

• kwq/KWQScrollView.h:
• kwq/KWQScrollView.mm: (QScrollView::setContentsPosRecursive): new method, calls _KWQ_scrollPointRecursive:

• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): call setContentsPosRecursive instead of setContentsPos; also remove the 50 pixel offset that upset Hyatt so.

WebKit:

• WebKit part of fix for: <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

Reviewed by Darin

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: removed _web_scrollPointToVisible:fromView:

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollPoint:]): removed call to _web_scrollPointToVisible:fromView:

4:34 PM Changeset in webkit [5748] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

Reviewed by kocienda.

• WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): tweak (addCertificateToKeychainFromData): renamed to use lowercase "c" in "keychain" (addCertificatesToKeychainFromData): take data instead of a path to a file
• WebCoreSupport.subproj/WebKeyGeneration.h:
• WebCoreSupport.subproj/WebKeyGenerator.h:
• WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): added temporary workaround for 3396936

WebBrowser:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

Reviewed by me, kocienda.

• BrowserNSDataExtras.h:
• BrowserNSDataExtras.m: new categories implemented by kocienda. (-[NSData indexOfCharacterInCString:]): (-[NSData indexOfCString:]): (-[NSData indexOfCString:startOffset:]): (-[NSData indexOfByteString:length:]): (-[NSData indexOfByteString:length:startOffset:]): (-[NSData certificateFromMultipartData]): extracts the cert
• DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): if the file is multipart/mixed, attempt to extract the cert using certificateFromMultipartData

2:39 PM Changeset in webkit [5747] by cblu

• 2 edits in trunk/WebCore

• kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::signedPublicKeyAndChallengeString): removed unnecessary includes

2:34 PM Changeset in webkit [5746] by hyatt

• 4 edits in trunk/WebCore

Fix for 3505846, overflow:auto region doesn't update when scrolled. The child layers inside an overflow:auto
block were not updating their positions.

Reviewed by john

• khtml/khtmlview.cpp: (KHTMLView::layout):
• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPositions): (RenderLayer::scrollToOffset):
• khtml/rendering/render_layer.h:

1:47 PM Changeset in webkit [5745] by mjs

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Corrected ChangeLog entry.

1:46 PM Changeset in webkit [5744] by mjs

• 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3505795>: loading invalid XML document crashes trying to create h1 element

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::isValidName): include "0123456789" instead of "0-9", it's not a regexp it's just a list of characters.

1:42 PM Changeset in webkit [5743] by mjs

• 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3504155>: Safari fails XMLHttpRequest abort test

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::tryCall): Avoid throwing an exception after send().

1:14 PM Changeset in webkit [5742] by hyatt

• 11 edits in trunk/WebCore

Rename -apple-aqua to auto for outline styles.

Reviewed by darin

• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
• khtml/css/cssvalues.c: (hash_val): (findValue):
• khtml/css/cssvalues.h:
• khtml/css/cssvalues.in:
• khtml/css/html4.css:
• khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
• khtml/rendering/render_object.cpp: (RenderObject::drawBorder): (RenderObject::paintOutline):
• khtml/rendering/render_style.h: (khtml::): (khtml::OutlineValue::OutlineValue): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineOffset):
• kwq/KWQRenderTreeDebug.cpp: (printBorderStyle):

Dec 9, 2003:

8:09 PM Changeset in webkit [5741] by mjs

• 7 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487195>: Implement responseXML property for XMLHttpRequest

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented responseXML by parsing the document and returning it. (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new field
• khtml/ecma/xmlhttprequest.h:

• khtml/ecma/kjs_window.cpp: (Windw::get): Forgot this in last commit; add XMLSerializer constructor.
• khtml/ecma/kjs_window.lut.h:
• khtml/ecma/Makefile.am: Forgot to include this in the last commit.

8:05 PM Changeset in webkit [5740] by mjs

• 5 edits
  3 adds in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3504049>: XMLSerializer object and serializeToString method needed for XMLHttpRequest testing

Also fixed some lasst-minute mistakes in the DOM serialization
code that was already there.

• WebCore.pbproj/project.pbxproj:
• khtml/dom/dom_doc.h:
• khtml/ecma/Makefile.am:
• khtml/ecma/kjs_window.cpp: (Window::get):
• khtml/ecma/kjs_window.h: (KJS::Window::):
• khtml/ecma/kjs_window.lut.h: (KJS::):
• khtml/ecma/xmlserializer.cpp: Added. (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): (KJS::XMLSerializerConstructorImp::implementsConstruct): (KJS::XMLSerializerConstructorImp::construct): (KJS::): (KJS::XMLSerializer::XMLSerializer): (KJS::XMLSerializerProtoFunc::tryCall):
• khtml/ecma/xmlserializer.h: Added. (KJS::XMLSerializer::toBoolean): (KJS::XMLSerializer::classInfo): (KJS::XMLSerializer::):
• khtml/ecma/xmlserializer.lut.h: Added. (KJS::):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::toString): (DocumentFragmentImpl::toString):
• khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::toString):

5:23 PM Changeset in webkit [5739] by hyatt

• 4 edits in trunk/WebCore

Implement start() and stop() for marquees.

Reviewed by darin

• khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::classInfo): (KJS::HTMLElementFunction::tryCall):
• khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
• khtml/ecma/kjs_html.lut.h: (KJS::):

5:05 PM Changeset in webkit [5738] by rjw

• 3 edits
  2 adds in trunk/JavaScriptCore

LiveConnect stubs that correspond to the native methods
on JSObject. These will be called from the new Java plugin
when an instance of JSObject is instantiated and messaged.
When these are implemented the Java will be able to originate
calls into JavaScript.

Also a temporary work-around added to Makefile.am to solve
a link problem. The 1.4.2 JavaVM accidentally links against
libobjc. This call a failure linking testkjs. Mike Hay is
working with someone to fix the problem (3505587).

Reviewed by Chris.

• JavaScriptCore.pbproj/project.pbxproj:
• Makefile.am:
• bindings/jni_jsobject.cpp: Added. (KJS_JSCreateNativeJSObject): (KJS_JSObject_JSFinalize): (KJS_JSObject_JSObjectCall): (KJS_JSObject_JSObjectEval): (KJS_JSObject_JSObjectGetMember): (KJS_JSObject_JSObjectSetMember): (KJS_JSObject_JSObjectRemoveMember): (KJS_JSObject_JSObjectGetSlot): (KJS_JSObject_JSObjectSetSlot): (KJS_JSObject_JSObjectToString):
• bindings/jni_jsobject.h: Added.

4:53 PM Changeset in webkit [5737] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed 3505277: nil-deref in ownerElement after choosing item from menu at projectnissan.com

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Add check for nil.

4:46 PM Changeset in webkit [5736] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveLocationProperties): Add locking around the call to get the location since it can allocate. (KWQKHTMLPart::restoreLocationProperties): Ditto.

4:29 PM Changeset in webkit [5735] by hyatt

• 2 edits in trunk/WebCore

Fix for mojibake bg painting problem on bofa.com. The bug # is 3487144. Transparent colors were not
being handled properly when specified on the body.

Reviewed by darin

• khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):

3:39 PM Changeset in webkit [5734] by darin

• 2 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3505391: REGRESSION (100-116): pages that move cells around don't repaint correctly

• khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): Added code similar to the code in RenderBlock::layoutBlock, but for table cells.

3:38 PM Changeset in webkit [5733] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add locking around the call to push event handler scope. Without this, we hit the "allocated without locking" assertion.

3:15 PM Changeset in webkit [5732] by hyatt

• 5 edits in trunk/WebCore

Fix the dirty rect checks on various render_objects to be more accurate so that page-break properties don't
have mojibake when printing.

Reviewed by john

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint):
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
• khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
• khtml/rendering/render_table.cpp: (RenderTable::paint):

3:01 PM Changeset in webkit [5731] by darin

• 5 edits in trunk/WebCore

Reviewed by Richard.

• fixed 3500408: Web Kit should pass the MAYSCRIPT attribute from the APPLET tag to the Java plug-in

• khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): Allow the "mayscript" attribute. (HTMLAppletElementImpl::createRenderer): Pass the value of the "mayscript" attribute as an argument named "mayScript".

• khtml/misc/htmlattrs.in: Added "mayscript".
• khtml/misc/htmlattrs.c: Regenerated.
• khtml/misc/htmlattrs.h: Regenerated.

2:26 PM Changeset in webkit [5730] by mjs

• 2 edits in trunk/JavaScriptCore

Reviewed by John.

<rdar://problem/3505183>: JavaScriptCore should assert that interpreter is locked in collector

• kjs/collector.cpp: (KJS::Collector::allocate): Assert that interpreter lock count is not 0. (KJS::Collector::collect): likewise

2:26 PM Changeset in webkit [5729] by mjs

• 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3501030>: JavaScript sites crash when a PAC file is in place (WebCore,Safari 1.2)

• khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Lock interpreter when needed. (JSLazyEventListener::parseCode): Likewise. (KJS::getDOMEvent): Likewise.
• khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Likewise. (KJSProxyImpl::initScript): Likewise.

2:11 PM Changeset in webkit [5728] by hyatt

• 2 edits in trunk/WebCore

Fix for 3491235, really make <script src="..."/> work in HTML. My original attempt to fix this only made
the tag flat, but did not ensure that the script got processed.

Reviewed by john

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

1:52 PM Changeset in webkit [5727] by cblu

• 7 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

• WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): (addCertificateToKeyChainFromData): new (addCertificateToKeyChainFromFile): new
• WebCoreSupport.subproj/WebKeyGeneration.h:
• WebCoreSupport.subproj/WebKeyGenerator.h:
• WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator addCertificateToKeyChainFromFileAtPath:]): new
• WebKit.exp:
• WebKit.pbproj/project.pbxproj: made WebKeyGenerator.h private

WebBrowser:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

• DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): new, calls [WebKeyGenerator addCertificateToKeyChainFromFileAtPath:] (-[DownloadProgressEntry autoOpen]): call _addCertificateToKeyChain

1:23 PM Changeset in webkit [5726] by sullivan

• 2 edits in trunk/WebKit

• fixed <rdar://problem/3504907>: REGRESSION (100-116): Clicking QuickTime-requiring link twice crashes (wholenote.com)

I found the bug; Darin wrote the fix; I reviewed and tested.

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): Rewrote this method to not use GetIndString, because GetIndString looks at all open resource files and in this case was reading information from the wrong plugin file.

11:56 AM Changeset in webkit [5725] by hyatt

• 2 adds in trunk/LayoutTests/fast/dynamic

Adding a dynamic cell array test.

Dec 8, 2003:

10:58 PM Changeset in webkit [5724] by hyatt

• 3 edits in trunk/WebCore

Fix for 3503652, news.com misrenders badly (footer is out of position). My fix to 3495748 caused this
regression. I made the tag priority of <nobr> too high. It needed to be the same as <div>, and I
accidentally made it higher. I intended for it to be the same as <div>.

I also had to make a fix (now that <nobr> has a higher priority) to ensure <nobr> can't be nested inside
other <nobr>.

Both fixes were required to make news.com render correctly again.

Reviewed by darin

• khtml/html/dtd.cpp:
• khtml/html/htmlparser.cpp: (KHTMLParser::getElement):

6:12 PM Changeset in webkit [5723] by cblu

• 15 edits
  6 adds
  4 deletes in trunk

WebCore:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

• WebCore-combined.exp:
• WebCore.exp:
• WebCore.pbproj/project.pbxproj:
• khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::parseAttribute): store the KEYTYPE attribute (HTMLKeygenElementImpl::encoding): call KSSLKeyGen::signedPublicKeyAndChallengeString
• khtml/html/html_formimpl.h: remove 2 declared but unimplemented methods
• khtml/misc/htmlattrs.c: generated changes (hash_attr): (findAttr):
• khtml/misc/htmlattrs.h: generated change
• khtml/misc/htmlattrs.in: added KEYTYPE
• kwq/KWQKSSLKeyGen.h:
• kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::supportedKeySizes): call renamed strengthMenuItemTitles (KSSLKeyGen::signedPublicKeyAndChallengeString): new, calls [WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]
• kwq/WebCoreKeyGenerationFactory.h: Added.
• kwq/WebCoreKeyGenerationFactory.m: Added. (+[WebCoreKeyGenerationFactory sharedFactory]): (-[WebCoreKeyGenerationFactory init]): (-[WebCoreKeyGenerationFactory strengthMenuItemTitles]): (-[WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]):
• kwq/WebCoreLocalizedStringFactory.h: Removed.
• kwq/WebCoreLocalizedStringFactory.m: Removed.

WebKit:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

Reviewed by mjs.

• WebCoreSupport.subproj/WebKeyGeneration.cpp: Added. (gnrAddContextAttribute): new (gnrGetSubjPubKey): new (gnrNullAlgParams): new (gnrSign): new (gnrFreeCssmData): new (signedPublicKeyAndChallengeString): new
• WebCoreSupport.subproj/WebKeyGeneration.h: Added.
• WebCoreSupport.subproj/WebKeyGenerationFactory.h: Added. Renamed from WebLocalizedStringFactory.
• WebCoreSupport.subproj/WebKeyGenerationFactory.m: Added. (+[WebKeyGenerationFactory createSharedFactory]): no change (-[WebKeyGenerationFactory dealloc]): no change (-[WebKeyGenerationFactory strengthMenuItemTitles]): new (-[WebKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): new
• WebCoreSupport.subproj/WebLocalizedStringFactory.h: Removed.
• WebCoreSupport.subproj/WebLocalizedStringFactory.m: Removed.
• WebCoreSupport.subproj/WebNetscapeTemplates.cpp: Added.
• WebCoreSupport.subproj/WebNetscapeTemplates.h: Added.
• WebKit.pbproj/project.pbxproj:
• WebKitPrefix.h:
• WebView.subproj/WebFrameView.m:

5:03 PM Changeset in webkit [5722] by kocienda

• 9 edits in branches

Reviewed by me.

Some more work on getting the delete key to work.
Some work to make relayout happen correctly.
Moved edit evenit handler to HTMLElementImpl.

• khtml/html/html_blockimpl.cpp:
• khtml/html/html_blockimpl.h:
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::defaultEventHandler): (HTMLElementImpl::toString):
• khtml/html/html_elementimpl.h:
• khtml/html/html_inlineimpl.h: (DOM::HTMLBRElementImpl::isHTMLBRElement):
• khtml/html/htmlediting.cpp: (EditCommand::notifyChanged): (InputTextCommand::applyToDocument): (DeleteTextCommand::applyToDocument):
• khtml/html/htmlediting.h: (khtml::EditCommand::selection): (khtml::InputTextCommand::text):
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isHTMLBRElement):

5:02 PM Changeset in webkit [5721] by mjs

• 4 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3504047>: XMLHttpRequest object needs onload event

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented onload property. (KJS::XMLHttpRequest::putValue): Ditto. (KJS::XMLHttpRequest::XMLHttpRequest): Ditto. (KJS::XMLHttpRequest::changeState): Ditto.
• khtml/ecma/xmlhttprequest.h:
• khtml/ecma/xmlhttprequest.lut.h: Regenerated.

4:53 PM Changeset in webkit [5720] by rjw

• 10 edits in trunk/JavaScriptCore

JavaScriptCore:

LiveConnect: The last piece of the JavaScript side of the
LiveConnect implementation. This change adds support for
setting/getting values from Java arrays in JavaScript.

Reviewed by John.

• bindings/jni/jni_instance.h:
• bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (convertJObjectToArray): (JavaArray::JavaArray): (JavaArray::~JavaArray): (JavaArray::setValueAt): (JavaArray::valueAt): (JavaArray::getLength):
• bindings/jni/jni_runtime.h: (Bindings::JavaArray::operator=): (Bindings::JavaArray::javaArray):
• bindings/jni/jni_utility.cpp: (JNITypeFromPrimitiveType): (convertValueToJValue):
• bindings/jni/jni_utility.h:
• bindings/runtime.h:
• bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp): (RuntimeArrayImp::~RuntimeArrayImp): (RuntimeArrayImp::get): (RuntimeArrayImp::put): (RuntimeArrayImp::hasProperty):
• bindings/runtime_array.h: (KJS::RuntimeArrayImp::getLength): (KJS::RuntimeArrayImp::getConcreteArray):
• bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty):

Tests:

LiveConnect: Added tests for JavaScript to Java
array access.

Reviewed by John.

• LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
• LiveConnect/Blink/test.html:

3:51 PM Changeset in webkit [5719] by hyatt

• 2 adds in trunk/LayoutTests/fast/text/international

Add asahi.com layout test.

3:50 PM Changeset in webkit [5718] by hyatt

• 2 edits in trunk/WebCore

Fix for 3503022, asahi.com is too wide. Bugs in line breaking of breakable Japanese characters caused
the breaks to be ignored.

Reviewed by john

• khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):

2:35 PM Changeset in webkit [5717] by kocienda

• 7 edits in branches

Reviewed by me

Got some more basic text editing working, including:
Deleting selection when you start typing, and making
the delete key work to remove text.

I did some refactoring as well, moving the guts of
the application of editing commands into the command
implementation file.

• khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::defaultEventHandler):
• khtml/html/htmlediting.cpp: (InputTextCommand::commandID): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::applyToDocument): (InputTextCommand::canUndo): (DeleteTextCommand::commandID): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::applyToDocument): (DeleteTextCommand::canUndo):
• khtml/html/htmlediting.h: (khtml::): (khtml::InputTextCommand::~InputTextCommand): (khtml::DeleteTextCommand::~DeleteTextCommand):
• khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent):
• khtml/khtmlview.cpp: (KHTMLView::caretOverrides):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyEditing):

11:44 AM Changeset in webkit [5716] by hyatt

• 3 edits in trunk/WebCore

Fix the position method to return screen coords like it should and to use the lower left corner instead of
the upper left.

Reviewed by john

• kwq/KWQAccObject.h:
• kwq/KWQAccObject.mm: (-[KWQAccObject position]): (-[KWQAccObject size]):

9:43 AM Changeset in webkit [5715] by kocienda

• 3 edits in branches

Reviewed by me

A couple of tweaks to make caret drawing work a little
better. Now the caret does not paint when you click on
a link, and the "leftover" pixel is gone from the
caret blink.

• khtml/khtmlview.cpp: (KHTMLView::timerEvent): (KHTMLView::placeCaret):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):

8:45 AM Changeset in webkit [5714] by darin

• 5 edits in trunk/WebCore

Reviewed by John.

• fixed 3502347: REGRESSION (100-116): bottom of login window sometimes missing (TR background image)

• khtml/rendering/render_object.h: Added setPixmap.
• khtml/rendering/render_object.cpp: (RenderObject::setPixmap): Moved this function here from RenderBox. This code is needed for the table row class and similar classes that supply a background image that is drawn by the table cell, and those are not RenderBox subclasses.

• khtml/rendering/render_box.cpp: Removed setPixmap.
• khtml/rendering/render_box.h: Removed setPixmap.

Dec 7, 2003:

10:04 PM Changeset in webkit [5713] by sullivan

• 2 edits in trunk/WebCore

• fixed <rdar://problem/3502655>: REGRESSION: Repro crash at espn.com

Reviewed by Darin.

• khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Check for nil RenderApplet before dereferencing rather than after.

Dec 6, 2003:

9:27 AM Changeset in webkit [5712] by kocienda

• 2 edits in branches

Reviewed by me

• khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Fixed a dumb crasher in a debug printf.