Timeline



Dec 13, 2003:

10:43 PM Changeset in webkit [5793] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507885>: REGRESSION (100-116): frames missing due to cross-domain check (derstandard.at)

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Loosen the frame access rules a bit. We already allowed access to a document loaded as empty from the parent or opener. Now also allow access from any document in the same domain as the parent or opener, so that, for instance, a sibling frame can access it so long as it is in the same domain as the parent.
4:43 PM Changeset in webkit [5792] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3506204: homepage.mac slide show window is wrong size on 2nd monitor
  • kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): Add code to flip the Y coordinate. This has no effect on the main screen, but a big effect on others. I used the same code to flip Y screen coordinates that is used KWQWindowWidget.mm and KWQKHTMLPartBrowserExtension.mm.
  • kwq/KWQKWinModule.mm: (KWinModule::workArea): Replaced the incorrect code to flip the Y coordinate here with correct code. The code flipped based on the frame of the main screen, but it needs to flip based on the frame of screen 0.
10:06 AM Changeset in webkit [5791] by darin
  • 2 edits in trunk/WebKit

Fixed by Ed Voas, reviewed by me.

  • fixed 3278443: CARBON: grow box obscures scroll bar knob
  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _growBoxRect]): Return the grow box so AppKit's scroll bar code will know where it is.

Dec 12, 2003:

10:08 PM Changeset in webkit [5790] by kocienda
  • 305 edits
    2 deletes in branches

Reviewed by me

Merged HEAD to tip of branch

  • ChangeLog:
  • English.lproj/InfoPlist.strings:
  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_valueimpl.cpp: (CSSImageValueImpl::CSSImageValueImpl): (CSSImageValueImpl::~CSSImageValueImpl): (CSSImageValueImpl::image):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::addSheet): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/dom/dom_doc.cpp: (DOM::Document::createElement): (DOM::Document::createElementNS): (DOM::Document::part):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/Makefile.am:
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (KJS::checkNodeSecurity): (KJS::getDOMNamedNodeMap): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): (JSLazyEventListener::parseCode): (KJS::getDOMEvent):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::tryGet): (KJS::HTMLDocument::putValue): (KJS::HTMLElement::classInfo): (KJS::HTMLElement::tryGet): (KJS::HTMLElementFunction::tryCall): (KJS::HTMLCollection::tryGet): (Image::notifyFinished):
  • khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode):
  • khtml/ecma/kjs_window.cpp: (Window::get): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValue): (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open): (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::getStatusText): (KJS::XMLHttpRequest::processSyncLoadResults): (KJS::XMLHttpRequest::slotRedirection): (KJS::XMLHttpRequest::slotData): (KJS::XMLHttpRequestProtoFunc::tryCall):
  • khtml/ecma/xmlhttprequest.h: (KJS::XMLHttpRequest::):
  • khtml/ecma/xmlhttprequest.lut.h: (KJS::):
  • khtml/ecma/xmlserializer.cpp: Added. (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): (KJS::XMLSerializerConstructorImp::implementsConstruct): (KJS::XMLSerializerConstructorImp::construct): (KJS::): (KJS::XMLSerializer::XMLSerializer): (KJS::XMLSerializerProtoFunc::tryCall):
  • khtml/ecma/xmlserializer.h: Added. (KJS::XMLSerializer::toBoolean): (KJS::XMLSerializer::classInfo): (KJS::XMLSerializer::):
  • khtml/ecma/xmlserializer.lut.h: Added. (KJS::):
  • khtml/html/dtd.cpp:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): (HTMLDocumentImpl::lastModified): (HTMLDocumentImpl::createElement):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): (HTMLFormElementImpl::prepareSubmit): (HTMLFormElementImpl::submit): (HTMLFormElementImpl::reset): (HTMLGenericFormElementImpl::attach): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::defaultEventHandler): (HTMLKeygenElementImpl::parseAttribute): (HTMLKeygenElementImpl::encoding):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isKeyboardFocusable): (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/htmlediting.cpp: (InputTextCommand::applyToDocument):
  • khtml/html/htmlediting.h:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): (HTMLTokenizer::scriptExecution): (HTMLTokenizer::parseTag):
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/misc/loader.cpp: (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestStyleSheet): (Cache::requestScript):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::paint):
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::setMaximalOutlineSize): (khtml::RenderCanvas::maximalOutlineSize):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::updateLayerPositions): (RenderLayer::beginTransparencyLayers): (RenderLayer::scrollToOffset): (RenderLayer::paint): (RenderLayer::paintLayer):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder): (RenderObject::paintOutline): (RenderObject::isEditable): (RenderObject::setPixmap): (RenderObject::maximalOutlineSize):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
  • khtml/rendering/render_style.h: (khtml::): (khtml::OutlineValue::OutlineValue): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineOffset):
  • khtml/rendering/render_table.cpp: (RenderTable::paint): (RenderTableSection::layoutRows): (RenderTableSection::paint): (RenderTableCell::paint):
  • khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): (DocumentImpl::createElement): (DocumentImpl::importNode): (DocumentImpl::createElementNS): (DocumentImpl::setTitle): (DocumentImpl::createHTMLElement): (DocumentImpl::part): (DocumentImpl::close): (DocumentImpl::processHttpEquiv): (DocumentImpl::isValidName): (DocumentImpl::toString): (DocumentFragmentImpl::toString):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::cloneNode): (ElementImpl::toString):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent): (NodeImpl::dispatchWindowEvent):
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): (XMLHandler::processingInstruction): (XMLTokenizer::finish): (XMLTokenizer::executeScripts):
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (-[KWQAccObject textUnderElement]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]):
  • kwq/KWQColor.h: (operator==): (operator!=):
  • kwq/KWQColor.mm: (QColor::name):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::nextKeyViewInFrame): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::partForNode): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::supportedKeySizes): (KSSLKeyGen::signedPublicKeyAndChallengeString):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQServeSynchronousRequest): (KWQResponseHeaderString): (KWQCacheObjectExpiresTime):
  • kwq/KWQNSViewExtras.h:
  • kwq/KWQNSViewExtras.m: (-[NSView _KWQ_scrollPointRecursive:]): (-[NSView _KWQ_scrollPointRecursive:inView:]):
  • kwq/KWQRenderTreeDebug.cpp: (printBorderStyle): (operator<<):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPosRecursive): (QScrollView::ensureVisible): (QScrollView::ensureRectVisibleCentered):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]):
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
  • kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument createElement:]): (-[WebCoreDOMDocument createElementNS::]):
  • kwq/WebCoreLocalizedStringFactory.h: Removed.
  • kwq/WebCoreLocalizedStringFactory.m: Removed.
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m:
  • layout-tests/apple-only/base/bugzilla.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/home.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/lxr.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/my.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/news.cnet.com/index-expected.txt:
  • layout-tests/apple-only/base/slashdot.org/index-expected.txt:
  • layout-tests/apple-only/base/web.icq.com/index-expected.txt:
  • layout-tests/apple-only/base/www.altavista.com/index-expected.txt:
  • layout-tests/apple-only/base/www.amazon.com/index-expected.txt:
  • layout-tests/apple-only/base/www.apple.com/index-expected.txt:
  • layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.digitalcity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
  • layout-tests/apple-only/base/www.excite.com/index-expected.txt:
  • layout-tests/apple-only/base/www.expedia.com/index-expected.txt:
  • layout-tests/apple-only/base/www.google.com/index-expected.txt:
  • layout-tests/apple-only/base/www.iplanet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.mapquest.com/index-expected.txt:
  • layout-tests/apple-only/base/www.microsoft.com/index-expected.txt:
  • layout-tests/apple-only/base/www.moviefone.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com_Table/index-expected.txt:
  • layout-tests/apple-only/base/www.quicken.com/index-expected.txt:
  • layout-tests/apple-only/base/www.sun.com/index-expected.txt:
  • layout-tests/apple-only/base/www.time.com/index-expected.txt:
  • layout-tests/apple-only/base/www.travelocity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.w3.org_DOML2Core/index-expected.txt:
  • layout-tests/apple-only/base/www.yahoo.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com_Gamespot.com/index-expected.txt:
  • layout-tests/css1/basic/class_as_selector-expected.txt:
  • layout-tests/css1/basic/comments-expected.txt:
  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/basic/contextual_selectors-expected.txt:
  • layout-tests/css1/basic/grouping-expected.txt:
  • layout-tests/css1/basic/id_as_selector-expected.txt:
  • layout-tests/css1/basic/inheritance-expected.txt:
  • layout-tests/css1/box_properties/acid_test-expected.txt:
  • layout-tests/css1/box_properties/border-expected.txt:
  • layout-tests/css1/box_properties/border_bottom-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_color-expected.txt:
  • layout-tests/css1/box_properties/border_color_inline-expected.txt:
  • layout-tests/css1/box_properties/border_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left-expected.txt:
  • layout-tests/css1/box_properties/border_left_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left_width-expected.txt:
  • layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right-expected.txt:
  • layout-tests/css1/box_properties/border_right_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right_width-expected.txt:
  • layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_style-expected.txt:
  • layout-tests/css1/box_properties/border_style_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top-expected.txt:
  • layout-tests/css1/box_properties/border_top_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top_width-expected.txt:
  • layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_width-expected.txt:
  • layout-tests/css1/box_properties/border_width_inline-expected.txt:
  • layout-tests/css1/box_properties/clear-expected.txt:
  • layout-tests/css1/box_properties/clear_float-expected.txt:
  • layout-tests/css1/box_properties/float-expected.txt:
  • layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
  • layout-tests/css1/box_properties/float_margin-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/box_properties/height-expected.txt:
  • layout-tests/css1/box_properties/margin-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_left-expected.txt:
  • layout-tests/css1/box_properties/margin_left_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_right-expected.txt:
  • layout-tests/css1/box_properties/margin_right_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_top-expected.txt:
  • layout-tests/css1/box_properties/margin_top_inline-expected.txt:
  • layout-tests/css1/box_properties/padding-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_left-expected.txt:
  • layout-tests/css1/box_properties/padding_left_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_right-expected.txt:
  • layout-tests/css1/box_properties/padding_right_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_top-expected.txt:
  • layout-tests/css1/box_properties/padding_top_inline-expected.txt:
  • layout-tests/css1/box_properties/width-expected.txt:
  • layout-tests/css1/cascade/cascade_order-expected.txt:
  • layout-tests/css1/cascade/important-expected.txt:
  • layout-tests/css1/classification/display-expected.txt:
  • layout-tests/css1/classification/list_style-expected.txt:
  • layout-tests/css1/classification/list_style_image-expected.txt:
  • layout-tests/css1/classification/list_style_position-expected.txt:
  • layout-tests/css1/classification/list_style_type-expected.txt:
  • layout-tests/css1/classification/white_space-expected.txt:
  • layout-tests/css1/color_and_background/background-expected.txt:
  • layout-tests/css1/color_and_background/background_attachment-expected.txt:
  • layout-tests/css1/color_and_background/background_color-expected.txt:
  • layout-tests/css1/color_and_background/background_image-expected.txt:
  • layout-tests/css1/color_and_background/background_position-expected.txt:
  • layout-tests/css1/color_and_background/background_repeat-expected.txt:
  • layout-tests/css1/color_and_background/color-expected.txt:
  • layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_family-expected.txt:
  • layout-tests/css1/font_properties/font_size-expected.txt:
  • layout-tests/css1/font_properties/font_style-expected.txt:
  • layout-tests/css1/font_properties/font_variant-expected.txt:
  • layout-tests/css1/font_properties/font_weight-expected.txt:
  • layout-tests/css1/formatting_model/canvas-expected.txt:
  • layout-tests/css1/formatting_model/floating_elements-expected.txt:
  • layout-tests/css1/formatting_model/height_of_lines-expected.txt:
  • layout-tests/css1/formatting_model/horizontal_formatting-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/formatting_model/replaced_elements-expected.txt:
  • layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/css1/pseudo/firstletter-expected.txt:
  • layout-tests/css1/pseudo/firstline-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • layout-tests/css1/text_properties/letter_spacing-expected.txt:
  • layout-tests/css1/text_properties/line_height-expected.txt:
  • layout-tests/css1/text_properties/text-transform-expected.txt:
  • layout-tests/css1/text_properties/text_align-expected.txt:
  • layout-tests/css1/text_properties/text_decoration-expected.txt:
  • layout-tests/css1/text_properties/text_indent-expected.txt:
  • layout-tests/css1/text_properties/text_transform-expected.txt:
  • layout-tests/css1/text_properties/vertical_align-expected.txt:
  • layout-tests/css1/text_properties/word_spacing-expected.txt:
  • layout-tests/css1/units/color_units-expected.txt:
  • layout-tests/css1/units/length_units-expected.txt:
  • layout-tests/css1/units/percentage_units-expected.txt:
  • layout-tests/css1/units/urls-expected.txt:
  • layout-tests/fast/block/basic/010-expected.txt:
  • layout-tests/fast/block/basic/011-expected.txt:
  • layout-tests/fast/block/float/001-expected.txt:
  • layout-tests/fast/block/float/004-expected.txt:
  • layout-tests/fast/block/float/005-expected.txt:
  • layout-tests/fast/block/float/006-expected.txt:
  • layout-tests/fast/block/float/013-expected.txt:
  • layout-tests/fast/block/float/014-expected.txt:
  • layout-tests/fast/block/float/016-expected.txt:
  • layout-tests/fast/block/float/024-expected.txt:
  • layout-tests/fast/block/margin-collapse/001-expected.txt:
  • layout-tests/fast/block/margin-collapse/005-expected.txt:
  • layout-tests/fast/block/margin-collapse/006-expected.txt:
  • layout-tests/fast/block/margin-collapse/010-expected.txt:
  • layout-tests/fast/block/margin-collapse/011-expected.txt:
  • layout-tests/fast/block/margin-collapse/012-expected.txt:
  • layout-tests/fast/block/margin-collapse/015-expected.txt:
  • layout-tests/fast/block/margin-collapse/016-expected.txt:
  • layout-tests/fast/block/margin-collapse/017-expected.txt:
  • layout-tests/fast/block/margin-collapse/018-expected.txt:
  • layout-tests/fast/block/margin-collapse/019-expected.txt:
  • layout-tests/fast/block/margin-collapse/020-expected.txt:
  • layout-tests/fast/block/margin-collapse/021-expected.txt:
  • layout-tests/fast/block/margin-collapse/022-expected.txt:
  • layout-tests/fast/block/margin-collapse/024-expected.txt:
  • layout-tests/fast/block/margin-collapse/025-expected.txt:
  • layout-tests/fast/block/margin-collapse/026-expected.txt:
  • layout-tests/fast/block/margin-collapse/027-expected.txt:
  • layout-tests/fast/block/margin-collapse/028-expected.txt:
  • layout-tests/fast/block/margin-collapse/029-expected.txt:
  • layout-tests/fast/block/margin-collapse/031-expected.txt:
  • layout-tests/fast/block/margin-collapse/032-expected.txt:
  • layout-tests/fast/block/margin-collapse/033-expected.txt:
  • layout-tests/fast/block/margin-collapse/034-expected.txt:
  • layout-tests/fast/block/margin-collapse/035-expected.txt:
  • layout-tests/fast/block/margin-collapse/041-expected.txt:
  • layout-tests/fast/block/margin-collapse/042-expected.txt:
  • layout-tests/fast/block/margin-collapse/043-expected.txt:
  • layout-tests/fast/block/positioning/001-expected.txt:
  • layout-tests/fast/block/positioning/002-expected.txt:
  • layout-tests/fast/block/positioning/053-expected.txt:
  • layout-tests/fast/block/positioning/056-expected.txt:
  • layout-tests/fast/block/positioning/058-expected.txt:
  • layout-tests/fast/block/positioning/060-expected.txt:
  • layout-tests/fast/clip/014-expected.txt:
  • layout-tests/fast/compact/001-expected.txt:
  • layout-tests/fast/compact/002-expected.txt:
  • layout-tests/fast/css-generated-content/006-expected.txt:
  • layout-tests/fast/css/005-expected.txt:
  • layout-tests/fast/dynamic/001-expected.txt:
  • layout-tests/fast/dynamic/007-expected.txt: Added.
  • layout-tests/fast/dynamic/007.html: Added.
  • layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
  • layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
  • layout-tests/fast/flexbox/007-expected.txt:
  • layout-tests/fast/flexbox/008-expected.txt:
  • layout-tests/fast/flexbox/009-expected.txt:
  • layout-tests/fast/flexbox/016-expected.txt:
  • layout-tests/fast/flexbox/022-expected.txt:
  • layout-tests/fast/flexbox/025-expected.txt:
  • layout-tests/fast/frames/001-expected.txt:
  • layout-tests/fast/lists/007-expected.txt:
  • layout-tests/fast/overflow/005.html: Added.
  • layout-tests/fast/replaced/001-expected.txt:
  • layout-tests/fast/replaced/002-expected.txt:
  • layout-tests/fast/replaced/003-expected.txt:
  • layout-tests/fast/replaced/004-expected.txt:
  • layout-tests/fast/selectors/001-expected.txt:
  • layout-tests/fast/selectors/006-expected.txt:
  • layout-tests/fast/selectors/007a-expected.txt:
  • layout-tests/fast/selectors/008-expected.txt:
  • layout-tests/fast/selectors/012-expected.txt:
  • layout-tests/fast/selectors/013-expected.txt:
  • layout-tests/fast/selectors/015-expected.txt:
  • layout-tests/fast/selectors/027-expected.txt:
  • layout-tests/fast/selectors/058-expected.txt:
  • layout-tests/fast/table/001-expected.txt:
  • layout-tests/fast/table/003-expected.txt:
  • layout-tests/fast/table/005-expected.txt:
  • layout-tests/fast/table/009-expected.txt:
  • layout-tests/fast/table/016-expected.txt:
  • layout-tests/fast/table/024-expected.txt:
  • layout-tests/fast/table/025-expected.txt:
  • layout-tests/fast/table/031-expected.txt:
  • layout-tests/fast/table/032-expected.txt:
  • layout-tests/fast/table/033-expected.txt:
  • layout-tests/fast/text/basic/012-expected.txt:
  • layout-tests/fast/text/international/003-expected.txt: Added.
  • layout-tests/fast/text/international/003.html: Added.
  • layout-tests/fast/text/whitespace/002-expected.txt:
  • layout-tests/fast/text/whitespace/003-expected.txt:
  • layout-tests/fast/text/whitespace/004-expected.txt:
  • layout-tests/fast/text/whitespace/005-expected.txt:
  • layout-tests/fast/text/whitespace/010-expected.txt:
  • layout-tests/fast/text/whitespace/011-expected.txt:
  • layout-tests/fast/text/whitespace/012-expected.txt:
  • layout-tests/fast/text/whitespace/015-expected.txt:
  • layout-tests/fast/text/whitespace/016-expected.txt:
  • layout-tests/fast/text/whitespace/017-expected.txt:
  • layout-tests/fast/text/whitespace/018-expected.txt:
  • layout-tests/fast/text/whitespace/021-expected.txt:
  • layout-tests/fast/text/whitespace/024-expected.txt:
10:08 PM Changeset in webkit [5789]
  • 1 copy
    117 deletes in branches/unlabeled-1.48.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.48.4'.

7:23 PM Changeset in webkit [5788] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): Fix build-bustin' typo.
5:37 PM Changeset in webkit [5787] by rjw
  • 6 edits in trunk/JavaScriptCore

Added implementation of stubs in JSObject. All that
remains is a couple of simple conversion functions stubs and
we're done with LiveConnect. Also, changed string passing to
JS to use uchars instead of chars.

Reviewed by Maciej.

4:57 PM Changeset in webkit [5786] by cblu
  • 13 edits in trunk

WebCore:

Fixed: <rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

Reviewed by rjw.

  • khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::encoding): pass the page URL to signedPublicKeyAndChallengeString
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::signedPublicKeyAndChallengeString): take a URL
  • kwq/WebCoreKeyGenerator.h:
  • kwq/WebCoreKeyGenerator.m: (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a URL

WebKit:

Fixed:
<rdar://problem/3396936>: can't obtain a digital ID from Verisign, form submission fails
<rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

Reviewed by rjw.

  • English.lproj/Localizable.strings:
  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): take a key description arg and use it, take and return CFStrings, handle the empty string case (addCertificatesToKeychainFromData): return a WebCertificateParseResult so WB knows how to handle the cert
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a page URL so we can use its host name in the key description
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed: <rdar://problem/3506645>: open PKCS7 encoded certificates downloaded from Verisign in Keychain Access

Reviewed by rjw.

  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): open PKCS7 files in Keychain Access
  • English.lproj/StringsNotToBeLocalized.txt:
4:23 PM Changeset in webkit [5785] by hyatt
  • 11 edits in trunk/WebCore

Fix for 3254534, CSS background-image style should be loaded lazily only when used.

Reviewed by rjw

  • ChangeLog:
  • khtml/css/css_valueimpl.cpp: (CSSImageValueImpl::CSSImageValueImpl): (CSSImageValueImpl::~CSSImageValueImpl): (CSSImageValueImpl::image):
  • khtml/css/css_valueimpl.h:
3:25 PM Changeset in webkit [5784] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3508825>: REGRESSION (100-116): crash in HTMLGenericFormElementImpl::attach at sonyericsson.com

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Move a few lines inside an existing nil check to prevent nil dereference.
2:01 PM Changeset in webkit [5783] by sullivan
  • 4 edits in trunk/WebCore
  • fixed <rdar://problem/3508760>: tabbing to out-of-sight link behaves differently than tabbing to out-of-sight form control

Reviewed by Dave.

  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::ensureVisible): added comments and changed parameter names to reveal differences between what we've implemented and what QScrollView was intended to do. (QScrollView::ensureRectVisibleCentered): New method that calls _KWQ_scrollRectToVisible, which is the method we use when scrolling to reveal form controls.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): call ensureRectVisibleCentered so tabbing to a link will use the same scroll-to-reveal code as tabbing to a form control
12:18 PM Changeset in webkit [5782] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3507856>: XMLHttpRequest xhtml test displays but doesn't load

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::tryCall): complete the URL using the document, not the htmlDocument.
12:01 PM Changeset in webkit [5781] by vicki
  • 2 edits in trunk/WebKit

Reviewed by me.

  • change the WebKit version number back to 118u for tip of tree builds
  • WebKit.pbproj/project.pbxproj:
11:14 AM Changeset in webkit [5780]
  • 4 copies in tags/Safari-117

This commit was manufactured by cvs2svn to create tag 'Safari-117'.

11:14 AM Changeset in webkit [5779] by vicki
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (OOPS!).

  • fix version number for submission (117)
  • WebKit.pbproj/project.pbxproj:
10:14 AM Changeset in webkit [5778] by vicki
  • 2 edits in trunk/WebKit

Reviewed by kocienda.

  • fix buildit build bustage. INSTALL_PATH should be '=', not '+=' (probably changed unintentionally)
  • WebKit.pbproj/project.pbxproj:
9:32 AM Changeset in webkit [5777] by rjw
  • 6 edits in trunk

JavaScriptCore:

Ensure that all calls from Java into JavaScript are
performed on a designated thread (the main thread).

Reviewed by Ken.

  • bindings/jni_jsobject.cpp: (isJavaScriptThread): (rootForImp): (Bindings::performJavaScriptAccess): (Bindings::completedJavaScriptAccess): (Bindings::initializeJavaScriptAccessLock): (Bindings::lockJavaScriptAccess): (Bindings::unlockJavaScriptAccess): (Bindings::dispatchToJavaScriptThread): (Bindings::RootObject::setFindRootObjectForNativeHandleFunction): (Bindings::RootObject::removeAllJavaReferencesForRoot): (Bindings::JSObject::invoke): (Bindings::JSObject::JSObject): (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::removeMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::setSlot): (Bindings::JSObject::toString): (Bindings::JSObject::finalize): (Bindings::JSObject::getWindow):
  • bindings/jni_jsobject.h: (Bindings::RootObject::~RootObject): (Bindings::RootObject::findRootObjectForNativeHandleFunction): (Bindings::RootObject::runLoop): (Bindings::RootObject::performJavaScriptSource): (Bindings::):

WebCore:

Replace calls to global functions with static member functions.

Reviewed by Ken.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):

Dec 11, 2003:

5:54 PM Changeset in webkit [5776] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3464315>: createDocument creates document with initial child element, unlike other browsers

  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Don;t add initial element.
5:32 PM Changeset in webkit [5775] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507863>: XMLHttpRequest should not parse response if HTML

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty):
4:48 PM Changeset in webkit [5774] by rjw
  • 12 edits in trunk

JavaScriptCore:

Added support for calling a JavaScript function from
Java. Right now this only works for void func(void)
functions, but the conversion of args and return values
will come shortly.

Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

Removed link hack for testkjs now that the Java folks think
they have a solution for the 1.4.2 JavaVM link problem. Although
Greg B. thinks his solution may cause problems for the 1.3.1
version of the VM!?!

Reviewed by Ken.

  • Makefile.am:
  • bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString):
  • bindings/jni/jni_utility.cpp: (convertValueToJValue): (convertValueToJObject): (listFromJArray):
  • bindings/jni/jni_utility.h:
  • bindings/jni_jsobject.cpp: (KJS_setFindRootObjectForNativeHandleFunction): (KJS_findRootObjectForNativeHandleFunction): (getReferencesByRootDictionary): (getReferencesDictionary): (findReferenceDictionary): (rootForImp): (addJavaReference): (removeJavaReference):
  • bindings/jni_jsobject.h: (Bindings::RootObject::RootObject): (Bindings::RootObject::~RootObject): (Bindings::RootObject::setRootObjectImp): (Bindings::RootObject::rootObjectImp): (Bindings::RootObject::setInterpreter): (Bindings::RootObject::interpreter):

WebCore:

Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

Reviewed by Ken.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
3:56 PM Changeset in webkit [5773] by kocienda
  • 6 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3489280>: redirect via post blows cache, causing everything to get reloaded

Now POST requests reload the main document by default, but will not reload
all subresources.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Take the cache policy for subresources from the original request, rather than the data source's current request.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient _isPostOrRedirectAfterPost:redirectResponse:]): New helper. (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): Call new helper to set the cache policy on the main resource load.
3:50 PM Changeset in webkit [5772] by mjs
  • 5 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3507862>: XMLHttpRequest documents that reference external resources (e.g. stylesheets) cause crash

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler):
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::processingInstruction): (XMLTokenizer::executeScripts):
3:30 PM Changeset in webkit [5771] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Chris.

<rdar://problem/3507859>: Status text should only include "OK", not full "HTTP/1.0 200 OK" status line

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getStatusText): Include only the status text, not the full status line.
2:59 PM Changeset in webkit [5770]
  • 1 copy
    25 deletes in branches/unlabeled-1.275.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.275.2'.

2:59 PM Changeset in webkit [5769] by vicki
  • 3 edits in trunk

the tree is open for Safari-118

2:55 PM Changeset in webkit [5768] by vicki
  • 6 edits in trunk

Safari-117 stamp, plus a few site changes

1:43 PM Changeset in webkit [5767] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • WebCoreSupport.subproj/WebBridge.m: time_t is a signed type, so casting -1 to a time_t does not work to make a max value. We'll go with INT_MAX.
11:48 AM Changeset in webkit [5766] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix duplicate changelog entry

11:46 AM Changeset in webkit [5765] by hyatt
  • 203 edits in trunk/LayoutTests

Landing changed layout tests that don't dump incorrect backgrounds.

11:39 AM Changeset in webkit [5764] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3507164, scrolling really slow on hixie's web forms spec page. Hixie has 12 little transparent layers
at various points on this page, and beginning/ending transparency on only those 12 layers as you scroll
is enough to kill scrolling performance.

This patch works around the issue by lazily beginning transparency layers only when we determine that
we're actually painting a descendant layer of a transparent ancestor or a transparent layer.

Also fixing QColor's comparison operator. It was broken and not comparing the "valid" bit, so invalid and
valid colors were being assumed to be the same.

Also fixed the render dumper to not dump transparent and invalid background colors and fixed it do dump the
alpha for colors with an alpha < 0xFF.

Reviewed by mjs (opacity changes), darin (color changes) and john (render tree dumper changes)

  • ChangeLog:
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::beginTransparencyLayers): (RenderLayer::paint): (RenderLayer::paintLayer):
  • khtml/rendering/render_layer.h:
  • kwq/KWQColor.h: (operator==): (operator!=):
  • kwq/KWQColor.mm: (QColor::name):
  • kwq/KWQRenderTreeDebug.cpp: (operator<<):
11:12 AM Changeset in webkit [5763] by kocienda
  • 4 edits in trunk/WebKit

Reviewed and C++ heavy-lifting by Darin

Fix warnings in C++ files.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): Add cast to remove warning. (addCertificatesToKeychainFromData): Add cast to remove warning.
  • WebKit.pbproj/project.pbxproj: Add back warnings to C++ files.
  • WebKitPrefix.h: Add define for NULL that works for C++.
11:00 AM Changeset in webkit [5762] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • kwq/KWQLoader.mm: (KWQCacheObjectExpiresTime): Fixed deployment build bustage.
8:11 AM Changeset in webkit [5761] by kocienda
  • 7 edits in trunk

WebCore:

Reviewed by Darin

<rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

  • khtml/misc/loader.cpp: (Loader::slotFinished): Don't reset expiration date. We set this once in slotReceivedResponse. (Loader::slotReceivedResponse): Call new KWQ function to get a cache object's expiration date using its NSURLResponse data. (Cache::requestImage): Don't reset expiration date. We set this once in slotReceivedResponse, and we do not want the value from the DocLoader anyway. (Cache::requestStyleSheet): Ditto. (Cache::requestScript): Ditto.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQCacheObjectExpiresTime): New function. Call over bridge to get access to SPI in NSURLResponse to calculate expiration time.
  • kwq/WebCoreBridge.h: Declare bridge method.

WebKit:

Reviewed by Darin

<rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): New method. Call response freshness lifetime method and add it to the current time to yield an expiration time.

Dec 10, 2003:

10:56 PM Changeset in webkit [5760] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3504156>: XMLHttpRequest reuse test fails
<rdar://problem/3505158>: XMLHttpRequest "abort with open" test fails

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::open): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequestProtoFunc::tryCall):
10:50 PM Changeset in webkit [5759] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507175>: Setting timeout function can allocate JS objects without lock

  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Lock interpreter around code that might allocate JS objects.
10:26 PM Changeset in webkit [5758]
  • 1 copy
    126 deletes in branches/unlabeled-1.1.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.1.2'.

10:26 PM Changeset in webkit [5757] by hyatt
  • 1 add in trunk/LayoutTests/fast/overflow/005.html

Adding overflow test with auto height.

10:25 PM Changeset in webkit [5756] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3507097, overflow:auto should include the height of the horizontal scrollbar when the height
of the block is auto.

Reviewed by darin

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren):
9:15 PM Changeset in webkit [5755] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3506739: nil-deref in DocumentImpl::setSelection triple clicking (generated content)
  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent): Check for the case where m_selectionEnd is 0. This doesn't fix the behavior completely, but it does prevent a crash.
8:55 PM Changeset in webkit [5754] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Richard.

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::processSyncLoadResults): (KJS::XMLHttpRequest::slotRedirection): (KJS::XMLHttpRequest::slotData):
  • khtml/ecma/xmlhttprequest.h:
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQServeSynchronousRequest): (KWQResponseHeaderString):
  • kwq/WebCoreBridge.h:

WebKit:

Reviewed by Richard.

WebKit part of fix for:

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
8:55 PM Changeset in webkit [5753] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed regression in JavaScript tests reported by the KDE guys
  • fixed 3506345: REGRESSION (115-116): VIP: chordfind.com no longer displays chords
  • kjs/ustring.h: Add tolerateEmptyString parameter to toDouble and toULong.
  • kjs/ustring.cpp: (KJS::UString::toDouble): Separate the "tolerant" parameter into two separate ones: tolerateTrailingJunk and tolerateEmptyString. Add new overloads; better for code size and binary compatibility than default parameter values. (KJS::UString::toULong): Pass tolerateEmptyString down to toDouble. Add new overload.
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Pass false for the new "tolerate empty string" parameter.
8:49 PM Changeset in webkit [5752] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3506706: REGRESSION (100-115): onkeyup handlers called twice for active input fields
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]): Don't call super because we don't want to pass the event down the responder chain.
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Return NO for key up events because we don't want to pass the event down the responder chain.
8:47 PM Changeset in webkit [5751] by hyatt
  • 1 edit in trunk/JavaScriptCore/bindings/jni_jsobject.cpp

Fix optimized build bustage.

6:20 PM Changeset in webkit [5750] by rjw
  • 11 edits in trunk

WebKit:

Added method to get to the bridge from a view. This is
used to ultimately get the part and KJS::Window for a
particular applet.

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]): (-[WebViewFactory bridgeForView:]):

WebCore:

Added method to get to the bridge from a view. This is
used to ultimately get the part and KJS::Window for a
particular applet.

Reviewed by Hyatt.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m:

JavaScriptCore:

Added code to manage reference counting of JavaScript
objects passed to Java. Also added implementation of
KJS_JSCreateNativeJSObject. This is the function that
provides the root object to Java (KJS::Window).

Reviewed by Hyatt.

  • JavaScriptCore.pbproj/project.pbxproj:
  • bindings/jni_jsobject.cpp: (KJS_setFindObjectForNativeHandleFunction): (KJS_findObjectForNativeHandleFunction): (getReferencesByOwnerDictionary): (getReferencesDictionary): (findReferenceDictionary): (addJavaReference): (removeJavaReference): (removeAllJavaReferencesForOwner):
  • bindings/jni_jsobject.h:
5:47 PM Changeset in webkit [5749] by sullivan
  • 10 edits in trunk

WebCore:

  • WebCore part of fix for: <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

Reviewed by Darin.

  • kwq/KWQNSViewExtras.h:
  • kwq/KWQNSViewExtras.m: (-[NSView _KWQ_scrollPointRecursive:]): (-[NSView _KWQ_scrollPointRecursive:inView:]): new methods, similar to existing scrollRect methods except that the preferred position for the point is the top-left corner rather than centered in the visible area
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPosRecursive): new method, calls _KWQ_scrollPointRecursive:
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): call setContentsPosRecursive instead of setContentsPos; also remove the 50 pixel offset that upset Hyatt so.

WebKit:

  • WebKit part of fix for: <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

Reviewed by Darin

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: removed _web_scrollPointToVisible:fromView:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollPoint:]): removed call to _web_scrollPointToVisible:fromView:
4:34 PM Changeset in webkit [5748] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

Reviewed by kocienda.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): tweak (addCertificateToKeychainFromData): renamed to use lowercase "c" in "keychain" (addCertificatesToKeychainFromData): take data instead of a path to a file
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): added temporary workaround for 3396936

WebBrowser:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

Reviewed by me, kocienda.

  • BrowserNSDataExtras.h:
  • BrowserNSDataExtras.m: new categories implemented by kocienda. (-[NSData indexOfCharacterInCString:]): (-[NSData indexOfCString:]): (-[NSData indexOfCString:startOffset:]): (-[NSData indexOfByteString:length:]): (-[NSData indexOfByteString:length:startOffset:]): (-[NSData certificateFromMultipartData]): extracts the cert
  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): if the file is multipart/mixed, attempt to extract the cert using certificateFromMultipartData
2:39 PM Changeset in webkit [5747] by cblu
  • 2 edits in trunk/WebCore
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::signedPublicKeyAndChallengeString): removed unnecessary includes
2:34 PM Changeset in webkit [5746] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3505846, overflow:auto region doesn't update when scrolled. The child layers inside an overflow:auto
block were not updating their positions.

Reviewed by john

  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPositions): (RenderLayer::scrollToOffset):
  • khtml/rendering/render_layer.h:
1:47 PM Changeset in webkit [5745] by mjs
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Corrected ChangeLog entry.

1:46 PM Changeset in webkit [5744] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3505795>: loading invalid XML document crashes trying to create h1 element

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::isValidName): include "0123456789" instead of "0-9", it's not a regexp it's just a list of characters.
1:42 PM Changeset in webkit [5743] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3504155>: Safari fails XMLHttpRequest abort test

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::tryCall): Avoid throwing an exception after send().
1:14 PM Changeset in webkit [5742] by hyatt
  • 11 edits in trunk/WebCore

Rename -apple-aqua to auto for outline styles.

Reviewed by darin

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder): (RenderObject::paintOutline):
  • khtml/rendering/render_style.h: (khtml::): (khtml::OutlineValue::OutlineValue): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineOffset):
  • kwq/KWQRenderTreeDebug.cpp: (printBorderStyle):

Dec 9, 2003:

8:09 PM Changeset in webkit [5741] by mjs
  • 7 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3487195>: Implement responseXML property for XMLHttpRequest

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Implemented responseXML by parsing the document and returning it. (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new field
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/kjs_window.cpp: (Windw::get): Forgot this in last commit; add XMLSerializer constructor.
  • khtml/ecma/kjs_window.lut.h:
  • khtml/ecma/Makefile.am: Forgot to include this in the last commit.
8:05 PM Changeset in webkit [5740] by mjs
  • 5 edits
    3 adds in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3504049>: XMLSerializer object and serializeToString method needed for XMLHttpRequest testing

Also fixed some lasst-minute mistakes in the DOM serialization
code that was already there.

  • WebCore.pbproj/project.pbxproj:
  • khtml/dom/dom_doc.h:
  • khtml/ecma/Makefile.am:
  • khtml/ecma/kjs_window.cpp: (Window::get):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/ecma/xmlserializer.cpp: Added. (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): (KJS::XMLSerializerConstructorImp::implementsConstruct): (KJS::XMLSerializerConstructorImp::construct): (KJS::): (KJS::XMLSerializer::XMLSerializer): (KJS::XMLSerializerProtoFunc::tryCall):
  • khtml/ecma/xmlserializer.h: Added. (KJS::XMLSerializer::toBoolean): (KJS::XMLSerializer::classInfo): (KJS::XMLSerializer::):
  • khtml/ecma/xmlserializer.lut.h: Added. (KJS::):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::toString): (DocumentFragmentImpl::toString):
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::toString):
5:23 PM Changeset in webkit [5739] by hyatt
  • 4 edits in trunk/WebCore

Implement start() and stop() for marquees.

Reviewed by darin

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::classInfo): (KJS::HTMLElementFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
5:05 PM Changeset in webkit [5738] by rjw
  • 3 edits
    2 adds in trunk/JavaScriptCore

LiveConnect stubs that correspond to the native methods
on JSObject. These will be called from the new Java plugin
when an instance of JSObject is instantiated and messaged.
When these are implemented the Java will be able to originate
calls into JavaScript.

Also a temporary work-around added to Makefile.am to solve
a link problem. The 1.4.2 JavaVM accidentally links against
libobjc. This call a failure linking testkjs. Mike Hay is
working with someone to fix the problem (3505587).

Reviewed by Chris.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/jni_jsobject.cpp: Added. (KJS_JSCreateNativeJSObject): (KJS_JSObject_JSFinalize): (KJS_JSObject_JSObjectCall): (KJS_JSObject_JSObjectEval): (KJS_JSObject_JSObjectGetMember): (KJS_JSObject_JSObjectSetMember): (KJS_JSObject_JSObjectRemoveMember): (KJS_JSObject_JSObjectGetSlot): (KJS_JSObject_JSObjectSetSlot): (KJS_JSObject_JSObjectToString):
  • bindings/jni_jsobject.h: Added.
4:53 PM Changeset in webkit [5737] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed 3505277: nil-deref in ownerElement after choosing item from menu at projectnissan.com
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Add check for nil.
4:46 PM Changeset in webkit [5736] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveLocationProperties): Add locking around the call to get the location since it can allocate. (KWQKHTMLPart::restoreLocationProperties): Ditto.
4:29 PM Changeset in webkit [5735] by hyatt
  • 2 edits in trunk/WebCore

Fix for mojibake bg painting problem on bofa.com. The bug # is 3487144. Transparent colors were not
being handled properly when specified on the body.

Reviewed by darin

  • khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):
3:39 PM Changeset in webkit [5734] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3505391: REGRESSION (100-116): pages that move cells around don't repaint correctly
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): Added code similar to the code in RenderBlock::layoutBlock, but for table cells.
3:38 PM Changeset in webkit [5733] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add locking around the call to push event handler scope. Without this, we hit the "allocated without locking" assertion.
3:15 PM Changeset in webkit [5732] by hyatt
  • 5 edits in trunk/WebCore

Fix the dirty rect checks on various render_objects to be more accurate so that page-break properties don't
have mojibake when printing.

Reviewed by john

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
  • khtml/rendering/render_table.cpp: (RenderTable::paint):
3:01 PM Changeset in webkit [5731] by darin
  • 5 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3500408: Web Kit should pass the MAYSCRIPT attribute from the APPLET tag to the Java plug-in
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): Allow the "mayscript" attribute. (HTMLAppletElementImpl::createRenderer): Pass the value of the "mayscript" attribute as an argument named "mayScript".
  • khtml/misc/htmlattrs.in: Added "mayscript".
  • khtml/misc/htmlattrs.c: Regenerated.
  • khtml/misc/htmlattrs.h: Regenerated.
2:26 PM Changeset in webkit [5730] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

<rdar://problem/3505183>: JavaScriptCore should assert that interpreter is locked in collector

  • kjs/collector.cpp: (KJS::Collector::allocate): Assert that interpreter lock count is not 0. (KJS::Collector::collect): likewise
2:26 PM Changeset in webkit [5729] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3501030>: JavaScript sites crash when a PAC file is in place (WebCore,Safari 1.2)

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Lock interpreter when needed. (JSLazyEventListener::parseCode): Likewise. (KJS::getDOMEvent): Likewise.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Likewise. (KJSProxyImpl::initScript): Likewise.
2:11 PM Changeset in webkit [5728] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3491235, really make <script src="..."/> work in HTML. My original attempt to fix this only made
the tag flat, but did not ensure that the script got processed.

Reviewed by john

  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
1:52 PM Changeset in webkit [5727] by cblu
  • 7 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): (addCertificateToKeyChainFromData): new (addCertificateToKeyChainFromFile): new
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator addCertificateToKeyChainFromFileAtPath:]): new
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj: made WebKeyGenerator.h private

WebBrowser:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

Reviewed by darin.

  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): new, calls [WebKeyGenerator addCertificateToKeyChainFromFileAtPath:] (-[DownloadProgressEntry autoOpen]): call _addCertificateToKeyChain
1:23 PM Changeset in webkit [5726] by sullivan
  • 2 edits in trunk/WebKit
  • fixed <rdar://problem/3504907>: REGRESSION (100-116): Clicking QuickTime-requiring link twice crashes (wholenote.com)

I found the bug; Darin wrote the fix; I reviewed and tested.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): Rewrote this method to not use GetIndString, because GetIndString looks at all open resource files and in this case was reading information from the wrong plugin file.
11:56 AM Changeset in webkit [5725] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Adding a dynamic cell array test.

Note: See TracTimeline for information about the timeline view.