Timeline



Dec 15, 2003:

10:24 PM Changeset in webkit [5804] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed a couple of snafus and removed some logging.

Reviewed by Maciej.

  • bindings/jni_jsobject.cpp: (Bindings::performJavaScriptAccess): (Bindings::completedJavaScriptAccess): (Bindings::dispatchToJavaScriptThread): Removed some annoying JS_LOG clutter.

(Bindings::RootObject::removeAllJavaReferencesForRoot):
Fixed allocation of key buffer that was called after it was needed.

(Bindings::JSObject::invoke):
(Bindings::JSObject::JSObject):
(Bindings::JSObject::getMember):
(Bindings::JSObject::getSlot):
Added additional interpreter locks around getMember and getSlot.
These functions may cause allocation of JS impls.

5:27 PM Changeset in webkit [5803] by rjw
  • 3 edits in trunk/JavaScriptCore

args weren't passed to 'call' invocation. d'oh.
lock interpreter when we create instances of JS impls.

Reviewed by Maciej.

  • bindings/jni_jsobject.cpp: (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::convertValueToJObject): (Bindings::JSObject::convertJObjectToValue): (Bindings::JSObject::listFromJArray):
  • bindings/jni_jsobject.h:
4:45 PM Changeset in webkit [5802] by hyatt
  • 8 edits in trunk/WebCore

Fix for 3508807, positions/sizes wrong for text elts and multi-line elts for accessibility.

Reviewed by john

  • khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::absoluteRects):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (RenderText::absoluteRects):
  • khtml/rendering/render_text.h:
  • kwq/KWQAccObject.mm: (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]):
3:14 PM Changeset in webkit [5801] by rjw
  • 9 edits in trunk

JavaScriptCore:

Last piece of LiveConnect! This checkin adds implementation
of the Java to JavaScript object conversion functions.

Reviewed by John.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_utility.cpp:
  • bindings/jni/jni_utility.h:
  • bindings/jni_jsobject.cpp: (Bindings::JSObject::invoke): (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::setSlot): (Bindings::JSObject::createNative): (Bindings::JSObject::convertValueToJObject): (Bindings::JSObject::convertJObjectToValue): (Bindings::JSObject::listFromJArray):
  • bindings/jni_jsobject.h: (Bindings::):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::get): (RuntimeMethodImp::codeType): (RuntimeMethodImp::execute):

WebCore:

Return 0 if the view doesn't have a bridge.

Reviewed by John.

  • kwq/WebCoreBridge.mm: (rootForView):
1:44 PM Changeset in webkit [5800] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3505546>: always get keychain prompt when sending mail using cert downloaded with Safari

Reviewed by john.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): set up the SecAccessRef with "everything goes" restrictions
1:38 PM Changeset in webkit [5799] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3508792. Remove tables and cells as AxObjects.

Reviewed by john

  • kwq/KWQAccObject.mm: (-[KWQAccObject role]): (-[KWQAccObject accessibilityIsIgnored]):
1:28 PM Changeset in webkit [5798] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3510459>: REGRESSION (100-113): Pressing button at google.com removes focus from text field

Reviewed by Dave.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't clear the focused widget when a mousedown occurs on a widget that is focusable in the abstract sense but is not mouse focusable or currently keyboard focusable. This matches the behavior of older Safaris (clicking in background or page text will make the webview itself be first responder, but clicking on a button won't).

Dec 14, 2003:

8:58 PM Changeset in webkit [5797] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3458937: nil-deref in timed layout
  • khtml/khtmlview.cpp: (KHTMLView::layout): Add a nil check for m_part.
4:46 PM Changeset in webkit [5796] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Maciej.

  • fixed 3311205: click() on a file input type form element does not work bring up the file chooser as it does in IE
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::click): Add a case for FILE that calls RenderFileButton's click() function. Get rid of the default case and list more cases explicitly. (HTMLInputElementImpl::accessKeyAction): Change FILE from just focus to focus/click.
  • khtml/rendering/render_form.h: Added a click() function to RenderFileButton.
  • khtml/rendering/render_form.cpp: (RenderFileButton::slotTextChanged): Added call to onChange on the element to match text input fields; helpful for the test case Adobe supplied. (RenderFileButton::click): Added. Calls click() on KWQFileButton.
  • kwq/KWQFileButton.h: Added a click function.
  • kwq/KWQFileButton.mm: (KWQFileButton::click): Added. Calls performClick on the file button.
  • kwq/WebCoreBridge.h: Add a performClick method to WebCoreFileButton.

WebKit:

Reviewed by Maciej.

  • fixed 3311205: click() on a file input type form element does not work bring up the file chooser as it does in IE
  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton performClick]): Add method for clicking, now part of the WebCoreFileButton protocol. The rest of the fix is in WebCore.
3:50 PM Changeset in webkit [5795] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3269212>: FILEMAKER: can't use Option objects created in a different window

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::updateDOMObjectDocument): Update per-document caching for the DOM object - let it be protected by both the old and the new document.
  • khtml/ecma/kjs_binding.h: Prototype new method.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::setDocument): New method to change a node's document pointer. (NodeImpl::checkAddChild): If the new child node is owned by the wrong document but not actually in it, change its document (using the two aforementioned methods) instead of throwing an exception.
  • khtml/xml/dom_nodeimpl.h: Prototype new method.
9:10 AM Changeset in webkit [5794] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3332280: REGRESSION (74-85): setting src of iframe results in two GETs
  • khtml/html/html_baseimpl.h: Added openURL virtual function.
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Call openURL to do the meat of the work, since it's different for frames and iframes. (HTMLFrameElementImpl::openURL): Move the part that's different for frames in here. (HTMLFrameElementImpl::parseAttribute): Call setLocation to share code. (HTMLFrameElementImpl::setLocation): Do nothing if the location is not changing. Not needed to fix this bug, but could eliminate other cases of extra GETs. (HTMLIFrameElementImpl::parseAttribute): Remove special handling of SRC, because now we will end up calling openURL, which will do the right thing for iframes. (HTMLIFrameElementImpl::openURL): Instead of doing the change to the frame directly, use updateWidget, since that's what we do for other changes to iframes. To trigger a call to updateWidget(), set needWidgetUpdate and mark the node changed.

Dec 13, 2003:

10:43 PM Changeset in webkit [5793] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507885>: REGRESSION (100-116): frames missing due to cross-domain check (derstandard.at)

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Loosen the frame access rules a bit. We already allowed access to a document loaded as empty from the parent or opener. Now also allow access from any document in the same domain as the parent or opener, so that, for instance, a sibling frame can access it so long as it is in the same domain as the parent.
4:43 PM Changeset in webkit [5792] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3506204: homepage.mac slide show window is wrong size on 2nd monitor
  • kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): Add code to flip the Y coordinate. This has no effect on the main screen, but a big effect on others. I used the same code to flip Y screen coordinates that is used KWQWindowWidget.mm and KWQKHTMLPartBrowserExtension.mm.
  • kwq/KWQKWinModule.mm: (KWinModule::workArea): Replaced the incorrect code to flip the Y coordinate here with correct code. The code flipped based on the frame of the main screen, but it needs to flip based on the frame of screen 0.
10:06 AM Changeset in webkit [5791] by darin
  • 2 edits in trunk/WebKit

Fixed by Ed Voas, reviewed by me.

  • fixed 3278443: CARBON: grow box obscures scroll bar knob
  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _growBoxRect]): Return the grow box so AppKit's scroll bar code will know where it is.

Dec 12, 2003:

10:08 PM Changeset in webkit [5790] by kocienda
  • 305 edits
    2 deletes in branches

Reviewed by me

Merged HEAD to tip of branch

  • ChangeLog:
  • English.lproj/InfoPlist.strings:
  • WebCore-combined.exp:
  • WebCore.exp:
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_valueimpl.cpp: (CSSImageValueImpl::CSSImageValueImpl): (CSSImageValueImpl::~CSSImageValueImpl): (CSSImageValueImpl::image):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::addSheet): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::applyRule):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/dom/dom_doc.cpp: (DOM::Document::createElement): (DOM::Document::createElementNS): (DOM::Document::part):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/Makefile.am:
  • khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (KJS::checkNodeSecurity): (KJS::getDOMNamedNodeMap): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): (JSLazyEventListener::parseCode): (KJS::getDOMEvent):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): (KJS::HTMLDocument::tryGet): (KJS::HTMLDocument::putValue): (KJS::HTMLElement::classInfo): (KJS::HTMLElement::tryGet): (KJS::HTMLElementFunction::tryCall): (KJS::HTMLCollection::tryGet): (Image::notifyFinished):
  • khtml/ecma/kjs_html.h: (KJS::HTMLElement::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilter::acceptNode):
  • khtml/ecma/kjs_window.cpp: (Window::get): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValue): (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open): (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::getStatusText): (KJS::XMLHttpRequest::processSyncLoadResults): (KJS::XMLHttpRequest::slotRedirection): (KJS::XMLHttpRequest::slotData): (KJS::XMLHttpRequestProtoFunc::tryCall):
  • khtml/ecma/xmlhttprequest.h: (KJS::XMLHttpRequest::):
  • khtml/ecma/xmlhttprequest.lut.h: (KJS::):
  • khtml/ecma/xmlserializer.cpp: Added. (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp): (KJS::XMLSerializerConstructorImp::implementsConstruct): (KJS::XMLSerializerConstructorImp::construct): (KJS::): (KJS::XMLSerializer::XMLSerializer): (KJS::XMLSerializerProtoFunc::tryCall):
  • khtml/ecma/xmlserializer.h: Added. (KJS::XMLSerializer::toBoolean): (KJS::XMLSerializer::classInfo): (KJS::XMLSerializer::):
  • khtml/ecma/xmlserializer.lut.h: Added. (KJS::):
  • khtml/html/dtd.cpp:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::referrer): (HTMLDocumentImpl::lastModified): (HTMLDocumentImpl::createElement):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): (HTMLFormElementImpl::prepareSubmit): (HTMLFormElementImpl::submit): (HTMLFormElementImpl::reset): (HTMLGenericFormElementImpl::attach): (HTMLGenericFormElementImpl::isKeyboardFocusable): (HTMLGenericFormElementImpl::defaultEventHandler): (HTMLKeygenElementImpl::parseAttribute): (HTMLKeygenElementImpl::encoding):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isKeyboardFocusable): (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::parseAttribute): (HTMLAppletElementImpl::createRenderer): (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/htmlediting.cpp: (InputTextCommand::applyToDocument):
  • khtml/html/htmlediting.h:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): (HTMLTokenizer::scriptExecution): (HTMLTokenizer::parseTag):
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmlattrs.h:
  • khtml/misc/htmlattrs.in:
  • khtml/misc/loader.cpp: (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestStyleSheet): (Cache::requestScript):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::paint):
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::paintRootBoxDecorations): (RenderBox::paintBackgroundExtended):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::RenderCanvas):
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::setMaximalOutlineSize): (khtml::RenderCanvas::maximalOutlineSize):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations):
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::updateLayerPositions): (RenderLayer::beginTransparencyLayers): (RenderLayer::scrollToOffset): (RenderLayer::paint): (RenderLayer::paintLayer):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder): (RenderObject::paintOutline): (RenderObject::isEditable): (RenderObject::setPixmap): (RenderObject::maximalOutlineSize):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint):
  • khtml/rendering/render_style.h: (khtml::): (khtml::OutlineValue::OutlineValue): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineOffset):
  • khtml/rendering/render_table.cpp: (RenderTable::paint): (RenderTableSection::layoutRows): (RenderTableSection::paint): (RenderTableCell::paint):
  • khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): (DocumentImpl::createElement): (DocumentImpl::importNode): (DocumentImpl::createElementNS): (DocumentImpl::setTitle): (DocumentImpl::createHTMLElement): (DocumentImpl::part): (DocumentImpl::close): (DocumentImpl::processHttpEquiv): (DocumentImpl::isValidName): (DocumentImpl::toString): (DocumentFragmentImpl::toString):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::cloneNode): (ElementImpl::toString):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchEvent): (NodeImpl::dispatchWindowEvent):
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): (XMLHandler::processingInstruction): (XMLTokenizer::finish): (XMLTokenizer::executeScripts):
  • kwq/KWQAccObject.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (-[KWQAccObject textUnderElement]): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]):
  • kwq/KWQColor.h: (operator==): (operator!=):
  • kwq/KWQColor.mm: (QColor::name):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::nextKeyViewInFrame): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::partForNode): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::supportedKeySizes): (KSSLKeyGen::signedPublicKeyAndChallengeString):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQServeSynchronousRequest): (KWQResponseHeaderString): (KWQCacheObjectExpiresTime):
  • kwq/KWQNSViewExtras.h:
  • kwq/KWQNSViewExtras.m: (-[NSView _KWQ_scrollPointRecursive:]): (-[NSView _KWQ_scrollPointRecursive:inView:]):
  • kwq/KWQRenderTreeDebug.cpp: (printBorderStyle): (operator<<):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPosRecursive): (QScrollView::ensureVisible): (QScrollView::ensureRectVisibleCentered):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]):
  • kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
  • kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument createElement:]): (-[WebCoreDOMDocument createElementNS::]):
  • kwq/WebCoreLocalizedStringFactory.h: Removed.
  • kwq/WebCoreLocalizedStringFactory.m: Removed.
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m:
  • layout-tests/apple-only/base/bugzilla.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/home.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/lxr.mozilla.org/index-expected.txt:
  • layout-tests/apple-only/base/my.netscape.com/index-expected.txt:
  • layout-tests/apple-only/base/news.cnet.com/index-expected.txt:
  • layout-tests/apple-only/base/slashdot.org/index-expected.txt:
  • layout-tests/apple-only/base/web.icq.com/index-expected.txt:
  • layout-tests/apple-only/base/www.altavista.com/index-expected.txt:
  • layout-tests/apple-only/base/www.amazon.com/index-expected.txt:
  • layout-tests/apple-only/base/www.apple.com/index-expected.txt:
  • layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.digitalcity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
  • layout-tests/apple-only/base/www.excite.com/index-expected.txt:
  • layout-tests/apple-only/base/www.expedia.com/index-expected.txt:
  • layout-tests/apple-only/base/www.google.com/index-expected.txt:
  • layout-tests/apple-only/base/www.iplanet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.mapquest.com/index-expected.txt:
  • layout-tests/apple-only/base/www.microsoft.com/index-expected.txt:
  • layout-tests/apple-only/base/www.moviefone.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msn.com/index-expected.txt:
  • layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com/index-expected.txt:
  • layout-tests/apple-only/base/www.nytimes.com_Table/index-expected.txt:
  • layout-tests/apple-only/base/www.quicken.com/index-expected.txt:
  • layout-tests/apple-only/base/www.sun.com/index-expected.txt:
  • layout-tests/apple-only/base/www.time.com/index-expected.txt:
  • layout-tests/apple-only/base/www.travelocity.com/index-expected.txt:
  • layout-tests/apple-only/base/www.w3.org_DOML2Core/index-expected.txt:
  • layout-tests/apple-only/base/www.yahoo.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com/index-expected.txt:
  • layout-tests/apple-only/base/www.zdnet.com_Gamespot.com/index-expected.txt:
  • layout-tests/css1/basic/class_as_selector-expected.txt:
  • layout-tests/css1/basic/comments-expected.txt:
  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/basic/contextual_selectors-expected.txt:
  • layout-tests/css1/basic/grouping-expected.txt:
  • layout-tests/css1/basic/id_as_selector-expected.txt:
  • layout-tests/css1/basic/inheritance-expected.txt:
  • layout-tests/css1/box_properties/acid_test-expected.txt:
  • layout-tests/css1/box_properties/border-expected.txt:
  • layout-tests/css1/box_properties/border_bottom-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_color-expected.txt:
  • layout-tests/css1/box_properties/border_color_inline-expected.txt:
  • layout-tests/css1/box_properties/border_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left-expected.txt:
  • layout-tests/css1/box_properties/border_left_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left_width-expected.txt:
  • layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right-expected.txt:
  • layout-tests/css1/box_properties/border_right_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right_width-expected.txt:
  • layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_style-expected.txt:
  • layout-tests/css1/box_properties/border_style_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top-expected.txt:
  • layout-tests/css1/box_properties/border_top_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top_width-expected.txt:
  • layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_width-expected.txt:
  • layout-tests/css1/box_properties/border_width_inline-expected.txt:
  • layout-tests/css1/box_properties/clear-expected.txt:
  • layout-tests/css1/box_properties/clear_float-expected.txt:
  • layout-tests/css1/box_properties/float-expected.txt:
  • layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
  • layout-tests/css1/box_properties/float_margin-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/box_properties/height-expected.txt:
  • layout-tests/css1/box_properties/margin-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_left-expected.txt:
  • layout-tests/css1/box_properties/margin_left_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_right-expected.txt:
  • layout-tests/css1/box_properties/margin_right_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_top-expected.txt:
  • layout-tests/css1/box_properties/margin_top_inline-expected.txt:
  • layout-tests/css1/box_properties/padding-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_left-expected.txt:
  • layout-tests/css1/box_properties/padding_left_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_right-expected.txt:
  • layout-tests/css1/box_properties/padding_right_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_top-expected.txt:
  • layout-tests/css1/box_properties/padding_top_inline-expected.txt:
  • layout-tests/css1/box_properties/width-expected.txt:
  • layout-tests/css1/cascade/cascade_order-expected.txt:
  • layout-tests/css1/cascade/important-expected.txt:
  • layout-tests/css1/classification/display-expected.txt:
  • layout-tests/css1/classification/list_style-expected.txt:
  • layout-tests/css1/classification/list_style_image-expected.txt:
  • layout-tests/css1/classification/list_style_position-expected.txt:
  • layout-tests/css1/classification/list_style_type-expected.txt:
  • layout-tests/css1/classification/white_space-expected.txt:
  • layout-tests/css1/color_and_background/background-expected.txt:
  • layout-tests/css1/color_and_background/background_attachment-expected.txt:
  • layout-tests/css1/color_and_background/background_color-expected.txt:
  • layout-tests/css1/color_and_background/background_image-expected.txt:
  • layout-tests/css1/color_and_background/background_position-expected.txt:
  • layout-tests/css1/color_and_background/background_repeat-expected.txt:
  • layout-tests/css1/color_and_background/color-expected.txt:
  • layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_family-expected.txt:
  • layout-tests/css1/font_properties/font_size-expected.txt:
  • layout-tests/css1/font_properties/font_style-expected.txt:
  • layout-tests/css1/font_properties/font_variant-expected.txt:
  • layout-tests/css1/font_properties/font_weight-expected.txt:
  • layout-tests/css1/formatting_model/canvas-expected.txt:
  • layout-tests/css1/formatting_model/floating_elements-expected.txt:
  • layout-tests/css1/formatting_model/height_of_lines-expected.txt:
  • layout-tests/css1/formatting_model/horizontal_formatting-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/formatting_model/replaced_elements-expected.txt:
  • layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/css1/pseudo/firstletter-expected.txt:
  • layout-tests/css1/pseudo/firstline-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • layout-tests/css1/text_properties/letter_spacing-expected.txt:
  • layout-tests/css1/text_properties/line_height-expected.txt:
  • layout-tests/css1/text_properties/text-transform-expected.txt:
  • layout-tests/css1/text_properties/text_align-expected.txt:
  • layout-tests/css1/text_properties/text_decoration-expected.txt:
  • layout-tests/css1/text_properties/text_indent-expected.txt:
  • layout-tests/css1/text_properties/text_transform-expected.txt:
  • layout-tests/css1/text_properties/vertical_align-expected.txt:
  • layout-tests/css1/text_properties/word_spacing-expected.txt:
  • layout-tests/css1/units/color_units-expected.txt:
  • layout-tests/css1/units/length_units-expected.txt:
  • layout-tests/css1/units/percentage_units-expected.txt:
  • layout-tests/css1/units/urls-expected.txt:
  • layout-tests/fast/block/basic/010-expected.txt:
  • layout-tests/fast/block/basic/011-expected.txt:
  • layout-tests/fast/block/float/001-expected.txt:
  • layout-tests/fast/block/float/004-expected.txt:
  • layout-tests/fast/block/float/005-expected.txt:
  • layout-tests/fast/block/float/006-expected.txt:
  • layout-tests/fast/block/float/013-expected.txt:
  • layout-tests/fast/block/float/014-expected.txt:
  • layout-tests/fast/block/float/016-expected.txt:
  • layout-tests/fast/block/float/024-expected.txt:
  • layout-tests/fast/block/margin-collapse/001-expected.txt:
  • layout-tests/fast/block/margin-collapse/005-expected.txt:
  • layout-tests/fast/block/margin-collapse/006-expected.txt:
  • layout-tests/fast/block/margin-collapse/010-expected.txt:
  • layout-tests/fast/block/margin-collapse/011-expected.txt:
  • layout-tests/fast/block/margin-collapse/012-expected.txt:
  • layout-tests/fast/block/margin-collapse/015-expected.txt:
  • layout-tests/fast/block/margin-collapse/016-expected.txt:
  • layout-tests/fast/block/margin-collapse/017-expected.txt:
  • layout-tests/fast/block/margin-collapse/018-expected.txt:
  • layout-tests/fast/block/margin-collapse/019-expected.txt:
  • layout-tests/fast/block/margin-collapse/020-expected.txt:
  • layout-tests/fast/block/margin-collapse/021-expected.txt:
  • layout-tests/fast/block/margin-collapse/022-expected.txt:
  • layout-tests/fast/block/margin-collapse/024-expected.txt:
  • layout-tests/fast/block/margin-collapse/025-expected.txt:
  • layout-tests/fast/block/margin-collapse/026-expected.txt:
  • layout-tests/fast/block/margin-collapse/027-expected.txt:
  • layout-tests/fast/block/margin-collapse/028-expected.txt:
  • layout-tests/fast/block/margin-collapse/029-expected.txt:
  • layout-tests/fast/block/margin-collapse/031-expected.txt:
  • layout-tests/fast/block/margin-collapse/032-expected.txt:
  • layout-tests/fast/block/margin-collapse/033-expected.txt:
  • layout-tests/fast/block/margin-collapse/034-expected.txt:
  • layout-tests/fast/block/margin-collapse/035-expected.txt:
  • layout-tests/fast/block/margin-collapse/041-expected.txt:
  • layout-tests/fast/block/margin-collapse/042-expected.txt:
  • layout-tests/fast/block/margin-collapse/043-expected.txt:
  • layout-tests/fast/block/positioning/001-expected.txt:
  • layout-tests/fast/block/positioning/002-expected.txt:
  • layout-tests/fast/block/positioning/053-expected.txt:
  • layout-tests/fast/block/positioning/056-expected.txt:
  • layout-tests/fast/block/positioning/058-expected.txt:
  • layout-tests/fast/block/positioning/060-expected.txt:
  • layout-tests/fast/clip/014-expected.txt:
  • layout-tests/fast/compact/001-expected.txt:
  • layout-tests/fast/compact/002-expected.txt:
  • layout-tests/fast/css-generated-content/006-expected.txt:
  • layout-tests/fast/css/005-expected.txt:
  • layout-tests/fast/dynamic/001-expected.txt:
  • layout-tests/fast/dynamic/007-expected.txt: Added.
  • layout-tests/fast/dynamic/007.html: Added.
  • layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
  • layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
  • layout-tests/fast/flexbox/007-expected.txt:
  • layout-tests/fast/flexbox/008-expected.txt:
  • layout-tests/fast/flexbox/009-expected.txt:
  • layout-tests/fast/flexbox/016-expected.txt:
  • layout-tests/fast/flexbox/022-expected.txt:
  • layout-tests/fast/flexbox/025-expected.txt:
  • layout-tests/fast/frames/001-expected.txt:
  • layout-tests/fast/lists/007-expected.txt:
  • layout-tests/fast/overflow/005.html: Added.
  • layout-tests/fast/replaced/001-expected.txt:
  • layout-tests/fast/replaced/002-expected.txt:
  • layout-tests/fast/replaced/003-expected.txt:
  • layout-tests/fast/replaced/004-expected.txt:
  • layout-tests/fast/selectors/001-expected.txt:
  • layout-tests/fast/selectors/006-expected.txt:
  • layout-tests/fast/selectors/007a-expected.txt:
  • layout-tests/fast/selectors/008-expected.txt:
  • layout-tests/fast/selectors/012-expected.txt:
  • layout-tests/fast/selectors/013-expected.txt:
  • layout-tests/fast/selectors/015-expected.txt:
  • layout-tests/fast/selectors/027-expected.txt:
  • layout-tests/fast/selectors/058-expected.txt:
  • layout-tests/fast/table/001-expected.txt:
  • layout-tests/fast/table/003-expected.txt:
  • layout-tests/fast/table/005-expected.txt:
  • layout-tests/fast/table/009-expected.txt:
  • layout-tests/fast/table/016-expected.txt:
  • layout-tests/fast/table/024-expected.txt:
  • layout-tests/fast/table/025-expected.txt:
  • layout-tests/fast/table/031-expected.txt:
  • layout-tests/fast/table/032-expected.txt:
  • layout-tests/fast/table/033-expected.txt:
  • layout-tests/fast/text/basic/012-expected.txt:
  • layout-tests/fast/text/international/003-expected.txt: Added.
  • layout-tests/fast/text/international/003.html: Added.
  • layout-tests/fast/text/whitespace/002-expected.txt:
  • layout-tests/fast/text/whitespace/003-expected.txt:
  • layout-tests/fast/text/whitespace/004-expected.txt:
  • layout-tests/fast/text/whitespace/005-expected.txt:
  • layout-tests/fast/text/whitespace/010-expected.txt:
  • layout-tests/fast/text/whitespace/011-expected.txt:
  • layout-tests/fast/text/whitespace/012-expected.txt:
  • layout-tests/fast/text/whitespace/015-expected.txt:
  • layout-tests/fast/text/whitespace/016-expected.txt:
  • layout-tests/fast/text/whitespace/017-expected.txt:
  • layout-tests/fast/text/whitespace/018-expected.txt:
  • layout-tests/fast/text/whitespace/021-expected.txt:
  • layout-tests/fast/text/whitespace/024-expected.txt:
10:08 PM Changeset in webkit [5789]
  • 1 copy
    117 deletes in branches/unlabeled-1.48.4

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.48.4'.

7:23 PM Changeset in webkit [5788] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): Fix build-bustin' typo.
5:37 PM Changeset in webkit [5787] by rjw
  • 6 edits in trunk/JavaScriptCore

Added implementation of stubs in JSObject. All that
remains is a couple of simple conversion functions stubs and
we're done with LiveConnect. Also, changed string passing to
JS to use uchars instead of chars.

Reviewed by Maciej.

4:57 PM Changeset in webkit [5786] by cblu
  • 13 edits in trunk

WebCore:

Fixed: <rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

Reviewed by rjw.

  • khtml/html/html_formimpl.cpp: (HTMLKeygenElementImpl::encoding): pass the page URL to signedPublicKeyAndChallengeString
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQKSSLKeyGen.mm: (KSSLKeyGen::signedPublicKeyAndChallengeString): take a URL
  • kwq/WebCoreKeyGenerator.h:
  • kwq/WebCoreKeyGenerator.m: (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a URL

WebKit:

Fixed:
<rdar://problem/3396936>: can't obtain a digital ID from Verisign, form submission fails
<rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

Reviewed by rjw.

  • English.lproj/Localizable.strings:
  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): take a key description arg and use it, take and return CFStrings, handle the empty string case (addCertificatesToKeychainFromData): return a WebCertificateParseResult so WB knows how to handle the cert
  • WebCoreSupport.subproj/WebKeyGeneration.h:
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a page URL so we can use its host name in the key description
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed: <rdar://problem/3506645>: open PKCS7 encoded certificates downloaded from Verisign in Keychain Access

Reviewed by rjw.

  • DownloadProgressEntry.m: (-[DownloadProgressEntry _addCertificateToKeyChain]): open PKCS7 files in Keychain Access
  • English.lproj/StringsNotToBeLocalized.txt:
4:23 PM Changeset in webkit [5785] by hyatt
  • 11 edits in trunk/WebCore

Fix for 3254534, CSS background-image style should be loaded lazily only when used.

Reviewed by rjw

  • ChangeLog:
  • khtml/css/css_valueimpl.cpp: (CSSImageValueImpl::CSSImageValueImpl): (CSSImageValueImpl::~CSSImageValueImpl): (CSSImageValueImpl::image):
  • khtml/css/css_valueimpl.h:
3:25 PM Changeset in webkit [5784] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3508825>: REGRESSION (100-116): crash in HTMLGenericFormElementImpl::attach at sonyericsson.com

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Move a few lines inside an existing nil check to prevent nil dereference.
2:01 PM Changeset in webkit [5783] by sullivan
  • 4 edits in trunk/WebCore
  • fixed <rdar://problem/3508760>: tabbing to out-of-sight link behaves differently than tabbing to out-of-sight form control

Reviewed by Dave.

  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::ensureVisible): added comments and changed parameter names to reveal differences between what we've implemented and what QScrollView was intended to do. (QScrollView::ensureRectVisibleCentered): New method that calls _KWQ_scrollRectToVisible, which is the method we use when scrolling to reveal form controls.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): call ensureRectVisibleCentered so tabbing to a link will use the same scroll-to-reveal code as tabbing to a form control
12:18 PM Changeset in webkit [5782] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3507856>: XMLHttpRequest xhtml test displays but doesn't load

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::tryCall): complete the URL using the document, not the htmlDocument.
12:01 PM Changeset in webkit [5781] by vicki
  • 2 edits in trunk/WebKit

Reviewed by me.

  • change the WebKit version number back to 118u for tip of tree builds
  • WebKit.pbproj/project.pbxproj:
11:14 AM Changeset in webkit [5780]
  • 4 copies in tags/Safari-117

This commit was manufactured by cvs2svn to create tag 'Safari-117'.

11:14 AM Changeset in webkit [5779] by vicki
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (OOPS!).

  • fix version number for submission (117)
  • WebKit.pbproj/project.pbxproj:
10:14 AM Changeset in webkit [5778] by vicki
  • 2 edits in trunk/WebKit

Reviewed by kocienda.

  • fix buildit build bustage. INSTALL_PATH should be '=', not '+=' (probably changed unintentionally)
  • WebKit.pbproj/project.pbxproj:
9:32 AM Changeset in webkit [5777] by rjw
  • 6 edits in trunk

JavaScriptCore:

Ensure that all calls from Java into JavaScript are
performed on a designated thread (the main thread).

Reviewed by Ken.

  • bindings/jni_jsobject.cpp: (isJavaScriptThread): (rootForImp): (Bindings::performJavaScriptAccess): (Bindings::completedJavaScriptAccess): (Bindings::initializeJavaScriptAccessLock): (Bindings::lockJavaScriptAccess): (Bindings::unlockJavaScriptAccess): (Bindings::dispatchToJavaScriptThread): (Bindings::RootObject::setFindRootObjectForNativeHandleFunction): (Bindings::RootObject::removeAllJavaReferencesForRoot): (Bindings::JSObject::invoke): (Bindings::JSObject::JSObject): (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::removeMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::setSlot): (Bindings::JSObject::toString): (Bindings::JSObject::finalize): (Bindings::JSObject::getWindow):
  • bindings/jni_jsobject.h: (Bindings::RootObject::~RootObject): (Bindings::RootObject::findRootObjectForNativeHandleFunction): (Bindings::RootObject::runLoop): (Bindings::RootObject::performJavaScriptSource): (Bindings::):

WebCore:

Replace calls to global functions with static member functions.

Reviewed by Ken.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):

Dec 11, 2003:

5:54 PM Changeset in webkit [5776] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3464315>: createDocument creates document with initial child element, unlike other browsers

  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Don;t add initial element.
5:32 PM Changeset in webkit [5775] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3507863>: XMLHttpRequest should not parse response if HTML

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty):
4:48 PM Changeset in webkit [5774] by rjw
  • 12 edits in trunk

JavaScriptCore:

Added support for calling a JavaScript function from
Java. Right now this only works for void func(void)
functions, but the conversion of args and return values
will come shortly.

Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

Removed link hack for testkjs now that the Java folks think
they have a solution for the 1.4.2 JavaVM link problem. Although
Greg B. thinks his solution may cause problems for the 1.3.1
version of the VM!?!

Reviewed by Ken.

  • Makefile.am:
  • bindings/jni/jni_runtime.h: (Bindings::JavaString::JavaString):
  • bindings/jni/jni_utility.cpp: (convertValueToJValue): (convertValueToJObject): (listFromJArray):
  • bindings/jni/jni_utility.h:
  • bindings/jni_jsobject.cpp: (KJS_setFindRootObjectForNativeHandleFunction): (KJS_findRootObjectForNativeHandleFunction): (getReferencesByRootDictionary): (getReferencesDictionary): (findReferenceDictionary): (rootForImp): (addJavaReference): (removeJavaReference):
  • bindings/jni_jsobject.h: (Bindings::RootObject::RootObject): (Bindings::RootObject::~RootObject): (Bindings::RootObject::setRootObjectImp): (Bindings::RootObject::rootObjectImp): (Bindings::RootObject::setInterpreter): (Bindings::RootObject::interpreter):

WebCore:

Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

Reviewed by Ken.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
3:56 PM Changeset in webkit [5773] by kocienda
  • 6 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3489280>: redirect via post blows cache, causing everything to get reloaded

Now POST requests reload the main document by default, but will not reload
all subresources.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Take the cache policy for subresources from the original request, rather than the data source's current request.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient _isPostOrRedirectAfterPost:redirectResponse:]): New helper. (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): Call new helper to set the cache policy on the main resource load.
3:50 PM Changeset in webkit [5772] by mjs
  • 5 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3507862>: XMLHttpRequest documents that reference external resources (e.g. stylesheets) cause crash

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler):
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::processingInstruction): (XMLTokenizer::executeScripts):
3:30 PM Changeset in webkit [5771] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Chris.

<rdar://problem/3507859>: Status text should only include "OK", not full "HTTP/1.0 200 OK" status line

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getStatusText): Include only the status text, not the full status line.
2:59 PM Changeset in webkit [5770]
  • 1 copy
    25 deletes in branches/unlabeled-1.275.2

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.275.2'.

2:59 PM Changeset in webkit [5769] by vicki
  • 3 edits in trunk

the tree is open for Safari-118

2:55 PM Changeset in webkit [5768] by vicki
  • 6 edits in trunk

Safari-117 stamp, plus a few site changes

1:43 PM Changeset in webkit [5767] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • WebCoreSupport.subproj/WebBridge.m: time_t is a signed type, so casting -1 to a time_t does not work to make a max value. We'll go with INT_MAX.
11:48 AM Changeset in webkit [5766] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix duplicate changelog entry

11:46 AM Changeset in webkit [5765] by hyatt
  • 203 edits in trunk/LayoutTests

Landing changed layout tests that don't dump incorrect backgrounds.

11:39 AM Changeset in webkit [5764] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3507164, scrolling really slow on hixie's web forms spec page. Hixie has 12 little transparent layers
at various points on this page, and beginning/ending transparency on only those 12 layers as you scroll
is enough to kill scrolling performance.

This patch works around the issue by lazily beginning transparency layers only when we determine that
we're actually painting a descendant layer of a transparent ancestor or a transparent layer.

Also fixing QColor's comparison operator. It was broken and not comparing the "valid" bit, so invalid and
valid colors were being assumed to be the same.

Also fixed the render dumper to not dump transparent and invalid background colors and fixed it do dump the
alpha for colors with an alpha < 0xFF.

Reviewed by mjs (opacity changes), darin (color changes) and john (render tree dumper changes)

  • ChangeLog:
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::beginTransparencyLayers): (RenderLayer::paint): (RenderLayer::paintLayer):
  • khtml/rendering/render_layer.h:
  • kwq/KWQColor.h: (operator==): (operator!=):
  • kwq/KWQColor.mm: (QColor::name):
  • kwq/KWQRenderTreeDebug.cpp: (operator<<):
11:12 AM Changeset in webkit [5763] by kocienda
  • 4 edits in trunk/WebKit

Reviewed and C++ heavy-lifting by Darin

Fix warnings in C++ files.

  • WebCoreSupport.subproj/WebKeyGeneration.cpp: (signedPublicKeyAndChallengeString): Add cast to remove warning. (addCertificatesToKeychainFromData): Add cast to remove warning.
  • WebKit.pbproj/project.pbxproj: Add back warnings to C++ files.
  • WebKitPrefix.h: Add define for NULL that works for C++.
11:00 AM Changeset in webkit [5762] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • kwq/KWQLoader.mm: (KWQCacheObjectExpiresTime): Fixed deployment build bustage.
8:11 AM Changeset in webkit [5761] by kocienda
  • 7 edits in trunk

WebCore:

Reviewed by Darin

<rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

  • khtml/misc/loader.cpp: (Loader::slotFinished): Don't reset expiration date. We set this once in slotReceivedResponse. (Loader::slotReceivedResponse): Call new KWQ function to get a cache object's expiration date using its NSURLResponse data. (Cache::requestImage): Don't reset expiration date. We set this once in slotReceivedResponse, and we do not want the value from the DocLoader anyway. (Cache::requestStyleSheet): Ditto. (Cache::requestScript): Ditto.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQCacheObjectExpiresTime): New function. Call over bridge to get access to SPI in NSURLResponse to calculate expiration time.
  • kwq/WebCoreBridge.h: Declare bridge method.

WebKit:

Reviewed by Darin

<rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): New method. Call response freshness lifetime method and add it to the current time to yield an expiration time.
Note: See TracTimeline for information about the timeline view.