Context Navigation

← Previous Period
Next Period →

Timeline

Dec 19, 2003:

9:16 PM Changeset in webkit [5840] by hyatt

3 edits in trunk/WebCore

Fix for 3483130, repaint doesn't occur when font is decreased dynamically when at the bottom of
amazon.com.

Reviewed by john

khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor):
kwq/WebCoreBridge.mm: (-[WebCoreBridge setTextSizeMultiplier:]):

4:32 PM Changeset in webkit [5839] by kocienda

8 edits in branches

Reviewed by me

Made out TreeWalker implementation less lame. It's not
done yet, but it's a lot better.

khtml/dom/dom2_traversal.cpp: (TreeWalker::root): (TreeWalker::whatToShow): (TreeWalker::filter): (TreeWalker::expandEntityReferences): (TreeWalker::currentNode): (TreeWalker::setCurrentNode):
khtml/dom/dom2_traversal.h:
khtml/editing/edit_caretimpl.cpp: (CaretImpl::adjustForEditing):
khtml/xml/dom2_traversalimpl.cpp: (TreeWalkerImpl::TreeWalkerImpl): (TreeWalkerImpl::operator=): (TreeWalkerImpl::~TreeWalkerImpl): (TreeWalkerImpl::setRoot): (TreeWalkerImpl::setFilter): (TreeWalkerImpl::setCurrentNode): (TreeWalkerImpl::parentNode): (TreeWalkerImpl::firstChild): (TreeWalkerImpl::lastChild): (TreeWalkerImpl::previousSibling): (TreeWalkerImpl::nextSibling): (TreeWalkerImpl::previousNode): (TreeWalkerImpl::nextNode): (TreeWalkerImpl::isAccepted): (firstDescendent): (lastDescendent):
khtml/xml/dom2_traversalimpl.h: (DOM::TreeWalkerImpl::root): (DOM::TreeWalkerImpl::whatToShow): (DOM::TreeWalkerImpl::filter): (DOM::TreeWalkerImpl::expandEntityReferences): (DOM::TreeWalkerImpl::currentNode): (DOM::TreeWalkerImpl::setWhatToShow): (DOM::TreeWalkerImpl::setExpandEntityReferences): (DOM::TreeWalkerImpl::assertNodeValid):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createTreeWalker):
khtml/xml/dom_docimpl.h:

3:06 PM Changeset in webkit [5838] by rjw

2 edits in trunk/WebCore

Fixed 3515590. Return Undefined to JS for applet if
Java is disabled.

Reviewed by Chris.

khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):

1:55 PM Changeset in webkit [5837] by rjw

3 edits in trunk/JavaScriptCore

Fixed 3515597. When an error occurs we need
to make sure result values are zeroed.

Cleaned up logs by adding a newline.

Reviewed by John.

bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (callJNIMethod): (callJNIMethodA): (KJS::Bindings::getJNIField):
bindings/jni_jsobject.cpp: (JSObject::convertValueToJObject):

1:25 PM Changeset in webkit [5836] by mjs

2 edits in trunk/WebCore

Reviewed by Chris.

<rdar://problem/3512545>: reproducible assertion failure in KWQKHTMLPart::addData scrolling to anchor while page loads

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Don't pretend we finished loading, because we don't actually make anchor scrolling stop the current page load.

11:54 AM Changeset in webkit [5835] by kocienda

41 edits in branches

Reviewed by me

Merged HEAD to branch

ChangeLog:
WebCore.pbproj/project.pbxproj:
khtml/css/css_valueimpl.h:
khtml/css/cssparser.cpp:
khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::updateDOMObjectDocument):
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_window.cpp: (Window::isSafeScript):
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::parseAttribute): (HTMLFrameElementImpl::setLocation): (HTMLIFrameElementImpl::parseAttribute): (HTMLIFrameElementImpl::openURL):
khtml/html/html_baseimpl.h:
khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::click): (HTMLInputElementImpl::accessKeyAction):
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): (HTMLAnchorElementImpl::isMouseFocusable):
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
khtml/html/html_objectimpl.h:
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::notifyFinished):
khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::dispatchMouseEvent):
khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
khtml/rendering/font.h:
khtml/rendering/render_form.cpp: (RenderFileButton::slotTextChanged): (RenderFileButton::click):
khtml/rendering/render_form.h:
khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
khtml/rendering/render_inline.h:
khtml/rendering/render_object.cpp: (RenderObject::absoluteRects): (checkFloats): (RenderObject::removeFromObjectLists):
khtml/rendering/render_object.h:
khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::absoluteRects): (RenderText::paintObject):
khtml/rendering/render_text.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::setDocument): (NodeImpl::checkAddChild):
khtml/xml/dom_nodeimpl.h:
kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]):
kwq/KWQApplication.mm: (QDesktopWidget::screenNumber): (QDesktopWidget::screenGeometry):
kwq/KWQFileButton.h:
kwq/KWQFileButton.mm: (KWQFileButton::click):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
kwq/KWQKWinModule.mm: (KWinModule::workArea):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):

9:59 AM Changeset in webkit [5834] by cblu

3 edits in trunk/WebKit

Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes 2 copies

Reviewed by john.

WebKit.pbproj/project.pbxproj: Xcode 1.1 file format change
WebView.subproj/WebImageView.h:
WebView.subproj/WebImageView.m: copied double-drag protection code from WebHTMLView (-[WebImageView mouseDown:]): set ignoringMouseDraggedEvents to NO (-[WebImageView mouseDragged:]): if ignoringMouseDraggedEvents, return (-[WebImageView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to YES

9:46 AM Changeset in webkit [5833] by vicki

3 edits in trunk

* empty log message *

9:37 AM Changeset in webkit [5832]

3 copies in tags/Safari-119

This commit was manufactured by cvs2svn to create tag 'Safari-119'.

9:37 AM Changeset in webkit [5831] by vicki

6 edits in trunk

top level:

Reviewed by me

Site/Internal/Design/html-editing-tasks.fp5: Added.

Tools:

disallow installation on 10.3.2 and later; update strings with better error messages

Install_resources/InstallationCheck:
Install_resources/InstallationCheck.strings:

JavaScriptCore:

Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

Reviewed by Dave.

ChangeLog:
bindings/jni/jni_class.cpp:
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (JavaMethod::signature):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::ascii): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaField::name): (KJS::Bindings::JavaField::type): (KJS::Bindings::JavaMethod::name): (KJS::Bindings::JavaMethod::returnType):
bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (KJS::Bindings::callJNIVoidMethod): (KJS::Bindings::callJNIObjectMethod): (KJS::Bindings::callJNIBooleanMethod): (KJS::Bindings::callJNIByteMethod): (KJS::Bindings::callJNICharMethod): (KJS::Bindings::callJNIShortMethod): (KJS::Bindings::callJNIIntMethod): (KJS::Bindings::callJNILongMethod): (KJS::Bindings::callJNIFloatMethod): (KJS::Bindings::callJNIDoubleMethod): (KJS::Bindings::callJNIVoidMethodA): (KJS::Bindings::callJNIObjectMethodA): (KJS::Bindings::callJNIByteMethodA): (KJS::Bindings::callJNICharMethodA): (KJS::Bindings::callJNIShortMethodA): (KJS::Bindings::callJNIIntMethodA): (KJS::Bindings::callJNILongMethodA): (KJS::Bindings::callJNIFloatMethodA): (KJS::Bindings::callJNIDoubleMethodA): (KJS::Bindings::callJNIBooleanMethodA): (KJS::Bindings::getCharactersFromJString): (KJS::Bindings::releaseCharactersForJString): (KJS::Bindings::getCharactersFromJStringInEnv): (KJS::Bindings::releaseCharactersForJStringInEnv): (KJS::Bindings::getUCharactersFromJStringInEnv): (KJS::Bindings::releaseUCharactersForJStringInEnv): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertValueToJValue):
bindings/jni/jni_utility.h:
bindings/jni_jsobject.cpp: (KJS::Bindings::JSObject::invoke): (KJS::Bindings::JSObject::JSObject): (KJS::Bindings::JSObject::call): (KJS::Bindings::JSObject::eval): (KJS::Bindings::JSObject::getMember): (KJS::Bindings::JSObject::setMember): (KJS::Bindings::JSObject::removeMember): (KJS::Bindings::JSObject::getSlot): (KJS::Bindings::JSObject::setSlot): (KJS::Bindings::JSObject::toString): (KJS::Bindings::JSObject::finalize): (KJS::Bindings::JSObject::createNative): (KJS::Bindings::JSObject::convertValueToJObject): (KJS::Bindings::JSObject::convertJObjectToValue): (KJS::Bindings::JSObject::listFromJArray):
bindings/jni_jsobject.h:
bindings/runtime.cpp:
bindings/runtime.h:
bindings/runtime_method.cpp:
bindings/runtime_method.h:

Tests:

LiveConnect: Added tests for JavaScript to Java
array access.

Reviewed by John.

LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
LiveConnect/Blink/test.html:

WebCore:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
khtml/rendering/font.h:
khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):

WebKit:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebBrowser:

Reviewed by Chris

BrowserNSDataExtras.m: (-[NSData certificateFromMultipartData]): Fix off-by-one error in code to strip trailing CRLFs off certificate data.

WebKitExamples:

Fixed 3455347. WEBVIEW: Dragging links from a Carbon HIWebView crash with NSException raise
Written be Ed. This code is often copy/pasted by developers, so this problem propagates.

Reviewed by Richard.

CarbonWeb/CarbonWeb.pbproj/project.pbxproj:
CarbonWeb/TWebWindow.cp:

Dec 18, 2003:

3:14 PM Changeset in webkit [5830] by rjw

11 edits in trunk

WebKit:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebCore:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
khtml/rendering/font.h:
khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):

Dec 17, 2003:

7:56 PM Changeset in webkit [5829] by rjw

6 edits in trunk/WebCore

Fixed build problem resulting from addition of KJS to Bindings namespace.

6:49 PM Changeset in webkit [5828] by rjw

15 edits in trunk/JavaScriptCore

Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

Reviewed by Dave.

ChangeLog:
bindings/jni/jni_class.cpp:
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (JavaMethod::signature):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::ascii): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaField::name): (KJS::Bindings::JavaField::type): (KJS::Bindings::JavaMethod::name): (KJS::Bindings::JavaMethod::returnType):
bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (KJS::Bindings::callJNIVoidMethod): (KJS::Bindings::callJNIObjectMethod): (KJS::Bindings::callJNIBooleanMethod): (KJS::Bindings::callJNIByteMethod): (KJS::Bindings::callJNICharMethod): (KJS::Bindings::callJNIShortMethod): (KJS::Bindings::callJNIIntMethod): (KJS::Bindings::callJNILongMethod): (KJS::Bindings::callJNIFloatMethod): (KJS::Bindings::callJNIDoubleMethod): (KJS::Bindings::callJNIVoidMethodA): (KJS::Bindings::callJNIObjectMethodA): (KJS::Bindings::callJNIByteMethodA): (KJS::Bindings::callJNICharMethodA): (KJS::Bindings::callJNIShortMethodA): (KJS::Bindings::callJNIIntMethodA): (KJS::Bindings::callJNILongMethodA): (KJS::Bindings::callJNIFloatMethodA): (KJS::Bindings::callJNIDoubleMethodA): (KJS::Bindings::callJNIBooleanMethodA): (KJS::Bindings::getCharactersFromJString): (KJS::Bindings::releaseCharactersForJString): (KJS::Bindings::getCharactersFromJStringInEnv): (KJS::Bindings::releaseCharactersForJStringInEnv): (KJS::Bindings::getUCharactersFromJStringInEnv): (KJS::Bindings::releaseUCharactersForJStringInEnv): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertValueToJValue):
bindings/jni/jni_utility.h:
bindings/jni_jsobject.cpp: (KJS::Bindings::JSObject::invoke): (KJS::Bindings::JSObject::JSObject): (KJS::Bindings::JSObject::call): (KJS::Bindings::JSObject::eval): (KJS::Bindings::JSObject::getMember): (KJS::Bindings::JSObject::setMember): (KJS::Bindings::JSObject::removeMember): (KJS::Bindings::JSObject::getSlot): (KJS::Bindings::JSObject::setSlot): (KJS::Bindings::JSObject::toString): (KJS::Bindings::JSObject::finalize): (KJS::Bindings::JSObject::createNative): (KJS::Bindings::JSObject::convertValueToJObject): (KJS::Bindings::JSObject::convertJObjectToValue): (KJS::Bindings::JSObject::listFromJArray):
bindings/jni_jsobject.h:
bindings/runtime.cpp:
bindings/runtime.h:
bindings/runtime_method.cpp:
bindings/runtime_method.h:

5:41 PM Changeset in webkit [5827] by rjw

2 edits in trunk/WebKit

Fixed 3503011 (really, this time). Always use integer width for '-' and '?', as we do for spaces, to ensure that 'words' (as defined by out rounding hack) start on integer boundaries.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):

4:44 PM Changeset in webkit [5826] by cblu

3 edits in trunk/WebKit

Fixed:
<rdar://problem/3393758>: REGRESSION (85-100): Flash onKeyUp event non-functional
<rdar://problem/3479020>: REGRESSION (85-100): Safari sends plug-in key events to wrong instance of plug-in

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): set suspendKeyUpEvents to NO (-[WebBaseNetscapePluginView keyMessageForEvent:]): copied from CVS (-[WebBaseNetscapePluginView keyUp:]): if !suspendKeyUpEvents, send the keyUp event (-[WebBaseNetscapePluginView keyDown:]): set suspendKeyUpEvents to YES (-[WebBaseNetscapePluginView windowBecameKey:]): call SetUserFocusWindow

4:38 PM Changeset in webkit [5825] by darin

3 edits in trunk/WebKit

Reviewed by Richard.

fixed 3513274: REGRESSION: anchor navigation within frames with "Back" is broken at tivofaq.com

WebView.subproj/WebDataSource.m: (-[WebDataSource _setURL:]): Since this method is only used when you do a fragment scroll, we need to update the original request as well as the request. This ensure that the fragment gets recorded in the history item (which goes in the back/forward history).

4:21 PM Changeset in webkit [5824] by kocienda

7 edits
7 adds
2 deletes in branches

Reviewed by me.

Made editing subdirectory.
Moved htmlediting files into this new directory.
Added Caret and CaretImpl classes.

WebCore.pbproj/project.pbxproj:
khtml/editing/edit_caret.cpp: Added. (Caret::Caret): (Caret::~Caret): (Caret::node): (Caret::offset): (Caret::startOfLine): (Caret::setPosition): (Caret::setStartOfLine): (Caret::needsAdjustmentForEditing): (Caret::adjustForEditing): (Caret::adjustedForEditing): (Caret::handle): (operator==):
khtml/editing/edit_caret.h: Added.
khtml/editing/edit_caretimpl.cpp: Added. (CaretImpl::CaretImpl): (CaretImpl::~CaretImpl): (CaretImpl::setPosition): (CaretImpl::setStartOfLine): (CaretImpl::needsAdjustmentForEditing): (CaretImpl::adjustForEditing): (EditNodeFilter::acceptNode):
khtml/editing/edit_caretimpl.h: Added. (khtml::CaretImpl::node): (khtml::CaretImpl::offset): (khtml::CaretImpl::startOfLine): (khtml::CaretImpl::CaretImpl):
khtml/editing/htmlediting.cpp: Added. (EditCommand::notifyChanged): (InputTextCommand::commandID): (InputTextCommand::InputTextCommand): (InputTextCommand::isLineBreak): (InputTextCommand::isSpace): (InputTextCommand::applyToDocument): (InputTextCommand::canUndo): (DeleteTextCommand::commandID): (DeleteTextCommand::DeleteTextCommand): (DeleteTextCommand::applyToDocument): (DeleteTextCommand::canUndo):
khtml/editing/htmlediting.h: Added. (khtml::): (khtml::EditCommand::EditCommand): (khtml::EditCommand::~EditCommand): (khtml::EditCommand::selection): (khtml::InputTextCommand::~InputTextCommand): (khtml::InputTextCommand::text): (khtml::DeleteTextCommand::~DeleteTextCommand):
khtml/html/htmlediting.cpp: Removed.
khtml/html/htmlediting.h: Removed.
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::slotClearSelection): (KHTMLPart::caret): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::emitCaretPositionChanged): (KHTMLPart::moveCaretTo):
khtml/khtml_part.h:
khtml/khtmlpart_p.h:
khtml/khtmlview.cpp: (khtml::sanitizeCaretState): (KHTMLView::init): (KHTMLView::initCaret): (KHTMLView::moveCaretTo):
kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged):

4:21 PM Changeset in webkit [5823] by kocienda

in /

file edit_caret.h was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5822] by kocienda

in /

file htmlediting.h was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5821] by kocienda

in /

file edit_caretimpl.h was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5820] by kocienda

in /

file htmlediting.cpp was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5819] by kocienda

in /

file edit_caretimpl.cpp was initially added on branch HTML-editing-hacks-branch.

4:21 PM Changeset in webkit [5818] by kocienda

in /

file edit_caret.cpp was initially added on branch HTML-editing-hacks-branch.

3:48 PM Changeset in webkit [5817] by darin

9 edits in trunk/WebCore

Reviewed by Dave.

fixed 3469085: can't tab to all links on aintitcool.com

khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): Re-implemented this to check width and height of all continuations, not just the main render object. Also, check the absoluteRects after checking all the render objects to catch things like floats. (HTMLAnchorElementImpl::isMouseFocusable): Clean up the code here a bit.

khtml/rendering/render_inline.h:
khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
khtml/rendering/render_object.h:
khtml/rendering/render_object.cpp: (RenderObject::absoluteRects):
khtml/rendering/render_text.h:
khtml/rendering/render_text.cpp: (RenderText::absoluteRects):
kwq/KWQAccObject.mm: (boundingBoxRect): Use QValueList instead of QPtrList for clarity and to fix storage leaks.

10:45 AM Changeset in webkit [5816] by vicki

3 edits in trunk

The tree is open for Safari-119!

10:25 AM Changeset in webkit [5815]

3 copies in tags/Safari-118

This commit was manufactured by cvs2svn to create tag 'Safari-118'.

10:25 AM Changeset in webkit [5814] by vicki

6 edits in trunk

Safari-118 stamp

9:36 AM Changeset in webkit [5813] by sullivan

2 edits in trunk/WebKit

fixed <rdar://problem/3512801>: REGRESSION (Safari 100-116): Mike Hay's Magic 8-ball game ignores slow clicks

Reviewed by Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleAutoscrollForMouseDragged:]): start the autoscroll timer here, so the timer only runs when KHTML is handling the event. (-[WebHTMLView mouseDown:]): don't start the autoscroll timer here.

Dec 16, 2003:

8:03 PM Changeset in webkit [5812] by kocienda

2 edits in trunk/WebKit

Reviewed by me

WebCoreSupport.subproj/WebBridge.m: ObjC runtime needs a declaration for new _calculatedExpiration SPI in NSURLResponse in Foundation

7:21 PM Changeset in webkit [5811] by rjw

2 edits in trunk/WebKit

Fixed 3512348: Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
iterators. Much faster, better cheaper, etc.

Reviewed by Dave.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):

5:46 PM Changeset in webkit [5810] by hyatt

2 edits in trunk/WebCore

Fix for 3510956, crash on mezzoblue.com. Relax the float-list searching code that runs when
a float is removed.

Reviewed by darin

khtml/rendering/render_object.cpp: (checkFloats): (RenderObject::removeFromObjectLists):

5:33 PM Changeset in webkit [5809] by rjw

2 edits in trunk/WebKit

Fixed 3503011. Added '-' and '?' to rounding hack.

Reviewed by John.

WebCoreSupport.subproj/WebTextRenderer.m: (isRoundingHackCharacter): (widthForNextCharacter):

5:30 PM Changeset in webkit [5808] by darin

2 edits in trunk/WebKit

Reviewed by Richard.

finished fix to 3109132: can't open movie file via open panel

WebView.subproj/WebView.m: (+[WebView _supportedFileExtensions]): Include all the extensions for each MIME type, not jus the preferred one.

4:53 PM Changeset in webkit [5807] by kocienda

2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3512199>: WebBridge expiresTimeForResponse can be
improved to use better expiration calculations

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): Switch to use new _calculatedExpiration SPI method on NSURLResponse.

1:19 PM Changeset in webkit [5806] by rjw

2 edits in trunk/JavaScriptCore

Ack! More assertions. Lock ALL entry points into the interpreter!
(3511733).

Reviewed by Ken.

bindings/jni_jsobject.cpp: (Bindings::JSObject::call): (Bindings::JSObject::eval): (Bindings::JSObject::getMember): (Bindings::JSObject::setMember): (Bindings::JSObject::removeMember): (Bindings::JSObject::getSlot): (Bindings::JSObject::setSlot): (Bindings::JSObject::convertJObjectToValue):

11:33 AM Changeset in webkit [5805] by sullivan

2 edits in trunk/WebCore

fixed <rdar://problem/3482852>: oft-seen, non-repro, nil-deref in
HTMLTokenizer::notifyFinished (snapfish.com, etc.)

At least one of the dupes of this bug is a separate (still reproducible) issue;
I'll clone it back to life and test the others.

Reviewed by Darin.

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::notifyFinished): Move check of cachedScript.isEmpty() until after scriptExecution() call, because cachedScript.isEmpty() value can be changed by that call.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed