Timeline

Dec 23, 2003:

5:50 PM Changeset in webkit [5851] by sullivan

• 5 edits in trunk

JavaScriptCore:

• JavaScriptCore.pbproj/project.pbxproj: Xcode version wars, harmless

WebCore:

• fixed <rdar://problem/3451306>: address book search fails at Airborne Express Corporate site (Apple Shipping wants to use it)

Reviewed by Darin.

• khtml/ecma/kjs_html.cpp: commented out definition of document.all; now sites like this one that set document.all to a value will work.
• khtml/ecma/kjs_html.lut.h: (KJS::): regenerated this file

4:37 PM Changeset in webkit [5850] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by John (concept, not code, which is just the old code coming back).

• fixed 3518092: REGRESSION (100-119): getting NaN instead of HH:MM times

• kjs/date_object.cpp: Added back our CF-based implementations of gmtime, localtime, mktime, timegm, and time, because mktime, at least, won't handle a year of 0.

3:52 PM Changeset in webkit [5849] by darin

• 1 edit in trunk/WebKit/ChangeLog

Fix some old malformed log entries.

3:52 PM Changeset in webkit [5848] by darin

• 6 edits in trunk/WebCore

Reviewed by John.

• another try at fixing the -[KWQPageState dealloc] bug, even though we don't fully understand it

This change saves the renderer inside the document rather than in the KWQPageState to
try to eliminate the possibility that multiple KWQPageState objects could restore the
same renderer multiple times, resulting in multiple detaches of the same renderer.

• khtml/xml/dom_docimpl.h: Add a m_savedRenderer field.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_savedRenderer to 0. (DocumentImpl::~DocumentImpl): Added some asserts to make sure we don't get destroyed while we are in the page cache. (DocumentImpl::attach): Added an assert. (DocumentImpl::setInPageCache): Save the renderer when setting the flag, and restore the renderer when clearing it.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Instead of doing a restoreRenderer call, just do setInPageCache(NO), which will restore the renderer as a side effect.

• kwq/KWQPageState.h: Removed the renderer method and field.
• kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): Don't store a pointer to the renderer. (-[KWQPageState clear]): New method, shared by invalidate and dealloc. (-[KWQPageState invalidate]): Removed code relating to "relinquishing object ownership"; just deallocate everything here without doing a detach(). (-[KWQPageState dealloc]): Removed restoreRenderer now that setInPageCache(NO) handles that. Added some assertions. Share code with invalidate by calling clear.

Dec 22, 2003:

2:30 PM Changeset in webkit [5847] by sullivan

• 2 edits in trunk/WebCore

• fixed <rdar://problem/3508798>: ACCESSIBILITY: role/description/value strings not defined

Reviewed by Darin.

• kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): provide not-yet-localized strings for all the role descriptions that this class uses. (-[KWQAccObject value]): return nil string rather than dummy string for the cases where we don't have a value attribute. (-[KWQAccObject accessibilityActionDescription:]): changed comment passed to UI_STRING bogus macro so it won't have to change if/when macro loses its bogosity

11:32 AM Changeset in webkit [5846] by sullivan

• 6 edits in trunk

WebCore:

• WebCore part of fix for <rdar://problem/3515706>: REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

Reviewed by Darin.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]): renamed method for clarity; now iterates over pages horizontally as well as vertically; assume x starts at 0 as we were already assuming that y starts at 0; now returns autoreleased result

WebKit:

• WebKit part of fix for <rdar://problem/3515706>: REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

Reviewed by Darin.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _userScaleFactorForPrintOperation:]): new method, extracts the scale factor provided by the user in the Page Setup dialog (-[WebHTMLView _scaleFactorForPrintOperation:]): take user scale factor into account (-[WebHTMLView knowsPageRange:]): renamed local var scaleFactor -> totalScaleFactor for clarity; take user scale factor into account for print width; now assumes computePageRects returns autoreleased result.

• WebKit.pbproj/project.pbxproj: Xcode version wars; Darin says these don't affect the build.

WebBrowser:

Reviewed by Darin.

• WebBrowser.pbproj/project.pbxproj: Xcode version wars; Darin says these don't affect the build.

11:26 AM Changeset in webkit [5845] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• follow-on to my fix for 3467919: handle collapsed spaces at the starts of runs too, not just at the end, and make sure that a space inherits style from the run it was collapsed from rather than always from the run it precedes

• khtml/khtml_part.cpp: (KHTMLPart::text): Add code to deal with collapsed spaces at the start of runs.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Change code to keep the style of a space that was collapsed at the end of the run, and use that styled space if necessary. Also add the code to deal with collapsed spaces at the start of runs. Also remove comment that refers to long-since-deleted code.

9:42 AM Changeset in webkit [5844] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3467919: REGRESSION (91-92): space missing when copying text with link at start or end of line

• khtml/khtml_part.cpp: (KHTMLPart::text):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Changed both "turn HTML into text" code paths to generate spaces in a different way. First, corrected the logic so it notices spaces left out at the end of a RenderText object. Second, don't emit the space until we are emitting more text, to prevent emitting trailing spaces. To get this completely right for the attributed string case, I had to add code to adjust the offset used to mark links.

9:40 AM Changeset in webkit [5843] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3477453: nowrap in a fixed-width TD is ignored on screen but not when printed (Williams-Sonoma)

• khtml/rendering/render_table.cpp: (RenderTableCell::setStyle): Compute the proper whitespace mode before calling the base class setStyle, since the base class setStyle may create styles that inherit from our style, and we want them to inherit the computed whitespace mode.

• WebCore.pbproj/project.pbxproj: Let Xcode be 1.1, as it was meant to be.

Dec 21, 2003:

12:42 PM Changeset in webkit [5842] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed a storage leak

• WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Move the release of the request out of an if statement, since it's always needed.

12:40 PM Changeset in webkit [5841] by darin

• 4 edits in trunk/WebCore

Reviewed by Dave.

• fixed a storage leak

• khtml/rendering/render_style.h: Added a destructor and a private unimplemented assignment operator to StyleCSS3InheritedData, since the textShadow field that needs to be allocated and deallocated and the default destructor and assignment operator don't do that.
• khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData): Added destructor that deletes the textShadow object.

• fixed locking for JavaScript debugging tools in Caches window

• kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): Lock and unlock around call to JavaScriptCore. (+[WebCoreJavaScript garbageCollect]): Ditto.