Timeline

Dec 26, 2003:

2:21 PM Changeset in webkit [5854] by darin

• 2 edits in trunk

Tweak some old ChangeLog entries (mostly removed "removed by me").

8:56 AM Changeset in webkit [5853] by darin

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix change log entry.

7:57 AM Changeset in webkit [5852] by darin

• 2 edits in trunk/WebCore

• one more small step to make -[KWQPageState dealloc] safer

• kwq/KWQPageState.mm: (-[KWQPageState dealloc]): Only do the real detach() if the document is already in the detached state; we don't want to detach twice.

Dec 23, 2003:

5:50 PM Changeset in webkit [5851] by sullivan

• 5 edits in trunk

JavaScriptCore:

• JavaScriptCore.pbproj/project.pbxproj: Xcode version wars, harmless

WebCore:

• fixed <rdar://problem/3451306>: address book search fails at Airborne Express Corporate site (Apple Shipping wants to use it)

Reviewed by Darin.

• khtml/ecma/kjs_html.cpp: commented out definition of document.all; now sites like this one that set document.all to a value will work.
• khtml/ecma/kjs_html.lut.h: (KJS::): regenerated this file

4:37 PM Changeset in webkit [5850] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by John (concept, not code, which is just the old code coming back).

• fixed 3518092: REGRESSION (100-119): getting NaN instead of HH:MM times

• kjs/date_object.cpp: Added back our CF-based implementations of gmtime, localtime, mktime, timegm, and time, because mktime, at least, won't handle a year of 0.

3:52 PM Changeset in webkit [5849] by darin

• 1 edit in trunk/WebKit/ChangeLog

Fix some old malformed log entries.

3:52 PM Changeset in webkit [5848] by darin

• 6 edits in trunk/WebCore

Reviewed by John.

• another try at fixing the -[KWQPageState dealloc] bug, even though we don't fully understand it

This change saves the renderer inside the document rather than in the KWQPageState to
try to eliminate the possibility that multiple KWQPageState objects could restore the
same renderer multiple times, resulting in multiple detaches of the same renderer.

• khtml/xml/dom_docimpl.h: Add a m_savedRenderer field.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_savedRenderer to 0. (DocumentImpl::~DocumentImpl): Added some asserts to make sure we don't get destroyed while we are in the page cache. (DocumentImpl::attach): Added an assert. (DocumentImpl::setInPageCache): Save the renderer when setting the flag, and restore the renderer when clearing it.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Instead of doing a restoreRenderer call, just do setInPageCache(NO), which will restore the renderer as a side effect.

• kwq/KWQPageState.h: Removed the renderer method and field.
• kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): Don't store a pointer to the renderer. (-[KWQPageState clear]): New method, shared by invalidate and dealloc. (-[KWQPageState invalidate]): Removed code relating to "relinquishing object ownership"; just deallocate everything here without doing a detach(). (-[KWQPageState dealloc]): Removed restoreRenderer now that setInPageCache(NO) handles that. Added some assertions. Share code with invalidate by calling clear.